GNU bug report logs - #33698
[PATCH 0/2] Update emacs-cider.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33698 in the body.
You can then email your comments to 33698 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Mathieu Lirzin <mthl <at> gnu.org>
Subject: [PATCH 0/2] Update emacs-cider.
Date: Mon, 10 Dec 2018 23:17:04 +0100

Mathieu Lirzin (2):
  gnu: Add emacs-sesman.
  gnu: emacs-cider: Update to 0.18.0.

 gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

-- 
2.19.2

Message #8 received at 33698 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: 33698 <at> debbugs.gnu.org
Cc: Mathieu Lirzin <mthl <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add emacs-sesman.
Date: Mon, 10 Dec 2018 23:20:21 +0100

* gnu/packages/emacs.scm (emacs-sesman): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 13588bf01..e25f558c9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -12729,3 +12729,26 @@ Emacs.")
 rooms.  It also provides an API which allows Emacs to seamlessly create
 RPC channels with users and other software.")
       (license license:gpl3+))))
+
+(define-public emacs-sesman
+  (package
+    (name "emacs-sesman")
+    (version "0.3.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/vspinu/sesman/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1y1drawdc24c026jhr1zi279n0vdm5ais4smkxqis4s0i9k5g67g"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/vspinu/sesman")
+    (synopsis "Generic Session Manager")
+    (description
+     "Sesman provides facilities for session management and interactive session
+association with the current contexts (project, directory, buffers etc).  See
+project's readme for more details.
+")
+    (license license:gpl3+)))
-- 
2.19.2

Message #11 received at 33698 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: 33698 <at> debbugs.gnu.org
Cc: Mathieu Lirzin <mthl <at> gnu.org>
Subject: [PATCH 2/2] gnu: emacs-cider: Update to 0.18.0.
Date: Mon, 10 Dec 2018 23:20:22 +0100

* gnu/packages/emacs.scm (emacs-cider): Update to 0.18.0.
---
 gnu/packages/emacs.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e25f558c9..238de9f3a 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5206,7 +5206,7 @@ target will call @code{compile} on it.")
 (define-public emacs-cider
   (package
     (name "emacs-cider")
-    (version "0.15.1")
+    (version "0.18.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -5215,7 +5215,7 @@ target will call @code{compile} on it.")
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "1j5hlmi14ypszv1f9nvq0jjlz7i742flg0ny3055l7i4x089xx6g"))))
+                "1l645ks1wl632v7rkyc43ncl6p7svcmfbrcxcwvnnlznj3fqm3iq"))))
     (build-system emacs-build-system)
     (arguments
      '(#:exclude                        ; Don't exclude 'cider-test.el'.
@@ -5223,6 +5223,7 @@ target will call @code{compile} on it.")
     (propagated-inputs
      `(("emacs-clojure-mode" ,emacs-clojure-mode)
        ("emacs-spinner" ,emacs-spinner)
+       ("emacs-sesman" ,emacs-sesman)
        ("emacs-pkg-info" ,emacs-pkg-info)
        ("emacs-queue" ,emacs-queue)))
     (home-page "https://cider.readthedocs.org/")
-- 
2.19.2

Message #14 received at 33698 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: mthl <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 33698 <at> debbugs.gnu.org
Subject: [PATCH v2 0/2] Update emacs-cider
Date: Tue, 11 Dec 2018 12:21:44 +0530

I've made several modifications to your patches. Most notably, I have changed
the synopsis and description of emacs-sesman. I have switched both
emacs-sesman and emacs-cider to using git-fetch. We do this now because
auto-generated github tarballs are unstable and cause hash mismatch errors. I
also enabled tests for emacs-sesman and made a few other minor stylistic
changes.

Let me know if the updated patches are fine. If they are, I will push them to
master.

Mathieu Lirzin (2):
  gnu: Add emacs-sesman.
  gnu: emacs-cider: Update to 0.18.0.

 gnu/packages/emacs.scm | 50 ++++++++++++++++++++++++++++++++----------
 1 file changed, 39 insertions(+), 11 deletions(-)

-- 
2.19.2

Message #17 received at 33698 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: mthl <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 33698 <at> debbugs.gnu.org
Subject: [PATCH v2 1/2] gnu: Add emacs-sesman.
Date: Tue, 11 Dec 2018 12:21:45 +0530

From: Mathieu Lirzin <mthl <at> gnu.org>

* gnu/packages/emacs.scm (emacs-sesman): New variable.

Signed-off-by: Arun Isaac <arunisaac <at> systemreboot.net>
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 13588bf01..a7fbd7657 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -12729,3 +12729,29 @@ Emacs.")
 rooms.  It also provides an API which allows Emacs to seamlessly create
 RPC channels with users and other software.")
       (license license:gpl3+))))
+
+(define-public emacs-sesman
+  (package
+    (name "emacs-sesman")
+    (version "0.3.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/vspinu/sesman.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0r32f8ma9ddczxrrdz0nadp14j3zmk10q1ch02gb82synkx3xdra"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:tests? #t
+       #:test-command '("make" "test")))
+    (home-page "https://github.com/vspinu/sesman")
+    (synopsis "Session manager for Emacs based IDEs")
+    (description "Sesman provides facilities for session management and
+interactive session association with the current contexts (project, directory,
+buffers).  While sesman can be used to manage arbitrary sessions, it primary
+targets the Emacs based IDEs (CIDER, ESS, Geiser, Robe, SLIME etc.)")
+    (license license:gpl3+)))
-- 
2.19.2

Message #20 received at 33698 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: mthl <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 33698 <at> debbugs.gnu.org
Subject: [PATCH v2 2/2] gnu: emacs-cider: Update to 0.18.0.
Date: Tue, 11 Dec 2018 12:21:46 +0530

From: Mathieu Lirzin <mthl <at> gnu.org>

* gnu/packages/emacs.scm (emacs-cider): Update to 0.18.0.
[source]: Use git-fetch.
[propagated-inputs]: Add emacs-sesman.
[home-page]: Update URI.

Signed-off-by: Arun Isaac <arunisaac <at> systemreboot.net>
---
 gnu/packages/emacs.scm | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a7fbd7657..358f32cab 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5206,26 +5206,28 @@ target will call @code{compile} on it.")
 (define-public emacs-cider
   (package
     (name "emacs-cider")
-    (version "0.15.1")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/clojure-emacs/cider/archive/v"
-                    version ".tar.gz"))
-              (file-name (string-append name "-" version ".tar.gz"))
-              (sha256
-               (base32
-                "1j5hlmi14ypszv1f9nvq0jjlz7i742flg0ny3055l7i4x089xx6g"))))
+    (version "0.18.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/clojure-emacs/cider.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1m9kc88vga3q5d731qnpngnsa0n57pf21k3hll20rw8rggrx4vdn"))))
     (build-system emacs-build-system)
     (arguments
      '(#:exclude                        ; Don't exclude 'cider-test.el'.
        '("^\\.dir-locals\\.el$" "^test/")))
     (propagated-inputs
      `(("emacs-clojure-mode" ,emacs-clojure-mode)
+       ("emacs-sesman" ,emacs-sesman)
        ("emacs-spinner" ,emacs-spinner)
        ("emacs-pkg-info" ,emacs-pkg-info)
        ("emacs-queue" ,emacs-queue)))
-    (home-page "https://cider.readthedocs.org/")
+    (home-page "https://cider.readthedocs.io/")
     (synopsis "Clojure development environment for Emacs")
     (description
      "CIDER (Clojure Interactive Development Environment that Rocks) aims to
-- 
2.19.2

Message #23 received at 33698 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 33698 <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/2] Update emacs-cider
Date: Tue, 11 Dec 2018 09:51:24 +0100

Hello Arun,

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> I've made several modifications to your patches. Most notably, I have changed
> the synopsis and description of emacs-sesman. I have switched both
> emacs-sesman and emacs-cider to using git-fetch. We do this now because
> auto-generated github tarballs are unstable and cause hash mismatch errors. I
> also enabled tests for emacs-sesman and made a few other minor stylistic
> changes.
>
> Let me know if the updated patches are fine. If they are, I will push them to
> master.

Excellent, thanks for polishing the patches and letting me know about
the ‘git-fetch’ policy change.  I saw various commits in the Git log
doing such changes without understanding the goal since commit messages
don't include any context/rationale.

Please go ahead.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Message #28 received at 33698-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Mathieu Lirzin <mthl <at> gnu.org>
Cc: 33698-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/2] Update emacs-cider
Date: Tue, 11 Dec 2018 23:14:50 +0530

Pushed to master. Thanks! :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.