From unknown Tue Aug 19 18:06:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33695 <33695@debbugs.gnu.org> To: bug#33695 <33695@debbugs.gnu.org> Subject: Status: 27.0.50; which-function reports wrong imenu information Reply-To: bug#33695 <33695@debbugs.gnu.org> Date: Wed, 20 Aug 2025 01:06:57 +0000 retitle 33695 27.0.50; which-function reports wrong imenu information reassign 33695 emacs submitter 33695 Alex Branham severity 33695 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 13:58:45 2018 Received: (at submit) by debbugs.gnu.org; 10 Dec 2018 18:58:45 +0000 Received: from localhost ([127.0.0.1]:42154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWQlR-0004qo-FT for submit@debbugs.gnu.org; Mon, 10 Dec 2018 13:58:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWQlP-0004qa-PZ for submit@debbugs.gnu.org; Mon, 10 Dec 2018 13:58:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWQlI-0005tQ-Fh for submit@debbugs.gnu.org; Mon, 10 Dec 2018 13:58:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWQlI-0005tI-C7 for submit@debbugs.gnu.org; Mon, 10 Dec 2018 13:58:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWQlG-0001Ea-L2 for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 13:58:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWQlD-0005rQ-G3 for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 13:58:34 -0500 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]:40714) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gWQlD-0005p8-3m for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 13:58:31 -0500 Received: by mail-oi1-x22c.google.com with SMTP id t204so9873811oie.7 for ; Mon, 10 Dec 2018 10:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=ujMIxuldp7cBjrWOrR9idk1IVLrzFhXXjgS3Hl3Mbi8=; b=PS3SJVEK+4izSxKkZ3EySWcjL8wuuk2XnJudvdE7+gOnKx3D6ZxAIDBw3XIjza0TgH cBAoN0Es/YV0WPvtgtTp9xDCTkXtbBD0iKiFlYVZ47N6c+JKzf7908KUUdnNLTYE2XBt EKqk+qSzCNabD3Lsx33kOjzEXL2x7okbq/+hZbL8LU0MAcSPBcJnj/KfU6o5LAUSoIRw JxMJq1HBv4/TiyC43nlwNoQ6mJ8GUM/5uASlWw8O/Jls1/uoCjuJWuFn5vsVf/P8rQsu RoNmItxFQMs+vw0fWJFFyak2n7g/OAxumEUTf3tsn1Ja8yJ4degBQknBajQxoeoMf71j gs3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=ujMIxuldp7cBjrWOrR9idk1IVLrzFhXXjgS3Hl3Mbi8=; b=dkFUcR4g3iN5Z32/fta5z0GXrqTLsggnU4x81wD6yrPyh/gvtSVypReCsHh2Jbs9qM gVYM7dDH512jT6WdMLNxpDY/8vYFzRPWFAGT2px/LvjcjAUpD+Zcz8iABtbXqWwJEbA2 sTL8/c/cFR/KHTLUvcN8bsY2471qfQeuou+66icGB4DlqBw/XtQOFMAWvfhE4OjjSayC CcHVHUGpkNv243LqtXPFBA9Vo9yZOIIFWm1Sa0QCv0XMu8zfI9bXY861bBIyy4YmhzW7 utKIiuUiazUDJgH9sdkP18UYgzj5tTc+JFFaSZ0JLGF9LqucMbKL7xty6zJass/JKOuD LNcw== X-Gm-Message-State: AA+aEWbZ74uKK8DYYOBdLJ4vF0R5KBJJ1Ox2lpO/FJiUUVWT8t3/Glhg DhLSUTtnQcs+wO3SgYL1XGCsCt0V X-Google-Smtp-Source: AFSGD/XvlhjF0D04cks+MODXeaVkZ1Kw/1/VfLkAGSey463DBEXgjc2kz0bfefInvNeONnJwNStGMw== X-Received: by 2002:aca:f389:: with SMTP id r131mr8397210oih.58.1544468307792; Mon, 10 Dec 2018 10:58:27 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id 18sm8786121otf.59.2018.12.10.10.58.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 10:58:27 -0800 (PST) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: bug-gnu-emacs@gnu.org Subject: 27.0.50; which-function reports wrong imenu information Date: Mon, 10 Dec 2018 12:58:25 -0600 Message-ID: <87tvjlmcoe.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) (which-function) can report outdated information because it relies on imenu--index-alist. To see what I'm talking about, from emacs -q: M-x which-function-mode RET type: (defun test () "foo" (ignore)) M-x imenu *Rescan* RET C-g type: (defun test2 () "bar" (ignore)) With point inside test2, (which-function) reports test (you'll see this in the modeline) because it uses the (outdated) information in `imenu--index-alist'. I see a few potential fixes: - Check `add-log-current-defun' before checking `imenu--index-alist' in `which-function' (easy, but falling back on imenu--index-alist could still report old info) - Have `which-function' update `imenu--index-alist' before checking it (also easy to implement, but updating the index could be slow in large buffers) - Something else I'm happy to write up a patch, just let me know what solution is best. Thanks, Alex From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 03:35:21 2018 Received: (at 33695) by debbugs.gnu.org; 11 Dec 2018 08:35:21 +0000 Received: from localhost ([127.0.0.1]:42770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWdVg-0001JE-Og for submit@debbugs.gnu.org; Tue, 11 Dec 2018 03:35:20 -0500 Received: from mout.gmx.net ([212.227.17.21]:34793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWdVf-0001Iu-16 for 33695@debbugs.gnu.org; Tue, 11 Dec 2018 03:35:19 -0500 Received: from [192.168.1.101] ([212.95.5.96]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LoaCE-1h7btS2umg-00gc1h; Tue, 11 Dec 2018 09:35:12 +0100 Message-ID: <5C0F76BC.6080001@gmx.at> Date: Tue, 11 Dec 2018 09:35:08 +0100 From: martin rudalics MIME-Version: 1.0 To: Alex Branham , 33695@debbugs.gnu.org Subject: Re: bug#33695: 27.0.50; which-function reports wrong imenu information References: <87tvjlmcoe.fsf@gmail.com> In-Reply-To: <87tvjlmcoe.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:dU77pqbMejO1qf78q6ps0T/GdhmCga2XCDWYF/ig1Ep4UBu0QgA W0JQ5hNfuFZTVonYTAcz8I0H/U6CwQXGn4y9qH1tAQB2qgWEPIFAwTJhZBAqMeeRRoOEgnx m9RU2ztov6N6KvWvKdyUGukcAehpnpQoVKrvP4f2vvxqspBR9DMJ+jcrDEaDmDnJxWW1YBe Na9oZ9HA0z0Y4pfdrG9OA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4GG6sqUVCqU=:CgZnZKRf9Wnd9V+k9IChqm EHeDYgCZO1BFF1JU6mfeAgydhXGIIT5BOitkkJ7ag5VgKIUZiZzwHIbY4zTZ9n10IFAjHZ65J zEXPHmCOVHcG5qS0yWRiCV5qezPkPQ8aR1uLgRrZfjGVJjfGkkvniNCVjCBTtEzXzr0vOTv3V 2nVqd+xBHgU4w1XJaWcghKVYvlbxD12YgACZLRUwzDN2nporJ3x9XokijkdodaoPsWNcDEIQD s9maopAD+Ae1OXWVBVSKaRSey28SlEgeC8rqkfXPlt9iXzO2BObVm06kbz0NyLQO0L3e3OW+v 0Mh10QRoPMOT0J/UB8xlTp3NKVTXFSJY1w3FFGW+n5wGmqeVY5e2NGAOKgFW5LBgpROAtlMfs k6nWs/5ztTGlPMDm3CuH+WwPF6WUwgvOqno77uuHODgqEuwf/xSbEUQu83Pks2qtdpNf6i7FI g2WgyzW8TjkXkPEr8cyQ2MdqAzaad2f5z3vO57EF0NjKdaWmOBrbFkrIGwT7/i5BR39ZWMxSr jDmXln+T0qSfC+C8Hqs/HuHKCLXdyNoqAdtq0+sZvI3N8AMmjwQQHd6A4cKBRJp7A9deQfOLC KpDLRIbcTWIj4TklJfkTS8Kalc7KrpWgMI2ORrm8NuPZlb3yEPM8EJGyCPx9nSj4OxRhB/dKS xRfuRvbixDPtyQl8bedXsZARZJadIo7h69nnxJdpKdt70TM5u+DWTOSkuhRxjuZrvyKER46Vn tl6MvisNEKD5mHmHje26mb/SJhVQUxma3fS7WlMdr4ZWxt1+kG7ozQcgkKeS+9S3WhS15idpw OCOpfAFhjQB3KJ8n1A5KzPTY7Dox4GmwQWhdBMxWhB4pHJAyutJ+O4mciR8zSOANOsGNuz+nX rsYbjmHs5PB+imMV6pY4uHpDUDxiGuJuXjYMzqwPkg1F2jm5gripKk9xo8siTy X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33695 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > - Have `which-function' update `imenu--index-alist' before checking it > (also easy to implement, but updating the index could be slow in large > buffers) Maybe we should try to do what 'imenu-update-menubar' does here: Compare the values of 'imenu-menubar-modified-tick' and 'buffer-chars-modified-tick' and update 'imenu--index-alist' if they differ. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 09:33:07 2018 Received: (at 33695) by debbugs.gnu.org; 11 Dec 2018 14:33:07 +0000 Received: from localhost ([127.0.0.1]:42906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWj5u-0004Mt-MW for submit@debbugs.gnu.org; Tue, 11 Dec 2018 09:33:06 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:35895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWj5s-0004ML-Kb for 33695@debbugs.gnu.org; Tue, 11 Dec 2018 09:33:05 -0500 Received: by mail-ot1-f41.google.com with SMTP id k98so14205308otk.3 for <33695@debbugs.gnu.org>; Tue, 11 Dec 2018 06:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=WRv4SYLvmp74xKMcJ+MrL0CjjiaBS34jWa70dLE8BYU=; b=CVjwrNqLHIBVfwBVKnWRqrZJCobi6YqimMxJbaNoBS+mYDUU4vgOlVrlntfZW6R+K+ 9YamCq5DCGwM7FhKO/uAjW51Vw22mIbVdlXxVlOyHQK4mLQm/YeayqL0r/NMXDPA9Xe5 zsePF4nHK6vc42Jp+qnBGhzPlPgpaL06OuLmJsUI80TBePJa9+QM0+EdMGuy0hKkd6j/ hWEM8a3bUr8tQDeA0pO4PlIq2vp4qChXUoOePIHGuwQLM+jJL+ibwMLz0fc3D1NjdbpJ jYj7c1T69ks/j8ATkzhujCgs4rN1B4PcyYifD6KrSezZ+rBVSsXeddl72zLzL+wn6Kda Knug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=WRv4SYLvmp74xKMcJ+MrL0CjjiaBS34jWa70dLE8BYU=; b=dUTBR9mEGyovCjF//e1fzZ8xkEM6fWHVEenETpNr+zIZZm4Zm22Lq5zjAmXXidHm7W AxugsSsMNrot9eFo4B4IeYtjSScur1uabcExNoisEI9uUylY/3+4kuyTNS1+fWxj4Db/ OtYif79rmsuMBL+ZhF7QAtN0qjUy6nOXbngl8BUnjFqXehaOR5fY1MutZEGUai1hSQhD +jiHfQnPkd7LV7ri1HIxNnJNiqbn+pfMdrzeAEZzA32ntgxXtlY4+9D615YfqtAw5DOT i5M0HXA4QeZJ1KBQCq+ociuVC33wUOOZzrh2D6OFWPofrnN6yNVGF9th+QbJF6muutDy E5qQ== X-Gm-Message-State: AA+aEWbarR8Pmjeuf8r7BDZbwNppba6uiT9R5wcV7wZdCYlAFsYTiyjZ qI896+ike2cFkFR+qLIZlW8bDKmx X-Google-Smtp-Source: AFSGD/XRjLJy3qpyI2gQxxtR1dP/31SUdDYgOth9g8F1cWnStj5A/dwfqidYOdKtVpafWcuFs5latg== X-Received: by 2002:a9d:39f7:: with SMTP id y110mr10770946otb.240.1544538778514; Tue, 11 Dec 2018 06:32:58 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id f127sm7896073oia.19.2018.12.11.06.32.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Dec 2018 06:32:57 -0800 (PST) References: <87tvjlmcoe.fsf@gmail.com> <5C0F76BC.6080001@gmx.at> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: martin rudalics Subject: Re: bug#33695: 27.0.50; which-function reports wrong imenu information In-reply-to: <5C0F76BC.6080001@gmx.at> Date: Tue, 11 Dec 2018 08:32:54 -0600 Message-ID: <87mupcm8vd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33695 Cc: 33695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue 11 Dec 2018 at 02:35, martin rudalics wrote: >> - Have `which-function' update `imenu--index-alist' before checking it >> (also easy to implement, but updating the index could be slow in large >> buffers) > > Maybe we should try to do what 'imenu-update-menubar' does here: > Compare the values of 'imenu-menubar-modified-tick' and > 'buffer-chars-modified-tick' and update 'imenu--index-alist' if they > differ. Thanks for the reply. This seems to work well, though I haven't tried it in an enormous buffer. Alex >From d794595fdbaff40df2f7769b22dd05a7786e56e7 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 11 Dec 2018 08:29:50 -0600 Subject: [PATCH] which-function: Do not display outdated imenu information * lisp/progmodes/which-func.el (which-function): Update imenu--index-alist if needed. Bug #33695 --- lisp/progmodes/which-func.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el index 7604be0c25..bbdfa2fff7 100644 --- a/lisp/progmodes/which-func.el +++ b/lisp/progmodes/which-func.el @@ -281,7 +281,10 @@ which-function ;; If Imenu is loaded, try to make an index alist with it. (when (and (null name) - (boundp 'imenu--index-alist) (null imenu--index-alist) + (boundp 'imenu--index-alist) + (or (null imenu--index-alist) + ;; Update if outdated + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) (null which-function-imenu-failed)) (ignore-errors (imenu--make-index-alist t)) (unless imenu--index-alist -- 2.19.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 03:31:58 2018 Received: (at 33695) by debbugs.gnu.org; 12 Dec 2018 08:31:58 +0000 Received: from localhost ([127.0.0.1]:44479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWzvy-0004QY-Js for submit@debbugs.gnu.org; Wed, 12 Dec 2018 03:31:58 -0500 Received: from mout.gmx.net ([212.227.15.19]:60747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWzvu-0004QB-9z for 33695@debbugs.gnu.org; Wed, 12 Dec 2018 03:31:54 -0500 Received: from [192.168.1.101] ([213.162.73.37]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MGjfl-1gbisf07TF-00DU90; Wed, 12 Dec 2018 09:31:48 +0100 Message-ID: <5C10C76D.2090702@gmx.at> Date: Wed, 12 Dec 2018 09:31:41 +0100 From: martin rudalics MIME-Version: 1.0 To: Alex Branham Subject: Re: bug#33695: 27.0.50; which-function reports wrong imenu information References: <87tvjlmcoe.fsf@gmail.com> <5C0F76BC.6080001@gmx.at> <87mupcm8vd.fsf@gmail.com> In-Reply-To: <87mupcm8vd.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:AAurtjeZ6RhzknZSXuLCJig8HtO9p4wK5nhvY5NKQ0Cee5ef2Ud Bzsx1QVWouKqA1Kzc+sNZHAClQApKSt9SbV3TmaeiaH/mpDxZGCl/h5XQUujgDy+OcCrAJ2 ziTGpvZ9KDCohXZgqUXafDi7QAbvsbuP16v23GQgFbK+OFH1PE0ThccNlQ7sAWE5bzy/waF dBRiK4h+2g9pnWo1+c9zA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JnURTSELDp8=:1DCOs4UtBvw5HZO5F8JmZI wuRlzv+hmHkqjJgmblHrfI4iY6U82mxpcOYKpXljNko41kgKfolaqPY3gtjm3JhGKmjtJ/FwO KdN93J+Ozorad37SU3LY+qH4G/lrARX/LBOB2ff7l8mSYNPGghAU8V2y1qWNbC0hKljL80ikN Dqqi1LyP+6HBysUCJjt4NU2flUHsvcOapoY3cBFLZSBvTfkZp0c+ySbgUts0VvV8KUB8N7B2n hNdstMwmxQp0cM60aqsONWosp7ttz6+t8JsOILB9xWN1vWH/bZ/S4/HY1MD/qKT3a4cCR477T cX2+X9iJvYxDkLO81f646QiyX1ZZR6irJ1nmmmUUeK6z5jMNuop+ajYyLwZ2ICjPpdwva+GoB UvdZYS4HsBmLsdKWAXwdsUC3p/69Gs+HYfv8mmqm2GYaV7EVeoRXkAyDNuHCKkqfblh9ChL5H RIfCJ2CNOigfvm64YE4fQbER0ugumMDAo14evy6Svpt53qC2+AGzdiWd9ijpBXXKJ7E4lf0Dj X1uTYSdQnxzlDC+iWHBI5yrOy1zQbF/V3+Fzj1jo4r+4nO14vjFh6gacesVSwbCcf9DWUqHZA KgPImozjPhi3wxsYZQBxGQ941FPo4zm4/RWyFq7+3livieq5FrwYle1AXH51WAqpYczktHbFS SEnHewDvh5aO4Gn7uzCE3E3ZavqRg3EOX4cTBQ1c0fQFtVlALpyH+GKlhthAKIL6bwzltozsu N7pzmWHN7DSgYrDuCzZeHQVLsLla48UtrB5SPKG+ieaxsXd+32RMOe0Ok5lrF5YFJxJJK5Jfq zAByCFQniPuTCQczY1el1LDbTRPv1SRq2eX+TWeUokN0n9DPpULZdGP8BOsQG3x91pTxyU5P4 G/R1NeQ2LMZwHG0NPoHJ8TKCR5k6YBsLkZ7XgyqyW3uwCBSVEf4HqK53QmzrnHo2FjC7+qgmD sXBsJ3ThI+Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33695 Cc: 33695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks for the reply. This seems to work well, though I haven't tried it > in an enormous buffer. Maybe we should make it optional so people on slower machines have the choice. I have no opinion because I don't use 'which-func-mode' hence people who do should chime in. For me the idea of calculating all function position in a buffer and afterwards have 'which-func-mode' scan them to find out which function point is in, strikes me as enormous over-kill. In particular with 'syntax-ppss' around which usually should, without any additional cost, provide the position where the current functions starts via the 9th element of its return value. But don't let these rantings distract you. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 12 17:54:10 2018 Received: (at 33695) by debbugs.gnu.org; 12 Dec 2018 22:54:10 +0000 Received: from localhost ([127.0.0.1]:45614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXDOM-0007tz-2Z for submit@debbugs.gnu.org; Wed, 12 Dec 2018 17:54:10 -0500 Received: from mail-oi1-f177.google.com ([209.85.167.177]:38728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXDOK-0007tj-Ac for 33695@debbugs.gnu.org; Wed, 12 Dec 2018 17:54:08 -0500 Received: by mail-oi1-f177.google.com with SMTP id a77so83118oii.5 for <33695@debbugs.gnu.org>; Wed, 12 Dec 2018 14:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=xcqqSGqXNGVmfxQw/mjDXYfoGb89YKG3FrMIZkviXR0=; b=trS3m5aQVDH/eDVSkaN7VubKBUfvHy5HAEKspUb+BF1kPGCYm2ITTBPmDeP47eq1GX OUER4hQAEkSE0XxKE45TDc1hATZmY7knqBS/G2n/bCo8AjA627wVHEvRv+Utsgtsak2x aw5yzQO22PEAHwuTirYsJnkm48jYLugdTD+5pgPuDcpRu+Hd+PJ6DWEb9liF64Ti+qn3 uDTz5opt2v/Z9gmbuA4sFESYcg7GLGr4Woslr7p6Ni/5DTol+VYx08ZlMbixOqM0PCP4 JCWeI8xOcCfRJ9/WJ7tbdk+MhFosxljCKVCQRK5YrO6Kpy10KBn4dOInqOOfTJq2x8uz 67OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=xcqqSGqXNGVmfxQw/mjDXYfoGb89YKG3FrMIZkviXR0=; b=ULW4D63HgI4k0Vgw+hOg9/12au/1mufgm9JYZyQR8hv2AIhq676vGtM2XWSYK94dK7 BrsA3zOd8FWZHXeQkXORqeqKY2640tvMdfvQI63EIZpCq9nPqP4qwIbdJomICzku9fH7 9gxMYGeySqW63jgWk3wwZKHreOLd9HnnDD2M8LVFVTfxpoBW3dtKeIDplBL8tSj8vSCc EQXyoQny9K4bacr0pQ3/HF/LuPSTBY9aYpYTxKyC/OjSBHYkLX10b8cv6XiBmi8oxON8 3A+lume1IKXCtv9eJhF7RYEGDSHbh9uL80JBXdyMx/mJ6jxIQKIpKd0KgF9rE+A0L/Qx FZhQ== X-Gm-Message-State: AA+aEWbvbYOSWjTpsJINOM0HbKrBaIQZpxxIIi8VSmEXcekosEio79Ud xCi/EPM36LjF56AmdFXWXu8aiZop X-Google-Smtp-Source: AFSGD/X03kLsvtjsAC0qEIhu2Q5D84JNqJJblOkMzh3X6fAu6K5qy28sEq5HVa7iJQcuzNaS7T92aQ== X-Received: by 2002:aca:5406:: with SMTP id i6mr1589290oib.344.1544655242289; Wed, 12 Dec 2018 14:54:02 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id t21sm39840otq.67.2018.12.12.14.54.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Dec 2018 14:54:01 -0800 (PST) References: <87tvjlmcoe.fsf@gmail.com> <5C0F76BC.6080001@gmx.at> <87mupcm8vd.fsf@gmail.com> <5C10C76D.2090702@gmx.at> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: martin rudalics Subject: Re: bug#33695: 27.0.50; which-function reports wrong imenu information In-reply-to: <5C10C76D.2090702@gmx.at> Date: Wed, 12 Dec 2018 16:53:59 -0600 Message-ID: <87o99qcq60.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33695 Cc: 33695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed 12 Dec 2018 at 02:31, martin rudalics wrote: >> Thanks for the reply. This seems to work well, though I haven't tried it >> in an enormous buffer. > > Maybe we should make it optional so people on slower machines have the > choice. I have no opinion because I don't use 'which-func-mode' hence > people who do should chime in. > > For me the idea of calculating all function position in a buffer and > afterwards have 'which-func-mode' scan them to find out which function > point is in, strikes me as enormous over-kill. In particular with > 'syntax-ppss' around which usually should, without any additional > cost, provide the position where the current functions starts via the > 9th element of its return value. But don't let these rantings > distract you. That won't help with non-lispy languages like R or python though, I don't think. Perhaps we should reverse the order of what which-function checks? It currently looks at: 1. which-func-functions 2. imenu--index-alist 3. add-log-current-defun but we could switch those last two. add-log-current-defun should be faster than reconstructing imenu--index-alist. Alex From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 13 04:01:37 2018 Received: (at 33695) by debbugs.gnu.org; 13 Dec 2018 09:01:37 +0000 Received: from localhost ([127.0.0.1]:45791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXMsD-0006Ff-0Y for submit@debbugs.gnu.org; Thu, 13 Dec 2018 04:01:37 -0500 Received: from mout.gmx.net ([212.227.17.21]:60963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXMsA-0006FO-Rp for 33695@debbugs.gnu.org; Thu, 13 Dec 2018 04:01:35 -0500 Received: from [192.168.1.101] ([213.162.73.124]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MgXCF-1glR5L0ECt-00NzJS; Thu, 13 Dec 2018 10:01:28 +0100 Message-ID: <5C121FDE.5070705@gmx.at> Date: Thu, 13 Dec 2018 10:01:18 +0100 From: martin rudalics MIME-Version: 1.0 To: Alex Branham Subject: Re: bug#33695: 27.0.50; which-function reports wrong imenu information References: <87tvjlmcoe.fsf@gmail.com> <5C0F76BC.6080001@gmx.at> <87mupcm8vd.fsf@gmail.com> <5C10C76D.2090702@gmx.at> <87o99qcq60.fsf@gmail.com> In-Reply-To: <87o99qcq60.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:cgBG+qfJVxztQEae5klYlT5aP1RfJzx6F+uTm05SgDOsHTBMPm9 awm4ErAJKr/YUSSShDO1HrMmmxlmdd8mWbWIcwsqFqms2v9kOGRaDFAeUR0oN6cYAMPP9JD eyGiTBa+EyDw3p82d9iHn2f9FrFnlrqhc5PvJfFBdMmU7/FmPYB2agBV6JPuYmozxS5i1/f +fK4M4t+aTTxb4HMdUfvQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:YcY+2E2gq1M=:1UuQK3kqMxUouE+OhKfvVm 2HdLlF8jacBqHs/Bm6mgeXtM1Z1GcPPp0tDnnfe4NOTlLGT+oVFjcfxEM7CXSFgLXWrBMMf4B ZS39NmD+v97a9yn3hIJMOyNMPOCP5/qY7NgS1cZ5W/5jQGw64YZ9OIWO6CRF91V9HxFwnbpx5 Xq9vbgwuVqV7Rhq5PncFNIPAYwo16hm0b/35CjtruxqtpK9pPIR4c/90R4lmxZsBmP23dLRH1 Np1X8zRjJ0f9I7tJoY0vp7AfNZQP7lMyWfPVs5D8Zng/xskUmW0YICYqI4w0X4qw62BzZvDgX 8ZMFs3wkiA8Ul1SBaf6CuKqp4ZpUWJUzbNP0C8tDqLpXLTbp7ed0gHKQ2NI3dapR1SnH+eC6/ UtkQCzIiCK1/m7MytUHYrK8kobD/HKhJStszFFQMdmEf+63QvY9sGQtz9CboqAnv4Ntm4UhQC 5G9OeQjnTgxCp0igfXh5aA0h9Ejja2589z37Pv383dJW+jw/+f5VrMBRAES+L/SoRVODF6sAS Oac+ayxVHFMbU8PyI1fiTT9hPIrzw3fMSPqCmeay7tk3QjSc7xP7w1fuxO21R78rkxLCPKk7m /KrznVXC56JEUgGKSyFS4JtrkMWqw17GtvJMR17Fhz4d7OejZ613Gt+AuOzAgIKZ1v9huXlOT dDGzJLLDU5simv3f0F7WM7VW0znw/2lKs7/4iDKXNZMBsDaoJrBlX0bQs0wms3Zl2ZXj4R1uU Ku3gDQ61aZEQ0SDWgB55NTAvwDunXiNH6s5PaxV/xQPElhdP3n4L1UvdadOEs/9DAtorLmJcc hy7rMLXGr5AvWd8eSKyIhrMeQq427kR2xEw9CcvKJRtoTufkB8fkz7xI3WSyVgC8i/RH+zbqE iV1mQfHsXlg49im61+k3z2kxsRoZvWZCbsss2g6Oybhqvm0Pgn9GpWnnmv1M1W X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33695 Cc: 33695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> For me the idea of calculating all function position in a buffer and >> afterwards have 'which-func-mode' scan them to find out which function >> point is in, strikes me as enormous over-kill. In particular with >> 'syntax-ppss' around which usually should, without any additional >> cost, provide the position where the current functions starts via the >> 9th element of its return value. But don't let these rantings >> distract you. > > That won't help with non-lispy languages like R or python though, I > don't think. IIUC 'python-info-looking-at-beginning-of-defun' uses 'syntax-ppss' while for example 'c-beginning-of-defun' doesn't. I understand that the implementors of which-func chose the most simple existing way to get the function point is in. But it amounts to having 'beginning-of-defun' always construct a list of the positions of all function definitions in a buffer to find the first one before point. With wich-func a user won't notice the effect because it's done when Emacs is idle. Still it's not ecological. > Perhaps we should reverse the order of what which-function checks? It > currently looks at: > > 1. which-func-functions > 2. imenu--index-alist > 3. add-log-current-defun > > but we could switch those last two. add-log-current-defun should be > faster than reconstructing imenu--index-alist. I think so. But I'm afraid it's not well supported everywhere. Anyway, as I already said don't let my remarks distract you. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 19 10:43:03 2018 Received: (at 33695) by debbugs.gnu.org; 19 Dec 2018 15:43:03 +0000 Received: from localhost ([127.0.0.1]:54985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZdzz-0001jV-3P for submit@debbugs.gnu.org; Wed, 19 Dec 2018 10:43:03 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:41682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZdzw-0001j0-Hn for 33695@debbugs.gnu.org; Wed, 19 Dec 2018 10:43:01 -0500 Received: by mail-oi1-f195.google.com with SMTP id j21so1928591oii.8 for <33695@debbugs.gnu.org>; Wed, 19 Dec 2018 07:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:cc:subject:date:message-id:mime-version; bh=9JT5WdAX130z3DEtishIyldJmjcgl+ekB/a/Nm8FaCI=; b=ncbsTGwub1+vSDgWDgFVuwdWSD00U8AvCvVdKpzVVXKbHsbNl5j3bwqrrmHXwHXwTP bk+K3WCsFPwGrIGCzxQtwtqRe+AmgZP0O9jnN7ZZ+Fj02CJML2mfeuA1My7EjHv2gSza LptbK08rzLg+Cv59PdriRHA4DL1uqb4wuOml6J0ey6NeFVgSQz/UGLW29GEMqtcIUASs un5iK8E3TcoYIfgQOVRePtbSW3DUgXXOIeczYeKo3LLG1HaF9HEXo+8F73w/R5wuHAQD 6t5UDxGTc5Brjj16+kaHhAjmFRGs9TgNN5JKJlw01vjgyAEORpocxUBiSumz1Ag039Xl F0/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:cc:subject:date:message-id :mime-version; bh=9JT5WdAX130z3DEtishIyldJmjcgl+ekB/a/Nm8FaCI=; b=rdEjcXOCiUb3GRuBzAtc+mVrRNNNKHOb6sK69rsHC4mAvbrlFlOEzuB4EwT+8hRw/3 P0edKi50l4dtEuSkM9VDiHWbQoOtDpPDJKFDRKQxV9nRA1p427UQeDv2u7AX1HZ5HoYa kx1DTqKirgzz0UqIFk1ue8hjw4rv+RJPOXr6E+S0Emw3odslYDxuEkyRi1NVqvBoi8+e nqEU0pa+dS2vV8lM2ZZHPF2sDi88qXbTBah3mZYpFPfxJw/NDYpU0H+YzKHHZW4Z1rg4 mc40/ioxfHDvfnJ+Fj1HKC73tvopFt2HzK4LGuwHcGIT4C/EQpQNM7ZnE7ESEKCmA07N Fdxw== X-Gm-Message-State: AA+aEWYwpoap5KgEGPht68ofFJP1wNoq5HORqgVNHopINvZEAjSzYh9Z pKIQWO5/0EhCZfnZGov7cSk= X-Google-Smtp-Source: AFSGD/WG3KTx+gaWjM68Ic3C/IlWkyURPHCal2+O8JVK0DsKUiIO3Ut/P8hK/Y0ZRglfASEXjXylsg== X-Received: by 2002:aca:52d4:: with SMTP id g203mr1451785oib.14.1545234174586; Wed, 19 Dec 2018 07:42:54 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id r11sm9454246oib.45.2018.12.19.07.42.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 07:42:53 -0800 (PST) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: 33695@debbugs.gnu.org Subject: [PATCH] Fix which-function reporting outdated information Date: Wed, 19 Dec 2018 09:42:51 -0600 Message-ID: <87pntxed50.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33695 Cc: martin rudalics X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello - The following patch fixes `which-function' returning outdated imenu information by: 1. Preferring `add-log-current-defun' over `imenu--index-alist' and 2. Updating `imenu--index-alist' more aggressively if we fall back to it. Thanks, Alex >From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 11 Dec 2018 08:29:50 -0600 Subject: [PATCH] which-function: Do not display outdated imenu information * lisp/progmodes/which-func.el (which-function): Check `add-log-current-defun' before imenu. Update `imenu--index-alist' if needed. Bug #33695 --- lisp/progmodes/which-func.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el index 7604be0c25..7cc75e0edb 100644 --- a/lisp/progmodes/which-func.el +++ b/lisp/progmodes/which-func.el @@ -272,16 +272,21 @@ which-func-functions (defun which-function () "Return current function name based on point. -Uses `which-func-functions', `imenu--index-alist' -or `add-log-current-defun'. +Uses `which-func-functions', `add-log-current-defun'. +or `imenu--index-alist' If no function name is found, return nil." (let ((name ;; Try the `which-func-functions' functions first. (run-hook-with-args-until-success 'which-func-functions))) - + ;; Try using add-log support. + (when (null name) + (setq name (add-log-current-defun))) ;; If Imenu is loaded, try to make an index alist with it. (when (and (null name) - (boundp 'imenu--index-alist) (null imenu--index-alist) + (boundp 'imenu--index-alist) + (or (null imenu--index-alist) + ;; Update if outdated + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) (null which-function-imenu-failed)) (ignore-errors (imenu--make-index-alist t)) (unless imenu--index-alist @@ -323,10 +328,6 @@ which-function (funcall which-func-imenu-joiner-function (reverse (cons (car pair) namestack)))))))))))) - - ;; Try using add-log support. - (when (null name) - (setq name (add-log-current-defun))) ;; Filter the name if requested. (when name (if which-func-cleanup-function -- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-which-function-Do-not-display-outdated-imenu-informa.patch >From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 11 Dec 2018 08:29:50 -0600 Subject: [PATCH] which-function: Do not display outdated imenu information * lisp/progmodes/which-func.el (which-function): Check `add-log-current-defun' before imenu. Update `imenu--index-alist' if needed. Bug #33695 --- lisp/progmodes/which-func.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el index 7604be0c25..7cc75e0edb 100644 --- a/lisp/progmodes/which-func.el +++ b/lisp/progmodes/which-func.el @@ -272,16 +272,21 @@ which-func-functions (defun which-function () "Return current function name based on point. -Uses `which-func-functions', `imenu--index-alist' -or `add-log-current-defun'. +Uses `which-func-functions', `add-log-current-defun'. +or `imenu--index-alist' If no function name is found, return nil." (let ((name ;; Try the `which-func-functions' functions first. (run-hook-with-args-until-success 'which-func-functions))) - + ;; Try using add-log support. + (when (null name) + (setq name (add-log-current-defun))) ;; If Imenu is loaded, try to make an index alist with it. (when (and (null name) - (boundp 'imenu--index-alist) (null imenu--index-alist) + (boundp 'imenu--index-alist) + (or (null imenu--index-alist) + ;; Update if outdated + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) (null which-function-imenu-failed)) (ignore-errors (imenu--make-index-alist t)) (unless imenu--index-alist @@ -323,10 +328,6 @@ which-function (funcall which-func-imenu-joiner-function (reverse (cons (car pair) namestack)))))))))))) - - ;; Try using add-log support. - (when (null name) - (setq name (add-log-current-defun))) ;; Filter the name if requested. (when name (if which-func-cleanup-function -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 10 14:56:00 2019 Received: (at 33695) by debbugs.gnu.org; 10 Jan 2019 19:56:00 +0000 Received: from localhost ([127.0.0.1]:54263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghgQq-0007WQ-9e for submit@debbugs.gnu.org; Thu, 10 Jan 2019 14:56:00 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:35851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghgQn-0007WB-9U for 33695@debbugs.gnu.org; Thu, 10 Jan 2019 14:55:59 -0500 Received: by mail-oi1-f195.google.com with SMTP id x23so10305929oix.3 for <33695@debbugs.gnu.org>; Thu, 10 Jan 2019 11:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:message-id:mime-version; bh=xXVgnOtGMvRQjw4j6KKuoJQ46hEb6s1QMw4h6jitGj8=; b=RaYeospJWczEpqqEQHJj+k+E+3YUEEjrlDushzKwrgdC1k5HugYzj4HUiaDLpWi4Dr jBeIWL9NoIgC52x5ENxSDmH8GLLnIXqFBxcIMnzaNJaC/YvBQA/27iTti+Y/mJyVkAGH VfsAJAvMFY3r9xL6+gKUJc3ez9FPxB2FP3qJELGUmo++kizRmsn8HqOv/1Yt+x3klOLn qdoAMbuTuQdL5R2mzQDsMucihfXZHYWJrnIUml0yn7GvGlSvuRVTsB88QRFUzu6TdnpU 8eBwmlQQSGF34KPffE2s394eTS9XOgeZU7aUtr2UBZkHcNOj0JOdpGZniywgEAVKHDcu dDRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :message-id:mime-version; bh=xXVgnOtGMvRQjw4j6KKuoJQ46hEb6s1QMw4h6jitGj8=; b=OHkgIvlcrRYxIv/5MllYuUjShY85fBn667Pjzz6QolHtYEQeoTI3Jmzd4UUTbr7rda FCbU51gdQKxBpsAwe6/nRGYKvlFchcvz4tAi+V570WmvWNO0rFKXjbSdJl2hxkfc+Xfo /+aTuhfl7bAoXQpiqRZ1vw+TcoSoPACIE2E65kBqd/8EFx0sY0TD98M8mrA5vBFSMX6C fdXVUFD/ays/Snn0PxMHZSOweff8ptnKbYPBpjZbTLlw/hxcLKTOFlNCHB5lowX8Am87 7N++0eW0rMEGaYAtt1G8oPPR93kTc5k68pTaFbxdnu5mEdSAR7lMjpc4cYumSGjZ0sd1 VHUw== X-Gm-Message-State: AJcUukeeg0gZcMJVz0A18ZiLrwNL+HI/MqjPodMYoPLjdCFyFtapJ4n2 0A2pFlvQRUOVI/Yk1NEGiGUg6kGy X-Google-Smtp-Source: ALg8bN5FHVB4sUjlj5cChGckay3hdFPoeuZhLpkT8Ai0JVHetUNhVT/7rbuOoip5mW4WrSAdko/xjQ== X-Received: by 2002:aca:2803:: with SMTP id 3mr6748752oix.85.1547150151032; Thu, 10 Jan 2019 11:55:51 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id c78sm55199317oig.30.2019.01.10.11.55.49 for <33695@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 11:55:49 -0800 (PST) References: <87pntxed50.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: 33695@debbugs.gnu.org Subject: Re: [PATCH] Fix which-function reporting outdated information Date: Thu, 10 Jan 2019 13:55:48 -0600 Message-ID: <87sgy070e3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33695 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi - I guess this fell through the cracks with the holidays. Would someone mind following up with either comments or applying this patch? Thanks, Alex On Wed 19 Dec 2018 at 09:42, Alex Branham wrote: > Hello - > > The following patch fixes `which-function' returning outdated imenu > information by: > > 1. Preferring `add-log-current-defun' over `imenu--index-alist' and > > 2. Updating `imenu--index-alist' more aggressively if we fall back to > it. > > Thanks, > Alex > > From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Tue, 11 Dec 2018 08:29:50 -0600 > Subject: [PATCH] which-function: Do not display outdated imenu information > > * lisp/progmodes/which-func.el (which-function): Check > `add-log-current-defun' before imenu. Update `imenu--index-alist' if > needed. Bug #33695 > --- > lisp/progmodes/which-func.el | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el > index 7604be0c25..7cc75e0edb 100644 > --- a/lisp/progmodes/which-func.el > +++ b/lisp/progmodes/which-func.el > @@ -272,16 +272,21 @@ which-func-functions > > (defun which-function () > "Return current function name based on point. > -Uses `which-func-functions', `imenu--index-alist' > -or `add-log-current-defun'. > +Uses `which-func-functions', `add-log-current-defun'. > +or `imenu--index-alist' > If no function name is found, return nil." > (let ((name > ;; Try the `which-func-functions' functions first. > (run-hook-with-args-until-success 'which-func-functions))) > - > + ;; Try using add-log support. > + (when (null name) > + (setq name (add-log-current-defun))) > ;; If Imenu is loaded, try to make an index alist with it. > (when (and (null name) > - (boundp 'imenu--index-alist) (null imenu--index-alist) > + (boundp 'imenu--index-alist) > + (or (null imenu--index-alist) > + ;; Update if outdated > + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) > (null which-function-imenu-failed)) > (ignore-errors (imenu--make-index-alist t)) > (unless imenu--index-alist > @@ -323,10 +328,6 @@ which-function > (funcall > which-func-imenu-joiner-function > (reverse (cons (car pair) namestack)))))))))))) > - > - ;; Try using add-log support. > - (when (null name) > - (setq name (add-log-current-defun))) > ;; Filter the name if requested. > (when name > (if which-func-cleanup-function > -- > 2.19.2 > > > > From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Tue, 11 Dec 2018 08:29:50 -0600 > Subject: [PATCH] which-function: Do not display outdated imenu information > > * lisp/progmodes/which-func.el (which-function): Check > `add-log-current-defun' before imenu. Update `imenu--index-alist' if > needed. Bug #33695 > --- > lisp/progmodes/which-func.el | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el > index 7604be0c25..7cc75e0edb 100644 > --- a/lisp/progmodes/which-func.el > +++ b/lisp/progmodes/which-func.el > @@ -272,16 +272,21 @@ which-func-functions > > (defun which-function () > "Return current function name based on point. > -Uses `which-func-functions', `imenu--index-alist' > -or `add-log-current-defun'. > +Uses `which-func-functions', `add-log-current-defun'. > +or `imenu--index-alist' > If no function name is found, return nil." > (let ((name > ;; Try the `which-func-functions' functions first. > (run-hook-with-args-until-success 'which-func-functions))) > - > + ;; Try using add-log support. > + (when (null name) > + (setq name (add-log-current-defun))) > ;; If Imenu is loaded, try to make an index alist with it. > (when (and (null name) > - (boundp 'imenu--index-alist) (null imenu--index-alist) > + (boundp 'imenu--index-alist) > + (or (null imenu--index-alist) > + ;; Update if outdated > + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) > (null which-function-imenu-failed)) > (ignore-errors (imenu--make-index-alist t)) > (unless imenu--index-alist > @@ -323,10 +328,6 @@ which-function > (funcall > which-func-imenu-joiner-function > (reverse (cons (car pair) namestack)))))))))))) > - > - ;; Try using add-log support. > - (when (null name) > - (setq name (add-log-current-defun))) > ;; Filter the name if requested. > (when name > (if which-func-cleanup-function --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-which-function-Do-not-display-outdated-imenu-informa.patch >From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 11 Dec 2018 08:29:50 -0600 Subject: [PATCH] which-function: Do not display outdated imenu information * lisp/progmodes/which-func.el (which-function): Check `add-log-current-defun' before imenu. Update `imenu--index-alist' if needed. Bug #33695 --- lisp/progmodes/which-func.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el index 7604be0c25..7cc75e0edb 100644 --- a/lisp/progmodes/which-func.el +++ b/lisp/progmodes/which-func.el @@ -272,16 +272,21 @@ which-func-functions (defun which-function () "Return current function name based on point. -Uses `which-func-functions', `imenu--index-alist' -or `add-log-current-defun'. +Uses `which-func-functions', `add-log-current-defun'. +or `imenu--index-alist' If no function name is found, return nil." (let ((name ;; Try the `which-func-functions' functions first. (run-hook-with-args-until-success 'which-func-functions))) - + ;; Try using add-log support. + (when (null name) + (setq name (add-log-current-defun))) ;; If Imenu is loaded, try to make an index alist with it. (when (and (null name) - (boundp 'imenu--index-alist) (null imenu--index-alist) + (boundp 'imenu--index-alist) + (or (null imenu--index-alist) + ;; Update if outdated + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) (null which-function-imenu-failed)) (ignore-errors (imenu--make-index-alist t)) (unless imenu--index-alist @@ -323,10 +328,6 @@ which-function (funcall which-func-imenu-joiner-function (reverse (cons (car pair) namestack)))))))))))) - - ;; Try using add-log support. - (when (null name) - (setq name (add-log-current-defun))) ;; Filter the name if requested. (when name (if which-func-cleanup-function -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 19 16:30:09 2019 Received: (at 33695) by debbugs.gnu.org; 19 Feb 2019 21:30:09 +0000 Received: from localhost ([127.0.0.1]:55673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwCxs-0004m0-RD for submit@debbugs.gnu.org; Tue, 19 Feb 2019 16:30:09 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:38799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwCxl-0004k0-DF for 33695@debbugs.gnu.org; Tue, 19 Feb 2019 16:30:04 -0500 Received: by mail-ot1-f66.google.com with SMTP id m1so36870487otf.5 for <33695@debbugs.gnu.org>; Tue, 19 Feb 2019 13:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=8vIcNkDapqz4eBRQPl0AL/uI7gxSKFrnnd7FUq4qQv4=; b=i9o/JQYjopiUGAeBc7OXR+uhXGZvTxIKfCNVgefYZ28ucWBMO3wQm2mYEqhmJJUUhX 0Fe3oOuKSszuf/8yTGakdUYrvVx2lM1sNx6BN4eLPfkcFUMjUT92GHjDXYC3alfr+67r DMWy+QGSasaWkFcaWlV4iUIdzdCmyKm6sQGA655qzv8zf11LI20ls6jwydZhtn6qYieg 3bdWdrwALdbpkeeohGlEJ3Pg7XtvnRHvNWcxW7qph/5yPdUUBAqBJR2EmurU5AGyzLiF /1C4X5+10tqzfX4siJHBTx2l9DwHt/13SbdlhUYdBKZ4x+NvQQZgEDQOe5EzzijFbWbI cA8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=8vIcNkDapqz4eBRQPl0AL/uI7gxSKFrnnd7FUq4qQv4=; b=ACqQd8ZadKd1VqOYI51I//nscf7QuhLreauIXVE44l5pUIqRcXOCcKFEv26bWAO8Rw MYUI/Oa5O9H1cDMZ/ZHbhsDi/xM2/eeV8gFWuF1d9G+o7TOHwx5kzrB+r94BjMMdrnHu fGQ+FTzJHT8B/DX/6LuWLi40WtiiYmyZfY090mG4VeisWvJZP+qdQt7Y3yqhyFKyfUKZ Ax9dgpLCx1i0jvcyphaaT+V1SGY8iLCCdsRXF1fJwVLzDzEWB+z9uGR1obCBLAsZSpgM hM0z8TsuSL3B6MTAu5Ra/BIjuQKplc/9Hoy/59k4ZOnnKVoecJXPnX7RRAouXpaWMx2Z mORQ== X-Gm-Message-State: AHQUAuaYvGFCQlPTIagXPbsMen0kEnFO2/YdxCSe2RD/p+58Kg7/TJ82 u6bzJpRqFZUa6Qshbz3br3/hFgoS X-Google-Smtp-Source: AHgI3IZ+zpWC0wJHXYYPkfqoCLvYQnPl+J75eAb66io+gM+QTYGT4VT9RIucnYeoinr+VRstJnfDMw== X-Received: by 2002:aca:4c8c:: with SMTP id z134mr3942866oia.158.1550611794240; Tue, 19 Feb 2019 13:29:54 -0800 (PST) Received: from mars (nat-128-62-60-156.public.utexas.edu. [128.62.60.156]) by smtp.gmail.com with ESMTPSA id s12sm5567139otk.0.2019.02.19.13.29.52 for <33695@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 13:29:53 -0800 (PST) References: <87pntxed50.fsf@gmail.com> <87sgy070e3.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: 33695@debbugs.gnu.org Subject: Re: [PATCH] Fix which-function reporting outdated information In-reply-to: <87sgy070e3.fsf@gmail.com> Date: Tue, 19 Feb 2019 15:29:51 -0600 Message-ID: <87y36b1n74.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33695 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi all - Assuming no objections, I'll apply the patch below to master later this week. Alex On Thu 10 Jan 2019 at 13:55, Alex Branham wrote: > Hi - > > I guess this fell through the cracks with the holidays. Would someone > mind following up with either comments or applying this patch? > > Thanks, > Alex > > On Wed 19 Dec 2018 at 09:42, Alex Branham wrote: > >> Hello - >> >> The following patch fixes `which-function' returning outdated imenu >> information by: >> >> 1. Preferring `add-log-current-defun' over `imenu--index-alist' and >> >> 2. Updating `imenu--index-alist' more aggressively if we fall back to >> it. >> >> Thanks, >> Alex >> >> From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 >> From: Alex Branham >> Date: Tue, 11 Dec 2018 08:29:50 -0600 >> Subject: [PATCH] which-function: Do not display outdated imenu information >> >> * lisp/progmodes/which-func.el (which-function): Check >> `add-log-current-defun' before imenu. Update `imenu--index-alist' if >> needed. Bug #33695 >> --- >> lisp/progmodes/which-func.el | 17 +++++++++-------- >> 1 file changed, 9 insertions(+), 8 deletions(-) >> >> diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el >> index 7604be0c25..7cc75e0edb 100644 >> --- a/lisp/progmodes/which-func.el >> +++ b/lisp/progmodes/which-func.el >> @@ -272,16 +272,21 @@ which-func-functions >> >> (defun which-function () >> "Return current function name based on point. >> -Uses `which-func-functions', `imenu--index-alist' >> -or `add-log-current-defun'. >> +Uses `which-func-functions', `add-log-current-defun'. >> +or `imenu--index-alist' >> If no function name is found, return nil." >> (let ((name >> ;; Try the `which-func-functions' functions first. >> (run-hook-with-args-until-success 'which-func-functions))) >> - >> + ;; Try using add-log support. >> + (when (null name) >> + (setq name (add-log-current-defun))) >> ;; If Imenu is loaded, try to make an index alist with it. >> (when (and (null name) >> - (boundp 'imenu--index-alist) (null imenu--index-alist) >> + (boundp 'imenu--index-alist) >> + (or (null imenu--index-alist) >> + ;; Update if outdated >> + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) >> (null which-function-imenu-failed)) >> (ignore-errors (imenu--make-index-alist t)) >> (unless imenu--index-alist >> @@ -323,10 +328,6 @@ which-function >> (funcall >> which-func-imenu-joiner-function >> (reverse (cons (car pair) namestack)))))))))))) >> - >> - ;; Try using add-log support. >> - (when (null name) >> - (setq name (add-log-current-defun))) >> ;; Filter the name if requested. >> (when name >> (if which-func-cleanup-function >> -- >> 2.19.2 >> >> >> >> From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 >> From: Alex Branham >> Date: Tue, 11 Dec 2018 08:29:50 -0600 >> Subject: [PATCH] which-function: Do not display outdated imenu information >> >> * lisp/progmodes/which-func.el (which-function): Check >> `add-log-current-defun' before imenu. Update `imenu--index-alist' if >> needed. Bug #33695 >> --- >> lisp/progmodes/which-func.el | 17 +++++++++-------- >> 1 file changed, 9 insertions(+), 8 deletions(-) >> >> diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el >> index 7604be0c25..7cc75e0edb 100644 >> --- a/lisp/progmodes/which-func.el >> +++ b/lisp/progmodes/which-func.el >> @@ -272,16 +272,21 @@ which-func-functions >> >> (defun which-function () >> "Return current function name based on point. >> -Uses `which-func-functions', `imenu--index-alist' >> -or `add-log-current-defun'. >> +Uses `which-func-functions', `add-log-current-defun'. >> +or `imenu--index-alist' >> If no function name is found, return nil." >> (let ((name >> ;; Try the `which-func-functions' functions first. >> (run-hook-with-args-until-success 'which-func-functions))) >> - >> + ;; Try using add-log support. >> + (when (null name) >> + (setq name (add-log-current-defun))) >> ;; If Imenu is loaded, try to make an index alist with it. >> (when (and (null name) >> - (boundp 'imenu--index-alist) (null imenu--index-alist) >> + (boundp 'imenu--index-alist) >> + (or (null imenu--index-alist) >> + ;; Update if outdated >> + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) >> (null which-function-imenu-failed)) >> (ignore-errors (imenu--make-index-alist t)) >> (unless imenu--index-alist >> @@ -323,10 +328,6 @@ which-function >> (funcall >> which-func-imenu-joiner-function >> (reverse (cons (car pair) namestack)))))))))))) >> - >> - ;; Try using add-log support. >> - (when (null name) >> - (setq name (add-log-current-defun))) >> ;; Filter the name if requested. >> (when name >> (if which-func-cleanup-function > > From a06b1318f23b3f67ed0e1041f50ccea67d46ea48 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Tue, 11 Dec 2018 08:29:50 -0600 > Subject: [PATCH] which-function: Do not display outdated imenu information > > * lisp/progmodes/which-func.el (which-function): Check > `add-log-current-defun' before imenu. Update `imenu--index-alist' if > needed. Bug #33695 > --- > lisp/progmodes/which-func.el | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el > index 7604be0c25..7cc75e0edb 100644 > --- a/lisp/progmodes/which-func.el > +++ b/lisp/progmodes/which-func.el > @@ -272,16 +272,21 @@ which-func-functions > > (defun which-function () > "Return current function name based on point. > -Uses `which-func-functions', `imenu--index-alist' > -or `add-log-current-defun'. > +Uses `which-func-functions', `add-log-current-defun'. > +or `imenu--index-alist' > If no function name is found, return nil." > (let ((name > ;; Try the `which-func-functions' functions first. > (run-hook-with-args-until-success 'which-func-functions))) > - > + ;; Try using add-log support. > + (when (null name) > + (setq name (add-log-current-defun))) > ;; If Imenu is loaded, try to make an index alist with it. > (when (and (null name) > - (boundp 'imenu--index-alist) (null imenu--index-alist) > + (boundp 'imenu--index-alist) > + (or (null imenu--index-alist) > + ;; Update if outdated > + (/= (buffer-chars-modified-tick) imenu-menubar-modified-tick)) > (null which-function-imenu-failed)) > (ignore-errors (imenu--make-index-alist t)) > (unless imenu--index-alist > @@ -323,10 +328,6 @@ which-function > (funcall > which-func-imenu-joiner-function > (reverse (cons (car pair) namestack)))))))))))) > - > - ;; Try using add-log support. > - (when (null name) > - (setq name (add-log-current-defun))) > ;; Filter the name if requested. > (when name > (if which-func-cleanup-function --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxsdU8ACgkQHkInolPp msc/Wgf/QwUvhpqhufhlUWN3HTKGGq5KsRakOGLD+xdAowImSMPnUx3OmUEHftN5 +Bla8myeVi3cJfA3rft0i4b8MOex7F+KwTgmNa5H0t7N09cvf0xAB7Gl3f8jFzD/ bTfuQWw+mjDWbLq8o5s6Fe6/cYaG+vuOgKYGprcf5FNDrgNKpnBmKKh2nyxbwKy5 nR5GJoIS5I1nTY6kwuuA/B9tSTZBzzo1fsdjhZhSTq3zdIwu9nyTvDsMA75j4IC/ va8DHoFikvD8K0g6M9XJrnrcb25C9TUMqwmxxUGUtBUrqAi22B25WUj1Af/pGx/7 PKXSk5BENCPfl+YHdZpwUCeKEzQvVg== =mR+V -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 22 16:28:36 2019 Received: (at 33695-done) by debbugs.gnu.org; 22 Feb 2019 21:28:36 +0000 Received: from localhost ([127.0.0.1]:48612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxIN1-0007Wd-PG for submit@debbugs.gnu.org; Fri, 22 Feb 2019 16:28:36 -0500 Received: from mail-oi1-f171.google.com ([209.85.167.171]:46940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxIMz-0007WQ-HQ for 33695-done@debbugs.gnu.org; Fri, 22 Feb 2019 16:28:34 -0500 Received: by mail-oi1-f171.google.com with SMTP id j135so2834845oib.13 for <33695-done@debbugs.gnu.org>; Fri, 22 Feb 2019 13:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=6ePaDzMIMbK8BsIZ8RPAzcVtHsUxc+CUfJjPVXpPAEA=; b=BoKpgg1lzaAS0IY6iejWMFhV0lqy/fLFI0jcsFzXJEaxkls9wpZNFF/OGljzCNMOkS mIzRJkbSTabUVAn0WEXFxGqEuc9X895G8ZPFVF84bCe0+gUVxssq1WDzzf9SLxGqztVk ufjsj1LA0wUiJNORrGCshMyOEoMhzS6MdW8GDbtIeXxd1iLf94S484vedso1RNg4v4GN dx9NHI4dH+Nc4IJROMENjAmz5wgLXMP5jZX2MwhwK0CHmF017jRLxujdUMoncuPdnaWI a/goCneW8Sfj7VmeUOwAMndh1KaQov2ft5J8sw+mt49Y+mMSgaLeid4iAIsSIQL7MuoB p6qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=6ePaDzMIMbK8BsIZ8RPAzcVtHsUxc+CUfJjPVXpPAEA=; b=q102xUtE66vnuOYQKPo059DQXaRcNDS+8RnHn9Cr8JYQb+nkSG5jHWOp4dMZQpDrwh 7GPxpO9fE0n6zZoVs+u9g5VzjZDL3RocXvTaWEwyiGXuG47vTmvluw+02cNuXOEBus35 smGMjvDybRCaxdDXGjJO3mp6jh2zcHF0jZp8Byna1ZlSIL3yDFNHgnQMRan8kCD787om hbC3QfX9vuvNTpJEumJb4MeNz7bdrYoSM7pt5q1U/b7fIkazk4Tgf7HzUHmR3QbgivKM eYeGpMaHDQDafbeJ3sssuNKTxWXBzHk0Mc/pcGGhIgrEmwLOneURjTsoXRCkJQsEnD8f corQ== X-Gm-Message-State: AHQUAuZ9xm927kv+tqtcDwpgKCBD+hpd7qWjHoWAixkAHz5Qu0EXcq82 Eo/yAXt6CNKUvAmdfB3zCFuS68ki X-Google-Smtp-Source: AHgI3IYDyqQDSyNlh+tz/IWlY+GB5QQBW9sVVRYj+QsE9JTrJsU1ggP4fW4vc7IawugzEOwhX3kTCA== X-Received: by 2002:aca:d682:: with SMTP id n124mr3938411oig.80.1550870907521; Fri, 22 Feb 2019 13:28:27 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id m11sm590582oif.50.2019.02.22.13.28.26 for <33695-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Feb 2019 13:28:26 -0800 (PST) References: <87pntxed50.fsf@gmail.com> <87sgy070e3.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: 33695-done@debbugs.gnu.org Subject: Re: [PATCH] Fix which-function reporting outdated information In-reply-to: <87sgy070e3.fsf@gmail.com> Date: Fri, 22 Feb 2019 15:28:25 -0600 Message-ID: <87lg27cy2u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33695-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Committed as 0613e7a38efc3b0534e0ca5c5fa401e2a3bda906 in what will be Emacs 27 From unknown Tue Aug 19 18:06:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Mar 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator