GNU bug report logs - #33694
27.0.50; 'set-window-scroll-bars' broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33694 in the body.
You can then email your comments to 33694 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Cc: monnier <at> iro.umontreal.ca
Subject: 27.0.50; 'set-window-scroll-bars' broken
Date: Mon, 10 Dec 2018 09:41:11 +0100

This change

2015-09-30  Stefan Monnier  <monnier <at> iro.umontreal.ca>

	Try to avoid redisplaying all frames when creating a new one

	...

	* src/window.c (apply_window_adjustment): Remove redundant setting of
	windows_or_buffers_changed.

        ...

broke evaluating the following form with emacs -Q:

(set-window-scroll-bars nil 0 nil)

This should immediately remove the scroll bar of the selected window
but instead hides its right fringe under the scroll bar.

martin

Message #8 received at 33694 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Mon, 10 Dec 2018 11:52:57 +0200

> Date: Mon, 10 Dec 2018 09:41:11 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> Cc: monnier <at> iro.umontreal.ca
> 
> This change
> 
> 2015-09-30  Stefan Monnier  <monnier <at> iro.umontreal.ca>
> 
> 	Try to avoid redisplaying all frames when creating a new one
> 
> 	...
> 
> 	* src/window.c (apply_window_adjustment): Remove redundant setting of
> 	windows_or_buffers_changed.
> 
>          ...
> 
> broke evaluating the following form with emacs -Q:
> 
> (set-window-scroll-bars nil 0 nil)
> 
> This should immediately remove the scroll bar of the selected window
> but instead hides its right fringe under the scroll bar.

Does the below look reasonable?  I'd like to apply it to the emacs-26
branch.

diff --git a/src/window.c b/src/window.c
index 5d99098..c93ab5c 100644
--- a/src/window.c
+++ b/src/window.c
@@ -7254,6 +7254,10 @@ set_window_scroll_bars (struct window *w, Lisp_Object width,
   wset_horizontal_scroll_bar_type (w, Qnil);
 #endif
 
+  /* This is needed to trigger immediate redisplay of the window when
+     scroll bars are changed.  */
+  if (changed)
+    windows_or_buffers_changed = 31;
   return changed ? w : NULL;
 }
 

Message #11 received at 33694 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Mon, 10 Dec 2018 18:44:38 +0100

> Does the below look reasonable?  I'd like to apply it to the emacs-26
> branch.

Hmm...  'set-window-fringes' has the same problem.

martin

Message #14 received at 33694 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Mon, 10 Dec 2018 20:09:00 +0200

> Date: Mon, 10 Dec 2018 18:44:38 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> CC: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
> 
>  > Does the below look reasonable?  I'd like to apply it to the emacs-26
>  > branch.
> 
> Hmm...  'set-window-fringes' has the same problem.

I can do the same there.  Anything else?

Message #17 received at 33694 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Tue, 11 Dec 2018 09:34:57 +0100

>> Hmm...  'set-window-fringes' has the same problem.
>
> I can do the same there.  Anything else?

Since IIUC margins are handled differently I see no further issues.

Thanks for fixing these, martin

Message #20 received at 33694 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Tue, 11 Dec 2018 10:43:09 +0200

> Date: Tue, 11 Dec 2018 09:34:57 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> CC: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
> 
>  >> Hmm...  'set-window-fringes' has the same problem.
>  >
>  > I can do the same there.  Anything else?
> 
> Since IIUC margins are handled differently I see no further issues.

OK, but can you give me a recipe for set-window-fringes?  In my
testing, the fringes are updated instantly after the call.

Thanks.

Message #23 received at 33694 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Tue, 11 Dec 2018 10:05:41 +0100

> OK, but can you give me a recipe for set-window-fringes?  In my
> testing, the fringes are updated instantly after the call.

When on the release branch with emacs -Q I evaluate

(set-window-fringes nil 40 60)

in *scratch* I don't see any change.  After moving the cursor I do.

martin

Message #28 received at 33694-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 33694-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Tue, 11 Dec 2018 12:33:56 +0200

> Date: Tue, 11 Dec 2018 10:05:41 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> CC: 33694 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
> 
>  > OK, but can you give me a recipe for set-window-fringes?  In my
>  > testing, the fringes are updated instantly after the call.
> 
> When on the release branch with emacs -Q I evaluate
> 
> (set-window-fringes nil 40 60)
> 
> in *scratch* I don't see any change.  After moving the cursor I do.

Thanks, I pushed the changes to the emacs-26 branch.

Message #31 received at 33694-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33694-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Wed, 12 Dec 2018 09:30:49 +0100

> Thanks, I pushed the changes to the emacs-26 branch.

Thank you, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.