GNU bug report logs - #33684
DocView bombs out upon password protected PDFs

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Sun, 9 Dec 2018 10:54:02 UTC

Severity: wishlist

Done: Tassilo Horn <tsdh <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33684: closed (DocView bombs out upon password protected PDFs)
Date: Mon, 04 Feb 2019 15:50:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 04 Feb 2019 16:49:25 +0100
with message-id <87h8djeepm.fsf <at> gnu.org>
and subject line Re: bug#33684: DocView bombs out upon password protected PDFs
has caused the debbugs.gnu.org bug report #33684,
regarding DocView bombs out upon password protected PDFs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33684: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33684
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: DocView bombs out upon password protected PDFs
Date: Sun, 09 Dec 2018 18:52:50 +0800
When trying to view a password protected PDF:
DocView: process pdf/ps->png changed status to exited abnormally with code 1.
Maybe it should ask for the password.
emacs-version "25.2.2"


[Message part 3 (message/rfc822, inline)]
From: Tassilo Horn <tsdh <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jidanni <at> jidanni.org, 33684-done <at> debbugs.gnu.org,
 Federico Tedin <federicotedin <at> gmail.com>
Subject: Re: bug#33684: DocView bombs out upon password protected PDFs
Date: Mon, 04 Feb 2019 16:49:25 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

>> > Hi Tassilo, thanks for your feedback. I've created a new patch with
>> > the commit message, and also added an entry to NEWS. I'm attaching
>> it
>> > here.
>> 
>> Looks perfect.  Small nitpick: we use * for bullet points instead of
>> - in the commit message, but I can amend that.  I can't push it from
>> work, so I'll do it this evening.
>
> When you do, please be sure to amend the log message to mention the
> bug number.
>
> Also, the doc strings of 2 of the new functions need to be reformatted
> to have the first line be a complete sentence.  (Just move the second
> sentence to the next line, I'd say.)

Pushed with the aforementioned changes.

Thanks again, Federico!
Tassilo


This bug report was last modified 6 years and 102 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.