From unknown Thu Jun 19 14:26:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Dec 2018 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33679 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33679@debbugs.gnu.org Cc: Ricardo Wurmus , Joakim Verona X-Debbugs-Original-To: Emacs bug reports Received: via spool by submit@debbugs.gnu.org id=B.15443135953047 (code B ref -1); Sun, 09 Dec 2018 00:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Dec 2018 23:59:55 +0000 Received: from localhost ([127.0.0.1]:39012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVmVn-0000n5-0c for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVmVk-0000mo-IX for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVmVe-00028l-C0 for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVmVe-00028h-7p for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVmVd-00044c-1s for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 18:59:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVmVZ-00027p-1n for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 18:59:44 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVmVY-00027F-Mk for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 18:59:40 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1029A1605D7; Sat, 8 Dec 2018 15:59:39 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ALfiHWPjUjn7; Sat, 8 Dec 2018 15:59:37 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AB0EB1605CA; Sat, 8 Dec 2018 15:59:37 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HcG7Tp8MSYZV; Sat, 8 Dec 2018 15:59:37 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6BE561604F6; Sat, 8 Dec 2018 15:59:37 -0800 (PST) From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <65ba713b-68e0-02d2-7795-177a7f27a407@cs.ucla.edu> Date: Sat, 8 Dec 2018 15:59:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FED6421367BBAB68D371E177" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------FED6421367BBAB68D371E177 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable I hadn't built Emacs lately with xwidgets support. When I tried it on Fed= ora 29=20 via './configure --with-xwidgets --enable-gcc-warnings' the build failed = with=20 the diagnostics at the end of this message. Apparently WebKitGTK has muta= ted and=20 Emacs hasn't kept up. Although I plan to work around the immediate proble= m by=20 installing the attached patch on master, could an xwidgets expert please = fix=20 this the "right" way by using the JavaScriptCore GLib API instead? Thanks= . CC xwidget.o xwidget.c: In function =E2=80=98webkit_javascript_finished_cb=E2=80=99: xwidget.c:393:2: error: =E2=80=98webkit_javascript_result_get_global_cont= ext=E2=80=99 is=20 deprecated [-Werror=3Ddeprecated-declarations] context =3D webkit_javascript_result_get_global_context (js_result); ^~~~~~~ In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54, from xwidget.c:30: /usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:49:1: note: d= eclared=20 here webkit_javascript_result_get_global_context (WebKitJavascriptResult *js= _result); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ xwidget.c:394:2: error: =E2=80=98webkit_javascript_result_get_value=E2=80= =99 is deprecated: Use=20 'webkit_javascript_result_get_js_value' instead [-Werror=3Ddeprecated-dec= larations] value =3D webkit_javascript_result_get_value (js_result); ^~~~~ In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54, from xwidget.c:30: /usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:52:1: note: d= eclared=20 here webkit_javascript_result_get_value (WebKitJavascriptResult *js= _result); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:384: xwidget.o] Error 1 make[1]: Leaving directory '/home/eggert/src/gnu/emacs/master-tmp/src' make: *** [Makefile:421: src] Error 2 --------------FED6421367BBAB68D371E177 Content-Type: text/x-patch; name="0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch" >From bcdda254cb249950812a6b7122278a4d63761194 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 8 Dec 2018 15:29:07 -0800 Subject: [PATCH] Suppress WebKitGTK+ 2.21.1 diagnostics * src/xwidget.c: Suppress deprecation warnings. --- src/xwidget.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/xwidget.c b/src/xwidget.c index 6da7a0bb3f..24f7d39077 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -30,6 +30,14 @@ along with GNU Emacs. If not, see . */ #include #include +/* Suppress GCC deprecation warnings starting in WebKitGTK+ 2.21.1 for + webkit_javascript_result_get_global_context and + webkit_javascript_result_get_value. + FIXME: Use the JavaScriptCore GLib API instead, and remove this hack. */ +#if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0) +# pragma GCC diagnostic ignored "-Wdeprecated-declarations" +#endif + static struct xwidget * allocate_xwidget (void) { -- 2.19.2 --------------FED6421367BBAB68D371E177-- From unknown Thu Jun 19 14:26:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1 Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33679 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: Ricardo Wurmus , 33679@debbugs.gnu.org, Joakim Verona Received: via spool by 33679-submit@debbugs.gnu.org id=B33679.159801185210516 (code B ref 33679); Fri, 21 Aug 2020 12:11:02 +0000 Received: (at 33679) by debbugs.gnu.org; 21 Aug 2020 12:10:52 +0000 Received: from localhost ([127.0.0.1]:45279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95sh-0002jX-LQ for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:10:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95sg-0002jD-16 for 33679@debbugs.gnu.org; Fri, 21 Aug 2020 08:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YksN6pWgc7zK31tK+C+lsWuLJOa41CvCZgho703/qFo=; b=ePEmtpsPuYDLuFZ4rMk/tZbqnX B/Kqwy4tpYb4oADzLJZL10FoavWqcNsivcuAZdoedoZwSvFpkAVQ32Kv22RO0HHN/AtlGkq6RpOWJ VA4KWdVhw0lFXIF0KZZyPdWy0xKh7IzUVrylrpWFeSXa769Kmvufd4DB8A1Inqn2hOTg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k95sR-0003O9-VL; Fri, 21 Aug 2020 14:10:38 +0200 From: Lars Ingebrigtsen References: <65ba713b-68e0-02d2-7795-177a7f27a407@cs.ucla.edu> X-Now-Playing: Peter Zummo's _Deep Drive_: "Deep Drive" Date: Fri, 21 Aug 2020 14:10:34 +0200 In-Reply-To: <65ba713b-68e0-02d2-7795-177a7f27a407@cs.ucla.edu> (Paul Eggert's message of "Sat, 8 Dec 2018 15:59:36 -0800") Message-ID: <875z9c6vyd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Paul Eggert writes: [...] > Although I plan to work around the immediate problem by installing > the attached patch on master, Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Paul Eggert writes: [...] > Although I plan to work around the immediate problem by installing > the attached patch on master, [...] > +/* Suppress GCC deprecation warnings starting in WebKitGTK+ 2.21.1 for > + webkit_javascript_result_get_global_context and > + webkit_javascript_result_get_value. > + FIXME: Use the JavaScriptCore GLib API instead, and remove this hack. */ > +#if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0) > +# pragma GCC diagnostic ignored "-Wdeprecated-declarations" > +#endif Paul, it looks like this patch was never applied? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Jun 19 14:26:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#33679: closed (Re: bug#33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1) Message-ID: References: <65ba713b-68e0-02d2-7795-177a7f27a407@cs.ucla.edu> X-Gnu-PR-Message: they-closed 33679 X-Gnu-PR-Package: emacs Reply-To: 33679@debbugs.gnu.org Date: Fri, 21 Aug 2020 21:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1598046782-30615-1" This is a multi-part message in MIME format... ------------=_1598046782-30615-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33679@debbugs.gnu.org. --=20 33679: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33679 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1598046782-30615-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33679-done) by debbugs.gnu.org; 21 Aug 2020 21:52:03 +0000 Received: from localhost ([127.0.0.1]:48439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9Ex9-0007wZ-7z for submit@debbugs.gnu.org; Fri, 21 Aug 2020 17:52:03 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9Ex7-0007w5-EE for 33679-done@debbugs.gnu.org; Fri, 21 Aug 2020 17:52:02 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 41737160084; Fri, 21 Aug 2020 14:51:55 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id h6zwXZsLSvJ0; Fri, 21 Aug 2020 14:51:54 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 980A91600E9; Fri, 21 Aug 2020 14:51:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6IAWhlhGxEAU; Fri, 21 Aug 2020 14:51:54 -0700 (PDT) Received: from [192.168.1.9] (cpe-75-82-69-226.socal.res.rr.com [75.82.69.226]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 671B2160084; Fri, 21 Aug 2020 14:51:54 -0700 (PDT) Subject: Re: bug#33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1 To: Lars Ingebrigtsen References: <65ba713b-68e0-02d2-7795-177a7f27a407@cs.ucla.edu> <875z9c6vyd.fsf@gnus.org> From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDUGdRVEFRSUFL QVVDVElCeQpaQUliQXdVSkVzd0RBQVlMQ1FnSEF3SUdGUWdDQ1FvTEJCWUNBd0VDSGdFQ0Y0 QUFDZ2tRN1pmcERtS3FmalJSCkd3LytJajAzZGhZZllsL2dYVlJpdXpWMWdHcmJIayt0bmZy SS9DN2ZBZW9GelE1dFZnVmluU2hhUGtabzBIVFAKZjE4eDZJREVkQWlPOE1xbzF5cDBDdEht ekdNQ0o1MG80R3JnZmpscjZnLyt2dEVPS2JobGVzek4yWHBKdnB3TQoyUWdHdm4vbGFUTFV1 OFBIOWFSV1RzN3FKSlpLS0tBYjRzeFljOTJGZWhQdTZGT0QwZERpeWhsREFxNGxPVjJtCmRC cHpRYmlvam9aelFMTVF3anBnQ1RLMjU3MmVLOUVPRVF5U1VUaFhyU0l6NkFTZW5wNE5ZVEZI czl0dUpRdlgKazlnWkRkUFNsM2JwKzQ3ZEd4bHhFV0xwQklNN3pJT053NGtzNGF6Z1Q4bnZE WnhBNUlaSHR2cUJsSkxCT2JZWQowTGU2MVdwMHkzVGxCRGgycWRLOGVZTDQyNlc0c2NFTVN1 aWc1Z2I4T0F0UWlCVzZrMnNHVXh4ZWl2OG92V3U4CllBWmdLSmZ1b1dJK3VSbk1FZGRydVk4 SnNvTTU0S2FLdlppa2tLczJiZzFuZHRMVnpIcEo2cUZaQzdRVmplSFUKaDYvQm1ndmRqV1Ba WUZUdE4rS0E5Q1dYM0dRS0tnTjN1dTk4OHl6bkQ3TG5COThUNEVVSDFIQS9HbmZCcU1WMQpn cHpUdlBjNHFWUWluQ21Ja0VGcDgzemwrRzVmQ2pKSjNXN2l2ekNuWW80S2hLTHBGVW05N29r VEtSMkxXM3haCnpFVzRjTFNXTzM4N01USzNDekRPeDVxZTZzNGE5MVp1Wk0vai9UUWRUTERh cU5uODNrQTRIcTQ4VUhYWXhjSWgKK05kOGsvM3c2bEZ1b0swd3JPRml5d2pMeCswdXI1am1t YmVjQkdIYzF4ZGhBRkc1QWcwRVRJQnlaQUVRQUthRgo2NzhUOXd5SDR3alRyVjFQejNjREVv U25WLzBaVXJPVDM3cDFkY0d5ai9JWHExeDY3MEhSVmFoQW1rMHNacFljCjI1UEY5RDVHUFlI RldsTmp1UFU5NnJEbmRYQjNoZWRtQlJoTGRDNGJBWGpJNERWK2JtZFZlK3EvSU1ubFpSYVYK bG05RWlNQ1ZBUjZ3MTNzUmV1N3FYa1c5cjNSd1kyQXpYc2twL3RBZTRCUktyMVptYnZpMm5i blE2ZXBFQzQycgpSYngwQjFFaGpiSVFaNUpIR2syNGlQVDdMZEJnbk5tb3M1d1lqendObGtN UUQ1VDBZZHpoazdKK1V4d0E1bTQ2Cm1PaFJEQzJyRlYvQTBnbTVUTHk4RFhqdi9Fc2M0Z1lu WWFpNlNRcW5VRVZoNUx1VjhZQ0pCbmlqcytUaXc3MXgKMWljbW42eEdJNDVFdWdKT2dlYyty THlwWWdwVnA0eDBISTVUODhxQlJZQ2t4SDNLZzhRbytFV05BOUE0TFJROQpEWDhuam9uYTBn ZjBzMDN0b2NLOGtCTjY2VW9xcVB0SEJuYzRlTWdCeW1DZmxLMTJlS2ZkMllZeG55ZzljWmF6 CldBNVZzbHZUeHBtNzZoYmc1b2lBRUgvVmcvOE14SHlBblBoZnJnd3lQcm1KRWNWQmFmZHNw Sm5ZUXhCWU5jbzIKTEZQSWhsT3ZXaDhyNGF0K3MrTTNMYjI2b1VUY3psZ2RXMVNmM1NEQTc3 Qk1SbkYwRlF5RSs3QXpWNzlNQk40eQpraXFhZXpReHRhRjFGeS90dmtoZmZTbzh1K2R3RzBF Z0poK3RlMzhnVGNJU1ZyMEdJUHBsTHo2WWhqcmJIclBSCkYxQ041VXVMOURCR2p4dU4zNVJM TlZFZnRhNlJVRmxSNk5jdFRqdnJBQkVCQUFHSkFpVUVHQUVDQUE4RkFreUEKY21RQ0d3d0ZD UkxNQXdBQUNna1E3WmZwRG1LcWZqU3JIQS8rS3pBS3ZUeFJoQTlNV05MeEl5SjdTNXVKMTZn cwpUM29DalpyQktHRWhLTU9HWDRPMEdBNlZPRXJ5TzdRUkNDWWFoM294U0czOElBbk5laXdK WGdVOUJ6a2s4NVVHCmJQRWQ3SEdGL1ZTZUhDUXdXb3U2anFVRFRTRHZuOVloTlRkRzBLWFBN NzRhQyt4cjJab3cxTzJtaFhpaGdXS0QKMER3KzBMWVBuVU9zUTBLT0Z4SFhYWUhtUnJTMU9a UFU1OUJMdmMrVFJoSWhhZlNIS0x3YlhLKzZja2t4Qng2aAo4ejVjY3BHMFFzNGJGaGRGWW5G ckVpZURMb0dtbkUyWUxoZFY2c3dKOVZOQ1M2cExpRW9oVDNmbTdhWG0xNXRaCk9JeXpNWmhI UlNBUGJsWHhRMFpTV2pxOG9ScmNZTkZ4YzRXMVVScEFrQkNPWUpvWHZRZkQ1TDNscUFsOFRD cUQKVXpZeGhIL3RKaGJEZEhycUhINzY3amFEYVRCMStUYWxwLzJBTUt3Y1hOT2Rpa2xHeGJt SFZHNllHbDZnOExyYgpzdTlOWkVJNHlMbEh6dWlrdGhKV2d6KzN2WmhWR3lObHQrSE5Jb0Y2 Q2pETDJvbXU1Y0VxNFJESE00NFFxUGs2Cmw3TzBwVXZOMW1UNEIrUzFiMDhSS3BxbS9mZjAx NUUzN0hOVi9waUl2Smx4R0FZejhQU2Z1R0NCMXRoTVlxbG0KZ2RoZDkvQmFiR0ZiR0dZSEE2 VTQvVDV6cVUrZjZ4SHkxU3NBUVoxTVNLbEx3ZWtCSVQrNC9jTFJHcUNIam5WMApxNUgvVDZh N3Q1bVBrYnpTck9MU280cHVqK0lUb05qWXlZSURCV3pobEExOWF2T2ErcnZVam1IdEQzc0ZO N2NYCld0a0dvaThidU5jYnk0VT0KPUFMNm8KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkgQkxP Q0stLS0tLQo= Organization: UCLA Computer Science Department Message-ID: Date: Fri, 21 Aug 2020 14:51:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z9c6vyd.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: 33679-done Cc: Ricardo Wurmus , 33679-done@debbugs.gnu.org, Joakim Verona X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) On 8/21/20 5:10 AM, Lars Ingebrigtsen wrote: > Paul, it looks like this patch was never applied? The patch was applied, but was later removed when Jimmy Aguilar Mena fixed the underlying problem in 2019-09-17T20:00:21Z!kratsbinovish@gmail.com. Closing the bug report. ------------=_1598046782-30615-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Dec 2018 23:59:55 +0000 Received: from localhost ([127.0.0.1]:39012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVmVn-0000n5-0c for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVmVk-0000mo-IX for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVmVe-00028l-C0 for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVmVe-00028h-7p for submit@debbugs.gnu.org; Sat, 08 Dec 2018 18:59:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVmVd-00044c-1s for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 18:59:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVmVZ-00027p-1n for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 18:59:44 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVmVY-00027F-Mk for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 18:59:40 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1029A1605D7; Sat, 8 Dec 2018 15:59:39 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ALfiHWPjUjn7; Sat, 8 Dec 2018 15:59:37 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AB0EB1605CA; Sat, 8 Dec 2018 15:59:37 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HcG7Tp8MSYZV; Sat, 8 Dec 2018 15:59:37 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6BE561604F6; Sat, 8 Dec 2018 15:59:37 -0800 (PST) To: Emacs bug reports From: Paul Eggert Subject: Emacs uses APIs deprecated in WebKitGTK 2.21.1 Organization: UCLA Computer Science Department Message-ID: <65ba713b-68e0-02d2-7795-177a7f27a407@cs.ucla.edu> Date: Sat, 8 Dec 2018 15:59:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FED6421367BBAB68D371E177" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Ricardo Wurmus , Joakim Verona X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------FED6421367BBAB68D371E177 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable I hadn't built Emacs lately with xwidgets support. When I tried it on Fed= ora 29=20 via './configure --with-xwidgets --enable-gcc-warnings' the build failed = with=20 the diagnostics at the end of this message. Apparently WebKitGTK has muta= ted and=20 Emacs hasn't kept up. Although I plan to work around the immediate proble= m by=20 installing the attached patch on master, could an xwidgets expert please = fix=20 this the "right" way by using the JavaScriptCore GLib API instead? Thanks= . CC xwidget.o xwidget.c: In function =E2=80=98webkit_javascript_finished_cb=E2=80=99: xwidget.c:393:2: error: =E2=80=98webkit_javascript_result_get_global_cont= ext=E2=80=99 is=20 deprecated [-Werror=3Ddeprecated-declarations] context =3D webkit_javascript_result_get_global_context (js_result); ^~~~~~~ In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54, from xwidget.c:30: /usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:49:1: note: d= eclared=20 here webkit_javascript_result_get_global_context (WebKitJavascriptResult *js= _result); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ xwidget.c:394:2: error: =E2=80=98webkit_javascript_result_get_value=E2=80= =99 is deprecated: Use=20 'webkit_javascript_result_get_js_value' instead [-Werror=3Ddeprecated-dec= larations] value =3D webkit_javascript_result_get_value (js_result); ^~~~~ In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54, from xwidget.c:30: /usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:52:1: note: d= eclared=20 here webkit_javascript_result_get_value (WebKitJavascriptResult *js= _result); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:384: xwidget.o] Error 1 make[1]: Leaving directory '/home/eggert/src/gnu/emacs/master-tmp/src' make: *** [Makefile:421: src] Error 2 --------------FED6421367BBAB68D371E177 Content-Type: text/x-patch; name="0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch" >From bcdda254cb249950812a6b7122278a4d63761194 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 8 Dec 2018 15:29:07 -0800 Subject: [PATCH] Suppress WebKitGTK+ 2.21.1 diagnostics * src/xwidget.c: Suppress deprecation warnings. --- src/xwidget.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/xwidget.c b/src/xwidget.c index 6da7a0bb3f..24f7d39077 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -30,6 +30,14 @@ along with GNU Emacs. If not, see . */ #include #include +/* Suppress GCC deprecation warnings starting in WebKitGTK+ 2.21.1 for + webkit_javascript_result_get_global_context and + webkit_javascript_result_get_value. + FIXME: Use the JavaScriptCore GLib API instead, and remove this hack. */ +#if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0) +# pragma GCC diagnostic ignored "-Wdeprecated-declarations" +#endif + static struct xwidget * allocate_xwidget (void) { -- 2.19.2 --------------FED6421367BBAB68D371E177-- ------------=_1598046782-30615-1--