From unknown Wed Jun 18 23:18:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33669 <33669@debbugs.gnu.org> To: bug#33669 <33669@debbugs.gnu.org> Subject: Status: 26.1; Buffer-menu-mode bad UX Reply-To: bug#33669 <33669@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:18:15 +0000 retitle 33669 26.1; Buffer-menu-mode bad UX reassign 33669 emacs submitter 33669 Devon Sean McCullough severity 33669 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 21:07:23 2018 Received: (at submit) by debbugs.gnu.org; 8 Dec 2018 02:07:23 +0000 Received: from localhost ([127.0.0.1]:37447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVS1b-0000Vp-9J for submit@debbugs.gnu.org; Fri, 07 Dec 2018 21:07:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVS1X-0000Vb-FJ for submit@debbugs.gnu.org; Fri, 07 Dec 2018 21:07:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVS1Q-0006Jv-EO for submit@debbugs.gnu.org; Fri, 07 Dec 2018 21:07:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43628) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVS1O-0006Jj-Hs for submit@debbugs.gnu.org; Fri, 07 Dec 2018 21:07:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVS1M-0001CZ-J4 for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 21:07:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVS1I-0006JB-U8 for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 21:07:08 -0500 Received: from gateway31.websitewelcome.com ([192.185.143.46]:21966) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVS1I-0006H7-G9 for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 21:07:04 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 658912186E9 for ; Fri, 7 Dec 2018 20:06:52 -0600 (CST) Received: from leaf.websitewelcome.com ([192.185.82.99]) by cmsmtp with SMTP id VS16g1CtXaSeyVS16gByG6; Fri, 07 Dec 2018 20:06:52 -0600 X-Authority-Reason: nr=8 Received: from 42-98-21-212.static.netvigator.com ([42.98.21.212]:59263 helo=[192.168.23.103]) by leaf.websitewelcome.com with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.91) (envelope-from ) id 1gVS15-002xPf-HK for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 20:06:52 -0600 From: Devon Sean McCullough Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: 26.1; Buffer-menu-mode bad UX Message-Id: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> Date: Sat, 8 Dec 2018 10:06:48 +0800 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source-IP: 42.98.21.212 X-Source-L: No X-Exim-ID: 1gVS15-002xPf-HK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 42-98-21-212.static.netvigator.com ([192.168.23.103]) [42.98.21.212]:59263 X-Source-Auth: devon2011@jovi.net X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) When Buffer-menu-execute asks Buffer foo modified; kill anyway? (yes or no) and the reply is no, that line is removed anyway, deceiving the user by making the buffer menu incorrect. The user will promptly seek out such buffers =E2=80=94 but they = disappeared, giving the distressing wrong impression that they were killed anyway. Better keep the buffer menu accurate and show a helpful message like 7 buffers killed, 1 modified buffer kept to maintain harmony. Peace =E2=80=94Devon Je vous =C3=A9cris une longue lettre parce que je n'ai pas le temps = d'en =C3=A9crire une courte. Les provinciales (1656) de Blaise Pascal P.S. Sorry for not including a patch. In GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 = Version 10.10.5 (Build 14F2511)) of 2018-05-31 built on builder10-10.porkrind.org Windowing system distributor 'Apple', version 10.3.1404 Recent messages: Saving file = /ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_supplicant/= wpa_supplicant.conf... Renaming = /ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_supplicant/= wpa_supplicant.conf to = /ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_supplicant/= wpa_supplicant.conf.~2~...done Tramp: Encoding local file = =E2=80=98/var/folders/jv/9lctn91j0xqfv3f2kxc1lxx80000gn/T/tramp.dDYlW2.con= f=E2=80=99 using =E2=80=98base64-encode-region=E2=80=99...done Tramp: Decoding remote file = =E2=80=98/ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_su= pplicant/wpa_supplicant.conf=E2=80=99 using =E2=80=98base64 -d -i = >%s=E2=80=99...done Wrote = /ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_supplicant/= wpa_supplicant.conf Saving file = /ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_supplicant/= wpa_supplicant.conf... Tramp: Encoding local file = =E2=80=98/var/folders/jv/9lctn91j0xqfv3f2kxc1lxx80000gn/T/tramp.QgPFNM.con= f=E2=80=99 using =E2=80=98base64-encode-region=E2=80=99...done Tramp: Decoding remote file = =E2=80=98/ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_su= pplicant/wpa_supplicant.conf=E2=80=99 using =E2=80=98base64 -d -i = >%s=E2=80=99...done Wrote = /ssh:pi@RaspberryPi.local|sudo:root@RaspberryPi.local:/etc/wpa_supplicant/= wpa_supplicant.conf (New file) Configured using: 'configure --with-ns '--enable-locallisppath=3D/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tramp-cmds cl-print debug help-fns radix-tree help-mode easymenu sh-script smie executable conf-mode view misearch multi-isearch dired-aux files-x tramp-cache tramp-sh tramp tramp-compat tramp-loaddefs trampver shell pcomplete comint ansi-color ring parse-time format-spec advice auth-source cl-seq eieio byte-opt bytecomp byte-compile cconv eieio-core cl-macs gv eieio-loaddefs cl-loaddefs cl-lib password-cache dired dired-loaddefs elec-pair time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 246729 19322) (symbols 48 22835 1) (miscs 40 132 409) (strings 32 42302 1687) (string-bytes 1 1185010) (vectors 16 43513) (vector-slots 8 1207050 59552) (floats 8 71 383) (intervals 56 2095 247) (buffers 992 30)) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 06:08:13 2018 Received: (at 33669) by debbugs.gnu.org; 8 Dec 2018 11:08:13 +0000 Received: from localhost ([127.0.0.1]:37690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVaSy-0002go-TC for submit@debbugs.gnu.org; Sat, 08 Dec 2018 06:08:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVaSx-0002gc-CA for 33669@debbugs.gnu.org; Sat, 08 Dec 2018 06:08:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVaSo-0008UG-TW for 33669@debbugs.gnu.org; Sat, 08 Dec 2018 06:08:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVaSo-0008U4-Q7; Sat, 08 Dec 2018 06:08:02 -0500 Received: from [176.228.60.248] (port=2950 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gVaSm-0003Pe-Jk; Sat, 08 Dec 2018 06:08:02 -0500 Date: Sat, 08 Dec 2018 13:07:42 +0200 Message-Id: <83tvjo46pt.fsf@gnu.org> From: Eli Zaretskii To: Devon Sean McCullough In-reply-to: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> (message from Devon Sean McCullough on Sat, 8 Dec 2018 10:06:48 +0800) Subject: Re: bug#33669: 26.1; Buffer-menu-mode bad UX References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33669 Cc: 33669@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Devon Sean McCullough > Date: Sat, 8 Dec 2018 10:06:48 +0800 > > When Buffer-menu-execute asks > > Buffer foo modified; kill anyway? (yes or no) > > and the reply is no, > that line is removed anyway, deceiving the user > by making the buffer menu incorrect. > > The user will promptly seek out such buffers — but they disappeared, > giving the distressing wrong impression that they were killed anyway. Thanks for reporting this. Does the patch below give good results? diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index bc1288a..95746b3 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -476,9 +476,10 @@ Buffer-menu-execute (tabulated-list-set-col 2 " " t)) (error (warn "Error saving %s" buffer)))) (if delete - (unless (eq buffer (current-buffer)) - (kill-buffer buffer) - (tabulated-list-delete-entry)) + (if (and (not (eq buffer (current-buffer))) + (kill-buffer buffer)) + (tabulated-list-delete-entry) + (forward-line 1)) (forward-line 1))))))))) (defun Buffer-menu-select () From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 22 05:50:36 2018 Received: (at 33669) by debbugs.gnu.org; 22 Dec 2018 10:50:36 +0000 Received: from localhost ([127.0.0.1]:59196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaerb-0007uV-Uh for submit@debbugs.gnu.org; Sat, 22 Dec 2018 05:50:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaerb-0007uH-5k for 33669@debbugs.gnu.org; Sat, 22 Dec 2018 05:50:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaerS-0003Fp-Kt for 33669@debbugs.gnu.org; Sat, 22 Dec 2018 05:50:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaerQ-0003Dw-ME; Sat, 22 Dec 2018 05:50:24 -0500 Received: from [176.228.60.248] (port=1593 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gaerQ-0007YB-9a; Sat, 22 Dec 2018 05:50:24 -0500 Date: Sat, 22 Dec 2018 12:50:10 +0200 Message-Id: <83muoxal99.fsf@gnu.org> From: Eli Zaretskii To: Devon Sean McCullough In-reply-to: <83tvjo46pt.fsf@gnu.org> (message from Eli Zaretskii on Sat, 08 Dec 2018 13:07:42 +0200) Subject: Re: bug#33669: 26.1; Buffer-menu-mode bad UX References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> <83tvjo46pt.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33669 Cc: 33669@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ping! Devon, could you please try the proposed fix? > Date: Sat, 08 Dec 2018 13:07:42 +0200 > From: Eli Zaretskii > Cc: 33669@debbugs.gnu.org > > > From: Devon Sean McCullough > > Date: Sat, 8 Dec 2018 10:06:48 +0800 > > > > When Buffer-menu-execute asks > > > > Buffer foo modified; kill anyway? (yes or no) > > > > and the reply is no, > > that line is removed anyway, deceiving the user > > by making the buffer menu incorrect. > > > > The user will promptly seek out such buffers — but they disappeared, > > giving the distressing wrong impression that they were killed anyway. > > Thanks for reporting this. Does the patch below give good results? > > diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el > index bc1288a..95746b3 100644 > --- a/lisp/buff-menu.el > +++ b/lisp/buff-menu.el > @@ -476,9 +476,10 @@ Buffer-menu-execute > (tabulated-list-set-col 2 " " t)) > (error (warn "Error saving %s" buffer)))) > (if delete > - (unless (eq buffer (current-buffer)) > - (kill-buffer buffer) > - (tabulated-list-delete-entry)) > + (if (and (not (eq buffer (current-buffer))) > + (kill-buffer buffer)) > + (tabulated-list-delete-entry) > + (forward-line 1)) > (forward-line 1))))))))) > > (defun Buffer-menu-select () > > > > From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 05 03:45:20 2019 Received: (at 33669) by debbugs.gnu.org; 5 Jan 2019 08:45:21 +0000 Received: from localhost ([127.0.0.1]:47220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfha1-0007X6-7L for submit@debbugs.gnu.org; Sat, 05 Jan 2019 03:45:20 -0500 Received: from eggsout.gnu.org ([209.51.188.92]:42924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfhZz-0007Ww-Av for 33669@debbugs.gnu.org; Sat, 05 Jan 2019 03:45:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfhZu-0003DK-Sk for 33669@debbugs.gnu.org; Sat, 05 Jan 2019 03:45:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfhZu-0003DE-Pj; Sat, 05 Jan 2019 03:45:10 -0500 Received: from [176.228.60.248] (port=4686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gfhZu-0002k7-C3; Sat, 05 Jan 2019 03:45:10 -0500 Date: Sat, 05 Jan 2019 10:44:51 +0200 Message-Id: <83o98v1ojg.fsf@gnu.org> From: Eli Zaretskii To: Emacs-Hacker2018@jovi.net In-reply-to: <83muoxal99.fsf@gnu.org> (message from Eli Zaretskii on Sat, 22 Dec 2018 12:50:10 +0200) Subject: Re: bug#33669: 26.1; Buffer-menu-mode bad UX References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> <83tvjo46pt.fsf@gnu.org> <83muoxal99.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33669 Cc: 33669@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ping! Ping! Devon, could you please try the proposed fix? > Date: Sat, 22 Dec 2018 12:50:10 +0200 > From: Eli Zaretskii > Cc: 33669@debbugs.gnu.org > > Ping! Devon, could you please try the proposed fix? > > > Date: Sat, 08 Dec 2018 13:07:42 +0200 > > From: Eli Zaretskii > > Cc: 33669@debbugs.gnu.org > > > > > From: Devon Sean McCullough > > > Date: Sat, 8 Dec 2018 10:06:48 +0800 > > > > > > When Buffer-menu-execute asks > > > > > > Buffer foo modified; kill anyway? (yes or no) > > > > > > and the reply is no, > > > that line is removed anyway, deceiving the user > > > by making the buffer menu incorrect. > > > > > > The user will promptly seek out such buffers — but they disappeared, > > > giving the distressing wrong impression that they were killed anyway. > > > > Thanks for reporting this. Does the patch below give good results? > > > > diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el > > index bc1288a..95746b3 100644 > > --- a/lisp/buff-menu.el > > +++ b/lisp/buff-menu.el > > @@ -476,9 +476,10 @@ Buffer-menu-execute > > (tabulated-list-set-col 2 " " t)) > > (error (warn "Error saving %s" buffer)))) > > (if delete > > - (unless (eq buffer (current-buffer)) > > - (kill-buffer buffer) > > - (tabulated-list-delete-entry)) > > + (if (and (not (eq buffer (current-buffer))) > > + (kill-buffer buffer)) > > + (tabulated-list-delete-entry) > > + (forward-line 1)) > > (forward-line 1))))))))) > > > > (defun Buffer-menu-select () > > > > > > > > > > > > From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 12 06:53:55 2019 Received: (at 33669-done) by debbugs.gnu.org; 12 Jan 2019 11:53:55 +0000 Received: from localhost ([127.0.0.1]:56590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHrO-0003ye-RE for submit@debbugs.gnu.org; Sat, 12 Jan 2019 06:53:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHrN-0003yQ-3u for 33669-done@debbugs.gnu.org; Sat, 12 Jan 2019 06:53:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHrH-0004VZ-Lq; Sat, 12 Jan 2019 06:53:47 -0500 Received: from [176.228.60.248] (port=2805 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1giHrH-0001Tv-9E; Sat, 12 Jan 2019 06:53:47 -0500 Date: Sat, 12 Jan 2019 13:53:28 +0200 Message-Id: <83ef9if5xj.fsf@gnu.org> From: Eli Zaretskii To: Devon Sean McCullough In-reply-to: <0D3D3224-4085-4608-9367-02F51D74B528@jovi.net> (message from Devon Sean McCullough on Sat, 5 Jan 2019 10:36:22 -0500) Subject: Re: bug#33669: 26.1; Buffer-menu-mode bad UX References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> <83tvjo46pt.fsf@gnu.org> <83muoxal99.fsf@gnu.org> <83o98v1ojg.fsf@gnu.org> <0D3D3224-4085-4608-9367-02F51D74B528@jovi.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33669-done Cc: 33669-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Devon Sean McCullough > Date: Sat, 5 Jan 2019 10:36:22 -0500 > > > On Jan 5, 2019, at 3:44 AM, Eli Zaretskii wrote: > > Ping! Ping! Devon, could you please try the proposed fix? > > The original and patched versions both look problematic. Instead, I had good results with > > --- old/buff-menu.el 2019-01-05 10:26:45.000000000 -0500 > +++ new/buff-menu.el 2019-01-05 10:27:23.000000000 -0500 > @@ -475,10 +475,10 @@ > (save-buffer)) > (tabulated-list-set-col 2 " " t)) > (error (warn "Error saving %s" buffer)))) > - (if delete > - (unless (eq buffer (current-buffer)) > - (kill-buffer buffer) > - (tabulated-list-delete-entry)) > + (if (and delete > + (not (eq buffer (current-buffer))) > + (kill-buffer buffer)) > + (tabulated-list-delete-entry) > (forward-line 1))))))))) > > (defun Buffer-menu-select () > Thanks, pushed to the emacs-26 branch. From unknown Wed Jun 18 23:18:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Feb 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator