GNU bug report logs - #33665
27.0.50; Variables not set up in Gnus when hooks are run

Previous Next

Full log

Message #17 received at 33665 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 33665 <at> debbugs.gnu.org
Subject: Re: bug#33665: 27.0.50;
 Variables not set up in Gnus when hooks are run
Date: Fri, 07 Dec 2018 10:36:18 -0800

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>>
>>> It looks like gnus-newsgroup-name (and friends?) are no longer set when
>>> the summary mode hooks are run, so hooks that rely on that are now
>>> broken.
>>
>> Yes, since `gnus-summary-mode' is now a real mode, it clears local
>> variables before running the hook. The right place for that sort of hook
>> is now `gnus-summary-prepared-hook'. I tried to change all the relevant
>> hooks I could within the codebase, but I guess gnus-mdrtn.el isn't
>> publicly available? I can change the Moderation section of the manual to
>> update the installation instructions.
>
> No, you can't break third-party software that way.  You have to set the
> variables the hooks expect to exist before calling the hook.

Okay. This patch should restore that behavior. I don't see any other
buffer-local variables that were being set to a specific value, other
than `gnus-newsgroup-name'.

[patch.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.