From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 06 17:39:45 2018 Received: (at submit) by debbugs.gnu.org; 6 Dec 2018 22:39:45 +0000 Received: from localhost ([127.0.0.1]:36123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gV2J6-0005t4-Sm for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:39:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gV2J5-0005so-Cz for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:39:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gV2Ix-0001Rr-T6 for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:39:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gV2Ix-0001R8-PE for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:39:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gV2Iv-0000hD-S7 for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 17:39:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gV2Is-0001Fw-Lc for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 17:39:33 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:45783) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gV2Is-00017W-9m for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 17:39:30 -0500 Received: from localhost (unknown [207.109.85.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id EA8963F46A for ; Thu, 6 Dec 2018 22:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1544135960; bh=xPP4HOCNqOoTJ2tUCzV7mOwH3i18k3nO+sX3clJvMj8=; h=From:To:Subject:Date:From; b=eJRYKaqH37O/oh4qZN7Fzsiigwr/nSoRyr524KeS21CzO23N98Vo2REdszLUgFZBo O8IAYQv4qX+I4UAMAkFm68ERyEf1QqXHC44UICpcRvUMQtrsm9pgKsizzqBXxWzGX4 ZBrRETemMKMz/8KIHN+aoKXUKBKgUx5BTGxX236Q= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Thu, 06 Dec 2018 14:39:07 -0800 Message-ID: <8736raz3ec.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Here's the next thing: turning Gnus' obarrays-as-hash-tables into real hash tables. Gnus currently stores information about groups by coercing group names to unibyte, interning them in custom obarrays, and then setting their symbol-value to whatever value needs to be stored. I think all this was written before Emacs had actual hash tables. I think real hash tables are better for a few reasons: 1. Hash table lookups seem to be marginally faster than obarray lookups, 2. It's "less weird" for contributors and bug hunters, 3. It allows us to reduces the amount of encoding/decoding going on: group names can stay strings instead of being forced into symbols. I've pushed a branch, scratch/gnus-hashtables, with two commits in it. The first changes all the obarrays to hash tables. Apart from simply replacing function calls, there were a few bumps. 1. Gnus uses `text-property-any' to find and compare group-name text properties; I made a new `gnus-text-property-search' which behaves similarly, but compares with equal. 2. Some of the "hash tables" were simply storing the value t, ie just used for membership. I left these as hash tables, but I think in many cases simple string-in-list membership tests would suffice. 3. The hash table in gnus-async.el didn't appear to be doing anything -- it seemed to be redundant with `gnus-async-article-alist'. I've removed it, but it might need to be put back if I'm missing something. 4. The creation of `gnus-newsgroup-dependencies' was the most fiddly, and I added tests for that. I'm not entirely convinced that `gnus-thread-loop-p' behaves the way it's meant to, it appears to only check for direct loops between parent and child, not parent and descendant. 5. The old return value of (gnus-gethash gnus-newsrc-hashtb) was kind of a slice into `gnus-newsrc-alist': it behaved a bit like `member', but also included the group *before* the group you wanted, as well as all those after, so you could traverse the list in either direction. It now no longer preserves the order of `gnus-newsrc-alist' (this ordering wasn't actually used in many places), and instead there's a new variable `gnus-group-list' which records the proper sort order of the groups. I feel fairly confident that all this is working okay. The second commit I do *not* feel very confident about, and it's more of a "let's see how things break" attempt. In theory, we should now be able to limit group name encoding/decoding to the boundaries of Gnus -- reading/writing active files, and talking to servers. Within Gnus, the group names can remain decoded strings. In the second commit I've just gone in and pulled out all the decoding I can find, changed all the 'raw-text encoding options to 'undecided, and deleted the `mm-disable-multibyte's. I have no confidence that I've covered all the bases, though I have been using this branch for a couple of weeks, with nnml, nnmaildir, and nnimap groups with multibyte names, and so far nothing has broken. I'm less confident about nntp. I'll continue working on this, and I hope I can get some feedback here, particularly on the second commit. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 06 17:46:50 2018 Received: (at submit) by debbugs.gnu.org; 6 Dec 2018 22:46:50 +0000 Received: from localhost ([127.0.0.1]:36128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gV2Px-0007TB-Np for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:46:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gV2Pw-0007Od-0u for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:46:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gV2Pq-00006i-48 for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:46:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gV2Pp-00006T-W3 for submit@debbugs.gnu.org; Thu, 06 Dec 2018 17:46:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gV2Pp-00044B-BT for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 17:46:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gV2Pk-0008Sz-DX for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 17:46:41 -0500 Received: from [195.159.176.226] (port=47556 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gV2Pj-0008Ph-2w for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 17:46:36 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1gV2NV-0004sb-GZ for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2018 23:44:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Thu, 06 Dec 2018 14:46:22 -0800 Lines: 9 Message-ID: <87y392xoht.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:7f9XI6WnaID3nvwucuG7I4udgIE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Eric Abrahamsen writes: > Here's the next thing: turning Gnus' obarrays-as-hash-tables into real > hash tables. Gnus currently stores information about groups by coercing > group names to unibyte, interning them in custom obarrays, and then > setting their symbol-value to whatever value needs to be stored. I think > all this was written before Emacs had actual hash tables. Also hounding Lars for his opinion... From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 18:30:40 2018 Received: (at 33653) by debbugs.gnu.org; 11 Dec 2018 23:30:40 +0000 Received: from localhost ([127.0.0.1]:44281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWrU8-0004wH-EY for submit@debbugs.gnu.org; Tue, 11 Dec 2018 18:30:40 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:52691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWrU7-0004wA-1H for 33653@debbugs.gnu.org; Tue, 11 Dec 2018 18:30:39 -0500 Received: from localhost (unknown [207.109.85.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 460183FB3D; Tue, 11 Dec 2018 23:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1544571038; bh=CcYACM96+IV18GKldJHQEmdOl7iur3AIUZvqgDLMMNk=; h=From:To:Subject:References:Date:In-Reply-To:From; b=L759zXOdeh25ZbOPneWeM4oCEGtwo1kg6ZltAIljBpOjcNqR2Bj5pPvrhBhDj0Lws BpTNR0adLpsoCJeahU4a0xsD3kzyvEWp0HMRZ7Mmdxrbp8WEPPx0V5c17+k3ID2ShN WEjxxX/kY8grJ3uDXC1YKQ+AHDnfq0atg9ay49YI= From: Eric Abrahamsen To: Lars Ingebrigtsen , 33653@debbugs.gnu.org Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> Date: Tue, 11 Dec 2018 15:30:29 -0800 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 11 Dec 2018 20:23:33 +0100") Message-ID: <87bm5rproq.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33653 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/11/18 20:23 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >>> Here's the next thing: turning Gnus' obarrays-as-hash-tables into real >>> hash tables. Gnus currently stores information about groups by coercing >>> group names to unibyte, interning them in custom obarrays, and then >>> setting their symbol-value to whatever value needs to be stored. I think >>> all this was written before Emacs had actual hash tables. >> >> Also hounding Lars for his opinion... > > Using real hash tables sounds nice, if there's no negative performance > impact. Cool! In fact it seems to be a hair faster. If you have a moment for this, would you look at the second commit in the scratch/gnus-hashtables branch? The first commit seems fairly stable, but the second has to do with encoding -- if group names never need to be unibyte, it should be possible to leave them decoded inside Gnus itself. Besides active files and server communication, are there any other places where group names would need to be encoded? Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 04 21:05:47 2019 Received: (at 33653) by debbugs.gnu.org; 5 Feb 2019 02:05:47 +0000 Received: from localhost ([127.0.0.1]:59951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqq7O-000189-UZ for submit@debbugs.gnu.org; Mon, 04 Feb 2019 21:05:47 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:49793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqq7M-000180-Np for 33653@debbugs.gnu.org; Mon, 04 Feb 2019 21:05:45 -0500 Received: from localhost (c-73-97-148-38.hsd1.wa.comcast.net [73.97.148.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CD3203F042; Tue, 5 Feb 2019 02:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1549332341; bh=lNwGU3KORoazAtgYqPk9gKHIZMAgCh6QTstM7bm4zWg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=zP5HV7nKUFSwy3KcFhr2KZW0H8bugzJd1KwG3wkfsVpWPWmQE/hlid9ErOwC5Ed6l SylB9IaEVATcnR0y0I2PahQklWtbBXTHhc5BS14O/uHNesUEhiJzdTH2/+1IxCR2Mg H08f/cmIjuNkW1TaiqDQZDZwHezhhsiwAOQZeJW0= From: Eric Abrahamsen To: 33653@debbugs.gnu.org Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> Date: Mon, 04 Feb 2019 18:05:39 -0800 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 11 Dec 2018 20:23:33 +0100") Message-ID: <87imxzxa4s.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33653 Cc: Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/11/18 20:23 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >>> Here's the next thing: turning Gnus' obarrays-as-hash-tables into real >>> hash tables. Gnus currently stores information about groups by coercing >>> group names to unibyte, interning them in custom obarrays, and then >>> setting their symbol-value to whatever value needs to be stored. I think >>> all this was written before Emacs had actual hash tables. >> >> Also hounding Lars for his opinion... > > Using real hash tables sounds nice, if there's no negative performance > impact. I've pushed another commit to scratch/gnus-hashtables, fixing a small bug in gnus-bklg.el. Otherwise, I've been using this branch for a couple months now, with no ill effects. I guess what I'd like to do is squash the first commit with the third (the changes that actually implement the hash tables), but leave the second aside for now (the one that stops doing internal encoding/decoding). That ought to be done eventually, but I'll need more time to figure it out, and would like to get more exposure for this refactoring in the meantime. Eric From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 21 20:09:24 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 00:09:24 +0000 Received: from localhost ([127.0.0.1]:53774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h77kR-0003JF-ND for submit@debbugs.gnu.org; Thu, 21 Mar 2019 20:09:24 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:60678 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h77kO-0003Iw-FJ for 33653@debbugs.gnu.org; Thu, 21 Mar 2019 20:09:21 -0400 Received: from localhost (unknown [172.58.43.108]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1988EFA02B; Fri, 22 Mar 2019 00:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553213354; bh=T44EwCU5FpCpZWMDKg7FIadjgrGqmuFoh5IEJaDxdS4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=w+ttwH/Vw3NqGqPvJrQh+mP+7/+bi03ocu1sxdG+H09PXsPlJxH3jHMWmc52wfKqy oRLK4+drjzGUZ6yDsJg/nDvJV+mqQU85yqDav9FCgv9cr2DSOMPZrCZsSwtGLTbfM8 byygJrGCZ+eaqH6z+nY2T4/BwOhs2kFpO9rjH9g4= From: Eric Abrahamsen To: 33653@debbugs.gnu.org Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> Date: Thu, 21 Mar 2019 17:09:07 -0700 In-Reply-To: <87imxzxa4s.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 04 Feb 2019 18:05:39 -0800") Message-ID: <87a7hn3h3w.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 02/04/19 18:05 PM, Eric Abrahamsen wrote: > On 12/11/18 20:23 PM, Lars Ingebrigtsen wrote: >> Eric Abrahamsen writes: >> >>>> Here's the next thing: turning Gnus' obarrays-as-hash-tables into real >>>> hash tables. Gnus currently stores information about groups by coercing >>>> group names to unibyte, interning them in custom obarrays, and then >>>> setting their symbol-value to whatever value needs to be stored. I think >>>> all this was written before Emacs had actual hash tables. >>> >>> Also hounding Lars for his opinion... >> >> Using real hash tables sounds nice, if there's no negative performance >> impact. > > I've pushed another commit to scratch/gnus-hashtables, fixing a small > bug in gnus-bklg.el. Otherwise, I've been using this branch for a couple > months now, with no ill effects. > > I guess what I'd like to do is squash the first commit with the third > (the changes that actually implement the hash tables), but leave the > second aside for now (the one that stops doing internal > encoding/decoding). Weeeeelll... I'd really like to push this. I promise to be on hand with quick fixes, and a revert if necessary. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 05:20:59 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 09:20:59 +0000 Received: from localhost ([127.0.0.1]:53992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7GME-0002Bg-OE for submit@debbugs.gnu.org; Fri, 22 Mar 2019 05:20:58 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:43915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7GMC-0002BR-Uv for 33653@debbugs.gnu.org; Fri, 22 Mar 2019 05:20:57 -0400 Received: by mail-wr1-f54.google.com with SMTP id d17so1472989wre.10 for <33653@debbugs.gnu.org>; Fri, 22 Mar 2019 02:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=IUXfsa4fi1PMxxrdX892kM/Ofs/9DFE1g4i47iGO4PE=; b=JPT26K5hWOpD8w2sDckMlWVvh4uNJFS6Gc+GUfOR4XduVWyAdLfN5bjXKfPA1F4VY4 t2IZQHUK0RiqOt3yG5n65D6rYMb4XKlOpx8vdLLSlrN5zNL2iH9qRv9Wu6syhUwcOC7c 7kvLLjJUcTLJ9mQvBM+XS98jDlAkvlQrl5n2SAeEmZ4NQZA8jkKVqUPQ1psj3hmcsDMW WLXPBwkqutoIb9nhrfraXeGOrxI7cqrx+Iu1hKTCb2aV4rEfbEIjB3auXLSbg1MfaS83 PPD4wq82RMAU6JG4p7YA/oXYahFvhcQu8IeMe2KB8Xb+pN0hIui+dIv6Vj6YrIuh7QJp nuLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=IUXfsa4fi1PMxxrdX892kM/Ofs/9DFE1g4i47iGO4PE=; b=NY8OSNVRZsK+Lfo9mwlj0/iNPMPqa9sSyyWvxsHPZM+k9qrQJEXf+qM330s4HvvE5b ZBthmsE5M+REg3laCGSwNXCgSQsNgVmM0TUT0i0eBo+UKlf3BaLqcGgG7Z2AgOZFOQeo U3ON/+jHoNs481qPDG8lSJ/lYraARgiNKCrmtJzb3sDiEeWXg1BLpckMuYhneIq1BONE VQU7mGF+R6trZ3/7oFcG4+jERjkvxNScjckbysFtKGosDsDkxPQQp9k6irr9ziwX5JGF HLjrDar3ZWm0+5xCE5n/Iy1hdkC/BHgrbFqWxEli586U9+fGsJPYRCvt+zYHtKW7c1Ag U0/A== X-Gm-Message-State: APjAAAUhOxNGQo1EVNyVavfTQydgv4Bc9b+Fnen+pC8jgy7o2w9EYxEM kN2tMCu6LzTmDa5ChhEmBU3M6V/1 X-Google-Smtp-Source: APXvYqyYfzeH+jP1Gk+Rk/lOEA7NFQCw04t0kxPASyAl3/h7nc9O2T/PAa0wRECZdxOVq+7LRota1w== X-Received: by 2002:a5d:52ca:: with SMTP id r10mr5870864wrv.187.1553246451348; Fri, 22 Mar 2019 02:20:51 -0700 (PDT) Received: from rpluim-mac ([90.85.83.105]) by smtp.gmail.com with ESMTPSA id 204sm12072012wmc.1.2019.03.22.02.20.50 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 22 Mar 2019 02:20:50 -0700 (PDT) From: Robert Pluim To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 22 Mar 2019 10:20:49 +0100 In-Reply-To: <87a7hn3h3w.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 21 Mar 2019 17:09:07 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Lars Ingebrigtsen , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 21 Mar 2019 17:09:07 -0700, Eric Abrahamsen said: Eric> Weeeeelll... I'd really like to push this. I promise to be Eric> on hand with quick fixes, and a revert if necessary. This is for emacs-27, right? I=CA=BCd say go for it :-) Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 13:22:10 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 17:22:11 +0000 Received: from localhost ([127.0.0.1]:54634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Nru-0001Q2-Lr for submit@debbugs.gnu.org; Fri, 22 Mar 2019 13:22:10 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:33814 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Nrq-0001P8-TJ for 33653@debbugs.gnu.org; Fri, 22 Mar 2019 13:22:08 -0400 Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BADDFFA17F; Fri, 22 Mar 2019 17:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553275321; bh=UpYqimk2t+q4V6MpvT47D9Uy1fPBhJydXScFIZKmOJU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P9Nei2CbWA8W6I5egYack7HsFrau5XJtMD3oLj1fyv1eVUv3d8fBYH1AQymrPhJM7 mm5VNhuxy+yGIkNWQCfZGfwpA5/t0gr8bAmEc7e/of1y68R2q1CzxpFx50PgbAjXX2 6G9/7nQkG4gsFVlKVGKH2MylCBnaitVs0Np4OAHw= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> Date: Fri, 22 Mar 2019 10:21:58 -0700 In-Reply-To: (Robert Pluim's message of "Fri, 22 Mar 2019 10:20:49 +0100") Message-ID: <87mulmkeo9.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: >>>>>> On Thu, 21 Mar 2019 17:09:07 -0700, Eric Abrahamsen said: > > Eric> Weeeeelll... I'd really like to push this. I promise to be > Eric> on hand with quick fixes, and a revert if necessary. > > This is for emacs-27, right?=20 Most definitely. > I=CA=BCd say go for it :-) Okay, if it explodes I'll say you said I could do it! :) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 15:55:04 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 19:55:04 +0000 Received: from localhost ([127.0.0.1]:54702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7QFs-00051g-Cg for submit@debbugs.gnu.org; Fri, 22 Mar 2019 15:55:04 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:34158 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7QFq-000515-Ch for 33653@debbugs.gnu.org; Fri, 22 Mar 2019 15:55:03 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 6A162FA17F for <33653@debbugs.gnu.org>; Fri, 22 Mar 2019 19:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553284496; bh=7IRHSEhMJd1V5o4My5RtHl6UAm7Shp/GvroDXdzZdjI=; h=From:To:Subject:References:Date:In-Reply-To:From; b=aoLpNxLWc6Ma4D10XhCSfbmoYBvQ+6gpzR2w0V2vs29V5PMw/EmOsIk5mWbbnJfyx QSpdCJZIvdJwb7AlZTM4NOnqZMv+N7vXTmh1tcqjxmI5Jote321to5pBkk8wMj3a2t 82Olmtvv49XqUIs57Z/xzKMsH1rUJ2hNUv++HK4Y= From: Eric Abrahamsen To: 33653@debbugs.gnu.org Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> Date: Fri, 22 Mar 2019 12:54:54 -0700 In-Reply-To: <87mulmkeo9.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 22 Mar 2019 10:21:58 -0700") Message-ID: <87pnqik7ld.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Robert Pluim writes: > >>>>>>> On Thu, 21 Mar 2019 17:09:07 -0700, Eric Abrahamsen said: >> >> Eric> Weeeeelll... I'd really like to push this. I promise to be >> Eric> on hand with quick fixes, and a revert if necessary. >> >> This is for emacs-27, right?=20 > > Most definitely. > >> I=CA=BCd say go for it :-) > > Okay, if it explodes I'll say you said I could do it! :) And... it exploded! Well, not really, but on my second machine there were a pile of stale *.elc files that aren't rebuilt with the new macro definitions, and even "make distclean" doesn't get rid of them (?), I had to go into the lisp/gnus directory, manually delete the elc files, and run "make" again. (Or maybe this is what "make bootstrap" does?) This must happen from time to time -- is there anything to be done besides warning people on the mailing lists? The bummer is that you don't get an error until you run Gnus, so it just looks like I broke Gnus :( Eric From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 17:14:40 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 21:14:40 +0000 Received: from localhost ([127.0.0.1]:54741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7RUs-0000Wn-JJ for submit@debbugs.gnu.org; Fri, 22 Mar 2019 17:14:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7RUq-0000WY-FO for 33653@debbugs.gnu.org; Fri, 22 Mar 2019 17:14:37 -0400 Received: from fencepost.gnu.org ([209.51.188.10]:37518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7RUj-00083E-FA; Fri, 22 Mar 2019 17:14:30 -0400 Received: from [176.228.60.248] (port=3145 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7RNq-0001fM-L8; Fri, 22 Mar 2019 17:07:23 -0400 Date: Fri, 22 Mar 2019 23:07:19 +0200 Message-Id: <834l7ur52w.fsf@gnu.org> From: Eli Zaretskii To: Eric Abrahamsen In-reply-to: <87pnqik7ld.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Fri, 22 Mar 2019 12:54:54 -0700) Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Eric Abrahamsen > Date: Fri, 22 Mar 2019 12:54:54 -0700 > > is there anything to be done besides warning people on the mailing > lists? A warning would be nice, yes. > "make distclean" doesn't get rid of them (?), I had to go into the > lisp/gnus directory, manually delete the elc files, and run "make" > again. (Or maybe this is what "make bootstrap" does?) Yes, that's what a bootstrap does (if you don't mind doing a bootstrap in such situations). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 18:25:07 2019 Received: (at submit) by debbugs.gnu.org; 22 Mar 2019 22:25:08 +0000 Received: from localhost ([127.0.0.1]:54807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Sb5-0002Je-JW for submit@debbugs.gnu.org; Fri, 22 Mar 2019 18:25:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Sb4-0002J6-0q for submit@debbugs.gnu.org; Fri, 22 Mar 2019 18:25:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:45806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7Sav-00083g-F3 for submit@debbugs.gnu.org; Fri, 22 Mar 2019 18:25:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7SNo-0005Rd-VH for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 18:11:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7SNn-0001UR-P9 for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 18:11:24 -0400 Received: from [195.159.176.226] (port=59990 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7SNH-0000fx-RA for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 18:11:23 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h7SNC-000dEI-2m for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2019 23:10:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Fri, 22 Mar 2019 15:10:38 -0700 Message-ID: <877ecqk1b5.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <834l7ur52w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:u9JxLqvMrkqcWctN5tKCyFq4jC4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Eric Abrahamsen >> Date: Fri, 22 Mar 2019 12:54:54 -0700 >> >> is there anything to be done besides warning people on the mailing >> lists? > > A warning would be nice, yes. Okay, I'll do that. I've already gotten a bug report :( >> "make distclean" doesn't get rid of them (?), I had to go into the >> lisp/gnus directory, manually delete the elc files, and run "make" >> again. (Or maybe this is what "make bootstrap" does?) > > Yes, that's what a bootstrap does (if you don't mind doing a bootstrap > in such situations). Got it, thank you. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 18:41:10 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 22:41:10 +0000 Received: from localhost ([127.0.0.1]:54812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7Sqc-0002jo-1J for submit@debbugs.gnu.org; Fri, 22 Mar 2019 18:41:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7SqZ-0002jY-SI for 33653@debbugs.gnu.org; Fri, 22 Mar 2019 18:41:08 -0400 Received: from fencepost.gnu.org ([209.51.188.10]:38952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7SqF-0007Eo-1N; Fri, 22 Mar 2019 18:41:00 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1h7SqE-0006NJ-8S; Fri, 22 Mar 2019 18:40:46 -0400 From: Glenn Morris To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> X-Spook: Lockdown Federal Emergency Management Agency Resistant X-Ran: VkJ7zU|K%0Br$``BQ3_H`F:MagA:hfr$n,0[9K:YgJV_(]:|%`=XQ*?[tZ:d[6 (Eric Abrahamsen's message of "Fri, 22 Mar 2019 12:54:54 -0700") Message-ID: <1hzhpmttw2.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen wrote: > even "make distclean" doesn't get rid of them (?), Because .elc files are distributed in release tarfiles. > This must happen from time to time -- is there anything to be done > besides warning people on the mailing lists? 1a) make bootstrap the default make target. 1b) rename the current default make target as faster-but-sometimes-will-go-wrong-for-obscure-reasons CPU time is cheaper than human time spent figuring out problems. 2) Make load-prefer-newer non-nil by default. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 18:51:54 2019 Received: (at 33653) by debbugs.gnu.org; 22 Mar 2019 22:51:54 +0000 Received: from localhost ([127.0.0.1]:54820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7T0z-00032J-Gz for submit@debbugs.gnu.org; Fri, 22 Mar 2019 18:51:54 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:34574 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7T0w-000323-MB for 33653@debbugs.gnu.org; Fri, 22 Mar 2019 18:51:51 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1953EFA17F for <33653@debbugs.gnu.org>; Fri, 22 Mar 2019 22:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553295104; bh=rNBcVkyYtpsNe3dhqEHvBVv1E5egNZ9XsV9PLXz58cU=; h=From:To:Subject:References:Date:In-Reply-To:From; b=my16nDbJT2OyrS/Re9lNDGM6Qia77fFZhCu6zCYoCnl62oCt1SuTE+8QI+ynoe95r dwJ0S7lA4pM9Y4oYcCgTajLiLYlr+L2TdyRNkXm4HTnRLhvyJNME5/zyM0yvPKG/gR ThS72a1Fh8mm27A18sKrbqty5sYJpXzKNKsWfFZs= From: Eric Abrahamsen To: 33653@debbugs.gnu.org Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <1hzhpmttw2.fsf@fencepost.gnu.org> Date: Fri, 22 Mar 2019 15:51:40 -0700 In-Reply-To: <1hzhpmttw2.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 22 Mar 2019 18:40:45 -0400") Message-ID: <87a7hmttdv.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 03/22/19 18:40 PM, Glenn Morris wrote: > Eric Abrahamsen wrote: > > >> even "make distclean" doesn't get rid of them (?), > > Because .elc files are distributed in release tarfiles. Right, that makes sense. >> This must happen from time to time -- is there anything to be done >> besides warning people on the mailing lists? > > 1a) make bootstrap the default make target. > 1b) rename the current default make target as > faster-but-sometimes-will-go-wrong-for-obscure-reasons Obviously this is the best solution! > CPU time is cheaper than human time spent figuring out problems. > > 2) Make load-prefer-newer non-nil by default. I didn't know about this, and really like it. Recently Emacs seems to save up all the "foo.el is newer than compiled file" warnings and feed them to me at random intervals, usually while I'm trying to use the minibuffer. Maybe this option will fix that. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 02:46:15 2019 Received: (at 33653) by debbugs.gnu.org; 23 Mar 2019 06:46:15 +0000 Received: from localhost ([127.0.0.1]:54932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7aQ2-0006dV-4n for submit@debbugs.gnu.org; Sat, 23 Mar 2019 02:46:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7aQ0-0006dJ-O0 for 33653@debbugs.gnu.org; Sat, 23 Mar 2019 02:46:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7aPu-0004Fq-Ru; Sat, 23 Mar 2019 02:46:07 -0400 Received: from [176.228.60.248] (port=2797 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7aPs-0000XS-Vh; Sat, 23 Mar 2019 02:46:05 -0400 Date: Sat, 23 Mar 2019 08:46:02 +0200 Message-Id: <831s2yqead.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: <1hzhpmttw2.fsf@fencepost.gnu.org> (message from Glenn Morris on Fri, 22 Mar 2019 18:40:45 -0400) Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <1hzhpmttw2.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: eric@ericabrahamsen.net, 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Glenn Morris > Date: Fri, 22 Mar 2019 18:40:45 -0400 > Cc: 33653@debbugs.gnu.org > > 1a) make bootstrap the default make target. Don't know about the others, but almost I never bootstrap, except in a fresh checkout. The reasons are (a) it's slow, and I don't want to wait for 10 or so minutes just because I updated from upstream; and (b) it deletes all previous executables of Emacs, which I use for fast-bisecting reported problems. When these rare situations happen, it is not hard to guess the file whose .elc should be removed and regenerated; if worse comes to worst, deleting all the *.elc files in the relevant subdirectory (lisp/gnus/ in this case) and typing "make" solves the problem much faster for me, and without the unwanted side effects. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 11:00:05 2019 Received: (at submit) by debbugs.gnu.org; 23 Mar 2019 15:00:05 +0000 Received: from localhost ([127.0.0.1]:55657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7i7u-0005pe-Qg for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:00:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7i7s-0005oe-KU for submit@debbugs.gnu.org; Sat, 23 Mar 2019 11:00:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:40430) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7i7n-0001q1-6Y for submit@debbugs.gnu.org; Sat, 23 Mar 2019 10:59:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7i7m-0001Xn-4Y for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 10:59:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_05,FREEMAIL_FROM, RDNS_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7i0Z-0004oh-3N for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 10:52:28 -0400 Received: from [195.159.176.226] (port=38108 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7i0Y-0004nu-K3 for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 10:52:26 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h7i0U-000ct3-Hx for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 15:52:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Sat, 23 Mar 2019 14:52:16 +0000 Message-ID: <86imw9abj3.fsf@gmail.com> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <834l7ur52w.fsf@gnu.org> <877ecqk1b5.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:BpLHZWTu7XHreloxoy5j/4Tx5Pw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri 22 Mar 2019, Eric Abrahamsen wrote: > Eli Zaretskii writes: > >>> From: Eric Abrahamsen >>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>> >>> is there anything to be done besides warning people on the mailing >>> lists? >> >> A warning [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ericabrahamsen.net] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andrewjmoreton[at]gmail.com) 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Fri 22 Mar 2019, Eric Abrahamsen wrote: > Eli Zaretskii writes: > >>> From: Eric Abrahamsen >>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>> >>> is there anything to be done besides warning people on the mailing >>> lists? >> >> A warning would be nice, yes. > > Okay, I'll do that. I've already gotten a bug report :( After bootstrapping, I observe that the summary buffer does not update the faces correctly for nntp articles that have been read: they still have an unread face. AndyM From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 23 12:14:45 2019 Received: (at submit) by debbugs.gnu.org; 23 Mar 2019 16:14:45 +0000 Received: from localhost ([127.0.0.1]:55721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7jID-0007cL-3X for submit@debbugs.gnu.org; Sat, 23 Mar 2019 12:14:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7jIB-0007c9-Vp for submit@debbugs.gnu.org; Sat, 23 Mar 2019 12:14:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:51765) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7jI6-0007i5-Sl for submit@debbugs.gnu.org; Sat, 23 Mar 2019 12:14:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7jI5-0000PK-Oc for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 12:14:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_20,RDNS_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7jI4-0007ff-8D for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 12:14:37 -0400 Received: from [195.159.176.226] (port=46490 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7jI3-0007dp-W5 for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 12:14:36 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h7jI1-000vi8-6B for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2019 17:14:33 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Sat, 23 Mar 2019 09:14:26 -0700 Message-ID: <877ecpo9el.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <834l7ur52w.fsf@gnu.org> <877ecqk1b5.fsf@ericabrahamsen.net> <86imw9abj3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:M6c+uC9a7SiWiPJinYkI38wiUxA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andy Moreton writes: > On Fri 22 Mar 2019, Eric Abrahamsen wrote: > >> Eli Zaretskii writes: >> >>>> From: Eric Abrahamsen >>>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>>> >>>> is there anything to be done besides warning people on the mailing >>>> lists? >>> >>> A warning would be nice, yes. >> >> Okay, I'll do that. I've already gotten a bug report :( > > After bootstrapping, I observe that the summary buffer does not update > the faces correctly for nntp articles that have been read: they still > have an unread face. Thanks for testing! I saw that problem while working on this patch, and thought it was solved. I'll revisit the issue, and come back to you if I have more questions. Thanks again, Eric From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 18:29:54 2019 Received: (at 33653) by debbugs.gnu.org; 24 Mar 2019 22:29:54 +0000 Received: from localhost ([127.0.0.1]:57258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Bco-0005xi-6Z for submit@debbugs.gnu.org; Sun, 24 Mar 2019 18:29:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Bcm-0005xT-VP for 33653@debbugs.gnu.org; Sun, 24 Mar 2019 18:29:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8Bch-0000Ir-6m; Sun, 24 Mar 2019 18:29:47 -0400 Received: from lns-bzn-32-82-254-31-120.adsl.proxad.net ([82.254.31.120]:54996 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1h8Bcg-0000z2-9p; Sun, 24 Mar 2019 18:29:47 -0400 Received: by guerry (Postfix, from userid 1000) id 927B91A606AC; Sun, 24 Mar 2019 23:29:44 +0100 (CET) From: Bastien To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Organization: GNU References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> Date: Sun, 24 Mar 2019 23:29:44 +0100 In-Reply-To: <87pnqik7ld.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 22 Mar 2019 12:54:54 -0700") Message-ID: <87y3536h47.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eric, Eric Abrahamsen writes: > The bummer is that you don't get an error until you run Gnus, so it just > looks like I broke Gnus :( I hope not! :) I have not followed this change. Can it corrupt the .newsrc.eld file? -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 19:40:47 2019 Received: (at 33653) by debbugs.gnu.org; 24 Mar 2019 23:40:48 +0000 Received: from localhost ([127.0.0.1]:57267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8CjP-0007dU-LO for submit@debbugs.gnu.org; Sun, 24 Mar 2019 19:40:47 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:39264 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8CjL-0007dG-Ar for 33653@debbugs.gnu.org; Sun, 24 Mar 2019 19:40:44 -0400 Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 7F430FA02A; Sun, 24 Mar 2019 23:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553470837; bh=7av8YkxKCPTXEVaYYV5mucafV66ETZE9I6NAPDzSzTI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Wzo6zlBrFBLeBA0H7Xvfew4ieIT0ke1o//vd9YGyPfc7vH/hbhzuw4b4bagXnuiCO cs7xQCjP7H/x0r55worM/ZF7PNWXHHw5GmB0cpQziQpRYroN5geQw9LcuqjCSa+nXr 6AVljaV+KFRg7ssBTR50S1xVTST+2ZsrUGG7Yb0U= From: Eric Abrahamsen To: Bastien Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <87y3536h47.fsf@bzg.fr> Date: Sun, 24 Mar 2019 16:40:36 -0700 In-Reply-To: <87y3536h47.fsf@bzg.fr> (Bastien's message of "Sun, 24 Mar 2019 23:29:44 +0100") Message-ID: <871s2vlu2z.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 03/24/19 23:29 PM, Bastien wrote: > Hi Eric, > > Eric Abrahamsen writes: > >> The bummer is that you don't get an error until you run Gnus, so it just >> looks like I broke Gnus :( > > I hope not! :) > > I have not followed this change. > Can it corrupt the .newsrc.eld file? Worst come to worst it will write non-ascii group names as unibyte when they should be utf-8, or else the other way around. I thought I could avoid dealing with this question for now, and just preserve Gnus' original method of saving group names, but it looks like I may have forced the issue instead... From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 22:15:33 2019 Received: (at 33653) by debbugs.gnu.org; 25 Mar 2019 02:15:33 +0000 Received: from localhost ([127.0.0.1]:57338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8F9B-0002or-HV for submit@debbugs.gnu.org; Sun, 24 Mar 2019 22:15:33 -0400 Received: from ostrich.birch.relay.mailchannels.net ([23.83.209.138]:48529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8F97-0002oe-Fj for 33653@debbugs.gnu.org; Sun, 24 Mar 2019 22:15:32 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 499025E1CB0; Mon, 25 Mar 2019 02:15:26 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-7-50.trex.outbound.svc.cluster.local [100.96.7.50]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 57FE95E1DC1; Mon, 25 Mar 2019 02:15:16 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 25 Mar 2019 02:15:26 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Reign-Society: 216aed894af8b518_1553480125047_3410461647 X-MC-Loop-Signature: 1553480125047:4175322673 X-MC-Ingress-Time: 1553480125047 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1h8F8d-00DBdG-4v; Sun, 24 Mar 2019 21:15:00 -0500 Date: Mon, 25 Mar 2019 11:14:57 +0900 Message-ID: From: Katsumi Yamaoka To: 33653@debbugs.gnu.org Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:jqCptf1YnBme943nFrVIWevkJsQ= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Gnus got not to work for groups of which the group name contains non-ASCII letters. For instance, I got this error when trying to update the "nnml:=E3=83=86=E3=82=B9=E3=83=88" group using `M-g'[1]: nnml:\343\203\206\343\202\271\343\203\210 error: No such group: =E3=83=86= =E3=82=B9=E3=83=88 When trying to enter the group using `0 RET'[2] I got: Group nnml:\343\203\206\343\202\271\343\203\210 couldn't be activated Those raw bytes are utf-8 encoded "=E3=83=86=E3=82=B9=E3=83=88", that is al= so used in the group entry in gnus-newsrc-alist saved in the ~/.newsrc.eld file as follows: ("nnml:\343\203\206\343\202\271\343\203\210" 1 nil ((unexist) (seen (1 . 5)= )) "nnml:" ((timestamp 23704 11958))) Such groups I have are only a few, mainly for testing, so not so damaged though, I'm afraid there may be those who using them as normal. Info says that nntp, nnml, and nnrss back ends support non-ASCII group names[3]. Regards, [1] gnus-group-get-new-news-this-group [2] gnus-group-select-group with the prefix arg 0 [3] (info "(gnus) Non-ASCII Group Names") ;; I did `make bootstrap' to recompile all the Gnus modules. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 22:35:30 2019 Received: (at 33653) by debbugs.gnu.org; 25 Mar 2019 02:35:30 +0000 Received: from localhost ([127.0.0.1]:57343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8FSU-0003L1-9Q for submit@debbugs.gnu.org; Sun, 24 Mar 2019 22:35:30 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:39512 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8FSS-0003Ko-Ep for 33653@debbugs.gnu.org; Sun, 24 Mar 2019 22:35:29 -0400 Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4B9D6FA02A; Mon, 25 Mar 2019 02:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553481322; bh=L+C7mMOk5E3HTJ2aCh/gN9Zn2uexkpnl5s51ECIm+b4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=C095ZwZvalTSJGL1UQXip8VUBwpcyXzVQLQ15j6AeNPiJ3JTv8oSKT6xHvhnmN9Ry bKz4Zj+uHgMlaTwnZFl3ZiaXhdILw6pqiPGCfoshSX8bv98peYwds3Lz3FtHHqe8Da TouArLLAC558fUYN0DQy7xCmm1p6EOTC2nNN5S3o= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> Date: Sun, 24 Mar 2019 19:35:21 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 25 Mar 2019 11:14:57 +0900") Message-ID: <87woknisuu.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > Hi, > > Gnus got not to work for groups of which the group name contains > non-ASCII letters. For instance, I got this error when trying > to update the "nnml:=E3=83=86=E3=82=B9=E3=83=88" group using `M-g'[1]: > > nnml:\343\203\206\343\202\271\343\203\210 error: No such group: =E3=83=86= =E3=82=B9=E3=83=88 > > When trying to enter the group using `0 RET'[2] I got: > > Group nnml:\343\203\206\343\202\271\343\203\210 couldn't be activated > > Those raw bytes are utf-8 encoded "=E3=83=86=E3=82=B9=E3=83=88", that is = also used in > the group entry in gnus-newsrc-alist saved in the ~/.newsrc.eld > file as follows: > > ("nnml:\343\203\206\343\202\271\343\203\210" 1 nil ((unexist) (seen (1 > . 5))) "nnml:" ((timestamp 23704 11958))) Yes, this is something I screwed up in c1b63af445. Gnus has always stored group names as raw bytes in.newsrc.eld (at least I believe it has, you probably know better than I do, it does in my experiments with Emacs 26, anyway), and only encodes during display. But obviously I've messed something up between file persistence and display, and I'm working on sorting it out. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 10:45:42 2019 Received: (at submit) by debbugs.gnu.org; 25 Mar 2019 14:45:42 +0000 Received: from localhost ([127.0.0.1]:58519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Qr8-0000jJ-CH for submit@debbugs.gnu.org; Mon, 25 Mar 2019 10:45:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Qr7-0000j1-6g for submit@debbugs.gnu.org; Mon, 25 Mar 2019 10:45:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:36041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8Qr1-00085i-Uy for submit@debbugs.gnu.org; Mon, 25 Mar 2019 10:45:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8Qr0-0001aw-Qk for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 10:45:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RDNS_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8Qqz-000849-Ot for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 10:45:34 -0400 Received: from [195.159.176.226] (port=34658 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8Qqz-00083A-GQ for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 10:45:33 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8Qqw-000uHP-3S for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 15:45:30 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Mon, 25 Mar 2019 14:45:24 +0000 Message-ID: References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:xJIWzZxR+LERAFPi4vHzmEBMPYA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun 24 Mar 2019, Eric Abrahamsen wrote: > Katsumi Yamaoka writes: > >> Hi, >> >> Gnus got not to work for groups of which the group name contains >> non-ASCII letters. For instance, I got this error when trying >> to update the "nnml:テã [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: jpl.org] 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andrewjmoreton[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Sun 24 Mar 2019, Eric Abrahamsen wrote: > Katsumi Yamaoka writes: > >> Hi, >> >> Gnus got not to work for groups of which the group name contains >> non-ASCII letters. For instance, I got this error when trying >> to update the "nnml:テスト" group using `M-g'[1]: >> >> nnml:\343\203\206\343\202\271\343\203\210 error: No such group: テスト >> >> When trying to enter the group using `0 RET'[2] I got: >> >> Group nnml:\343\203\206\343\202\271\343\203\210 couldn't be activated >> >> Those raw bytes are utf-8 encoded "テスト", that is also used in >> the group entry in gnus-newsrc-alist saved in the ~/.newsrc.eld >> file as follows: >> >> ("nnml:\343\203\206\343\202\271\343\203\210" 1 nil ((unexist) (seen (1 >> . 5))) "nnml:" ((timestamp 23704 11958))) > > Yes, this is something I screwed up in c1b63af445. Gnus has always > stored group names as raw bytes in.newsrc.eld (at least I believe it > has, you probably know better than I do, it does in my experiments with > Emacs 26, anyway), and only encodes during display. But obviously I've > messed something up between file persistence and display, and I'm > working on sorting it out. Perhaps it would be better to revert and reintroduce your changes after further testing ? Taking time over this is better than causing data loss for gnus users. Other notes from reading the code: 1) In `gnus-gnus-to-quick-newsrc-format' you ignore the contents of `gnus-newsrc-alist' when saving "newsrc.eld", and replace it with the details from `gnus-newsrc-hashtb'. Why ? The rest of the gnus code appears to treat `gnus-newsrc-alist' as the single source of truth, with the hash tables being used only for faster access to it. 2) In `gnus-gnus-to-quick-newsrc-format' you dropped the code to remove the dummy group from `gnus-newsrc-alist'. Why ? This internal dummy group is now saved in "newsrc.eld", which is not needed. 3) The format of the entries in `gnus-newsrc-hashtb' has changed, removing the second element. Why ? 4) You changed several hash tale sizesfrom 4096 to 4000, and 1024 to 1000. Why ? Your patch contains several logical changes that would be easier to understand (and bisect) as a series of patches with one logical change in each patch: - code layout changes - add missing doc strings and code comments - change hash table implementation - change format of `gnus-newsrc-hashtb' entries - change usage of `gnus-group-change-level' - change coding of group names While it can take extra work to split things up, the end result is much easier to understand. Thanks for working on gnus, AndyM From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 13:35:42 2019 Received: (at 33653) by debbugs.gnu.org; 25 Mar 2019 17:35:42 +0000 Received: from localhost ([127.0.0.1]:58615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8TVd-0005P2-Hx for submit@debbugs.gnu.org; Mon, 25 Mar 2019 13:35:41 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:41120 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8TVb-0005Om-VG for 33653@debbugs.gnu.org; Mon, 25 Mar 2019 13:35:40 -0400 Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E1AFAFA02A; Mon, 25 Mar 2019 17:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553535334; bh=Os0YluyLfpkqicXeCfEQEOLSrDoyXLfZRvibiBW3St8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rUXZIwIFMF06+HaxbxptQR5mgcJbDrf6mU0IVnvbXepFfjBDvfFYXCgek1R4pV3EN WvtwAb0Km6j3yPunz2MaUUTKw6jNBeugAqlJdTldQgY4Sr9e5YuCU8N6KGE/b3nJhf xw2GhskBgSD9rQ1rDcu9nr1/vX2cj292eyIspS5A= From: Eric Abrahamsen To: Andy Moreton Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> Date: Mon, 25 Mar 2019 10:35:32 -0700 In-Reply-To: (Andy Moreton's message of "Mon, 25 Mar 2019 14:45:24 +0000") Message-ID: <8736naj1qz.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andy Moreton writes: > On Sun 24 Mar 2019, Eric Abrahamsen wrote: > >> Katsumi Yamaoka writes: >> >>> Hi, >>> >>> Gnus got not to work for groups of which the group name contains >>> non-ASCII letters. For instance, I got this error when trying >>> to update the "nnml:=E3=83=86=E3=82=B9=E3=83=88" group using `M-g'[1]: >>> >>> nnml:\343\203\206\343\202\271\343\203\210 error: No such group: =E3=83= =86=E3=82=B9=E3=83=88 >>> >>> When trying to enter the group using `0 RET'[2] I got: >>> >>> Group nnml:\343\203\206\343\202\271\343\203\210 couldn't be activated >>> >>> Those raw bytes are utf-8 encoded "=E3=83=86=E3=82=B9=E3=83=88", that i= s also used in >>> the group entry in gnus-newsrc-alist saved in the ~/.newsrc.eld >>> file as follows: >>> >>> ("nnml:\343\203\206\343\202\271\343\203\210" 1 nil ((unexist) (seen (1 >>> . 5))) "nnml:" ((timestamp 23704 11958))) >> >> Yes, this is something I screwed up in c1b63af445. Gnus has always >> stored group names as raw bytes in.newsrc.eld (at least I believe it >> has, you probably know better than I do, it does in my experiments with >> Emacs 26, anyway), and only encodes during display. But obviously I've >> messed something up between file persistence and display, and I'm >> working on sorting it out. > > Perhaps it would be better to revert and reintroduce your changes after > further testing ? Taking time over this is better than causing data loss > for gnus users. That's the conclusion I'm coming to, yes. > Other notes from reading the code: > > 1) In `gnus-gnus-to-quick-newsrc-format' you ignore the contents of > `gnus-newsrc-alist' when saving "newsrc.eld", and replace it with the > details from `gnus-newsrc-hashtb'. Why ? The rest of the gnus code > appears to treat `gnus-newsrc-alist' as the single source of truth, > with the hash tables being used only for faster access to it. Eventually I would like to reduce the number of data structures so that groups are held in `gnus-newsrc-hashtb', and ordering is kept in `gnus-group-list', and that's it. `gnus-newsrc-alist' would only be used when persisting to disk. My next proposed change (once I've recovered my confidence) is to turn groups into actual objects, in which case the alist would really just be a kind of serialization format. The hash table ought to be in sync with the rest of the data structure -- if it isn't, that's another bug. > 2) In `gnus-gnus-to-quick-newsrc-format' you dropped the code to remove > the dummy group from `gnus-newsrc-alist'. Why ? This internal dummy > group is now saved in "newsrc.eld", which is not needed. This was an error. (Though in my case, I've had the dummy group in my newsrc.eld for months, and it hasn't done any harm. I don't know why it's necessary.) > 3) The format of the entries in `gnus-newsrc-hashtb' has changed, > removing the second element. Why ? Because the old `gnus-gethash' call returned a slice of `gnus-newsrc-alist', where the second element was actually the group *before* the group you wanted, and the third element was the cdr of `gnus-newsrc-alist', starting with the group you wanted. This was undocumented, and took a bit to figure out. Now, the gethash call just gives you the group. Ideally, in the next set of changes, it will give you an object. > 4) You changed several hash tale sizesfrom 4096 to 4000, and 1024 to > 1000. Why ? My understanding is that using a prime number is significant when it comes to vector access, but that the hash table implementation is higher-level, where a prime number is no longer significant. If that's incorrect I would like to know! > Your patch contains several logical changes that would be easier to > understand (and bisect) as a series of patches with one logical change > in each patch: > - code layout changes > - add missing doc strings and code comments > - change hash table implementation > - change format of `gnus-newsrc-hashtb' entries > - change usage of `gnus-group-change-level' > - change coding of group names > While it can take extra work to split things up, the end result is much > easier to understand. In principle I agree with this completely. In practice I found it extraordinarily difficult to touch one part of Gnus without running into knock-on repercussions. The ultimate goal of the changes I have in mind for Gnus is to address exactly this: to make it more modular, to improve isolation of code paths, and to reduce the number of semi-redundant data structures. But the process is evidently even messier than I thought. I held back another commit to group name encoding in an attempt to keep things simple, but that seems to have made things even worse. But yes, if I end up backing this change out, I'll try to break it up into smaller commits. > Thanks for working on gnus, Thanks for the code review! I wish I'd gotten this to begin with. Eric From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 13:51:48 2019 Received: (at 33653) by debbugs.gnu.org; 25 Mar 2019 17:51:48 +0000 Received: from localhost ([127.0.0.1]:58640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8TlD-0005on-D1 for submit@debbugs.gnu.org; Mon, 25 Mar 2019 13:51:47 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:33024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8TlA-0005oZ-VW for 33653@debbugs.gnu.org; Mon, 25 Mar 2019 13:51:45 -0400 Received: by mail-wr1-f46.google.com with SMTP id q1so11268763wrp.0 for <33653@debbugs.gnu.org>; Mon, 25 Mar 2019 10:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=Dnkbph1HHLZGuvLOM06Y1GMAmQtLai0ea/fCRyrkrmc=; b=GSf8fL66/132oZuO5wacyCdx8HOB6UFqnpDWzaXDkCUcwnkeIwRK9vNXQZoT3zAS3O yA0wc4FFEdDn3fdfbgz1IWr6ZkG8pVdZs2NPTAmR9NpZNDhhiYVknF9O0NIo8We6IZwM m601oV0Gn80NcT3rG/F90HZqWZ5eOF1Hqtp0XIVY6VZT6djY4vqxWUbhxFf3pCQzo8MP DnwJjgnYq7F1Iwk2G593mcevR7EOssDtBIdEMw/E/RXmuRxpJLltbrOw41usf+kgvmp8 TsnpG42rxRREKcyqm8dgB1lUo0DtYGH3ATvyRG/5O5Ssx5JBkW0krga6YRx7msU0OBiC /miQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=Dnkbph1HHLZGuvLOM06Y1GMAmQtLai0ea/fCRyrkrmc=; b=kvSnWykQvZrPaeyeWQiJXNHeqNmcov3JWxnjHa2YfH9sU5fVQjowwXfYUOzYVAlDdQ ixr1Z60mLJkqRJVkKGqlNaoaf5+1iuMkM7rJyQoTfUmMegA8VCREU1567s78rw0BjdtP 8ffCipmNgu+ynhgzS46csYfD+ZUyollNyANIDp5O9DAHeef1H/GbbSpI1QpvJ5r6ZRIS sxbS3fqreoGwTM0hT3CQ5Vo4xDKyfDG1v/D9PNnHHpTeD2JW6ntRIadRv+IBbV0UZ7yL QAKQHDGHZLHt9sGQForoVBAI93I1IqpUkcFKQmfwFPfMDikSzmmtYeRUu48XVu6rc68B 0yyQ== X-Gm-Message-State: APjAAAUmWJ8LMkqPcqOt6FLD6n39tVBQjOimB2FVd+5/FpGWjLqZFyOb lfm857R+qTzpaW/jkc5BKHuYakqK X-Google-Smtp-Source: APXvYqwOwDWIeRxhp8990ETnWEN3IiYENeP6dVvcdspall0y6Ezk59X6P1Wd2OQMJQYWJ8pzvdGGpA== X-Received: by 2002:adf:ee91:: with SMTP id b17mr16804048wro.234.1553536298788; Mon, 25 Mar 2019 10:51:38 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:7c6e:2cbe:cbda:343a]) by smtp.gmail.com with ESMTPSA id e1sm25064524wrw.66.2019.03.25.10.51.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 25 Mar 2019 10:51:37 -0700 (PDT) From: Robert Pluim To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> <8736naj1qz.fsf@ericabrahamsen.net> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 25 Mar 2019 18:51:36 +0100 In-Reply-To: <8736naj1qz.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 25 Mar 2019 10:35:32 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 25 Mar 2019 10:35:32 -0700, Eric Abrahamsen said: >> Perhaps it would be better to revert and reintroduce your >> changes after further testing ? Taking time over this is better >> than causing data loss for gnus users. Eric> That's the conclusion I'm coming to, yes. FWIW, gnus on master has been working flawlessly for me since you pushed the hash table changes. People running master should expect occasional breakage, so I wouldn=CA=BCt give up too soon. Robert From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 14:17:12 2019 Received: (at 33653) by debbugs.gnu.org; 25 Mar 2019 18:17:12 +0000 Received: from localhost ([127.0.0.1]:58654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8U9n-0006T8-R2 for submit@debbugs.gnu.org; Mon, 25 Mar 2019 14:17:12 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:34953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8U9l-0006Sv-HG for 33653@debbugs.gnu.org; Mon, 25 Mar 2019 14:17:09 -0400 Received: by mail-ed1-f42.google.com with SMTP id s39so2911225edb.2 for <33653@debbugs.gnu.org>; Mon, 25 Mar 2019 11:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uIc25zn5POc1w8Rqn4Ef0Z3sr33azkFo3/YB154cWzE=; b=z9K37QtzaiFnk92IbRZOHB6R4PxGOjHjqebriJLJd3IRbyfYPJ25nW2/V1Xytz13Vk YHzddpLge/WivUBWfBzBeIkU3oj2UxRliAsuIVRq9yghLCqRuiACN96nTQClvpQ2xzYJ fRT8QnuKXzrII5zOhrabxruxoE0AQMGqqxnUVCjGGtZygPJk6E+RchTSVLAbNX5QGkSI e44/Um3fnuoDTJ7E1seFWQJTxyk3hbtb3L5ZwSMb0gxMc1eoHOAqguHEnb3BnC3G71hI 7eiYod+hwav7VwszYVCU0e5vmrm22evmmHNMapXe8/ABSi5vDMAt0trPWw0ZrfcVIHgT cfIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uIc25zn5POc1w8Rqn4Ef0Z3sr33azkFo3/YB154cWzE=; b=WltHtqI23aV5oPovqpj0U/vizGenJvxNwOfst3Gjw8NehDeH6/e29B30exTaqS0HEN 3XAjLVP/CIarG/CwgG6HOTdfY/kYuaGfJRpPIp4hd2v1a1WF8I9bKHj1ftsGIsIjsdTc W7ma/Te2yeJ077VyssJW46egyyCEEfAyMckvqD6MJZV9XMOtbgoZouzWj5wlB1N3SMn0 ONNOyrQ/3iOuEZmhJtueF6SzQ3tE+uUt5xBYkCghuLfZ4bbtHGuyQF8JfrqW0Y560Pf+ /q1whI0ku9wRHEEtNro1gOtc3jydShx9uphxlXTCz7XdESge7Sz0uOr1kL4q6rlUqkBa 5h0A== X-Gm-Message-State: APjAAAWMzkJ6jcAOj4p28/Sd07RmCUbjGL1xBJbQrRYmNbvP0v4E+8Xr 0WFn6U0bBfWON7e807BZ3Z4IjQ== X-Google-Smtp-Source: APXvYqyoZr7Fh+2ZQAd+3fiBdN+yz7GP63qsOGA3z/8XHmmPluCuu544STaFMr199Txxcu3TLNdGoQ== X-Received: by 2002:a50:b79d:: with SMTP id h29mr14718832ede.233.1553537823926; Mon, 25 Mar 2019 11:17:03 -0700 (PDT) Received: from localhost ([134.226.214.210]) by smtp.gmail.com with ESMTPSA id 5sm5592172edp.50.2019.03.25.11.17.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 25 Mar 2019 11:17:03 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> <8736naj1qz.fsf@ericabrahamsen.net> Date: Mon, 25 Mar 2019 18:17:01 +0000 In-Reply-To: (Robert Pluim's message of "Mon, 25 Mar 2019 18:51:36 +0100") Message-ID: <87y352q0o2.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: >>>>>> On Mon, 25 Mar 2019 10:35:32 -0700, Eric Abrahamsen said: > >> Perhaps it would be better to revert and reintroduce your > >> changes after further testing ? Taking time over this is better > >> than causing data loss for gnus users. > > Eric> That's the conclusion I'm coming to, yes. > > FWIW, gnus on master has been working flawlessly for me since you > pushed the hash table changes. People running master should expect > occasional breakage, so I wouldn=CA=BCt give up too soon. Seconded. --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 15:04:52 2019 Received: (at 33653) by debbugs.gnu.org; 25 Mar 2019 19:04:52 +0000 Received: from localhost ([127.0.0.1]:58679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Utw-0007fE-ED for submit@debbugs.gnu.org; Mon, 25 Mar 2019 15:04:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Utu-0007f0-Hn for 33653@debbugs.gnu.org; Mon, 25 Mar 2019 15:04:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8Utl-0006hc-30; Mon, 25 Mar 2019 15:04:42 -0400 Received: from lns-bzn-32-82-254-31-120.adsl.proxad.net ([82.254.31.120]:47748 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1h8Uth-00011r-4G; Mon, 25 Mar 2019 15:04:38 -0400 Received: by guerry (Postfix, from userid 1000) id 2D4D91A62150; Mon, 25 Mar 2019 20:04:35 +0100 (CET) From: Bastien To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Organization: GNU References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> <8736naj1qz.fsf@ericabrahamsen.net> Date: Mon, 25 Mar 2019 20:04:35 +0100 In-Reply-To: (Robert Pluim's message of "Mon, 25 Mar 2019 18:51:36 +0100") Message-ID: <871s2uydvg.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > FWIW, gnus on master has been working flawlessly for me since you > pushed the hash table changes. People running master should expect > occasional breakage, so I wouldn=CA=BCt give up too soon. For something as critical as Gnus and for which many various configs exist, I would recommend that a patch can be confirmed by *at least* three persons on top of the contributor himself. This is perhaps the case for this patch, I don't know. If things are okay on your side, perhaps you don't feel the pain, but I can tell you it's here :) Also, the fact that Gnus has been crazily stable on the master branch from... well, from as far as I can remember, makes the situation even worse: you really don't expect anything to break in this area. Not a big deal, I'll wait, and thanks again Eric for both the patches and your patience in finding possible issues! --=20 Bastien From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 16:31:13 2019 Received: (at submit) by debbugs.gnu.org; 25 Mar 2019 20:31:13 +0000 Received: from localhost ([127.0.0.1]:58713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8WFU-0001Gn-Or for submit@debbugs.gnu.org; Mon, 25 Mar 2019 16:31:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8WFT-0001Gb-0P for submit@debbugs.gnu.org; Mon, 25 Mar 2019 16:31:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:56312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8WFL-0008OO-CB for submit@debbugs.gnu.org; Mon, 25 Mar 2019 16:31:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8WFJ-0006CN-Ph for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 16:31:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8W0b-0005g4-J1 for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 16:15:50 -0400 Received: from [195.159.176.226] (port=42944 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8W0Z-0005LQ-Iq for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 16:15:48 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8W0T-000Oyr-98 for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2019 21:15:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Mon, 25 Mar 2019 20:15:33 +0000 Message-ID: References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> <8736naj1qz.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cancel-Lock: sha1:r2W1zXzF38ER2nnDKKXnmiIhJbw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon 25 Mar 2019, Eric Abrahamsen wrote: > Andy Moreton writes: >> Other notes from reading the code: >> >> 1) In `gnus-gnus-to-quick-newsrc-format' you ignore the contents of >> `gnus-newsrc-alist' when saving "newsrc.eld", and replace it [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andrewjmoreton[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Mon 25 Mar 2019, Eric Abrahamsen wrote: > Andy Moreton writes: >> Other notes from reading the code: >> >> 1) In `gnus-gnus-to-quick-newsrc-format' you ignore the contents of >> `gnus-newsrc-alist' when saving "newsrc.eld", and replace it with the >> details from `gnus-newsrc-hashtb'. Why ? The rest of the gnus code >> appears to treat `gnus-newsrc-alist' as the single source of truth, >> with the hash tables being used only for faster access to it. > > Eventually I would like to reduce the number of data structures so that > groups are held in `gnus-newsrc-hashtb', and ordering is kept in > `gnus-group-list', and that's it. `gnus-newsrc-alist' would only be used > when persisting to disk. My next proposed change (once I've recovered my > confidence) is to turn groups into actual objects, in which case the > alist would really just be a kind of serialization format. ok, but if the hash table and the alist reference the same lisp objects then the existing setup is not so bad. > The hash table ought to be in sync with the rest of the data structure > -- if it isn't, that's another bug. > >> 2) In `gnus-gnus-to-quick-newsrc-format' you dropped the code to remove >> the dummy group from `gnus-newsrc-alist'. Why ? This internal dummy >> group is now saved in "newsrc.eld", which is not needed. > > This was an error. (Though in my case, I've had the dummy group in my > newsrc.eld for months, and it hasn't done any harm. I don't know why > it's necessary.) I agree that it's harmless, it just seemed to be an unnecessary change. I expect it is there to ensure that the alist is never empty to avoid the need to check that everywhere. >> 3) The format of the entries in `gnus-newsrc-hashtb' has changed, >> removing the second element. Why ? > > Because the old `gnus-gethash' call returned a slice of > `gnus-newsrc-alist', where the second element was actually the group > *before* the group you wanted, and the third element was the cdr of > `gnus-newsrc-alist', starting with the group you wanted. This was > undocumented, and took a bit to figure out. Now, the gethash call just > gives you the group. Ideally, in the next set of changes, it will give > you an object. ok, so it sounds like the old code was trying hard to use the same lisp objects in both the hash table and the alist. That avoids alloacting twice the storage, and ensures that the hash table and the alist stay in sync. >> 4) You changed several hash tale sizesfrom 4096 to 4000, and 1024 to >> 1000. Why ? > > My understanding is that using a prime number is significant when it > comes to vector access, but that the hash table implementation is > higher-level, where a prime number is no longer significant. If that's > incorrect I would like to know! None of these numbers are prime. The old numbers are powers of two, which are reasonable for allocation sizes on a binary machine. Again, not a terribly important change, but not really needed either. >> Your patch contains several logical changes that would be easier to >> understand (and bisect) as a series of patches with one logical change >> in each patch: >> - code layout changes >> - add missing doc strings and code comments >> - change hash table implementation >> - change format of `gnus-newsrc-hashtb' entries >> - change usage of `gnus-group-change-level' >> - change coding of group names >> While it can take extra work to split things up, the end result is much >> easier to understand. > > In principle I agree with this completely. In practice I found it > extraordinarily difficult to touch one part of Gnus without running into > knock-on repercussions. Agreed. I find that this sort of work usually goes in two phases: some exploratory programming to decide on the path forward and the eventual goal, followed by rearranging the changes into a logical set of (bisectable) patches that get to that goal in small, self-contained steps. The second half is extra work, but worth it to make it easier for other people to review the patches (and to simplify any archaeology needed by a later maintainer). If changing gnus is hard, then perhaps writing new tests to document what you have discovered about the code will help to ensure that later changes do not change the observed behaviour. > The ultimate goal of the changes I have in mind for Gnus is to address > exactly this: to make it more modular, to improve isolation of code > paths, and to reduce the number of semi-redundant data structures. But > the process is evidently even messier than I thought. I held back > another commit to group name encoding in an attempt to keep things > simple, but that seems to have made things even worse. A worthwhile goal - please do not get discouraged. AndyM From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 14:41:14 2019 Received: (at submit) by debbugs.gnu.org; 26 Mar 2019 18:41:14 +0000 Received: from localhost ([127.0.0.1]:60551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8r0c-0004bC-8U for submit@debbugs.gnu.org; Tue, 26 Mar 2019 14:41:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8r0a-0004am-2r for submit@debbugs.gnu.org; Tue, 26 Mar 2019 14:41:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:59148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8r0T-0002oP-JB for submit@debbugs.gnu.org; Tue, 26 Mar 2019 14:41:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8r0S-00074O-6M for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:41:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RDNS_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8qoG-0004Ze-NP for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:28:29 -0400 Received: from [195.159.176.226] (port=59116 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8qoD-0004Y8-Pv for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:28:28 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8qoB-000wOr-Te for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 19:28:23 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Tue, 26 Mar 2019 18:28:15 +0000 Message-ID: References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <834l7ur52w.fsf@gnu.org> <877ecqk1b5.fsf@ericabrahamsen.net> <86imw9abj3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1://khO0z6TiaT6yiNeyto744ogaM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat 23 Mar 2019, Andy Moreton wrote: > On Fri 22 Mar 2019, Eric Abrahamsen wrote: > >> Eli Zaretskii writes: >> >>>> From: Eric Abrahamsen >>>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>>> >>>> is there anything to be done besides warn [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andrewjmoreton[at]gmail.com) 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Sat 23 Mar 2019, Andy Moreton wrote: > On Fri 22 Mar 2019, Eric Abrahamsen wrote: > >> Eli Zaretskii writes: >> >>>> From: Eric Abrahamsen >>>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>>> >>>> is there anything to be done besides warning people on the mailing >>>> lists? >>> >>> A warning would be nice, yes. >> >> Okay, I'll do that. I've already gotten a bug report :( > > After bootstrapping, I observe that the summary buffer does not update > the faces correctly for nntp articles that have been read: they still > have an unread face. After more debugging, I have found the problem. Updating summary lines is handled in `gnus-summary-insert-line': (condition-case () (put-text-property (point) (progn (eval gnus-summary-line-format-spec) (point)) 'gnus-number gnus-tmp-number) (error (gnus-message 5 "Error updating the summary line"))) In my setup, `gnus-summary-line-format' used starts with "%U%R%u&score;" to use a user format function for printing score info. That results in calls to my user function to display summary lines: (defun gnus-user-format-function-score (header) (let* ((article (mail-header-number header)) (thread (gnus-id-to-thread (mail-header-id header))) ... This now fails because `gnus-id-to-thread' sometimes throws an error, because `gnus-newsgroup-dependencies' is nil when it is called. This usage worked in emacs-26 and in master before your changes. I've fixed this in my user format function with: (defun gnus-user-format-function-score (header) (let* ((article (mail-header-number header)) (thread (and gnus-newsgroup-dependencies (gnus-id-to-thread (mail-header-id header)))) ... After that change, the marks are displayed correctly in the summary buffer. I'm not sure if that is something that only worked by chance in old code, or if it is a regression, but it is a change of behaviour. AndyM From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 15:49:18 2019 Received: (at 33653) by debbugs.gnu.org; 26 Mar 2019 19:49:18 +0000 Received: from localhost ([127.0.0.1]:60594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8s4T-0006Fq-Q8 for submit@debbugs.gnu.org; Tue, 26 Mar 2019 15:49:18 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:44270 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8s4R-0006Fd-Ob for 33653@debbugs.gnu.org; Tue, 26 Mar 2019 15:49:17 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 9DD35FA02B; Tue, 26 Mar 2019 19:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553629749; bh=pCxGHJTiCjqnwWkaKDDlOUH6FGmWM81eDxaB0i19SeA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=svndM9HeeRTfb5E2hs6HMcMTJbvPD9ZRTuOHXz3TjJHZZAkN27lzgilP/4LPbj+cI hoJ2h8rOZYGSuv8XQPRp1PsTuTzr8C6twU9Ya7MLdHMtnXe595QZxd+dQbuZToRFV1 PuOcEnto2pAebTbuWRPo0ux9gbRRKa2lmAgyyRj0= From: Eric Abrahamsen To: Andy Moreton Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <834l7ur52w.fsf@gnu.org> <877ecqk1b5.fsf@ericabrahamsen.net> <86imw9abj3.fsf@gmail.com> Date: Tue, 26 Mar 2019 12:49:08 -0700 In-Reply-To: (Andy Moreton's message of "Tue, 26 Mar 2019 18:28:15 +0000") Message-ID: <87o95xto0b.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andy Moreton writes: > On Sat 23 Mar 2019, Andy Moreton wrote: > >> On Fri 22 Mar 2019, Eric Abrahamsen wrote: >> >>> Eli Zaretskii writes: >>> >>>>> From: Eric Abrahamsen >>>>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>>>> >>>>> is there anything to be done besides warning people on the mailing >>>>> lists? >>>> >>>> A warning would be nice, yes. >>> >>> Okay, I'll do that. I've already gotten a bug report :( >> >> After bootstrapping, I observe that the summary buffer does not update >> the faces correctly for nntp articles that have been read: they still >> have an unread face. > > After more debugging, I have found the problem. > > Updating summary lines is handled in `gnus-summary-insert-line': > (condition-case () > (put-text-property > (point) > (progn (eval gnus-summary-line-format-spec) (point)) > 'gnus-number gnus-tmp-number) > (error (gnus-message 5 "Error updating the summary line"))) > > In my setup, `gnus-summary-line-format' used starts with "%U%R%u&score;" > to use a user format function for printing score info. That results in > calls to my user function to display summary lines: > > (defun gnus-user-format-function-score (header) > (let* ((article (mail-header-number header)) > (thread (gnus-id-to-thread (mail-header-id header))) > ... > > This now fails because `gnus-id-to-thread' sometimes throws an error, > because `gnus-newsgroup-dependencies' is nil when it is called. This > usage worked in emacs-26 and in master before your changes. > > I've fixed this in my user format function with: > > (defun gnus-user-format-function-score (header) > (let* ((article (mail-header-number header)) > (thread (and gnus-newsgroup-dependencies > (gnus-id-to-thread (mail-header-id header)))) > ... > > After that change, the marks are displayed correctly in the summary > buffer. I'm not sure if that is something that only worked by chance in > old code, or if it is a regression, but it is a change of behaviour. Yes, the format spec is eval'ed twice (to set summary buffer positions) before the threads are actually built, and `gnus-newsgroup-dependencies' is nil at that point. Back when this was a call to `intern', it would just silently return nil, now it errors. Your fix works, but I could also have `gnus-id-to-thread' return nil if `gnus-newsgroup-dependencies' is nil. That would mimic Gnus' previous behavior. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 16:01:48 2019 Received: (at submit) by debbugs.gnu.org; 26 Mar 2019 20:01:48 +0000 Received: from localhost ([127.0.0.1]:60606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8sGZ-0006ZR-Oe for submit@debbugs.gnu.org; Tue, 26 Mar 2019 16:01:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8sGY-0006ZD-58 for submit@debbugs.gnu.org; Tue, 26 Mar 2019 16:01:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:49636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8sGS-0003SZ-Vf for submit@debbugs.gnu.org; Tue, 26 Mar 2019 16:01:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8sGR-0005jZ-HC for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 16:01:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8sDb-0002VF-93 for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 15:58:44 -0400 Received: from [195.159.176.226] (port=52564 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8sDb-0002Uv-0X for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 15:58:43 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8sDZ-000KeL-ED for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 20:58:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Tue, 26 Mar 2019 12:58:32 -0700 Message-ID: <87ftr9tnkn.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87woknisuu.fsf@ericabrahamsen.net> <8736naj1qz.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:VJ447eenNV4Uf89u/2AeNKR3RQM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andy Moreton writes: > On Mon 25 Mar 2019, Eric Abrahamsen wrote: > >> Andy Moreton writes: >>> Other notes from reading the code: >>> >>> 1) In `gnus-gnus-to-quick-newsrc-format' you ignore the contents of >>> `gnus-newsrc-alist' when saving "newsrc.eld", and replace it with the >>> details from `gnus-newsrc-hashtb'. Why ? The rest of the gnus code >>> appears to treat `gnus-newsrc-alist' as the single source of truth, >>> with the hash tables being used only for faster access to it. >> >> Eventually I would like to reduce the number of data structures so that >> groups are held in `gnus-newsrc-hashtb', and ordering is kept in >> `gnus-group-list', and that's it. `gnus-newsrc-alist' would only be used >> when persisting to disk. My next proposed change (once I've recovered my >> confidence) is to turn groups into actual objects, in which case the >> alist would really just be a kind of serialization format. > > ok, but if the hash table and the alist reference the same lisp objects > then the existing setup is not so bad. There's nothing wrong with the existing setup here! I'm just laying the groundwork for the next round of changes. >> The hash table ought to be in sync with the rest of the data structure >> -- if it isn't, that's another bug. >> >>> 2) In `gnus-gnus-to-quick-newsrc-format' you dropped the code to remove >>> the dummy group from `gnus-newsrc-alist'. Why ? This internal dummy >>> group is now saved in "newsrc.eld", which is not needed. >> >> This was an error. (Though in my case, I've had the dummy group in my >> newsrc.eld for months, and it hasn't done any harm. I don't know why >> it's necessary.) > > I agree that it's harmless, it just seemed to be an unnecessary change. > I expect it is there to ensure that the alist is never empty to avoid > the need to check that everywhere. Yes, for sure, and I didn't mean to leave it in there, that's just a bug. >>> 3) The format of the entries in `gnus-newsrc-hashtb' has changed, >>> removing the second element. Why? >> >> Because the old `gnus-gethash' call returned a slice of >> `gnus-newsrc-alist', where the second element was actually the group >> *before* the group you wanted, and the third element was the cdr of >> `gnus-newsrc-alist', starting with the group you wanted. This was >> undocumented, and took a bit to figure out. Now, the gethash call just >> gives you the group. Ideally, in the next set of changes, it will give >> you an object. > > ok, so it sounds like the old code was trying hard to use the same lisp > objects in both the hash table and the alist. That avoids alloacting > twice the storage, and ensures that the hash table and the alist stay in > sync. Yes, I'm looking forward to when the groups are actual objects, . But in the meantime, the lisp objects are still the same, I haven't doubled storage (at least `eq' returns t, so I assume that's what that means). >>> 4) You changed several hash tale sizesfrom 4096 to 4000, and 1024 to >>> 1000. Why? >> >> My understanding is that using a prime number is significant when it >> comes to vector access, but that the hash table implementation is >> higher-level, where a prime number is no longer significant. If that's >> incorrect I would like to know! > > None of these numbers are prime. The old numbers are powers of two, > which are reasonable for allocation sizes on a binary machine. Again, > not a terribly important change, but not really needed either. Yes, sorry, powers of two. It's true it's a do-nothing change, I guess I've been erring on the side of trying to make the code more self-explanatory, less "odd". Probably this change didn't need to be made, but it seems about as un-risky as a code change could be. >>> Your patch contains several logical changes that would be easier to >>> understand (and bisect) as a series of patches with one logical change >>> in each patch: >>> - code layout changes >>> - add missing doc strings and code comments >>> - change hash table implementation >>> - change format of `gnus-newsrc-hashtb' entries >>> - change usage of `gnus-group-change-level' >>> - change coding of group names >>> While it can take extra work to split things up, the end result is much >>> easier to understand. >> >> In principle I agree with this completely. In practice I found it >> extraordinarily difficult to touch one part of Gnus without running into >> knock-on repercussions. > > Agreed. I find that this sort of work usually goes in two phases: some > exploratory programming to decide on the path forward and the eventual > goal, followed by rearranging the changes into a logical set of > (bisectable) patches that get to that goal in small, self-contained > steps. The second half is extra work, but worth it to make it easier for > other people to review the patches (and to simplify any archaeology > needed by a later maintainer). > > If changing gnus is hard, then perhaps writing new tests to document > what you have discovered about the code will help to ensure that later > changes do not change the observed behaviour. The previous commit did add some new Gnus tests -- perhaps the first! I'm planning more, once Gnus group are actual objects. Everything's so interconnected now (and data-reliant) that it's very hard to write effective tests. >> The ultimate goal of the changes I have in mind for Gnus is to address >> exactly this: to make it more modular, to improve isolation of code >> paths, and to reduce the number of semi-redundant data structures. But >> the process is evidently even messier than I thought. I held back >> another commit to group name encoding in an attempt to keep things >> simple, but that seems to have made things even worse. > > A worthwhile goal - please do not get discouraged. Thank you, Eric From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 17:44:43 2019 Received: (at 33653) by debbugs.gnu.org; 26 Mar 2019 21:44:43 +0000 Received: from localhost ([127.0.0.1]:60640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8tsB-0000kk-0u for submit@debbugs.gnu.org; Tue, 26 Mar 2019 17:44:43 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:44490 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8ts8-0000kU-8K for 33653@debbugs.gnu.org; Tue, 26 Mar 2019 17:44:41 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 08429FA02B; Tue, 26 Mar 2019 21:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553636674; bh=S70Kv/OYCWmrWUffQ78v47Xmqk1Z4QMvZHdsZdMbtLg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=wHK1jOzGm4mtTfSZB1pYGkcxnVMqH6sp8vSxqRMeftVV+3vHn4lTQqLWyQdpsRYf0 RW2wb4nd31IV+Y38u/kDdisEs2Ay1CnTUB3xwNJA+PC258iZ9GqJJ5VK/FzPlIo2k9 zchKIk7zkKMESd8se03NGfjyUqcbi7+rhrhjX5DM= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> Date: Tue, 26 Mar 2019 14:44:32 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 25 Mar 2019 11:14:57 +0900") Message-ID: <87a7hhtinz.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Katsumi Yamaoka writes: > Hi, > > Gnus got not to work for groups of which the group name contains > non-ASCII letters. For instance, I got this error when trying > to update the "nnml:=E3=83=86=E3=82=B9=E3=83=88" group using `M-g'[1]: Thanks for this report. When you have a moment will you please try the attached patch and see if it fixes the problem? Yours, Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=fix-nnml-assoc.diff diff --git a/lisp/gnus/nnml.el b/lisp/gnus/nnml.el index 5770777ad4..205e9e4803 100644 --- a/lisp/gnus/nnml.el +++ b/lisp/gnus/nnml.el @@ -259,7 +259,7 @@ nnml-request-group (t (nnheader-re-read-dir nnml-current-directory) (nnmail-activate 'nnml) - (let ((active (nth 1 (assoc group nnml-group-alist)))) + (let ((active (nth 1 (assoc-string group nnml-group-alist)))) (if (not active) (nnheader-report 'nnml "No such group: %s" decoded) (nnheader-report 'nnml "Selected group %s" decoded) @@ -295,7 +295,7 @@ nnml-request-create-group (nnheader-report 'nnml "%s is a file" (directory-file-name (nnml-group-pathname group nil server)))) - ((assoc group nnml-group-alist) + ((assoc-string group nnml-group-alist) t) (t (let (active) @@ -379,7 +379,7 @@ nnml-request-expire-articles (nnml-nov-delete-article group number)) (push number rest))) (push number rest))) - (let ((active (nth 1 (assoc group nnml-group-alist)))) + (let ((active (nth 1 (assoc-string group nnml-group-alist)))) (when active (setcar active (or (and active-articles (apply 'min active-articles)) @@ -520,7 +520,7 @@ nnml-request-delete-group (nnheader-report 'nnml "No such directory: %s/" file)) ;; Remove the group from all structures. (setq nnml-group-alist - (delq (assoc group nnml-group-alist) nnml-group-alist) + (delq (assoc-string group nnml-group-alist) nnml-group-alist) nnml-current-group nil nnml-current-directory nil) ;; Save the active file. @@ -549,7 +549,7 @@ nnml-request-rename-group (when (<= (length (directory-files old-dir)) 2) (ignore-errors (delete-directory old-dir))) ;; That went ok, so we change the internal structures. - (let ((entry (assoc group nnml-group-alist))) + (let ((entry (assoc-string group nnml-group-alist))) (when entry (setcar entry new-name)) (setq nnml-current-directory nil @@ -597,7 +597,7 @@ nnml-deletable-article-p (when (setq path (nnml-article-to-file article)) (when (file-writable-p path) (or (not nnmail-keep-last-article) - (not (eq (cdr (nth 1 (assoc group nnml-group-alist))) + (not (eq (cdr (nth 1 (assoc-string group nnml-group-alist))) article))))))) ;; Find an article number in the current group given the Message-ID. @@ -742,7 +742,7 @@ nnml-active-number "Compute the next article number in GROUP on SERVER." (let* ((encoded (if nnmail-group-names-not-encoded-p (nnml-encoded-group-name group server))) - (active (cadr (assoc (or encoded group) nnml-group-alist)))) + (active (cadr (assoc-string (or encoded group) nnml-group-alist)))) ;; The group wasn't known to nnml, so we just create an active ;; entry for it. (unless active @@ -783,7 +783,7 @@ nnml-save-incremental-nov (cdr nnml-incremental-nov-buffer-alist))))) (defun nnml-open-incremental-nov (group) - (or (cdr (assoc group nnml-incremental-nov-buffer-alist)) + (or (cdr (assoc-string group nnml-incremental-nov-buffer-alist)) (let ((buffer (nnml-get-nov-buffer group t))) (push (cons group buffer) nnml-incremental-nov-buffer-alist) buffer))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 00:54:52 2019 Received: (at 33653) by debbugs.gnu.org; 27 Mar 2019 04:54:52 +0000 Received: from localhost ([127.0.0.1]:60784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h90aS-0003YE-E1 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 00:54:52 -0400 Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:27538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h90aQ-0003Y5-C4 for 33653@debbugs.gnu.org; Wed, 27 Mar 2019 00:54:51 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B47103E4DC5; Wed, 27 Mar 2019 04:54:48 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.39.118]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 19E433E4F22; Wed, 27 Mar 2019 04:54:47 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 27 Mar 2019 04:54:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Troubled-Occur: 36820cb6762abd33_1553662488474_31324354 X-MC-Loop-Signature: 1553662488473:3923679862 X-MC-Ingress-Time: 1553662488473 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1h90aI-008JsZ-UI; Tue, 26 Mar 2019 23:54:44 -0500 Date: Wed, 27 Mar 2019 13:54:42 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:Kg/4jE7ZBJ5+WQzwyzH6qwXKrhA= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 26 Mar 2019 14:44:32 -0700, Eric Abrahamsen wrote: > Thanks for this report. When you have a moment will you please try the > attached patch and see if it fixes the problem? Works great. Now I can enter and read the nnml:=E3=83=86=E3=82=B9=E3=83=88= group. Thank you. But there seem to be some more fix needed. The group level of nnml:=E3=83=86=E3=82=B9=E3=83=88 is 1 and there are some= unread articles in it, however the group is not listed in the Group buffer when I launch Gnus by `C-u 1 M-x gnus RET' (it also happened when I worked on non-ASCII group names years ago, but I don't recall how I fixed it, sorry). Typing L helps it. I tried changing `assoc' with `assoc-string' in nnrss.el, too. It works for non-ASCII group names so far, though only I glanced a few feeds. A diff is attached. Regards, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment --- nnrss.el~ 2019-02-20 21:21:21.909516900 +0000 +++ nnrss.el 2019-03-27 04:49:26.756386000 +0000 @@ -340,10 +340,10 @@ (let (elem) ;; There may be two or more entries in `nnrss-group-alist' since ;; this function didn't delete them formerly. - (while (setq elem (assoc group nnrss-group-alist)) + (while (setq elem (assoc-string group nnrss-group-alist)) (setq nnrss-group-alist (delq elem nnrss-group-alist)))) (setq nnrss-server-data - (delq (assoc group nnrss-server-data) nnrss-server-data)) + (delq (assoc-string group nnrss-server-data) nnrss-server-data)) (nnrss-save-server-data server) (ignore-errors (let ((file-name-coding-system nnmail-pathname-coding-system)) @@ -367,7 +367,7 @@ (with-current-buffer nntp-server-buffer (erase-buffer) (dolist (group groups) - (let ((elem (assoc (gnus-group-decoded-name group) nnrss-server-data))) + (let ((elem (assoc-string (gnus-group-decoded-name group) nnrss-server-data))) (insert (format "%S %s 1 y\n" group (or (cadr elem) 0))))) 'active)) @@ -539,7 +539,7 @@ (if (hash-table-p nnrss-group-hashtb) (clrhash nnrss-group-hashtb) (setq nnrss-group-hashtb (make-hash-table :test 'equal))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (setq nnrss-group-max (or (cadr pair) 0)) (setq nnrss-group-min (+ nnrss-group-max 1))) (let ((file (nnrss-make-filename group server)) @@ -644,8 +644,8 @@ (concat group ".xml")) nnrss-directory)))) (setq xml (nnrss-fetch file t)) - (setq url (or (nth 2 (assoc group nnrss-server-data)) - (cadr (assoc group nnrss-group-alist)))) + (setq url (or (nth 2 (assoc-string group nnrss-server-data)) + (cadr (assoc-string group nnrss-group-alist)))) (unless url (setq url (cdr @@ -653,7 +653,7 @@ (nnrss-discover-feed (read-string (format "URL to search for %s: " group) "http://"))))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcdr (cdr pair) (list url)) (push (list group nnrss-group-max url) nnrss-server-data))) @@ -721,7 +721,7 @@ (setq extra nil)) (when changed (nnrss-save-group-data group server) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcar (cdr pair) nnrss-group-max) (push (list group nnrss-group-max) nnrss-server-data))) @@ -792,7 +792,7 @@ (insert "RSSDIR='" (expand-file-name nnrss-directory) "'\n") (dolist (elem nnrss-server-data) (let ((url (or (nth 2 elem) - (cadr (assoc (car elem) nnrss-group-alist))))) + (cadr (assoc-string (car elem) nnrss-group-alist))))) (insert "$WGET -q -O \"$RSSDIR\"/'" (nnrss-translate-file-chars (concat (car elem) ".xml")) "' '" url "'\n")))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 14:54:56 2019 Received: (at submit) by debbugs.gnu.org; 27 Mar 2019 18:54:56 +0000 Received: from localhost ([127.0.0.1]:33546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9DhQ-0002q0-22 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 14:54:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9DhO-0002pn-JH for submit@debbugs.gnu.org; Wed, 27 Mar 2019 14:54:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:50422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9DhG-0005iW-Oz for submit@debbugs.gnu.org; Wed, 27 Mar 2019 14:54:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9DhF-0002eu-OP for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 14:54:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_40,RDNS_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9Dad-0003gi-9V for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 14:47:56 -0400 Received: from [195.159.176.226] (port=56566 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9Dad-0003gJ-0g for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 14:47:55 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h9Dab-0017qc-8w for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 19:47:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Wed, 27 Mar 2019 11:47:47 -0700 Message-ID: <87mulgf92k.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:6VcIL7pl4jJ09wEYpPmNngm0/tA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > On Tue, 26 Mar 2019 14:44:32 -0700, Eric Abrahamsen wrote: >> Thanks for this report. When you have a moment will you please try the >> attached patch and see if it fixes the problem? > > Works great. Now I can enter and read the nnml:テスト group. > Thank you. But there seem to be some more fix needed. > > The group level of nnml:テスト is 1 and there are some unread > articles in it, however the group is not listed in the Group > buffer when I launch Gnus by `C-u 1 M-x gnus RET' (it also > happened when I worked on non-ASCII group names years ago, but > I don't recall how I fixed it, sorry). Typing L helps it. Excellent -- I know where to go from here (I've also run into this before). I hope I've nearly got this sorted. > I tried changing `assoc' with `assoc-string' in nnrss.el, too. > It works for non-ASCII group names so far, though only I glanced > a few feeds. A diff is attached. Thanks! Eric From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 17:27:29 2019 Received: (at 33653) by debbugs.gnu.org; 27 Mar 2019 21:27:29 +0000 Received: from localhost ([127.0.0.1]:33600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9G53-0006R0-5M for submit@debbugs.gnu.org; Wed, 27 Mar 2019 17:27:29 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:46758 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9G50-0006Qh-8g for 33653@debbugs.gnu.org; Wed, 27 Mar 2019 17:27:27 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 20735FA02A; Wed, 27 Mar 2019 21:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553722040; bh=vLVXb+pAEyXEFqHUnXUlUvL2reE4TgsEyWQTVYH4uXc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=g43q1vfXFE0pSM33vVu5cc1vaN2P07ayEwN0K43URWLKg9zgERwBgeOW4R8HfYAWv rooRImu61ir+YhSF2VxDhPVW0ZlMUrd2/PHf0h1vGT1vSN79Q1RnjjDX/L3yBHNEcO 8caR5C2kPb1Es+5PzWTLYC15mNR92wYWGtv4aBR8= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Date: Wed, 27 Mar 2019 14:27:19 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Wed, 27 Mar 2019 13:54:42 +0900") Message-ID: <87imw4f1oo.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 03/27/19 13:54 PM, Katsumi Yamaoka wrote: > On Tue, 26 Mar 2019 14:44:32 -0700, Eric Abrahamsen wrote: >> Thanks for this report. When you have a moment will you please try the >> attached patch and see if it fixes the problem? > > Works great. Now I can enter and read the nnml:=E3=83=86=E3=82=B9=E3=83= =88 group. > Thank you. But there seem to be some more fix needed. > > The group level of nnml:=E3=83=86=E3=82=B9=E3=83=88 is 1 and there are so= me unread > articles in it, however the group is not listed in the Group > buffer when I launch Gnus by `C-u 1 M-x gnus RET' (it also > happened when I worked on non-ASCII group names years ago, but > I don't recall how I fixed it, sorry). Typing L helps it. I think I've found the source of the problem. The error you and others are seeing comes when the group has an entry in gnus-newsrc-hashtb (ie, you're subscribed to the group) but not in gnus-active-hashtb (Gnus can't tell if the group has articles). Gnus writes "nnml:=E3=83=86=E3=82=B9=E3=83=88" to .newsrc.eld as "nnml:\343\203\206\343\202\271\343\203\210", and that's used as the key in gnus-newsrc-hashtb. But when it reads the active info from nnml, the (unibyte) buffer contains: nnml:\343\203\206\343\202\271\343\203\210 As a symbol, not a string. My current code then uses `symbol-name' to turn it into a string, but it's crucially *not the same string* as the one saved to.newsrc.eld, even though it looks the same in edebug, the *scratch* buffer, etc. Hence a mismatch between the two keys in the two hash-tables, and things going haywire. Obviously this arises from a misunderstanding on my part about how bytes and strings interact. The code in question is at line 2145 in gnus-start.el -- it uses `read' to pick pieces out of the buffer. Right now my best idea is to swap out `read' for a some sort of regexp crawl, but I am open to suggestions. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 18:10:23 2019 Received: (at submit) by debbugs.gnu.org; 27 Mar 2019 22:10:23 +0000 Received: from localhost ([127.0.0.1]:33623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9GkX-0007Su-Hr for submit@debbugs.gnu.org; Wed, 27 Mar 2019 18:10:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9GkW-0007Sb-43 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 18:10:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:55525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9GkQ-0002Mf-RX for submit@debbugs.gnu.org; Wed, 27 Mar 2019 18:10:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9GkP-0000am-OQ for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 18:10:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,RDNS_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9GkO-0002Lw-8u for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 18:10:13 -0400 Received: from [195.159.176.226] (port=42646 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9GkO-0002Ji-0G for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 18:10:12 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h9GkK-000SuO-Q8 for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 23:10:08 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Wed, 27 Mar 2019 15:10:02 -0700 Message-ID: <8736n8ge9x.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:7ztznVkISvWnB+LBNC56CqechaQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > On 03/27/19 13:54 PM, Katsumi Yamaoka wrote: >> On Tue, 26 Mar 2019 14:44:32 -0700, Eric Abrahamsen wrote: >>> Thanks for this report. When you have a moment will you please try the >>> attached patch and see if it fixes the problem? >> >> Works great. Now I can enter and read the nnml:テスト group. >> Thank you. But there seem to be some more fix needed. >> >> The group level of nnml:テスト is 1 and there are some unread >> articles in it, however the group is not listed in the Group >> buffer when I launch Gnus by `C-u 1 M-x gnus RET' (it also >> happened when I worked on non-ASCII group names years ago, but >> I don't recall how I fixed it, sorry). Typing L helps it. > > I think I've found the source of the problem. The error you and others > are seeing comes when the group has an entry in gnus-newsrc-hashtb (ie, > you're subscribed to the group) but not in gnus-active-hashtb (Gnus > can't tell if the group has articles). > > Gnus writes "nnml:テスト" to .newsrc.eld as > "nnml:\343\203\206\343\202\271\343\203\210", and that's used as the key > in gnus-newsrc-hashtb. But when it reads the active info from nnml, the > (unibyte) buffer contains: > > nnml:\343\203\206\343\202\271\343\203\210 > > As a symbol, not a string. Sorry, as raw bytes I guess. But `read' interprets it as a symbol. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 30 08:09:37 2019 Received: (at 33653) by debbugs.gnu.org; 30 Mar 2019 12:09:37 +0000 Received: from localhost ([127.0.0.1]:36306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hACnn-0007oX-31 for submit@debbugs.gnu.org; Sat, 30 Mar 2019 08:09:35 -0400 Received: from mout.gmx.net ([212.227.15.15]:54557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hACnl-0007oI-Hz for 33653@debbugs.gnu.org; Sat, 30 Mar 2019 08:09:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1553947758; bh=w9htZkq0AV45qYGYObUfVOV2+hmdZ/pSnLN0lKHEAP4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=BlReK6H1k848FhzpW7+PtIhtfyaSz/WXAI1vLfanqY5yYzjdyWhGpiVJXP1OalKjw 6h/HCa/yvbrL/u5uRzYo7qUG2rv/oqi3dJtRnkNzTH2LFecZtTzVUcswZSf9mnojAb Ms5YPPeqDbxF3SvJl0fRWv/t6u2w08kFYi36q1wM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from dellcorei5dias ([37.153.145.167]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MWSwU-1hTObP39Ug-00XcZV; Sat, 30 Mar 2019 13:09:17 +0100 From: Deus Max To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <87y3536h47.fsf@bzg.fr> <871s2vlu2z.fsf@ericabrahamsen.net> Date: Sat, 30 Mar 2019 14:09:13 +0200 In-Reply-To: <871s2vlu2z.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 24 Mar 2019 16:40:36 -0700") Message-ID: <877ecg8sye.fsf@aia00054aia.gr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:+xNBJ0p84kwFjm4O9X/AZ60YxuwNZ/UvJ3dtd7K808fe8qacEuQ vE9uNZuhBG3mBChepJWvrxrH51/faSUtzbg5bSfY3Xhf+d6vJ6iW3rwEvVq6+JoPW9xuyUS Qf7zFez5vieWClZcnCnbPou80So/mc2XFil+KKuxQfOTNWg82eooP1k5BrT8zazOHVV7eM9 ASMzb7mZC8bQIO7rXIdjA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XjP+fD5BZBA=:+8xY2ckgDAhY/FNtSxKdPz KGwcVzUC9fZwDc8vznc2JeqChyKgMuBHF2xv9TDU82ciz9Huu8YcJtFrFE4QzUkh2ezDs9kbG nCUGEIRnEMEwX2EEUn8fNn2lJH4ShWPgN0qOEbqRqy4ZODpPY6ZL8RwsMmeaj4q8xJrTMG5qq NudX+W2BoXRPa37uX9MYCPPVfuIStkyezlNTWZsFDf7qt0W5gZtfxmQM84uoBOpmnfE3u0R3V SgIyfVQnJRH6xCIws7qwKFwBWPqSyJ/IMGqpaqU3d26/M6RWzIsqB2xiYhyKMHJHTecz7/CNu mD2S43eaRMA1FJRNw0XlgeKn5wlOwqmLN6PiWkD2XBY5hNWO9u9ksmeBjC2qiFRsVG8sJj626 pqzpTTt1OT7sGEax+JzGfd1drMNAyIcsrc7WvdSS1DmFL+LtzIXk0MMdxRQB6aOg/zUEoDk2Z DeKyGDMCREAxQMqqQxk+YkMsJKKfmmnkw48YGVlpf/WA10kx7giBwkWV2JZDZ0df1LD3kNQhC xOtftgSstsEWPcGY98OUwPBxoQxOsg4I1Kq1PsMe8Sp5EDOZxgxCqshWXUeC1FWsgIA2ZJmOP RxHICP0uDVHJCwl1a9ckdYx0NSinL2O9x6g0Ns3ib+NpeSZZAhrUPm4VukPinuSjluooeOhUJ OozqJ6CsObptoO78tlFbOGQyJg04HfQPjrHDlE3ky7KfG8D5Nny1uTpnU0vzWJlYcS1akSIZN MWboz6eYXGeSu3386dW8gY4RYq42FNCSBl0XvLp85URBeqJj/NcxwjgPi3T3bny3L6FDVUTjZ r+t7jzuZwk9L+JpT2XI/au4cASP2WKqJlyFvqvG64daokVnrbO6awIYaTPwscC56znJ3iCGmc dP8RcJqgAGjkvS1Xg9Z4JSWCAR4TJrnw3noBLJ0K5xcwYEhqV8YsTLQMjLcNm9Dpl+cWD++sU n8HXNSdOd/Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Eric, It seems you are implementing some pretty drastic upgrades to Gnus. Is there a write-up on the planned changes, benefits, what is going to be affected and what to expect ? I'm interested and would like to read it. On Sun, Mar 24 2019, Eric Abrahamsen wrote: > On 03/24/19 23:29 PM, Bastien wrote: >> Hi Eric, >> >> Eric Abrahamsen writes: >> >>> The bummer is that you don't get an error until you run Gnus, so it just >>> looks like I broke Gnus :( >> >> I hope not! :) >> >> I have not followed this change. >> Can it corrupt the .newsrc.eld file? > > Worst come to worst it will write non-ascii group names as unibyte when > they should be utf-8, or else the other way around. I thought I could > avoid dealing with this question for now, and just preserve Gnus' > original method of saving group names, but it looks like I may have > forced the issue instead... From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 31 19:29:19 2019 Received: (at 33653) by debbugs.gnu.org; 31 Mar 2019 23:29:20 +0000 Received: from localhost ([127.0.0.1]:38633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAjt9-00084r-Cq for submit@debbugs.gnu.org; Sun, 31 Mar 2019 19:29:19 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:55776 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAjt7-00084c-2U for 33653@debbugs.gnu.org; Sun, 31 Mar 2019 19:29:18 -0400 Received: from localhost (unknown [172.58.41.175]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 70CB5FA02A; Sun, 31 Mar 2019 23:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554074951; bh=xxUJrPrCuX6VFtPl3e9CgMRDiOsizKqidAE0vUZM1G4=; h=From:To:Cc:Subject:In-Reply-To:Date:References:From; b=J4XIi6EPL1GAS+5kASiwnm9wmARmG22gmpUkyDRuqZSbGPb6DbCI/UdX3FeCTRfjh ogToR/yNohYHMyFgKLPrkgf7bz2SsxHzBj+1WvOhWp0fa6rI2cIT82hkNR2Aexdq52 f34Ys87sTRRh0UcHfjJTqDhXfLcnS57DXRBaHMds= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables In-Reply-To: <87imw4f1oo.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 27 Mar 2019 14:27:19 -0700") Date: Sun, 31 Mar 2019 15:55:15 -0700 Message-ID: <874l7i3b8s.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , =?utf-8?Q?Adam_Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/27/19 14:27 PM, Eric Abrahamsen wrote: > On 03/27/19 13:54 PM, Katsumi Yamaoka wrote: >> On Tue, 26 Mar 2019 14:44:32 -0700, Eric Abrahamsen wrote: >>> Thanks for this report. When you have a moment will you please try the >>> attached patch and see if it fixes the problem? >> >> Works great. Now I can enter and read the nnml:=E3=83=86=E3=82=B9=E3=83= =88 group. >> Thank you. But there seem to be some more fix needed. >> >> The group level of nnml:=E3=83=86=E3=82=B9=E3=83=88 is 1 and there are s= ome unread >> articles in it, however the group is not listed in the Group >> buffer when I launch Gnus by `C-u 1 M-x gnus RET' (it also >> happened when I worked on non-ASCII group names years ago, but >> I don't recall how I fixed it, sorry). Typing L helps it. > > I think I've found the source of the problem. The error you and others > are seeing comes when the group has an entry in gnus-newsrc-hashtb (ie, > you're subscribed to the group) but not in gnus-active-hashtb (Gnus > can't tell if the group has articles). Okay, it might be as simple as the attached patch, applied to current master. Basically this forces nnmail to always write the group names as strings, which are then read correctly later on. Also cc'ing Bastien and Adam, who have been very helpful with road-testing. Thanks to all, Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-WIP-on-nnmail-group-names.patch >From 05c5d299fa4342cce6c4921b5c5387d6be07c89a Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sun, 31 Mar 2019 09:09:18 -0700 Subject: [PATCH 1/2] WIP on nnmail group names --- lisp/gnus/nnmail.el | 2 +- lisp/gnus/nnml.el | 16 ++++++++-------- lisp/gnus/nnrss.el | 18 +++++++++--------- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el index a95cdb4a4f..a84830b48d 100644 --- a/lisp/gnus/nnmail.el +++ b/lisp/gnus/nnmail.el @@ -691,7 +691,7 @@ nnmail-generate-active (erase-buffer) (let (group) (while (setq group (pop alist)) - (insert (format "%S %d %d y\n" (intern (car group)) (cdadr group) + (insert (format "\"%s\" %d %d y\n" (car group) (cdadr group) (caadr group)))) (goto-char (point-max)) (while (search-backward "\\." nil t) diff --git a/lisp/gnus/nnml.el b/lisp/gnus/nnml.el index 5770777ad4..205e9e4803 100644 --- a/lisp/gnus/nnml.el +++ b/lisp/gnus/nnml.el @@ -259,7 +259,7 @@ nnml-request-group (t (nnheader-re-read-dir nnml-current-directory) (nnmail-activate 'nnml) - (let ((active (nth 1 (assoc group nnml-group-alist)))) + (let ((active (nth 1 (assoc-string group nnml-group-alist)))) (if (not active) (nnheader-report 'nnml "No such group: %s" decoded) (nnheader-report 'nnml "Selected group %s" decoded) @@ -295,7 +295,7 @@ nnml-request-create-group (nnheader-report 'nnml "%s is a file" (directory-file-name (nnml-group-pathname group nil server)))) - ((assoc group nnml-group-alist) + ((assoc-string group nnml-group-alist) t) (t (let (active) @@ -379,7 +379,7 @@ nnml-request-expire-articles (nnml-nov-delete-article group number)) (push number rest))) (push number rest))) - (let ((active (nth 1 (assoc group nnml-group-alist)))) + (let ((active (nth 1 (assoc-string group nnml-group-alist)))) (when active (setcar active (or (and active-articles (apply 'min active-articles)) @@ -520,7 +520,7 @@ nnml-request-delete-group (nnheader-report 'nnml "No such directory: %s/" file)) ;; Remove the group from all structures. (setq nnml-group-alist - (delq (assoc group nnml-group-alist) nnml-group-alist) + (delq (assoc-string group nnml-group-alist) nnml-group-alist) nnml-current-group nil nnml-current-directory nil) ;; Save the active file. @@ -549,7 +549,7 @@ nnml-request-rename-group (when (<= (length (directory-files old-dir)) 2) (ignore-errors (delete-directory old-dir))) ;; That went ok, so we change the internal structures. - (let ((entry (assoc group nnml-group-alist))) + (let ((entry (assoc-string group nnml-group-alist))) (when entry (setcar entry new-name)) (setq nnml-current-directory nil @@ -597,7 +597,7 @@ nnml-deletable-article-p (when (setq path (nnml-article-to-file article)) (when (file-writable-p path) (or (not nnmail-keep-last-article) - (not (eq (cdr (nth 1 (assoc group nnml-group-alist))) + (not (eq (cdr (nth 1 (assoc-string group nnml-group-alist))) article))))))) ;; Find an article number in the current group given the Message-ID. @@ -742,7 +742,7 @@ nnml-active-number "Compute the next article number in GROUP on SERVER." (let* ((encoded (if nnmail-group-names-not-encoded-p (nnml-encoded-group-name group server))) - (active (cadr (assoc (or encoded group) nnml-group-alist)))) + (active (cadr (assoc-string (or encoded group) nnml-group-alist)))) ;; The group wasn't known to nnml, so we just create an active ;; entry for it. (unless active @@ -783,7 +783,7 @@ nnml-save-incremental-nov (cdr nnml-incremental-nov-buffer-alist))))) (defun nnml-open-incremental-nov (group) - (or (cdr (assoc group nnml-incremental-nov-buffer-alist)) + (or (cdr (assoc-string group nnml-incremental-nov-buffer-alist)) (let ((buffer (nnml-get-nov-buffer group t))) (push (cons group buffer) nnml-incremental-nov-buffer-alist) buffer))) diff --git a/lisp/gnus/nnrss.el b/lisp/gnus/nnrss.el index 7f2accc2b6..0bfecb28e0 100644 --- a/lisp/gnus/nnrss.el +++ b/lisp/gnus/nnrss.el @@ -340,10 +340,10 @@ nnrss-request-delete-group (let (elem) ;; There may be two or more entries in `nnrss-group-alist' since ;; this function didn't delete them formerly. - (while (setq elem (assoc group nnrss-group-alist)) + (while (setq elem (assoc-string group nnrss-group-alist)) (setq nnrss-group-alist (delq elem nnrss-group-alist)))) (setq nnrss-server-data - (delq (assoc group nnrss-server-data) nnrss-server-data)) + (delq (assoc-string group nnrss-server-data) nnrss-server-data)) (nnrss-save-server-data server) (ignore-errors (let ((file-name-coding-system nnmail-pathname-coding-system)) @@ -367,7 +367,7 @@ nnrss-retrieve-groups (with-current-buffer nntp-server-buffer (erase-buffer) (dolist (group groups) - (let ((elem (assoc (gnus-group-decoded-name group) nnrss-server-data))) + (let ((elem (assoc-string (gnus-group-decoded-name group) nnrss-server-data))) (insert (format "%S %s 1 y\n" group (or (cadr elem) 0))))) 'active)) @@ -539,7 +539,7 @@ nnrss-read-group-data (if (hash-table-p nnrss-group-hashtb) (clrhash nnrss-group-hashtb) (setq nnrss-group-hashtb (make-hash-table :test 'equal))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (setq nnrss-group-max (or (cadr pair) 0)) (setq nnrss-group-min (+ nnrss-group-max 1))) (let ((file (nnrss-make-filename group server)) @@ -644,8 +644,8 @@ nnrss-check-group (concat group ".xml")) nnrss-directory)))) (setq xml (nnrss-fetch file t)) - (setq url (or (nth 2 (assoc group nnrss-server-data)) - (cadr (assoc group nnrss-group-alist)))) + (setq url (or (nth 2 (assoc-string group nnrss-server-data)) + (cadr (assoc-string group nnrss-group-alist)))) (unless url (setq url (cdr @@ -653,7 +653,7 @@ nnrss-check-group (nnrss-discover-feed (read-string (format "URL to search for %s: " group) "http://"))))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcdr (cdr pair) (list url)) (push (list group nnrss-group-max url) nnrss-server-data))) @@ -721,7 +721,7 @@ nnrss-check-group (setq extra nil)) (when changed (nnrss-save-group-data group server) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcar (cdr pair) nnrss-group-max) (push (list group nnrss-group-max) nnrss-server-data))) @@ -792,7 +792,7 @@ nnrss-generate-download-script (insert "RSSDIR='" (expand-file-name nnrss-directory) "'\n") (dolist (elem nnrss-server-data) (let ((url (or (nth 2 elem) - (cadr (assoc (car elem) nnrss-group-alist))))) + (cadr (assoc-string (car elem) nnrss-group-alist))))) (insert "$WGET -q -O \"$RSSDIR\"/'" (nnrss-translate-file-chars (concat (car elem) ".xml")) "' '" url "'\n")))) -- 2.21.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 31 19:29:23 2019 Received: (at 33653) by debbugs.gnu.org; 31 Mar 2019 23:29:23 +0000 Received: from localhost ([127.0.0.1]:38636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAjtC-000858-TY for submit@debbugs.gnu.org; Sun, 31 Mar 2019 19:29:23 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:55786 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAjt9-00084g-Ev for 33653@debbugs.gnu.org; Sun, 31 Mar 2019 19:29:19 -0400 Received: from localhost (unknown [172.58.41.175]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 841B6FA180; Sun, 31 Mar 2019 23:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554074954; bh=oGoTzRoWDAGZrEcpW9vTHs0hcaDe1qXZonEmqVapxpE=; h=From:To:Cc:Subject:In-Reply-To:Date:References:From; b=UeBt3ypy7UFciAlfEKWIgvy5J9zBZ2IR0ZzRn6b5692MdKNiEXcztTV+XQ1o6dy3l 10fYXWUtKnMfoj5SAtrCwn4trCOmzB+55Mn+57oicOYMporTginfWcn0h1zr2ooehk W65bZy18HxU5JG7GPgk7QmMcQGWsuk8cnsmZG9Q0= From: Eric Abrahamsen To: Deus Max Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables In-Reply-To: <877ecg8sye.fsf@aia00054aia.gr> (Deus Max's message of "Sat, 30 Mar 2019 14:09:13 +0200") Date: Sun, 31 Mar 2019 16:27:46 -0700 Message-ID: <871s2m39ql.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <87y3536h47.fsf@bzg.fr> <871s2vlu2z.fsf@ericabrahamsen.net> <877ecg8sye.fsf@aia00054aia.gr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 03/30/19 14:09 PM, Deus Max wrote: > Hi Eric, > > It seems you are implementing some pretty drastic upgrades to Gnus. > > Is there a write-up on the planned changes, benefits, what is going to be > affected and what to expect ? > > I'm interested and would like to read it. There is a writeup! Sort of -- I called it a roadmap. Originally I stuck it in a branch called scratch/gnus-roadmap but soon realized it didn't make any sense to keep track of something like this in a git branch. I've attached the current version. Obviously, this is _not_ meant as a list of "changes I will unilaterally implement in Gnus", but as a document for record-keeping and discussion. I didn't get much discussion, but I know that's to be expected! Eric --=-=-= Content-Type: application/vnd.lotus-organizer Content-Disposition: attachment; filename=roadmap.org Content-Transfer-Encoding: base64 IytUSVRMRTogR251cyBSb2FkbWFwCiMrU1VCVElUTEU6IFBvdGVudGlhbCBmaXh1cHMgYW5kIHJl ZmFjdG9yaW5nIGZvciBHbnVzCiMrREFURTogPDIwMTctMTAtMTcgVHVlPgojK0FVVEhPUjogRXJp YyBBYnJhaGFtc2VuCiMrRU1BSUw6IGVyaWNAZXJpY2FicmFoYW1zZW4ubmV0CiMrTEFOR1VBR0U6 IGVuCgojIFRoZSAidXNlciIgdGFnIGluZGljYXRlcyBhIG5vbi1iYWNrd2FyZHMtY29tcGF0aWJs ZSBjaGFuZ2UgdGhhdCB0aGUKIyB1c2VyIHdvdWxkIGhhdmUgdG8gYmUgbWFkZSBhd2FyZSBvZi4K KiBFYXN5IGZpeGVzIGFuZCB1cGRhdGVzCioqIFRPRE8gT2Jzb2xldGUgfmdudXMtZGVmYXVsdC1u bnRwLXNlcnZlcn4KQWxvbmcgd2l0aCB+Z251cy1ubnRwLXNlcnZlcn4sIGFuZCBqdXN0IHJlbW92 ZSB0aGF0IHdob2xlICJzZWxlY3QgYW4Kbm50cCBzZXJ2ZXIiIG1lY2hhbmlzbSBjb21wbGV0ZWx5 LiB+Z251cy1ubnRwLXNlcnZlcn4gd2FzIG9ic29sZXRlZCBpbgoyNC4xLCBtaWdodCBsZXQgaXQg c2l0IGZvciBhIGJpdCBsb25nZXIuCioqIERPTkUgUmVwbGFjZSB+Z251cy1jb3B5LXNlcXVlbmNl fiB3aXRoIH5jb3B5LXRyZWV+CjpMT0dCT09LOgotIFN0YXRlICJET05FIiAgICAgICBmcm9tICJU T0RPIiAgICAgICBbMjAxNy0wNS0wOSBUdWVdCjpFTkQ6Ckl0IGRvZXMgdGhlIHNhbWUgdGhpbmcu CioqIERPTkUgUmVwbGFjZSB+Z251cy1sYXN0LWVsZW1lbnR+IHdpdGggfihjYXIgKGxhc3QgTElT VCkpfgo6TE9HQk9PSzoKLSBTdGF0ZSAiRE9ORSIgICAgICAgZnJvbSAiVE9ETyIgICAgICAgWzIw MTctMDUtMDkgVHVlXQo6RU5EOgpVc2luZyB+bGFzdH4gaXMgbW9yZSBlZmZpY2llbnQuCioqIFRP RE8gUmVtb3ZlIH5nbnVzLXJlcGxhY2UtaW4tc3RyaW5nfgpMb29rcyBsaWtlIHRoaXMgaXMgb25s eSBoZXJlIGZvciBvdGhlciBFbWFjc2VuLgoqKiBUT0RPIElzIH5nbnVzLWV2YWwtaW4tYnVmZmVy LXdpbmRvd34gcmVkdW5kYW50PwpJcyBpdCB0aGUgc2FtZSBhcyB+c2F2ZS13aW5kb3ctZXhjdXJz aW9ufiBwbHVzIH53aXRoLWN1cnJlbnQtYnVmZmVyfj8KKiogVE9ETyBSZXBsYWNlIH5nbnVzLXN0 cmluZz5+IHdpdGggfnN0cmluZz5+CioqIENBTkNFTExFRCBSZW1vdmUgfmdudXMteS1vci1uLXB+ IGFuZCB+Z251cy15ZXMtb3Itbm8tcH4KOkxPR0JPT0s6Ci0gU3RhdGUgIkNBTkNFTExFRCIgIGZy b20gIlRPRE8iICAgICAgIFsyMDE5LTAzLTMxIFN1biAxNTo0NF0gXFwKICBUaGUgY2FsbCB0byBt ZXNzYWdlIGNsZWFycyB0aGUgbWluaWJ1ZmZlci4KOkVORDoKV2h5IHRoZSBjYWxsIHRvIH5tZXNz YWdlfj8KKiogVE9ETyBVc2UgZG9saXN0IHdoZXJlIHBvc3NpYmxlClRoZXJlJ3MgYSB3aG9sZSBs b3Qgb2YgY29kZSB0aGF0IHVzZXMgfih3aGlsZSAoc2V0cSB0aGluZyAoY2FyCmxpc3QpKS4uLil+ IGFuZCB0aGUgbGlrZSwgYW5kIGl0IG1ha2VzIGFscmVhZHktY29udm9sdXRlZCBmdW5jdGlvbnMK dGhhdCBtdWNoIG1vcmUgZGlmZmljdWx0IHRvIHBhcnNlLiBUaGVyZSBhcmUgY2xlYW5lciBjb252 ZW50aW9ucyB0aGF0CmNvdWxkIGJlIHVzZWQgbm93LgoqKiBUT0RPIFVzZSB+cHJvY2Vzcy1saXZl LXB+Ckluc3RlYWQgb2YgfihtZW1xIChwcm9jZXNzLXN0YXR1cyBwcm9jZXNzKSAnKG9wZW4gcnVu KSl+LiBFeGNlcHQgdGhhdAp0aGUgY3VycmVudCBjb2RlIGNoZWNrcyB+JyhvcGVuIHJ1bil+LCBh bmQgfnByb2Nlc3MtbGl2ZS1wfiBjaGVja3MKficocnVuIG9wZW4gbGlzdGVuIGNvbm5lY3Qgc3Rv cCl+LiBQcm9iYWJseSB3b24ndCBiZWhhdmUgdGhlIHNhbWUuCioqIENBTkNFTExFRCBSZXBsYWNl IH5nbnVzLXN0cmluZzx+IHdpdGggfnN0cmluZzx+CjpMT0dCT09LOgotIFN0YXRlICJDQU5DRUxM RUQiICBmcm9tICJUT0RPIiAgICAgICBbMjAxNy0xMC0wNiBGcmkgMDk6MDJdIFxcCiAgTm9wZSwg bG9va3MgbGlrZSB0aGlzIG9uZSBkb2VzIGJlaGF2ZSBkaWZmZXJlbnRseSwgd2l0aCByZXNwZWN0 IHRvCiAgfmNhc2UtZm9sZC1zZWFyY2h+IGFuZCBvZiBjb3Vyc2UgdGhlIHN5bWJvbHMuCjpFTkQ6 CiogTWVkaXVtLWxldmVsIHJlZmFjdG9yaW5nCioqIFRPRE8gQ29tYmluZSBnbnVzLWV4cGVydC11 c2VyIGFuZCBnbnVzLW5vdmljZS11c2VyICAgICAgICAgICAgICAgICA6dXNlcjoKV2h5IHdvdWxk IHdlIG5lZWQgYm90aD8gVGhlIGRvY3N0cmluZ3MgbWFrZSB0aGVtIHNvdW5kIHNpbWlsYXIuIElm CiJub3ZpY2UiIGdvdmVybnMgdmVyYm9zaXR5IC9hbmQvIGNvbmZpcm1hdGlvbnMsIGFuZCAiZXhw ZXJ0IiBqdXN0CmdvdmVybnMgY29uZmlybWF0aW9ucywgdGhlbiB3ZSBjb3VsZCBtb3ZlIGFsbCB2 ZXJib3NpdHkgYmVoYXZpb3IgdW5kZXIKfmdudXMtdmVyYm9zZX4gYW5kIG9ubHkga2VlcCBvbmUg ImV4cGVydCIgc2V0dGluZyB0aGF0IG9ubHkgZ292ZXJuZWQKY29uZmlybWF0aW9ucy4gSXQgYWxz byBzZWVtcyBsaWtlIH5nbnVzLWludGVyYWN0aXZlLWNhdGNodXB+IHNob3VsZCBiZQpwYXJ0IG9m IHRoZSAiZXhwZXJ0IiBzZXR0aW5nLCB0aG91Z2ggcGVyaGFwcyB+Z251cy1pbnRlcmFjdGl2ZS1l eGl0fgpzaG91bGQgcmVtYWluIGl0cyBvd24gdGhpbmcuCioqIFRPRE8gQ29uc29saWRhdGUgc2Vy dmVyIGxpc3RzClZhcnMgdGhhdCBsaXN0IHRoZSBjdXJyZW50bHktZGVmaW5lZCBzZXJ2ZXJzOgoK MS4gfmdudXMtc2VydmVyLWFsaXN0fjogQ29udGFpbnMgc2VydmVycyBlaXRoZXIgZGVmaW5lZCBi eSBHbnVzLCBvcgogICBhZGRlZCBieSB0aGUgdXNlciB0aHJvdWdoIHRoZSBTZXJ2ZXIgYnVmZmVy IGludGVyZmFjZS4KMi4gfmdudXMtb3BlbmVkLXNlcnZlcnN+OiBIb2xkcyBhbGwgdGhlIHNlcnZl cnMgKGJvdGggb3BlbmVkIGFuZCBpbgogICBvdGhlciBzdGF0dXNlcyksIHRoZWlyIHBhcmFtZXRl cnMsIGFuZCBhIHN0YXR1cyBzeW1ib2wuCjMuIH5ubm9vLXN0YXRlLWFsaXN0fjogSG9sZHMgYWxs IHRoZSBzZXJ2ZXJzLCBzb21lIG90aGVyIHNlcnZlcnMgKD8pLAogICBhbmQgYWxsIHRoZSBncm91 cHMgYW5kIG1hcmtzLgo1LiB+Z251cy1zZXJ2ZXItbWV0aG9kLWNhY2hlfjogQSBzaW1wbGVyIGFs aXN0IG9mIHNlcnZlciBuYW1lcyBhbmQKICAgc2VydmVyIHZhcmlhYmxlcy4KCkhvdyByZWR1bmRh bnQgYXJlIHRoZXNlPwoKVmFycyB0aGF0IGxpc3Qgc2VydmVycyB0aGF0IG1pZ2h0IGJlOgoKMS4g fmdudXMtdmFsaWQtc2VsZWN0LW1ldGhvZHN+OiBGYWlybHkgbGlnaHR3ZWlnaHQgbGlzdCBvZiBk ZWZpbmVkCiAgIHNlcnZlciB0eXBlcyBhbmQgdGhlaXIgY2F0ZWdvcnkga2V5cy4gU2V0IGJ5CiAg IH5nbnVzLWRlY2xhcmUtYmFja2VuZH4uCjIuIH5ubm9vLWRlZmluaXRpb24tYWxpc3R+OiBIZWF2 eXdlaWdodCBsaXN0IG9mIGRlZmluZWQgc2VydmVyIHR5cGVzCiAgIHdpdGggYWxsIHRoZWlyIHBv c3NpYmxlIHNlcnZlciBwYXJhbWV0ZXJzIGFuZCBmdW5jdGlvbnMuCjMuIH5nbnVzLXByZWRlZmlu ZWQtc2VydmVyLWFsaXN0fjogVGhpcyBvbmUgbm90IHNvIG11Y2gsIGl0IGp1c3QKICAgaW5kaWNh dGVzIHdoYXQgd2Ugc2hvdWxkIHN0YXJ0IG91dCB3aXRoLgoqKiBUT0RPIFVzZSBXaXNlbnQgcGFy c2VyIGZvciBzZXJ2ZXIgb3V0cHV0Ck9uY2UgQ0VERVQgaXMgZnVsbHkgbWVyZ2VkIGludG8gRW1h Y3MsIHdyaXRlIGEgcHJvcGVyIHBhcnNlciBmb3IgTk5UUAphbmQgSU1BUCBzZXJ2ZXIgb3V0cHV0 LgoqKiBUT0RPIFVzZSByZWFsIGhhc2h0YWJsZXMKOlBST1BFUlRJRVM6CjpJRDogICAgICAgYTc3 YzNjM2YtZWU5MC00ZmRkLTk5ZDctZmQ0YzYzNmMxNGJiCjpFTkQ6ClRoZXNlIHZhcmlhYmxlcyBh cmUgY3VycmVudGx5IGNhbGxlZCBoYXNodGFibGVzLCBidXQgYWN0dWFsbHkgdXNlCm9iYXJyYXlz LiBBcmUgYW55IG9mIHRoZW0gd29ydGggdHVybmluZyBpbnRvIHJlYWwgaGFzaCB0YWJsZXM/Cgot IGdudXMtZHVwLWhhc2h0YgotIGdudXMtYXN5bmMtaGFzaHRiCi0gZ251cy1raWxsZWQtaGFzaHRi Ci0gZ251cy1hY3RpdmUtaGFzaHRiCi0gZ251cy1uZXdzcmMtaGFzaHRiCi0gZ251cy1iYWNrbG9n LWhhc2h0YgotIGdudXMtbW9kZXJhdGVkLWhhc2h0YgotIGdudXMtYWdlbnQtc3BhbS1oYXNodGIK LSBnbnVzLWRlc2NyaXB0aW9uLWhhc2h0YgotIGdudXMtY2FjaGUtYWN0aXZlLWhhc2h0YgotIGdu dXMtY2FjaGUtdG90YWwtZmV0Y2hlZC1oYXNodGIKLSBnbnVzLWFnZW50LXRvdGFsLWZldGNoZWQt aGFzaHRiCioqIFRPRE8gUmVmYWN0b3IgZ3JvdXAgcmVhZGluZy9zZWxlY3Rpb24KVGhpcyB3b3Vs ZG4ndCBoYXZlIHRvIGJlIGFzIGhhcmQgYXMgaXQgc291bmRzLgoKUmlnaHQgbm93IHdlIGRvIChp biBtYWtlLWJlbGlldmUgY29kZSk6CgojK0JFR0lOX1NSQyBlbWFjcy1saXNwCiAgKGdudXMtZ3Jv dXAtcmVhZC1ncm91cAogICAoZ251cy1zdW1tYXJ5LXJlYWQtZ3JvdXAKICAgIChnbnVzLXN1bW1h cnktcmVhZC1ncm91cC0xCiAgICAgKGdudXMtc2VsZWN0LW5ld3Nncm91cAogICAgICAoZ251cy1y ZXF1ZXN0LWdyb3VwKQogICAgICAoZ251cy1yZXRyaWV2ZS1oZWFkZXJzKSkpKSkKIytFTkRfU1JD CgpBbG1vc3QgYWxsIHRob3NlIGZ1bmN0aW9ucywgYXBhcnQgZnJvbSB0aGUgdHdvIGlubmVybW9z dCBvbmVzLCBhcmUKaW52b2x2ZWQgaW4gbW9zdCBhc3BlY3RzIG9mIHN1bW1hcnkgYnVmZmVyIGNy ZWF0aW9uOiBjaG9vc2luZyBhcnRpY2xlcwp0byByZWFkLCBtYW5pcHVsYXRpbmcgbWFya3MsIGRv aW5nIGVuY29kaW5nLCBoYW5kbGluZyBwZXJpcGhlcmFsIHN0dWZmCmxpa2UgY2FjaGluZywgaGFu ZGxpbmcgZXJyb3JzLCBhbmQgZG9pbmcgdGhlIHZpc3VhbCBzZXR1cCBvZiB0aGUKXHN0YXJ7fVN1 bW1hcnlcc3RhciBidWZmZXIuCgpUcnkgdG8gdW5waWNrIHRoZXNlIGZ1bmN0aW9ucyBhIGJpdDoK Ci0gfmdudXMtZ3JvdXAtcmVhZC1ncm91cH4gOjogQW5kIG90aGVyIHNpbWlsYXIgZnVuY3Rpb25z IHNob3VsZCBiZQogICAgIHRoaW4gaW50ZXJhY3RpdmUgd3JhcHBlcnMgdGhhdCBoYW5kbGUgdXNl ciBwcm9tcHRzLgotIH5nbnVzLXN1bW1hcnktcmVhZC1ncm91cH4gOjogQ2FsbHMgfmdudXMtc2Vs ZWN0LW5ld3Nncm91cH4gdG8gZ2V0CiAgICAgdGhlIGRlc2lyZWQgYXJ0aWNsZSBoZWFkZXJzLCBj b25zdWx0cyB0aGUgZGlzcGxheS0vc2VsZWN0LXJlbGF0ZWQKICAgICBhcmd1bWVudHMsIGFuZCBo YW5kbGVzIGVpdGhlciBzZXR0aW5nIHVwIHRoZSBzdW1tYXJ5IGJ1ZmZlciwgb3IKICAgICBxdWl0 dGluZy4gVGhpcyBmdW5jdGlvbiBkb2Vzbid0IGZvb2wgd2l0aCB0aGUgc2VsZWN0aW9uIG9mCiAg ICAgYXJ0aWNsZXMgYXQgYWxsLgotIH5nbnVzLXNlbGVjdC1uZXdzZ3JvdXB+IDo6IElzIHBhc3Nl ZCBhcmd1bWVudHMgc2F5aW5nIGhvdyBtYW55L3doaWNoCiAgICAgYXJ0aWNsZXMgdG8gZmV0Y2gu IEV4YW1pbmVzIHRoZSBncm91cCBpbmZvLCBjYWxscwogICAgIH5nbnVzLXJlcXVlc3QtZ3JvdXB+ IGFuZCB+Z251cy1yZXRyaWV2ZS1oZWFkZXJzfiwgYW5kIHBhc3NlcyB0aGUKICAgICBoZWFkZXJz IGJhY2sgdXAuIFRoaXMgZnVuY3Rpb24gaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCB0aGUgdmlzdWFs CiAgICAgcHJlc2VudGF0aW9uIG9mIHRoZSBzdW1tYXJ5IGJ1ZmZlci4KClRoYXQgd291bGQgZ2V0 IHVzIGEgc3RlcCBjbG9zZXIgdG8gYmVpbmcgYWJsZSB0byB3cml0ZSB0ZXN0cy4KCkFsc28sIHRo ZSB2YXJpb3VzIGFyZ3VtZW50cyBsaWtlIH5zaG93LWFsbH4sIH5uby1kaXNwbGF5fiwKfm5vLWFy dGljbGV+LCB+c2VsZWN0LWFydGljbGVzfiwgZXRjLCBhcmUgZWl0aGVyIHN0ZXBwaW5nIG9uIGVh Y2gKb3RoZXJzJyB0b2VzLCBvciBzaG91bGQgYmUgZG9jdW1lbnRlZCBhIGxpdHRsZSBiZXR0ZXIg c28gdGhlaXIKcmVsYXRpb25zaGlwIGlzIGNsZWFyZXIuCioqIFRPRE8gVXBkYXRlIHRvIHVzZSB+ ZGVjb2RlLWNvZGluZy1zdHJpbmd+CkdldCByaWQgb2YgdGhlIGxhc3QgdXNlcyBvZiB+c3RyaW5n LSh0b3xmcm9tKS0odW5pfG11bHRpKWJ5dGV+LgpGaW5hbGx5IGNsZWFyIHVwIHRob3NlIGNvbXBp bGVyIHdhcm5pbmdzLgoqKiBUT0RPIENvbnNvbGlkYXRlIGRpcmVjdG9yeSB2YXJpYWJsZXMgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOnVzZXI6CklzIHRoZXJlIHJlYWxseSBhIG5lZWQg Zm9yIHNlcGFyYXRlIHZhcmlhYmxlcyBmb3IgfmdudXMtZGlyZWN0b3J5fiwKfmdudXMtaG9tZS1k aXJlY3Rvcnl+LCBhbmQgfmdudXMtZGVmYXVsdC1kaXJlY3Rvcnl+PwoqKiBUT0RPIENvbnNpZGVy IHVzaW5nIHNpZGUgd2luZG93cyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnVz ZXI6Ckluc3RlYWQgb2YgR251cycgd2luZG93IGNvbmZpZz8KKiBIYXJkIHJlZmFjdG9yaW5nCioq IFRPRE8gV3JpdGUgbWFyay1zZXR0aW5nIG1hY3JvcwpUaGUgZ29hbCB3b3VsZCBiZSB0byBnZXQg YWxsIG9wYXF1ZSB3cml0ZS1vbmx5IGNvZGUgb3V0IG9mIHRoZQoiZ251cy1zdW0iIGFuZCAiZ251 cy1ncm91cCIgZmlsZXMsIGFuZCBtb3ZlZCBpbnRvIChwcm9iYWJseSkKImdudXMtcmFuZ2UiLiBX aGVuIGhhY2tlcnMgYW5kIGJ1Zy1yZXBvcnRlcnMgbG9vayBhdCB0aGVzZSBmaWxlcywgdGhleQpz aG91bGRuJ3QgaGF2ZSB0byBpbnRlcnByZXQgY29kZSBiaXRzIGxpa2UgfihzZXRjZHIgbGlzdCAo Y2RkcgpsaXN0KSl+LiBDcmVhdGUgYSBoYW5kZnVsIG9mIG1hY3JvcyB3aXRoIHNlbnNpYmxlIG5h bWVzIHRvIGhhbmRsZQp0aGUgY29tbW9uIHRyYW5zYWN0aW9ucy4KClN0YXJ0IHdpdGggfmdudXMt cmFuZ2Utc3RhcnR+IGFuZCB+Z251cy1yYW5nZS1lbmR+LCBkZWZpbmVkIHVzaW5nCn5kZWZpbmUt aW5saW5lfiBzbyB0aGF0IHRoZXkgY2FuIGJvdGggYmUgdXNlZCB0byByZXR1cm4gdGhlIHN0YXJ0 IGFuZAplbmQgb2YgYSByYW5nZSwgYnV0IGFsc28gc2V0IHRoZSBzdGFydC9lbmQsIHRydW5jYXRp bmcgdGhlIHJhbmdlCmFwcHJvcHJpYXRlbHkuCioqIFRPRE8gSW4tcGxhY2UgU3VtbWFyeSBidWZm ZXIgdXBkYXRpbmcKOlBST1BFUlRJRVM6CjpJRDogICAgICAgNTdjYjEzOTYtMjI0Ni00ZDk2LTkx MjUtNWU2ZDRkMmRhZGE0CjpFTkQ6ClJpZ2h0IG5vdyBpdCdzIHBvc3NpYmxlIHRvIHVwZGF0ZSBh IFN1bW1hcnkgYnVmZmVyIHdoaWxlIGl0J3Mgb3BlbiwKYnV0IHdoYXQgYWN0dWFsbHkgaGFwcGVu cyBpcyB0aGF0IGl0IGlzIGNsb3NlZCAod2hpY2ggc2VuZHMgYW55CnVwZGF0ZXMgdG8gdGhlIHNl cnZlcikgYW5kIHRoZW4gcmUtb3BlbmVkLiBDb25zaWRlciBtZXJnaW5nIGxvY2FsCmNoYW5nZXMg YW5kIHJlbW90ZSBjaGFuZ2VzIGFuZCBvbmx5IHVwZGF0aW5nIHRoZSBTdW1tYXJ5IGJ1ZmZlciB3 aXRoCnRoZSBkZWx0YS4KCklmIHRoaXMgd2VyZSBzdWZmaWNpZW50bHkgZmFzdCwgaXQgd291bGQg bWVhbiB0aGF0IFtbaWQ6YmE2ZDczZGMtYzVmMS00OGQwLWIzZTMtYWVlYzBlNzMxNTAzXVt0aHJl YWRpbmddXSBpbgpjb21iaW5hdGlvbiB3aXRoIFtbaWQ6Y2MzM2FiODEtOTIxOS00YTk4LWJkNmQt Zjc5YjA4ZGExYTVkXVtwZXJzaXN0ZW50IFN1bW1hcnkgYnVmZmVyc11dIHdvdWxkIGxldCB1cyBs YXVuY2ggYSAiZyIKdXBkYXRlLCBvcGVuIGEgZ3JvdXAgdG8gc3RhcnQgcmVhZGluZywgdGhlbiAo d2l0aCBhIHNob3J0IGhpY2N1cCkgaGF2ZQpzdW1tYXJpZXMgdXBkYXRlZCB3aGlsZSB0aGV5J3Jl IG9wZW4uCioqIFRPRE8gUGVyc2lzdGVudCBTdW1tYXJ5IGJ1ZmZlcnMKOlBST1BFUlRJRVM6CjpJ RDogICAgICAgY2MzM2FiODEtOTIxOS00YTk4LWJkNmQtZjc5YjA4ZGExYTVkCjpFTkQ6Ck9uZSBv ZiB0aGUgbWFpbiByZWFzb25zIHRoYXQgR251cyAvZmVlbHMvIHNsb3cgaXMgdGhhdCBTdW1tYXJ5 IGJ1ZmZlcnMKYXJlIHNsb3cgdG8gZ2VuZXJhdGUuIEFkZGl0aW9uYWxseSwgYXMgR251cyBpcyB1 c2VkIG1vcmUgYW5kIG1vcmUgYXMgYQptYWlsIGNsaWVudCAoYXMgb3Bwb3NlZCB0byBhIG5ld3Ny ZWFkZXIpLCBpdCBzZWVtcyBsaWtlbHkgdGhhdCB1c2VyCmJlaGF2aW9yIHdpbGwgdGVuZCBtb3Jl IHRvd2FyZHMgcmVvcGVuaW5nIHRoZSBzYW1lIGdyb3VwcyBtdWx0aXBsZQp0aW1lcy4gSWYgU3Vt bWFyeSBidWZmZXJzIHdlcmUgc2ltcGx5IGxlZnQgb3BlbiwgaXQgd291bGQgY3JlYXRlIHRoZQpp bXByZXNzaW9uIHRoYXQgR251cyB3YXMgb3BlcmF0aW5nIG11Y2ggZmFzdGVyLiBJZiBbW2lkOjU3 Y2IxMzk2LTIyNDYtNGQ5Ni05MTI1LTVlNmQ0ZDJkYWRhNF1baW4tcGxhY2UgU3VtbWFyeQpidWZm ZXIgdXBkYXRpbmddXSB3b3JrZWQsIHRoZW4gaGl0dGluZyAiZyIgbWlnaHQgYmUgYWJsZSB0byB1 cGRhdGUgYWxsCnRoZSBvcGVuIFN1bW1hcnkgYnVmZmVycyB3aXRob3V0IGNhdXNpbmcgdG9vIG11 Y2ggb2YgYSBkZWxheS4KQ3VzdG9taXphdGlvbiBvcHRpb24gdG8gc2F5IHdoaWNoL2hvdyBtYW55 IGdyb3VwcyBzaG91bGQgaGF2ZQpwZXJzaXN0ZW50IHN1bW1hcmllcy4KKiBBbWJpdGlvdXMgc3R1 ZmYKKiogVE9ETyBVc2UgRUlFSU8gY2xhc3NlcyBmb3IgZ3JvdXBzCldlIGNvdWxkIGdldCB+Z251 cy1kZWZpbmUtZ3JvdXAtcGFyYW1ldGVyfiBhbmQgdGhlIGN1c3RvbWl6YXRpb24gZWRpdAppbnRl cmZhY2UgZm9yIGZyZWUuICBTdWJjbGFzc2luZyBncm91cHMgY291bGQgYWxsb3cgcHJldHR5IGRp ZmZlcmVudApncm91cCBiZWhhdmlvciBmb3IgZGlmZmVyZW50IHNlcnZlcnMuIFdvdWxkIGRvIGF3 YXkgd2l0aCBkaXN0aW5jdGlvbgpiZXR3ZWVuICJncm91cCIgYW5kICJpbmZvIi4KKiogVE9ETyBV c2UgRUlFSU8gY2xhc3NlcyBmb3Igc2VydmVycyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDp1c2VyOgpDb3VsZCBkbyBhd2F5IHdpdGggYWxsIG9mIG5ub28uZWwuIFdvdWxkIGRvIGF3 YXkgd2l0aCB0aGUgInNlbGVjdAptZXRob2QiIHZzICJjb21tYW5kIG1ldGhvZCIgdnMgInNlcnZl ciIgdnMgImJhY2tlbmQiIGRpc3RpbmN0aW9uLCBhbmQKd2UgY291bGQgZHJvcCB2ZXJ5IG11Y2gg Y29kZSB1c2VkIGZvciBib3VuY2luZyBiYWNrIGFuZCBmb3J0aCBiZXR3ZWVuCnNlcnZlcnMgYW5k IG1ldGhvZHMuIFdvdWxkIGFsbG93IHVzIHRvIHVzZSBzbG90cyBhbmQgZ2VuZXJpYyBtZXRob2Rz Cmluc3RlYWQgb2YgfmRlZnZvb34gYW5kIH5kZWZmb29+LgoKQWdlbnQgYW5kIGNhY2hpbmcgY291 bGQgYmUgOmFyb3VuZCBtZXRob2RzLgoKbm5tYWlsIHdvdWxkIGJlY29tZSBhIGJhc2UgY2xhc3Mg aW5oZXJpdGVkIGJ5IG5ubWFpbGRpciwgbm5tbCwgZXRjLgoqKiogUmVzaHVmZmxpbmcgb2YgR251 cycgc3RhdGUgZmlsZXMKVGhpcyB3b3VsZCBhbGxvdyB1cyB0byByZXNodWZmbGUgR251cycgY29u ZmlndXJhdGlvbiBhbmQgZGF0YSBzdG9yYWdlLgpDdXJyZW50bHkgd2UndmUgZ290OgoKLSBnbnVz LmVsIDo6IEhvbGRzIH5nbnVzLXNlbGVjdC1tZXRob2R+IGFuZAogICAgIH5nbnVzLXNlY29uZGFy eS1zZWxlY3QtbWV0aG9kc34sIGFzIHdlbGwgYXMgYWxsIGdudXMtcmVsYXRlZAogICAgIHZhcmlh YmxlL2N1c3RvbWl6YXRpb24gc2V0dGluZ3MuCi0gbmV3c3JjLmVsZCA6OiBIb2xkcyBtYXJrcywg YXMgd2VsbCBhcyBhbGwgc3RhdGUgc2V0IGJ5IHRoZSB1c2VyLAogICAgIHN1Y2ggYXMgdG9waWMg dG9wb2xvZ3ksIGdyb3VwIHNvcnRpbmcsIGdyb3VwIHNldHRpbmdzLCBldGMuCgpUaGlzIGNoYW5n ZSB3b3VsZCBhbGxvdyB0aHJlZSBkaWZmZXJlbnQgZmlsZXM6CgotIGdudXMuZWwgOjogT25seSBo b2xkcyB2YXJpYWJsZS9jdXN0b21pemF0aW9uIHNldHRpbmdzLCBjdXN0b20KICAgICBmdW5jdGlv bnMsIGV0Yy4KLSBnbnVzLXNlcnZlcnMuZWwgOjogSG9sZHMgYWxsIHNlcnZlciBkZWZpbml0aW9u cywgZ3JvdXAgcGFyYW1ldGVyCiAgICAgY3VzdG9taXphdGlvbnMsIGFuZCBhbGwgdXNlci1lZGl0 YWJsZSBzdGF0ZSBzZXQgdGhyb3VnaCBHbnVzJwogICAgIGludGVyZmFjZXMgKHN1Y2ggYXMgdG9w aWMgdG9wb2xvZ3kpLgotIGdudXMtbWFya3MuZWwgOjogVGhpcyB3b3VsZCBjb250YWluIG5vdGhp bmcgYnV0IGdyb3VwLXRvLW1hcmtzCiAgICAgY29ycmVzcG9uZGVuY2VzLiBEaWZmZXJlbnQgc2Vy dmVyIG9yIGdyb3VwIGNsYXNzZXMgY291bGQgc3RvcmUKICAgICB0aGVpciBtYXJrcyBkaWZmZXJl bnRseTogaWUsIG9uIGEgcmVtb3RlIHNlcnZlciwgb3IgaW4gYQogICAgIGRhdGFiYXNlLiBCdXQg YnkgZGVmYXVsdCwgdGhleSdkIGFsbCBiZSBzdHVjayBpbiB0aGlzIGZpbGUuCgpJbXBsaWNhdGlv bnM6CgoxLiBFdmVyeXRoaW5nIGluIGdudXMuZWwgaXMgdGhlb3JldGljYWxseSBlZGl0YWJsZSB2 aWEgdGhlCiAgIGN1c3RvbWl6YXRpb24gaW50ZXJmYWNlLCBwbHVzIGN1c3RvbSBmdW5jdGlvbnMu CjIuIEV2ZXJ5dGhpbmcgaW4gZ251cy1zZXJ2ZXJzLmVsIGlzIG1lYW50IHRvIGJlIGVkaXRlZCB0 aHJvdWdoIEdudXMnCiAgIG93biBpbnRlcmZhY2VzLiBUbyBkZWZpbmUgc2VydmVycywgeW91IGdv IHRvIHRoZSBTZXJ2ZXIgYnVmZmVyIGFuZAogICBydW4gaW5zZXJ0L2RlbGV0ZS9lZGl0IGNvbW1h bmRzIHRoZXJlLiBJdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBlZGl0CiAgIHRoZSBmaWxlIGJ5IGhh bmQsIGJ1dCBpdCdzIC9tZWFudC8gdG8gYmUgZWRpdGVkIHdpdGhpbiBHbnVzLgozLiBnbnVzLW1h cmtzLmVsIHNob3VsZCBvbmx5IGJlIGVkaXRlZCBieSBHbnVzLiBJZiB5b3Ugd2FudCB0bwogICBz aGFyZS9wcm9wYWdhdGUgbWFya3MgYmV0d2VlbiBtYWNoaW5lcywgR251cyB3aWxsIHByb3ZpZGUg c2VwYXJhdGUKICAgbWVjaGFuaXNtcyBmb3IgZG9pbmcgdGhhdC4KNC4gRmlsZXMgb25lIGFuZCB0 d28gY2FuIG5vdyBiZSBzYWZlbHkga2VwdCB3aXRoaW4gdmVyc2lvbiBjb250cm9sLgogICBUaGV5 IHJlcHJlc2VudCBvcHRpb25zIGFuZCBzdGF0ZSB0aGF0IGhhdmUgYmVlbiBleHBsaWNpdGx5IHNl dCBieQogICB0aGUgdXNlciwgYW5kIHdoaWNoIGNhbiByZWFzb25hYmx5IGJlIGV4cGVjdGVkIG5v dCB0byBjaGFuZ2Ugb24gYQogICBkYXktdG8tZGF5IGJhc2lzLgoqKiBUT0RPIFJlbW92ZSB+Z251 cy1zZWNvbmRhcnktc2VsZWN0LW1ldGhvZHN+ICAgICAgICAgICAgICAgICAgICAgICAgOnVzZXI6 Ckluc3RlYWQganVzdCBoYXZlIGEgc2luZ2xlIH5nbnVzLXNlbGVjdC1tZXRob2RzfiBvcHRpb24u IFNvbWUgcGVvcGxlCndpbGwgbG92ZSB0aGlzIGlkZWEsIHNvbWUgd2lsbCBoYXRlIGl0LgoqKiBU T0RPIFJldGhpbmsgfm5udHAtc2VydmVyLWJ1ZmZlcn4gYmVoYXZpb3IgLS0gdGhyZWFkaW5nPwo6 UFJPUEVSVElFUzoKOklEOiAgICAgICBiYTZkNzNkYy1jNWYxLTQ4ZDAtYjNlMy1hZWVjMGU3MzE1 MDMKOkVORDoKfm5uaGVhZGVyLWluaXQtc2VydmVyLWJ1ZmZlcn4gY3JlYXRlcyBhIGJ1ZmZlciBu YW1lZCB+PCAqbm50cGQqPn4sCndoZXJlIGFsbCBzZXJ2ZXJzIHdyaXRlIHRoZWlyIHJlc3BvbnNl cyAtLSBzbyBmYXIgc28gZ29vZC4gVGhlIGJ1ZmZlcgpkb2VzIG5vdCBhY3R1YWxseSBoYXZlIGEg cHJvY2VzcyBhc3NvY2lhdGVkIHdpdGggaXQuIFNlcnZlcnMgd2l0aApsb25nLXJ1bm5pbmcgcHJv Y2Vzc2VzLCBsaWtlIG5udHAgYW5kIGltYXAsIG1haW50YWluIHByb2Nlc3MtYnVmZmVyCmxpc3Rz IGluIHZhcmlhYmxlcyBsaWtlIH5ubnRwLWNvbm5lY3Rpb24tYWxpc3R+IGFuZAp+bm5pbWFwLWNv bm5lY3Rpb24tYWxpc3R+LiBIb3dldmVyLCB0aGVzZSB2YXJpYWJsZXMgb25seSBldmVyIGhvbGQg YQpzaW5nbGUgZWxlbWVudCAoZXZlbiB3aGVuIHRoZXJlIGFyZSBtdWx0aXBsZSBJTUFQIHNlcnZl cnMgY29uZmlndXJlZCwKZm9yIGV4YW1wbGUpLCBhbmQgdGhlIGVsZW1lbnQgaXMgc3dhcHBlZCBv dXQgYXMgZGlmZmVyZW50IHNlcnZlcnMgYXJlCm9wZW5lZC4gVGhlIGVsZW1lbnQgaXMgYSBsaXN0 IG9mIHRoZSB+bm50cC1zZXJ2ZXItYnVmZmVyfiwgYW5kIHRoZQpzZXJ2ZXIncyBwcm9jZXNzIGJ1 ZmZlci4gSG93IGlzIHRoZSBlbGVtZW50IHN3YXBwZWQgb3V0PyBXaHk/IFdoYXQncwp0aGUgcG9p bnQgb2YgZG9pbmcgfihjYWRyIChhc3NvYyBubnRwLXNlcnZlci1idWZmZXIKbm5pbWFwLWNvbm5l Y3Rpb24tYWxpc3QpKX4gdG8gZ2V0IHRoZSBpbWFwIHNlcnZlciBidWZmZXI/IFdoeSBhcmUgYWxs CnRoZSBwcm9jZXNzIGJ1ZmZlcnMgdGhlbiBrZXB0IGluIH5ubmltYXAtcHJvY2Vzcy1idWZmZXJz fj8KCklmIGVhY2ggc2VydmVyIHdyb3RlIHRvIGl0cyBvd24gb3V0cHV0IGJ1ZmZlciAoYW5kIHNl cnZlcnMgd2l0aApsb25nLXJ1bm5pbmcgcHJvY2Vzc2VzIGNvdWxkIGF0dGFjaCB0aGVpciBwcm9j ZXNzIHRvIHRoaXMgYnVmZmVyKSwgd2UKY291bGQgc2VwYXJhdGUgY29uY2VybnMgY29tcGxldGVs eS4gRWFjaCBzZXJ2ZXIgd291bGQgcmVhZCBpdHMgb3V0cHV0CmluZGVwZW5kZW50bHksIGFuZCB3 ZSBjb3VsZCB1c2UgdGhyZWFkaW5nIGZvciBwcm9jZXNzIGNvbmN1cnJlbmN5LAppbnN0ZWFkIG9m IHRoZSBwcmVzZW50IH5yZXRyaWV2ZS1ncm91cC1kYXRhLWVhcmx5fiBzeXN0ZW0uCioqIFRPRE8g SW5jb3Jwb3JhdGUgc29tZXRoaW5nIGxpa2UgImdudXMtcGVycyIgYnkgZGVmYXVsdCAgICAgICAg ICAgICA6dXNlcjoKVGhlIHNlcGFyYXRpb24gb2YgcmVhZGluZyBhbmQgc2VuZGluZyBpcyBjb3Jy ZWN0LCBhbmQgYWRtaXJhYmxlLCBidXQKc29tZXRpbWVzIGluY29udmVuaWVudC4gQXQgdGhlIHZl cnkgbGVhc3QsIGlmIGEgImZyb20iIGFkZHJlc3MgY291bGQKYmUgYXNzb2NpYXRlZCB3aXRoIGEg c2VydmVyLCB0aGF0IHdvdWxkIGdpdmUgdXMgYSBsb3Qgb2YgbGVld2F5LgoqKiBUT0RPIEFsbG93 IGJhY2tlbmRzIHRvIGhhbmRsZSBkcmFmdHMgYW5kIGFyY2hpdmVzICAgICAgICAgICAgICAgICAg OnVzZXI6ClRoZSBpZGVhIGlzIHRoYXQgbWFpbC1saWtlIGJhY2tlbmRzIHNob3VsZCBiZSBnaXZl biBhIHNob3QgdG8gaGFuZGxlCmRyYWZ0IHNhdmluZyBhbmQgbWVzc2FnZSBhcmNoaXZpbmcuIElt YXAgc2VydmVycywgZm9yIGluc3RhbmNlLCBjb3VsZAphZHZlcnRpc2UgdGhlbXNlbHZlcyBoYXMg YmVpbmcgYWJsZSB0byBkbyB0aGlzLiBDcmVhdGUgbmV3IGZ1bmN0aW9ucwp+cmVxdWVzdC1zYXZl LWRyYWZ0fiBhbmQgfnJlcXVlc3QtYXJjaGl2ZS1tZXNzYWdlfiwgYW5kIG9ubHkgaWYgdGhlCnNl cnZlciBpbiBxdWVzdGlvbiBkb2Vzbid0IGhhdmUgdGhvc2UgZnVuY3Rpb25zIChvciB3ZSdyZSB1 bnBsdWdnZWQpCmRvZXMgdGhlIGFnZW50IGhhbmRsZSBpdCBsb2NhbGx5LiBUaGlzIHdvdWxkIGJl IG11Y2ggZWFzaWVyIHRvCmltcGxlbWVudCBpZiB3ZSdyZSB1c2luZyBwcm9wZXIgZ2VuZXJpYyBm dW5jdGlvbnMuCioqIFRPRE8gQXN5bmNocm9ub3VzIG1lc3NhZ2Ugc2VuZGluZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA6dXNlcjoKQW5vdGhlciBiaWcgZW5jaGlsYWRhLiBJdCB3 b3VsZCByZXF1aXJlIHRoZSBhYmlsaXR5IHRvIHVwZGF0ZSBtYXJrcwphbmQgbWFrZSBzZXJ2ZXIg cmVxdWVzdHMgb3V0IG9mIGJhbmQsIHdoaWNoIHdvdWxkbid0IGJlIHBvc3NpYmxlIHVudGlsCndl IHdlcmUgdXNpbmcgb2JqZWN0cyBhbmQgaGFkIGRvbmUgYXdheSB3aXRoIG5ub28ncyBjb25jZXB0 IG9mIHRoZQoiY3VycmVudCBzZXJ2ZXIiLiBCZXlvbmQgdGhhdCwgaXQgd291bGQgcmVxdWlyZSB2 ZXJ5IGNhcmVmdWwgZXJyb3IKaGFuZGxpbmcsIG9idmlvdXNseS4K --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 01 16:18:27 2019 Received: (at 33653) by debbugs.gnu.org; 1 Apr 2019 20:18:27 +0000 Received: from localhost ([127.0.0.1]:39938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB3Nz-0002qE-AW for submit@debbugs.gnu.org; Mon, 01 Apr 2019 16:18:27 -0400 Received: from virgil.koldfront.dk ([2.110.51.43]:42736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB3Nv-0002pz-Hq for 33653@debbugs.gnu.org; Mon, 01 Apr 2019 16:18:25 -0400 Received: from tullinup.koldfront.dk (tullinup.koldfront.dk [192.168.1.216]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by virgil.koldfront.dk (Postfix) with ESMTPS id 30ACC801C1A64; Mon, 1 Apr 2019 22:18:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 virgil.koldfront.dk 30ACC801C1A64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koldfront.dk; s=mail; t=1554149896; bh=dBwUQVs3VtOXeh5S3z8zEO4SoNotB+r776yaKcpAs+0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lnluzUH/LfPP+1lO8mQ812nudxhNZZP3P0fK3867UT+QCixJ4UanYeosYMMkfF9YE xCQ0GdAzaOpDRPs2vZHpLDudvnsiBABZxEpfeAOmUuR5DsCo+mmrgkR+fmM/D3MIG5 719FlGLD6ESHRwaTFp60BiVjoU8FYZ5mLbfWxrg1xPQ9q1I78zfNwnUZq8T6BFnrdK p3ND7mZisLR2SZRBOWj6+ZlRyDssK6mNbWdUNhusJ0DEqtR4MHBx0oI1H4EbpwQ679 3nS68/Pwq39+yIn5q/zyGHVfvllupDZA044nnLiS6qOhHxVyxyC7oqrXGqfKurx0AC kSLEkb5hS4Y1w== Received: by tullinup.koldfront.dk (Postfix, from userid 1000) id 1A79F101ED2B5; Mon, 1 Apr 2019 22:18:16 +0200 (CEST) From: =?utf-8?Q?Adam_Sj=C3=B8gren?= To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Organization: koldfront - analysis & revolution, Copenhagen, Denmark References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> OpenPGP: id=476630590A231909B0A0961A49D0746121BDE416; url=https://asjo.koldfront.dk/gpg.asc X-Now-Playing: Avatar, The Seer (cd 2) (Swans) X-Hashcash: 1:21:190401:bzg@gnu.org::iMZ/HBO0NLJCq6Aw:0000001cvw X-Hashcash: 1:21:190401:33653@debbugs.gnu.org::8my22hQuYCHQAR9n:000000000000000000000000000000000000000034qV X-Hashcash: 1:21:190401:eric@ericabrahamsen.net::wxU31OyfjRmiO+Xc:000000000000000000000000000000000000003L00 X-Hashcash: 1:21:190401:yamaoka@jpl.org::9Kw5wCEblplE15da:0072y2 X-Face: )qY&CseJ?.:=8F#^~GcSA?F=9eu'{KAFfL1C3/A&:nE?PW\i65"ba0NS)97, Q(^@xk}n4Ou rPuR#V8I(J_@~H($[ym:`K_+]*kjvW>xH5jbgLBVFGXY:(#4P>zVBklLbdL&XxL\M)%T}3S/IS9lMJ ^St'=VZBR (Eric Abrahamsen's message of "Sun, 31 Mar 2019 15:55:15 -0700") Message-ID: <874l7hh43b.fsf@tullinup.koldfront.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Katsumi Yamaoka , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric writes: > Okay, it might be as simple as the attached patch, applied to current > master. Basically this forces nnmail to always write the group names as > strings, which are then read correctly later on. > > Also cc'ing Bastien and Adam, who have been very helpful with > road-testing. I'm running with this patch now. I started by taking a copy of my .newsrc.eld, so I could return to it. I swear the first time I started Gnus from master with the patch, my groups with =C3=A6=C3=B8=C3=A5 showed up as previously. But then I stopped = Emacs and copied the .newsrc.eld back, and somehow they did not show up again. It makes no sense to me, unless there is state somewhere besides .newsrc.eld that I don't know of. Since then Gnus from Emacs master with the patch has behaved as expected. Slighly confused, but happy that it works, Adam --=20 "Everything needs to change. Adam Sj=C3=B8= gren And it has to start today." asjo@koldfront.dk From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 01 16:57:28 2019 Received: (at 33653) by debbugs.gnu.org; 1 Apr 2019 20:57:29 +0000 Received: from localhost ([127.0.0.1]:39980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB3zk-0003pe-Ms for submit@debbugs.gnu.org; Mon, 01 Apr 2019 16:57:28 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:57810 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB3zj-0003pR-4U for 33653@debbugs.gnu.org; Mon, 01 Apr 2019 16:57:27 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 84E88FA025; Mon, 1 Apr 2019 20:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554152241; bh=FIpDWz6tP1P51J8ROqZviiwzdE5qqCqJuWwpFT3aSxI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=zNfZdUJXe610uFQ9Eg4SoZHcodSxE0IhlX6Zx/qOjiispZmhn6f/+WKMnCapyxuiV w84ykGKVrEuUiE887zP6F0AOgev2l8ZcJrYHA8Pm04hVmYEsIUuUYt7hQ4ANrPw6em WSI+YR+CXBQJnsWb87Gfdk+fgSQr4IOsG91j7OH8= From: Eric Abrahamsen To: Adam =?utf-8?Q?Sj=C3=B8gren?= Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> Date: Mon, 01 Apr 2019 13:57:20 -0700 In-Reply-To: <874l7hh43b.fsf@tullinup.koldfront.dk> ("Adam =?utf-8?Q?Sj?= =?utf-8?Q?=C3=B8gren=22's?= message of "Mon, 01 Apr 2019 22:18:16 +0200") Message-ID: <87tvfh30lr.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Katsumi Yamaoka , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Adam Sj=C3=B8gren writes: > Eric writes: > >> Okay, it might be as simple as the attached patch, applied to current >> master. Basically this forces nnmail to always write the group names as >> strings, which are then read correctly later on. >> >> Also cc'ing Bastien and Adam, who have been very helpful with >> road-testing. > > I'm running with this patch now. > > I started by taking a copy of my .newsrc.eld, so I could return to it. > > I swear the first time I started Gnus from master with the patch, my > groups with =C3=A6=C3=B8=C3=A5 showed up as previously. But then I stoppe= d Emacs and > copied the .newsrc.eld back, and somehow they did not show up again. > > It makes no sense to me, unless there is state somewhere besides > .newsrc.eld that I don't know of. > > Since then Gnus from Emacs master with the patch has behaved as > expected. > > > Slighly confused, but happy that it works, Thank you for testing. This whole process has made me suspect my sanity (or the interference of cosmic rays), so I'm kind of glad you're confused, too :) I am even now able to reproduce bugs *once* (for instance the "j" bug Lars reported yesterday) in my testing setup (the gnus-mock package), but not again thereafter. If I restart gnus-mock, I can reproduce it once again, but only once. I think once I eventually figure out why, the problem will be solved! From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 01 18:39:32 2019 Received: (at 33653) by debbugs.gnu.org; 1 Apr 2019 22:39:32 +0000 Received: from localhost ([127.0.0.1]:40028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB5aW-0006L9-JR for submit@debbugs.gnu.org; Mon, 01 Apr 2019 18:39:32 -0400 Received: from mout.gmx.net ([212.227.15.15]:39327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hB5aU-0006Kt-Vl for 33653@debbugs.gnu.org; Mon, 01 Apr 2019 18:39:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1554158356; bh=qa2lv5EM3DOjea3wf9kXUgsv97/YOYPGg+OcS+Jiw5k=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=axXqOdtq/TwPJdrxWsQok6iOD8f5pKnABy/z8N3s9RvN5mJJ7nwOszjs98oCpvcYG R8ARiDa00/Q0irqsEZg2htwjlvbQ0YnpeqJIp4liT0RHaaOcXPpvHpA0Q+9M0sV0XT hJAGd5INNugdh8WLTiltdl/gjiGZXQ35d8SqHa00= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from dellcorei5dias ([37.153.145.167]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LcT2M-1gTXda21qQ-00jtTj; Tue, 02 Apr 2019 00:39:16 +0200 From: Deus Max To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <87y3536h47.fsf@bzg.fr> <871s2vlu2z.fsf@ericabrahamsen.net> <877ecg8sye.fsf@aia00054aia.gr> <871s2m39ql.fsf@ericabrahamsen.net> Date: Tue, 02 Apr 2019 01:39:12 +0300 In-Reply-To: <871s2m39ql.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 31 Mar 2019 16:27:46 -0700") Message-ID: <87h8bh5p0v.fsf@aia00054aia.gr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:zcAI1Aruwcq3vYUlhAKG61uAcjG9FeBVFcI9+ZWARlTYQGsY9SM //oF9AKxh4xC+bs3C7ykVIz02IMyvydWz3ieCm4vYUMM4xfN2UuwFHCO3nmGCKswDNy2WLT 4lu59tABqK5SLIuAv8IO6vB7MU++3GwDhNwx9SQk/kfwOpNDcvJd4Fo1axNG+gdoC32QNRG DUKGPnisZY5bZ+t8uyx8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:sgOP/vchtTk=:aGr1vlkAJU2Qz6ao189vAw B2sodgJk0Rv2Rk/OaxCDVbEeiMESIq2ewS+sxhL9oimpsARCn9gvLeQnj1JBhod+NVQN0buK2 CLcUFVE9nNFjjdLRvKdcXKYhMis3sECzMUIEO7Jojxz+FznnzpgDw890IIRlciNgwpuRl6+k9 nfDKngMlnbrrmzj0L2VhPJoJ/9WQjDvh67xlI5+5LW+TXePL24xJRNPM65SMShHW4lDkbFVQM udqAs1hQgSItKpY4pAzu1slr3jYglOz5sySzpxQb1q3ZA4Fr2sDUQnyU6UTYaQo2e0eofrROR jJ03d/W/nKA/kymUlbfD7h/svuQlL/1BtsFIYFPEKBV4eJDUJBdOJsymsJPUr9nYiGMtMT/Ud aYqePCOi75y0OtoR+8OUdT+gD1LyZs3qxLh3GJg2f9rAWOEGSjhPCn+WzObz3B9XSe2Q39V4t 2xK0GC3kGYyuOpWANdYZ+EI+/SdL4gSG7hxqedWZZAoFK0/K6L1ndtfp7HLmBbdwH8w9d7ko9 m3bNXMlAYPpTm1Ek/PPjjeBhf5IeLYtrVmx2dtndjwcBmXXEwo8wv5pAg7WYDDmAnrDVF3wMI P2yFdH5EeD8bn3+fQPhLyRso6Ynxcl4jIz0DJ6XR1uOV14OQvdOutIhisxhHx/pHyGZU1VO95 xdKdy64tm3op8V1zFtFxf/bARBBC+x4RzgsWteQHL9Czw/SdV+66pAHbzuOQjgNJNmfUURpgP icrriEBoeCXihPbkdiaSa1JFXiRFdtV8UD+8S6LpkeTaksYuq9pbKXPcK/b++LPKB7mjSLfWr JLCd3+O6/cqQ6LFDBZ3wmFk5dQhjGiNn8Q8es48QICVbZArFlUeRQnUTTANHkT3AARoL32xvO KD2dechDgaqR3zSbBhtzGJ7753e6NXZjCi8wCaB+SXALwDjPedNwk30QD9Bg/8zcwqRnMhwXW ULUdnfnDhaQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Mar 31 2019, Eric Abrahamsen wrote: > On 03/30/19 14:09 PM, Deus Max wrote: >> Hi Eric, >> >> It seems you are implementing some pretty drastic upgrades to Gnus. >> >> Is there a write-up on the planned changes, benefits, what is going to be >> affected and what to expect ? >> >> I'm interested and would like to read it. > > There is a writeup! Sort of -- I called it a roadmap. Originally I stuck > it in a branch called scratch/gnus-roadmap but soon realized it didn't > make any sense to keep track of something like this in a git branch. > I've attached the current version. > > Obviously, this is _not_ meant as a list of "changes I will unilaterally > implement in Gnus", but as a document for record-keeping and discussion. > I didn't get much discussion, but I know that's to be expected! > > Eric Hi Eric, A roadmap, yes! that's the word I was looking for. Thank you, very interesting. I always wondered why there are multiple select method variables (as ~gnus-secondary-select-methods~), instead of one ~gnus-select-methods~. I see there are plenty of things to simplify, such as group reading/selection. Also i think, jumping to an article should be easier and more stable. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 01:23:31 2019 Received: (at 33653) by debbugs.gnu.org; 2 Apr 2019 05:23:31 +0000 Received: from localhost ([127.0.0.1]:40252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBBtT-0002nk-13 for submit@debbugs.gnu.org; Tue, 02 Apr 2019 01:23:31 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:58250 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBBtO-0002n5-77 for 33653@debbugs.gnu.org; Tue, 02 Apr 2019 01:23:27 -0400 Received: from localhost (97-126-66-162.tukw.qwest.net [97.126.66.162]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 3A21FFA17C; Tue, 2 Apr 2019 05:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554182600; bh=bxsRSUSlqwiwbXqywOCQpWskzLMppgN9PlJp9XbNW6Q=; h=From:To:Cc:Subject:References:Date:From; b=T2xXAjnUSeuaiBVtXlIJGeiHt2ZCxI6BYxDGl1qUC2kZ+7G4HRJaGvbTfeCp4vQzk xqC8yWqN86q9oUOLWpzqAVNoA/aYVY8p/eslANWHr1Xuk1SRuHH8V8/JkCqOucRS0Z v8uBBInzajpPCaVso/Kn62N+EqhiEG9mUVsXa7RY= From: Eric Abrahamsen To: Deus Max Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <87y3536h47.fsf@bzg.fr> <871s2vlu2z.fsf@ericabrahamsen.net> <877ecg8sye.fsf@aia00054aia.gr> <871s2m39ql.fsf@ericabrahamsen.net> <87h8bh5p0v.fsf@aia00054aia.gr> Date: Mon, 01 Apr 2019 22:23:18 -0700 Message-ID: <87r2alq8u1.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 04/02/19 01:39 AM, Deus Max wrote: > On Sun, Mar 31 2019, Eric Abrahamsen wrote: > >> On 03/30/19 14:09 PM, Deus Max wrote: >>> Hi Eric, >>> >>> It seems you are implementing some pretty drastic upgrades to Gnus. >>> >>> Is there a write-up on the planned changes, benefits, what is going to be >>> affected and what to expect ? >>> >>> I'm interested and would like to read it. >> >> There is a writeup! Sort of -- I called it a roadmap. Originally I stuck >> it in a branch called scratch/gnus-roadmap but soon realized it didn't >> make any sense to keep track of something like this in a git branch. >> I've attached the current version. >> >> Obviously, this is _not_ meant as a list of "changes I will unilaterally >> implement in Gnus", but as a document for record-keeping and discussion. >> I didn't get much discussion, but I know that's to be expected! >> >> Eric > > Hi Eric, > > A roadmap, yes! that's the word I was looking for. > > Thank you, very interesting. > I always wondered why there are multiple select method variables (as > ~gnus-secondary-select-methods~), instead of one ~gnus-select-methods~. One thing that makes sense is distinguishing between servers you've defined in your gnus.el file, versus servers you've added via the *Server* buffer in Gnus. As things are set up currently, those do need to be held in different variables. Perhaps that might change in the future, but this much makes sense. What makes less sense to me is the distinction between the primary select method and the secondary select methods. So far as I can tell, the only practical difference between the two is that groups on the primary select method don't have the method name prefixed to the group name. That's something that could be profitably simplified, I think (there's a ton of code that just checks whether the current method is primary or secondary). > I see there are plenty of things to simplify, such as group > reading/selection. Also i think, jumping to an article should be easier > and more stable. Noted! Please do let me know if you have any more ideas or responses to that document. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 12:43:46 2019 Received: (at 33653) by debbugs.gnu.org; 2 Apr 2019 16:43:46 +0000 Received: from localhost ([127.0.0.1]:41497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBMVl-0005R1-MA for submit@debbugs.gnu.org; Tue, 02 Apr 2019 12:43:46 -0400 Received: from virgil.koldfront.dk ([2.110.51.43]:36970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBMVj-0005Qn-5A for 33653@debbugs.gnu.org; Tue, 02 Apr 2019 12:43:44 -0400 Received: from tullinup.koldfront.dk (tullinup.koldfront.dk [192.168.1.216]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by virgil.koldfront.dk (Postfix) with ESMTPS id 85175801E3E4E; Tue, 2 Apr 2019 18:43:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 virgil.koldfront.dk 85175801E3E4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koldfront.dk; s=mail; t=1554223416; bh=Nkyp7c4VjH/S+DJoRr4brUTujOdqzSsxqZHwvUp8KoQ=; h=From:To:Cc:Subject:References:Date:From; b=dle0lTHFtQ4EPQYamjO8gLkHQI8osot05sBmInZ/iWvuzsKwU8rgOYJmlOsFSzlEu Reg39cqUdM0rfkFl9MLnakI/g1ixckgNm1K3Y83L77KthM+xN/IEf+h9D54Qql645F FuEjh1JxKPNZjzT+IBknd/sISbGFu3SK/S6lW+zZ77jSRBz5YzzpgtYVGa52wai8cb +LAGcG+SxDQBL5/7SJF65VjqasZCtT5+rzCiBbZEQZn+41dzIN6i8oeV3Njgvnbnw9 R2I17kjiGtYoac6pZMNltEXzOsSWgUfzMZuHp4+U3ZMWwBiTN28iXLbxT+xcX119WU /LYxRJev2pFHA== Received: by tullinup.koldfront.dk (Postfix, from userid 1000) id 62198101EA321; Tue, 2 Apr 2019 18:43:36 +0200 (CEST) From: =?utf-8?Q?Adam_Sj=C3=B8gren?= To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Organization: koldfront - analysis & revolution, Copenhagen, Denmark References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> OpenPGP: id=476630590A231909B0A0961A49D0746121BDE416; url=https://asjo.koldfront.dk/gpg.asc X-Now-Playing: =?utf-8?B?U8Olw6UgbsOkcmEsIEzDpXRlcg==?= som miljarder (bob hund) X-Hashcash: 1:21:190402:yamaoka@jpl.org::AxYnwUqCv93hGJVi:0004HN X-Hashcash: 1:21:190402:bzg@gnu.org::htv7nT8Y70xrWOm+:0000001L+4 X-Hashcash: 1:21:190402:eric@ericabrahamsen.net::bfJnahstKTv4/mU8:000000000000000000000000000000000000002/JT X-Hashcash: 1:21:190402:33653@debbugs.gnu.org::wQ0EEjtXMubyrjbK:0000000000000000000000000000000000000000D6AH X-Face: )qY&CseJ?.:=8F#^~GcSA?F=9eu'{KAFfL1C3/A&:nE?PW\i65"ba0NS)97, Q(^@xk}n4Ou rPuR#V8I(J_@~H($[ym:`K_+]*kjvW>xH5jbgLBVFGXY:(#4P>zVBklLbdL&XxL\M)%T}3S/IS9lMJ ^St'=VZBR User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Katsumi Yamaoka , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric writes: > Thank you for testing. This whole process has made me suspect my sanity > (or the interference of cosmic rays), so I'm kind of glad you're > confused, too :) ;-) > I am even now able to reproduce bugs *once* (for instance the "j" bug > Lars reported yesterday) in my testing setup (the gnus-mock package), > but not again thereafter. If I restart gnus-mock, I can reproduce it > once again, but only once. I was a little too quick to declare victory. While I don't see any duplicates, nor any problems with the nnml-groups, I still see the nntp-groups with =C3=B8 and =C3=A5 in the name show up with a * in front. If I enter the group, exit it again, the * changes to 0, and if I then fetch new news, it doesn't show up. Until I start Gnus the next time. Then it's back with *. > I think once I eventually figure out why, the problem will be solved! I think that is very likely! Best regards, Adam --=20 "Everything needs to change. Adam Sj=C3=B8= gren And it has to start today." asjo@koldfront.dk From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 18:16:22 2019 Received: (at 33653) by debbugs.gnu.org; 3 Apr 2019 22:16:22 +0000 Received: from localhost ([127.0.0.1]:43369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoBB-00054D-Vs for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:16:22 -0400 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:16506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoB9-000544-CE for 33653@debbugs.gnu.org; Wed, 03 Apr 2019 18:16:20 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5E7A46A1FC8; Wed, 3 Apr 2019 22:16:13 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-4-94.trex.outbound.svc.cluster.local [100.96.4.94]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 3A43B6A1E68; Wed, 3 Apr 2019 22:16:12 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 03 Apr 2019 22:16:13 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Unite-Drop: 2c5a8f757e3f576a_1554329773196_1113724756 X-MC-Loop-Signature: 1554329773196:4233515609 X-MC-Ingress-Time: 1554329773196 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hBoAt-0005yM-9u; Wed, 03 Apr 2019 17:16:04 -0500 Date: Thu, 04 Apr 2019 07:16:01 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (x86_64-unknown-cygwin) Cancel-Lock: sha1:06UaT1sWGls/ws+R2FFjUy811jk= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) One more regression. Performing `B ' or `B m' in the "nnml:inbox" group, i.e., that of an ASCII name, does not update the NOV database; in the summary buffer the face for deleted or moved article lines get changed so as to be absent at that time, however they revive when re-entering to the group's summary. `nnml-generate-nov-databases-directory' helps (marks survives). I'd like to have time to fix it and others from the next week, hopefully. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 18:37:10 2019 Received: (at 33653) by debbugs.gnu.org; 3 Apr 2019 22:37:10 +0000 Received: from localhost ([127.0.0.1]:43399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoVK-0005bE-7g for submit@debbugs.gnu.org; Wed, 03 Apr 2019 18:37:10 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:33826 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBoVH-0005b0-Fl for 33653@debbugs.gnu.org; Wed, 03 Apr 2019 18:37:08 -0400 Received: from localhost (75-151-119-142-Washington.hfc.comcastbusiness.net [75.151.119.142]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B6E20FA594; Wed, 3 Apr 2019 22:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554331022; bh=vtdDbKefpTiFKB3ou+8kcE2v9e6CDuur+sOOg1NWYzk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KJDq64UmJJoCD2WD0iCL3O5+R/0eoOoiXl1xyJjM/YZyojcdFoyU8B6W3xyznc4BD OT4CuFuPVm5u3rsGz2zq7tbC8pmNMHKVQNULJK/6F2WUu1OD8GUG5CSXoB0bSjy7be 6i4SQp/pQvRGJsPWlUcBMIr305l2JPZum68txo/I= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> Date: Wed, 03 Apr 2019 15:36:58 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Thu, 04 Apr 2019 07:16:01 +0900") Message-ID: <875zruu35h.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > One more regression. > > Performing `B ' or `B m' in the "nnml:inbox" group, i.e., > that of an ASCII name, does not update the NOV database; in the > summary buffer the face for deleted or moved article lines get > changed so as to be absent at that time, however they revive > when re-entering to the group's summary. > `nnml-generate-nov-databases-directory' helps (marks survives). > > I'd like to have time to fix it and others from the next week, > hopefully. Thanks for your continued reports! Was this with the most recent WIP commit I posted a day or so ago, or with origin/master? I'm working on this right now, and hope to have an interim fix today. If you do think you'll have a bit of time to put into this, what would be _really_ awesome is if you'd help me check over the next step, which will be keeping group names decoded everywhere inside Gnus. That ought to simplify this whole process, and avoid similar types of bugs in the future. That was the original point of this whole patch series; I think my mistake was breaking the series up at the wrong point. Anyway, I will solve as much as I can in the next week. It would be really great to have experienced eyes check my work, though. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 00:25:43 2019 Received: (at 33653) by debbugs.gnu.org; 5 Apr 2019 04:25:43 +0000 Received: from localhost ([127.0.0.1]:44956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCGQB-00014q-HQ for submit@debbugs.gnu.org; Fri, 05 Apr 2019 00:25:43 -0400 Received: from otter.birch.relay.mailchannels.net ([23.83.209.139]:10324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCGQ9-00014h-88 for 33653@debbugs.gnu.org; Fri, 05 Apr 2019 00:25:42 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E30DD123A06; Fri, 5 Apr 2019 04:25:37 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.20.50]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 3108C1207A1; Fri, 5 Apr 2019 04:25:37 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Fri, 05 Apr 2019 04:25:37 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Well-Made-Glossy: 2a530c0e2b9b2591_1554438337698_12678529 X-MC-Loop-Signature: 1554438337697:1299763481 X-MC-Ingress-Time: 1554438337697 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hCGQ1-007M2b-3F; Thu, 04 Apr 2019 23:25:34 -0500 Date: Fri, 05 Apr 2019 13:25:32 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:YfpxJGAu8QbM0BcRgD218gZUP1s= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 03 Apr 2019 15:36:58 -0700, Eric Abrahamsen wrote: > Thanks for your continued reports! Was this with the most recent WIP > commit I posted a day or so ago, or with origin/master? I'm working on > this right now, and hope to have an interim fix today. It's origin/master, I've been installing it almost everyday of weekday. ;) I found a cause of the `move article' not to work and pushed a fix to master. That is having changed `while loop' to `dolist' in `gnus-summary-move-article'. Because of this, the 5th arg `last' passed to `gnus-request-move-article' gets always nil, and that function never saves NOV and also ACTIVE at least for an nnml group. This is a good lesson to me; changing `while loop' to `dolist' should be done carefully. Regards, From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 02:44:55 2019 Received: (at 33653) by debbugs.gnu.org; 5 Apr 2019 06:44:55 +0000 Received: from localhost ([127.0.0.1]:44998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCIat-0006dw-BA for submit@debbugs.gnu.org; Fri, 05 Apr 2019 02:44:55 -0400 Received: from ladybird.maple.relay.mailchannels.net ([23.83.214.98]:54009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCIaq-0006dn-I3 for 33653@debbugs.gnu.org; Fri, 05 Apr 2019 02:44:53 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D03DB124975; Fri, 5 Apr 2019 06:44:50 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.11.48]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 01BF91249FC; Fri, 5 Apr 2019 06:44:49 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Fri, 05 Apr 2019 06:44:50 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Well-Made-Arch: 0cefe84f5926d22b_1554446690654_1203108587 X-MC-Loop-Signature: 1554446690654:2719959295 X-MC-Ingress-Time: 1554446690653 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hCIaj-007vAZ-5L; Fri, 05 Apr 2019 01:44:46 -0500 Date: Fri, 05 Apr 2019 15:44:44 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:AeNRXlyyu0WOHxUbUL1vkeScYBU= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) One more regression. :) In the group buffer the `j' command (`gnus-group-jump-to-group') does not work for a group that is not activated yet. The point goes to the top. Such a group will appear with the `*' mark by the `l' or the `L' command like the followig: *: nntp+gmane:gmane.emacs.devel Similarly the "#" mark put in front of a marked such group will not disappear after processing a certain job (normally `gnus-group-get-new-news-this-group' on me) as follows: # *: nntp+gmane:gmane.emacs.devel =E2=86=93=E2=86=93=E2=86=93 # 168: nntp+gmane:gmane.emacs.devel The cause is the same; such non-activated groups are not listed in `gnus-active-hashtb': (gethash "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb) =3D> nil But in Gnus bundled with Emacs 26.1.92 it returns a group name symbol, though its value (i.e., active) is nil: (gnus-intern-safe "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb) =3D> nntp+gmane:gmane\.emacs\.devel (symbol-value (gnus-intern-safe "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb)) =3D> nil In my Gnus, there are many non-activated groups at just after lauching Gnus with the prefix arg `1', because I set the group level `1' to the groups normally used and larger level to the others. In the starting time of work, my habit is to check mails in the active groups for a while and then activate and check groups of larger level. Running `gnus-group-get-new-news-this-group' again on a group in question helps (the "#" mark disappears) but I wish it could work as before. How about making the value for an inactive group in hashtb to `t' or something, that means the group exists but not activated? Regards, From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 07:02:03 2019 Received: (at 33653) by debbugs.gnu.org; 5 Apr 2019 11:02:03 +0000 Received: from localhost ([127.0.0.1]:45078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMbj-0004NU-Ds for submit@debbugs.gnu.org; Fri, 05 Apr 2019 07:02:03 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:34227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMbh-0004Mz-Cy for 33653@debbugs.gnu.org; Fri, 05 Apr 2019 07:02:01 -0400 Received: by mail-ed1-f41.google.com with SMTP id x14so5136431eds.1 for <33653@debbugs.gnu.org>; Fri, 05 Apr 2019 04:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rDCc1COegZJLTUJ/+L7G694vULqC9j3JLgMIrnl8O1I=; b=beM9ALZGHqou5I5yVECP5ryL1ZYhW+9FgUBJY0nsJvHir7vm4sGV6jGxm6AI/Tl1WZ nQYzvjZ3C+C5mK7xe6r/TXbKn0dlzNSbIM7c54t7Q5PEKnOwHqBaOZu3HCAtfSOVktAA oVUWwo22bOJFReHPTffxbEWXaHBEvagxpQY26klMEcc8FhF6w5FWc+98mS/yYKoGGjxc VgFK3yxGQSqNwZVKeKSNGJDV46bVwIWG4vtH0E7I26IyoLSph+2bPBulQ5o2ttJQkXxg Wc2NFXqQOS2GlBAv0OIgyFM4O7Y2vQVwekUpo0MhxUQWEla87+EeSlx/xBta/gdGkgGb s9ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rDCc1COegZJLTUJ/+L7G694vULqC9j3JLgMIrnl8O1I=; b=QnxE7vEwdezW3uQSouVblQkRyrtd4TBNAdf8cfT0kvmlCLfhg9+ZkgNuzU6h3CPZJB 3iOiUpySBG5L+7cSDH3/boyS5nh2LVYRCSWeM47l7GkMIdFLjTD0HGg+8FTT9lUWES9e vbvw91xu5ezDS5SX3BylfgPaPjeHDu8uNojuHSzIS0K9+4afmEvM3DRF9l7nu6SQSMb5 SLXXuC52WFviA765RKxq9XFb7MKBAX/7QBNcMcYjXiIGEHn2q9eYgOa+CjPFZAVJ5fi3 Xw2zYl5BVmMbnaXDxTQ5KwFnj/heK3glDoRaxdKCGQOSb/YLUc00kEUe+fcR6pFBfMY1 Mm9w== X-Gm-Message-State: APjAAAUkyjJrDgHD/kAaAWUKWnBdtaeOHeQHUt24UnWhK81aEeRtDgMQ KKK9DYKB7M1KwRiePtAQbZUqVA== X-Google-Smtp-Source: APXvYqzCBXXu5PN8ggfJFcdFK6eR9CvZKKHg3jCxJtD/unh61KvdmVIQOcyOI4r8aCQAP+4NaHkQxQ== X-Received: by 2002:a50:fa90:: with SMTP id w16mr7670368edr.42.1554462115472; Fri, 05 Apr 2019 04:01:55 -0700 (PDT) Received: from localhost (86-41-18-45-dynamic.agg3.crz.crz-crz.eircom.net. [86.41.18.45]) by smtp.gmail.com with ESMTPSA id h15sm1524783ejc.78.2019.04.05.04.01.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 04:01:54 -0700 (PDT) From: "Basil L. Contovounesios" To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> Date: Fri, 05 Apr 2019 12:01:53 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 5 Apr 2019 13:25:32 +0900") Message-ID: <87mul490m6.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > I found a cause of the `move article' not to work and pushed a > fix to master. That is having changed `while loop' to `dolist' > in `gnus-summary-move-article'. Because of this, the 5th arg > `last' passed to `gnus-request-move-article' gets always nil, > and that function never saves NOV and also ACTIVE at least for > an nnml group. Oops, mea culpa. > This is a good lesson to me; changing `while loop' to `dolist' > should be done carefully. I tried to be careful, but clearly wasn't careful enough. Thanks for fixing this, and sorry for the trouble. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 07:02:42 2019 Received: (at 33653) by debbugs.gnu.org; 5 Apr 2019 11:02:42 +0000 Received: from localhost ([127.0.0.1]:45081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMcL-0004OH-QS for submit@debbugs.gnu.org; Fri, 05 Apr 2019 07:02:42 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:39621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMcJ-0004O5-SM for 33653@debbugs.gnu.org; Fri, 05 Apr 2019 07:02:40 -0400 Received: by mail-ed1-f52.google.com with SMTP id p20so5105903eds.6 for <33653@debbugs.gnu.org>; Fri, 05 Apr 2019 04:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=jaKwftVxAM2jmh113A5056KciNPUOQ23+aqQQWpbcBc=; b=iJdynw5PCQ7VCU2stttSM3n6NWM2fWrEe0BqRHTffIJtEVNzAv7pKreS0qoVkg0ESN OrmcraDmWjjwG/FKLWvsFHRqIXtHuzemtbwgEkbJ4D7i7U8n+lvTsIauagglQ1H+5oTN aX3M2l6wOH8OAl1aaN0LK2jpEXWD5jawfz2GAsqjw1suL7o4KTRg+VWdNowVqMoc8oXU /k+fD4P+ReoPGQw5U9K0swtrKvk4eXzI4z8gM5m6m2JFBJwxH2s+D2io+VKCMTn/zW3g Qi8rWiMJLYAX0mI1YkraEPm2diSCAEwCmnv26oCdwe2jtRrlQ3QwfK1u0uLQfhCq6epm jiyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jaKwftVxAM2jmh113A5056KciNPUOQ23+aqQQWpbcBc=; b=PampfeRGx7wxi36ASspRXIpv64nTFSmWxDlF0byaHS+PQA/vJaBq14XrMB5GbZTYlG H1CcmEoKyX2k/EGmyW5KPtQn8JVPbw4el4FNpjDEfgNCEgkkX9k3ANSn+Ip40DoLhvud u2FB62d1G8/RcEILnOW/AXnYS/T28hl/iqmEalcsmZPX7mgp/DwvxKkcNbAQmjhffsDZ LSJlljhEF7xn1GnSgtuoL/AgSGH3UGni6VfOXArudPISSu/uQK5lMcGjKK6ZF0dr9qae QZB6DHS7Lo7DmfqQi1LjPB8JiKBODbRuph0kKJg30FKmbZfS3M1WX0mz7TR1BPp5jv7i CFkQ== X-Gm-Message-State: APjAAAU7nL5c2l2c98v7DgLJ069AzRox0wRrSNQhcIlKXAX1a3cVTYw9 TK7pNdvORGrMHf0Nt2qhMoWKyw== X-Google-Smtp-Source: APXvYqyWkWWM7ra6xx6eIdKvD7z4CiqRlNLx0T+Olgqw7qJ0HM725jpm2ZTeVc+oOQJhrhEYx3DOww== X-Received: by 2002:a17:906:f0f:: with SMTP id z15mr6980166eji.125.1554462154128; Fri, 05 Apr 2019 04:02:34 -0700 (PDT) Received: from localhost (86-41-18-45-dynamic.agg3.crz.crz-crz.eircom.net. [86.41.18.45]) by smtp.gmail.com with ESMTPSA id p16sm6273358eds.61.2019.04.05.04.02.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 04:02:33 -0700 (PDT) From: "Basil L. Contovounesios" To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> Date: Fri, 05 Apr 2019 12:02:32 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 5 Apr 2019 15:44:44 +0900") Message-ID: <87lg0o90l3.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > One more regression. :) > > In the group buffer the `j' command (`gnus-group-jump-to-group') > does not work for a group that is not activated yet. The point > goes to the top. Such a group will appear with the `*' mark by > the `l' or the `L' command like the followig: > > *: nntp+gmane:gmane.emacs.devel > > Similarly the "#" mark put in front of a marked such group will > not disappear after processing a certain job (normally > `gnus-group-get-new-news-this-group' on me) as follows: > > # *: nntp+gmane:gmane.emacs.devel > =E2=86=93=E2=86=93=E2=86=93 > # 168: nntp+gmane:gmane.emacs.devel > > The cause is the same; such non-activated groups are not listed > in `gnus-active-hashtb': > > (gethash "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb) > =3D> nil > > But in Gnus bundled with Emacs 26.1.92 it returns a group name > symbol, though its value (i.e., active) is nil: > > (gnus-intern-safe "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb) > =3D> nntp+gmane:gmane\.emacs\.devel > (symbol-value > (gnus-intern-safe "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb)) > =3D> nil > > In my Gnus, there are many non-activated groups at just after > lauching Gnus with the prefix arg `1', because I set the group > level `1' to the groups normally used and larger level to the > others. In the starting time of work, my habit is to check > mails in the active groups for a while and then activate and > check groups of larger level. > > Running `gnus-group-get-new-news-this-group' again on a group in > question helps (the "#" mark disappears) but I wish it could work > as before. How about making the value for an inactive group in > hashtb to `t' or something, that means the group exists but not > activated? Would this fix bug#35070? I.e. are you describing the same bug? Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 16:19:00 2019 Received: (at 33653) by debbugs.gnu.org; 5 Apr 2019 20:19:00 +0000 Received: from localhost ([127.0.0.1]:46322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCVIh-0002jm-R4 for submit@debbugs.gnu.org; Fri, 05 Apr 2019 16:19:00 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:39378 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCVIc-0002jW-KT for 33653@debbugs.gnu.org; Fri, 05 Apr 2019 16:18:58 -0400 Received: from localhost (50-251-205-17-static.hfc.comcastbusiness.net [50.251.205.17]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E2FA7FA035; Fri, 5 Apr 2019 20:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554495529; bh=QuP28aeg6nbvoHFuaI3ezUVJ4rEX0KyV7RXBm8crxU4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VQ1ci4u5DsaAJ3bxGI6c/+q0CUiahyfir0mzl539NCHklpi4QKJXkmqNjyoeKaKp8 LzUMDFo0bekSgL8nHvCvL005B46LuFAA3ZzCmBnuHJXPin/cAr2IuauoI4czIpv/FX qwKOfAaqdurFLZBSAcWySzO2WHDX5WPrDMQDuGZo= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> Date: Fri, 05 Apr 2019 13:18:47 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 05 Apr 2019 15:44:44 +0900") Message-ID: <87h8bcqk7s.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 04/05/19 15:44 PM, Katsumi Yamaoka wrote: > One more regression. :) > > In the group buffer the `j' command (`gnus-group-jump-to-group') > does not work for a group that is not activated yet. The point > goes to the top. Such a group will appear with the `*' mark by > the `l' or the `L' command like the followig: > > *: nntp+gmane:gmane.emacs.devel > > Similarly the "#" mark put in front of a marked such group will > not disappear after processing a certain job (normally > `gnus-group-get-new-news-this-group' on me) as follows: > > # *: nntp+gmane:gmane.emacs.devel > =E2=86=93=E2=86=93=E2=86=93 > # 168: nntp+gmane:gmane.emacs.devel > > The cause is the same; such non-activated groups are not listed > in `gnus-active-hashtb': > > (gethash "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb) > =3D> nil > > But in Gnus bundled with Emacs 26.1.92 it returns a group name > symbol, though its value (i.e., active) is nil: > > (gnus-intern-safe "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb) > =3D> nntp+gmane:gmane\.emacs\.devel > (symbol-value > (gnus-intern-safe "nntp+gmane:gmane.emacs.devel" gnus-active-hashtb)) > =3D> nil > > In my Gnus, there are many non-activated groups at just after > lauching Gnus with the prefix arg `1', because I set the group > level `1' to the groups normally used and larger level to the > others. In the starting time of work, my habit is to check > mails in the active groups for a while and then activate and > check groups of larger level. > > Running `gnus-group-get-new-news-this-group' again on a group in > question helps (the "#" mark disappears) but I wish it could work > as before. How about making the value for an inactive group in > hashtb to `t' or something, that means the group exists but not > activated? I think the right solution might be to check (member group-name (hash-table-keys gnus-active-hashtb)) Or else use the DFLT argument to `gethash' together with a `make-symbol', to see if "nil" means "no such key", or if it means "key with nil value". Eric From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 21:47:31 2019 Received: (at 33653) by debbugs.gnu.org; 8 Apr 2019 01:47:31 +0000 Received: from localhost ([127.0.0.1]:48879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDJNi-0006g6-Kv for submit@debbugs.gnu.org; Sun, 07 Apr 2019 21:47:30 -0400 Received: from indri.birch.relay.mailchannels.net ([23.83.209.92]:56180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDJNg-0006fv-Hp for 33653@debbugs.gnu.org; Sun, 07 Apr 2019 21:47:29 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 227661250B3; Mon, 8 Apr 2019 01:47:26 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.11.48]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 4B4C8125001; Mon, 8 Apr 2019 01:47:25 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 08 Apr 2019 01:47:26 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Print-Glossy: 36e9a2c259db83e9_1554688045914_444011560 X-MC-Loop-Signature: 1554688045914:2703785269 X-MC-Ingress-Time: 1554688045914 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDJNZ-005NDx-HN; Sun, 07 Apr 2019 20:47:22 -0500 Date: Mon, 08 Apr 2019 10:47:24 +0900 Message-ID: From: Katsumi Yamaoka To: Basil L. Contovounesios Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> <87lg0o90l3.fsf@tcd.ie> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (x86_64-unknown-cygwin) Cancel-Lock: sha1:XH5QWPelm9j+RumpzedkvFba+xY= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 05 Apr 2019 12:02:32 +0100, Basil L. Contovounesios wrote: > Would this fix bug#35070? I.e. are you describing the same bug? Well, what I can reproduce doesn't seem to be exactly the same with Lars' though, I guess the root cause would probably be: (gethash "inactive-or-non-existent-group" gnus-active-hashtb) returns nil. Maybe "undisplayed group" that Lars says means a group that is inactive but in existence. Performing Lars' recipe in my Gnus produces things as follows: (gnus-group-jump-to-group "inactive-group") =E2=86=93 (gnus-group-goto-group "inactive-group") =E2=86=93 (let ((active (gethash "inactive-group" gnus-active-hashtb))) =E2=86=93 (gnus-text-property-search 'gnus-group active nil 'goto) Where `active' is nil but `gnus-text-property-search' finds it at (point-min) and goes to there. Though the "inactive-group" does not appear there. But if forcing `active' to be an inactive group name in the above flow, it appears at, as Lars says, "either at the start of the buffer (before all topics) or at the start of one of the topics it doesn't belong in" as *: nnfoo:bar and the point is positioned there. Regards, From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 21:58:44 2019 Received: (at 33653) by debbugs.gnu.org; 8 Apr 2019 01:58:44 +0000 Received: from localhost ([127.0.0.1]:48883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDJYZ-0006y5-QW for submit@debbugs.gnu.org; Sun, 07 Apr 2019 21:58:44 -0400 Received: from bisque.maple.relay.mailchannels.net ([23.83.214.18]:42356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDJYX-0006xw-5r for 33653@debbugs.gnu.org; Sun, 07 Apr 2019 21:58:41 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id ABB4F1417F4; Mon, 8 Apr 2019 01:58:36 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-6-122.trex.outbound.svc.cluster.local [100.96.6.122]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 8100B141379; Mon, 8 Apr 2019 01:58:35 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 08 Apr 2019 01:58:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Gusty-Duck: 3209c26f32c1f08d_1554688716444_3824316295 X-MC-Loop-Signature: 1554688716444:3216739304 X-MC-Ingress-Time: 1554688716443 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDJYI-005Pgs-KG; Sun, 07 Apr 2019 20:58:27 -0500 Date: Mon, 08 Apr 2019 10:58:30 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> <87h8bcqk7s.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (x86_64-unknown-cygwin) Cancel-Lock: sha1:bogW8fqkitGns4RvCDd56TiDrUw= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 05 Apr 2019 13:18:47 -0700, Eric Abrahamsen wrote: > I think the right solution might be to check > (member group-name (hash-table-keys gnus-active-hashtb)) It doesn't help because it returns nil for a non-activated (but existing) group name. Probably the solution would be to make hashtb list all the groups existing in `gnus-newsrc-alist' at the startup. It will take time but is necessary, I think. > Or else use the DFLT argument to `gethash' together with a > `make-symbol', to see if "nil" means "no such key", or if it means "key > with nil value". Doesn't it make any group valid no matter what is really exists or not? Regards, From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 00:31:13 2019 Received: (at 33653) by debbugs.gnu.org; 8 Apr 2019 04:31:13 +0000 Received: from localhost ([127.0.0.1]:48910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDLw9-0002Cq-Bk for submit@debbugs.gnu.org; Mon, 08 Apr 2019 00:31:13 -0400 Received: from ladybird.maple.relay.mailchannels.net ([23.83.214.98]:65312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDLw7-0002Cd-0X for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 00:31:12 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BB6A55E1CAB; Mon, 8 Apr 2019 04:31:09 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-7-60.trex.outbound.svc.cluster.local [100.96.7.60]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 9ADC15E1C70; Mon, 8 Apr 2019 04:31:08 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 08 Apr 2019 04:31:09 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Eight-Irritate: 0b81e7df55f836ad_1554697869480_1631421563 X-MC-Loop-Signature: 1554697869480:3812045615 X-MC-Ingress-Time: 1554697869479 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDLvv-005zdf-KF; Sun, 07 Apr 2019 23:31:00 -0500 Date: Mon, 08 Apr 2019 13:31:03 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> <87h8bcqk7s.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (x86_64-unknown-cygwin) Cancel-Lock: sha1:tSW5XeRGI1VLmQDztz1WH0z+8gw= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 08 Apr 2019 10:58:30 +0900, Katsumi Yamaoka wrote: > Probably the solution would be to make hashtb list all > the groups existing in `gnus-newsrc-alist' at the startup. I found `gnus-newsrc-hashtb' has all the group names that `gnus-newsrc-alist' holds. So, I'm not quite sure since I have not tested it thoroughly yet though, the problem I brought up --- j doesn't work for groups having not activated --- can be fixed with: --- gnus-group.el~ 2019-04-01 21:28:54.404887500 +0000 +++ gnus-group.el 2019-04-08 04:19:19.117882300 +0000 @@ -2562,3 +2562,3 @@ (let ((start (point)) - (active (and (gethash group gnus-active-hashtb) + (active (and (gethash group gnus-newsrc-hashtb) group))) ;; The variable name `active' seems to be better to change to ;; `name' or something since it is a group name string, not ;; active data here. This looks to fix Lars' bug#35070 as well. I'll check and check it with investigating other issues... From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 04:13:37 2019 Received: (at 33653) by debbugs.gnu.org; 8 Apr 2019 08:13:37 +0000 Received: from localhost ([127.0.0.1]:48969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDPPN-0007f4-6B for submit@debbugs.gnu.org; Mon, 08 Apr 2019 04:13:37 -0400 Received: from ladybird.maple.relay.mailchannels.net ([23.83.214.98]:33081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDPPL-0007ew-4e for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 04:13:35 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E71921423F6; Mon, 8 Apr 2019 08:13:33 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-4-125.trex.outbound.svc.cluster.local [100.96.4.125]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 9164F142381; Mon, 8 Apr 2019 08:13:32 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 08 Apr 2019 08:13:33 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Cellar-Broad: 01c14e7141e595b5_1554711213539_2389787375 X-MC-Loop-Signature: 1554711213538:877808022 X-MC-Ingress-Time: 1554711213538 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDPP8-006sva-V3; Mon, 08 Apr 2019 03:13:24 -0500 Date: Mon, 08 Apr 2019 17:13:25 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (x86_64-unknown-cygwin) Cancel-Lock: sha1:ebqac1VsO/gk2LJxRzK0jn4Ylx0= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 27 Mar 2019 13:54:42 +0900, Katsumi Yamaoka wrote: > The group level of nnml:=E3=83=86=E3=82=B9=E3=83=88 is 1 and there are so= me unread > articles in it, however the group is not listed in the Group > buffer when I launch Gnus by `C-u 1 M-x gnus RET'... I found a cause of it not to be listed in the group buffer just after launching Gnus. The group entry in the ~/Mail/active file is: =E3=83=86=E3=82=B9=E3=83=88 5 1 y The file coding is utf-8-unix. So, the binary expression of the group name is \343\203\206\343\202\271\343\203\210, where \343 is a single character, and this form is what the hash tables use (in the ~/.newsrc.eld file, "\343" consists of four characters "\", "3", "4", and "3", though). `gnus-active-to-gnus-format' reads it in the following way: =E3=83=BBLoad the active file to the " *nntpd*" buffer in the binary =E3=80=80mode. Copy it to another temp buffer. There \343 is a single =E3=80=80character. =E3=83=BBRead the group name using `(read (current-buffer))'. =E3=80=80Then it is read as a symbol; \343 is still a single character. =E3=83=BBConvert it to a string using `symbol-name'. =E3=80=80\343 is expanded into the one consists of four characters. :< =E3=80=80It should never match to the one in the hash tables. Why the single-char to four-chars conversion happens is that the buffer where those processes are done is in the multibyte mode. So, the patch attached below solves the problem. I'm going to test it for the other back ends... --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- gnus-start.el~ 2019-03-25 21:22:46.184139100 +0000 +++ gnus-start.el 2019-04-08 08:07:41.906976900 +0000 @@ -2139,3 +2139,3 @@ - (with-temp-buffer + (mm-with-unibyte-buffer (insert-buffer-substring cur) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 04:58:06 2019 Received: (at 33653) by debbugs.gnu.org; 8 Apr 2019 08:58:06 +0000 Received: from localhost ([127.0.0.1]:48989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDQ6Q-0000Lh-Fi for submit@debbugs.gnu.org; Mon, 08 Apr 2019 04:58:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:32896 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDQ6O-0000LE-Lk for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 04:58:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7EED4AC5C; Mon, 8 Apr 2019 08:57:58 +0000 (UTC) From: Andreas Schwab To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> X-Yow: I am having FUN... I wonder if it's NET FUN or GROSS FUN? Date: Mon, 08 Apr 2019 10:57:57 +0200 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 08 Apr 2019 17:13:25 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , "Basil L. Contovounesios" , Adam =?utf-8?Q?Sj?= =?utf-8?Q?=C3=B8gren?= , 33653@debbugs.gnu.org, Bastien Guerry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Apr 08 2019, Katsumi Yamaoka wrote: > ・Load the active file to the " *nntpd*" buffer in the binary > 　mode. Copy it to another temp buffer. There \343 is a single > 　character. > ・Read the group name using `(read (current-buffer))'. > 　Then it is read as a symbol; \343 is still a single character. > ・Convert it to a string using `symbol-name'. > 　\343 is expanded into the one consists of four characters. :< It's not expanded. That's just the print representation. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 14:32:09 2019 Received: (at 33653) by debbugs.gnu.org; 8 Apr 2019 18:32:09 +0000 Received: from localhost ([127.0.0.1]:50174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDZ3v-0002Fg-VR for submit@debbugs.gnu.org; Mon, 08 Apr 2019 14:32:09 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:44292 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDZ3s-0002F9-Rn for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 14:32:06 -0400 Received: from localhost (97-113-36-222.tukw.qwest.net [97.113.36.222]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id EE4C2FA028; Mon, 8 Apr 2019 18:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554748319; bh=Sgfu08ElJlufC0wV8ANhQP9kW/B/i1QD4KC2wzxyrmU=; h=From:To:Cc:Subject:References:Date:From; b=PZSaIvX8Cri/nl06nQJKYYH50q5LZkiWP3K4LXtAQrzxXb7EXCU7+cNjprNOwXiC0 cTcZdkE7ckFB1grZkSxMcsxbwA+pU2vra6bIVW7zWc6f+6KhkAHmD6mtYpeeVX/Sm7 w6JQobMymsGcmg1yNO8NovzHBF9QTgQuK9vVFdTQ= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Date: Mon, 08 Apr 2019 11:31:57 -0700 Message-ID: <87o95gqrfm.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/08/19 17:13 PM, Katsumi Yamaoka wrote: > On Wed, 27 Mar 2019 13:54:42 +0900, Katsumi Yamaoka wrote: >> The group level of nnml:=E3=83=86=E3=82=B9=E3=83=88 is 1 and there are s= ome unread >> articles in it, however the group is not listed in the Group >> buffer when I launch Gnus by `C-u 1 M-x gnus RET'... > > I found a cause of it not to be listed in the group buffer just > after launching Gnus. > > The group entry in the ~/Mail/active file is: > > =E3=83=86=E3=82=B9=E3=83=88 5 1 y > > The file coding is utf-8-unix. So, the binary expression of the > group name is \343\203\206\343\202\271\343\203\210, where \343 > is a single character, and this form is what the hash tables use > (in the ~/.newsrc.eld file, "\343" consists of four characters > "\", "3", "4", and "3", though). > > `gnus-active-to-gnus-format' reads it in the following way: > > =E3=83=BBLoad the active file to the " *nntpd*" buffer in the binary > =E3=80=80mode. Copy it to another temp buffer. There \343 is a single > =E3=80=80character. > =E3=83=BBRead the group name using `(read (current-buffer))'. > =E3=80=80Then it is read as a symbol; \343 is still a single character. > =E3=83=BBConvert it to a string using `symbol-name'. > =E3=80=80\343 is expanded into the one consists of four characters. :< > =E3=80=80It should never match to the one in the hash tables. > > Why the single-char to four-chars conversion happens is that > the buffer where those processes are done is in the multibyte > mode. So, the patch attached below solves the problem. I'm > going to test it for the other back ends... > > --- gnus-start.el~ 2019-03-25 21:22:46.184139100 +0000 > +++ gnus-start.el 2019-04-08 08:07:41.906976900 +0000 > @@ -2139,3 +2139,3 @@ > > - (with-temp-buffer > + (mm-with-unibyte-buffer > (insert-buffer-substring cur) I was asking on emacs.devel about that, and with Andreas' help came up with the attached patch. It's a terrible hack, but it seems to work, and I think would be good as an intermediate step. What you're doing -- changing the unibyte/multibyte status of the buffers -- is I think part of the final, more correct solution to the problem, that will leave group names decoded everywhere. But I would like to Gnus back into an intermediate working state before tackling that... What do you think? Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-WIP-on-nnmail-group-names.patch >From 4905ecb5dfd301d3ce9c6d92d2c0b6005a24fa51 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sun, 31 Mar 2019 09:09:18 -0700 Subject: [PATCH] WIP on nnmail group names --- lisp/gnus/gnus-start.el | 15 +++++++++------ lisp/gnus/nnmail.el | 2 +- lisp/gnus/nnml.el | 16 ++++++++-------- lisp/gnus/nnrss.el | 18 +++++++++--------- 4 files changed, 27 insertions(+), 24 deletions(-) diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index 9b1be65067..2beb685822 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -2145,12 +2145,15 @@ gnus-active-to-gnus-format (condition-case () (if (and (stringp (progn (setq group (read cur) - group (cond ((numberp group) - (number-to-string group)) - ((symbolp group) - (symbol-name group)) - ((stringp group) - group))))) + group + (encode-coding-string + (cond ((numberp group) + (number-to-string group)) + ((symbolp group) + (symbol-name group)) + ((stringp group) + group)) + 'latin-1)))) (numberp (setq max (read cur))) (numberp (setq min (read cur))) (null (progn diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el index a95cdb4a4f..b6dbbea74c 100644 --- a/lisp/gnus/nnmail.el +++ b/lisp/gnus/nnmail.el @@ -663,7 +663,7 @@ nnmail-parse-active (narrow-to-region (point) (point-at-eol)) (setq group (read buffer)) (unless (stringp group) - (setq group (symbol-name group))) + (setq group (encode-coding-string (symbol-name group) 'latin-1))) (if (and (numberp (setq max (read buffer))) (numberp (setq min (read buffer)))) (push (list group (cons min max)) diff --git a/lisp/gnus/nnml.el b/lisp/gnus/nnml.el index 5770777ad4..205e9e4803 100644 --- a/lisp/gnus/nnml.el +++ b/lisp/gnus/nnml.el @@ -259,7 +259,7 @@ nnml-request-group (t (nnheader-re-read-dir nnml-current-directory) (nnmail-activate 'nnml) - (let ((active (nth 1 (assoc group nnml-group-alist)))) + (let ((active (nth 1 (assoc-string group nnml-group-alist)))) (if (not active) (nnheader-report 'nnml "No such group: %s" decoded) (nnheader-report 'nnml "Selected group %s" decoded) @@ -295,7 +295,7 @@ nnml-request-create-group (nnheader-report 'nnml "%s is a file" (directory-file-name (nnml-group-pathname group nil server)))) - ((assoc group nnml-group-alist) + ((assoc-string group nnml-group-alist) t) (t (let (active) @@ -379,7 +379,7 @@ nnml-request-expire-articles (nnml-nov-delete-article group number)) (push number rest))) (push number rest))) - (let ((active (nth 1 (assoc group nnml-group-alist)))) + (let ((active (nth 1 (assoc-string group nnml-group-alist)))) (when active (setcar active (or (and active-articles (apply 'min active-articles)) @@ -520,7 +520,7 @@ nnml-request-delete-group (nnheader-report 'nnml "No such directory: %s/" file)) ;; Remove the group from all structures. (setq nnml-group-alist - (delq (assoc group nnml-group-alist) nnml-group-alist) + (delq (assoc-string group nnml-group-alist) nnml-group-alist) nnml-current-group nil nnml-current-directory nil) ;; Save the active file. @@ -549,7 +549,7 @@ nnml-request-rename-group (when (<= (length (directory-files old-dir)) 2) (ignore-errors (delete-directory old-dir))) ;; That went ok, so we change the internal structures. - (let ((entry (assoc group nnml-group-alist))) + (let ((entry (assoc-string group nnml-group-alist))) (when entry (setcar entry new-name)) (setq nnml-current-directory nil @@ -597,7 +597,7 @@ nnml-deletable-article-p (when (setq path (nnml-article-to-file article)) (when (file-writable-p path) (or (not nnmail-keep-last-article) - (not (eq (cdr (nth 1 (assoc group nnml-group-alist))) + (not (eq (cdr (nth 1 (assoc-string group nnml-group-alist))) article))))))) ;; Find an article number in the current group given the Message-ID. @@ -742,7 +742,7 @@ nnml-active-number "Compute the next article number in GROUP on SERVER." (let* ((encoded (if nnmail-group-names-not-encoded-p (nnml-encoded-group-name group server))) - (active (cadr (assoc (or encoded group) nnml-group-alist)))) + (active (cadr (assoc-string (or encoded group) nnml-group-alist)))) ;; The group wasn't known to nnml, so we just create an active ;; entry for it. (unless active @@ -783,7 +783,7 @@ nnml-save-incremental-nov (cdr nnml-incremental-nov-buffer-alist))))) (defun nnml-open-incremental-nov (group) - (or (cdr (assoc group nnml-incremental-nov-buffer-alist)) + (or (cdr (assoc-string group nnml-incremental-nov-buffer-alist)) (let ((buffer (nnml-get-nov-buffer group t))) (push (cons group buffer) nnml-incremental-nov-buffer-alist) buffer))) diff --git a/lisp/gnus/nnrss.el b/lisp/gnus/nnrss.el index 7f2accc2b6..0bfecb28e0 100644 --- a/lisp/gnus/nnrss.el +++ b/lisp/gnus/nnrss.el @@ -340,10 +340,10 @@ nnrss-request-delete-group (let (elem) ;; There may be two or more entries in `nnrss-group-alist' since ;; this function didn't delete them formerly. - (while (setq elem (assoc group nnrss-group-alist)) + (while (setq elem (assoc-string group nnrss-group-alist)) (setq nnrss-group-alist (delq elem nnrss-group-alist)))) (setq nnrss-server-data - (delq (assoc group nnrss-server-data) nnrss-server-data)) + (delq (assoc-string group nnrss-server-data) nnrss-server-data)) (nnrss-save-server-data server) (ignore-errors (let ((file-name-coding-system nnmail-pathname-coding-system)) @@ -367,7 +367,7 @@ nnrss-retrieve-groups (with-current-buffer nntp-server-buffer (erase-buffer) (dolist (group groups) - (let ((elem (assoc (gnus-group-decoded-name group) nnrss-server-data))) + (let ((elem (assoc-string (gnus-group-decoded-name group) nnrss-server-data))) (insert (format "%S %s 1 y\n" group (or (cadr elem) 0))))) 'active)) @@ -539,7 +539,7 @@ nnrss-read-group-data (if (hash-table-p nnrss-group-hashtb) (clrhash nnrss-group-hashtb) (setq nnrss-group-hashtb (make-hash-table :test 'equal))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (setq nnrss-group-max (or (cadr pair) 0)) (setq nnrss-group-min (+ nnrss-group-max 1))) (let ((file (nnrss-make-filename group server)) @@ -644,8 +644,8 @@ nnrss-check-group (concat group ".xml")) nnrss-directory)))) (setq xml (nnrss-fetch file t)) - (setq url (or (nth 2 (assoc group nnrss-server-data)) - (cadr (assoc group nnrss-group-alist)))) + (setq url (or (nth 2 (assoc-string group nnrss-server-data)) + (cadr (assoc-string group nnrss-group-alist)))) (unless url (setq url (cdr @@ -653,7 +653,7 @@ nnrss-check-group (nnrss-discover-feed (read-string (format "URL to search for %s: " group) "http://"))))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcdr (cdr pair) (list url)) (push (list group nnrss-group-max url) nnrss-server-data))) @@ -721,7 +721,7 @@ nnrss-check-group (setq extra nil)) (when changed (nnrss-save-group-data group server) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcar (cdr pair) nnrss-group-max) (push (list group nnrss-group-max) nnrss-server-data))) @@ -792,7 +792,7 @@ nnrss-generate-download-script (insert "RSSDIR='" (expand-file-name nnrss-directory) "'\n") (dolist (elem nnrss-server-data) (let ((url (or (nth 2 elem) - (cadr (assoc (car elem) nnrss-group-alist))))) + (cadr (assoc-string (car elem) nnrss-group-alist))))) (insert "$WGET -q -O \"$RSSDIR\"/'" (nnrss-translate-file-chars (concat (car elem) ".xml")) "' '" url "'\n")))) -- 2.21.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 20:55:20 2019 Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 00:55:20 +0000 Received: from localhost ([127.0.0.1]:50373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDf2l-0001JB-Uq for submit@debbugs.gnu.org; Mon, 08 Apr 2019 20:55:20 -0400 Received: from quail.birch.relay.mailchannels.net ([23.83.209.151]:64271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDf2j-0001J2-Bf for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 20:55:18 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DBA2D3E4A9E; Tue, 9 Apr 2019 00:55:15 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.39.118]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 0CC4A3E3FDC; Tue, 9 Apr 2019 00:55:14 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 09 Apr 2019 00:55:15 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Harbor-Tank: 0973b85540644442_1554771315687_4029383287 X-MC-Loop-Signature: 1554771315687:1581531984 X-MC-Ingress-Time: 1554771315687 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDf2d-00AqcI-DO; Mon, 08 Apr 2019 19:55:12 -0500 Date: Tue, 09 Apr 2019 09:55:15 +0900 Message-ID: From: Katsumi Yamaoka To: Andreas Schwab Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:Ct8QBrFBcpFiiNfemKU6+FHyRz8= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , "Basil L. Contovounesios" , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org, Bastien Guerry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 08 Apr 2019 10:57:57 +0200, Andreas Schwab wrote: > On Apr 08 2019, Katsumi Yamaoka wrote: >> =E3=83=BBConvert it to a string using `symbol-name'. >> =E3=80=80\343 is expanded into the one consists of four characters. :< > It's not expanded. That's just the print representation. Indeed. I learned not only symbol-name, but also eval-print-last-sexp, edebug-eval-expression, describe-variable, etc. also just make it human readable one. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 20:55:28 2019 Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 00:55:28 +0000 Received: from localhost ([127.0.0.1]:50376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDf2u-0001JW-9q for submit@debbugs.gnu.org; Mon, 08 Apr 2019 20:55:28 -0400 Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:48757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDf2s-0001JO-Ju for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 20:55:27 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6F1DB124750; Tue, 9 Apr 2019 00:55:24 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.20.50]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 4B5DC124CE9; Tue, 9 Apr 2019 00:55:23 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 09 Apr 2019 00:55:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Power-Bubble: 4696fe1c6c124cba_1554771323979_1206876961 X-MC-Loop-Signature: 1554771323979:461705882 X-MC-Ingress-Time: 1554771323978 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60001 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDf2l-00Aqdh-E7; Mon, 08 Apr 2019 19:55:20 -0500 Date: Tue, 09 Apr 2019 09:55:23 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87o95gqrfm.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:8bDBR0fRhBie6nh12XzJfvdAB4M= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 08 Apr 2019 11:31:57 -0700, Eric Abrahamsen wrote: > On 04/08/19 17:13 PM, Katsumi Yamaoka wrote: >> - (with-temp-buffer >> + (mm-with-unibyte-buffer >> (insert-buffer-substring cur) > I was asking on emacs.devel about that, and with Andreas' help came up > with the attached patch. It's a terrible hack, but it seems to work, and > I think would be good as an intermediate step. > What you're doing -- changing the unibyte/multibyte status of the > buffers -- is I think part of the final, more correct solution to the > problem, that will leave group names decoded everywhere. But I would > like to Gnus back into an intermediate working state before tackling > that... > What do you think? Whatever we should do finally, isn't it necessary to make Gnus on Emacs master work now anyway even if it is immature? Those who like the *latest* code by any means (me included) would be coming to use it sooner or later. So, I'd like you to install to master a fix whatever makes Gnus work. > --- a/lisp/gnus/gnus-start.el > +++ b/lisp/gnus/gnus-start.el [...] > (setq group (read cur) > + group > + (encode-coding-string > + (cond ((numberp group) > + (number-to-string group)) > + ((symbolp group) > + (symbol-name group)) > + ((stringp group) > + group)) > + 'latin-1)))) Makes sense to me. Though encoding the one having already encoded looks redundant, I have no idea other than this and my patch, and benchmark reports there is no notably difference in speed between this and my patch. Anyway I verified it works for listing the nnml:=E3=83=86=E3=82=B9=E3=83=88= group. > --- a/lisp/gnus/nnmail.el > +++ b/lisp/gnus/nnmail.el > --- a/lisp/gnus/nnml.el > +++ b/lisp/gnus/nnml.el Verified that those patches enable updating groups by `M-g'. > --- a/lisp/gnus/nnrss.el > +++ b/lisp/gnus/nnrss.el Verified that I can read some feeds. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 22:01:17 2019 Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 02:01:18 +0000 Received: from localhost ([127.0.0.1]:50406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDg4b-000521-Ko for submit@debbugs.gnu.org; Mon, 08 Apr 2019 22:01:17 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:44862 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDg4a-00051o-0M for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 22:01:16 -0400 Received: from localhost (97-126-93-115.tukw.qwest.net [97.126.93.115]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 16364FA05B; Tue, 9 Apr 2019 02:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554775270; bh=/TqE14strgtOyX0+KChXq8ag6OB3D/yKA+9mbNwrxeg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZdoBkhX4gEd5t7pldnJxFXscelJixF5enbw/NBBDkfChewEcBWHFu5qhpQKOtK5FU KnWzFeAaXV6+fSnxbk6Sdtfwam1BnUzzi3LL3LFRXGoLlZ0hTWdLXJGRbE2jy5AlNc IhzOhh24gO36gOAx1T3E44wBOJUfDxNVMsPiJcUU= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87o95gqrfm.fsf@ericabrahamsen.net> Date: Mon, 08 Apr 2019 19:01:08 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 09 Apr 2019 09:55:23 +0900") Message-ID: <87ftqsey3f.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 04/09/19 09:55 AM, Katsumi Yamaoka wrote: > On Mon, 08 Apr 2019 11:31:57 -0700, Eric Abrahamsen wrote: >> On 04/08/19 17:13 PM, Katsumi Yamaoka wrote: >>> - (with-temp-buffer >>> + (mm-with-unibyte-buffer >>> (insert-buffer-substring cur) > >> I was asking on emacs.devel about that, and with Andreas' help came up >> with the attached patch. It's a terrible hack, but it seems to work, and >> I think would be good as an intermediate step. > >> What you're doing -- changing the unibyte/multibyte status of the >> buffers -- is I think part of the final, more correct solution to the >> problem, that will leave group names decoded everywhere. But I would >> like to Gnus back into an intermediate working state before tackling >> that... > >> What do you think? > > Whatever we should do finally, isn't it necessary to make Gnus on > Emacs master work now anyway even if it is immature? Those who > like the *latest* code by any means (me included) would be coming > to use it sooner or later. So, I'd like you to install to master > a fix whatever makes Gnus work. Yes, that's what I was saying! Do the minimum needed now to get things working again, then I'll be more careful putting a more thorough fix later. >> --- a/lisp/gnus/gnus-start.el >> +++ b/lisp/gnus/gnus-start.el > [...] >> (setq group (read cur) >> + group >> + (encode-coding-string >> + (cond ((numberp group) >> + (number-to-string group)) >> + ((symbolp group) >> + (symbol-name group)) >> + ((stringp group) >> + group)) >> + 'latin-1)))) > > Makes sense to me. Though encoding the one having already encoded > looks redundant, I have no idea other than this and my patch, and > benchmark reports there is no notably difference in speed between > this and my patch. Yes, it's ugly, but hopefully it's temporary. I am glad that it doesn't affect speed, though. > Anyway I verified it works for listing the nnml:=E3=83=86=E3=82=B9=E3=83= =88 group. > >> --- a/lisp/gnus/nnmail.el >> +++ b/lisp/gnus/nnmail.el > >> --- a/lisp/gnus/nnml.el >> +++ b/lisp/gnus/nnml.el > > Verified that those patches enable updating groups by `M-g'. > >> --- a/lisp/gnus/nnrss.el >> +++ b/lisp/gnus/nnrss.el > > Verified that I can read some feeds. Thanks very much. I'll push this now, and then see what else needs cleaning up. Eric From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 00:18:18 2019 Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 04:18:18 +0000 Received: from localhost ([127.0.0.1]:50432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDiDB-0008Op-TG for submit@debbugs.gnu.org; Tue, 09 Apr 2019 00:18:18 -0400 Received: from otter.birch.relay.mailchannels.net ([23.83.209.139]:40447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDiD9-0008Of-3z for 33653@debbugs.gnu.org; Tue, 09 Apr 2019 00:18:16 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2A4E98C1BB5; Tue, 9 Apr 2019 04:18:13 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-6-122.trex.outbound.svc.cluster.local [100.96.6.122]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 010EA8C1AF9; Tue, 9 Apr 2019 04:18:11 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 09 Apr 2019 04:18:13 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Trail-Army: 176ca79102d24f34_1554783492994_3588581402 X-MC-Loop-Signature: 1554783492994:1207655987 X-MC-Ingress-Time: 1554783492994 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDiCw-00BbH2-Vu; Mon, 08 Apr 2019 23:18:04 -0500 Date: Tue, 09 Apr 2019 13:18:06 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87o95gqrfm.fsf@ericabrahamsen.net> <87ftqsey3f.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (x86_64-unknown-cygwin) Cancel-Lock: sha1:Qmh2wzr2G2qkX3vqn2a4yxKy/7w= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 08 Apr 2019 19:01:08 -0700, Eric Abrahamsen wrote: > Thanks very much. I'll push this now, and then see what else needs > cleaning up. Thanks! I added this one (cf. ): Make `jump to group' work even if it is not activated (bug#33653) * lisp/gnus/gnus-group.el (gnus-group-goto-group): Use gnus-newsrc-hashtb instead of gnus-newsrc-hashtb to check if a group exists even if its server is not activated (bug#33653). From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 00:30:44 2019 Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 04:30:44 +0000 Received: from localhost ([127.0.0.1]:50436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDiPC-0000GR-2y for submit@debbugs.gnu.org; Tue, 09 Apr 2019 00:30:44 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:45064 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDiP9-0000GD-04 for 33653@debbugs.gnu.org; Tue, 09 Apr 2019 00:30:40 -0400 Received: from localhost (97-126-93-115.tukw.qwest.net [97.126.93.115]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 15616FA05B; Tue, 9 Apr 2019 04:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554784233; bh=V3F84Dhtw/hugOe+OaBtjMI4Q/GGLkVcaGFxTI1xhdY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MAy7c1dTYl/aJ5ms47q+cY8AzI55qqM+aEmBKhCtIDoy4ONr9fG8Exl7bqhn8kpeB MI1pqjCl+mMVa8RfaqGly+B/cChk/RkOYvSuHlpEZAk5ByleGD674TPw6Jzfa/yYJT +NiKP+dTHv4QentIxwj7/TUObRyboYKRrMTxgPWY= From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87o95gqrfm.fsf@ericabrahamsen.net> <87ftqsey3f.fsf@ericabrahamsen.net> Date: Mon, 08 Apr 2019 21:30:31 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 09 Apr 2019 13:18:06 +0900") Message-ID: <87k1g3er6g.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > On Mon, 08 Apr 2019 19:01:08 -0700, Eric Abrahamsen wrote: >> Thanks very much. I'll push this now, and then see what else needs >> cleaning up. > > Thanks! I added this one (cf. ): > > Make `jump to group' work even if it is not activated (bug#33653) > > * lisp/gnus/gnus-group.el (gnus-group-goto-group): > Use gnus-newsrc-hashtb instead of gnus-newsrc-hashtb to check if > a group exists even if its server is not activated (bug#33653). Yes, I think that's better behavior. I'll wait to hear from one or two other reporters, then close this bug (and reopen new ones as necessary). From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 17:29:43 2019 Received: (at 33653) by debbugs.gnu.org; 11 Apr 2019 21:29:44 +0000 Received: from localhost ([127.0.0.1]:55232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEhGR-0003iS-Ez for submit@debbugs.gnu.org; Thu, 11 Apr 2019 17:29:43 -0400 Received: from mail-ed1-f46.google.com ([209.85.208.46]:44566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEhGP-0003iD-0I for 33653@debbugs.gnu.org; Thu, 11 Apr 2019 17:29:42 -0400 Received: by mail-ed1-f46.google.com with SMTP id d11so6508122edp.11 for <33653@debbugs.gnu.org>; Thu, 11 Apr 2019 14:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BikeMZlRhOyRY6UdfYtdhrC17NtTMPwsxWMiK3ZE118=; b=RPGei0P4pE7Sgr8WKbVabFx0KWFtBWkS77p/7cz46isF5qdO6ftbNeRLB7kuKHy9nX rTSRmHsGtzB5NOEX/srIfjHpIVjJcombteQlR+81pvx2fyVH7VT34PvaYyicnk/f57zf QM2jgSj2UKxRt+9jIcCdjQXQCSD9Br3H4fQIzKQx910q0x5xiS98egSwVWYi0EZSMI/u 4uOk9/QBhRDxnAFsjYb5Gg7PTBZkSAOX+6HnvLOVYcQf3TC5sc7D/SQdRC22Mrig09eO 1zCoonmiHbToFp/Wfi/oQDdGJ7BlrTEID3n/4phJsGBDiNwy+p0UzX1PDoGhIl9bwRZP nvgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BikeMZlRhOyRY6UdfYtdhrC17NtTMPwsxWMiK3ZE118=; b=YP2ICBO1CQ4x1fyQlIhs9Tm96/Zef1WM7aDTQ8tVjMGzpFPd6/I8/MBuwhXzNIaDRU aP26KkC1z/YzpQ/OnNbkl7dZByAh0PGEVhLL723/y+jgyZFH1zcp4uSrxviCpj0WESpp K3K/HZliHwid7/G4+O2JZDaO0i+EdcGclCwUVbvjXKUOxW9SSngJQd3YQN16Vsr43nju Z+J50L1A2GsH2n6nabOTzZTTmRS7TYtP8jnR24dz/X+qVaz9klrpGHS59anPyuhQe+S5 PZJZObpyfVulsYzEINtAujlqdRzx2waXRpKGt+zVOQBFnsZtEPUiYJ8hIYevzZBENbU0 SulA== X-Gm-Message-State: APjAAAVNkJ29ImBBcini5dCCtR+v1SZrvpbM+BiPC5U3anjhWunCWIh/ PsZjzqzslrU3gGkq+kErQdsTIQ== X-Google-Smtp-Source: APXvYqwAiPvmFgsBg2FuvEJ59XNBcRP2h4ENfgIxxCkwZ76LMYoYc8IbNHYDbJPTFrKYyWuFlqe8yA== X-Received: by 2002:a17:906:5013:: with SMTP id s19mr17219933ejj.203.1555018175118; Thu, 11 Apr 2019 14:29:35 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id f4sm3557265ejx.55.2019.04.11.14.29.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 14:29:33 -0700 (PDT) From: "Basil L. Contovounesios" To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> Date: Thu, 11 Apr 2019 22:29:23 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 5 Apr 2019 15:44:44 +0900") Message-ID: <87wok0s024.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Always-set-gnus-group-property-to-a-group-name.patch >From 5d3eb57ae62decf6316ab7c882cc6f18a9c63ae3 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Thu, 11 Apr 2019 17:24:36 +0100 Subject: [PATCH] Always set gnus-group property to a group name * lisp/gnus/gnus-group.el (gnus-group-prepare-flat-list-dead): Set gnus-group property to a group name, not active info. Simplify surrounding logic. (gnus-group-prepare-flat, gnus-group-goto-group): Use accessor macros. (gnus-group-insert-group-line, gnus-group-new-mail) (gnus-group-mark-group): Write ?\s instead of ? . (gnus-group-group-name, gnus-group-list-active): Simplify. --- lisp/gnus/gnus-group.el | 98 ++++++++++++++++++----------------------- 1 file changed, 43 insertions(+), 55 deletions(-) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index e1554cab8a..b1e4091c97 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -1320,7 +1320,7 @@ gnus-group-prepare-flat gnus-group-listed-groups) ;; List living groups, according to order in `gnus-group-list'. (dolist (g (cdr gnus-group-list)) - (setq info (nth 1 (gethash g gnus-newsrc-hashtb)) + (setq info (gnus-get-info g) group (gnus-info-group info) params (gnus-info-params info) unread (gnus-group-unread group)) @@ -1389,39 +1389,35 @@ gnus-group-prepare-flat-list-dead ;; List zombies and killed lists somewhat faster, which was ;; suggested by Jack Vinson . It does ;; this by ignoring the group format specification altogether. - (let (group) - (if (> (length groups) gnus-group-listing-limit) - (while groups - (setq group (pop groups)) - (when (gnus-group-prepare-logic - group - (or (not regexp) - (and (stringp regexp) (string-match regexp group)) - (and (functionp regexp) (funcall regexp group)))) - (add-text-properties - (point) (prog1 (1+ (point)) - (insert " " mark " *: " - (gnus-group-decoded-name group) - "\n")) - (list 'gnus-group (gethash group gnus-active-hashtb) - 'gnus-unread t - 'gnus-level level)))) - (while groups - (setq group (pop groups)) + (if (nthcdr gnus-group-listing-limit groups) + (dolist (group groups) (when (gnus-group-prepare-logic group - (or (not regexp) - (and (stringp regexp) (string-match regexp group)) - (and (functionp regexp) (funcall regexp group)))) - (gnus-group-insert-group-line - group level nil - (let ((active (gnus-active group))) - (if active - (if (zerop (cdr active)) - 0 - (- (1+ (cdr active)) (car active))) - nil)) - (gnus-method-simplify (gnus-find-method-for-group group)))))))) + (cond ((not regexp)) + ((stringp regexp) (string-match-p regexp group)) + ((functionp regexp) (funcall regexp group)))) + (add-text-properties + (point) (prog1 (1+ (point)) + (insert " " mark " *: " + (gnus-group-decoded-name group) + "\n")) + (list 'gnus-group group + 'gnus-unread t + 'gnus-level level)))) + (dolist (group groups) + (when (gnus-group-prepare-logic + group + (cond ((not regexp)) + ((stringp regexp) (string-match-p regexp group)) + ((functionp regexp) (funcall regexp group)))) + (gnus-group-insert-group-line + group level nil + (let ((active (gnus-active group))) + (and active + (if (zerop (cdr active)) + 0 + (- (cdr active) (car active) -1)))) + (gnus-method-simplify (gnus-find-method-for-group group))))))) (defun gnus-group-update-group-line () "Update the current line in the group buffer." @@ -1527,7 +1523,7 @@ gnus-group-insert-group-line (int-to-string (max 0 (- gnus-tmp-number-total number))) "*")) (gnus-tmp-subscribed - (cond ((<= gnus-tmp-level gnus-level-subscribed) ? ) + (cond ((<= gnus-tmp-level gnus-level-subscribed) ?\s) ((<= gnus-tmp-level gnus-level-unsubscribed) ?U) ((= gnus-tmp-level gnus-level-zombie) ?Z) (t ?K))) @@ -1546,7 +1542,7 @@ gnus-group-insert-group-line (gnus-tmp-moderated (if (and gnus-moderated-hashtb (gethash gnus-tmp-group gnus-moderated-hashtb)) - ?m ? )) + ?m ?\s)) (gnus-tmp-moderated-string (if (eq gnus-tmp-moderated ?m) "(m)" "")) (gnus-tmp-group-icon (gnus-group-get-icon gnus-tmp-group)) @@ -1560,15 +1556,15 @@ gnus-group-insert-group-line (if (and (numberp number) (zerop number) (cdr (assq 'tick gnus-tmp-marked))) - ?* ? )) + ?* ?\s)) (gnus-tmp-summary-live (if (and (not gnus-group-is-exiting-p) (gnus-buffer-live-p (gnus-summary-buffer-name gnus-tmp-group))) - ?* ? )) + ?* ?\s)) (gnus-tmp-process-marked (if (member gnus-tmp-group gnus-group-marked) - gnus-process-mark ? )) + gnus-process-mark ?\s)) (buffer-read-only nil) beg end gnus-tmp-header) ; passed as parameter to user-funcs. @@ -1768,10 +1764,8 @@ gnus-group-set-mode-line (defun gnus-group-group-name () "Get the name of the newsgroup on the current line." (let ((group (get-text-property (point-at-bol) 'gnus-group))) - (when group - (if (stringp group) - group - (symbol-name group))))) + (cond ((stringp group) group) + (group (symbol-name group))))) (defun gnus-group-group-level () "Get the level of the newsgroup on the current line." @@ -1791,7 +1785,7 @@ gnus-group-group-unread (defun gnus-group-new-mail (group) (if (nnmail-new-mail-p (gnus-group-real-name group)) gnus-new-mail-mark - ? )) + ?\s)) (defun gnus-group-level (group) "Return the estimated level of GROUP." @@ -1881,7 +1875,7 @@ gnus-group-mark-group (if unmark (progn (setq gnus-group-marked (delete group gnus-group-marked)) - (insert-char ? 1 t)) + (insert-char ?\s 1 t)) (setq gnus-group-marked (cons group (delete group gnus-group-marked))) (insert-char gnus-process-mark 1 t))) @@ -2561,10 +2555,10 @@ gnus-group-goto-group (when group (let ((start (point)) (active (and (or - ;; some kind of group may be only there. - (gethash group gnus-active-hashtb) - ;; all groups (but with exception) are there. - (gethash group gnus-newsrc-hashtb)) + ;; Some kind of group may be only there. + (gnus-active group) + ;; All groups (but with exception) are there. + (gnus-group-entry group)) group))) (beginning-of-line) (cond @@ -4013,15 +4007,9 @@ gnus-group-list-active (gnus-agent gnus-plugged)); If we're actually plugged, store the active file in the agent. (gnus-read-active-file))) ;; Find all groups and sort them. - (let ((groups - (sort - (hash-table-keys gnus-active-hashtb) - 'string<)) - (buffer-read-only nil) - group) + (let ((buffer-read-only nil)) (erase-buffer) - (while groups - (setq group (pop groups)) + (dolist (group (sort (hash-table-keys gnus-active-hashtb) #'string<)) (add-text-properties (point) (prog1 (1+ (point)) (insert " *: " -- 2.20.1 --=-=-= Content-Type: text/plain While looking at bug#35208 and bug#35233, I spotted one more place in gnus-group.el which sets the gnus-group text property to the group's active info instead of its name, namely in gnus-group-prepare-flat-list-dead. Is the attached patch, which includes some extra cleanup, okay to push? Or have I misunderstood something? Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 19:56:33 2019 Received: (at 33653) by debbugs.gnu.org; 11 Apr 2019 23:56:33 +0000 Received: from localhost ([127.0.0.1]:55308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjYW-0002sM-Vu for submit@debbugs.gnu.org; Thu, 11 Apr 2019 19:56:33 -0400 Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:37558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjYU-0002sC-Jl for 33653@debbugs.gnu.org; Thu, 11 Apr 2019 19:56:31 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1E3A18C0945; Thu, 11 Apr 2019 23:56:29 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-11-84.trex.outbound.svc.cluster.local [100.96.11.84]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id B32108C13B2; Thu, 11 Apr 2019 23:56:17 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 11 Apr 2019 23:56:29 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Reaction-Suffer: 029e254a1b42dd6a_1555026982525_1866696606 X-MC-Loop-Signature: 1555026982525:3867362643 X-MC-Ingress-Time: 1555026982525 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hEjY8-009IHT-Nd; Thu, 11 Apr 2019 18:56:09 -0500 Date: Fri, 12 Apr 2019 08:56:07 +0900 Message-ID: From: Katsumi Yamaoka To: Basil L. Contovounesios Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> <87wok0s024.fsf@tcd.ie> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:2FVc0XaxI17uHZOJCyHgaaRodUI= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Adam =?iso-8859-1?Q?Sj=F8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 11 Apr 2019 22:29:23 +0100, Basil L. Contovounesios wrote: > While looking at bug#35208 and bug#35233, I spotted one more place in > gnus-group.el which sets the gnus-group text property to the group's > active info instead of its name, namely in > gnus-group-prepare-flat-list-dead. I see this fix is necessary: (add-text-properties (the_beginning_of_each_group_line) (list 'gnus-group (gethash group gnus-active-hashtb) =E2=86=93 (add-text-properties (the_beginning_of_each_group_line) (list 'gnus-group group > Is the attached patch, which includes some extra cleanup, okay to push? No problem I think. Please push the patch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 07:05:12 2019 Received: (at 33653) by debbugs.gnu.org; 12 Apr 2019 11:05:12 +0000 Received: from localhost ([127.0.0.1]:55505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEtzc-0004Ww-E4 for submit@debbugs.gnu.org; Fri, 12 Apr 2019 07:05:12 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:37817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEtza-0004Wg-Ry for 33653@debbugs.gnu.org; Fri, 12 Apr 2019 07:05:11 -0400 Received: by mail-ed1-f42.google.com with SMTP id f53so6388961ede.4 for <33653@debbugs.gnu.org>; Fri, 12 Apr 2019 04:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nvhOh1fGiOJq3Xt51gaiCw3ZIauBqlQW0mD7Do1ypo8=; b=vorrpUd7wxPPFtPB3e4+riWq8Uexg1xcxAMACQh1VK3HR7moDqr7ZM9R5DzK43u621 JNkDPX8osZSvFymK1ysV9i2aiyNSjSAK9ickMq0uxGMo1GR8J9jfG0hpNZW/CyZXTeTT pvn/MGldk4i+whJsLkgn7tiDUWGIE9Aj5WCdyqjD9tWQY09jZv4WhKFaE4rzu8JnMonf 7fQnXXUijmuyw0B428h7aXUizrw7tNALeBAoO48njp/MQ7pq4e3Ksc3vNwE+T/3MF0n0 XWQyWB8/5JvQ1qL3qKyNsuDndv+arhIasHRHomnjQN1grljNSurDt2+99Zd/sKtQxM48 17nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nvhOh1fGiOJq3Xt51gaiCw3ZIauBqlQW0mD7Do1ypo8=; b=QhENMa2Pmljd+np2hFxml976SEsSSe9TVcEC6TPXr2TT4WtJr99x4ZIRuSuc95n/jm mI2R/zE9JlCpJ9mXICPXhrlAXYlKDFXivqq9Okl8g86D5RgPCSrlpcJWPV4okd3XDlSP Znrsar+AHzn4xH4MuRX7T/jGDU0lHBj0xTqfEbOwDz82Nupb2YHn/KR1e/1hUdtbEg19 MYBwRJs1azzUD0tEkUwQFlyS+KqC6aUzcA+cdf1Puu6nXeXw0lOtC5WAE57X7XsPypzR 9To9NSRNMrIF0n2Dk/27TFmm/GdTpIKx6I8QIeCSrGHZv5lKgDN3aBDl1jT+aiQ/4YLR XP8g== X-Gm-Message-State: APjAAAXiyxDfOjKnBm3vNt9gXrv1/zrGPOaWoSWyZPDbzDMBqVs9DzPz yqIKUVFpw4xOk2dXYdzX0etpzA== X-Google-Smtp-Source: APXvYqzEJJ0pXDGuFKXzYVHibVL3uNrj4+X6VetM/shRtDSawxIY6ycMK7euPkb1bJOGCPtIvPUUwg== X-Received: by 2002:a17:906:3e85:: with SMTP id a5mr31126644ejj.272.1555067105153; Fri, 12 Apr 2019 04:05:05 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id cg22sm7472552ejb.2.2019.04.12.04.05.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Apr 2019 04:05:03 -0700 (PDT) From: "Basil L. Contovounesios" To: Katsumi Yamaoka Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> <87wok0s024.fsf@tcd.ie> Date: Fri, 12 Apr 2019 12:05:02 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 12 Apr 2019 08:56:07 +0900") Message-ID: <87bm1btrfl.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Adam =?utf-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Katsumi Yamaoka writes: >> Is the attached patch, which includes some extra cleanup, okay to push? > > No problem I think. Please push the patch. Done, thanks. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 09:11:50 2019 Received: (at 33653) by debbugs.gnu.org; 22 Jun 2019 13:11:50 +0000 Received: from localhost ([127.0.0.1]:51228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hefo6-0006QQ-5E for submit@debbugs.gnu.org; Sat, 22 Jun 2019 09:11:50 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hefo4-0006QI-B2 for 33653@debbugs.gnu.org; Sat, 22 Jun 2019 09:11:48 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hefnz-0006BA-8k; Sat, 22 Jun 2019 15:11:45 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87imw4f1oo.fsf@ericabrahamsen.net> <874l7i3b8s.fsf@ericabrahamsen.net> <874l7hh43b.fsf@tullinup.koldfront.dk> <87tvfh30lr.fsf@ericabrahamsen.net> <87sgv0z7bb.fsf@tullinup.koldfront.dk> <875zruu35h.fsf@ericabrahamsen.net> <87wok0s024.fsf@tcd.ie> <87bm1btrfl.fsf@tcd.ie> Date: Sat, 22 Jun 2019 15:11:43 +0200 In-Reply-To: <87bm1btrfl.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 12 Apr 2019 12:05:02 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > Katsumi Yamaoka writes: > >>> Is the attached patch, which includes some extra cleanup, okay to push? >> >> No problem I think. Please push the patch. > > Done, thanks. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33653 Cc: Eric Abrahamsen , Bastien Guerry , Katsumi Yamaoka , 33653@debbugs.gnu.org, Adam =?utf-8?Q?Sj=C3=B8gren?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Katsumi Yamaoka writes: > >>> Is the attached patch, which includes some extra cleanup, okay to push? >> >> No problem I think. Please push the patch. > > Done, thanks. Browsing this thread, it seems like everything was resolved, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 09:11:53 2019 Received: (at control) by debbugs.gnu.org; 22 Jun 2019 13:11:53 +0000 Received: from localhost ([127.0.0.1]:51231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hefo9-0006Qg-ER for submit@debbugs.gnu.org; Sat, 22 Jun 2019 09:11:53 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hefo7-0006QY-LU for control@debbugs.gnu.org; Sat, 22 Jun 2019 09:11:51 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hefo5-0006BI-6Q for control@debbugs.gnu.org; Sat, 22 Jun 2019 15:11:51 +0200 Date: Sat, 22 Jun 2019 15:11:49 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #33653 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 33653 fixed close 33653 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 33653 fixed close 33653 27.1 quit From unknown Wed Jul 30 13:12:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 21 Jul 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator