GNU bug report logs - #33650
27.0.50; Root diffs between revisions

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 33650 <at> debbugs.gnu.org
Subject: bug#33650: 27.0.50; Root diffs between revisions
Date: Mon, 10 Dec 2018 08:29:04 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 33650 <at> debbugs.gnu.org
> Date: Mon, 10 Dec 2018 02:04:30 +0200
> 
> >> It didn't work as documented before properly implemented by the patch.
> >
> > Isn't the result user-visible change in behavior?
> 
> Yes, this fix changes user-visible behavior, so perhaps it should be
> mentioned in NEWS.

I think so too.

> > I wonder whether "fileset" needs to be mentioned at all, given your
> > changes.  When does any "fileset" come into play here?
> 
> "fileset" is essential to be mentioned in `vc-version-diff'
> whereas the text "in the repository history" is unnecessary.
> 
> >> +(defun vc-root-version-diff (_files rev1 rev2)
> >> +  "Report diffs between revisions of the whole tree in the repository history.
> >> +REV1 is an older revision, REV2 is a newer revision."
> >
> > Same here: please mention the arguments in the first sentence.
> 
> As "fileset" is essential for `vc-version-diff',
> "whole tree" is essential for `vc-root-version-diff':

OK, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.