From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Dec 2018 13:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 33598@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154384489510455 (code B ref -1); Mon, 03 Dec 2018 13:49:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Dec 2018 13:48:15 +0000 Received: from localhost ([127.0.0.1]:58774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gToa6-0002iW-PV for submit@debbugs.gnu.org; Mon, 03 Dec 2018 08:48:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gToa4-0002iJ-WB for submit@debbugs.gnu.org; Mon, 03 Dec 2018 08:48:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gToZx-0006sA-Us for submit@debbugs.gnu.org; Mon, 03 Dec 2018 08:48:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gToZx-0006rz-QV for submit@debbugs.gnu.org; Mon, 03 Dec 2018 08:48:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gToZu-0007lO-O9 for guix-patches@gnu.org; Mon, 03 Dec 2018 08:48:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gToZq-0006mY-DZ for guix-patches@gnu.org; Mon, 03 Dec 2018 08:48:02 -0500 Received: from sonic302-20.consmr.mail.ir2.yahoo.com ([87.248.110.83]:41594) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gToZp-0006kU-TL for guix-patches@gnu.org; Mon, 03 Dec 2018 08:47:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1543844876; bh=WYYiiPIet14MZbOzZ3GVdbTKhjp6+K7ndgZ5GDA5B8M=; h=To:From:Subject:Date:From:Subject; b=ZhMUc/UiNRtYbL+sxUTFxKi2TcnGEfCciXLbjS3puT0FGI8L6TVC/5DuA2ZnpcJ9YGgAuAliEYZaERHW+tqY4rF1HlADZT1tK3sNfMxhMcCECNlGJYHFtWI/x7/plhvStlqny1Z5MzrkvIkIk86Eb0y7lKGdepN5OqERXwWZYoOfEZkvMHN5lK20s+BEVqFetkt/mULf9K/+EB1ASGNAd+lp6f6G9n0x8SQwM877E4WI7wLvmXdqTMGNOfTVEG4irCM71eyYu3w4kDS3heX89GXGrEUcj7PLQmJpUF92niIPlfgag7ncFfuyHxqtKuWUE47hT8Ejk0tvzTCDSSKj7g== X-YMail-OSG: 54t.iskVM1nRJHqaNuHCrHrG._gwRxTSQllR4Vu9rhJNNQT_i6uLTgc4aOgZ2DR ZUbjiPxRxLjxvp1JK4R43SooEaJcuVP0ZutOFn337HZqD.e7VUfdfM99IWfPl1TVBopDQouL3YWa O9kuA8GhjLP61K2eOTpYNrYTLKNvLSXEAM8zR0tgaHvTNSUlJbPXvcZ0q6g6xMeE2Y4I5OmZZ3m0 BWdMNDCjwxQVgkgpRICD7D4IVTHVKOMryRRgE2WQhiM7xPmuzQXf6paGCUcXSlxmXhSADvr.JTUl C.k901J17Bx0sB6RcO1_aQDpf9k4yqzOZZTgGEB9D69ddm3Npafrr_d_zmpW4xUDmdUPOHyRK_i0 uMHCZb5cy99zF2nKHRS6njHxUcReElkXvBngCXgi5_p0oyLD31CzHy3U8rIyJCWeCqDhtadIXu34 pZChYYGFLGtSNcfBh9PGkJl1ZVENg1QL78.yUgWn1L22Wc.LTwqL1M0h253Xn7IUon1XY2gE7Zrj 53v0.Q5qfa8p0tFA5PKj3T_jddfg46U8GHtGs2h9zI842kpYbSVSHV4WIuwxzaq1xJk9Zly5A2Ju sqoExAXhdDzDZ90G_edeSdpnEOqDtDJagKKY9Q5Rm2lqicC56dTv3bZLZGnnotD21Io5iH5GavgZ eIMGEyVvp3w18Ah6zR5Wcx1dKlMNvAuB.OM99RMviOeBKShG9rrKc5eBYeA6AePzGdltWgR55F0s BpfFRwdawunwnihkJAOX2t9Kh2QvL8ssDnBqf09LvCD66Q74rqBek4RDMG7zH.fbwQAW8NCOvOmr ujk2Lnp3p370MvLcLNZ6hnclFrDpDMMPo7T1o6PyLOmJfSjkgU62aDt0Zqx02PRzKmFFcE7pASjM BUcPn47kRMMiP7C.9Iayc3uDm5AIbKjKi_QxAfbvlBTQjx1F7elvccR0caqn40Nan8YlklZ4OHY2 GTi6ros6BmTf6u9yLefBX7ebilO8CeafYw6E92Xnomfy_P8Mcj698rBDy6cgr48JU2RuXazfjeOb e4rA72XFjLK70K75pxI7UH3QojnDDaBvO8GfuALHq78Qhy57bhThNHt.w7.GjZJIjswmUPy1__T4 6qImGlzGm Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 3 Dec 2018 13:47:56 +0000 Received: from p5B221942.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.25.66]) by smtp420.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID cba66bd63d721f1f75562a94154c2dd5 for ; Mon, 03 Dec 2018 13:47:51 +0000 (UTC) From: Tim Gesthuizen Message-ID: Date: Mon, 3 Dec 2018 14:47:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8ri8gw03ePRZ0hyv10xG8hsXguz2jEw8I" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8ri8gw03ePRZ0hyv10xG8hsXguz2jEw8I Content-Type: multipart/mixed; boundary="6e0XEx4XazlYAWzA3EeHjBTXO8ymJwMtx"; protected-headers="v1" From: Tim Gesthuizen To: guix-patches@gnu.org Message-ID: Subject: Optimizations for emacs-clang-format and emacs-clang-rename --6e0XEx4XazlYAWzA3EeHjBTXO8ymJwMtx Content-Type: multipart/mixed; boundary="------------F8CB051DF55FEC9A30074256" Content-Language: en-US This is a multi-part message in MIME format. --------------F8CB051DF55FEC9A30074256 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, the attached patches add optimizations to emacs-clang-format and emacs-clang-rename: - Only package the required elisp file in the source - Add a function for generating package definitions of packages containing a single elisp file from the clang source. The patches make clear that the elisp file is the only thing required for building the package and should save some disk space as the packages do not need the full clang source tree. Tim. --------------F8CB051DF55FEC9A30074256 Content-Type: text/x-patch; name="0001-gnu-Shrink-source-for-emacs-clang-format.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Shrink-source-for-emacs-clang-format.patch" =46rom 5d85956a30ff1bed8f7c529d4b760bb609ac4ab7 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 30 Nov 2018 14:49:51 +0100 Subject: [PATCH 1/3] gnu: Shrink source for emacs-clang-format. To build emacs-clang-format only the `clang-format.el` file is needed. In= order to save disk space and make clear that this is the only file needed= modify the downloaded source to only contain `clang-format.el`. * gnu/packages/emacs.scm (emacs-clang-format): Add source snippet. * gnu/packages/emacs.scm (emacs-clang-format): Modify phases. --- gnu/packages/llvm.scm | 58 ++++++++++++++++++++++++++++--------------- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index dace546a4..e7dd6477a 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -461,28 +461,46 @@ code analysis tools.") (license license:bsd-3))) =20 (define-public emacs-clang-format - (package - (inherit clang) - (name "emacs-clang-format") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-format/clang-format.el" "clang-fo= rmat.el") - (emacs-substitute-variables "clang-format.el" - ("clang-format-executable" - (string-append clang "/bin/clang-format")))) - #t))))) - (synopsis "Format code using clang-format") - (description "This package allows to filter code through @code{clang= -format} + (let ((target-file "clang-format.el")) + (package + (inherit clang) + (name "emacs-clang-format") + (source (let ((orig (package-source clang))) + (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + ;; Copy target file to source root and delete all = other files + (copy-file (string-append "tools/clang-format/" ,t= arget-file) + ,target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,target-file))) + #t))))) + (build-system emacs-build-system) + (inputs + `(("clang" ,clang))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((clang (assoc-ref inputs "clang"))) + (emacs-substitute-variables ,target-file + ("clang-format-executable" + (string-append clang "/bin/clang-format")))) + #t))))) + (synopsis "Format code using clang-format") + (description "This package allows to filter code through @code{cla= ng-format} to fix its formatting. @code{clang-format} is a tool that formats C/C++/Obj-C code according to a set of style options, see -@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}."))) +@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")))) =20 (define-public emacs-clang-rename (package --=20 2.19.2 --------------F8CB051DF55FEC9A30074256 Content-Type: text/x-patch; name="0002-gnu-Shrink-source-for-emacs-clang-rename.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-gnu-Shrink-source-for-emacs-clang-rename.patch" =46rom 29a1992253908ea191ef0227462972f78ce20da3 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 30 Nov 2018 15:01:10 +0100 Subject: [PATCH 2/3] gnu: Shrink source for emacs-clang-rename. To build emacs-clang-rename only the `clang-rename.el` file is needed. In= order to save disk space and make clear that this is the only file needed= modify the downloaded source to only contain `clang-rename.el`. * gnu/packages/emacs.scm (emacs-clang-rename): Add source snippet. * gnu/packages/emacs.scm (emacs-clang-rename): Modify phases. --- gnu/packages/llvm.scm | 59 ++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index e7dd6477a..3eb0fb29f 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -503,23 +503,42 @@ C/C++/Obj-C code according to a set of style option= s, see @url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")))) =20 (define-public emacs-clang-rename - (package - (inherit clang) - (name "emacs-clang-rename") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-rename/clang-rename.el" "clang-re= name.el") - (emacs-substitute-variables "clang-rename.el" - ("clang-rename-binary" - (string-append clang "/bin/clang-rename")))) - #t))))) - (synopsis "Rename every occurrence of a symbol using clang-rename") - (description "This package renames every occurrence of a symbol at p= oint -using @code{clang-rename}."))) + (let ((target-file "clang-rename.el")) + (package + (inherit clang) + (name "emacs-clang-rename") + (source (let ((orig (package-source clang))) + (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append name + (package-version clang))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + (copy-file (string-append "tools/clang-rename/" ,ta= rget-file) + ,target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,target-file))) + #t))))) + (build-system emacs-build-system) + (inputs + `(("clang" ,clang))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((clang (assoc-ref inputs "clang"))) + (emacs-substitute-variables ,target-file + ("clang-rename-binary" + (string-append clang "/bin/clang-rename")))) + #t))))) + (synopsis "Rename every occurrence of a symbol using clang-rename")= + (description "This package renames every occurrence of a symbol at = point +using @code{clang-rename}.")))) --=20 2.19.2 --------------F8CB051DF55FEC9A30074256 Content-Type: text/x-patch; name="0003-gnu-Add-package-from-clang-elisp-file.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0003-gnu-Add-package-from-clang-elisp-file.patch" =46rom e4fdd028c0e71118073aee34c5976a4948b46511 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 30 Nov 2018 15:13:51 +0100 Subject: [PATCH 3/3] gnu: Add package-from-clang-elisp-file emacs-clang-format and emacs-clang-rename both are packages that are buil= d by extracting a single elisp file and building it as an emacs package. This concept is encapsulated in the package-from-clang-elisp-file function. This reduces repeating of concepts in the two package definitio= ns. * gnu/packages/llvm.scm (package-from-clang-elisp-file): New function * gnu/packages/llvm.scm (emacs-clang-format): Use new function * gnu/packages/llvm.scm (emacs-clang-rename): Use new function --- gnu/packages/llvm.scm | 138 +++++++++++++++++++----------------------- 1 file changed, 61 insertions(+), 77 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 3eb0fb29f..ad71c967a 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -460,85 +460,69 @@ code analysis tools.") "This package provides a Python binding to LLVM for use in Numba.")= (license license:bsd-3))) =20 +;;; Returns a package definition that packages an emacs-lisp file from t= he +;;; clang source. The package has the name PKGNAME and packages the file= +;;; SRC-FILE from the clang source in its root directory with the name +;;; TARGET-FILE where SUBST substitutions will be performed on the elisp= file +;;; and SYN and DESC as the package synopsis an description. +(define (package-from-clang-elisp-file pkgname src-file target-file subs= t syn desc) + (package + (inherit clang) + (name pkgname) + (source (let ((orig (package-source clang))) + (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append pkgname "-" (package-version c= lang))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + ;; Copy target file to source root and delete all ot= her files + (copy-file (string-append ,src-file) + ,target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,target-file))) + #t))))) + (build-system emacs-build-system) + (inputs + `(("clang" ,clang))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((clang (assoc-ref inputs "clang"))) + (emacs-substitute-variables ,target-file + ,subst)) + #t))))) + (synopsis syn) + (description desc))) + (define-public emacs-clang-format - (let ((target-file "clang-format.el")) - (package - (inherit clang) - (name "emacs-clang-format") - (source (let ((orig (package-source clang))) - (origin - (method (origin-method orig)) - (uri (origin-uri orig)) - (sha256 (origin-sha256 orig)) - (modules '((guix build utils) - (srfi srfi-1) - (ice-9 ftw))) - (snippet - `(begin - ;; Copy target file to source root and delete all = other files - (copy-file (string-append "tools/clang-format/" ,t= arget-file) - ,target-file) - (map delete-file-recursively - (fold delete - (scandir ".") - '("." ".." ,target-file))) - #t))))) - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (emacs-substitute-variables ,target-file - ("clang-format-executable" - (string-append clang "/bin/clang-format")))) - #t))))) - (synopsis "Format code using clang-format") - (description "This package allows to filter code through @code{cla= ng-format} + (package-from-clang-elisp-file + "emacs-clang-format" + "tools/clang-format/clang-format.el" + "clang-format.el" + '("clang-format-executable" + (string-append clang "/bin/clang-format")) + "Format code using clang-format" + "This package allows to filter code through @code{clang-format} to fix its formatting. @code{clang-format} is a tool that formats C/C++/Obj-C code according to a set of style options, see -@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")))) +@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")) =20 (define-public emacs-clang-rename - (let ((target-file "clang-rename.el")) - (package - (inherit clang) - (name "emacs-clang-rename") - (source (let ((orig (package-source clang))) - (origin - (method (origin-method orig)) - (uri (origin-uri orig)) - (sha256 (origin-sha256 orig)) - (file-name (string-append name - (package-version clang))) - (modules '((guix build utils) - (srfi srfi-1) - (ice-9 ftw))) - (snippet - `(begin - (copy-file (string-append "tools/clang-rename/" ,ta= rget-file) - ,target-file) - (map delete-file-recursively - (fold delete - (scandir ".") - '("." ".." ,target-file))) - #t))))) - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (emacs-substitute-variables ,target-file - ("clang-rename-binary" - (string-append clang "/bin/clang-rename")))) - #t))))) - (synopsis "Rename every occurrence of a symbol using clang-rename")= - (description "This package renames every occurrence of a symbol at = point -using @code{clang-rename}.")))) + (package-from-clang-elisp-file + "emacs-clang-rename" + "tools/clang-rename/clang-rename.el" + "clang-rename.el" + '("clang-rename-binary" + (string-append clang "/bin/clang-rename")) + "Rename every occurrence of a symbol using clang-rename" + "This package renames every occurrence of a symbol at point +using @code{clang-rename}.")) --=20 2.19.2 --------------F8CB051DF55FEC9A30074256-- --6e0XEx4XazlYAWzA3EeHjBTXO8ymJwMtx-- --8ri8gw03ePRZ0hyv10xG8hsXguz2jEw8I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwFNAUACgkQ0uWPaa77 GdUkugf9G0EIc6l1RM8mKKUNbggh/Orn4I9NLU6d/7X+2Pihco6q4LRTcJW2GxtN xm9oO5yCKW5G9bm2GmhiCewZ1lkoO3uR/xPMa0LLObGmeijQ8YwkSd1gUN0KPUyV MEjKCL+NKiXZfl1v2atUAAg52J8qJ3I4sWlglLnuPdVV8iute4LFbRfuP6FvrFOv t3N1G3wx162Bqd7yQjhT2Bwaqa+6FkoXP6IPkZKYY18uMDdv5EkmYAXj5puPwjX5 /P/sPnGzJz0+3j2lmu+LsM5UoVZUmfZFtga7CQc17PHSVRoOn8BifQezQNF8G81G n7H2NWgt0ROsiaTvpcp7lBPLizQ1Ig== =AB+f -----END PGP SIGNATURE----- --8ri8gw03ePRZ0hyv10xG8hsXguz2jEw8I-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 Dec 2018 22:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen , Pierre Neidhardt Cc: 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154474139432570 (code B ref 33598); Thu, 13 Dec 2018 22:50:01 +0000 Received: (at 33598) by debbugs.gnu.org; 13 Dec 2018 22:49:54 +0000 Received: from localhost ([127.0.0.1]:47022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXZnl-0008TE-O1 for submit@debbugs.gnu.org; Thu, 13 Dec 2018 17:49:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXZnj-0008T0-GN for 33598@debbugs.gnu.org; Thu, 13 Dec 2018 17:49:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXZnY-0005Q8-R5 for 33598@debbugs.gnu.org; Thu, 13 Dec 2018 17:49:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXZnN-00050t-Nd; Thu, 13 Dec 2018 17:49:33 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=32778 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gXZnN-0003T7-2V; Thu, 13 Dec 2018 17:49:29 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 13 Dec 2018 23:49:27 +0100 In-Reply-To: (Tim Gesthuizen's message of "Mon, 3 Dec 2018 14:47:48 +0100") Message-ID: <871s6l9h54.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello Tim, Sorry for the delay, it looks like these patches fell through the cracks! Tim Gesthuizen skribis: > the attached patches add optimizations to emacs-clang-format and > emacs-clang-rename: > > - Only package the required elisp file in the source > - Add a function for generating package definitions of packages > containing a single elisp file from the clang source. > > The patches make clear that the elisp file is the only thing required > for building the package and should save some disk space as the packages > do not need the full clang source tree. Nice! Pierre, could you take a look and apply them if they look good to yo= u? Thanks! Ludo=E2=80=99. From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Dec 2018 09:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154477942526473 (code B ref 33598); Fri, 14 Dec 2018 09:24:01 +0000 Received: (at 33598) by debbugs.gnu.org; 14 Dec 2018 09:23:45 +0000 Received: from localhost ([127.0.0.1]:47311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXjhB-0006sv-1e for submit@debbugs.gnu.org; Fri, 14 Dec 2018 04:23:45 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:42645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXjh9-0006sm-C6 for 33598@debbugs.gnu.org; Fri, 14 Dec 2018 04:23:43 -0500 X-Originating-IP: 86.246.35.59 Received: from mimimi (lfbn-1-799-59.w86-246.abo.wanadoo.fr [86.246.35.59]) (Authenticated sender: mail@ambrevar.xyz) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 96AC41C001C; Fri, 14 Dec 2018 09:23:41 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <871s6l9h54.fsf@gnu.org> Date: Fri, 14 Dec 2018 10:23:41 +0100 Message-ID: <87r2ekea1u.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Tim! Thanks for working on this. I'm just a little confused about the intention, so I have a few questions. The current package re-uses Clang source and packages clang-format.el / clang-rename.el only. In your implementation, you've essentially moved the 'configure phase to a snippet. As I understand it, this does not change anything. What is your reason for doing this? You are also deleting all non-required files. Which saves some space in /t= mp indeed, but this won't change anything to the store or the resulting substitutes, right? I don't mind this change, I just want to be clear about what we are trying to achieve here :) Last, the factorization into package-from-clang-elisp-file: this is a good = idea, and I would make it even more generic. Simply rename your function package-elisp-from-package (or something like that) and make "clang" a parameter. Then we can use this function in other packages like emacs-agda2-mode. Am I making sense? What do you think? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwTdp0ACgkQm9z0l6S7 zH9TjQf+IqBdKyOSMm+ZjPnLXVZfyuP6WMq5eXaPYkhuPBclcvnbc175a3FYrGGR E+Qsecgh6vUE+0i+FJKQl+LNOV6BZWbZEA0VBfrJIWKOL2U/J456PBuSienKUJtS AsVSzVGXE1hidEziO5UrrP7w+xXBoaUosKkblV/ptqLwqMfenyf2SWyrtHieQbK7 3NM2Q5xahLDBu2+PUNtxEwJyjmM9g2h718xx3nmWFaw1dQqhGpaq7Bu0l8H/4M8h cxK9x3z6N6CO9Qu5PLVn6gi0O3a/uCK1Si8SvZfGk/5AIHNSsh9YTTK3dhfJ+Vug bxss6YVI1g1XDlTsMelQLZEzTeZ7pQ== =HpwN -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Dec 2018 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154478200130588 (code B ref 33598); Fri, 14 Dec 2018 10:07:01 +0000 Received: (at 33598) by debbugs.gnu.org; 14 Dec 2018 10:06:41 +0000 Received: from localhost ([127.0.0.1]:47345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkMi-0007xI-KL for submit@debbugs.gnu.org; Fri, 14 Dec 2018 05:06:40 -0500 Received: from sonic311-30.consmr.mail.ir2.yahoo.com ([77.238.176.162]:34709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkMh-0007x2-6F for 33598@debbugs.gnu.org; Fri, 14 Dec 2018 05:06:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1544781992; bh=nkjSjppvi3CBnxUE0Snz/UHSR1Le79n55p1IzXRrr68=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=RtmczldRfSOdfyEJXvT2sBwyuvzhlRAXSutsqZtpuv7SS58BWIexMcgg0WQQ40zjWJowoWA2ebGFsE8p12xlMHNjttpRy5vAySTRfGDSP4vJU4FpF/rn0QRx2SnUnlP1oE5tMDkH8TJdwh//eAdlZ1r3bIEWzqCB0adiZiXxpmeDr+JaA4js+nYIm5PN5vA/baoslx/EWURoXfYMO93tNrSHnemk7rU74zu8lnWGsw4yYGk4jSygQ50nvg1BRlPij3CexIHsbg0brBlWX53VPEV0zbDQbBtgFPQ6oKQKmYAzmOYz+50vxLEGlPVzNnI/xUMmRfbUH/55VDDlftwZsQ== X-YMail-OSG: Q0YPAs0VM1loJBps6YDrU5AEFixB4yQifmz73MU2kuxcloSgGiujwkltPviW6Np TUUqceuCGBuRHn2_jlpm01sZBN93GsWs.0qtV.dB.plhy8MDvqLo5tijVrmkg_Dx7YZIxjqBU8CY LIM_6.RF1SYFQ_KLDQx.fp7tGHW6ccd0fz5OyrpASv3uP1wyCs9PL.4nEI7XZRKvjuM5EZuloV4J xycpLSuuBT3WWR5zMm3AD0Iyv_G7Ql4hftaZBcZw_IPdQBqthDGfdsTH8UIjZFW.vM63dxp.LPUo z2ks8KpD8r8sqUPr__oanlXYfX.ow3udubxvTM_jeYSd31ooT7ttFttP5EspnYonvsjIoLfBQ0U_ gl_yT9hjxWQOYNObEcwfr0VJd2JnFrEmeBkrbb4K.Y_ECyShIvhyWLdvsRrDFEyxPUNOoka124Im sSbGbefcjqMm_FG.3_vQuwS1uazbryxPrhLCOgU6UOMdZ4nmtqk4ULWC3JXOoj1Mkzg6iMjECR53 yeLEJbQGWEL6ujmJMlLJSBV75QKSmQt8cwqgO0gOXubimMjEs09URRsZP_kUc4BEcz4LA8DrzSmO cpz5bhcCXhsaV3S9fbOSbijTc58Ajn3sICzzpk15whHxT1vHlZeRLncHehHZ3HZeDEUzZ7rTZQ2d AKgT6FpKBekk5.Y7HnooGG8EgrhhwyFc5b25kujj6hihL.PHk4H3tkDa6Co1Yq7neKkjH79yxk3W bWgcdQZ.BXYw8J9ON6fe1gNfl3QKICwZfpgdP13tOs4fAovHr7d9dqq8tLkCbJrxVxQZF0_.9MSn LLonaEjqz7uRapC3Gm4WlheUcBQhv4PED5LMpMjtlxs7gOSHgMn4b9XWwDLpT2l6G6GgUk4atV3f _EPe3jKsYDs0XbWdrvIjBKxFNAD.._tzQiVcdWFVVA_cPz1q1Hz02iJJqmj.6.8EVzFdMuCRdciW cqEzyl89vDt4.Fp1X.t5TTTpgsviIeBOkXvBBooyDVuyfecya9_vhj4PSfVKnvX3Zi1.aj7QQLmi sqQfFyi620v.TEz4iA4BslN.j.MDEEPNj.vSkprfYrkP1rNRGPHhWLXPlgNmOlk4dul0- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Fri, 14 Dec 2018 10:06:32 +0000 Received: from p5B22171B.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.23.27]) by smtp427.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 6d50a3e1199e0335238579ebd1cabcba; Fri, 14 Dec 2018 10:06:28 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> Date: Fri, 14 Dec 2018 11:06:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87r2ekea1u.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xIXQVaBHFS5mVlLvyQFeq316V3n2h0Y5v" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xIXQVaBHFS5mVlLvyQFeq316V3n2h0Y5v Content-Type: multipart/mixed; boundary="KtXaa7t88eiMJdO05dBkRzV8KS03Y4ZmE"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt , =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: 33598@debbugs.gnu.org Message-ID: <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> In-Reply-To: <87r2ekea1u.fsf@ambrevar.xyz> --KtXaa7t88eiMJdO05dBkRzV8KS03Y4ZmE Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, On 14.12.2018 10:23, Pierre Neidhardt wrote: > In your implementation, you've essentially moved the 'configure phase t= o a > snippet. As I understand it, this does not change anything. What is y= our > reason for doing this? 1. Intention: Stripping the source with the snippet models more clearly that the building part is a function that maps the single elisp file to the final package. > You are also deleting all non-required files. Which saves some space i= n /tmp > indeed, but this won't change anything to the store or the resulting > substitutes, right? I don't mind this change, I just want to be clear = about > what we are trying to achieve here :) 2. Efficiency: I am not quite sure about this - maybe I am just wrong: As far as I understand it at first guix builds a source derivation and then the actual package derivation. Even when the source derivation is not stored in the store it can be substituted. If this is the case we can save some bandwith / disk space / build time by moving the file stripping to the source snippet. On my machine the most time during the build process is spend unpacking the clang source. > Last, the factorization into package-from-clang-elisp-file: this is a g= ood idea, > and I would make it even more generic. Simply rename your function >=20 > package-elisp-from-package >=20 > (or something like that) and make "clang" a parameter. Then we can use= this > function in other packages like emacs-agda2-mode. I also thought about this but could not find another situation where this was applicable. In which module should such a function go? What would definitely be nice is that such a function can encapsulate the emacs stuff so that we do not need any other emacs related modules imported in (gnu packages llvm) for example. > Am I making sense? What do you think? Yes. Maybe we should add some reasoning to the commit message then? Depends on whether we just want a description of the changes in a commit message or also some reasoning if things might be unclear. I think that package-elisp-from-package is a really good idea. Without seeing the function definition it is really hard to figure out why it needs the arguments it needs and what their purposes are. Maybe we want to make the arguments keyword arguments if it becomes more generic so its usage is more intuitive. The first two patches are debatable though. If there is a particular reason against them (unnecessary changing without benefits included) we might want to not merge them. Tim. --KtXaa7t88eiMJdO05dBkRzV8KS03Y4ZmE-- --xIXQVaBHFS5mVlLvyQFeq316V3n2h0Y5v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwTgKMACgkQ0uWPaa77 GdWKbwgApsTYDe9EG5r9e3k6T+9jr7yTLlSE367PxZ4q/hjqDV0pPz6708lGoZCd FMx1I0W2bBS6+L3ukpE9ROHrhRes0B7N7sKqmVYFqZRnfpGsNXKOhjUTUAKFfSl1 J4rVWmM4erXwRAUJ7vIqRkQVR6IG7oUh3i3BiQ0Uwbm3KH77+VjP+Hq10cW/JmR0 ECehESZKAvB97HoBNHYgCcRNfu2Fp2HqkAylIy0PbQvppayy/4XduUYsHnbjpsqi Bs6sR6GIjf0p6BGPsMrRFVbg9Dm1ViOHk0IFV7wLd0r1JVbd0w4ybTs6n6upffS3 1BBvwAUYQERiRxu9kYweoalV6BI6bg== =6Lp0 -----END PGP SIGNATURE----- --xIXQVaBHFS5mVlLvyQFeq316V3n2h0Y5v-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Dec 2018 10:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.1544783510496 (code B ref 33598); Fri, 14 Dec 2018 10:32:02 +0000 Received: (at 33598) by debbugs.gnu.org; 14 Dec 2018 10:31:50 +0000 Received: from localhost ([127.0.0.1]:47356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkl4-00007w-2k for submit@debbugs.gnu.org; Fri, 14 Dec 2018 05:31:50 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXkl1-00007l-W7 for 33598@debbugs.gnu.org; Fri, 14 Dec 2018 05:31:48 -0500 X-Originating-IP: 86.246.35.59 Received: from mimimi (lfbn-1-799-59.w86-246.abo.wanadoo.fr [86.246.35.59]) (Authenticated sender: mail@ambrevar.xyz) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0064840012; Fri, 14 Dec 2018 10:31:45 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> Date: Fri, 14 Dec 2018 11:31:44 +0100 Message-ID: <87lg4se6wf.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > 2. Efficiency: I am not quite sure about this - maybe I am just wrong: > As far as I understand it at first guix builds a source derivation > and then the actual package derivation. Even when the source > derivation is not stored in the store it can be substituted. If this > is the case we can save some bandwith / disk space / build time by > moving the file stripping to the source snippet. On my machine the > most time during the build process is spend unpacking the clang > source. I am not sure sure about this. Ludovic, do we have such a thing as "source substitutes"? > I also thought about this but could not find another situation where > this was applicable. Look for "emacs-build-system" in files other than emacs.scm. It's used in = quite a few places. > In which module should such a function go? Hmmm, I guess either guix/build/emacs-utils.scm, or gnu/packages/emacs.scm. > What would definitely be nice is that such a function can encapsulate > the emacs stuff so that we do not need any other emacs related modules > imported in (gnu packages llvm) for example. What emacs stuff? You mean the build system? > Yes. Maybe we should add some reasoning to the commit message then? > Depends on whether we just want a description of the changes in a commit > message or also some reasoning if things might be unclear. Well, the reasoning above is mostly a nit. What matters most is =2D Efficiency, if it really works. =2D The abstraction function. > Without seeing the function definition it is really hard to figure out > why it needs the arguments it needs and what their purposes are. > Maybe we want to make the arguments keyword arguments if it becomes more > generic so its usage is more intuitive. Sure, that's the very purpose of keyword arguments, make code readable. If= it reads like an English sentence, it's a win! > The first two patches are debatable though. If there is a particular > reason against them (unnecessary changing without benefits included) we > might want to not merge them. Even if the efficiency point is moot, the abstraction is more than welcome:= try it on at least one more package, then it will save lots of package code. I= 'm all for it! :) =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwThpEACgkQm9z0l6S7 zH+LCgf/XncnSOftZh+Kke6x3KeOrC9oMPb44MfDxgQ+iHpr/GKkLGLnbnBkj4VX lUN3bgs06n7iKU9uJFdsQaPv02KtdZEbpZxia7IPTFIYz/trA06AZLjnd4V61Tub KJ79+TKx83L/iM6wwEQcgBetd0fZzY+3q6kiWvThGVpvLWRzkTjffl+APx+sF2ei HeTqPPtFHeFBKJNfEBbOb7PqMzoBZ3zWoVI2TyPAEDkw/SgXjTzuUAa5fn50r6AH PCo4mSrKR8eHzAU4IHNjA7Gx9nodOW48CDOML2ElMGyx9Z4dynWIAfMTOjA/jL5M z2SGZSM2SyOABjXOjDHlR9xlPaGdgg== =hVp1 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Dec 2018 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15447852483286 (code B ref 33598); Fri, 14 Dec 2018 11:01:02 +0000 Received: (at 33598) by debbugs.gnu.org; 14 Dec 2018 11:00:48 +0000 Received: from localhost ([127.0.0.1]:47376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXlD6-0000qv-GZ for submit@debbugs.gnu.org; Fri, 14 Dec 2018 06:00:48 -0500 Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:33175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXlD4-0000qg-38 for 33598@debbugs.gnu.org; Fri, 14 Dec 2018 06:00:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1544785240; bh=dgs+1HBzDKMuN3obE9/yDhDXzKsUj1OcKfnbuXuz5ME=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=H0rfhorqtSmKQ6GDtyAjv67+jTZHywi4nm9wEGtpjbg27+2cRi8/a/Eb9RyQo+YBWjs9HLfnwZrwG0vtf6+dWOtaq1xRfuzTEtly5kZGf5PUZ7RclysmhnGZKkW+aaBuunko4CM9NnEhZIrsvQWfPkkLGqP8MgHCwTIiRKRud06ZvC1RhqTz6+b0HkBL6hUZ2QzbbYDEIVNs/ilROZlaUoSDpH/Lgd3GRV9WqWA0Nn6+2+YEH/thbxxiyKZX3dfT+ZAZNuGxQNhzKEIAvLkbJFo+lGFX1bCXqXDB7/Iq89oyQcvFHhEO01Ft/WaCfQTdkLB71L3HeSrcdOipfL9InA== X-YMail-OSG: 3jwoNNYVM1mlzgaeDxY2OKZ.DAbAX9DkRf8TFzvRF0dfLc9bCrAJjY5VJxpsBZD ckXOEONPcTcEDRSqVOXX1v8lP7S.UEvss0uPoKYHrEou.8uZ5mGMKSfiJPTeuRZhbXIGX9hd7jC2 Om.OrsjBJnZN7UA4dItqu2SdsN0NRc0DMqwtdf4vrzi6ACbBb02OsmVa29li9NmXgCB5FEE2A3gg OBQKSeF2_j20OKuTODAd75p3HjbEz5SLT.LG8OwVeZZlXRgFrp2OC0RYymR_7udFychguWci1EYR KuYeHUkOeb0GiHc9uI8ybaCC43ysDZf4_a4znlDxluDNANrVzNLbOkryMYBXYbwpJtYmmSHHNJT6 enVnvDxQQn2I8uTJmz2rlj2.oem0im2U1tazMXwHEJPfdHWshUtPB.AuShIcT2hOGLzXmACs71.9 DZattB6L_T7Wx8k9uZn4jxXfpiaNT4.v5_CD39C1cBmBlDCacyb7QCwBZyEueb4ayFHLqZqiiaJ. lXPEqP2Bz.ziQmwFE4MvowuZ7T_30Xt1XmLS4Qq9leYGwLLdj8q64W__0bQiIvfLehcQQ.MC.dYz BSDtjVwFrr5Dja9dgWhpzcYN01LiTtfE6AI81f6j5j6.ebpca39R._mfG726CuMqfF.FOkMkUX3O xVcC2C7TLM.AX2URxvL8dR5DSpsbGBNeKBy65nc1fxq91IclBjgI4DDWL11jLs_nEumB.pUZCuxi aIXkdr7hT_I2xieDERlanhh30ogxHZkGehSZ9cMNkcLOGyDXdvXiB_i7SC_vShmIYMxfAydkezC3 GHzNkIuftU8ChQhsT7dmHEHP3GLDNmajEe1DNhW2WsdQ4RyxN4_DMBRa.mQdSX857Sis23RKnrjf Z_f2dAo5GV99B0Gm5oi.9fH.3uRSnmRyBH7yI3MgTP_94UMrEiVdIyEUSzQxMbFr9_biMOcbBIoi o4HEdT9LMOOlv_XY5M7CbiPqhjVQ3CrECL.7Uvr7dlKSkmZBGXdeqNX8T5xKwNjCjTLBCMBsY2C6 4BtgjCzkb3DxdlCAdNZxEGGVysj2eTGdnUFmeLCrKM4wOJyhzh8j7gfv5UV4- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Fri, 14 Dec 2018 11:00:40 +0000 Received: from p5B22171B.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.23.27]) by smtp415.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID daa3da0b369e2c513546392a62f14d1c; Fri, 14 Dec 2018 11:00:36 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> Date: Fri, 14 Dec 2018 12:00:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87lg4se6wf.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="03hb0cKU9vFToNmBVgKxG6TkLospBTOzD" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --03hb0cKU9vFToNmBVgKxG6TkLospBTOzD Content-Type: multipart/mixed; boundary="4po76ZHny5ZZa7VODgeQJ3CNMTe9iNHj7"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> In-Reply-To: <87lg4se6wf.fsf@ambrevar.xyz> --4po76ZHny5ZZa7VODgeQJ3CNMTe9iNHj7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 14.12.2018 11:31, Pierre Neidhardt wrote: > I am not sure sure about this. Ludovic, do we have such a thing as "so= urce > substitutes"? I have searched a little bit in my store... Looks like its not the case. After all it seems to me that this is the purpose of a source snippet. >> I also thought about this but could not find another situation where >> this was applicable. >=20 > Look for "emacs-build-system" in files other than emacs.scm. It's used= in quite > a few places. I will have a look at it. > What emacs stuff? You mean the build system? Yes. With the abstraction we could only import the function and do not need the emacs-build-system imported in modules that have nothing to do with emacs otherwise. >> Yes. Maybe we should add some reasoning to the commit message then? >> Depends on whether we just want a description of the changes in a comm= it >> message or also some reasoning if things might be unclear. >=20 > Well, the reasoning above is mostly a nit. What matters most is > - Efficiency, if it really works. > - The abstraction function. Then I will apply the changes to the function and send new patches when I am done. Unless Ludo thinks differently we probably shouldn't merge - The first two patches if they don't work like I expected them to - The last patch in its current form until the changes are implemented and we can start to use the generic function in package definitions Tim. --4po76ZHny5ZZa7VODgeQJ3CNMTe9iNHj7-- --03hb0cKU9vFToNmBVgKxG6TkLospBTOzD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwTjVIACgkQ0uWPaa77 GdUtfggAry1g9oym3f8h8BmFZ0mGCWOrzlWWpgnlpdqpl3T8tWIn6AFDVs+RvZ5j kUy3Lg1SrLNe3ZeLG3Eet4na0d+Iawdm4yCm7Oy10ZMuIxmnLAkNgw4T8okgSyTi XTTtBGIdAyML9k2XNTfU9wXWA8kNjA76VI+HOH0KtzadagtdFLIoEBJsfDOxBIkh 2XbCRoR22y3HKVkQy1NV7sPcaKCboSxITl4XyHBakbLj/6rTxvTbWPUwzVURBmD1 DeVfxVxViK6Pxdaw+9KiO8AcnIB0bt26d4EeZ3fKJa4xf0HSuxdJ5YEjARWw5BB+ hvOr99IXa2Mv//s5AQas6/I/Ev3enw== =PFcr -----END PGP SIGNATURE----- --03hb0cKU9vFToNmBVgKxG6TkLospBTOzD-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Dec 2018 12:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154478942710685 (code B ref 33598); Fri, 14 Dec 2018 12:11:01 +0000 Received: (at 33598) by debbugs.gnu.org; 14 Dec 2018 12:10:27 +0000 Received: from localhost ([127.0.0.1]:47405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXmIV-0002mH-Ki for submit@debbugs.gnu.org; Fri, 14 Dec 2018 07:10:27 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:36369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXmIT-0002m7-3R for 33598@debbugs.gnu.org; Fri, 14 Dec 2018 07:10:25 -0500 X-Originating-IP: 86.246.35.59 Received: from mimimi (lfbn-1-799-59.w86-246.abo.wanadoo.fr [86.246.35.59]) (Authenticated sender: mail@ambrevar.xyz) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D05F81BF207; Fri, 14 Dec 2018 12:09:45 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> Date: Fri, 14 Dec 2018 13:09:44 +0100 Message-ID: <87imzwe2d3.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > I have searched a little bit in my store... Looks like its not the case. > After all it seems to me that this is the purpose of a source snippet. My understanding is that snippets are mostly meant as a Lispy way to replace patches. But hey, it's all Scheme code in the end, should it be executed before or a= fter does not make much of a difference. > Yes. With the abstraction we could only import the function and do not > need the emacs-build-system imported in modules that have nothing to do > with emacs otherwise. But you'll have to import the module where the abstraction is defined ;) =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwTnYgACgkQm9z0l6S7 zH8EVwf/UL6pjNwgTx12fNlCIMv2t6aqoEy2MbF7Nagf8o00RXZRpVG+fP6xjbwz R+5jgS9/ACZ8MJwLSOGLxmHfU09tf3SMxoVIDoKMGtf2WMcDb7LCEgGvQAtPvQHE YOvth+TQipHtIG0tUWOXhEDjHT36yA7GY9cuRtUUiyCLPNzI6m9mKphlyOj5p70M 3x+OZpaAZaBIkLYCKCfT1DFH++F0A3z+N8SEIMscKAza38RgMyrf27FB90Z34czR K6dVAK1Ksq9UZOXslq/Y8kopIcHOGEeMobFcFoe/8nzumc5/MUB5RnQygwk4I0AT P3+ZXXcMn+XuML6jtnTOqMHFxUoCZg== =7Byy -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Dec 2018 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154478959010936 (code B ref 33598); Fri, 14 Dec 2018 12:14:02 +0000 Received: (at 33598) by debbugs.gnu.org; 14 Dec 2018 12:13:10 +0000 Received: from localhost ([127.0.0.1]:47410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXmL6-0002qI-2O for submit@debbugs.gnu.org; Fri, 14 Dec 2018 07:13:08 -0500 Received: from sonic308-18.consmr.mail.ir2.yahoo.com ([77.238.178.146]:43928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXmL3-0002pj-OE for 33598@debbugs.gnu.org; Fri, 14 Dec 2018 07:13:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1544789579; bh=/BhUMoK+s8zZqOGjnyQr4aUNs0Ux4d7yqWmcgjuZH9Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=G30erF+Jrn/t1NWy9LlQwEoEOMLAB7DVJLmTM/pV1RxkiokxLgVhZM21LB/Rb/aH8pcFLvACNWR1aEyGWSnXsrjIJqDRyqVIzC9qlKoLp79f6M6oYoFKlUdGeqOXeGzySuvsWrfkoZid2rsTrzTDmkx30WcqDXtJBEAlobKssvHjEQ26AGX2JgLmsLJ5XOHwgjLMVZxsJSJoH54iU1maiHl98PdCkTHtCT1DwZAzYw/L1NOcyhAHlBS+Tl6XNehxwZk2cNbOgglDZjKPgAOjfsSdrbn0yoUuzavF3sJIsj4rsxu/amuhNucAG34PTkv1UlJM/H/kc0Wbqwy7OCC6Sg== X-YMail-OSG: 2Gmrm0MVM1mHOI2BdCzSpGG0Jmld1KZOk14ZxxvyWPAOZl8gSnOEkIUFHfnbG8c _gI2cARz6Bz4s9z6ScVkwwmxN7WU8R6ymms8SzMfoXQUot5k9YhCN8boV6MJAlSABSPhCgFIhurj byCrjyY2Qw0SDvk4WnlExMQ22liVgPvNVVuYALBMHzEeY6DewmCjXOCs6VMMl94YrrmWYjykC1ez 1.7NKdzLOwQ1ktNmd3cqjM0k99eQhbNaq794K2bN2KIrO85RjLAiU8MAPG3jWV2Xil9oHY012wQj lnHJeQU8_oJxL4OzNt_JWuCs3cUXtRYr1.KI9I56MEsfVE4CZ8CjjAMhfhWOAQh5qgYLLsekLKhu 5DBzWW1MgZ.Uua1sVJPa9m0SgZL0QUTbQhoQ2asQcC7Jtn8zmsZiERAoUqxKGyZRE4jJYNNWs.09 w5UFo14.69QMODDE3VwD9ipRY4LnBbr_GlDIA4XKHP9PqIuy_UsULNSXEtT2itW_hYdr_TBzet.o zUJEzpDdjDoiNHNpIPIiATtzg8tmosmpCPyixi1uvczmQIfAJm4s1YcSrYr7TUka.SofaaXNb1UF YCbV8En9VopP7oxYw2H71djFLHrbtL9agARDmE_xIag74eyVKG7vVBeHn3KZS9JCws4mcGGLlu4R mkjvCTNl4puG0zNxQcZ3McbHsOHBmZUfs1ynDWxBYYosrJXHQGnX6Q8tQwMBfLLetG8S2ZFkZT88 8bjv0l8q02hk.hUzSYB1Z..32WdSdSX4wRdnel1BKaxBxDpSmAH8xRhmDHrgaa9slA3T6tF8Bf8d U7Y9xJrvz2vgWFeWJXdoRp882lcspBK3aFg8SC2mJCFND5aUWf5iJPXxi18aWmKqwTJScbzrFR.h GSkKJfC.iRr8XX70CPvybSpgUQ8sbyXzatZsJ97cD4K_5bYZF0ntzJDgdqFKIgaX_GgkAhh_3gmk KGGzChRuGi7xzDcB3wuv4kl2emMejnn3EFqWT8JMvFx9RZiaFvlvpfZwlTblI8fT8tdZffDZzkFO 0KQTeRkGa4mXbjBMkNBOwr6XF3XD7i4ALMJotcJ5QTwxIRWnUosXfbGSCGZzQ Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Fri, 14 Dec 2018 12:12:59 +0000 Received: from p5B22171B.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.23.27]) by smtp403.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 56256455a153283b041180914d6410fa; Fri, 14 Dec 2018 12:12:57 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: <7ae7c5f6-5695-dfde-6c9a-2df139b2f1bc@yahoo.de> Date: Fri, 14 Dec 2018 13:12:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87imzwe2d3.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gTBfuvxTOK9kVFKILEkcrn6Hp2TC3rNRi" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gTBfuvxTOK9kVFKILEkcrn6Hp2TC3rNRi Content-Type: multipart/mixed; boundary="Pzb8xWtkIIZQ9eg3onUFXzodYSd5a9YmF"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: <7ae7c5f6-5695-dfde-6c9a-2df139b2f1bc@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> In-Reply-To: <87imzwe2d3.fsf@ambrevar.xyz> --Pzb8xWtkIIZQ9eg3onUFXzodYSd5a9YmF Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 14.12.2018 13:09, Pierre Neidhardt wrote: > But you'll have to import the module where the abstraction is defined ;= ) But you could only #:select the abstraction and don't import the rest ;) Tim. --Pzb8xWtkIIZQ9eg3onUFXzodYSd5a9YmF-- --gTBfuvxTOK9kVFKILEkcrn6Hp2TC3rNRi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwTnkEACgkQ0uWPaa77 GdWZiAf+LGl2v2T+Au94a3hfWPo6HBYdw36XyL4S+o1wdZygBKK9yyIB0xjLHNFF K3s3Mhvr1ALs9YGYr7KtRbmg8prRyiXOrmaznnEGX9czSrlhXGd9jpZ6sC5Zhyr7 2kX00QR7FS9gKt33p+dalGASbZHCfK8z89I+37fzNk8wnvwCfME9jprQuh++kIv+ 89sKrRSj4I5hB1Np2jQfBLeUDzjFCQkjLrUBe5H6KmPFX2mtEVJKZUIAuxDmNoJf RyXnBeQ6y7W5RxmpnHnv3WekfpNMEvEQ4d5LpXiqbF8jBs6oJcxk24hoTdHBIXNF Vo0Z2nBxA93VrFi30daCo0XurgZ/AA== =n+YQ -----END PGP SIGNATURE----- --gTBfuvxTOK9kVFKILEkcrn6Hp2TC3rNRi-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Dec 2018 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154524163826523 (code B ref 33598); Wed, 19 Dec 2018 17:48:01 +0000 Received: (at 33598) by debbugs.gnu.org; 19 Dec 2018 17:47:18 +0000 Received: from localhost ([127.0.0.1]:55058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZfwD-0006tj-L3 for submit@debbugs.gnu.org; Wed, 19 Dec 2018 12:47:17 -0500 Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:45084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZfwB-0006tV-Dq for 33598@debbugs.gnu.org; Wed, 19 Dec 2018 12:47:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1545241629; bh=BLuhKX3jTZBfDoiLaR+2w+o1u2QGFoQ8qNbtJ+dVgFQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=BrpIP62XMM0WXzF90Vu0bVFunNc/KEkONaEfaLJKsG49sEVQizb6SEB99XfhJAnMVUImsQTx+xVzt8c8A2hlP2AQFVQGnzb2IEfXdV+Ac2W0GT+Svt8YteY8iARJUUrC+gREMm7nVg4m0Xkd/ETKtiSJ1ZyCH8XwwS6zYEqmhxIik4gEFL58bhG6ziGfWdSiAYkocWDBXJUkVm/Nh2FydnxINdbv0UhcdrK7pyo6P6/edoP7ecfWnWNcGBtES78sUqrhcM/Un016F1vts5m4DCksJ9khlSJl1E56tIgjc9jpN0z7f+sLFW44NtYgOj9xmowwyyfZh55NGD9vbyt1CQ== X-YMail-OSG: 9xCXByYVM1lvWkoDpvRVxYJyX2v90t1Z5n5o5E55UlUW2fLnVnTDJCgJ0doKfOR pwcZRxaGOeRA34Fj5k_wPHD6cj7q.rq5hGUKGiUhIrGo6HY2aqqrGGFOZwykbQckNQuPzBVYfjG5 NJvuAkUGjKiq3mzrKTs95XKggv7XVN9fgWjevke18zNFZFTBBrk0CEJh5TZWDFTuvijkNLdwiP38 g_w1lCV.oC0zB0Ko9fd85WnEBZIs4p4lKmJhlW_DfFO89O8rwdCmGYc79P09.xtBJWSGxOu1N_YD FShvYZxJaIKqjPFyYLzoSG3Ub6enQLYVkOM496YHX1biBY1ZJOwuNQbQ953I9u5lk1fHQtGLl.QZ 8UnkliyeQGfRnJbj5zCQT1DFUcIT00KjJn5zpihqsF.pqQ8fPosjHpxOoYXcahgJxEZA.OdlsXs2 3Eff2SjRwD6egfCST5G03Od.0DbGGSuAXRp.0VeBqakT.2Xwown366W8DnsCllgE4fKU2OKDRiFc QEF_U7yzveOoB6ZRxaP.PyZPxt7yWiNA0bDQHvTk1L1mliamvW6qsCwqy1SkPUy7G7dm53e5gZjl rJj0mmYF1E90dRH.wpPMNc9cVfinhqBulQwmfE06FvO5ajHRJtnvQR4JPNmhfDIUT4akvxM2OpMn i.7QnoK7Tt3nR9eDvaaWhPiBCNefQOHBAOnx1VHWzFNbsELy52_kMZdrv3fCc6bf_wPW4uNDEgrq 3lSVbIp3ENQ1Qi_W4.oVQ9PBE4G36xl8VIkuQkojpldnW886F5A0z7KyUASous4WqCODl9armWKa cHzKArbypaZj_Z2ICe6TEjLRYMsGh6AB4V6wEuKj1odd0R3ey_o9cY6pijZbH4N1omga9jZs_pVZ E.RcdI8V0xnSBY_helsOa6VhKPW1c15nebuEGDp9Vmr6.8IIAamIePMNMMN_pAmf.gzVq8FOcaLE pNixpvNa9bSe6w5n66yTCnUS8CX5z0y6NxJxi04Lf3QnipLebrkKHiuPLI9uf9vRE3kyZ.d7Tppx oXl2klfC3OJpt123xhvrCScDF3j8MEf7wj7dEXTTOUQfuzgfnN1n2Hsp5uJWKqsjqW8F1eGFqjA- - Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Wed, 19 Dec 2018 17:47:09 +0000 Received: from p5B22188C.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.24.140]) by smtp420.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 4837b1694b3f84c3c16e3ada3eaee672; Wed, 19 Dec 2018 17:47:07 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> Date: Wed, 19 Dec 2018 18:47:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87imzwe2d3.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w2xHO9mXgJO9mWyMefqMhB3Ws21WQLcst" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --w2xHO9mXgJO9mWyMefqMhB3Ws21WQLcst Content-Type: multipart/mixed; boundary="H5Rvr43q331BUcD78S8iqH74lS24o6nmN"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> In-Reply-To: <87imzwe2d3.fsf@ambrevar.xyz> --H5Rvr43q331BUcD78S8iqH74lS24o6nmN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, I was wondering why I sended patches that do not improve anything. After some more investigation I found out again what the patches improve: The source is repacked by guix and the patches applied before the source is stored in the store. With the current guix: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 ~/src/guix/build$ tar -tf `guix build -S emacs-clang-format` =E2=94=82 cfe-6.0.1.src/ =E2=94=82 cfe-6.0.1.src/.arcconfig =E2=94=82 cfe-6.0.1.src/.clang-format =E2=94=82 cfe-6.0.1.src/.clang-tidy =E2=94=82 cfe-6.0.1.src/.gitignore =E2=94=82 cfe-6.0.1.src/CMakeLists.txt =E2=94=82 cfe-6.0.1.src/CODE_OWNERS.TXT =E2=94=82 cfe-6.0.1.src/INPUTS/ =E2=94=82 cfe-6.0.1.src/INPUTS/Cocoa_h.m =E2=94=82 cfe-6.0.1.src/INPUTS/all-std-headers.cpp =E2=94=82 cfe-6.0.1.src/INPUTS/c99-intconst-1.c =E2=94=82 cfe-6.0.1.src/INPUTS/carbon_h.c =E2=94=82 cfe-6.0.1.src/INPUTS/cfg-big-switch.c =E2=94=82 cfe-6.0.1.src/INPUTS/cfg-long-chain1.c =E2=94=82 cfe-6.0.1.src/INPUTS/cfg-long-chain2.c =E2=94=82 cfe-6.0.1.src/INPUTS/cfg-long-chain3.c =E2=94=82 cfe-6.0.1.src/INPUTS/cfg-nested-switches.c =E2=94=82 cfe-6.0.1.src/INPUTS/cfg-nested-var-scopes.cpp =E2=94=82 cfe-6.0.1.src/INPUTS/iostream.cc =E2=94=82 cfe-6.0.1.src/INPUTS/macro_pounder_fn.c =E2=94=82 cfe-6.0.1.src/INPUTS/macro_pounder_obj.c =E2=94=82 cfe-6.0.1.src/INPUTS/stpcpy-test.c =E2=94=82 cfe-6.0.1.src/INSTALL.txt =E2=94=82 cfe-6.0.1.src/LICENSE.TXT =E2=94=82 cfe-6.0.1.src/ModuleInfo.txt =E2=94=82 cfe-6.0.1.src/NOTES.txt =E2=94=82 ... < the rest of clangs sources > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 With the patches applied: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 ~/src/guix/build$ tar -tf `guix build -S emacs-clang-format` =E2=94=82 ... < repacking and building the source> =E2=94=82 successfully built /gnu/store/yds0n90idgaa65ladnpbcdjkqgs8l61d-emacs-clang-format-6.0.1.tar.= xz.drv =E2=94=82 cfe-6.0.1.src/ =E2=94=82 cfe-6.0.1.src/clang-format.el =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 So it does save disk space. I also think that these sources can be substituted (This may still not be the case though). The term source derivation is mentioned in the description of guix builds `-S` option. I would argue that I implement the file deletion in the source snippet in package-elisp-from-package. I hope this makes clear what the purpose of the first two patches is. Tim. --H5Rvr43q331BUcD78S8iqH74lS24o6nmN-- --w2xHO9mXgJO9mWyMefqMhB3Ws21WQLcst Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwahBkACgkQ0uWPaa77 GdUz3gf/WpOXFqAYXCfdO0q2IETp9QPTHPWxbYF6t0g8OTGG0Dn5woxDNmr/0/Y9 0CCIjDXQmyjz0lkIpi59DZuyzjQd5a1Eirt/d2b6YBHTkrtHHkGDYym2ox+0Rk9O zODz7TyH9IJj4361Xubk8l2Dgqc3dWvIGUTdF9y7/tQK7hqM6gmZWjQz6qf8GBfF qAkOH5UiJh8FIBbdmUuEzy9I7QIT/AakgW3tdLPafhJTLA6yrPknP/ZMZw68tIh+ Fc6jolmk17Jx+KxkRyFi9Rd1y8XlbtJbiqmD7ztOsE9l1zrwi/We5Tsx2cg3caOC 1yvWQtT92C55thwLyqD2l6XhmxCXJA== =UgvN -----END PGP SIGNATURE----- --w2xHO9mXgJO9mWyMefqMhB3Ws21WQLcst-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Dec 2018 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154524183326821 (code B ref 33598); Wed, 19 Dec 2018 17:51:02 +0000 Received: (at 33598) by debbugs.gnu.org; 19 Dec 2018 17:50:33 +0000 Received: from localhost ([127.0.0.1]:55062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZfzN-0006yX-8X for submit@debbugs.gnu.org; Wed, 19 Dec 2018 12:50:33 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:51823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZfzL-0006yN-6I for 33598@debbugs.gnu.org; Wed, 19 Dec 2018 12:50:32 -0500 X-Originating-IP: 86.246.35.59 Received: from mimimi (lfbn-1-799-59.w86-246.abo.wanadoo.fr [86.246.35.59]) (Authenticated sender: mail@ambrevar.xyz) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 62B331BF209; Wed, 19 Dec 2018 17:50:29 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> Date: Wed, 19 Dec 2018 18:50:28 +0100 Message-ID: <87ftuth0d7.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Tim, Yeah, that makes sense. Please send a new patch updated with the aforement= ioned recommendations and I'll merge. Thanks for the good work! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwahOQACgkQm9z0l6S7 zH8goAgAjkXg8gAbs+wh7ucE2oFaDXMldlUqPtEPh52JyTtg3J9/bFus998N2mNL Xdt9WTV3D+mgnnjx+zawFTVYz/7iQ6iOCdE0slesGLz1Qp1xaXGBv7XPb6tbxCsi arMfR8pwJra5XBRME6aSRsrBT4ugnGAcUZXJoM/Hv+BKUenZL7e00GQb+X92iwbJ WZ6JWRuTCkYz0uP5YHRNOIXhqZXtQvxKSZK3y9WcpjrUw1yrkNjRZhl8eo5OW1LH mtabyBq5NcIKaZXQh/lQkKy2kt1cH3HbRSbST7mVK+yPanA4jp0NfEhpvWXm4yXJ 55PJVUeZ0tmYLEVj4kFqYiYwUGqemg== =pZq3 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Jan 2019 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154663927216266 (code B ref 33598); Fri, 04 Jan 2019 22:02:02 +0000 Received: (at 33598) by debbugs.gnu.org; 4 Jan 2019 22:01:12 +0000 Received: from localhost ([127.0.0.1]:47082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfXWd-0004EF-Rl for submit@debbugs.gnu.org; Fri, 04 Jan 2019 17:01:11 -0500 Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:42515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfXWb-0004Dc-B6 for 33598@debbugs.gnu.org; Fri, 04 Jan 2019 17:01:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1546639259; bh=iY87dtX5bTb5BPUiz1uBeFa4GcSQTCJORItPpW1tWIs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=crmgCD101WTj81Uoh+yFdHARQliBk8k+/wo0E+m18dl+onL9kiYVLqOKJ5+z6Q6TkgPAYtmx4czhqrTWFqzwyAgipSifmwwnVGTCkvXVaKO6dxMVFF1fgte4bXvYUdLLyTONKNEFEjlZySuAdQjMhf9gb64EsA1MgaheKb9k6k3gf09JquMZYkb6eB+aHsOgtIGq1mE5TRBSTN8i8TEDndJq1cVh/A9bJ3vf73BLu3whEcwDechz4athwsjyWUoh9zYH10g76GyVSnUlBrzKtr2Pw7o4a7uZWcPdH2HmM5hVRYxkqa7JX4VQDggS1cbOjT8b73WDYO1riLaek/XhNA== X-YMail-OSG: JjojaWoVM1mpTzYzZr0EySb5ih7vaprpSih_IGCUwwdQt.aD9QLGyulGnoyKH1K 8R9zooFbTla2kfcP0SbySmNJPwFOA1ox_JYPlMTIfrsnYiD.w1yBAACOfHgYeejNtc065InQ8APx TdR3w2LnfiSCy6PBIYWEK3f4rNpOT6dVeIjQ7zsuRnV4NeM9WrjcvbKVowHKNE8piQ5rzSozCOzi b_BGH1l8DGJHKDAmGLhSExddGi.BWWxwo3BkloUkRSEGGPWoDIDPkzFQylVY8ZA85p3py.pPBbcW NE5ywtKIFotd5f13OzNtUMhcyCL0jsRDPFfyuXhQW4u768z.fR9fUIUPqfHYU8z53uaJ7V4I3eiz NM58AVPZekmqytn031gN9o8iVp6nROPKKY2RnZrb5ndWbca.H1RfowjbrjMz_lKjrwRL2QA0yDAK VFQDk7VCyNeMK6I0.gTxj43PF0TAl2M0idnl8esQcXo7uwMSkxTZ1X4SAQHW30Nkzp_mBvlh3ZSa CoVCiNBmEsW_fGecLKawBznBv.EdfpTkDQ4kc7TuLe0PrKi73EN6q1AX7V9n3S6rxvaURN2XlCNL lFmjI51dZczQMul3YEGUPq_3uA7bHfrynBXuXw7quCq8bQDNF5H8vFLub93gJRFhIGrYbkbEAqH. GPfbzk69Fjdc6I2m5dfZDMfzgr1wQNdOoVIywLqqUOl7cO0431AyY555RdaykYBj.fCIh2CuCDjS i3FYp57nzTX4D.KTlO7swQb2QfI9PGOXwjN9zLKk0tr1.fvvNpFHaaKAR3vHBM3W9hgsL8wJ.u2P hAIvHCht3cLAP6ZCqXjGRkRSoOFTlbOc0Bjiv9AjVac7xCdZIviadLO_WgNRMdnkR.2K2tG_cdU9 0kQ9Ki7zKHLlzkkuQHFxmXydsAo6uu7qzPbfZuPyPZnwx1LGjKLYaXbsldHZ9m1XKZDusMMu754O N8M9jsUEyiHngbxXut45VaR7t_6eCZ_zPSCpR.ZH9dCHVbk6YJAMrN0WfPijJyOXFQ8qbNTBPg0W qJzbzxDITRG__ZEsgb0ggQexLPregUiSYli9tfjdKjEcLwLdthBl2ZRdr9Ko2Rdjqc8P0XQkbAfe pJRCvddoc1t9J2b3V3faaHhFoqAG2Dc_6gSsdaWs- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Fri, 4 Jan 2019 22:00:59 +0000 Received: from p5B221793.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.23.147]) by smtp406.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 664e3d076c79e98f28661625337c8a38; Fri, 04 Jan 2019 22:00:55 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> Date: Fri, 4 Jan 2019 23:00:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87ftuth0d7.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HHC7OlMKsi8YG31tgEd3ULMJyN0oJkxyW" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HHC7OlMKsi8YG31tgEd3ULMJyN0oJkxyW Content-Type: multipart/mixed; boundary="a2E31j65zWbIWFLnWhYCay4PFMXGGdZk9"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> In-Reply-To: <87ftuth0d7.fsf@ambrevar.xyz> --a2E31j65zWbIWFLnWhYCay4PFMXGGdZk9 Content-Type: multipart/mixed; boundary="------------61A15E4AA074705CC9B85E57" Content-Language: en-US This is a multi-part message in MIME format. --------------61A15E4AA074705CC9B85E57 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.12.2018 18:50, Pierre Neidhardt wrote: > Hi Tim, >=20 > Yeah, that makes sense. Please send a new patch updated with the afore= mentioned > recommendations and I'll merge. > Thanks for the good work! >=20 Hi, I had some problems packaging the changes because I had some really weird issues with the guile modules (please validate that the patches compile as expected). They implement the discussed function for generating package definitions for packages that contain only a single elisp file from another packages source. If the attached patches compile, they can be merged and work as expected. If they cause weird errors to happen Pierre tries to find some time to investigate into this. Tim Gesthuizen. --------------61A15E4AA074705CC9B85E57 Content-Type: text/x-patch; name="0001-gnu-Shrink-source-for-emacs-clang-format.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Shrink-source-for-emacs-clang-format.patch" =46rom beec284f12caec18995be40c7a1cb9e254f83ec7 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 30 Nov 2018 14:49:51 +0100 Subject: [PATCH 1/5] gnu: Shrink source for emacs-clang-format. To build emacs-clang-format only the `clang-format.el` file is needed. In= order to save disk space and make clear that this is the only file needed= modify the downloaded source to only contain `clang-format.el`. * gnu/packages/emacs.scm (emacs-clang-format): Add source snippet. * gnu/packages/emacs.scm (emacs-clang-format): Modify phases. --- gnu/packages/llvm.scm | 58 ++++++++++++++++++++++++++++--------------- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 7eb785c36..cf7c44600 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -480,28 +480,46 @@ code analysis tools.") (license license:bsd-3))) =20 (define-public emacs-clang-format - (package - (inherit clang) - (name "emacs-clang-format") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-format/clang-format.el" "clang-fo= rmat.el") - (emacs-substitute-variables "clang-format.el" - ("clang-format-executable" - (string-append clang "/bin/clang-format")))) - #t))))) - (synopsis "Format code using clang-format") - (description "This package allows to filter code through @code{clang= -format} + (let ((target-file "clang-format.el")) + (package + (inherit clang) + (name "emacs-clang-format") + (source (let ((orig (package-source clang))) + (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + ;; Copy target file to source root and delete all = other files + (copy-file (string-append "tools/clang-format/" ,t= arget-file) + ,target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,target-file))) + #t))))) + (build-system emacs-build-system) + (inputs + `(("clang" ,clang))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((clang (assoc-ref inputs "clang"))) + (emacs-substitute-variables ,target-file + ("clang-format-executable" + (string-append clang "/bin/clang-format")))) + #t))))) + (synopsis "Format code using clang-format") + (description "This package allows to filter code through @code{cla= ng-format} to fix its formatting. @code{clang-format} is a tool that formats C/C++/Obj-C code according to a set of style options, see -@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}."))) +@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")))) =20 (define-public emacs-clang-rename (package --=20 2.20.1 --------------61A15E4AA074705CC9B85E57 Content-Type: text/x-patch; name="0002-gnu-Shrink-source-for-emacs-clang-rename.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-gnu-Shrink-source-for-emacs-clang-rename.patch" =46rom 93a8266610510e67103d06a852b97feba3d3c4e9 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 30 Nov 2018 15:01:10 +0100 Subject: [PATCH 2/5] gnu: Shrink source for emacs-clang-rename. To build emacs-clang-rename only the `clang-rename.el` file is needed. In= order to save disk space and make clear that this is the only file needed= modify the downloaded source to only contain `clang-rename.el`. * gnu/packages/emacs.scm (emacs-clang-rename): Add source snippet. * gnu/packages/emacs.scm (emacs-clang-rename): Modify phases. --- gnu/packages/llvm.scm | 59 ++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index cf7c44600..530d6599b 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -522,23 +522,42 @@ C/C++/Obj-C code according to a set of style option= s, see @url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")))) =20 (define-public emacs-clang-rename - (package - (inherit clang) - (name "emacs-clang-rename") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-rename/clang-rename.el" "clang-re= name.el") - (emacs-substitute-variables "clang-rename.el" - ("clang-rename-binary" - (string-append clang "/bin/clang-rename")))) - #t))))) - (synopsis "Rename every occurrence of a symbol using clang-rename") - (description "This package renames every occurrence of a symbol at p= oint -using @code{clang-rename}."))) + (let ((target-file "clang-rename.el")) + (package + (inherit clang) + (name "emacs-clang-rename") + (source (let ((orig (package-source clang))) + (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append name + (package-version clang))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + (copy-file (string-append "tools/clang-rename/" ,ta= rget-file) + ,target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,target-file))) + #t))))) + (build-system emacs-build-system) + (inputs + `(("clang" ,clang))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((clang (assoc-ref inputs "clang"))) + (emacs-substitute-variables ,target-file + ("clang-rename-binary" + (string-append clang "/bin/clang-rename")))) + #t))))) + (synopsis "Rename every occurrence of a symbol using clang-rename")= + (description "This package renames every occurrence of a symbol at = point +using @code{clang-rename}.")))) --=20 2.20.1 --------------61A15E4AA074705CC9B85E57 Content-Type: text/x-patch; name="0003-gnu-Add-package-from-clang-elisp-file.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0003-gnu-Add-package-from-clang-elisp-file.patch" =46rom c253da5cbb01eb0218f559559ecf16754bb824da Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 30 Nov 2018 15:13:51 +0100 Subject: [PATCH 3/5] gnu: Add package-from-clang-elisp-file emacs-clang-format and emacs-clang-rename both are packages that are buil= d by extracting a single elisp file and building it as an emacs package. This concept is encapsulated in the package-from-clang-elisp-file function. This reduces repeating of concepts in the two package definitio= ns. * gnu/packages/llvm.scm (package-from-clang-elisp-file): New function * gnu/packages/llvm.scm (emacs-clang-format): Use new function * gnu/packages/llvm.scm (emacs-clang-rename): Use new function --- gnu/packages/llvm.scm | 138 +++++++++++++++++++----------------------- 1 file changed, 61 insertions(+), 77 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 530d6599b..05147b665 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -479,85 +479,69 @@ code analysis tools.") "This package provides a Python binding to LLVM for use in Numba.")= (license license:bsd-3))) =20 +;;; Returns a package definition that packages an emacs-lisp file from t= he +;;; clang source. The package has the name PKGNAME and packages the file= +;;; SRC-FILE from the clang source in its root directory with the name +;;; TARGET-FILE where SUBST substitutions will be performed on the elisp= file +;;; and SYN and DESC as the package synopsis an description. +(define (package-from-clang-elisp-file pkgname src-file target-file subs= t syn desc) + (package + (inherit clang) + (name pkgname) + (source (let ((orig (package-source clang))) + (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append pkgname "-" (package-version c= lang))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + ;; Copy target file to source root and delete all ot= her files + (copy-file (string-append ,src-file) + ,target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,target-file))) + #t))))) + (build-system emacs-build-system) + (inputs + `(("clang" ,clang))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((clang (assoc-ref inputs "clang"))) + (emacs-substitute-variables ,target-file + ,subst)) + #t))))) + (synopsis syn) + (description desc))) + (define-public emacs-clang-format - (let ((target-file "clang-format.el")) - (package - (inherit clang) - (name "emacs-clang-format") - (source (let ((orig (package-source clang))) - (origin - (method (origin-method orig)) - (uri (origin-uri orig)) - (sha256 (origin-sha256 orig)) - (modules '((guix build utils) - (srfi srfi-1) - (ice-9 ftw))) - (snippet - `(begin - ;; Copy target file to source root and delete all = other files - (copy-file (string-append "tools/clang-format/" ,t= arget-file) - ,target-file) - (map delete-file-recursively - (fold delete - (scandir ".") - '("." ".." ,target-file))) - #t))))) - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (emacs-substitute-variables ,target-file - ("clang-format-executable" - (string-append clang "/bin/clang-format")))) - #t))))) - (synopsis "Format code using clang-format") - (description "This package allows to filter code through @code{cla= ng-format} + (package-from-clang-elisp-file + "emacs-clang-format" + "tools/clang-format/clang-format.el" + "clang-format.el" + '("clang-format-executable" + (string-append clang "/bin/clang-format")) + "Format code using clang-format" + "This package allows to filter code through @code{clang-format} to fix its formatting. @code{clang-format} is a tool that formats C/C++/Obj-C code according to a set of style options, see -@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")))) +@url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")) =20 (define-public emacs-clang-rename - (let ((target-file "clang-rename.el")) - (package - (inherit clang) - (name "emacs-clang-rename") - (source (let ((orig (package-source clang))) - (origin - (method (origin-method orig)) - (uri (origin-uri orig)) - (sha256 (origin-sha256 orig)) - (file-name (string-append name - (package-version clang))) - (modules '((guix build utils) - (srfi srfi-1) - (ice-9 ftw))) - (snippet - `(begin - (copy-file (string-append "tools/clang-rename/" ,ta= rget-file) - ,target-file) - (map delete-file-recursively - (fold delete - (scandir ".") - '("." ".." ,target-file))) - #t))))) - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (emacs-substitute-variables ,target-file - ("clang-rename-binary" - (string-append clang "/bin/clang-rename")))) - #t))))) - (synopsis "Rename every occurrence of a symbol using clang-rename")= - (description "This package renames every occurrence of a symbol at = point -using @code{clang-rename}.")))) + (package-from-clang-elisp-file + "emacs-clang-rename" + "tools/clang-rename/clang-rename.el" + "clang-rename.el" + '("clang-rename-binary" + (string-append clang "/bin/clang-rename")) + "Rename every occurrence of a symbol using clang-rename" + "This package renames every occurrence of a symbol at point +using @code{clang-rename}.")) --=20 2.20.1 --------------61A15E4AA074705CC9B85E57 Content-Type: text/x-patch; name="0004-gnu-Add-package-elisp-from-package.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0004-gnu-Add-package-elisp-from-package.patch" =46rom 51a9a6ea6615eef9ce66985bb1ad0c3ddec5c8d8 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 4 Jan 2019 22:34:36 +0100 Subject: [PATCH 4/5] gnu: Add package-elisp-from-package Add a function to generate package definitions that packages single elisp= files from other packages. * gnu/packages/emacs.scm (package-elisp-from-package): New function --- gnu/packages/emacs.scm | 64 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 52f4018c2..cdee59ce4 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -35,7 +35,7 @@ ;;; Copyright =C2=A9 2018 Sohom Bhattacharjee ;;; Copyright =C2=A9 2018 Mathieu Lirzin ;;; Copyright =C2=A9 2018 Pierre Neidhardt -;;; Copyright =C2=A9 2018 Tim Gesthuizen +;;; Copyright =C2=A9 2018, 2019 Tim Gesthuizen = ;;; Copyright =C2=A9 2018 Jack Hill ;;; Copyright =C2=A9 2018 Pierre-Antoine Rouby ;;; Copyright =C2=A9 2018 Alex Branham @@ -333,6 +333,68 @@ editor (without an X toolkit)" ) (lambda _ (invoke "mkdir" "-p" "src/deps"))))))))) =20 +;;; Returns a package definition that packages an emacs-lisp file from t= he +;;; SRCPKG source. The package has the name PKGNAME and packages the fil= e +;;; SRC-FILE from the source in its root directory as TARGET-FILE or the= +;;; basename of SRC-FILE where INPUTS NATIVE-INPUTS and PROPAGATED-INPUT= S are +;;; added as package inputs and SUBSTITUTIONS substitutions will be perf= ormed +;;; on the elisp file and SYNOPSIS and DESCRIPTION as the package synops= is and +;;; description. +(define* (package-elisp-from-package + srcpkg pkgname src-file + #:key (target-file #f) + (inputs '()) + (native-inputs '()) + (propagated-inputs '()) + (substitutions '()) + (synopsis #f) + (description #f)) + (let ((real-target-file (if target-file + target-file + (basename src-file))) + (orig (package-source srcpkg))) + (package + (inherit srcpkg) + (name pkgname) + (source (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append pkgname "-" (package-version s= rcpkg))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(begin + ;; Copy target file to source root and delete all ot= her files + (copy-file ,src-file + ,real-target-file) + (map delete-file-recursively + (fold delete + (scandir ".") + '("." ".." ,real-target-file))) + #t)))) + (build-system emacs-build-system) + (inputs inputs) + (native-inputs native-inputs) + (propagated-inputs propagated-inputs) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (emacs-substitute-variables ,real-target-file + ,substitutions) + #t))))) + (synopsis (if synopsis + synopsis + (package-synopsis srcpkg))) + (description (if description + description + (package-description srcpkg)))))) + +(export package-elisp-from-package) + =0C ;;; ;;; Emacs hacking. --=20 2.20.1 --------------61A15E4AA074705CC9B85E57 Content-Type: text/x-patch; name="0005-gnu-Use-package-elisp-from-package-for-clangs-emacs-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0005-gnu-Use-package-elisp-from-package-for-clangs-emacs-.pa"; filename*1="tch" =46rom fda77fbd33933065a3d18f4db60fbf53f5908970 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 4 Jan 2019 22:34:56 +0100 Subject: [PATCH 5/5] gnu: Use package-elisp-from-package for clangs emacs= lisp files Use package-elisp-from-package for emacs-clang-format and emacs-clang-ren= ame. Also remove package-from-clang-elisp-file as it is not needed anymore. * gnu/packages/llvm.scm (emacs-clang-format): Use package-elisp-from-pack= age * gnu/packages/llvm.scm (emacs-clang-rename): Use package-elisp-from-pack= age * gnu/packages/llvm.scm (package-from-clang-elisp-file): Remove function --- gnu/packages/llvm.scm | 70 ++++++++++--------------------------------- 1 file changed, 15 insertions(+), 55 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 05147b665..c846e2758 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -39,6 +39,7 @@ #:use-module (gnu packages gcc) #:use-module (gnu packages bootstrap) ;glibc-dynamic-linker #:use-module (gnu packages compression) + #:use-module (gnu packages emacs) #:use-module (gnu packages libffi) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -479,69 +480,28 @@ code analysis tools.") "This package provides a Python binding to LLVM for use in Numba.")= (license license:bsd-3))) =20 -;;; Returns a package definition that packages an emacs-lisp file from t= he -;;; clang source. The package has the name PKGNAME and packages the file= -;;; SRC-FILE from the clang source in its root directory with the name -;;; TARGET-FILE where SUBST substitutions will be performed on the elisp= file -;;; and SYN and DESC as the package synopsis an description. -(define (package-from-clang-elisp-file pkgname src-file target-file subs= t syn desc) - (package - (inherit clang) - (name pkgname) - (source (let ((orig (package-source clang))) - (origin - (method (origin-method orig)) - (uri (origin-uri orig)) - (sha256 (origin-sha256 orig)) - (file-name (string-append pkgname "-" (package-version c= lang))) - (modules '((guix build utils) - (srfi srfi-1) - (ice-9 ftw))) - (snippet - `(begin - ;; Copy target file to source root and delete all ot= her files - (copy-file (string-append ,src-file) - ,target-file) - (map delete-file-recursively - (fold delete - (scandir ".") - '("." ".." ,target-file))) - #t))))) - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (emacs-substitute-variables ,target-file - ,subst)) - #t))))) - (synopsis syn) - (description desc))) - (define-public emacs-clang-format - (package-from-clang-elisp-file + (package-elisp-from-package + clang "emacs-clang-format" "tools/clang-format/clang-format.el" - "clang-format.el" - '("clang-format-executable" - (string-append clang "/bin/clang-format")) - "Format code using clang-format" - "This package allows to filter code through @code{clang-format} + #:inputs `(("clang" ,clang)) + #:substitutions '("clang-format-executable" + (string-append (assoc-ref inputs "clang") "/bin/cla= ng-format")) + #:synopsis "Format code using clang-format" + #:description "This package allows to filter code through @code{clang= -format} to fix its formatting. @code{clang-format} is a tool that formats C/C++/Obj-C code according to a set of style options, see @url{http://clang.llvm.org/docs/ClangFormatStyleOptions.html}.")) =20 (define-public emacs-clang-rename - (package-from-clang-elisp-file + (package-elisp-from-package + clang "emacs-clang-rename" "tools/clang-rename/clang-rename.el" - "clang-rename.el" - '("clang-rename-binary" - (string-append clang "/bin/clang-rename")) - "Rename every occurrence of a symbol using clang-rename" - "This package renames every occurrence of a symbol at point + #:inputs `(("clang" ,clang)) + #:substitutions '("clang-rename-binary" + (string-append (assoc-ref inputs "clang") "/bin/cla= ng-rename")) + #:synopsis "Rename every occurrence of a symbol using clang-rename" + #:description "This package renames every occurrence of a symbol at p= oint using @code{clang-rename}.")) --=20 2.20.1 --------------61A15E4AA074705CC9B85E57-- --a2E31j65zWbIWFLnWhYCay4PFMXGGdZk9-- --HHC7OlMKsi8YG31tgEd3ULMJyN0oJkxyW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwv15UACgkQ0uWPaa77 GdUFAQf/SqyW3Lwqr8Y4WBSF6/SYZPeR7IR78wREZgasV7XpRm/Q0dwcTBqovvUy +WgkaPGRBXo8tvO8nowzMPwo9i9Yom4gaHXFHby17+PPanLoTYZJd446r3Gjis/Y UVxBCwueX94SoPUvrTWdPTpFE8b+3kzlRF1sfJRLKs0xOTkjuv8mlF95xZWMPq5d QhCLN1Vhp0Euwh8h6a0B+pt4vFwHsQVv3VmJqgdJ1EI5yLpN2I7IJa1HKnKH1rCr 6TgAb/nW3dKECAOCHQVluC1dnzYqDsaM1iIWUSy46T+pgRjH2NNfFBY4BzKWX7Oj KMGWlKJgWX5q/t2ch3KeWKEUTJvhfA== =KDKi -----END PGP SIGNATURE----- --HHC7OlMKsi8YG31tgEd3ULMJyN0oJkxyW-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Jan 2019 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154680122416245 (code B ref 33598); Sun, 06 Jan 2019 19:01:02 +0000 Received: (at 33598) by debbugs.gnu.org; 6 Jan 2019 19:00:24 +0000 Received: from localhost ([127.0.0.1]:49004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggDeq-0004Dx-Bc for submit@debbugs.gnu.org; Sun, 06 Jan 2019 14:00:24 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggDen-0004Dm-PY for 33598@debbugs.gnu.org; Sun, 06 Jan 2019 14:00:22 -0500 X-Originating-IP: 82.123.99.232 Received: from mimimi (lfbn-idf2-1-384-232.w82-123.abo.wanadoo.fr [82.123.99.232]) (Authenticated sender: mail@ambrevar.xyz) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3CF8140007; Sun, 6 Jan 2019 19:00:20 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> Date: Sun, 06 Jan 2019 20:00:19 +0100 Message-ID: <87wonhipbw.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Tim, I just reviewed your patch. Looks pretty good overall, thanks! A few things: > +(export package-elisp-from-package) This should be placed at the beginning of the file in the (define-module... See bootstrap.scm. > +;;; Returns a package definition that packages an emacs-lisp file from t= he > +;;; SRCPKG source. The package has the name PKGNAME and packages the file > +;;; SRC-FILE from the source in its root directory as TARGET-FILE or the > +;;; basename of SRC-FILE where INPUTS NATIVE-INPUTS and PROPAGATED-INPUT= S are > +;;; added as package inputs and SUBSTITUTIONS substitutions will be perf= ormed > +;;; on the elisp file and SYNOPSIS and DESCRIPTION as the package synops= is and > +;;; description. > +(define* (package-elisp-from-package Move the ";;;" comment to a docstring, e.g. =2D-8<---------------cut here---------------start------------->8--- (define* (package-elisp-from-package ...) "Return ..." =2D-8<---------------cut here---------------end--------------->8--- > +;;; Returns a package definition that packages an emacs-lisp file from t= he "Return", not "Returns". > +;;; SRCPKG source. The package has the name PKGNAME and packages the file Separate sentences with two spaces. > + srcpkg pkgname src-file Prefer complete words over abbreviations. Here I'd suggest source-package name source-file > + (synopsis (if synopsis > + synopsis > + (package-synopsis srcpkg))) > + (description (if description > + description > + (package-description srcpkg)))))) A more Lispy way: =2D-8<---------------cut here---------------start------------->8--- + (synopsis (or synopsis + (package-synopsis srcpkg))) + (description (or description + (package-description srcpkg)))))) =2D-8<---------------cut here---------------end--------------->8--- Regarding the function parameters, I would turn SOURCE-FILE into SOURCE-FIL= ES to make it more generic. Indeed, the Emacs library could very well be split o= ver multiple files. One thing I'm not too sure about is the replication of the structure fields= as keys. I think it's easier to ignore those and let the user define them as follows: =2D-8<---------------cut here---------------start------------->8--- (define-public emacs-clang-rename (package (inherit (package-elisp-from-package clang "emacs-clang-rename" "tools/clang-rename/clang-rename.el")) (arguments ...))) =2D-8<---------------cut here---------------end--------------->8--- Makes sense? This would also be more robust in case the package structure changes someday. Finally, rebase your changes so that you directly use the last function, no need for the clang-specific function to appear in the history of commits. Thank you again for the good work! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwyUEMACgkQm9z0l6S7 zH/mKAgAiF3SOCbout0WG9x1tLICRcYMfs6AEK62wY+XFdbsYUk6jHf5eyUO/V2H SgaSm/SePvYEqzirqENflrkM6/ftLmdl3yIos7kzAt+6wOlmqdjzCdpRwegS2WQD GepbP1WJDCaP0ZRY3B6kKb7Xmt4lOefrZqFqaXQsZ0n2spUn7vsZJpF+yWdV3h5o y4HibTP+84GgkRyKdEX1xwA0SUZAN3mKI5ly/rN3REmPtgqbz3+DXe7n0MPiY54R KcGao1DyEmoMwZiYjiSnPJT+lTluKwu4bL8/SieConX7isQ+FahPnOn9nwMeoqeY sOGVvyO4RVphsp0S2TvAI87iW66dEQ== =2Fy9 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Jan 2019 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15468101881226 (code B ref 33598); Sun, 06 Jan 2019 21:30:02 +0000 Received: (at 33598) by debbugs.gnu.org; 6 Jan 2019 21:29:48 +0000 Received: from localhost ([127.0.0.1]:47379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggFzL-0000JV-Bl for submit@debbugs.gnu.org; Sun, 06 Jan 2019 16:29:48 -0500 Received: from sonic310-13.consmr.mail.ir2.yahoo.com ([77.238.177.34]:35742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggFzD-0000JB-U3 for 33598@debbugs.gnu.org; Sun, 06 Jan 2019 16:29:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1546810170; bh=XawciInZjsLmEt2lXg+OTVL3VCeM458DjhZJdvACGoM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=FlL7KhJyaeLTteqmJUdHUEvHrOBEIRpHioH4ZsUOtRg/519AP2hBD3MY0ovHt+dyvcBYTfvmpfrhKxpAZfGu4tifY/056zVU6qJt36uoJ/3l+zOXlS1wiU5i5NdhImGHqWwEZkAumWzqPiCHMbAlFegsF43vJsH5wnnIbZ0sheZaZgo5LXxcwHJuMPwh36SPqdJDm542AVdS6Rskl2hpS7PxvNytgbJJzxE6K9FrzxqrT3LNMFW4lmPOsbXc6j+eba2KpYgLZhsrt7USwIJgINTMmAH23MBLxm3HPuU/ZPd/pt5FHj4AQ8fF1y8B++0LSdamH/Ugwissp7QdPcz2SA== X-YMail-OSG: wW4QBfEVM1nVlsW2qKQ.l04t1tDf7lVbTpNbAamJlNwlTSOl9r7yugJ86v.ub02 tND2eem9ISaydVDwXYu5UQPD6SmPHzGaSq5SETwZi3UcDo8uUEwYiuOwcKM4C9ITnjfhKW8azhV2 xIw8_I4BSs6Rm.5VSG0kq112pjVv5Qx_3hAJmQtxrOxK6.ljSbcvu5UW3icHZAsS5O38zpgI4hl7 Ao8MaCvSbDN9yORqnv6lUStcLNnywO45zUQSg1_bzpUL8hD05PrAK4wDPP79fTzyM4yMvLAhQRJX MRy2vi351l75fq9E23_Rl0KbdHKPUcdU._Lx86XorL37EhSdEYZQRg4c4n_x5uGGZy63.XFkkwr3 Rj4dic4T9yFx1qphBYWi749FZhKdy80JObnmNPBZKfyOKUxVSigKEVR1K8Ty6nlAa2VrXhh7r8MU j0nOpzHLl3xnwYF5M25An_pC4VENkld1ZI0H.MNe32Jk2KqPSNMJh60Jp9Q6.PxtTUsb.7hcP7x1 3jFkg2o71ykwKse0cRzhSVEXAAcuxSEp7uewPoFowSsXvPNome7BQyVhSpqV9RLCpkgP66m8FqaI slqIuasJHB9I_nrfM1zxWWfBx8pLhulhxvdFXnbvI0Vu7KSoV5G2a4mmKMYD6RdEmQ.31nT4kYxu vCfzFYHH02GQGE2kolqw.iYavQYfVSRzMGWfJjaCi2O9EJZBBKreudDmvBN9c8j6G1kI96supUtk VnyiiVtDWeUY.l_LjSIn1vOLwchcAt7DSP9YjaFqv.vzHWGfC2tA2MOgVTVBWN4nOlKw7L.IO8sn ANJdkSSzttxJy0XKdezdXQK08H41pSorfvrJ988swBTQ_C8mUZVE42jhv97iVrrFIs3R65oaqim_ KvgYObqirKxZ6zftc6M0Q8jjhe3zOppeB8zGMcYtBzGwbsiEul0HWxA.iSpIgFVSa1Xt__Oci0Uy 1TLJ1KXOGv9jyGUd2h.rZO6WLVorKDeHS7l_EV7G4idSUtzT_oBIQeJ8zqU3TqA60UU9TodzogPH Buuio5kBKjVDJMt5a5Gh_ZgLqKR9uGLSaAq523DqcnvjiWQnWGTU1XE8iBpC14eEbClRYxy5ZSJ9 ZDTcrDmE- Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sun, 6 Jan 2019 21:29:30 +0000 Received: from p3EE27950.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([62.226.121.80]) by smtp426.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5a8254c614db457a410d4ba24de0f33e; Sun, 06 Jan 2019 21:29:28 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> From: Tim Gesthuizen Openpgp: preference=signencrypt Autocrypt: addr=tim.gesthuizen@yahoo.de; prefer-encrypt=mutual; keydata= mQENBFrE7N0BCAC7s3lBzEf8MPAiqYjlD8Z/9TrwMEy2gLZifF3wTgIFVSOujb5gcceS3I64 qur9lCPJycxzl9dOVOBXycXZNMjSrd1VXsmBoBmR54NOOE526eCwfjkbbNhAJ5hPAwGDOvIs s2xKbIBcqfrdNnHIrZt0ohueX6RxEc6HhVTh79GwUjCaux4Jfs0NfNH+We1hyINqMKnIHQ1D kycgyFj1w0HkJiNNZSgKGNeSvqDA4gV/g9uVy25XQA/hsCBHU1teJiSfM8aVw8PA41eUsl9L pCeCTWjWwW+VQWNs5y4I3ZEpY1CAZ/C9OrbCBzNs1ssAT2aOhV3TNrOUkzPBMbLKwel1ABEB AAG0KFRpbSBHZXN0aHVpemVuIDx0aW0uZ2VzdGh1aXplbkB5YWhvby5kZT6JAVMEEwEIAD4W IQQpSILn7wFEoSuLl9rS5Y9prvsZ1QUCWsTs3QIbAwUJA8JnAAULCQgHAgYVCAkKCwIEFgID AQIeAQIXgAAKCRDS5Y9prvsZ1RzzB/ibvqnUyPlhqiLoDtIXPMGOJizkI+6YVGn5M3egrS2I W3ZHBlJMACNhhBY1dYjnFMmUJluHG0ROyS1MyA5MNf1arQXPGNGZBIJqwnHLEm8v6zhNpb9t V11o+p+Vf6fXOGMZbVYyTD7Nt8sRD3xyovd6YARsRaRWx6Jm1QKvLuade6jGFZKq4j8WSjk1 W9FZs+n845QKE7+6G4SaJZJVw+7nbOCfUtKBsSDf63G9aTFc8i6jJFPpKgu6A1xs/xRiEwqZ KBkF5+rh1JGHne3iSEgPvxxsmfQyLpW2kH7tUgFCAfipLyrz84K+E+yrfaG9zEY8jqV/D9Kt fFvADUZOkt65AQ0EWsTs3QEIAMUmXjZhfhYA5tg3aau8jB2kph2vl9geVGc+PABv90DgHUOW dKnFdXqaABLtR05amEIWKtkkE8U4Ze5FF4R8f2pMMP5QCWf0DUxI6QZ86PhP0jmyfH6QOPpM BxegjHNnD35CQvfn977lzCdZGetx/H05okwC2rlhU7e+XO62pjUjxj8CNQqbC3KGdkzn30Uv gfipAQb369FuCu83MWPWBNjgZ4eBsActr5c2S6/ltCTshkYWD9YSs/MfUyL8YblZ4xy4Nk5L sl8BKAzl16zuoo9q32Fa/L+7S+6RStY5gaBoISlQUXRrdQBuoPO72BRG3xxRpYfHQiHcKsw8 CCqlINcAEQEAAYkBPAQYAQgAJhYhBClIgufvAUShK4uX2tLlj2mu+xnVBQJaxOzdAhsMBQkD wmcAAAoJENLlj2mu+xnV+9QH/1/VcoiqpSJReuMyDAMcYHOrXhKnMLR/rDxTYn4oBNrGDXh+ vMbMJtxHpaNiFrzkd+QOWc0MU15cJRqCx2hSZNfJDaPEoHSwUs++gFSqaIkS/dLQ0LTL/DBp jKsed8FfV8Ubv/M0AoD8cixAmJLnxlt3G1gLBBkAlv0F53bIdAGJMBJZsZ+1HmzFazknGIR0 LgHZ28PK/QWPwE5gRkIzwTD+hrKJjGcBMach2ZbcAvo47rrRYW1ukbN6L1L5mvTSCh2Gitgp ewig0IiavSVkL3uWpPvAqmr9N9zk/qrHk1EgV+hzNriJhUitpMgrgZQfHYRm4LIhsmJm9TOT N3SWwT0= Message-ID: <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> Date: Sun, 6 Jan 2019 22:29:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87wonhipbw.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nkg7ECbHBShueInR8UYTzCE2v3cpQaMIH" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nkg7ECbHBShueInR8UYTzCE2v3cpQaMIH Content-Type: multipart/mixed; boundary="WJRYWDuVSr7TFOG0SoDMzgjwsaVmFMHh6"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> In-Reply-To: <87wonhipbw.fsf@ambrevar.xyz> --WJRYWDuVSr7TFOG0SoDMzgjwsaVmFMHh6 Content-Type: multipart/mixed; boundary="------------5582292179FECF82B6000E45" Content-Language: en-US This is a multi-part message in MIME format. --------------5582292179FECF82B6000E45 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Pierre, thank you for reviewing! On 06.01.19 20:00, Pierre Neidhardt wrote: > Hi Tim, >=20 > I just reviewed your patch. Looks pretty good overall, thanks! >=20 > A few things: >=20 >> +(export package-elisp-from-package) >=20 > This should be placed at the beginning of the file in the (define-modul= e... > See bootstrap.scm. As the new function can be defined with a normal lambda and not a lambda* I just used define-public. >> +;;; Returns a package definition that packages an emacs-lisp file fro= m the >> +;;; SRCPKG source. The package has the name PKGNAME and packages the = file >> +;;; SRC-FILE from the source in its root directory as TARGET-FILE or = the >> +;;; basename of SRC-FILE where INPUTS NATIVE-INPUTS and PROPAGATED-IN= PUTS are >> +;;; added as package inputs and SUBSTITUTIONS substitutions will be p= erformed >> +;;; on the elisp file and SYNOPSIS and DESCRIPTION as the package syn= opsis and >> +;;; description. >> +(define* (package-elisp-from-package >=20 > Move the ";;;" comment to a docstring, e.g. >=20 > --8<---------------cut here---------------start------------->8--- > (define* (package-elisp-from-package > ...) > "Return ..." > --8<---------------cut here---------------end--------------->8--- Done. >> +;;; Returns a package definition that packages an emacs-lisp file fro= m the >=20 > "Return", not "Returns". >=20 >> +;;; SRCPKG source. The package has the name PKGNAME and packages the = file >=20 > Separate sentences with two spaces. Done. >> + srcpkg pkgname src-file >=20 > Prefer complete words over abbreviations. Here I'd suggest >=20 > source-package > name > source-file Done. name is called package-name. >> + (synopsis (if synopsis >> + synopsis >> + (package-synopsis srcpkg))) >> + (description (if description >> + description >> + (package-description srcpkg)))))) >=20 > A more Lispy way: >=20 > --8<---------------cut here---------------start------------->8--- > + (synopsis (or synopsis > + (package-synopsis srcpkg))) > + (description (or description > + (package-description srcpkg)))))) > --8<---------------cut here---------------end--------------->8--- Obsolete as this is now moved again to the final package definition. Thanks for the tip :) I'm still quite new to scheme. > Regarding the function parameters, I would turn SOURCE-FILE into SOURCE= -FILES to > make it more generic. Indeed, the Emacs library could very well be spl= it over > multiple files. >=20 > One thing I'm not too sure about is the replication of the structure fi= elds as > keys. > I think it's easier to ignore those and let the user define them as fol= lows: >=20 > --8<---------------cut here---------------start------------->8--- > (define-public emacs-clang-rename > (package > (inherit (package-elisp-from-package > clang > "emacs-clang-rename" > "tools/clang-rename/clang-rename.el")) > (arguments ...))) > --8<---------------cut here---------------end--------------->8--- I was also thinking about this. But with stuffing everything into the function to evaluate to the final definition made multiple files difficult as it would complicate the data structure for substitutions. As this is not part of the function this is not a problem anymore. Maybe we could make the function even more generic if we would just let it modify the origin object. > Makes sense? This would also be more robust in case the package struct= ure > changes someday. >=20 > Finally, rebase your changes so that you directly use the last function= , no > need for the clang-specific function to appear in the history of commit= s. Done. Patches are attached. Tim. --------------5582292179FECF82B6000E45 Content-Type: text/x-patch; name="0001-gnu-Add-package-elisp-from-package.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-package-elisp-from-package.patch" =46rom 738d70333c5f09d4f5914e9e524999e800f9f37a Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 4 Jan 2019 22:34:36 +0100 Subject: [PATCH 1/2] gnu: Add package-elisp-from-package Add a function to generate package definitions that packages single elisp= files from other packages. * gnu/packages/emacs.scm (package-elisp-from-package): New function --- gnu/packages/emacs.scm | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index df0d6144b..a70c9dd9c 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -35,7 +35,7 @@ ;;; Copyright =C2=A9 2018 Sohom Bhattacharjee ;;; Copyright =C2=A9 2018 Mathieu Lirzin ;;; Copyright =C2=A9 2018 Pierre Neidhardt -;;; Copyright =C2=A9 2018 Tim Gesthuizen +;;; Copyright =C2=A9 2018, 2019 Tim Gesthuizen = ;;; Copyright =C2=A9 2018 Jack Hill ;;; Copyright =C2=A9 2018 Pierre-Antoine Rouby ;;; Copyright =C2=A9 2018 Alex Branham @@ -336,6 +336,36 @@ editor (without an X toolkit)" ) (lambda _ (invoke "mkdir" "-p" "src/deps"))))))))) =20 +(define-public (package-elisp-from-package + source-package package-name source-files) + "Returns a package definition that packages emacs-lisp files from the +SOURCE-PACKAGEs source. The package has the name PACKAGE-NAME and packa= ges +the files SOURCE-FILES from the source in its root directory." + (let ((orig (package-source source-package))) + (package + (inherit source-package) + (name package-name) + (build-system emacs-build-system) + (source (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append package-name "-" + (package-version source-packag= e))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(let* ((source-files (quote ,source-files)) + (basenames (map basename source-files))) + (map copy-file + source-files basenames) + (map delete-file-recursively + (fold delete + (scandir ".") + (append '("." "..") basenames))) + #t))))))) + =0C ;;; ;;; Emacs hacking. --=20 2.20.1 --------------5582292179FECF82B6000E45 Content-Type: text/x-patch; name="0002-gnu-Use-package-elisp-from-package-for-clangs-emacs-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0002-gnu-Use-package-elisp-from-package-for-clangs-emacs-.pa"; filename*1="tch" =46rom 012ba2f96b16d54e0e1c23ee912c8a219355216c Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 4 Jan 2019 22:34:56 +0100 Subject: [PATCH 2/2] gnu: Use package-elisp-from-package for clangs emacs= lisp files Use package-elisp-from-package for emacs-clang-format and emacs-clang-ren= ame. Also remove package-from-clang-elisp-file as it is not needed anymore. * gnu/packages/llvm.scm (emacs-clang-format): Use package-elisp-from-pack= age * gnu/packages/llvm.scm (emacs-clang-rename): Use package-elisp-from-pack= age * gnu/packages/llvm.scm (package-from-clang-elisp-file): Remove function --- gnu/packages/llvm.scm | 65 +++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 33 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 6dab9c519..32d7ef81b 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -8,7 +8,7 @@ ;;; Copyright =C2=A9 2018 Marius Bakke ;;; Copyright =C2=A9 2018 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2018 Efraim Flashner -;;; Copyright =C2=A9 2018 Tim Gesthuizen +;;; Copyright =C2=A9 2018, 2019 Tim Gesthuizen = ;;; Copyright =C2=A9 2018 Pierre Neidhardt ;;; ;;; This file is part of GNU Guix. @@ -39,6 +39,7 @@ #:use-module (gnu packages gcc) #:use-module (gnu packages bootstrap) ;glibc-dynamic-linker #:use-module (gnu packages compression) + #:use-module (gnu packages emacs) #:use-module (gnu packages libffi) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -481,22 +482,21 @@ code analysis tools.") =20 (define-public emacs-clang-format (package - (inherit clang) - (name "emacs-clang-format") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-format/clang-format.el" "clang-fo= rmat.el") - (emacs-substitute-variables "clang-format.el" - ("clang-format-executable" - (string-append clang "/bin/clang-format")))) - #t))))) + (inherit (package-elisp-from-package + clang + "emacs-clang-format" + '("tools/clang-format/clang-format.el"))) + (inputs `(("clang" ,clang))) + (arguments `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-k= eys) + (chmod "clang-format.el" #o644) + (emacs-substitute-variables "clang-f= ormat.el" + ("clang-format-executable" + (string-append (assoc-ref inputs = "clang") + "/bin/clang-format= "))) + #t))))) (synopsis "Format code using clang-format") (description "This package allows to filter code through @code{clang= -format} to fix its formatting. @code{clang-format} is a tool that formats @@ -505,22 +505,21 @@ C/C++/Obj-C code according to a set of style option= s, see =20 (define-public emacs-clang-rename (package - (inherit clang) - (name "emacs-clang-rename") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-rename/clang-rename.el" "clang-re= name.el") - (emacs-substitute-variables "clang-rename.el" - ("clang-rename-binary" - (string-append clang "/bin/clang-rename")))) - #t))))) + (inherit (package-elisp-from-package + clang + "emacs-clang-rename" + '("tools/clang-rename/clang-rename.el"))) + (inputs `(("clang" ,clang))) + (arguments `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (chmod "clang-rename.el" #o644) + (emacs-substitute-variables "clang-rename.el" + ("clang-rename-binary" + (string-append (assoc-ref inputs "clang") + "/bin/clang-rename"))) + #t))))) (synopsis "Rename every occurrence of a symbol using clang-rename") (description "This package renames every occurrence of a symbol at p= oint using @code{clang-rename}."))) --=20 2.20.1 --------------5582292179FECF82B6000E45-- --WJRYWDuVSr7TFOG0SoDMzgjwsaVmFMHh6-- --nkg7ECbHBShueInR8UYTzCE2v3cpQaMIH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwyczcACgkQ0uWPaa77 GdVrGQf/YcdROgHmaXWesMbXnXj8AQfnXK1F6M43P092xtD2n9cAFkM294t/yLS4 abNoOODlbigsJ7cUxtYInEg8+vRD3HoFMAebCSAgE1uFM3am5UC53QeEy0o199fh 6zvq4MxZNAWAmAn12NVHpEOp6Yq0haoChkt4kW+bAfhhvir58Qg57gELjyaaZGZK Ev4EFJ0qtRHJ71QAPxxFqnVZol+8eLKp3fPaNIMiYcbVN2O+0zJ8YZnFkm69gZKx Dsa0HIiVkUxesPzF6wvBhnZpOw8WR4+2f+wQ6oV6ptrElGighGsk7ff2WBCSKNrv wWfV7t1S382ZmHpbfZiiS22FlNq1wA== =JByk -----END PGP SIGNATURE----- --nkg7ECbHBShueInR8UYTzCE2v3cpQaMIH-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jan 2019 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15468688828599 (code B ref 33598); Mon, 07 Jan 2019 13:49:02 +0000 Received: (at 33598) by debbugs.gnu.org; 7 Jan 2019 13:48:02 +0000 Received: from localhost ([127.0.0.1]:47736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggVG4-0002EL-To for submit@debbugs.gnu.org; Mon, 07 Jan 2019 08:48:02 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggVG2-0002EB-Mn for 33598@debbugs.gnu.org; Mon, 07 Jan 2019 08:47:59 -0500 X-Originating-IP: 86.246.56.59 Received: from mimimi (lfbn-1-822-59.w86-246.abo.wanadoo.fr [86.246.56.59]) (Authenticated sender: mail@ambrevar.xyz) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id CE1EAC0014; Mon, 7 Jan 2019 13:47:56 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> Date: Mon, 07 Jan 2019 14:47:55 +0100 Message-ID: <878szwinp0.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Merged! > : > +;;; Returns a package definition that packages an emacs-lisp file fr= om the > :=20 > : "Return", not "Returns". You forgot this! Anyways, I was confused by the docstring, so I took the liberty to simplify it a little bit to the following: "Return a package definition named PACKAGE-NAME that packages the Emacs L= isp SOURCE-FILES found in SOURCE-PACKAGE." If you think this is missing something, let me know and I'll fix it. Thanks for your great contribution! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwzWIsACgkQm9z0l6S7 zH/yaQf+NRN5NBYomuv0MxkDLLoliD8xak7X+onFXY0AtABDAp99WbRFUXYzLWmD SCbGaJYS45kdmTkp4MHz0FhGV4DSRqe9vT88cNrmU9agR+A42KgwnK6h6pgOsHF8 /mwtXrA/6QSeOJam2StWUj4qLbdagRI7RNEvzDpgk3yvP75WMo9iDFSRX60ZLRAh 5l2h9CVSM9jVC8uCgLo86LRTHuuBGHR41eewxIgtTo44UPkO+9MushUjg/IXwwng zmH4B+VXuhkFJ5dIYGHoKj+CYXiWGZFcRSQDWLHF6JZEuhLgVwXlc/yOK1rPDAvc vhlOF6QYoU2zvZ8+61Y//Jyou27bQw== =whMr -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jan 2019 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15468696439763 (code B ref 33598); Mon, 07 Jan 2019 14:01:02 +0000 Received: (at 33598) by debbugs.gnu.org; 7 Jan 2019 14:00:43 +0000 Received: from localhost ([127.0.0.1]:47740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggVSI-0002XK-Lb for submit@debbugs.gnu.org; Mon, 07 Jan 2019 09:00:43 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:55719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggVSH-0002XB-4v for 33598@debbugs.gnu.org; Mon, 07 Jan 2019 09:00:37 -0500 Received: from mimimi (lfbn-1-822-59.w86-246.abo.wanadoo.fr [86.246.56.59]) (Authenticated sender: mail@ambrevar.xyz) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 561B1200013; Mon, 7 Jan 2019 14:00:35 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <878szwinp0.fsf@ambrevar.xyz> Date: Mon, 07 Jan 2019 15:00:34 +0100 Message-ID: <877efgin3x.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Oops, got too fast: there is a circular dependency problem because emacs.scm depends on llvm.scm. The function must be moved to some other place. I'll place it in emacs uti= ls or something. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwzW4IACgkQm9z0l6S7 zH8gSAf/QzBupxeKKHaI+Os7HFsF2otQrkmJq1KSz+wEdJ8T8/5j4hvbSiN9onja P4aeQLXaSYimnNa028S/HIEl9eZ0eK6RoyAbcawWPZ6Ttd/46muAGdBg3NEQ+WX2 5edgf7sXFmKoyjOgxEYPunTbL4FB8QuHZkZcmvh9vXyJZR5SXrtBnKbBwA3n30mq ND4vJp2iA3DThx3HwJiwno9kT7sJdZF4BzR8rg1fT8naB5gxzwQmjEfMHD36H5n7 49XaY83y6fs/zFagUHTE53qsHP4aA7wan62yWHIR5gE+L2LkhcsvpFYVgjLrt2H6 EOG8mdXEJtrJ8U04gAzhIMT5RFrABg== =r+Ky -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jan 2019 14:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154687009910586 (code B ref 33598); Mon, 07 Jan 2019 14:09:01 +0000 Received: (at 33598) by debbugs.gnu.org; 7 Jan 2019 14:08:19 +0000 Received: from localhost ([127.0.0.1]:47744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggVZj-0002kg-07 for submit@debbugs.gnu.org; Mon, 07 Jan 2019 09:08:19 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:37935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggVZg-0002kU-P6 for 33598@debbugs.gnu.org; Mon, 07 Jan 2019 09:08:17 -0500 X-Originating-IP: 86.246.56.59 Received: from mimimi (lfbn-1-822-59.w86-246.abo.wanadoo.fr [86.246.56.59]) (Authenticated sender: mail@ambrevar.xyz) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 42F82240012; Mon, 7 Jan 2019 14:08:13 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <877efgin3x.fsf@ambrevar.xyz> Date: Mon, 07 Jan 2019 15:08:12 +0100 Message-ID: <875zv0imr7.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hmmm... Not too sure where to put package-elisp-from-package. I see the following options: =2D build-system/emacs.scm, but is it our policy? =2D Or a separate file, but which one? =20=20 @Ludo? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwzXUwACgkQm9z0l6S7 zH+4Gwf8CkO+lz/Cj0UNf36EXkvl1fe0Sz5D8JD0CZk00fwJnqZxvfrHVrXDt/lc ZiG1P9lRJJIOz/vaxz85qh588uBgZxcrU7ig79oQ1jT2ZY8egpSx8E5LAaIoCyIr onYjth9WBfFxtIdktcxjvZI4/ZKl956QI+GaREQXAK2tpQXnwo6Xs/Bo95Dek13b Yu8rMKFigDv7t6OZt4cvpaQOWWw4chq/tMIA7ckkRkoOxlHGBmRKsj8JHHrH3GhJ AJl6z011n9p2KLkMApxB7KFRsQBvWbvuXWjf6nNh3hKs3y/9UHseeFsSk9TQkHUt lQGDBsaa6OJzCrs9R18rq434U5+jVQ== =sPVo -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jan 2019 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154687545720294 (code B ref 33598); Mon, 07 Jan 2019 15:38:01 +0000 Received: (at 33598) by debbugs.gnu.org; 7 Jan 2019 15:37:37 +0000 Received: from localhost ([127.0.0.1]:48868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggWy9-0005HG-Ht for submit@debbugs.gnu.org; Mon, 07 Jan 2019 10:37:37 -0500 Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:43550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggWy6-0005H1-TF for 33598@debbugs.gnu.org; Mon, 07 Jan 2019 10:37:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1546875448; bh=V/mM0pbqYX/bHLz/y4gcNjJyTM2bOMDl3K/CXBCvLrw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=m/r15dsQQwShwB8mwGo8M/3y1+O85sK54ojj8jdHUZnJrqYMRgiefQvQ07LqSOhdOyxmPEqxudqOkgrLnrlzHNG/0rY3qYgzYAB5eRabQlZfz22z4DQT45D2uSeZsDoIyyKphiwr+NuyoA7oMC1NCX6fkRcAzMySNxrdRY7l3+IzJrrvodUIPuip5iUYfPPwfcWWROgaCLjoPrmqpoEAz1VhTUus2k4Qw6RFXf83YsUiNkUYfJZW/1gyUWeHQ82M3ZFKCjn7/zqh8ZFxTtGUKh3v8QgkyytZ4Fno1D5qBGDMUXnx234k/6vilQIRotBFjikY8mppbCIjl7QutyX86A== X-YMail-OSG: 2GlTkLkVM1mctoiN_tsWS.MyD2bdNxWSNgCKID8s3DGxjTxoswDyQIEC_yLp0kh CUUUOEZDr0k.wc6Phpl2ArIw5a0W6LK4XuXBcfnMi6.uzP4iJ69cmZQRhWgPcZ1bNGdMz54gvLmd PYjreTm8bYqri1vw_3c5aOgJMhiwmO1.WG.d2glLjkJxz3twf2PSUvHAs2jXOK8oe_QuRUw7wu1W fsaMk607XF94GNgK_ZNZBCiWONWE3XQA2AIJU_uO0UNOncoL02Q0OxYpZoPN2gZiorMD3Iq91mLQ GPbkpVmw08VW.EFbd8MSTQf6xcU8aCe6RLUlyOYWBORU02N6LoSMGbrke2VHx2wkEmj7JIAGRm0c V.Y5idHAp.wS75Zcev4Xxw2FtVioK36PGZ_rFbe4GTMPnNM7M4I23Un2pLpt7Hkzuh_BXqdcmXzL y9PCIJjt9.QCzDyrkCCTvDU9Yja63kFxHjbc9dcCf6KuHUXM1PpTj2hfNu6JMTYauFerk9RkSuPu AoM_yVbIvz1pHDANuGP8LDpSlOT9myHv0Hyid_HUR2HGmgQ0vn_W19h0yfwg6DCnOxdZQDfCkEjU VBSgmM3tjO.oB3LuRFOdwl4cCDtflUnaX3rkm5LMMv4U8P87Wgr48Oht2gpqrwr6AoU8oeU_sv0m g2ADBkXfZFFyLaZx9gqp5lfeJXBcoV5MMerUcjFjKbCPU5oZ0lrjHWKq24D_rGPGMBvBW8fw3idY zS7w2rbtBCe.n2nDJQUx96IHf06gp7GQBsODFvPkByev8u6zF3dtzKoKlUjBDDAn4RZ7.eLhK7oO fTwrvs1bt9P45P5a13.qUGpmTomgEtQ12Pw2Evwjs4iTyEFNCyACBrZdXKH6mmUdYXfZ1QG3oubJ j9GIF7R2AKjk3m9Xgt_V1YLNnoS0iS.pYXm52K6rJa6YrR7mJOBvqxYR0SAl4dQplwpVHOo62z85 Qs2ExsPLRlV3auJS55ZZmr_rXCiyeCle9XxScdMRY5fa24tgdsbUcWWWk38Qm8Io0mxJ2FucEFYY ibFKRsKCKLFvEmuJdrWu9uagA.s6VFsbWsNEyNRqmZd2Ka4JLyFnBWyju9GU- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Mon, 7 Jan 2019 15:37:28 +0000 Received: from p5B2219AC.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.25.172]) by smtp426.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 77068566ab748484df138af6be31a7a9; Mon, 07 Jan 2019 15:37:24 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> From: Tim Gesthuizen Openpgp: preference=signencrypt Autocrypt: addr=tim.gesthuizen@yahoo.de; prefer-encrypt=mutual; keydata= mQENBFrE7N0BCAC7s3lBzEf8MPAiqYjlD8Z/9TrwMEy2gLZifF3wTgIFVSOujb5gcceS3I64 qur9lCPJycxzl9dOVOBXycXZNMjSrd1VXsmBoBmR54NOOE526eCwfjkbbNhAJ5hPAwGDOvIs s2xKbIBcqfrdNnHIrZt0ohueX6RxEc6HhVTh79GwUjCaux4Jfs0NfNH+We1hyINqMKnIHQ1D kycgyFj1w0HkJiNNZSgKGNeSvqDA4gV/g9uVy25XQA/hsCBHU1teJiSfM8aVw8PA41eUsl9L pCeCTWjWwW+VQWNs5y4I3ZEpY1CAZ/C9OrbCBzNs1ssAT2aOhV3TNrOUkzPBMbLKwel1ABEB AAG0KFRpbSBHZXN0aHVpemVuIDx0aW0uZ2VzdGh1aXplbkB5YWhvby5kZT6JAVMEEwEIAD4W IQQpSILn7wFEoSuLl9rS5Y9prvsZ1QUCWsTs3QIbAwUJA8JnAAULCQgHAgYVCAkKCwIEFgID AQIeAQIXgAAKCRDS5Y9prvsZ1RzzB/ibvqnUyPlhqiLoDtIXPMGOJizkI+6YVGn5M3egrS2I W3ZHBlJMACNhhBY1dYjnFMmUJluHG0ROyS1MyA5MNf1arQXPGNGZBIJqwnHLEm8v6zhNpb9t V11o+p+Vf6fXOGMZbVYyTD7Nt8sRD3xyovd6YARsRaRWx6Jm1QKvLuade6jGFZKq4j8WSjk1 W9FZs+n845QKE7+6G4SaJZJVw+7nbOCfUtKBsSDf63G9aTFc8i6jJFPpKgu6A1xs/xRiEwqZ KBkF5+rh1JGHne3iSEgPvxxsmfQyLpW2kH7tUgFCAfipLyrz84K+E+yrfaG9zEY8jqV/D9Kt fFvADUZOkt65AQ0EWsTs3QEIAMUmXjZhfhYA5tg3aau8jB2kph2vl9geVGc+PABv90DgHUOW dKnFdXqaABLtR05amEIWKtkkE8U4Ze5FF4R8f2pMMP5QCWf0DUxI6QZ86PhP0jmyfH6QOPpM BxegjHNnD35CQvfn977lzCdZGetx/H05okwC2rlhU7e+XO62pjUjxj8CNQqbC3KGdkzn30Uv gfipAQb369FuCu83MWPWBNjgZ4eBsActr5c2S6/ltCTshkYWD9YSs/MfUyL8YblZ4xy4Nk5L sl8BKAzl16zuoo9q32Fa/L+7S+6RStY5gaBoISlQUXRrdQBuoPO72BRG3xxRpYfHQiHcKsw8 CCqlINcAEQEAAYkBPAQYAQgAJhYhBClIgufvAUShK4uX2tLlj2mu+xnVBQJaxOzdAhsMBQkD wmcAAAoJENLlj2mu+xnV+9QH/1/VcoiqpSJReuMyDAMcYHOrXhKnMLR/rDxTYn4oBNrGDXh+ vMbMJtxHpaNiFrzkd+QOWc0MU15cJRqCx2hSZNfJDaPEoHSwUs++gFSqaIkS/dLQ0LTL/DBp jKsed8FfV8Ubv/M0AoD8cixAmJLnxlt3G1gLBBkAlv0F53bIdAGJMBJZsZ+1HmzFazknGIR0 LgHZ28PK/QWPwE5gRkIzwTD+hrKJjGcBMach2ZbcAvo47rrRYW1ukbN6L1L5mvTSCh2Gitgp ewig0IiavSVkL3uWpPvAqmr9N9zk/qrHk1EgV+hzNriJhUitpMgrgZQfHYRm4LIhsmJm9TOT N3SWwT0= Message-ID: Date: Mon, 7 Jan 2019 16:37:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <878szwinp0.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV Content-Type: multipart/mixed; boundary="bBeAsaqqwKCUODe2IoR55PgFp6vNxY8iq"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> In-Reply-To: <878szwinp0.fsf@ambrevar.xyz> --bBeAsaqqwKCUODe2IoR55PgFp6vNxY8iq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07.01.19 14:47, Pierre Neidhardt wrote: > Merged! >=20 >> : > +;;; Returns a package definition that packages an emacs-lisp file= from the >> :=20 >> : "Return", not "Returns". >=20 > You forgot this! Anyways, I was confused by the docstring, so I took t= he > liberty to simplify it a little bit to the following: Whoops... Maybe I did not reformat the patches. > "Return a package definition named PACKAGE-NAME that packages the Ema= cs Lisp > SOURCE-FILES found in SOURCE-PACKAGE." >=20 > If you think this is missing something, let me know and I'll fix it. Much better. That was probably just to straight forward for me. > Oops, got too fast: there is a circular dependency problem because emac= s.scm > depends on llvm.scm. > The function must be moved to some other place. I'll place it in emacs= utils or > something. So that is my "weird issue"! I first packaged the function in emacs-utils.scm and experienced much worse things. I suspected it to be a circular dependency as any package using emacs-build-system includes emacs-utils under the hood and moved it to packages/emacs.scm. I thought it was something different because the same error appeared there too. Maybe we should have a file with "shortcuts" for package definitions of special kind and place the function there? I would claim that we would have the same problems in emacs-utils.scm. Tim. --bBeAsaqqwKCUODe2IoR55PgFp6vNxY8iq-- --Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwzcjMACgkQ0uWPaa77 GdWWJAf/W3fluWSXYSE9FKxIh2u93X8UXRc8q00RJk892I2qOUFR/GkTpkFp5pSG xO5FGtG/Lcv1UBkJVsMNOFsquZRW6qVtx5lrN1/U3jg1ravkvp3/ecNOB4hmJ3oM xGQFXbPgF/YVhWsnT576sOrT939I+CfN8lzYuqUMExgJwJRXwK+LMAxf4FnfJOTl CzMpHpCDvW9ViuXWDGLUbnXT9HevBLJJ8tnshJ4T/af436lehFSRYtfLVRaV08eP 3K8TH6rNMdqrwhnso+FA+W1pR9EGx80SrikeyFwrFvj1J6mHto0LqOZ2t1zurliq 1K3DxpyMcPVGRad9fWg6Wy8SLF3S/A== =JZKT -----END PGP SIGNATURE----- --Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jan 2019 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15468990411419 (code B ref 33598); Mon, 07 Jan 2019 22:11:02 +0000 Received: (at 33598) by debbugs.gnu.org; 7 Jan 2019 22:10:41 +0000 Received: from localhost ([127.0.0.1]:49035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggd6V-0000Mn-18 for submit@debbugs.gnu.org; Mon, 07 Jan 2019 17:10:39 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:35242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggd6I-0000MU-Qa for 33598@debbugs.gnu.org; Mon, 07 Jan 2019 17:10:27 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1864BAAC; Mon, 7 Jan 2019 23:10:25 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GTx1ZJ42AzGc; Mon, 7 Jan 2019 23:10:24 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 087F63A6; Mon, 7 Jan 2019 23:10:23 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 =?UTF-8?Q?Niv=C3=B4se?= an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 07 Jan 2019 23:10:23 +0100 In-Reply-To: <875zv0imr7.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Mon, 07 Jan 2019 15:08:12 +0100") Message-ID: <87k1jgce5s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello! Pierre Neidhardt skribis: > Hmmm... Not too sure where to put package-elisp-from-package. > I see the following options: > > - build-system/emacs.scm, but is it our policy? > - Or a separate file, but which one? >=20=20=20 > @Ludo? I actually fixed it today right after you reverted the commit (I rebased and didn=E2=80=99t notice it had been reverted in the meantime): https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D67eebb19b70acfe99= 7b40d8c7978f9dc0673a4af With this you should be able to reinstate the rest of the commit. I tried to explain the reason for the issue in the commit log, let me know if anything=E2=80=99s unclear. Thanks, Ludo=E2=80=99. From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jan 2019 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15468992871773 (code B ref 33598); Mon, 07 Jan 2019 22:15:02 +0000 Received: (at 33598) by debbugs.gnu.org; 7 Jan 2019 22:14:47 +0000 Received: from localhost ([127.0.0.1]:49039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggdAU-0000SW-Pr for submit@debbugs.gnu.org; Mon, 07 Jan 2019 17:14:47 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:52211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggdAT-0000SO-CS for 33598@debbugs.gnu.org; Mon, 07 Jan 2019 17:14:45 -0500 Received: from mimimi (lfbn-1-822-59.w86-246.abo.wanadoo.fr [86.246.56.59]) (Authenticated sender: mail@ambrevar.xyz) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 1D356100009; Mon, 7 Jan 2019 22:14:42 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <87k1jgce5s.fsf@gnu.org> Date: Mon, 07 Jan 2019 23:14:42 +0100 Message-ID: <878szw6rot.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) It works, but it's semantically dubious. For packages like emacs-cmake-mode now have to use the llvm module to use package-elisp-from-package. Thoughts? From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jan 2019 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15469367544244 (code B ref 33598); Tue, 08 Jan 2019 08:40:02 +0000 Received: (at 33598) by debbugs.gnu.org; 8 Jan 2019 08:39:14 +0000 Received: from localhost ([127.0.0.1]:49207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggmuo-00016O-FP for submit@debbugs.gnu.org; Tue, 08 Jan 2019 03:39:14 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:37362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggmum-00016E-JP for 33598@debbugs.gnu.org; Tue, 08 Jan 2019 03:39:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 973A4493; Tue, 8 Jan 2019 09:39:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PbSqNZJ2VQCs; Tue, 8 Jan 2019 09:39:10 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C2009354; Tue, 8 Jan 2019 09:39:09 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?UTF-8?Q?Niv=C3=B4se?= an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 08 Jan 2019 09:39:09 +0100 In-Reply-To: <878szw6rot.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Mon, 07 Jan 2019 23:14:42 +0100") Message-ID: <874laj35n6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Pierre Neidhardt skribis: > It works, but it's semantically dubious. For packages like emacs-cmake-m= ode now > have to use the llvm module to use package-elisp-from-package. > Thoughts? Sure, it probably belongs elsewhere. I moved it there to quickly fix the problem, and I purposefully made it private, but I agree, it could go to some other places if there=E2=80=99s a need for it outside of llvm.sc= m. I=E2=80=99m not sure exactly where. I wonder how often the approach of =E2=80=98package-elisp-from-package=E2= =80=99 is applicable or desirable. There are packages (e.g., recutils, GLOBAL) that come with elisp files, which automatically get installed upon =E2=80= =9Cmake install.=E2=80=9D I=E2=80=99m not sure we=E2=80=99d want to make them sepa= rate. Thoughts? Ludo=E2=80=99. From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jan 2019 08:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15469372895109 (code B ref 33598); Tue, 08 Jan 2019 08:49:01 +0000 Received: (at 33598) by debbugs.gnu.org; 8 Jan 2019 08:48:09 +0000 Received: from localhost ([127.0.0.1]:49226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggn3R-0001KL-1E for submit@debbugs.gnu.org; Tue, 08 Jan 2019 03:48:09 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:36565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggn3P-0001KD-VX for 33598@debbugs.gnu.org; Tue, 08 Jan 2019 03:48:08 -0500 Received: from mimimi (lfbn-1-822-59.w86-246.abo.wanadoo.fr [86.246.56.59]) (Authenticated sender: mail@ambrevar.xyz) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 07733240015; Tue, 8 Jan 2019 08:48:04 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <874laj35n6.fsf@gnu.org> Date: Tue, 08 Jan 2019 09:48:04 +0100 Message-ID: <87wonf5yd7.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The benefit of separate Emacs packages is if the Emacs library can be used without installing the parent package to the user profile. For instance, emacs-clang-rename can be installed and it will work while the user does not have to install clang. (Clang remains an input, obviously.) For this reason, "package-elisp-from-package" gives maximal flexibility in my opinion. Currently, there are a few more packages. We can look up "emacs-build-system" outside emacs.scm to find them (e.g. agda2). Off the top of my head, there is also asymptote. Now to the ideal place for package-elisp-from-package: it seems that no existing file would be a fit. So what about guix/utils/emacs.scm? Having a separate file would make sure we run into other meta-circular dependency issues. From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jan 2019 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154694123711046 (code B ref 33598); Tue, 08 Jan 2019 09:54:02 +0000 Received: (at 33598) by debbugs.gnu.org; 8 Jan 2019 09:53:57 +0000 Received: from localhost ([127.0.0.1]:49258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggo56-0002s5-JJ for submit@debbugs.gnu.org; Tue, 08 Jan 2019 04:53:57 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:37930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggo54-0002rw-A9 for 33598@debbugs.gnu.org; Tue, 08 Jan 2019 04:53:55 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 85D70354; Tue, 8 Jan 2019 10:53:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uZ8Yd81EJrSh; Tue, 8 Jan 2019 10:53:51 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6C5CB91; Tue, 8 Jan 2019 10:53:51 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?UTF-8?Q?Niv=C3=B4se?= an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 08 Jan 2019 10:53:50 +0100 In-Reply-To: <87wonf5yd7.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Tue, 08 Jan 2019 09:48:04 +0100") Message-ID: <87k1jfzd8x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Pierre Neidhardt skribis: > The benefit of separate Emacs packages is if the Emacs library can be used > without installing the parent package to the user profile. > > For instance, emacs-clang-rename can be installed and it will work while = the > user does not have to install clang. (Clang remains an input, obviously.) > > For this reason, "package-elisp-from-package" gives maximal flexibility i= n my > opinion. Yes, I agree that it makes a lot of sense for =E2=80=98emacs-clang-rename= =E2=80=99 for instance. I=E2=80=99m just unsure whether the approach generalize to other packages. > Currently, there are a few more packages. We can look up "emacs-build-sy= stem" > outside emacs.scm to find them (e.g. agda2). > > Off the top of my head, there is also asymptote. I=E2=80=99m not convinced sure =E2=80=98emacs-agda2-mode=E2=80=99 and =E2= =80=98asymptote=E2=80=99 need to be changed; it doesn=E2=80=99t look like a clear win, dunno. For example, =E2=80=98package-elisp-from-package=E2=80=99 preserves the nam= e, synopsis, and description, so you end up having to do: (define foo (package (inherit (package-elisp-from-package x)) (name "emacs-foo") (license =E2=80=A6) (synopsis =E2=80=A6) (description =E2=80=A6))) =E2=80=A6 which I think it a marginal improvement compared to =E2=80=98emacs-agda2-mode=E2=80=99. Also, the =E2=80=9Cfind *.el=E2=80=9D = approach may not work out of the box for all cases, so the procedure may need to be tweaked further, etc. > Now to the ideal place for package-elisp-from-package: it seems that no e= xisting > file would be a fit. So what about guix/utils/emacs.scm? Having a separ= ate > file would make sure we run into other meta-circular dependency issues. Circular, not meta-circular. ;-) So yeah, (guix utils emacs) is one option; another one would be to trim the list of modules emacs.scm depends on, such that we don=E2=80=99t have t= his issue in the first place (that requires care, though.) However, my suggestion would be to use =E2=80=98package-elisp-from-package= =E2=80=99 as Tim intended in the original patch, keeping the procedure private to llvm.scm, and generalize if and when we see other use cases. How does that sound? Ludo=E2=80=99. From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jan 2019 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Tim Gesthuizen , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154694193412141 (code B ref 33598); Tue, 08 Jan 2019 10:06:02 +0000 Received: (at 33598) by debbugs.gnu.org; 8 Jan 2019 10:05:34 +0000 Received: from localhost ([127.0.0.1]:49264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggoGM-00039l-Jl for submit@debbugs.gnu.org; Tue, 08 Jan 2019 05:05:34 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggoGK-00039c-7p for 33598@debbugs.gnu.org; Tue, 08 Jan 2019 05:05:32 -0500 X-Originating-IP: 86.246.56.59 Received: from mimimi (lfbn-1-822-59.w86-246.abo.wanadoo.fr [86.246.56.59]) (Authenticated sender: mail@ambrevar.xyz) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 451B2E0019; Tue, 8 Jan 2019 10:05:29 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <87k1jfzd8x.fsf@gnu.org> Date: Tue, 08 Jan 2019 11:05:29 +0100 Message-ID: <87va2z5us6.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Agreed, the win is not always obvious. If we are all OK with this, let's close the issue. Tim, what do you think? From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jan 2019 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154696172919148 (code B ref 33598); Tue, 08 Jan 2019 15:36:02 +0000 Received: (at 33598) by debbugs.gnu.org; 8 Jan 2019 15:35:29 +0000 Received: from localhost ([127.0.0.1]:50135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggtPd-0004ym-1w for submit@debbugs.gnu.org; Tue, 08 Jan 2019 10:35:29 -0500 Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:45231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggtPa-0004yW-L4 for 33598@debbugs.gnu.org; Tue, 08 Jan 2019 10:35:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1546961720; bh=LVMbpmBMDVix3gnLg6eDTeu8JtGsgTAZ8dbhmHTrUno=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=QSMXc4noyNGHTDJUwnM7BNOEy3xJUAdhBdIkmUEvHQfivVBULChLjTd6KQNX/rohwejA0COsLiQuwqtCfLysnMFhBeS3yggu/3EZi8o3CjYegbCYn+4g7dPEXz7BDzk8IFCm3k4zQuvHgpwRWGyt/YpSfSRvi8wOHF+QTtBpO3UVjdtsi5jCHOXB21BfXeLtWalsoHzO7Ijyd3dQNJoZ7lxURas4u0ECldVVzg/HEd2thsOdNPrHtcsB48mqOKN9I6JXAnOFjRxPsaPl454fMO84Aju8++v5tciTr1J9CzLbeq5QKjE7Cl71mHZvRT2+x64SxlCBLV0BJzQUhSZGng== X-YMail-OSG: wSNVGy0VM1kETOMxW1fjDCTeQcXzNzHO6YPw1M09xlHVkMFHmRwg1UTrKkgPAAk o25b4PY9ZJ8_s7EHOWax_KZFF79N_aVCTUqPX_bZs1wP38_kXtt5G9KfOBc5UTL5jIJNuYfKO7Um u239N.ZO0xHd7OIAT5yOveKLG82BXlYaYjriaxeW1Bc1pYq.Tm6xuLk39ixH26XBoAe6cYYakH3H hMuqB.MhLg2tydkofk4Vj9UCFL7btpU6jKG31oGtMmBX52xmW.qMzf2LNmD6SaODEyGtFTbgmM9c KN2HrFCXxBqUegkTGDFrBp7obNiGaKtYvUXVkCg6IimgRhJtV9sSWRpsXvdjbpUnlj6_Ew370itC dKN9MsWzQNx2cDX7rA2s6.wMiV0YTGF2q.8k_aTpHIdlDdWz6fWBNTyVtKTEOgEzdMg6wJe_a7K0 7SMjfgJJo0XSTbVHqjPaqdDAFOnRxGh8y8BtQNNXc63ouL3VSQxaES0zRWk6o5ukdzHT72h2NNuD YS.fDberXmxq4tHg9MbMeno4z5Bk.DMw52_kd9kivMFMyGfROeYfoOrUxvW7vfJHzickxvjrw9V6 DTukmtnp8BQ8GdGDHRueK37Qwb4qyHNBAedI0RTCb6vTjWb6m2oqdbHKagKw8FjVuzJHqWy6gDyP z0P0u1BZBapJh_IPsOA5TOjvoiDBCSAsd8PJIBYLEZ61nLzeTmTKj2Rw99YL6mL6nvMSfn6XwIqf _1FBPB8VJqoR3RcTVIfJ44ABzpmkZCvXfUyiXHtVDO3lbA0MmQfrRWlrW6sHv1L2GA00H5o6ZLWY eHHkU2CQ0RUmmuUHr6OMI87FnugxEk2AD9q5zzMiY0q7XBu284FRXb.I_tG9D1edECH59.QRcXoz NEZf7wVrYNT7JbI8pYmxYP1VoZ_WhNT22SAR6WTTgY_q5WVn2oJ1c8Y82ZURlC56P2.VHEAWeV.h mBXLOLjkCmIWTJoVzbRvM_tlfI.4F4wR1PTIaIfGKTO.TsKwNv6DP2iT36sNLiVQBJOtRdx.bZQA qfW7uC4fsaJh9hRKDVbre9SRQex.4asmFtbFbMhIon3ggzvmlGMT9G5AF7aQmo149zE0- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Tue, 8 Jan 2019 15:35:20 +0000 Received: from p5B221357.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.19.87]) by smtp422.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 04037a707a6f1e0475249397388701ae; Tue, 08 Jan 2019 15:35:19 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> From: Tim Gesthuizen Openpgp: preference=signencrypt Autocrypt: addr=tim.gesthuizen@yahoo.de; prefer-encrypt=mutual; keydata= mQENBFrE7N0BCAC7s3lBzEf8MPAiqYjlD8Z/9TrwMEy2gLZifF3wTgIFVSOujb5gcceS3I64 qur9lCPJycxzl9dOVOBXycXZNMjSrd1VXsmBoBmR54NOOE526eCwfjkbbNhAJ5hPAwGDOvIs s2xKbIBcqfrdNnHIrZt0ohueX6RxEc6HhVTh79GwUjCaux4Jfs0NfNH+We1hyINqMKnIHQ1D kycgyFj1w0HkJiNNZSgKGNeSvqDA4gV/g9uVy25XQA/hsCBHU1teJiSfM8aVw8PA41eUsl9L pCeCTWjWwW+VQWNs5y4I3ZEpY1CAZ/C9OrbCBzNs1ssAT2aOhV3TNrOUkzPBMbLKwel1ABEB AAG0KFRpbSBHZXN0aHVpemVuIDx0aW0uZ2VzdGh1aXplbkB5YWhvby5kZT6JAVMEEwEIAD4W IQQpSILn7wFEoSuLl9rS5Y9prvsZ1QUCWsTs3QIbAwUJA8JnAAULCQgHAgYVCAkKCwIEFgID AQIeAQIXgAAKCRDS5Y9prvsZ1RzzB/ibvqnUyPlhqiLoDtIXPMGOJizkI+6YVGn5M3egrS2I W3ZHBlJMACNhhBY1dYjnFMmUJluHG0ROyS1MyA5MNf1arQXPGNGZBIJqwnHLEm8v6zhNpb9t V11o+p+Vf6fXOGMZbVYyTD7Nt8sRD3xyovd6YARsRaRWx6Jm1QKvLuade6jGFZKq4j8WSjk1 W9FZs+n845QKE7+6G4SaJZJVw+7nbOCfUtKBsSDf63G9aTFc8i6jJFPpKgu6A1xs/xRiEwqZ KBkF5+rh1JGHne3iSEgPvxxsmfQyLpW2kH7tUgFCAfipLyrz84K+E+yrfaG9zEY8jqV/D9Kt fFvADUZOkt65AQ0EWsTs3QEIAMUmXjZhfhYA5tg3aau8jB2kph2vl9geVGc+PABv90DgHUOW dKnFdXqaABLtR05amEIWKtkkE8U4Ze5FF4R8f2pMMP5QCWf0DUxI6QZ86PhP0jmyfH6QOPpM BxegjHNnD35CQvfn977lzCdZGetx/H05okwC2rlhU7e+XO62pjUjxj8CNQqbC3KGdkzn30Uv gfipAQb369FuCu83MWPWBNjgZ4eBsActr5c2S6/ltCTshkYWD9YSs/MfUyL8YblZ4xy4Nk5L sl8BKAzl16zuoo9q32Fa/L+7S+6RStY5gaBoISlQUXRrdQBuoPO72BRG3xxRpYfHQiHcKsw8 CCqlINcAEQEAAYkBPAQYAQgAJhYhBClIgufvAUShK4uX2tLlj2mu+xnVBQJaxOzdAhsMBQkD wmcAAAoJENLlj2mu+xnV+9QH/1/VcoiqpSJReuMyDAMcYHOrXhKnMLR/rDxTYn4oBNrGDXh+ vMbMJtxHpaNiFrzkd+QOWc0MU15cJRqCx2hSZNfJDaPEoHSwUs++gFSqaIkS/dLQ0LTL/DBp jKsed8FfV8Ubv/M0AoD8cixAmJLnxlt3G1gLBBkAlv0F53bIdAGJMBJZsZ+1HmzFazknGIR0 LgHZ28PK/QWPwE5gRkIzwTD+hrKJjGcBMach2ZbcAvo47rrRYW1ukbN6L1L5mvTSCh2Gitgp ewig0IiavSVkL3uWpPvAqmr9N9zk/qrHk1EgV+hzNriJhUitpMgrgZQfHYRm4LIhsmJm9TOT N3SWwT0= Message-ID: Date: Tue, 8 Jan 2019 16:35:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87va2z5us6.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zyqS7rInNMgyY5BUyznANInw8mT0hP44Y" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zyqS7rInNMgyY5BUyznANInw8mT0hP44Y Content-Type: multipart/mixed; boundary="R7JdlNaVhvAYbaZLrj3S67NDSLv3Cs0Zy"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt , =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: 33598@debbugs.gnu.org Message-ID: Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> In-Reply-To: <87va2z5us6.fsf@ambrevar.xyz> --R7JdlNaVhvAYbaZLrj3S67NDSLv3Cs0Zy Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08.01.19 11:05, Pierre Neidhardt wrote: > Agreed, the win is not always obvious. > If we are all OK with this, let's close the issue. >=20 > Tim, what do you think? >=20 That's no problem for me. After all my intent was to make sure I don't have clangs source tree 3 times in the store :) I think we should still put the generic function into llvm.scm and not the clang specific one. --R7JdlNaVhvAYbaZLrj3S67NDSLv3Cs0Zy-- --zyqS7rInNMgyY5BUyznANInw8mT0hP44Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlw0wzUACgkQ0uWPaa77 GdUWtQgAmWGfbm3oiRYwFIfiGOiZiUheYVu4+O+2fORcOZhjJp7knK+bL+YRLdFL aBqNcXtg1f1uLMHBp9WYCmyQoGN3VD93EYC6SoOhUovg58yDiw9R0WsetY0V4dIg GHZLfA9EBZp4o2t3FELQVFhXXA9vrqVGk5ce/IBSkYh+L+FF5t7r8MM/fT/L7ya+ pfSZ+jnYwhPHsbuW0ji5fl7MbEnCL5T9DMxS4iWTafCL6O8qif2W/Ajolp5CN+R0 c1O6zWOuCjRGsVv8NbNIkP6tRRXh0CcNUjHHptmgis+eHlSXO+MVgduiS4rS4iJX ka7g+rK03/yMPTmyb3cD1QrVKJ7gXg== =jsv4 -----END PGP SIGNATURE----- --zyqS7rInNMgyY5BUyznANInw8mT0hP44Y-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Jan 2019 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154714491230010 (code B ref 33598); Thu, 10 Jan 2019 18:29:01 +0000 Received: (at 33598) by debbugs.gnu.org; 10 Jan 2019 18:28:32 +0000 Received: from localhost ([127.0.0.1]:54173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghf4B-0007ny-TT for submit@debbugs.gnu.org; Thu, 10 Jan 2019 13:28:32 -0500 Received: from sonic312-27.consmr.mail.ir2.yahoo.com ([77.238.178.98]:34112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghf48-0007ni-NU for 33598@debbugs.gnu.org; Thu, 10 Jan 2019 13:28:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1547144902; bh=dK8x+9d6T5f89ifHUDvELik7frr2/eqyEVPqBYQz9I4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=OnJgLFEdUItzoXFoU4sF95TsNy3NzZneMFDHiu6kMQVLios9S4yLQMj3bSxy+pPeFmzpRy/X0CdgpJXWOMlhJoCcJwUoUNHWBLH3acaYX87Cx5IC1m048I1+t4HdvAr4uC5vxcbSiTj1qDxHKIkhJo3iYFvQWjEPuQVs3wksDizWyyw8slB7YCGlhthA/YBstGbqSnYeyCWT3uxXLztPAiqEJ3rSqvBAcHn4ZshcG4/oHHLFVAI0m7EInmAku8T/iJcpv4ygyJJy51OxN0ajlfExZHovJhfDirAA29s09jueFOQtSq6DUPJA82wmXH1cn1cfCjgWjusmAEquHF/FlQ== X-YMail-OSG: qGeIjuMVM1kw3rhJKQ33Mnvrcy0GPhNssTKaiqyPeTEA.QPx8p3hr.d.DRbPYL5 S6wpFDkyMK.oG9H0ZEw3MEnnvyA1rPd40VMlPfZfUfY72Gs1Tig.VHison9c3WzTkgx_HlI9jruP Qkn7Uyfe4Y3YailojJV2qouJuxjAAwMfKuxZWr2nWDn75h1DUnoAAyY4aPSVGJyEoXBpmvo6RAx6 DoRrgFL_AuuyKsKGhTsa2u0GUA8d9AIEFtvjIQwiNM7MnZXM0gDMzVj0NrsxEn.HyarL6szWqsgJ _PAqKhnhM_9ScOWC5bIP.RxnZNYA_IJsyK_5f.Md6Oet.lwIicBGuoM099yHmbOVAvm0vsjqSNbV LkHGKN.OMI.A8YxD3R3R6tC8UxEkQsaoE_qWZWtvk1xncz4X9_W0ApkRFoI2gYUC.YTx2vl21Wf0 zO.OH8qnYXsEqGTfYZbmHC8_bE3ABuV8vwyI3PH.EejcK3N56Lw7EQMREAPll208cmXmAdPD92c0 ghWFkUseAwS6XcXSZO5e3N_R4yUG0seiwHaIHHBklgrel2ok0TfoV_0yD.5vEI2zlaaEVouKs0dL mzuuGMu6W8vzY81bzfKO20CknSuluN6vxwJNUA1KfgauAe9R4aGd4XAsP.QCRyZ9qK9HNAQlny.O dGtgv2OfeyYO9RhX2YoHHLZasPyZ28b9zjscitrfW_AemHYfnCChzLFBt2GfmE2kPtytr1YSJ8XP RHyjlKKlYAYRqvMeniahr5NJXUem_7D3RmfcZKl46d3zgV5tjIHnAP44xzEiFlOierOwrNYlvqU_ VESI2G31Dmo.HA07QZVv8Bz1.LUktS4lPB4jTt3I_qZyjRYzSz0dpMbhmLVIjFayZOPyEeiK5N0b hX_tQkoPrqjn5rdE3oPY2uEIUYyHoFW7Q6HM25jy0BkVLexBAorcCvsHRM7jZ6ERpSzHOLJ29c.J JF3ruldrcudTMZv8qNP2Skp9Oyk9V12VboQHTuTqmG744y3VNMSKVE4I8wLq8epC_lRFqvO5cKJ5 DxBpLmC2FM1KHDzPCCOwqLLV1W6y2SyxzIwFJjuJ3onF.y6hTDerD5p705RzlnIJetdAtP66L5RF uk.y9iZZcl_g74gI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Thu, 10 Jan 2019 18:28:22 +0000 Received: from p5B221453.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.20.83]) by smtp425.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5bd3ea88f447d5ba83e91b3a0f58baab; Thu, 10 Jan 2019 18:28:19 +0000 (UTC) References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> From: Tim Gesthuizen Openpgp: preference=signencrypt Autocrypt: addr=tim.gesthuizen@yahoo.de; prefer-encrypt=mutual; keydata= mQENBFrE7N0BCAC7s3lBzEf8MPAiqYjlD8Z/9TrwMEy2gLZifF3wTgIFVSOujb5gcceS3I64 qur9lCPJycxzl9dOVOBXycXZNMjSrd1VXsmBoBmR54NOOE526eCwfjkbbNhAJ5hPAwGDOvIs s2xKbIBcqfrdNnHIrZt0ohueX6RxEc6HhVTh79GwUjCaux4Jfs0NfNH+We1hyINqMKnIHQ1D kycgyFj1w0HkJiNNZSgKGNeSvqDA4gV/g9uVy25XQA/hsCBHU1teJiSfM8aVw8PA41eUsl9L pCeCTWjWwW+VQWNs5y4I3ZEpY1CAZ/C9OrbCBzNs1ssAT2aOhV3TNrOUkzPBMbLKwel1ABEB AAG0KFRpbSBHZXN0aHVpemVuIDx0aW0uZ2VzdGh1aXplbkB5YWhvby5kZT6JAVMEEwEIAD4W IQQpSILn7wFEoSuLl9rS5Y9prvsZ1QUCWsTs3QIbAwUJA8JnAAULCQgHAgYVCAkKCwIEFgID AQIeAQIXgAAKCRDS5Y9prvsZ1RzzB/ibvqnUyPlhqiLoDtIXPMGOJizkI+6YVGn5M3egrS2I W3ZHBlJMACNhhBY1dYjnFMmUJluHG0ROyS1MyA5MNf1arQXPGNGZBIJqwnHLEm8v6zhNpb9t V11o+p+Vf6fXOGMZbVYyTD7Nt8sRD3xyovd6YARsRaRWx6Jm1QKvLuade6jGFZKq4j8WSjk1 W9FZs+n845QKE7+6G4SaJZJVw+7nbOCfUtKBsSDf63G9aTFc8i6jJFPpKgu6A1xs/xRiEwqZ KBkF5+rh1JGHne3iSEgPvxxsmfQyLpW2kH7tUgFCAfipLyrz84K+E+yrfaG9zEY8jqV/D9Kt fFvADUZOkt65AQ0EWsTs3QEIAMUmXjZhfhYA5tg3aau8jB2kph2vl9geVGc+PABv90DgHUOW dKnFdXqaABLtR05amEIWKtkkE8U4Ze5FF4R8f2pMMP5QCWf0DUxI6QZ86PhP0jmyfH6QOPpM BxegjHNnD35CQvfn977lzCdZGetx/H05okwC2rlhU7e+XO62pjUjxj8CNQqbC3KGdkzn30Uv gfipAQb369FuCu83MWPWBNjgZ4eBsActr5c2S6/ltCTshkYWD9YSs/MfUyL8YblZ4xy4Nk5L sl8BKAzl16zuoo9q32Fa/L+7S+6RStY5gaBoISlQUXRrdQBuoPO72BRG3xxRpYfHQiHcKsw8 CCqlINcAEQEAAYkBPAQYAQgAJhYhBClIgufvAUShK4uX2tLlj2mu+xnVBQJaxOzdAhsMBQkD wmcAAAoJENLlj2mu+xnV+9QH/1/VcoiqpSJReuMyDAMcYHOrXhKnMLR/rDxTYn4oBNrGDXh+ vMbMJtxHpaNiFrzkd+QOWc0MU15cJRqCx2hSZNfJDaPEoHSwUs++gFSqaIkS/dLQ0LTL/DBp jKsed8FfV8Ubv/M0AoD8cixAmJLnxlt3G1gLBBkAlv0F53bIdAGJMBJZsZ+1HmzFazknGIR0 LgHZ28PK/QWPwE5gRkIzwTD+hrKJjGcBMach2ZbcAvo47rrRYW1ukbN6L1L5mvTSCh2Gitgp ewig0IiavSVkL3uWpPvAqmr9N9zk/qrHk1EgV+hzNriJhUitpMgrgZQfHYRm4LIhsmJm9TOT N3SWwT0= Message-ID: Date: Thu, 10 Jan 2019 19:28:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87va2z5us6.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pFySSy80a6M31JNiVOS7qImGmnD7voZJ8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pFySSy80a6M31JNiVOS7qImGmnD7voZJ8 Content-Type: multipart/mixed; boundary="bB5ru9GL4Ri8p6dSGlLk6ut928FdyoDJe"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt , =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: 33598@debbugs.gnu.org Message-ID: Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> In-Reply-To: <87va2z5us6.fsf@ambrevar.xyz> --bB5ru9GL4Ri8p6dSGlLk6ut928FdyoDJe Content-Type: multipart/mixed; boundary="------------81AF155A443509D879614087" Content-Language: en-US This is a multi-part message in MIME format. --------------81AF155A443509D879614087 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I implemented the changes we discussed so we can finally close this ticke= t. Patches are attached. Tim. --------------81AF155A443509D879614087 Content-Type: text/x-patch; name="0001-gnu-Add-package-elisp-from-package.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-package-elisp-from-package.patch" =46rom 515a9392b8912fbfb067728acb25f84de83d8378 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 4 Jan 2019 22:34:36 +0100 Subject: [PATCH 1/2] gnu: Add package-elisp-from-package Add a function to generate package definitions that packages single elisp= files from other packages. * gnu/packages/llvm.scm (package-elisp-from-package): New function --- gnu/packages/llvm.scm | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index b1e41d72f..5518d4d5c 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -8,7 +8,7 @@ ;;; Copyright =C2=A9 2018 Marius Bakke ;;; Copyright =C2=A9 2018 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2018 Efraim Flashner -;;; Copyright =C2=A9 2018 Tim Gesthuizen +;;; Copyright =C2=A9 2018, 2019 Tim Gesthuizen = ;;; Copyright =C2=A9 2018 Pierre Neidhardt ;;; ;;; This file is part of GNU Guix. @@ -508,6 +508,36 @@ SOURCE-FILES found in SOURCE-PACKAGE." (append '("." "..") basenames))) #t))))))) =20 +(define (package-elisp-from-package + source-package package-name source-files) + "Return a package definition that packages emacs-lisp files from the +SOURCE-PACKAGEs source. The package has the name PACKAGE-NAME and packa= ges +the files SOURCE-FILES from the source in its root directory." + (let ((orig (package-source source-package))) + (package + (inherit source-package) + (name package-name) + (build-system emacs-build-system) + (source (origin + (method (origin-method orig)) + (uri (origin-uri orig)) + (sha256 (origin-sha256 orig)) + (file-name (string-append package-name "-" + (package-version source-packag= e))) + (modules '((guix build utils) + (srfi srfi-1) + (ice-9 ftw))) + (snippet + `(let* ((source-files (quote ,source-files)) + (basenames (map basename source-files))) + (map copy-file + source-files basenames) + (map delete-file-recursively + (fold delete + (scandir ".") + (append '("." "..") basenames))) + #t))))))) + (define-public emacs-clang-format (package (inherit clang) --=20 2.20.1 --------------81AF155A443509D879614087 Content-Type: text/x-patch; name="0002-gnu-Use-package-elisp-from-package-for-clangs-emacs-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0002-gnu-Use-package-elisp-from-package-for-clangs-emacs-.pa"; filename*1="tch" =46rom 939547e6e2c0f5a83eb1290ff1c9ee39415ce3d5 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Fri, 4 Jan 2019 22:34:56 +0100 Subject: [PATCH 2/2] gnu: Use package-elisp-from-package for clangs emacs= lisp files Use package-elisp-from-package for emacs-clang-format and emacs-clang-ren= ame. Also remove package-from-clang-elisp-file as it is not needed anymore. * gnu/packages/llvm.scm (emacs-clang-format): Use package-elisp-from-pack= age * gnu/packages/llvm.scm (emacs-clang-rename): Use package-elisp-from-pack= age * gnu/packages/llvm.scm (package-from-clang-elisp-file): Remove function --- gnu/packages/llvm.scm | 63 +++++++++++++++++++++---------------------- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 5518d4d5c..dedad7dc7 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -39,6 +39,7 @@ #:use-module (gnu packages gcc) #:use-module (gnu packages bootstrap) ;glibc-dynamic-linker #:use-module (gnu packages compression) + #:use-module (gnu packages emacs) #:use-module (gnu packages libffi) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -540,22 +541,21 @@ the files SOURCE-FILES from the source in its root = directory." =20 (define-public emacs-clang-format (package - (inherit clang) - (name "emacs-clang-format") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-format/clang-format.el" "clang-fo= rmat.el") - (emacs-substitute-variables "clang-format.el" - ("clang-format-executable" - (string-append clang "/bin/clang-format")))) - #t))))) + (inherit (package-elisp-from-package + clang + "emacs-clang-format" + '("tools/clang-format/clang-format.el"))) + (inputs `(("clang" ,clang))) + (arguments `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-k= eys) + (chmod "clang-format.el" #o644) + (emacs-substitute-variables "clang-f= ormat.el" + ("clang-format-executable" + (string-append (assoc-ref inputs = "clang") + "/bin/clang-format= "))) + #t))))) (synopsis "Format code using clang-format") (description "This package allows to filter code through @code{clang= -format} to fix its formatting. @code{clang-format} is a tool that formats @@ -564,22 +564,21 @@ C/C++/Obj-C code according to a set of style option= s, see =20 (define-public emacs-clang-rename (package - (inherit clang) - (name "emacs-clang-rename") - (build-system emacs-build-system) - (inputs - `(("clang" ,clang))) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let ((clang (assoc-ref inputs "clang"))) - (copy-file "tools/clang-rename/clang-rename.el" "clang-re= name.el") - (emacs-substitute-variables "clang-rename.el" - ("clang-rename-binary" - (string-append clang "/bin/clang-rename")))) - #t))))) + (inherit (package-elisp-from-package + clang + "emacs-clang-rename" + '("tools/clang-rename/clang-rename.el"))) + (inputs `(("clang" ,clang))) + (arguments `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (chmod "clang-rename.el" #o644) + (emacs-substitute-variables "clang-rename.el" + ("clang-rename-binary" + (string-append (assoc-ref inputs "clang") + "/bin/clang-rename"))) + #t))))) (synopsis "Rename every occurrence of a symbol using clang-rename") (description "This package renames every occurrence of a symbol at p= oint using @code{clang-rename}."))) --=20 2.20.1 --------------81AF155A443509D879614087-- --bB5ru9GL4Ri8p6dSGlLk6ut928FdyoDJe-- --pFySSy80a6M31JNiVOS7qImGmnD7voZJ8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlw3jsEACgkQ0uWPaa77 GdX+PggAqvuAfjw7XdPqGAUShxNX6yYooshtNDvO5kGiWLiWtPAshw+l3yv94VzU NZJfpBRs5nszcEq9MAMCL69mhaVHvN1/2l3qkfjERmeQ4UqIiMi+fpTJ84ZMU3K6 Zu9RZlgNrVcgWdpbwyzAtVqD26CW0o6xBiu28Zp0U9/dNpqYzbRFC6WXUnvboBVU 82DAsbhJP5vOXQ5NF0zFwTEDMQd9tBQh4azQ3MtKKvkfuRBee7cROwVPStxP4pIn 1EWnBW6d7Pm3BBCpv8WNVyQysjurt4az1zUcSMGM1XBFBzIkXPDYTA/UEB1R6pFR HHgElVtbz8F22wqF+edeNasGbAq6Gw== =N7Zw -----END PGP SIGNATURE----- --pFySSy80a6M31JNiVOS7qImGmnD7voZJ8-- From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Jan 2019 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.154714563031173 (code B ref 33598); Thu, 10 Jan 2019 18:41:02 +0000 Received: (at 33598) by debbugs.gnu.org; 10 Jan 2019 18:40:30 +0000 Received: from localhost ([127.0.0.1]:54184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfFl-00086i-Gm for submit@debbugs.gnu.org; Thu, 10 Jan 2019 13:40:29 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfFj-00086a-Sp for 33598@debbugs.gnu.org; Thu, 10 Jan 2019 13:40:28 -0500 X-Originating-IP: 86.246.38.102 Received: from mimimi (lfbn-1-802-102.w86-246.abo.wanadoo.fr [86.246.38.102]) (Authenticated sender: mail@ambrevar.xyz) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 57C8C60008; Thu, 10 Jan 2019 18:40:25 +0000 (UTC) References: <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: Date: Thu, 10 Jan 2019 19:40:24 +0100 Message-ID: <87r2dkcq5j.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Err... The patch is already merged, what did you change? From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Jan 2019 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15471460717073 (code B ref 33598); Thu, 10 Jan 2019 18:48:02 +0000 Received: (at 33598) by debbugs.gnu.org; 10 Jan 2019 18:47:51 +0000 Received: from localhost ([127.0.0.1]:54198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfMr-0001q0-W8 for submit@debbugs.gnu.org; Thu, 10 Jan 2019 13:47:51 -0500 Received: from sonic306-20.consmr.mail.ir2.yahoo.com ([77.238.176.206]:45672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfMp-0001pl-4g for 33598@debbugs.gnu.org; Thu, 10 Jan 2019 13:47:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1547146061; bh=nlPYh0PA/2XC/6SnMUTwGnwSy8XRjvokWv1nt9n1oRs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=UFSa2SrhnSukr1WIFPQrnnLB8L4dIpU30bI3phcmIfGOPg6X/gy1gq30q7B66VPO6WTVl0y3bzKUCWGazKsUcx1Kw0umMrE1DS6Qbq+Xs4KvS4F63ngg58+TCoRrilqD0uSo62+EBwa2U4bjG2eAKis84F1K5UDvuqe3lLgDcWv+i71osODe9MQ7HlBK7posPvImYKv+mq0CfvIeSpUKIBlm1tI3eYG1/CSxApCnF80ietht1fVSLIo1solBFI2kV5uBY364XbS7oJnL9SWt9H8CJFtWW3XgX6XqvPZPcl47Ao5tTc8/iW43RwfX4GSsu5GoaG6WjQX3i9VrsKU1bQ== X-YMail-OSG: AeBxl58VM1nPunzb9WF175B6OdqzeaUsZI63IByCV6Xd21FayFR7iK.ScE.3hJy Go7gg48rRTKl04cMFD37CorWOh0Y5tGnqUX0X4bwC7YsnuS6bExrY_3Gox.URE7Y70W7jUXYdRsi MynOGSk_60Wtsn46y46K2e1_x7tRwQ6WTKyZE0Nm1Z.leXEHuyD9Ch6TSzHGtDHzqqGrAtI6no6P laECqRefazukoWYI56Db2ANEE_lWOK9LW07wF7At0NDeVaMvIAG2s.xALt9KrugVuTc1_E1iClAW ArxBK3lCWQ93mD7KexsJ4xqkJuwWGfxQGpM._EDNIZBmnpoFwNgX8PWK0p3khCI7pPBeTozgD47p GkbRrio5tZYmZxYPtMfh0WLzpU9R5FwFr.mCHr.7hGUcF0Jd6KFWssyTLIsJmTefarj_WqLgFhHI ns3il5A7By4CG6HrGUA2r810nwAwMpGKQ3.5PGh5g_rFQXowfN64yZXk939g4ehGyejLLM.plBAG mDRabSUdnfh_51LogmtuiFviKO03AGRmdzo80c8_49Y1UwqTQ.5vEckoHY7EXrRybbxNHEB2BXqU 1BegUj7J9wo8Rdi.K7Pgo2dLqx74eD0mSDRMmVGVpqN7cnAsZmgUfHoW1KNfT5_O82NBEyI9xCOk fbIbleNVjofGTetKrK8ysITSByRNVz720II7Q0mv3QWfL4ZY6mcqccUCE_0YhkZf0vRYPtzN62A3 stzggudK5mMyaqexkuA.0YS.pUtQv7SxbzfiUChmGh_XNukm0Frv07mq7cnq6jIB5qZZly4ac2lK fZoImuGhk_7YyFnvfCtvJhQuQstfnkSCMLduybDYxe21zV1TUPncqBFqpNFqUmKpjIXjdEoYOuJk 98wB.x4nbknq022bLpRBFEB8u_EyOqJlqOZto787gYkysvaJ40.20LWJMz0oJnIiiF0i_eliTrrp p1szcTy5vEV2XU4JB2T2ytKmp8VPy48Pjzgxr9VLTeTpkwyzHow9I3MW2j8ithdJx7FAxTjLcni7 j896P572MxcJGIwcm9.38XrcytJHTk7erv5LErJhSDZrQZ_njD8crc69NiAI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Thu, 10 Jan 2019 18:47:41 +0000 Received: from p5B221453.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.20.83]) by smtp428.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 6243e56ef227b84f829a76987a660855; Thu, 10 Jan 2019 18:47:39 +0000 (UTC) References: <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> <87r2dkcq5j.fsf@ambrevar.xyz> From: Tim Gesthuizen Openpgp: preference=signencrypt Autocrypt: addr=tim.gesthuizen@yahoo.de; prefer-encrypt=mutual; keydata= mQENBFrE7N0BCAC7s3lBzEf8MPAiqYjlD8Z/9TrwMEy2gLZifF3wTgIFVSOujb5gcceS3I64 qur9lCPJycxzl9dOVOBXycXZNMjSrd1VXsmBoBmR54NOOE526eCwfjkbbNhAJ5hPAwGDOvIs s2xKbIBcqfrdNnHIrZt0ohueX6RxEc6HhVTh79GwUjCaux4Jfs0NfNH+We1hyINqMKnIHQ1D kycgyFj1w0HkJiNNZSgKGNeSvqDA4gV/g9uVy25XQA/hsCBHU1teJiSfM8aVw8PA41eUsl9L pCeCTWjWwW+VQWNs5y4I3ZEpY1CAZ/C9OrbCBzNs1ssAT2aOhV3TNrOUkzPBMbLKwel1ABEB AAG0KFRpbSBHZXN0aHVpemVuIDx0aW0uZ2VzdGh1aXplbkB5YWhvby5kZT6JAVMEEwEIAD4W IQQpSILn7wFEoSuLl9rS5Y9prvsZ1QUCWsTs3QIbAwUJA8JnAAULCQgHAgYVCAkKCwIEFgID AQIeAQIXgAAKCRDS5Y9prvsZ1RzzB/ibvqnUyPlhqiLoDtIXPMGOJizkI+6YVGn5M3egrS2I W3ZHBlJMACNhhBY1dYjnFMmUJluHG0ROyS1MyA5MNf1arQXPGNGZBIJqwnHLEm8v6zhNpb9t V11o+p+Vf6fXOGMZbVYyTD7Nt8sRD3xyovd6YARsRaRWx6Jm1QKvLuade6jGFZKq4j8WSjk1 W9FZs+n845QKE7+6G4SaJZJVw+7nbOCfUtKBsSDf63G9aTFc8i6jJFPpKgu6A1xs/xRiEwqZ KBkF5+rh1JGHne3iSEgPvxxsmfQyLpW2kH7tUgFCAfipLyrz84K+E+yrfaG9zEY8jqV/D9Kt fFvADUZOkt65AQ0EWsTs3QEIAMUmXjZhfhYA5tg3aau8jB2kph2vl9geVGc+PABv90DgHUOW dKnFdXqaABLtR05amEIWKtkkE8U4Ze5FF4R8f2pMMP5QCWf0DUxI6QZ86PhP0jmyfH6QOPpM BxegjHNnD35CQvfn977lzCdZGetx/H05okwC2rlhU7e+XO62pjUjxj8CNQqbC3KGdkzn30Uv gfipAQb369FuCu83MWPWBNjgZ4eBsActr5c2S6/ltCTshkYWD9YSs/MfUyL8YblZ4xy4Nk5L sl8BKAzl16zuoo9q32Fa/L+7S+6RStY5gaBoISlQUXRrdQBuoPO72BRG3xxRpYfHQiHcKsw8 CCqlINcAEQEAAYkBPAQYAQgAJhYhBClIgufvAUShK4uX2tLlj2mu+xnVBQJaxOzdAhsMBQkD wmcAAAoJENLlj2mu+xnV+9QH/1/VcoiqpSJReuMyDAMcYHOrXhKnMLR/rDxTYn4oBNrGDXh+ vMbMJtxHpaNiFrzkd+QOWc0MU15cJRqCx2hSZNfJDaPEoHSwUs++gFSqaIkS/dLQ0LTL/DBp jKsed8FfV8Ubv/M0AoD8cixAmJLnxlt3G1gLBBkAlv0F53bIdAGJMBJZsZ+1HmzFazknGIR0 LgHZ28PK/QWPwE5gRkIzwTD+hrKJjGcBMach2ZbcAvo47rrRYW1ukbN6L1L5mvTSCh2Gitgp ewig0IiavSVkL3uWpPvAqmr9N9zk/qrHk1EgV+hzNriJhUitpMgrgZQfHYRm4LIhsmJm9TOT N3SWwT0= Message-ID: <73dbadc3-bfdc-df78-e8ce-806fad7695de@yahoo.de> Date: Thu, 10 Jan 2019 19:47:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87r2dkcq5j.fsf@ambrevar.xyz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10.01.19 19:40, Pierre Neidhardt wrote: > Err... The patch is already merged, what did you change? > Sorry... Forgot to pull. Is there anything left keeping us from closing the ticket? From unknown Sun Aug 10 09:11:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Jan 2019 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 33598@debbugs.gnu.org Received: via spool by 33598-submit@debbugs.gnu.org id=B33598.15471462237337 (code B ref 33598); Thu, 10 Jan 2019 18:51:02 +0000 Received: (at 33598) by debbugs.gnu.org; 10 Jan 2019 18:50:23 +0000 Received: from localhost ([127.0.0.1]:54202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfPJ-0001uF-Ry for submit@debbugs.gnu.org; Thu, 10 Jan 2019 13:50:23 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:45709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfPH-0001u6-HC for 33598@debbugs.gnu.org; Thu, 10 Jan 2019 13:50:20 -0500 X-Originating-IP: 86.246.38.102 Received: from mimimi (lfbn-1-802-102.w86-246.abo.wanadoo.fr [86.246.38.102]) (Authenticated sender: mail@ambrevar.xyz) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A4F7D20003; Thu, 10 Jan 2019 18:50:16 +0000 (UTC) References: <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> <877efgin3x.fsf@ambrevar.xyz> <875zv0imr7.fsf@ambrevar.xyz> <87k1jgce5s.fsf@gnu.org> <878szw6rot.fsf@ambrevar.xyz> <874laj35n6.fsf@gnu.org> <87wonf5yd7.fsf@ambrevar.xyz> <87k1jfzd8x.fsf@gnu.org> <87va2z5us6.fsf@ambrevar.xyz> <87r2dkcq5j.fsf@ambrevar.xyz> <73dbadc3-bfdc-df78-e8ce-806fad7695de@yahoo.de> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt In-reply-to: <73dbadc3-bfdc-df78-e8ce-806fad7695de@yahoo.de> Date: Thu, 10 Jan 2019 19:50:16 +0100 Message-ID: <87pnt4cpp3.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) No, I think you can close it. Thank you again for your contribution! From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 10 14:08:46 2019 Received: (at control) by debbugs.gnu.org; 10 Jan 2019 19:08:46 +0000 Received: from localhost ([127.0.0.1]:54229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfh8-0004MP-LZ for submit@debbugs.gnu.org; Thu, 10 Jan 2019 14:08:46 -0500 Received: from sonic304-23.consmr.mail.ir2.yahoo.com ([77.238.179.148]:40716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghfh5-0004M8-J6 for control@debbugs.gnu.org; Thu, 10 Jan 2019 14:08:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1547147317; bh=XBmIMiMIV7Sy7ExjZS6it36k+EpIL12LZcHf7QFaHj0=; h=To:Subject:From:Date:From:Subject; b=DqD0clUMpcHP4krkNCzDagy/21+OOGHKb0U832MAeRRji2+FS0hbs/VvnOJnba313/F7q4BkL6Fcdh0Na6FqGUQUOXCyWOd9uAoXVbjYvqCI1dJarPxcEZIUSSrGewuPbLSPXaPjyHThN0rNw8U5nB/QsSqxUd2uL6/or4Eblq34/+/7Lf+AnO34F/L8KoWw7GZr53TGkBAZA3KUYoxYEj2LBHU/t+McomSsg8aMAVbOBVzByliLciZz2CaRAtFpI2EuMBw/KHl6hQfs2wapBX5kTKaNZJb/CIze0kc0khQPXcieiY7eNhNRiI9r9SZPy0hK0OSNjIvXjuyagd12WA== X-YMail-OSG: Z_xSmzoVM1kLvde2p9N6CcBl2Ky4DmPEDd5W_eFxNNnMXCIBVcJXlxHu_bwJlnc 5uNn1f2BRdr5RLC6eRmeGUYwb6sCK9MDXs6q.1yK8Tq.7GS.w8xFBtefUTTufg_8jwce6xo.nH5x 2CbDwe2JOEXNNoLtxoH5BvL0kDd1DDB.4dfRcx2P9ghblLqMCOWnbpAlgEPLiVdfRiqRtkW3st6q EICYibAhS.A83l8GCOMt0v5vFRa_CIStZHPh6kMTdjvIB618ndA27oqA_FVsWzTe3kw0TutpzSnm z2lFoTKwKvJFXmmKN5gDgVRxSvhRklYQfcL5Ut7pqj0CXUnx9fX7fCBhtl4rx._Fn1w0wL5h3_nT EntS4yor0qHQrhYHs268eYSAhEgBQhf4xbutxLCIG0jiVItt6NTwVC9a_geNfFIzQR0jwmMKDskR oo1gbig2MespQj0Y.czgpjVvCpcYbw21gtHHyWPPQMw1QWRAIs45wyNBhFZrtGJfAcIb1QZ1La8O _lwGQrhdqSfjYwLV83HohW_suR2.s2tvELXgVfn4PSXKNsoq6vRDXvonxpU5zEF.LTze6v52BsQi GG9pD0Wc.IxURG.exHb5kl6eUBVGhmO69XCPoFoVtQYDVnHx9niP_7ROQRP7Et0e5oLx.UVDyQZF YcyY_5MLSEwc6XsHmtYTb6kRajhoJG_776HSPzt9CI.ns0ICmaGdVVFyO9TubaOz0STjvmVjEAmL fQygdwwpfL5h_w.OFz0tXr0Ua3pTqujOHjWsexUxXU32VWK3IPu7vabh4J4nFrAKvEjdLSOs4_L8 hZuEVoCo9nNSE1WN3zMz184Pd_wcRuQ8y7auB0sV5wc_rqemIX3skp8srhXaNB9Sg5ZaQ9Bxb0.f IKiYSRw35Tyf06sFucUp02YmrKzZxXMVxYaqz9HqrKmG_XovFJy5Y6bH.VF5z9TdOAsfL5qbe6z5 Ets01UPIP29AmirLH6bQmdOthp2P7VJJ5AQznijJOG.XlGuQjHVEd_VGr_4mjQuqeKvbJkbxL0Y7 PFyZEqDOXttHTnzEKeNI0WS_HpqPt6tgB7hoUO.sB.UJMxjqQFQ-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Thu, 10 Jan 2019 19:08:37 +0000 Received: from p5B221453.dip0.t-ipconnect.de (EHLO [192.168.178.27]) ([91.34.20.83]) by smtp424.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 620bca351021ca2f346ccc0bfcf33ee0 for ; Thu, 10 Jan 2019 19:08:34 +0000 (UTC) To: control@debbugs.gnu.org Subject: control message for bug #33598 From: Tim Gesthuizen Openpgp: preference=signencrypt Autocrypt: addr=tim.gesthuizen@yahoo.de; prefer-encrypt=mutual; keydata= mQENBFrE7N0BCAC7s3lBzEf8MPAiqYjlD8Z/9TrwMEy2gLZifF3wTgIFVSOujb5gcceS3I64 qur9lCPJycxzl9dOVOBXycXZNMjSrd1VXsmBoBmR54NOOE526eCwfjkbbNhAJ5hPAwGDOvIs s2xKbIBcqfrdNnHIrZt0ohueX6RxEc6HhVTh79GwUjCaux4Jfs0NfNH+We1hyINqMKnIHQ1D kycgyFj1w0HkJiNNZSgKGNeSvqDA4gV/g9uVy25XQA/hsCBHU1teJiSfM8aVw8PA41eUsl9L pCeCTWjWwW+VQWNs5y4I3ZEpY1CAZ/C9OrbCBzNs1ssAT2aOhV3TNrOUkzPBMbLKwel1ABEB AAG0KFRpbSBHZXN0aHVpemVuIDx0aW0uZ2VzdGh1aXplbkB5YWhvby5kZT6JAVMEEwEIAD4W IQQpSILn7wFEoSuLl9rS5Y9prvsZ1QUCWsTs3QIbAwUJA8JnAAULCQgHAgYVCAkKCwIEFgID AQIeAQIXgAAKCRDS5Y9prvsZ1RzzB/ibvqnUyPlhqiLoDtIXPMGOJizkI+6YVGn5M3egrS2I W3ZHBlJMACNhhBY1dYjnFMmUJluHG0ROyS1MyA5MNf1arQXPGNGZBIJqwnHLEm8v6zhNpb9t V11o+p+Vf6fXOGMZbVYyTD7Nt8sRD3xyovd6YARsRaRWx6Jm1QKvLuade6jGFZKq4j8WSjk1 W9FZs+n845QKE7+6G4SaJZJVw+7nbOCfUtKBsSDf63G9aTFc8i6jJFPpKgu6A1xs/xRiEwqZ KBkF5+rh1JGHne3iSEgPvxxsmfQyLpW2kH7tUgFCAfipLyrz84K+E+yrfaG9zEY8jqV/D9Kt fFvADUZOkt65AQ0EWsTs3QEIAMUmXjZhfhYA5tg3aau8jB2kph2vl9geVGc+PABv90DgHUOW dKnFdXqaABLtR05amEIWKtkkE8U4Ze5FF4R8f2pMMP5QCWf0DUxI6QZ86PhP0jmyfH6QOPpM BxegjHNnD35CQvfn977lzCdZGetx/H05okwC2rlhU7e+XO62pjUjxj8CNQqbC3KGdkzn30Uv gfipAQb369FuCu83MWPWBNjgZ4eBsActr5c2S6/ltCTshkYWD9YSs/MfUyL8YblZ4xy4Nk5L sl8BKAzl16zuoo9q32Fa/L+7S+6RStY5gaBoISlQUXRrdQBuoPO72BRG3xxRpYfHQiHcKsw8 CCqlINcAEQEAAYkBPAQYAQgAJhYhBClIgufvAUShK4uX2tLlj2mu+xnVBQJaxOzdAhsMBQkD wmcAAAoJENLlj2mu+xnV+9QH/1/VcoiqpSJReuMyDAMcYHOrXhKnMLR/rDxTYn4oBNrGDXh+ vMbMJtxHpaNiFrzkd+QOWc0MU15cJRqCx2hSZNfJDaPEoHSwUs++gFSqaIkS/dLQ0LTL/DBp jKsed8FfV8Ubv/M0AoD8cixAmJLnxlt3G1gLBBkAlv0F53bIdAGJMBJZsZ+1HmzFazknGIR0 LgHZ28PK/QWPwE5gRkIzwTD+hrKJjGcBMach2ZbcAvo47rrRYW1ukbN6L1L5mvTSCh2Gitgp ewig0IiavSVkL3uWpPvAqmr9N9zk/qrHk1EgV+hzNriJhUitpMgrgZQfHYRm4LIhsmJm9TOT N3SWwT0= Message-ID: Date: Thu, 10 Jan 2019 20:08:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 33598