Subject: bug#33597: closed (Re: [bug#33597] emacs-irony-mode: fetch sources from git)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 04 Dec 2018 10:18:03 +0000

Your bug report

#33597: emacs-irony-mode: fetch sources from git

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
33597: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33597
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#33597] emacs-irony-mode: fetch sources from git
From: [email-masked] (Ludovic Courtès)
To: Tim Gesthuizen <[email-masked]>
Cc: [email-masked]
Date: Tue, 04 Dec 2018 11:17:12 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Tim,

Tim Gesthuizen <[email-masked]> skribis:

>>>From 25a19bd4d43d36f01a4cd03028b6cacf49f1e31b Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <[email-masked]>
> Date: Tue, 27 Nov 2018 18:09:25 +0100
> Subject: [PATCH] gnu: emacs-irony-mode: Fetch source using git.
>
> * gnu/packages/emacs.scm (emacs-irony-mode)[source]: Rewrite in terms of GIT-FETCH.

Applied.  Apologies for letting it fall through the crack when you
initially submitted it.

Thanks,
Ludo’.

Subject: emacs-irony-mode: fetch sources from git
From: Tim Gesthuizen <[email-masked]>
To: [email-masked]
Date: Mon, 3 Dec 2018 14:36:16 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,
the attached patch was not merged with the patchset #33526.
It lets emacs-irony-mode fetch its source via git.

Tim.
>From 25a19bd4d43d36f01a4cd03028b6cacf49f1e31b Mon Sep 17 00:00:00 2001
From: Tim Gesthuizen <[email-masked]>
Date: Tue, 27 Nov 2018 18:09:25 +0100
Subject: [PATCH] gnu: emacs-irony-mode: Fetch source using git.

* gnu/packages/emacs.scm (emacs-irony-mode)[source]: Rewrite in terms of GIT-FETCH.
---
 gnu/packages/emacs.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 073f19b95..b63a9f77e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2811,11 +2811,13 @@ These are distributed in separate files and can be used individually.")
     (version "1.2.0")
     (home-page "https://github.com/Sarcasm/irony-mode")
     (source (origin
-              (method url-fetch)
-              (uri (string-append home-page "/archive/v" version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url (string-append home-page ".git"))
+                    (commit (string-append "v" version))))
               (sha256
                (base32
-                "1f68zi0glkg2aly66s07rx3w0b0hdi1znxan02h6dbabaadylk99"))
+                "0nhjrnlmss535jbshjjd30vydbr8py21vkx4p294w6d8vg2rssf8"))
               (file-name (string-append name "-" version ".tar.gz"))))
     (build-system emacs-build-system)
     (arguments '())
-- 
2.19.2