GNU bug report logs - #33575
[PATCH] guix: lint: Add checker to check if inputs are sorted.

Previous Next

Full log

Message #41 received at 33575 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 33575 <at> debbugs.gnu.org, Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs
 are sorted.
Date: Mon, 10 Dec 2018 19:45:24 +0800

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi,
>
> Arun Isaac <arunisaac <at> systemreboot.net> writes:
>
>>> If they are sorted, I have to add comment for each test input:
>>>
>>>   `(("aspell-dict-en", aspecll-dict-en) ; for test
>>>     ("glib" ,glib "bin")
>>>     ("pkg-config" ,pkg-config)
>>>     ("xmllint" ,libxml2)
>>>     ("xorg-server" ,xorg-server))       ; for test
>>>
>>> Which will be a little annoying...
>>
>> I too find this convincing. It's not a good idea to enforce sorted
>> inputs all the time. If there is sufficient consensus, we can close this
>> bug report.
>
> Maybe our test inputs should have their own field? This would make their
> raison d'être explicit and remove the need of using comments.

Yeah, something like:

  (package
    ...
    (inputs ...)
  (test:inputs ...)
  (test:native-inputs ...))

If we plan to support build packages with tests disabled, this would be
the way to go.  And due to how build works in guix, if tests are
disabled, it would be considered as a different derivation/package, so
the main use case may be:

  - I disable substitute servers to build all packages from sources
    locally.
  - I want to disable tests for some packages as they are too slow...

I don't have this use case now, and seperate package inputs will be a
big change, so I think the current way is totally ok.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.