GNU bug report logs - #33575
[PATCH] guix: lint: Add checker to check if inputs are sorted.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Sun, 2 Dec 2018 07:43:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


Message #35 received at 33575 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 33575 <at> debbugs.gnu.org, 宋文武 <iyzsong <at> member.fsf.org>
Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs
 are sorted.
Date: Sun, 09 Dec 2018 17:49:45 -0500
Hi,

Arun Isaac <arunisaac <at> systemreboot.net> writes:

>> If they are sorted, I have to add comment for each test input:
>>
>>   `(("aspell-dict-en", aspecll-dict-en) ; for test
>>     ("glib" ,glib "bin")
>>     ("pkg-config" ,pkg-config)
>>     ("xmllint" ,libxml2)
>>     ("xorg-server" ,xorg-server))       ; for test
>>
>> Which will be a little annoying...
>
> I too find this convincing. It's not a good idea to enforce sorted
> inputs all the time. If there is sufficient consensus, we can close this
> bug report.

Maybe our test inputs should have their own field? This would make their
raison d'être explicit and remove the need of using comments.

Maxim




This bug report was last modified 6 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.