GNU bug report logs - #33575
[PATCH] guix: lint: Add checker to check if inputs are sorted.

Previous Next

Full log

Message #26 received at 33575 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <at> riseup.net
To: iyzsong <at> member.fsf.org
Cc: 33575 <at> debbugs.gnu.org,
 Guix-patches <guix-patches-bounces+swedebugia=riseup.net <at> gnu.org>,
 Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs
 are sorted.
Date: Fri, 07 Dec 2018 23:58:43 -0800

On 2018-12-08 04:51, iyzsong <at> member.fsf.org wrote:
> Arun Isaac <arunisaac <at> systemreboot.net> writes:
> 
>> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure.
>> (%checkers): Add it.
>> [...]
>>
>> +(define (check-inputs-should-be-sorted package)
>> +  ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE
>> +  ;; are not lexicographically ordered.
> 
> Hello, consider 'gspell', it has some native-inputs for build and some
> for test:
> 
>     (native-inputs
>      `(("glib" ,glib "bin")
>        ("pkg-config" ,pkg-config)
>        ("xmllint" ,libxml2)
> 
>        ;; For tests.
>        ("aspell-dict-en" ,aspell-dict-en)
>        ("xorg-server" ,xorg-server)))
> 
> Currently I'd seperated them by a comment like this.
> 
> If they are sorted, I have to add comment for each test input:
> 
>   `(("aspell-dict-en", aspecll-dict-en) ; for test
>     ("glib" ,glib "bin")
>     ("pkg-config" ,pkg-config)
>     ("xmllint" ,libxml2)
>     ("xorg-server" ,xorg-server))       ; for test
> 
> Which will be a little annoying...

You convinced me sorting is a bad idea. Thanks for providing a good
argument :)

-- 
Cheers 
Swedebugia

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.