From unknown Sat Jun 21 10:45:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33575 <33575@debbugs.gnu.org> To: bug#33575 <33575@debbugs.gnu.org> Subject: Status: [PATCH] guix: lint: Add checker to check if inputs are sorted. Reply-To: bug#33575 <33575@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:45:10 +0000 retitle 33575 [PATCH] guix: lint: Add checker to check if inputs are sorted. reassign 33575 guix-patches submitter 33575 Arun Isaac severity 33575 normal tag 33575 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 02 02:42:59 2018 Received: (at submit) by debbugs.gnu.org; 2 Dec 2018 07:42:59 +0000 Received: from localhost ([127.0.0.1]:57519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTMP5-00010k-A7 for submit@debbugs.gnu.org; Sun, 02 Dec 2018 02:42:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTMP3-00010V-6t for submit@debbugs.gnu.org; Sun, 02 Dec 2018 02:42:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTMOx-0005Yc-0M for submit@debbugs.gnu.org; Sun, 02 Dec 2018 02:42:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_WEB autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36441) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTMOw-0005YW-Tl for submit@debbugs.gnu.org; Sun, 02 Dec 2018 02:42:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTMOw-0007gj-22 for guix-patches@gnu.org; Sun, 02 Dec 2018 02:42:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTMOr-0005Vv-31 for guix-patches@gnu.org; Sun, 02 Dec 2018 02:42:49 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:41124) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTMOq-0005P0-N9 for guix-patches@gnu.org; Sun, 02 Dec 2018 02:42:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=apyJcGGF8INHSwazKRwMU7eCFa2XA8z9mL0O+JcBdtY=; b=jy36/dfWi907rjqqF9Je2qV+xS 8Ia6zi8MxmY9cmyC5cZez7AOTPNAWZCTmrVKNWC4ByGsjQ83f5HD+Qsoiai7Quw4++Pb+qjowH6cZ hvtz6nWptXgsIz4zUOunVTHmCwvhzatbFWrwSN04AaLuyhCwtP0NL7nd9DZ4EZHMRFi8=; Received: from [103.5.134.173] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gTMOl-0003wK-1Z; Sun, 02 Dec 2018 13:12:40 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] guix: lint: Add checker to check if inputs are sorted. Date: Sun, 2 Dec 2018 13:12:10 +0530 Message-Id: <20181202074210.31361-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure. (%checkers): Add it. --- guix/scripts/lint.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 2314f3b28..37e8a1ec5 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2017 Alex Kost ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2017 Efraim Flashner +;;; Copyright © 2018 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -301,6 +302,22 @@ of a package, and INPUT-NAMES, a list of package specifications such as (package-input-intersection (package-direct-inputs package) input-names)))) +(define (check-inputs-should-be-sorted package) + ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE + ;; are not lexicographically ordered. + (define (check-inputs inputs-accessor input-type) + (unless (sorted? (map (match-lambda + ((name input) name)) + (inputs-accessor package)) + string) id 1gToKN-0002HE-FG for submit@debbugs.gnu.org; Mon, 03 Dec 2018 08:31:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gToKJ-0002Gy-UQ for 33575@debbugs.gnu.org; Mon, 03 Dec 2018 08:31:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gToKD-0007C7-JR for 33575@debbugs.gnu.org; Mon, 03 Dec 2018 08:31:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gToKD-0007Bz-GC; Mon, 03 Dec 2018 08:31:49 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=54892 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gToKD-0001Tu-4A; Mon, 03 Dec 2018 08:31:49 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> Date: Mon, 03 Dec 2018 14:31:44 +0100 In-Reply-To: <20181202074210.31361-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Sun, 2 Dec 2018 13:12:10 +0530") Message-ID: <87y3967n3z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Arun Isaac skribis: > * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure. > (%checkers): Add it. > --- > guix/scripts/lint.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm > index 2314f3b28..37e8a1ec5 100644 > --- a/guix/scripts/lint.scm > +++ b/guix/scripts/lint.scm > @@ -8,6 +8,7 @@ > ;;; Copyright =C2=A9 2017 Alex Kost > ;;; Copyright =C2=A9 2017 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2017 Efraim Flashner > +;;; Copyright =C2=A9 2018 Arun Isaac > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -301,6 +302,22 @@ of a package, and INPUT-NAMES, a list of package spe= cifications such as > (package-input-intersection (package-direct-inputs package) > input-names)))) >=20=20 > +(define (check-inputs-should-be-sorted package) > + ;; Emit a warning if inputs, native inputs or propagated inputs of PAC= KAGE > + ;; are not lexicographically ordered. It=E2=80=99s something we rarely do so we=E2=80=99d get warnings for most p= ackages. As a side effect, people may pay less attention to what =E2=80=98guix lint=E2= =80=99 says. As for the goal itself, I think sorting is a good idea when there are lots of inputs (things like IceCat), but otherwise I personally don=E2=80= =99t think it matters that much. What do people think? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 19:42:53 2018 Received: (at 33575) by debbugs.gnu.org; 6 Dec 2018 00:42:53 +0000 Received: from localhost ([127.0.0.1]:34785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUhkd-0004AN-AO for submit@debbugs.gnu.org; Wed, 05 Dec 2018 19:42:52 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:33900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUhkX-0004A6-O5 for 33575@debbugs.gnu.org; Wed, 05 Dec 2018 19:42:45 -0500 Received: by mail-pf1-f174.google.com with SMTP id h3so10870345pfg.1 for <33575@debbugs.gnu.org>; Wed, 05 Dec 2018 16:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8Yi8OVmv6ooDb+uC2QBuhxoQiAIjba+H5YSq6yWCJds=; b=dAMRd9XuPjYirTAwq0vrYZudAg7SQQmWSCOQcDvSgZHrSHnBFzDMQrCe8ktm+97U2d UcjCRsCDfGzz5VS7Y6uYQoLjh+yxxKJ2Nan9XIdL+ZJzXlq00WnBdiOYNlljHq8Tig5A t0f4GtMVCmjwXHe24PRrtpRftHfJQV9xMiGOSYOYnj2SAMQbDfnj7zO8djW1yhKGDZss QDBMx/7bTD6EZbG3mykkjIIqfeEVzYPiHYdcL+B9pK6X+2Rvj6ceH2KN4WJF99Q9rsOK E552uWbPazb7VAhj2bTNyUhbUBbZHW+1/KQEc0wcHRTl5KHdMQ6HMVlYIcuXy/UrreQ4 jTiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8Yi8OVmv6ooDb+uC2QBuhxoQiAIjba+H5YSq6yWCJds=; b=aHmEclt9XRS95xgRMzJRa9fNLJK2gteajh8dAn91F6MaxUQZEX2hZ9EC3O3bFqIsPY pMJI057C+Ce5oBC5lopcsUePopVr4/OTgu4vP94ul1oivAL2xBA1EJ3j2+P5vn+dVtV5 I3WWBWc8DM8phGe5L7gjkXRoNnj2NYShTKc52KmAQ8ja8lBZVOOMQSHyeAKURn6MEook XckK95lqG1So9kmwKhwTbUZYvQ6/2elMHVjxSmNNCSTUXxckVUz0W5qUHOSFQa1gqaqk 6tEP+WSL1fWbWqkEYkzlXvUqIV6NfL/AXq4Ul269HgZVMIlNopgSUhDNox9fh9yYClwP WJTg== X-Gm-Message-State: AA+aEWYOvvwSU0dEK5jgLwPQAcHjEsnm898XHaLKgA8szKpE/3eiidnY hooacCmquzRgBK5v3yZqX4FJ6qHpX5k+ZA== X-Google-Smtp-Source: AFSGD/VjPKj7SzTEPTHjBFuniyU7CjDXm6mN71XlNkX9Tn6epoHMxdDBsk2Ntmko0bj8/7ws+u/2GA== X-Received: by 2002:a62:29c3:: with SMTP id p186mr26937462pfp.117.1544056955485; Wed, 05 Dec 2018 16:42:35 -0800 (PST) Received: from magnolia (95-55-112-238.dynamic.avangarddsl.ru. [95.55.112.238]) by smtp.gmail.com with ESMTPSA id r130sm33700197pfr.48.2018.12.05.16.42.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Dec 2018 16:42:34 -0800 (PST) From: Oleg Pykhalov To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> Date: Thu, 06 Dec 2018 03:42:25 +0300 In-Reply-To: <87y3967n3z.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 03 Dec 2018 14:31:44 +0100") Message-ID: <87k1knpjta.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, ludo@gnu.org (Ludovic Court=C3=A8s) writes: [=E2=80=A6] > It=E2=80=99s something we rarely do so we=E2=80=99d get warnings for most= packages. As > a side effect, people may pay less attention to what =E2=80=98guix lint= =E2=80=99 says. I think this should not stop us from improving a linter and an option like --misc-checks=3Dsort-input,foo,bar could be used for such cases. [=E2=80=A6] Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAlwIcHEACgkQFn+OpQAa +pyBnhAAicRVr9oSkGLOEMlUMqbkj3J3F3j7VbY1c5QCxnD7TOC3GqaaeowLz/OT W6KSQFFvqSZGeJKhRejA2Fkrgh5HAr24+zQxJPqJqn+mtc4O/7Oga5oM/8IJ4frP v6q82YJGaAaE0rTHpiB696L4Ie1IKYCMrHQe3ZwWdum/DA47wU6e+yL+3qI6/zWX vP773ts07wQMn0jL3a69Y/7eFHh/tXJUdrrSdV5IRiuFFDPKIgVG58foGG2BBCsu 0qPknTPk3YURsQ7sV9HXxQQmx6XRJl8tuNWTM9CRrL6H7JkPiFJfFU1ijO8CtCpx O+NkrgAAuOuV40Y/+IdSOa6oNVusE93DS+DQPa70mEgys8ftwERJK6Ln+e1fbc/g ETTEIWIYfKyJcbOq0tykfy7UFSnJEvtHk/VgZB4pCO2TTameR7MmiW+x6PcslBXm L0c+65DlHGrvsXm97bczZiEzNEsERFDJklyxgW7gi466KjpkF52FFRvJiihxfqW5 fKc/f1tAeDz2e+ZgqNNRucdX3AAMw+pNJJ6DGPcE1dy8VeD7SHwY4aohDxeexRjW Slol9vZtg9U7RjziSTRbhp+aFDkzdnJkZtlZsNd+AnJNSVCxmkq7WFzFvjoHMELk hwhV/FQvi9rmfiI6gKUqe3TXBk536HL4OshpCC6/iduHHW9LXYk= =+G1B -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 06 07:31:41 2018 Received: (at 33575) by debbugs.gnu.org; 6 Dec 2018 12:31:41 +0000 Received: from localhost ([127.0.0.1]:35005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUsoa-00085z-MK for submit@debbugs.gnu.org; Thu, 06 Dec 2018 07:31:41 -0500 Received: from mx1.riseup.net ([198.252.153.129]:33897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUsoT-00080Q-FW for 33575@debbugs.gnu.org; Thu, 06 Dec 2018 07:31:34 -0500 Received: from cotinga.riseup.net (cotinga-pn.riseup.net [10.0.1.164]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 9914D1A048C; Thu, 6 Dec 2018 04:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1544099488; bh=ECSeLqU2X6nPCRcR8PzTAIjmT2BHtXEeCh1Mv1cGywc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PVTefeqzr1NntWvJEYbD7A6y+Teq1IptYxkYnKv1hfAGGo4NA6QssxERcrPGvgVcJ OoThSnottEwv8bGhuSq5xPM89Ptul/4EbN4qhZhNKKbor6KXxVo/fFROmrHwhseFxS cQCQnkDlVe4tnSteEBDhoDikcTi7m4CQP64Ck1Ls= X-Riseup-User-ID: 48414DF7AE12CCABB21AA9408DD732D5D1F309D1B411595341A0BE3FA428F1AF Received: from [127.0.0.1] (localhost [127.0.0.1]) by cotinga.riseup.net with ESMTPSA id 30FE78F916; Thu, 6 Dec 2018 04:31:28 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Thu, 06 Dec 2018 04:31:28 -0800 From: swedebugia@riseup.net To: Oleg Pykhalov Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. In-Reply-To: <87k1knpjta.fsf@gmail.com> References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> <87k1knpjta.fsf@gmail.com> Message-ID: <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Guix-patches , ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2018-12-06 01:42, Oleg Pykhalov wrote: > Hello, > > ludo@gnu.org (Ludovic Courtès) writes: > > […] > >> It’s something we rarely do so we’d get warnings for most packages. As >> a side effect, people may pay less attention to what ‘guix lint’ says. > > I think this should not stop us from improving a linter and an option > like --misc-checks=sort-input,foo,bar could be used for such cases. I agree with Oleg here. If many packages needs inputs to be sorted lets write a guix lint --sort modelling the updater (that is make the changes in the work tree to be committed). -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 08:08:22 2018 Received: (at 33575) by debbugs.gnu.org; 7 Dec 2018 13:08:22 +0000 Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVFri-0002Cn-J1 for submit@debbugs.gnu.org; Fri, 07 Dec 2018 08:08:22 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:55915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVFrg-0002Cb-KI for 33575@debbugs.gnu.org; Fri, 07 Dec 2018 08:08:20 -0500 Received: by mail-it1-f196.google.com with SMTP id o19so6712625itg.5 for <33575@debbugs.gnu.org>; Fri, 07 Dec 2018 05:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=LgfDSYBACrPHU6oH4QMvi/0cvu3KUUVssz3DHgn7ino=; b=X3fyM5STlVGGogqrMs2PAL1Zac9pHL1gDnGlu8nu2ESVR2uukTF3g5eq0NwJ7yTg5e 7DsXGdymOuuqHlGcEufVLPEQ6aTqUCUCsEN2s5nauuhk2weVGeG/ECATBrZyMXZKA+M7 0tAJYyrDK4PAclb3onMb+CQXz70nDKbmTlRBDM1q+UyeIS4bZsa5J+Vc9P5MNVmOXpwf kO6u6SGzEDX88Dx0B8+BPhRIxs1BFZjK9rgpR100mZRZ5COKdV6DaeB4/WNhBvQeeqZ1 enRiVWDimt8SDoiUiMovGzUbABxq4NHWbEq+P+Kdmu3DkV3ywGcpXRB1QujP6V65f+Y5 smHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LgfDSYBACrPHU6oH4QMvi/0cvu3KUUVssz3DHgn7ino=; b=qxf49U7EsuL85fZlnVudCDk7mYlMB8r2kCIlxSt1jYawl1d9J96K6L5Wsr9sdf+8nM xHgtQR1EzHT7j2Z2RATY3J1SuDx6qv9KwbhrYp1BqUHdzLUj1rIWgt/Ccy2e4ypz3vHn IjqPjeSNRhV0Z3m+0smBzGhXmtcMgaXG3spciU11aFTZvUTykHzJNFTIjm8YPH0tefY+ F4yeGnfqiREf8yC/dTUJxyFXObFByoRVSYqW9jQ2vbvyxrPHrf61275be+BC2aIcOsI1 SDh5SugLFC2Lc5OrUagozdPvBB+Zd+mLnuNtT1UbZtKf8JrV1vDgUjHaTF6TcU9tei/z 4y5Q== X-Gm-Message-State: AA+aEWazMf2ApKVUOkaCMxMsL5GaLlJ/usggttuCyqdNY2ppuq4JFaQW Vg6IAhqwCv91zOixIpwLBAU= X-Google-Smtp-Source: AFSGD/VzKBTJ5NY2kjW9ggG3GHV+NnG4zQOZoyc4Wjqmsk+CDLJtDU9Xq2MlXKB6LcreBTk8wbnp1g== X-Received: by 2002:a02:1509:: with SMTP id j9mr1738191jad.5.1544188095033; Fri, 07 Dec 2018 05:08:15 -0800 (PST) Received: from apteryx ([45.72.138.75]) by smtp.gmail.com with ESMTPSA id d199sm1913239itd.31.2018.12.07.05.08.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Dec 2018 05:08:14 -0800 (PST) From: Maxim Cournoyer To: swedebugia@riseup.net Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> <87k1knpjta.fsf@gmail.com> <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> Date: Fri, 07 Dec 2018 08:08:13 -0500 In-Reply-To: <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> (swedebugia's message of "Thu, 06 Dec 2018 04:31:28 -0800") Message-ID: <87zhthmqma.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Oleg Pykhalov , Guix-patches X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) swedebugia@riseup.net writes: > On 2018-12-06 01:42, Oleg Pykhalov wrote: >> Hello, >>=20 >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>=20 >> [=E2=80=A6] >>=20 >>> It=E2=80=99s something we rarely do so we=E2=80=99d get warnings for mo= st packages. As >>> a side effect, people may pay less attention to what =E2=80=98guix lint= =E2=80=99 says. >>=20 >> I think this should not stop us from improving a linter and an option >> like --misc-checks=3Dsort-input,foo,bar could be used for such cases. > > I agree with Oleg here.=20 > > If many packages needs inputs to be sorted lets write a guix lint --sort > modelling the updater (that is make the changes in the work tree to be > committed). +1 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 22:51:59 2018 Received: (at 33575) by debbugs.gnu.org; 8 Dec 2018 03:51:59 +0000 Received: from localhost ([127.0.0.1]:37476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVTep-0003B3-Kx for submit@debbugs.gnu.org; Fri, 07 Dec 2018 22:51:59 -0500 Received: from rezeros.cc ([45.76.207.221]:60082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVTek-0003Ao-OD for 33575@debbugs.gnu.org; Fri, 07 Dec 2018 22:51:55 -0500 Received: from localhost (117.173.133.7 [117.173.133.7]) by rezeros.cc (OpenSMTPD) with ESMTPSA id a785033a (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 8 Dec 2018 03:51:50 +0000 (UTC) Received: from gift (localhost.localdomain [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id f91dde2f; Sat, 8 Dec 2018 03:51:43 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Arun Isaac Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> Date: Sat, 08 Dec 2018 11:51:43 +0800 In-Reply-To: <20181202074210.31361-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Sun, 2 Dec 2018 13:12:10 +0530") Message-ID: <87sgz8ekvk.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Arun Isaac writes: > * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure. > (%checkers): Add it. > [...] > > +(define (check-inputs-should-be-sorted package) > + ; ; Emit a warning if inputs, native in [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Arun Isaac writes: > * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure. > (%checkers): Add it. > [...] > > +(define (check-inputs-should-be-sorted package) > + ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE > + ;; are not lexicographically ordered. Hello, consider 'gspell', it has some native-inputs for build and some for test: (native-inputs `(("glib" ,glib "bin") ("pkg-config" ,pkg-config) ("xmllint" ,libxml2) ;; For tests. ("aspell-dict-en" ,aspell-dict-en) ("xorg-server" ,xorg-server))) Currently I'd seperated them by a comment like this. If they are sorted, I have to add comment for each test input: `(("aspell-dict-en", aspecll-dict-en) ; for test ("glib" ,glib "bin") ("pkg-config" ,pkg-config) ("xmllint" ,libxml2) ("xorg-server" ,xorg-server)) ; for test Which will be a little annoying... From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 00:09:27 2018 Received: (at 33575) by debbugs.gnu.org; 8 Dec 2018 05:09:27 +0000 Received: from localhost ([127.0.0.1]:37499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVUrn-0005G4-Jy for submit@debbugs.gnu.org; Sat, 08 Dec 2018 00:09:27 -0500 Received: from tobias.gr ([80.241.217.52]:56280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVUrl-0005Fv-Ux for 33575@debbugs.gnu.org; Sat, 08 Dec 2018 00:09:26 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 2e2de1ed; Sat, 8 Dec 2018 05:09:23 +0000 (UTC) Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ff2ab3be (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 8 Dec 2018 05:09:20 +0000 (UTC) From: Tobias Geerinckx-Rice To: Ludovic =?us-ascii?Q?=3D=3Futf-8=3FQ=3FCourt=3DC3=3DA8s=3F=3D?= Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. Date: Tue, 04 Dec 2018 10:13:14 +0100 Message-ID: <87woopk639.fsf@nckx> References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> In-reply-to: <87y3967n3z.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludo', Arun, Ludovic Court=C3=A8s wrote: >> + ;; Emit a warning if inputs, native inputs or propagated=20 >> inputs >> of PACKAGE >> + ;; are not lexicographically ordered. > > It's something we rarely do so we'd get warnings for most > packages. As > a side effect, people may pay less attention to what =E2=80=98guix lint= =E2=80=99 > says. Even I agree :-) There are valid reasons not to sort them. > As for the goal itself, I think sorting is a good idea when > there are > lots of inputs (things like IceCat), but otherwise I personally > don't > think it matters that much. Do we already check for duplication? I sometimes order inputs for the same reason I sort module=20 imports: to catch duplicates. These are usually harmless and=20 produce no errors. Kind regards, T G-R From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 02:58:47 2018 Received: (at 33575) by debbugs.gnu.org; 8 Dec 2018 07:58:47 +0000 Received: from localhost ([127.0.0.1]:37534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVXVe-0001TZ-UJ for submit@debbugs.gnu.org; Sat, 08 Dec 2018 02:58:47 -0500 Received: from mx1.riseup.net ([198.252.153.129]:33187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVXVd-0001TR-0V for 33575@debbugs.gnu.org; Sat, 08 Dec 2018 02:58:45 -0500 Received: from cotinga.riseup.net (cotinga-pn.riseup.net [10.0.1.164]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id C20241A0408; Fri, 7 Dec 2018 23:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1544255924; bh=1TRH0W7LcIZZg1xwAoQ5OPWLkrSIS4K6+kda4hb7xog=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oaS8bCWgqrood4FhF/PLJgd0R29e3WhSz4PUGL9eKb+cSg4ya1G9z+wVMURvvQS08 AIkTVLHpd91iBe4rhvZ1OGp7FZSFK82mMPo9p1/ZZn19CaGaSDwVl+gi8r2FrA+PKT eyQE86f5CfsZX1Qz0MLn+IyQYhAtPYMVIX3Tgm6A= X-Riseup-User-ID: 1E593CC1ABAC2929A83708B5EC1EFCE25C5FB52092DD8A25C1264466B1D565F6 Received: from [127.0.0.1] (localhost [127.0.0.1]) by cotinga.riseup.net with ESMTPSA id 84F51E9A94; Fri, 7 Dec 2018 23:58:43 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 07 Dec 2018 23:58:43 -0800 From: swedebugia@riseup.net To: iyzsong@member.fsf.org Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. In-Reply-To: <87sgz8ekvk.fsf@member.fsf.org> References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> Message-ID: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Guix-patches , Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2018-12-08 04:51, iyzsong@member.fsf.org wrote: > Arun Isaac writes: > >> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure. >> (%checkers): Add it. >> [...] >> >> +(define (check-inputs-should-be-sorted package) >> + ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE >> + ;; are not lexicographically ordered. > > Hello, consider 'gspell', it has some native-inputs for build and some > for test: > > (native-inputs > `(("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > > ;; For tests. > ("aspell-dict-en" ,aspell-dict-en) > ("xorg-server" ,xorg-server))) > > Currently I'd seperated them by a comment like this. > > If they are sorted, I have to add comment for each test input: > > `(("aspell-dict-en", aspecll-dict-en) ; for test > ("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > ("xorg-server" ,xorg-server)) ; for test > > Which will be a little annoying... You convinced me sorting is a bad idea. Thanks for providing a good argument :) -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 08:30:08 2018 Received: (at 33575) by debbugs.gnu.org; 8 Dec 2018 13:30:08 +0000 Received: from localhost ([127.0.0.1]:37769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVcgJ-0008TD-Oh for submit@debbugs.gnu.org; Sat, 08 Dec 2018 08:30:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVcgI-0008S8-6k for 33575@debbugs.gnu.org; Sat, 08 Dec 2018 08:30:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVcgB-0005qc-6j for 33575@debbugs.gnu.org; Sat, 08 Dec 2018 08:30:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVcgA-0005oy-R8; Sat, 08 Dec 2018 08:29:59 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38106 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gVcgA-0006cL-IP; Sat, 08 Dec 2018 08:29:58 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> <87woopk639.fsf@nckx> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 Frimaire an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 08 Dec 2018 14:29:57 +0100 In-Reply-To: <87woopk639.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 04 Dec 2018 10:13:14 +0100") Message-ID: <87zhtg87u2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Tobias Geerinckx-Rice skribis: > Ludovic Court=C3=A8s wrote: [...] >> As for the goal itself, I think sorting is a good idea when >> there are >> lots of inputs (things like IceCat), but otherwise I personally >> don't >> think it matters that much. > > Do we already check for duplication? No but it would be a worthy check! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 08:35:02 2018 Received: (at 33575) by debbugs.gnu.org; 8 Dec 2018 13:35:02 +0000 Received: from localhost ([127.0.0.1]:37773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVcl4-0000Bc-Ee for submit@debbugs.gnu.org; Sat, 08 Dec 2018 08:35:02 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:42742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVcl2-0000B8-3b for 33575@debbugs.gnu.org; Sat, 08 Dec 2018 08:35:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wd0zpHnx9zSs4omZaPlhyPe6kVxXuLF2wC9BqhHMi4U=; b=d4kzuFZWLojJ/DmypS3drng51 BgR0Q9M+cTh6L18BjpvzCODWA7UfZFyIlrxHL8kSUm0nn2z+giWzC75s0u/xjBK1H/ZC2r9hP8wOa ublqDHZPsbYh4NG/D1W2PxbbDzJhoxOgQUB4YEf/v4ZD9IHeQkR8YixVKpZOGoBXUcJLc=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gVckx-0007P4-LI; Sat, 08 Dec 2018 19:04:56 +0530 From: Arun Isaac To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. In-Reply-To: <87sgz8ekvk.fsf@member.fsf.org> References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> Date: Sat, 08 Dec 2018 19:04:47 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > If they are sorted, I have to add comment for each test input: > > `(("aspell-dict-en", aspecll-dict-en) ; for test > ("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > ("xor [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > If they are sorted, I have to add comment for each test input: > > `(("aspell-dict-en", aspecll-dict-en) ; for test > ("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > ("xorg-server" ,xorg-server)) ; for test > > Which will be a little annoying... I too find this convincing. It's not a good idea to enforce sorted inputs all the time. If there is sufficient consensus, we can close this bug report. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 17:49:54 2018 Received: (at 33575) by debbugs.gnu.org; 9 Dec 2018 22:49:54 +0000 Received: from localhost ([127.0.0.1]:40362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW7ta-0008GB-An for submit@debbugs.gnu.org; Sun, 09 Dec 2018 17:49:54 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:38486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW7tY-0008Fx-Pi for 33575@debbugs.gnu.org; Sun, 09 Dec 2018 17:49:53 -0500 Received: by mail-it1-f196.google.com with SMTP id h65so15170664ith.3 for <33575@debbugs.gnu.org>; Sun, 09 Dec 2018 14:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=RN7Ty+bYSxAGtE1T9KzYYGtBgoCXFYHaoPCgGxjQcS8=; b=csR4t1iGFpggTuZjeOyL2TzJyheIqaBwpDLvWlDFPc1U10e118kiZScnmpdQDhKam6 aqhajUekAeqQ0fEsf0NBNLPX2DtTzPXl2OFiHsNPE98AygdJSLW+VAfMN9gvGotrjOyB 4INd8FCPBZO0FVGQkM64+ZIAxrJHs6QFjQZV7wHMoEEIwQK7SRWe1f/mzg4nqebeahA4 vX+7bsYsWLCbVuImrhZ3NbDOd1H3VDzOR/5STLXsPQnWrUOJgKc5URsjLnM0ceVTKVyo gZq2HwSaZnfEgLEJzxccGpwQkyqx803wVp4kvPOfLGhwY72tkWL3BwcVL58Ys3jj1gr+ zGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=RN7Ty+bYSxAGtE1T9KzYYGtBgoCXFYHaoPCgGxjQcS8=; b=eDq2k+8BQ1Y7M+UJDmiOenHnAfAIxxtfF1rukVjbRxFBDIQfWuxwW7sWhvKGHzVCSZ QDe7jHqBGbi7cyXhyEP+lN0Qnp0MI6zQVOc6EqIYQrASxOFlX20YoyQIn5M5NGM3ad2d x6JEVQdEjhXKAsp9JRgt9vAvmbhX+1Nj7lApqfiJSRRk26bhWSQ9snoA4jSWvO8ouWoL W+debq1Zhlk1bX/r3k66xa2Nx2aN+0KCQ+lY5q/4xHZP+Zum7wLAkZ4aFAOxUPRnSJFB I7pSgoskA/+DyC16HOYtcE+r94fgJ4jRmKacDgf79yBEyEqthpdMvtEibd08h9XKQiJL tFxA== X-Gm-Message-State: AA+aEWbxuYYrXSgksZjNRtrxGAGwuWlr6oDFaiK3hsIPpW0oiv2alIK/ 6Dmotlkac6t0jr8Wq4z8+dqT2QWj97s= X-Google-Smtp-Source: AFSGD/VtNs7G6UXavmmUNfl73JZjV2yV1/qUYdrCGOQXPFzzZlajRMSWO9DdGt0uTO49+d4i4kOncw== X-Received: by 2002:a24:be06:: with SMTP id i6mr8117176itf.168.1544395787066; Sun, 09 Dec 2018 14:49:47 -0800 (PST) Received: from apteryx ([45.72.138.75]) by smtp.gmail.com with ESMTPSA id f21sm4793460itc.14.2018.12.09.14.49.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Dec 2018 14:49:46 -0800 (PST) From: Maxim Cournoyer To: Arun Isaac Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> Date: Sun, 09 Dec 2018 17:49:45 -0500 In-Reply-To: (Arun Isaac's message of "Sat, 08 Dec 2018 19:04:47 +0530") Message-ID: <87efaql3hy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, =?utf-8?B?5a6L5paH5q2m?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Arun Isaac writes: >> If they are sorted, I have to add comment for each test input: >> >> `(("aspell-dict-en", aspecll-dict-en) ; for test >> ("glib" ,glib "bin") >> ("pkg-config" ,pkg-config) >> ("xmllint" ,libxml2) >> ("xorg-server" ,xorg-server)) ; for test >> >> Which will be a little annoying... > > I too find this convincing. It's not a good idea to enforce sorted > inputs all the time. If there is sufficient consensus, we can close this > bug report. Maybe our test inputs should have their own field? This would make their raison d'=C3=AAtre explicit and remove the need of using comments. Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 06:19:39 2018 Received: (at 33575) by debbugs.gnu.org; 10 Dec 2018 11:19:39 +0000 Received: from localhost ([127.0.0.1]:40772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWJb9-00060G-Eo for submit@debbugs.gnu.org; Mon, 10 Dec 2018 06:19:39 -0500 Received: from rezeros.cc ([45.76.207.221]:60456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWJb5-000603-UA for 33575@debbugs.gnu.org; Mon, 10 Dec 2018 06:19:36 -0500 Received: from localhost (117.176.201.45 [117.176.201.45]) by rezeros.cc (OpenSMTPD) with ESMTPSA id bc0e300b (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 10 Dec 2018 11:19:31 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id fc42d119; Mon, 10 Dec 2018 11:19:26 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Arun Isaac Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> Date: Mon, 10 Dec 2018 19:19:26 +0800 In-Reply-To: (Arun Isaac's message of "Sat, 08 Dec 2018 19:04:47 +0530") Message-ID: <87a7ldmxxd.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Arun Isaac writes: >> If they are sorted, I have to add comment for each test input: >> >> `(("aspell-dict-en", aspecll-dict-en) ; for test >> ("glib" ,glib "bin") >> ("pkg-config" ,pkg-config) >> ("xmllint" ,libxml2) > [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Arun Isaac writes: >> If they are sorted, I have to add comment for each test input: >> >> `(("aspell-dict-en", aspecll-dict-en) ; for test >> ("glib" ,glib "bin") >> ("pkg-config" ,pkg-config) >> ("xmllint" ,libxml2) >> ("xorg-server" ,xorg-server)) ; for test >> >> Which will be a little annoying... > > I too find this convincing. It's not a good idea to enforce sorted > inputs all the time. If there is sufficient consensus, we can close this > bug report. Yes, I think so. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 06:45:36 2018 Received: (at 33575) by debbugs.gnu.org; 10 Dec 2018 11:45:36 +0000 Received: from localhost ([127.0.0.1]:40782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWK0G-0006lw-Bb for submit@debbugs.gnu.org; Mon, 10 Dec 2018 06:45:36 -0500 Received: from rezeros.cc ([45.76.207.221]:60464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWK0D-0006lj-VK for 33575@debbugs.gnu.org; Mon, 10 Dec 2018 06:45:34 -0500 Received: from localhost (117.176.201.45 [117.176.201.45]) by rezeros.cc (OpenSMTPD) with ESMTPSA id 89c43a5c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 10 Dec 2018 11:45:30 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 692b3755; Mon, 10 Dec 2018 11:45:24 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Maxim Cournoyer Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> <87efaql3hy.fsf@gmail.com> Date: Mon, 10 Dec 2018 19:45:24 +0800 In-Reply-To: <87efaql3hy.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 09 Dec 2018 17:49:45 -0500") Message-ID: <875zw1mwq3.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Maxim Cournoyer writes: > Hi, > > Arun Isaac writes: > >>> If they are sorted, I have to add comment for each test input: >>> >>> `(("aspell-dict-en", aspecll-dict-en) ; for test >>> ("glib" ,gli [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 33575 Cc: 33575@debbugs.gnu.org, Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Maxim Cournoyer writes: > Hi, > > Arun Isaac writes: > >>> If they are sorted, I have to add comment for each test input: >>> >>> `(("aspell-dict-en", aspecll-dict-en) ; for test >>> ("glib" ,glib "bin") >>> ("pkg-config" ,pkg-config) >>> ("xmllint" ,libxml2) >>> ("xorg-server" ,xorg-server)) ; for test >>> >>> Which will be a little annoying... >> >> I too find this convincing. It's not a good idea to enforce sorted >> inputs all the time. If there is sufficient consensus, we can close this >> bug report. > > Maybe our test inputs should have their own field? This would make their > raison d'=C3=AAtre explicit and remove the need of using comments. Yeah, something like: (package ... (inputs ...) (test:inputs ...) (test:native-inputs ...)) If we plan to support build packages with tests disabled, this would be the way to go. And due to how build works in guix, if tests are disabled, it would be considered as a different derivation/package, so the main use case may be: - I disable substitute servers to build all packages from sources locally. - I want to disable tests for some packages as they are too slow... I don't have this use case now, and seperate package inputs will be a big change, so I think the current way is totally ok. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 18 15:37:06 2018 Received: (at 33575-done) by debbugs.gnu.org; 18 Dec 2018 20:37:06 +0000 Received: from localhost ([127.0.0.1]:53745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZM6z-0002Z2-Ph for submit@debbugs.gnu.org; Tue, 18 Dec 2018 15:37:05 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:41326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZM6x-0002Yr-JP for 33575-done@debbugs.gnu.org; Tue, 18 Dec 2018 15:37:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wiQKk2+Ezwdo7msjb97TYU7V8R7gaGRah9kAdbO2Zpk=; b=n1yAVW+36Z7ySxw4gW//2pAV+ rRb3HDHJYZwiOiP+yJIwJYrRw8QG+cPxkoqvDASKtW0U+ni5R/Fw33f0gO42Shb8VhuG1jJsA2ojW XhyrEQX5npzKNHgDrWdb9W0vplifqU1lymBUH/onxEdFsEdfe263adPyp/q1dPwLzudws=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gZM6u-0002LF-66 for 33575-done@debbugs.gnu.org; Wed, 19 Dec 2018 02:07:01 +0530 From: Arun Isaac To: 33575-done@debbugs.gnu.org Subject: Re: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. In-Reply-To: <87a7ldmxxd.fsf@member.fsf.org> References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> <87a7ldmxxd.fsf@member.fsf.org> Date: Wed, 19 Dec 2018 02:06:51 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I'm closing this bug report since I believe we have reached a consensus that this patch is unnecessary. Thank you all for your thoughts! Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_PASS SPF: sender matches SPF record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] X-Debbugs-Envelope-To: 33575-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I'm closing this bug report since I believe we have reached a consensus that this patch is unnecessary. Thank you all for your thoughts! Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager I'm closing this bug report since I believe we have reached a consensus that this patch is unnecessary. Thank you all for your thoughts! From unknown Sat Jun 21 10:45:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Jan 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator