From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 02 01:46:26 2018 Received: (at submit) by debbugs.gnu.org; 2 Dec 2018 06:46:26 +0000 Received: from localhost ([127.0.0.1]:57474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTLWL-0007oe-O2 for submit@debbugs.gnu.org; Sun, 02 Dec 2018 01:46:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTKrN-0006Zs-Hu for submit@debbugs.gnu.org; Sun, 02 Dec 2018 01:04:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTKrH-000391-SS for submit@debbugs.gnu.org; Sun, 02 Dec 2018 01:04:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTKrH-00038s-PR for submit@debbugs.gnu.org; Sun, 02 Dec 2018 01:03:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTKrH-0002Oa-3D for bug-automake@gnu.org; Sun, 02 Dec 2018 01:03:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTKrD-000309-UL for bug-automake@gnu.org; Sun, 02 Dec 2018 01:03:59 -0500 Received: from mailhub.air.net.au ([121.127.198.92]:39956) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTKrD-0002xt-H2 for bug-automake@gnu.org; Sun, 02 Dec 2018 01:03:55 -0500 Received: by mailhub.air.net.au (Postfix, from userid 500) id E209E12009E; Sun, 2 Dec 2018 17:03:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=air.net.au; s=mail; t=1543730628; bh=G5eAL/K90s85vtqLdLzthoFcIh2NHQ10KSZHWYMiYgk=; h=Date:From:To:Subject:From; b=Vtl4CSo2VGT8Qn8dYVQ7gHYlUg9IxxBNz1jMzd1AdZ1F9Tlsdl+gbQOZ3GQ1IBO17 WdYmOR7Dkf2Pvefw3ppAc2YxXSg6qcv7nr+T3V2t/7Jw33QQ/OhNJspBykxlSpBAGi FtfeRwzN7Ws4bfvz2PnhRVJSGAVPYJtgMKOe042A= Date: Sun, 2 Dec 2018 17:03:48 +1100 From: Ben Elliston To: bug-automake@gnu.org Subject: --add-missing behaviour Message-ID: <20181202060348.htzcz3xww4dw5ztk@air.net.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gjrelujiff2witms" Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 02 Dec 2018 01:46:24 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) --gjrelujiff2witms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I ran 'automake --add-missing' to copy mdate-sh to my project. This, of course, creates a symbolic link to the automake install tree. Remembering this, I then ran 'automake --add-missing -c' to copy the script instead. Since mdate-sh was already present in my tree, automake did nothing. When passing -c, I think automake should replace the symbolic link (if and only if it is a symbolic link). Ben --gjrelujiff2witms Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEFS8+rdM1/2KWERKFZ9rcPj90NkkFAlwDdcQACgkQZ9rcPj90 NklV9hAAimtJnSMKM8KM4WR/SbQ/ibCBFR+cqi6bQCdEvVubX4zXbqfHmtmG/Ckn zK4bv8f0jdEc01YCbAt1oRw+JVNRH7YTpwOo5n8K+6DG9L1+w2J7IRbfAMwClB87 84Emh3ZfJUttQM7YkCoGslMPELWF+w94/M26UK/x5AX4cWWIA3HDT37Zfu5SvlvD hFOciQ6KH4Z0aMTeDELGYWODAAK8ATaEX3go6qL6H7lECqRXsrhUC0mfcJPqIjvE n9fK0w0APw1JwY1PPEyQ7cWyRWWo0CsSWf0dVS3UFR/eHXakkqQsWXJztdwfsxGL oIiDFyX+Lm6IBqPAglh5uqGiF4md3Hf6gMhkxlh1W1YsvWeH8CUdCizTn1+xsi+n GnKYtRcfMergcqwGn3nkCQRiueN9+CGvpyJyCrdhER6d2JzYhVnsuO9qN1jBiPX9 I0Q1FSQjW5jsNUKPEf8+lTuNH1/v45xRdqoh2BmcI2yVkXMb1cPmvwCAwXotTOaf M97xpauhi7jqhpv9E+BUnvoxV50jrKoBTAW7Zb+UF6/Dfa2c2IN3/ymH2WDCr7X3 Jbz1u7MAiyXV5yEGjzhaaEDrBFl2mz0AjNNP9H9acCEHJo61iy3djH+KKktmHrh5 dH+sHxWMCQxkfWng0XoVOSbEgygSyJZAci2RsBRbsJVfIGP9JNE= =twsI -----END PGP SIGNATURE----- --gjrelujiff2witms-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 02:14:55 2021 Received: (at control) by debbugs.gnu.org; 10 Dec 2021 07:14:55 +0000 Received: from localhost ([127.0.0.1]:45372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mva7L-0005NU-ER for submit@debbugs.gnu.org; Fri, 10 Dec 2021 02:14:55 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:57516 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mva7J-0005NH-MF for control@debbugs.gnu.org; Fri, 10 Dec 2021 02:14:53 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 3C235342E81; Fri, 10 Dec 2021 07:14:48 +0000 (UTC) Date: Fri, 10 Dec 2021 02:14:54 -0500 From: Mike Frysinger To: control@debbugs.gnu.org Message-ID: Mail-Followup-To: control@debbugs.gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) tag 33573 confirmed severity 33573 wishlist From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 19 03:40:48 2022 Received: (at control) by debbugs.gnu.org; 19 Jan 2022 08:40:49 +0000 Received: from localhost ([127.0.0.1]:52300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA6WO-0003Hp-Ql for submit@debbugs.gnu.org; Wed, 19 Jan 2022 03:40:48 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:58788 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA6WN-0003Hb-QZ for control@debbugs.gnu.org; Wed, 19 Jan 2022 03:40:48 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 50A6334317D; Wed, 19 Jan 2022 08:40:42 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20220119084042.50A6334317D@smtp.gentoo.org> Date: Wed, 19 Jan 2022 08:40:42 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) retitle 33573 --add-missing --copy should replace symlinks with real files tag 33573 = confirmed help easy thankyou From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 05:04:11 2022 Received: (at submit) by debbugs.gnu.org; 29 Dec 2022 10:04:12 +0000 Received: from localhost ([127.0.0.1]:59297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAplh-00049x-6R for submit@debbugs.gnu.org; Thu, 29 Dec 2022 05:04:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:40634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAdZh-00060J-5o for submit@debbugs.gnu.org; Wed, 28 Dec 2022 16:02:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAdZg-0006yZ-6N for automake-patches@gnu.org; Wed, 28 Dec 2022 16:02:56 -0500 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAdZe-0004T1-3h for automake-patches@gnu.org; Wed, 28 Dec 2022 16:02:55 -0500 Received: from [192.168.1.226] ([90.227.12.124]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M2f9b-1p89GW3IOF-004EPL for ; Wed, 28 Dec 2022 22:02:51 +0100 Content-Type: multipart/mixed; boundary="------------Zj7LULAxk2rUsT0yYqmm5up6" Message-ID: Date: Wed, 28 Dec 2022 22:02:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: automake-patches@gnu.org Content-Language: en-GB, sv-SE From: Bogdan Subject: [bug#33573] Patch to replace symlinks with files X-Provags-ID: V03:K1:L8SI0p92DYEB1gIbh0fA72+hvdv9z6eo9KFq1xn/mEEy6ssPJWC 4EUfaQdQ2fI3apKQYoM0yJv18OB+dzY2nR62RcjEvT+p4BM1NDHXeR/dXSpMu0Y+YAh05IZ EzZmVuELyyrIFw/Wnu3yxQMm+uullyAmxk/1WK0aKC7p+13XjlXCwFFk5bQpN/zHPWJ2f24 n6bm9wguv7e6jo45tIrQw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:D3e5Ihky2/4=;J8iuRZ+uMq5h3En7oVNN71RKvwP QMm0EP27D9fgk0Boe8eVxkjMywhxlCR30cCGR1DshcKi27CdbsSEKY3BS97Sft8NEBi9Be2Qa W+B9tAX0Qq9mFVxBHh9UGOWn8x+OYOpHF2wdFHWQwy4X8anCHT4bDx1qokqcw+SwdHa+wj1jJ ehDjeFtPs2MsNXk8T2j4qxtx8gH8zs1gi0Bw/EfSPumhRlPx62ec12BwA7sV31VP+VEW+SMTx VyeItRDE1FwiMvbnJffO4t1H/P6kkhl3mpOkuqMKxd8KRgKq17IoBp62Skf3bZOfLhfwEWFhw 8vS1S2sT/vpUGsdsC04B221Ag/0eG/rtXpovdSQn4cTlfIsbX/t7AdCcXF+Q3qyj89IWd5Npo qVsE6lWDLwKRFWpXB7KLqZUs89syLGDPzs/H9/lTFRD0FmZMGFWw84cKf93PeqGEOaXAAAdS0 b4w628S34Iwp0rmoQuuO5Vw3TK2vOUD+1Po6SWnGw+vPthXQiNX3gHeop6R5m7JhWKq9VBmnn crSjMdCxA3F8j/vGD15ZyyaQ9JBUVB+F9nzvpA4BiYYkijTZF1qn5Dah5nZujkUMLKM/hle/K 6JDRs9oUjffJ+HLqRI64wsm2kvlPsrTpvj/yWUPuzOq7IrRh7S7+10QjjUUV+jQMZcvWxp+ac kCp1d5Voh8c/Wmu2Mw4JJOgJhbzjyhFiGfw+uHcEs6tfoS5s1boxSW0BGNNHCf80S/v91PCzS zLX5SBe5YUqA/qbtFj2KMK4hPowYoVdmqRDQdqZ+vQLKT8QeQ8/Ma9+1D4TPU8SjYeV5uJvoF KbaPYqnCfwLQlfpAF6bgRNUK0Xnm5YpTWRwvRNR6W8WLarw1booMHrAhnoSziXPjhQNa7KWhr Gv/GB/D/3IEe1AYF/7FSMzOET4vASQ/BWBX1xO+uEZ44nyI0pkdd3A4ONq/mPPFh9B+PHTc08 Nk2kKFfz0e84xiDW+dEWZorp0J8= Received-SPF: pass client-ip=212.227.17.22; envelope-from=bogdro_rep@gmx.us; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 29 Dec 2022 05:04:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a multi-part message in MIME format. --------------Zj7LULAxk2rUsT0yYqmm5up6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Automake gurus. Another simple patch from my side: when '--copy' given to '--add-missing', copy the standard files even if symlinks already exist. Basically, the patch adds "if --copy given and a link exists, do NOT exit" (+ a double-check of the object type if that would be needed on some systems). This may simplify the things for some users, although you may as well update the documentation to say that giving "--force-missing" would produce the same result. Regards, Bogdan Drozdowski -- Regards - Bogdan ('bogdro') D. (GNU/Linux & FreeDOS) X86 assembly (DOS, GNU/Linux): http://bogdro.evai.pl/index-en.php Soft(EN): http://bogdro.evai.pl/soft http://bogdro.evai.pl/soft4asm www.Xiph.org www.TorProject.org www.LibreOffice.org www.GnuPG.org --------------Zj7LULAxk2rUsT0yYqmm5up6 Content-Type: text/x-patch; charset=UTF-8; name="automake-missing-link-to-file-mail.diff" Content-Disposition: attachment; filename="automake-missing-link-to-file-mail.diff" Content-Transfer-Encoding: base64 RnJvbSBkNjdiODU4ZDAyNTRlMzI1MmYwYTYzMjcwZDI2MjEzMTdjNTEyMTI3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCb2dkYW4gRHJvemRvd3NraSA8PgpEYXRlOiBNb24s IDI2IERlYyAyMDIyIDE4OjI2OjI4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQ29weSBtaXNz aW5nIGZpbGVzIGlmIC0tY29weSBnaXZlbiBidXQgYSBsaW5rIGV4aXN0cyAoYnVnCiAzMzU3 MykKCi0tLQogYmluL2F1dG9tYWtlLmluICAgICAgICAgICB8ICA0ICsrLS0KIHQvbGlzdC1v Zi10ZXN0cy5tayAgICAgICAgfCAgMSArCiB0L21pc3NpbmctbGluay10by1maWxlLnNoIHwg NDIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNo YW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx MDA2NDQgdC9taXNzaW5nLWxpbmstdG8tZmlsZS5zaAoKZGlmZiAtLWdpdCBhL2Jpbi9hdXRv bWFrZS5pbiBiL2Jpbi9hdXRvbWFrZS5pbgppbmRleCBjMDk0MjM0YmMuLmRjNDcxN2YwZiAx MDA2NDQKLS0tIGEvYmluL2F1dG9tYWtlLmluCisrKyBiL2Jpbi9hdXRvbWFrZS5pbgpAQCAt NzY0Nyw3ICs3NjQ3LDcgQEAgc3ViIHJlcXVpcmVkX2ZpbGVfY2hlY2tfb3JfY29weQogICAj ICctLWZvcmNlLW1pc3NpbmcnIG9ubHkgaGFzIGFuIGVmZmVjdCBpZiAnLS1hZGQtbWlzc2lu ZycgaXMKICAgIyBzcGVjaWZpZWQuCiAgIHJldHVybgotICAgIGlmICRmb3VuZF9pdCAmJiAo ISAkYWRkX21pc3NpbmcgfHwgISAkZm9yY2VfbWlzc2luZyk7CisgICAgaWYgJGZvdW5kX2l0 ICYmICghICRhZGRfbWlzc2luZyB8fCAoISAkZm9yY2VfbWlzc2luZyAmJiAhICgkY29weV9t aXNzaW5nICYmIC1sICRmdWxsZmlsZSkpKTsKIAogICAjIElmIHdlJ3ZlIGFscmVhZHkgbG9v a2VkIGZvciBpdCwgd2UncmUgZG9uZS4gIFlvdSBtaWdodCB3b25kZXIgd2h5IHdlCiAgICMg ZG9uJ3QgZG8gdGhpcyBiZWZvcmUgc2VhcmNoaW5nIGZvciB0aGUgZmlsZS4gIElmIHdlIGRv IHRoYXQsIHRoZW4KQEAgLTc2OTMsNyArNzY5Myw3IEBAIHN1YiByZXF1aXJlZF9maWxlX2No ZWNrX29yX2NvcHkKIAogICAgICAgICAgICMgV2luZG93cyBQZXJsIHdpbGwgaGFuZyBpZiB3 ZSB0cnkgdG8gZGVsZXRlIGEKICAgICAgICAgICAjIGZpbGUgdGhhdCBkb2Vzbid0IGV4aXN0 LgotICAgICAgICAgIHVubGluayAoJGZ1bGxmaWxlKSBpZiAtZiAkZnVsbGZpbGU7CisgICAg ICAgICAgdW5saW5rICgkZnVsbGZpbGUpIGlmICgtZiAkZnVsbGZpbGUgb3IgLWwgJGZ1bGxm aWxlKTsKICAgICAgICAgICBpZiAoJHN5bWxpbmtfZXhpc3RzICYmICEgJGNvcHlfbWlzc2lu ZykKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgaWYgKCEgc3ltbGluayAoIiRsaWJk aXIvJGZpbGUiLCAkZnVsbGZpbGUpCmRpZmYgLS1naXQgYS90L2xpc3Qtb2YtdGVzdHMubWsg Yi90L2xpc3Qtb2YtdGVzdHMubWsKaW5kZXggZDgyY2Y5YzRkLi4zOTVjODY4OWEgMTAwNjQ0 Ci0tLSBhL3QvbGlzdC1vZi10ZXN0cy5taworKysgYi90L2xpc3Qtb2YtdGVzdHMubWsKQEAg LTcxMiw2ICs3MTIsNyBAQCB0L21kYXRlMy5zaCBcCiB0L21kYXRlNC5zaCBcCiB0L21kYXRl NS5zaCBcCiB0L21kYXRlNi5zaCBcCit0L21pc3NpbmctbGluay10by1maWxlLnNoIFwKIHQv bWlzc2luZy12ZXJzaW9uLW1pc21hdGNoLnNoIFwKIHQvbWlzc2luZzMuc2ggXAogdC9hbS1t aXNzaW5nLXByb2cuc2ggXApkaWZmIC0tZ2l0IGEvdC9taXNzaW5nLWxpbmstdG8tZmlsZS5z aCBiL3QvbWlzc2luZy1saW5rLXRvLWZpbGUuc2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwLi4yM2Q2ZDJjZGUKLS0tIC9kZXYvbnVsbAorKysgYi90L21pc3Npbmct bGluay10by1maWxlLnNoCkBAIC0wLDAgKzEsNDIgQEAKKyMhIC9iaW4vc2gKKyMgQ29weXJp Z2h0IChDKSAyMDAyLTIwMjIgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjCisj IFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIsIG9yIChhdCB5b3VyIG9wdGlvbikKKyMg YW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBp biB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBidXQgV0lUSE9VVCBBTlkg V0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJD SEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUg dGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisj CisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBz ZWUgPGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworIyBNYWtlIHN1cmUgQXV0 b21ha2Ugd2lsbCBpbnN0YWxsIHJlYWwgZmlsZXMgd2hlbiAtLWNvcHkgaXMgZ2l2ZW4gZXZl bgorIyBpZiBzeW1saW5rcyBhbHJlYWR5IGV4aXN0LgorCisuIHRlc3QtaW5pdC5zaAorCitj YXQgPj4gY29uZmlndXJlLmFjIDw8RU9GCitBQ19PVVRQVVQKK0VPRgorCitjYXQgPiBNYWtl ZmlsZS5hbSA8PCAnRU5EJworaW5mb19URVhJTkZPUyA9IGZvby50ZXhpCitFTkQKKworJEFD TE9DQUwKKyRBVVRPQ09ORgorJEFVVE9NQUtFIC0tYWRkLW1pc3NpbmcKKworI2xzIC1sCisK KyRBVVRPTUFLRSAtLWFkZC1taXNzaW5nIC0tY29weQorCisjbHMgLWwKKwordGVzdCAhIC1o IHRleGluZm8udGV4IHx8IGV4aXQgMQorCis6Ci0tIAoyLjM1LjEKCg== --------------Zj7LULAxk2rUsT0yYqmm5up6-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 18:33:14 2022 Received: (at submit) by debbugs.gnu.org; 29 Dec 2022 23:33:14 +0000 Received: from localhost ([127.0.0.1]:33159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB2Og-0002Vf-Jm for submit@debbugs.gnu.org; Thu, 29 Dec 2022 18:33:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:44580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB2Od-0002VW-2f for submit@debbugs.gnu.org; Thu, 29 Dec 2022 18:33:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB2Oc-0006NM-TE for automake-patches@gnu.org; Thu, 29 Dec 2022 18:33:10 -0500 Received: from freefriends.org ([96.88.95.60]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB2Ob-0003TI-74 for automake-patches@gnu.org; Thu, 29 Dec 2022 18:33:10 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 2BTNX4A1032588 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Dec 2022 16:33:04 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 2BTNX3eC032587; Thu, 29 Dec 2022 16:33:03 -0700 Date: Thu, 29 Dec 2022 16:33:03 -0700 Message-Id: <202212292333.2BTNX3eC032587@freefriends.org> From: Karl Berry To: bogdro_rep@gmx.us Subject: Re: bug#33573: Patch to replace symlinks with files In-Reply-To: Received-SPF: pass client-ip=96.88.95.60; envelope-from=karl@freefriends.org; helo=freefriends.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Another simple patch from my side: when '--copy' given to '--add-missing', copy the standard files even if symlinks already exist. I am not sure about changing the behavior here. Although the behavior you propose is plausible, I fear that people might depend or expect on failure if symlinks exist. It doesn't seem bad to me to require the user to clean up their own symlinks, instead of assuming the overwriting should be done. There's no way to know what the situation really is. What I suggest is making the new behavior of deleting existing symlinks iff -f is *also* given. If the user says "force" and "copy" then ok, we can figure they're asking for what they're getting. Wdyt? --thanks, karl. P.S. I hope to reply to your other patch in the next day or two. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 12:52:06 2022 Received: (at submit) by debbugs.gnu.org; 30 Dec 2022 17:52:06 +0000 Received: from localhost ([127.0.0.1]:36074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJY3-0006FE-Le for submit@debbugs.gnu.org; Fri, 30 Dec 2022 12:52:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:50240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBE8M-0005sR-Pv for submit@debbugs.gnu.org; Fri, 30 Dec 2022 07:05:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBE8M-00048Q-KO for automake-patches@gnu.org; Fri, 30 Dec 2022 07:05:10 -0500 Received: from mout.gmx.net ([212.227.15.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBE8J-0002ll-H8 for automake-patches@gnu.org; Fri, 30 Dec 2022 07:05:10 -0500 Received: from [192.168.1.226] ([90.227.12.124]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1N8XTv-1opJQO193R-014SBn; Fri, 30 Dec 2022 13:04:57 +0100 Message-ID: Date: Fri, 30 Dec 2022 13:04:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#33573: Patch to replace symlinks with files Content-Language: en-GB, sv-SE To: Karl Berry References: <202212292333.2BTNX3eC032587@freefriends.org> From: Bogdan In-Reply-To: <202212292333.2BTNX3eC032587@freefriends.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:svyqcz3yiPn6gJnJnMUNVjkvB5w8H1UkedhzJaU/aI8YFvoMglH mSRHFWIPv+rxa5WRvJJKk5jok6zEj4Ft8HUuGRKQoCdgfsvEmliSutWq12TaX8tHisj45Lb bBg+8TmNPuKuhnchDg59BsH1DFW2Z2BNGu450/jE+DkXq0PFb5TGY9lsuABA2wsCU4PTCfV 5EMkrNXmYIENplKKTAN7w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:m35JiuvvkxM=;b97FuAh2INEnvDQBd7o/1JNveOW kN3MxH9KR091tlxXgbrjC0L+wkXH22yn/E0WhMh84/jPHiFDG0xjhN+tgtHd6jCgaz03kHewc 499EAJiF3Aw0zncEBe+IQpAijOIigIOoAMFT9A7YPTAWfp7RIowcw7DtnOWAhpz1i8RC/B1nb f2BHJEOK7PSgrcTm8eiokJwskC67qVW2X9hm9SB06IekpBlD5ic1Cf7dK25xkOoTIMvzbR/J3 moo0Xi7HWY7tNGLybOQ2Uubkxzr9rcTm/R9r4wfCrlw3KsSyht3Mn608v600ZglLbrHMUhhfV Gh9JG4Y4ue6aZBrTUo3lEilo9GkCvVvF+/BotZl28+CRH1Y/qb+FM7lVnv/3B2gJEAmLHB6Fv T3aEPxDsqjJw3ay2Y+4+U45FossDTBx5ZyfCJ9ZIEwngThr08zhxR6jleu34pVRcnBcAgEoxT N/mMOysyPmMQOxNN4CO3ZzrNUr3Yog/uAFk8AH2yeLuVihbg1nfjrcpDDE7nttTUBMVdcxA2H hxeMpZkOdHtoiTGdItzsMZG75eOoX3sTwhC1dG0Dipaeajo0kcZsqbeEFzi4cJ6o1J7AfQSCC 3q6OQDcdIx2zQnYOyXYFnJKDXL2dkob4u+VCa9pNQF1p5uMp/fkxBL2d1osdcwTOnPN/I2Ghe Bf2R11y1YSK1cbjDjwmeiC8XRhmw8WanW2gvmrvydx1w+lLEhLEyspDP7psZpbx18DfrP7FPZ fXhti4x+t4kvdArV6GZ+QFHPjfz5p2E6zRUfuGrfNj3sAk3SHg5fxysJarYcYhgpmevq530Se iwFQoGBvNx7/rpRwIIdiaD+mEi3SSILAloHadL1C1KRZ0623G675g1autIuf13LxsyJ1t7Y8x KeKtaXIwMdGHl1FHQ9ssGtsm/VtJDcS4nszrogQ8BMfENYYxbsT74iBMFoQfkNJuxFcRgp7fL i/AtGV4YyMiKWmi7Vh/dswoyCwg= Received-SPF: pass client-ip=212.227.15.15; envelope-from=bogdro_rep@gmx.us; helo=mout.gmx.net X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.146, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 30 Dec 2022 12:52:01 -0500 Cc: automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Karl Berry , Fri Dec 30 2022 00:33:03 GMT+0100 (Central European Standard Time) > Another simple patch from my side: when '--copy' given to > '--add-missing', copy the standard files even if symlinks already exist. > > I am not sure about changing the behavior here. Although the behavior > you propose is plausible, I fear that people might depend or expect on > failure if symlinks exist. It doesn't seem bad to me to require the user > to clean up their own symlinks, instead of assuming the overwriting > should be done. There's no way to know what the situation really is. > > What I suggest is making the new behavior of deleting existing symlinks > iff -f is *also* given. If the user says "force" and "copy" then ok, we > can figure they're asking for what they're getting. > > Wdyt? --thanks, karl. Hi. Sure, no problem from my side. This is actually already the current behavior, from what I see (but I didn't check in detail). Someone reported a bug for this, so I simply gave it a try. The user has a point: --copy was given, but the files were not copied. This may be a bit confusing. But this depends on the point of view, I guess, and both behaviors have a point and can be correct, depending on who you're asking. We can as well leave the current behavior, as you say: make the user be clear about what they want and maybe allow Automake one day behave differently (like exit with an error if a symlink exists and -c given, but no -f, etc.). Just maybe make something clearer in the documentation and/or the help message in such case, like: --help: [...] -c, --copy with -a, copy missing files if they or their symlinks don't already exist (default is symlink) -f, --force-missing force update of standard files (with -c copies the files even if symlinks exist) Automake docs: ‘-c’ ‘--copy’ When used with ‘--add-missing’, causes installed files to be copied if files or symlinks don't already exist. The default is to make a symbolic link. > P.S. I hope to reply to your other patch in the next day or two. No problem - thanks for confirmation that they actually arrived. I thought the mails got lost in some black hole, because I'm not subscribed and I didn't see them in the mailing list's archive :). -- Regards - Bogdan ('bogdro') D. (GNU/Linux & FreeDOS) X86 assembly (DOS, GNU/Linux): http://bogdro.evai.pl/index-en.php Soft(EN): http://bogdro.evai.pl/soft http://bogdro.evai.pl/soft4asm www.Xiph.org www.TorProject.org www.LibreOffice.org www.GnuPG.org From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 21:30:55 2022 Received: (at submit) by debbugs.gnu.org; 31 Dec 2022 02:30:55 +0000 Received: from localhost ([127.0.0.1]:36338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBReA-0002qR-OD for submit@debbugs.gnu.org; Fri, 30 Dec 2022 21:30:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:49702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBRe8-0002qH-MT for submit@debbugs.gnu.org; Fri, 30 Dec 2022 21:30:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBRe8-0007GR-9C for automake-patches@gnu.org; Fri, 30 Dec 2022 21:30:52 -0500 Received: from freefriends.org ([96.88.95.60]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBRe6-0008Lk-6h for automake-patches@gnu.org; Fri, 30 Dec 2022 21:30:51 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 2BV2UhU9001425 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Dec 2022 19:30:44 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 2BV2UgK7001424; Fri, 30 Dec 2022 19:30:42 -0700 Date: Fri, 30 Dec 2022 19:30:42 -0700 Message-Id: <202212310230.2BV2UgK7001424@freefriends.org> From: Karl Berry To: bogdro_rep@gmx.us Subject: Re: bug#33573: Patch to replace symlinks with files In-Reply-To: Received-SPF: pass client-ip=96.88.95.60; envelope-from=karl@freefriends.org; helo=freefriends.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Bogdan, Someone reported a bug for this, so I simply gave it a try. Thank you! I didn't realize you were working on some of the old bugs. That is great! To bring this one in particular to fruition: can you check what happens when -c -a would need to overwrite a symlink? I think it should just give a warning. Then the user can decide what to do. And, can you check that automake -a -f -c does in fact overwrite a symlink with a copy? And, I guess, that -a -f, without the -c, overwrites files with symlinks? (Or, if it gives an error now, that's ok too.) And that the test checks this stuff? Sorry, but these are the kinds of nitty-gritty things that every automake change needs to think about. Just maybe make something clearer in the documentation and/or the help message in such case, like: Yes, agreed. No problem there. I'm not subscribed If you intend to keep working for a while on automake (I hope so), you should subscribe to the mailing lists, especially bug-automake and automake-patches. Unfortunately the debbugs software does not send mail to everyone who has been on a given bug (not even the bug originator), but only to the associated mailing list, as I understand it. For the same reason, it is good to explicitly cc a bug's originator and anyone else who has contributed to the bug, if you happen to have them. and I didn't see them in the mailing list's archive :). I see all your messages there now, I believe: https://lists.gnu.org/archive/html/bug-automake/2022-12/threads.html As I recall, there is a delay of up to an hour or maybe more before the archives are updated. Unfortunately it does not happen when a message is received; there's a separate polling cron job :(. Thanks for all, Karl From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 03:35:37 2023 Received: (at submit) by debbugs.gnu.org; 1 Jan 2023 08:35:37 +0000 Received: from localhost ([127.0.0.1]:40253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBtod-0001Ce-W4 for submit@debbugs.gnu.org; Sun, 01 Jan 2023 03:35:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:35304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBhPc-0005UN-6b for submit@debbugs.gnu.org; Sat, 31 Dec 2022 14:20:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBhPc-0003VQ-1Y for automake-patches@gnu.org; Sat, 31 Dec 2022 14:20:56 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBhPa-0004Le-1r for automake-patches@gnu.org; Sat, 31 Dec 2022 14:20:55 -0500 Received: from [192.168.1.226] ([90.227.12.124]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MWigq-1pIPXI0tNA-00X7U6; Sat, 31 Dec 2022 20:20:44 +0100 Message-ID: <1faea0cb-06e9-bd06-f7b1-9f4f6ccce575@gmx.us> Date: Sat, 31 Dec 2022 20:20:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#33573: Patch to replace symlinks with files Content-Language: en-GB, sv-SE To: Karl Berry References: <202212310230.2BV2UgK7001424@freefriends.org> From: Bogdan In-Reply-To: <202212310230.2BV2UgK7001424@freefriends.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:ZVlN2fOxatRlR2kirewHrZMp3Y7AZKFzxKs3jubWxajkf3aliz+ iw+9KaDKGL4kzVQ+5+HDAkc1J1oXMYco5tAEjsNzm5FxGG1K9gPdkJrQ03vE2NlI/qpKQXu zak3YwrRzNko1Y6elEkmErS6DOarDZ0q0DgE1AQPU4wE4mNEnKdvsJp/kWdw82d6opXJSXz 8WDGZPOnGahSYz14bc7Wg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kOpqppNQqdc=;jjORYPJL3lmHJMeEyjr8I40/52K 1Z6X8zixScL6PRvNg9ltUVlsUitqwQytALyD8HTQVY5ISt/cWsi2I/79CXYda/lWHXYxU1usP eQ7aeQLgjuP3rb/5Uznk5zQjvIgLTq2xeeZwnlOrMFpvk8ticMkTVWEttLzJ4ONFxfHq7iaED HZ7wb/xjVCmfAq7x2D8LH3nMqdJjxXpUvtbyCc8oLM18rAZul2h8zDt4yOB/PveEI9o8J3Tuw eOOX2TkzmCIHIPxRIIPjfKPjDWzjD/+COE3MvJPMztsiHZe35bfDNSITDYG2jy15kpa5WpOf6 HLa+ysYYK1uXjzf8d0KuIubeopy1mtupm0wJwrqtI1lLqFDrcZlpmelI8qBe1B5+PRt2ZbUME ujmhBQ88T8pEbEJJXO4AldCKRLynx85alKWbyWV+6LIE++LQU35KpChLHFVeS77ERVbJ276eD iGzphhdQ8oWEnNnPZidqQjU1kAO3OzTDKSY4taD4rUCxUkp3DoiOYF+d92XO51t9w+MKLtWbo LXQbvto97HQr99ALVwN6Nzph2X6Ztq6igvzr3A7oTEMyiPa/T+7qswYqiCf7mtw7tQkWbKL7B 1iAyfiJAufyN6opZ6/7FVx+0QCqwX6aOTyGdePtxqhcl2eLY3/F9W1k/nlS+l43W43EpEMJiw 2IXVGW/h6Q+CO628F2CMeZrwzvjWWnfcenwYC2L/B1hp0WCyMmd8sSjeuxQidy4r/h0EPD29l 7kx3BoKgG7ZqOGQHN+efbEpC3WjeObzUQaVEvToEsXl7o4gWOKRdxvmZ/nGnfBOg23hqnWijf NNvpMDZ3vCOoEaLfuVlTWmAAYoyoP+19LyVSO1zy3mFIsTSs5nS70d4GNQ3589+ean7z+jnPj wVeTFtFUX1LTznwBdADoiC/jE/0fWg/hoglgop/+v6N049pxjNI2P1sipUr1qlZHbbqrgH4z0 nLU5gg== Received-SPF: pass client-ip=212.227.17.21; envelope-from=bogdro_rep@gmx.us; helo=mout.gmx.net X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.153, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 01 Jan 2023 03:35:31 -0500 Cc: automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Karl Berry , Sat Dec 31 2022 03:30:42 GMT+0100 (Central European Standard Time) > Hi Bogdan, > > Someone reported a bug for this, so I simply gave it a try. > > Thank you! I didn't realize you were working on some of the old bugs. > That is great! :) > To bring this one in particular to fruition: can you check what happens > when -c -a would need to overwrite a symlink? I think it should just > give a warning. Then the user can decide what to do. It simply doesn't do or say anything, because the object already exists (the subroutine simply leaves). $ rm -f doc/texinfo.tex $ automake --add-missing doc/Makefile.am:1: installing 'doc/texinfo.tex' $ ll doc/texinfo.tex lrwxrwxrwx 1 bogdan bogdan 36 gru 31 19:48 doc/texinfo.tex -> /usr/share/automake-1.16/texinfo.tex $ automake --add-missing --copy $ > And, can you check that automake -a -f -c does in fact overwrite a > symlink with a copy? And, I guess, that -a -f, without the -c, > overwrites files with symlinks? (Or, if it gives an error now, that's ok > too.) The combination '-a -f -c' does what's expected (replaces a symlink with a regular file): $ ll doc/texinfo.tex lrwxrwxrwx 1 bogdan bogdan 36 gru 31 19:48 doc/texinfo.tex -> /usr/share/automake-1.16/texinfo.tex $ automake --add-missing --copy $ automake --add-missing --copy --force-missing $ ll doc/texinfo.tex -rw------- 1 bogdan bogdan 374230 gru 31 19:49 doc/texinfo.tex $ That's where my idea about updating the documentation comes from - may not be clear enough. Just '-a -f' does indeed replace regular files with symlinks: $ ll doc/texinfo.tex -rw------- 1 bogdan bogdan 374230 gru 31 19:49 doc/texinfo.tex $ automake --add-missing --force-missing $ ll doc/texinfo.tex lrwxrwxrwx 1 bogdan bogdan 36 gru 31 19:51 doc/texinfo.tex -> /usr/share/automake-1.16/texinfo.tex $ $ automake --version automake (GNU automake) 1.16.5 > And that the test checks this stuff? The change I'm implementing is tested by the test I've added. It simply checks if after --copy the file is not a link: $AUTOMAKE --add-missing --copy test ! -h texinfo.tex || exit 1 (unneeded parts removed) > Sorry, but these are the kinds of nitty-gritty things that every > automake change needs to think about. Yes, testing and portability is important, I know. > Just maybe make something clearer in the documentation and/or the help > message in such case, like: > > Yes, agreed. No problem there. > > I'm not subscribed > > If you intend to keep working for a while on automake (I hope so), you > should subscribe to the mailing lists, especially bug-automake and > automake-patches. Unfortunately the debbugs software does not send mail > to everyone who has been on a given bug (not even the bug originator), > but only to the associated mailing list, as I understand it. I see. We'll see what my future work on Automake will look like. Maybe I could contribute something useful. Right now, I'm planning just one more patch ("the last this year" - yes, it's still 2022 here :) ) and later we'll see what time allows. I also have my own projects to look after once in a while :). Some guide like "to implement this and this, you need to change/add subroutine that and that" would be nice for beginners. I wish there would be some kind of roadmap or a list of interesting ideas to-do in Automake. The "PLANS" doesn't have much, not for me, at least... Otherwise, I don't know if e.g. Automake 2.0 is implemented in 99% already or is it maybe just 1% and a full re-write is planned. > For the same reason, it is good to explicitly cc a bug's originator and > anyone else who has contributed to the bug, if you happen to have them. I didn't want to send any notifications to the bugs in case my patches get rejected for some reason (like they don't work on *BSD/some antique Unix, don't match the programming style, etc., or are completely against the idea). Furthermore, Automake doesn't get so many releases, as I see, so even implementing a fix doesn't mean that it will go to a release any time soon. > and I didn't see them in the mailing list's archive :). > > I see all your messages there now, I believe: > https://lists.gnu.org/archive/html/bug-automake/2022-12/threads.html > > As I recall, there is a delay of up to an hour or maybe more before the > archives are updated. Unfortunately it does not happen when a message is > received; there's a separate polling cron job :(. Right. They're there. Unfortunately, the Automake website points to https://lists.gnu.org/archive/html/automake-patches/ instead :). That's also where I send my mails to, not knowing they end up in "bug-automake". Minor issue, but may be confusing, as you can see :). Thanks. -- Regards - Bogdan ('bogdro') D. (GNU/Linux & FreeDOS) X86 assembly (DOS, GNU/Linux): http://bogdro.evai.pl/index-en.php Soft(EN): http://bogdro.evai.pl/soft http://bogdro.evai.pl/soft4asm www.Xiph.org www.TorProject.org www.LibreOffice.org www.GnuPG.org From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 06:14:50 2023 Received: (at submit) by debbugs.gnu.org; 1 Jan 2023 11:14:51 +0000 Received: from localhost ([127.0.0.1]:40347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBwIk-0007cp-Hz for submit@debbugs.gnu.org; Sun, 01 Jan 2023 06:14:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:57920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBwIj-0007ch-Dd for submit@debbugs.gnu.org; Sun, 01 Jan 2023 06:14:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBwIh-0003vS-AF for automake-patches@gnu.org; Sun, 01 Jan 2023 06:14:47 -0500 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBwIf-0004zO-Mk for automake-patches@gnu.org; Sun, 01 Jan 2023 06:14:46 -0500 Received: by mail-pj1-x102c.google.com with SMTP id ge16so23501003pjb.5 for ; Sun, 01 Jan 2023 03:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ChDyR8of3hzarhfYozPGDBk9kngZfHEy+W8PTCrgWRk=; b=LlVCWtTgQt2rSexbEbr8/oZRjWIjfj6n2Y8vnvgP3K5lt1Ek5SjZ+OABHmCg2nqm+P NO/Uv+sCMUY2q6hVgLMirEvcxyH6KkzXoixLgUBtvLqsnydlSyacGNKDSu9b6bMMO/dV T7BzPeLexDr2tq/l0TC1Tb73oGMMV5WjldL0OoxohIvONpmLeLjtCv2np2HQ6GmQLse6 roPfNV9eVtrEixmI2oexkvOWQ+fAaJgZPVt2sSeHX5dfn0I7WMrMObJ5xYfV85gUnH03 kiksbNcMjYDIOJOwEIs71hvAIJyvo/FYnU4MK6IEWACTL92JcCzmTeOu9kTdPWpGChF/ 9KNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ChDyR8of3hzarhfYozPGDBk9kngZfHEy+W8PTCrgWRk=; b=SW5c5KVzXASH382WT/BSivrPBSU4fAq+UAvZCZIAj0Y79omfZPR11u7N0HfVDzNjZj MszA3JklpO0jzMlSf/ftDir3ukxQjeyM9HgNlvnfWbBQLSSMilqlPouUeOE3nCpXUO0W Fx4vWwKbpmXWg1B4ASsvs3U3rTSjmUSTuee6qCVviy2VYkbU3rF9K1BmofMsHOVroQBQ C9Vt53QXT4kFgSjkejfsks/oUoSe0mUfmb4J+kkY9n9ZXYQH8Zj02sdYwBWLCHu1+aL2 jTKfp14z57MYyfpJPtnPNVhE1k5oXkFyNdNfhzMWGw9txavj8Bw5FZVqId9v6zn1n/pF HP0A== X-Gm-Message-State: AFqh2kpWLqu4oIWl6XjVMWVK3ul6EB8mG3BrqdQ+kRsnDN210BS/pOsp 7QK3hb2bhxI0Vi+shf1GFYE= X-Google-Smtp-Source: AMrXdXtqX/SGnBsX8SAWmyt9A6d8NM+7MAbQCIT7/wvuqviXtoDMkZg9HREt0uVKfbNHrt5VQlIBkA== X-Received: by 2002:a17:90a:d58a:b0:219:7d75:de7b with SMTP id v10-20020a17090ad58a00b002197d75de7bmr39901511pju.35.1672571683441; Sun, 01 Jan 2023 03:14:43 -0800 (PST) Received: from [10.1.1.50] ([118.208.5.40]) by smtp.gmail.com with ESMTPSA id j8-20020a17090a94c800b00219bf165b5fsm15819800pjw.21.2023.01.01.03.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Jan 2023 03:14:42 -0800 (PST) Message-ID: Date: Sun, 1 Jan 2023 21:14:38 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#33573: Patch to replace symlinks with files To: Bogdan , Karl Berry References: <202212310230.2BV2UgK7001424@freefriends.org> <1faea0cb-06e9-bd06-f7b1-9f4f6ccce575@gmx.us> Content-Language: en-US From: Peter Johansson In-Reply-To: <1faea0cb-06e9-bd06-f7b1-9f4f6ccce575@gmx.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=trojkan@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.153, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit Cc: automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Hi both, On 1/1/23 05:20, Bogdan wrote: > Karl Berry , Sat Dec 31 2022 03:30:42 GMT+0100 > (Central European Standard Time) >> Hi Bogdan, >> >>      Someone reported a bug for this, so I simply gave it a try. >> >> Thank you! I didn't realize you were working on some of the old bugs. >> That is great! > > > :) > > >> To bring this one in particular to fruition: can you check what happens >> when -c -a would need to overwrite a symlink? I think it should just >> give a warning. Then the user can decide what to do. > > > It simply doesn't do or say anything, because the object already > exists (the subroutine simply leaves). > > FWIW, as a user I think this is the expected behavior. The option is named --add-missing, so if the file is not missing, I expect nothing to happen. Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 18:02:34 2023 Received: (at submit) by debbugs.gnu.org; 1 Jan 2023 23:02:34 +0000 Received: from localhost ([127.0.0.1]:41987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC7Le-0004eU-5B for submit@debbugs.gnu.org; Sun, 01 Jan 2023 18:02:34 -0500 Received: from lists.gnu.org ([209.51.188.17]:37166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC7Lb-0004eL-N0 for submit@debbugs.gnu.org; Sun, 01 Jan 2023 18:02:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC7Lb-0000YP-HO for automake-patches@gnu.org; Sun, 01 Jan 2023 18:02:31 -0500 Received: from freefriends.org ([96.88.95.60]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC7LZ-0006q0-T3 for automake-patches@gnu.org; Sun, 01 Jan 2023 18:02:31 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 301N2O0w021906 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 1 Jan 2023 16:02:25 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 301N2Nws021905; Sun, 1 Jan 2023 16:02:23 -0700 Date: Sun, 1 Jan 2023 16:02:23 -0700 Message-Id: <202301012302.301N2Nws021905@freefriends.org> From: Karl Berry To: trojkan@gmail.com Subject: Re: bug#33573: Patch to replace symlinks with files In-Reply-To: Received-SPF: pass client-ip=96.88.95.60; envelope-from=karl@freefriends.org; helo=freefriends.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bogdro_rep@gmx.us, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) FWIW, as a user I think this is the expected behavior. The option is named --add-missing, so if the file is not missing, I expect nothing to happen. I more or less agree, but the original suggestion from Ben (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33573) was for --add-missing --copy to overwrite existing symlinks with files, because of the --copy. So the current behavior of silently ignoring existing entries doesn't suit everyone. But I don't think silently overwriting symlinks is right either. I can see that specifying both --add-missing and --copy leaves it rather indeterminate what should happen with existing symlinks. In practice, I doubt people would want to end up with some symlinks and some files for the "missing" list of files, which is what would generally happen now. Hence my idea of simply reporting the situation (not failing, just warning), and if they want to overwrite symlinks with files, also use --force. It occurs to me that, in the analogous situation from the other side, when --add-missing is given without --copy, one could argue that a warning should equally be given if a file (not symlink) exists. But somehow that feels like a step too far, although I can't think of a real argument against it. --best, karl. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 18:20:03 2023 Received: (at submit) by debbugs.gnu.org; 1 Jan 2023 23:20:03 +0000 Received: from localhost ([127.0.0.1]:41992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC7cY-000531-TC for submit@debbugs.gnu.org; Sun, 01 Jan 2023 18:20:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:60780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC7cW-00052X-Ig for submit@debbugs.gnu.org; Sun, 01 Jan 2023 18:20:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC7cW-0002MK-7f for automake-patches@gnu.org; Sun, 01 Jan 2023 18:20:00 -0500 Received: from supercat.cmpct.info ([71.19.146.230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC7cU-0002MQ-Fl for automake-patches@gnu.org; Sun, 01 Jan 2023 18:19:59 -0500 Received: from smtpclient.apple (unknown [82.8.138.118]) by supercat.cmpct.info (Postfix) with ESMTPSA id 3F65643614; Sun, 1 Jan 2023 23:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpct.info; s=default; t=1672615190; bh=5f7bnbPVmc2PXqD/nB6HbYYPTzpm0DzkN6hx/Y9gHYc=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=pjn7+bxf8axWQixZD86mH/ld0OQmNseWtDSx+1MiUM6wAoHqgXx+JpAdLksx+cJDM DLevC0DSYHozeoof0OD8FSx3DdbZOnC6Jituywy2aysOmU2ED24v5yPjuVlDx40nPa kAjSn9CVXn2Z5AbPhn7W9eKo4A423tfN+JPnvd6g= Content-Type: multipart/signed; boundary="Apple-Mail=_116727B9-F6D4-4321-BD0F-5DB23EAD9FA0"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: bug#33573: Patch to replace symlinks with files From: Sam James In-Reply-To: <1faea0cb-06e9-bd06-f7b1-9f4f6ccce575@gmx.us> Date: Sun, 1 Jan 2023 23:19:34 +0000 Message-Id: <60837736-3B17-41F6-845F-F0C6B7FD9465@cmpct.info> References: <202212310230.2BV2UgK7001424@freefriends.org> <1faea0cb-06e9-bd06-f7b1-9f4f6ccce575@gmx.us> To: Bogdan X-Mailer: Apple Mail (2.3731.300.101.1.3) Received-SPF: pass client-ip=71.19.146.230; envelope-from=sam@cmpct.info; helo=supercat.cmpct.info X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: automake-patches@gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Apple-Mail=_116727B9-F6D4-4321-BD0F-5DB23EAD9FA0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 31 Dec 2022, at 19:20, Bogdan wrote: >=20 > Karl Berry , Sat Dec 31 2022 03:30:42 GMT+0100 = (Central European Standard Time) > [snip] >=20 >> For the same reason, it is good to explicitly cc a bug's originator = and >> anyone else who has contributed to the bug, if you happen to have = them. >=20 >=20 > I didn't want to send any notifications to the bugs in case my patches = get rejected for some reason (like they don't work on *BSD/some antique = Unix, don't match the programming style, etc., or are completely against = the idea). >=20 > Furthermore, Automake doesn't get so many releases, as I see, so even = implementing a fix doesn't mean that it will go to a release any time = soon. >=20 I appreciate the thought, but this is likely to be more confusing as we = want feedback if possible, and you're trying - so it can't hurt. Don't overthink it. :) --Apple-Mail=_116727B9-F6D4-4321-BD0F-5DB23EAD9FA0 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY7IVB18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kOuUAP9gmSjIXrXadQqMtZhggmTtxM99jhMaPdz24sYUHXL7owD/bBRncrLilArK R9sUn5+lVuryJAUy1vL6lPVoV4yHeQw= =yuPJ -----END PGP SIGNATURE----- --Apple-Mail=_116727B9-F6D4-4321-BD0F-5DB23EAD9FA0--