GNU bug report logs - #33572
[PATCH] Make Guile-JSON a required dependency.

Previous Next

Package: guix-patches;

Reported by: ericbavier <at> centurylink.net

Date: Sun, 2 Dec 2018 05:20:01 UTC

Severity: normal

Tags: patch

Done: Eric Bavier <ericbavier <at> centurylink.net>

Bug is archived. No further changes may be made.

Full log


Message #19 received at 33572-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 33572-done <at> debbugs.gnu.org, Eric Bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#33572] [PATCH] Make Guile-JSON a required dependency.
Date: Sun, 2 Dec 2018 18:22:18 -0600
[Message part 1 (text/plain, inline)]
On Sun, 02 Dec 2018 23:39:04 +0100
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hello Eric,
> 
> ericbavier <at> centurylink.net skribis:
> 
> > From: Eric Bavier <bavier <at> member.fsf.org>
> >
> > * README (Requirements): Remove "optional" verbiage.
> > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional.
> > (have_guile_json): Error if not "yes".
> > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests
> > unconditionally.
> > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave
> > guile-json input.  
> 
> Could you include guix.texi changes along the lines of what Joshua
> proposed on guix-devel?

Done.

> Otherwise LGTM, thanks!
> 
> Ludo’.

Thanks for the review.  Pushed
in 6776af04d4b65c5a9a07784307a6abe395b6f480

`~Eric
[Message part 2 (application/pgp-signature, inline)]

This bug report was last modified 6 years and 166 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.