From unknown Sat Jun 14 19:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] [PATCH] Make Guile-JSON a required dependency. Resent-From: ericbavier@centurylink.net Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Dec 2018 05:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33572@debbugs.gnu.org Cc: Eric Bavier X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154372794820667 (code B ref -1); Sun, 02 Dec 2018 05:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Dec 2018 05:19:08 +0000 Received: from localhost ([127.0.0.1]:57449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTK9k-0005Mq-9I for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:19:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTK9e-0005MY-Pm for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:18:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTK9Y-0004TF-57 for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:18:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTK9Y-0004TB-2P for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:18:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTK9W-0001lk-Qr for guix-patches@gnu.org; Sun, 02 Dec 2018 00:18:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTK9T-0004Qf-LG for guix-patches@gnu.org; Sun, 02 Dec 2018 00:18:46 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:21184 helo=smtp.centurylink.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTK9T-0004Q2-E5 for guix-patches@gnu.org; Sun, 02 Dec 2018 00:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543727922; h=From:Subject:Date:To:MIME-Version; bh=6Dg/j7tk8uAFgDBgB0PLAVAmDFw=; b=31VShiyWMP+TZQqq1+z4I6cOd5/Z7H7HUWyZveRvXFnpMlTE+Zra0mn0su8+tlfi OFhx/xW9hxBbslnWshxWxhOnxL9EIQlsSAB+UZwRaUqtaOAAFb0nmvBDxr5Drf/k qyT8+QK6HJ3bNEM7q5r0cT7Dn6ddFvCd0/hZHg4vdOXi6BPs9EEEOrugX4ezyMCM 14Egx082V5Bn/7N+RiKCn30mbEfx5q5XHMrZuRjm++ORwLyNYr4oR+hVaDjCRxvU /49qqlzVj8odHIOqQQXReRKdu/uC4TuDJSuQkRP6FEDTNWQu94JJkowYg2yp1MB8 zsQT5AXrI5L99V/TZyGcSg==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=Sbi1TbZu c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=inoG4m36AAAA:8 a=CcLUTRNvAAAA:8 a=FFLdh5n2AAAA:20 a=fXms6y0vAAAA:8 a=69wJf7TsAAAA:8 a=p-wP41oKWemYr1zPVNkA:9 a=_Qgj-RFg6mImvLaOgLPg:22 a=obhdfE27RNN5ZnF-s2K5:22 a=c6Zb8eaUoX5VaqycxFvw:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp02.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:49464] helo=localhost.localdomain) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=DHE-RSA-AES128-GCM-SHA256) id 03/10-10541-13B630C5; Sun, 02 Dec 2018 00:18:42 -0500 From: ericbavier@centurylink.net Date: Sat, 1 Dec 2018 23:18:22 -0600 Message-Id: <20181202051822.8344-1-ericbavier@centurylink.net> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) From: Eric Bavier * README (Requirements): Remove "optional" verbiage. * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. (have_guile_json): Error if not "yes". * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests unconditionally. * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave guile-json input. --- Makefile.am | 72 ++++++++++++----------------- README | 2 +- configure.ac | 6 ++- gnu/packages/package-management.scm | 2 +- 4 files changed, 36 insertions(+), 46 deletions(-) diff --git a/Makefile.am b/Makefile.am index e14ac57f2..32cebd591 100644 --- a/Makefile.am +++ b/Makefile.am @@ -62,7 +62,9 @@ MODULES = \ guix/base16.scm \ guix/base32.scm \ guix/base64.scm \ + guix/ci.scm \ guix/cpio.scm \ + guix/docker.scm \ guix/records.scm \ guix/pki.scm \ guix/progress.scm \ @@ -186,15 +188,24 @@ MODULES = \ guix/build/make-bootstrap.scm \ guix/search-paths.scm \ guix/packages.scm \ - guix/import/print.scm \ - guix/import/utils.scm \ - guix/import/gnu.scm \ - guix/import/snix.scm \ guix/import/cabal.scm \ + guix/import/cpan.scm \ guix/import/cran.scm \ - guix/import/hackage.scm \ + guix/import/crate.scm \ guix/import/elpa.scm \ + guix/import/gem.scm \ + guix/import/github.scm \ + guix/import/gnome.scm \ + guix/import/gnu.scm \ + guix/import/hackage.scm \ + guix/import/json.scm \ + guix/import/opam.scm \ + guix/import/print.scm \ + guix/import/pypi.scm \ + guix/import/snix.scm \ + guix/import/stackage.scm \ guix/import/texlive.scm \ + guix/import/utils.scm \ guix/scripts.scm \ guix/scripts/download.scm \ guix/scripts/perform-download.scm \ @@ -216,46 +227,29 @@ MODULES = \ guix/scripts/system/search.scm \ guix/scripts/lint.scm \ guix/scripts/challenge.scm \ + guix/scripts/import/crate.scm \ guix/scripts/import/cran.scm \ + guix/scripts/import/elpa.scm \ + guix/scripts/import/gem.scm \ guix/scripts/import/gnu.scm \ - guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/elpa.scm \ + guix/scripts/import/json.scm \ + guix/scripts/import/nix.scm \ + guix/scripts/import/opam.scm \ + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm \ guix/scripts/import/texlive.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ guix/scripts/edit.scm \ guix/scripts/size.scm \ guix/scripts/graph.scm \ + guix/scripts/weather.scm \ guix/scripts/container.scm \ guix/scripts/container/exec.scm \ guix.scm \ $(GNU_SYSTEM_MODULES) -if HAVE_GUILE_JSON - -MODULES += \ - guix/ci.scm \ - guix/docker.scm \ - guix/import/cpan.scm \ - guix/import/crate.scm \ - guix/import/gem.scm \ - guix/import/github.scm \ - guix/import/gnome.scm \ - guix/import/json.scm \ - guix/import/opam.scm \ - guix/import/pypi.scm \ - guix/import/stackage.scm \ - guix/scripts/import/crate.scm \ - guix/scripts/import/gem.scm \ - guix/scripts/import/json.scm \ - guix/scripts/import/opam.scm \ - guix/scripts/import/pypi.scm \ - guix/scripts/import/stackage.scm \ - guix/scripts/weather.scm - -endif - if HAVE_GUILE_SSH MODULES += \ @@ -335,7 +329,10 @@ SCM_TESTS = \ tests/base16.scm \ tests/base32.scm \ tests/base64.scm \ + tests/cpan.scm \ tests/cpio.scm \ + tests/crate.scm \ + tests/gem.scm \ tests/pki.scm \ tests/print.scm \ tests/sets.scm \ @@ -389,22 +386,13 @@ SCM_TESTS = \ tests/services.scm \ tests/scripts-build.scm \ tests/containers.scm \ + tests/opam.scm \ tests/pack.scm \ + tests/pypi.scm \ tests/import-utils.scm \ tests/store-database.scm \ tests/store-deduplication.scm -if HAVE_GUILE_JSON - -SCM_TESTS += \ - tests/pypi.scm \ - tests/opam.scm \ - tests/cpan.scm \ - tests/gem.scm \ - tests/crate.scm - -endif - SH_TESTS = \ tests/guix-build.sh \ tests/guix-build-branch.sh \ diff --git a/README b/README index a7a818c5c..e7871917f 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ GNU Guix currently depends on the following packages: - [[https://notabug.org/guile-sqlite3/guile-sqlite3][Guile-SQLite3]], version 0.1.0 or later - [[https://gitlab.com/guile-git/guile-git][Guile-Git]] - [[http://www.zlib.net/][zlib]] - - optionally [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]], for the 'guix import pypi' command + - [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]] Unless `--disable-daemon' was passed, the following packages are needed: diff --git a/configure.ac b/configure.ac index 2a1edbc32..2817e6e24 100644 --- a/configure.ac +++ b/configure.ac @@ -122,9 +122,11 @@ if test "x$have_guile_git" != "xyes"; then AC_MSG_ERROR([Guile-Git is missing; please install it.]) fi -dnl Guile-JSON is used in various places. +dnl Check for Guile-JSON. GUILE_MODULE_AVAILABLE([have_guile_json], [(json)]) -AM_CONDITIONAL([HAVE_GUILE_JSON], [test "x$have_guile_json" = "xyes"]) +if test "x$have_guile_json" != "xyes"; then + AC_MSG_ERROR([Guile-JSON is missing; please install it.]) +fi dnl Guile-Sqlite3 is used by the (guix store ...) modules. GUIX_CHECK_GUILE_SQLITE3 diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index 141d0e52f..c4e917102 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -389,7 +389,7 @@ the Nix package manager.") (propagated-inputs (fold alist-delete (package-propagated-inputs guix) - '("guile-json" "guile-ssh"))))))) + '("guile-ssh"))))))) (define (source-file? file stat) "Return true if FILE is likely a source file, false if it is a typical -- 2.19.2 From unknown Sat Jun 14 19:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] Guile-JSON now seems to be a required dependency Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Dec 2018 22:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: guix-devel@gnu.org, Joshua Branson , 33572@debbugs.gnu.org Received: via spool by 33572-submit@debbugs.gnu.org id=B33572.154378937125360 (code B ref 33572); Sun, 02 Dec 2018 22:23:02 +0000 Received: (at 33572) by debbugs.gnu.org; 2 Dec 2018 22:22:51 +0000 Received: from localhost ([127.0.0.1]:58420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTa8R-0006ap-CQ for submit@debbugs.gnu.org; Sun, 02 Dec 2018 17:22:51 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:59384 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTa8H-0006aQ-8G for 33572@debbugs.gnu.org; Sun, 02 Dec 2018 17:22:42 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543789347; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=kD+JW8hE/BpiXwLokQUj67AHUf8=; b=Qn94wYTPXNEl96512gd0LNdEz0Vzm/tpTVH8XmzyO+xeW6z9DT676/EkO93Npydf CeP2Ztz8BIQequFk2rq5hyZbdx/fGkoNP/FdCP2RwsdirldgUz5IL7dp3JuKWix3 VXRVNdA7SRfulH6BjmdtjB8jfZlQ81qu8WtxtLg+SaRtxwVk8fxdf8ZOQt6xfk2o 5jC1v/pE+GnyQ6cGEPa49nGYv82u3adItZRJwOWYpVSJyZmqWbClEYXdOrrLxvB2 w+vZos/fiSWQK4kwp3RL05IfF4/jFlRCFgCPdYW0rwiulhVuzdRx8LOSPa1eAPZ3 8Qni5sT2r3k8KaYknk0FKQ==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=Sbi1TbZu c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=ZLGELXoPAAAA:8 a=xyPz4MZXAAAA:8 a=I_5RNyk1AAAA:8 a=wKcCK5iB-FcXXnCOgFkA:9 a=QEXdDO2ut3YA:10 a=r10zed8N3wsA:10 a=inoG4m36AAAA:8 a=CcLUTRNvAAAA:8 a=FFLdh5n2AAAA:20 a=fXms6y0vAAAA:8 a=69wJf7TsAAAA:8 a=YlWAI3VNwFMpwfLTPFcA:9 a=uegmFwBr8OsD4fItXKcA:9 a=_FVE-zBwftR9WsbkzFJk:22 a=CFiPc5v16LZhaT-MVE1c:22 a=MgilOBo1dlhwZn2HC1h_:22 a=Eh9yxdLE6B1twWrs3SXz:22 a=_Qgj-RFg6mImvLaOgLPg:22 a=obhdfE27RNN5ZnF-s2K5:22 a=c6Zb8eaUoX5VaqycxFvw:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp02.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:51136] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 4C/C4-10541-22B540C5; Sun, 02 Dec 2018 17:22:27 -0500 Date: Sun, 2 Dec 2018 16:22:25 -0600 From: Eric Bavier Message-ID: <20181202162225.500e1721@centurylink.net> In-Reply-To: <87a7lnlhd8.fsf@gnu.org> References: <87y399am9b.fsf@ngyro.com> <20181201091658.720e1f20@centurylink.net> <87sgzh9ivq.fsf@ngyro.com> <87woorg3hk.fsf@fastmail.com> <87a7lnlhd8.fsf@gnu.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/YwBbVrV.jNWhPNhusqaVM5T"; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/YwBbVrV.jNWhPNhusqaVM5T Content-Type: multipart/mixed; boundary="MP_/TVvQ/8d9wk01=Wagiq0OqM4" --MP_/TVvQ/8d9wk01=Wagiq0OqM4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sun, 02 Dec 2018 22:59:47 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello, >=20 > Joshua Branson skribis: >=20 > > Timothy Sample writes: > > =20 > >> Hi Eric, > >> > >> Eric Bavier writes: =20 >=20 > [...] >=20 > >>> Yes, we decided to make it a hard requirement. I'm working on a patch > >>> to follow through. =20 > > > > I believe I created such a patch. =20 >=20 > Eric, could you consider merging your patch with Joshua=E2=80=99s? Making > Guile-JSON a hard dependency takes more than updating guix.texi, though. Here's an updated patch. I think this takes care of everything. Most of the conditional-loading logic in modules has been removed/factored/superseded already. `~Eric --MP_/TVvQ/8d9wk01=Wagiq0OqM4 Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-Make-Guile-JSON-a-required-dependency.patch =46rom 48c22f503493a4406758e91844d3708fe5f88864 Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Sat, 1 Dec 2018 20:46:22 -0600 Subject: [PATCH] Make Guile-JSON a required dependency. * README (Requirements): Remove "optional" verbiage. * doc/guix.texi (Requirements): Move Guile-JSON from optional to required. * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. (have_guile_json): Error if not "yes". * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests unconditionally. * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Lea= ve guile-json input. --- Makefile.am | 72 ++++++++++++----------------- README | 2 +- configure.ac | 6 ++- doc/guix.texi | 9 +--- gnu/packages/package-management.scm | 2 +- 5 files changed, 37 insertions(+), 54 deletions(-) diff --git a/Makefile.am b/Makefile.am index e14ac57f2..32cebd591 100644 --- a/Makefile.am +++ b/Makefile.am @@ -62,7 +62,9 @@ MODULES =3D \ guix/base16.scm \ guix/base32.scm \ guix/base64.scm \ + guix/ci.scm \ guix/cpio.scm \ + guix/docker.scm \ guix/records.scm \ guix/pki.scm \ guix/progress.scm \ @@ -186,15 +188,24 @@ MODULES =3D \ guix/build/make-bootstrap.scm \ guix/search-paths.scm \ guix/packages.scm \ - guix/import/print.scm \ - guix/import/utils.scm \ - guix/import/gnu.scm \ - guix/import/snix.scm \ guix/import/cabal.scm \ + guix/import/cpan.scm \ guix/import/cran.scm \ - guix/import/hackage.scm \ + guix/import/crate.scm \ guix/import/elpa.scm \ + guix/import/gem.scm \ + guix/import/github.scm \ + guix/import/gnome.scm \ + guix/import/gnu.scm \ + guix/import/hackage.scm \ + guix/import/json.scm \ + guix/import/opam.scm \ + guix/import/print.scm \ + guix/import/pypi.scm \ + guix/import/snix.scm \ + guix/import/stackage.scm \ guix/import/texlive.scm \ + guix/import/utils.scm \ guix/scripts.scm \ guix/scripts/download.scm \ guix/scripts/perform-download.scm \ @@ -216,46 +227,29 @@ MODULES =3D \ guix/scripts/system/search.scm \ guix/scripts/lint.scm \ guix/scripts/challenge.scm \ + guix/scripts/import/crate.scm \ guix/scripts/import/cran.scm \ + guix/scripts/import/elpa.scm \ + guix/scripts/import/gem.scm \ guix/scripts/import/gnu.scm \ - guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/elpa.scm \ + guix/scripts/import/json.scm \ + guix/scripts/import/nix.scm \ + guix/scripts/import/opam.scm \ + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm \ guix/scripts/import/texlive.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ guix/scripts/edit.scm \ guix/scripts/size.scm \ guix/scripts/graph.scm \ + guix/scripts/weather.scm \ guix/scripts/container.scm \ guix/scripts/container/exec.scm \ guix.scm \ $(GNU_SYSTEM_MODULES) =20 -if HAVE_GUILE_JSON - -MODULES +=3D \ - guix/ci.scm \ - guix/docker.scm \ - guix/import/cpan.scm \ - guix/import/crate.scm \ - guix/import/gem.scm \ - guix/import/github.scm \ - guix/import/gnome.scm \ - guix/import/json.scm \ - guix/import/opam.scm \ - guix/import/pypi.scm \ - guix/import/stackage.scm \ - guix/scripts/import/crate.scm \ - guix/scripts/import/gem.scm \ - guix/scripts/import/json.scm \ - guix/scripts/import/opam.scm \ - guix/scripts/import/pypi.scm \ - guix/scripts/import/stackage.scm \ - guix/scripts/weather.scm - -endif - if HAVE_GUILE_SSH =20 MODULES +=3D \ @@ -335,7 +329,10 @@ SCM_TESTS =3D \ tests/base16.scm \ tests/base32.scm \ tests/base64.scm \ + tests/cpan.scm \ tests/cpio.scm \ + tests/crate.scm \ + tests/gem.scm \ tests/pki.scm \ tests/print.scm \ tests/sets.scm \ @@ -389,22 +386,13 @@ SCM_TESTS =3D \ tests/services.scm \ tests/scripts-build.scm \ tests/containers.scm \ + tests/opam.scm \ tests/pack.scm \ + tests/pypi.scm \ tests/import-utils.scm \ tests/store-database.scm \ tests/store-deduplication.scm =20 -if HAVE_GUILE_JSON - -SCM_TESTS +=3D \ - tests/pypi.scm \ - tests/opam.scm \ - tests/cpan.scm \ - tests/gem.scm \ - tests/crate.scm - -endif - SH_TESTS =3D \ tests/guix-build.sh \ tests/guix-build-branch.sh \ diff --git a/README b/README index a7a818c5c..e7871917f 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ GNU Guix currently depends on the following packages: - [[https://notabug.org/guile-sqlite3/guile-sqlite3][Guile-SQLite3]], ve= rsion 0.1.0 or later - [[https://gitlab.com/guile-git/guile-git][Guile-Git]] - [[http://www.zlib.net/][zlib]] - - optionally [[https://savannah.nongnu.org/projects/guile-json/][Guile-J= SON]], for the 'guix import pypi' command + - [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]] =20 Unless `--disable-daemon' was passed, the following packages are needed: =20 diff --git a/configure.ac b/configure.ac index 2a1edbc32..2817e6e24 100644 --- a/configure.ac +++ b/configure.ac @@ -122,9 +122,11 @@ if test "x$have_guile_git" !=3D "xyes"; then AC_MSG_ERROR([Guile-Git is missing; please install it.]) fi =20 -dnl Guile-JSON is used in various places. +dnl Check for Guile-JSON. GUILE_MODULE_AVAILABLE([have_guile_json], [(json)]) -AM_CONDITIONAL([HAVE_GUILE_JSON], [test "x$have_guile_json" =3D "xyes"]) +if test "x$have_guile_json" !=3D "xyes"; then + AC_MSG_ERROR([Guile-JSON is missing; please install it.]) +fi =20 dnl Guile-Sqlite3 is used by the (guix store ...) modules. GUIX_CHECK_GUILE_SQLITE3 diff --git a/doc/guix.texi b/doc/guix.texi index fff5dfe0b..907735285 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -653,20 +653,13 @@ or later; @c FIXME: Specify a version number once a release has been made. @uref{https://gitlab.com/guile-git/guile-git, Guile-Git}, from August 2017 or later; +@item @uref{https://savannah.nongnu.org/projects/guile-json/, Guile-JSON}; @item @url{http://zlib.net, zlib}; @item @url{http://www.gnu.org/software/make/, GNU Make}. @end itemize =20 The following dependencies are optional: =20 -@itemize -@item -Installing -@url{http://savannah.nongnu.org/projects/guile-json/, Guile-JSON} will -allow you to use the @command{guix import pypi} command (@pxref{Invoking -guix import}). It is of -interest primarily for developers and not for casual users. - @item @c Note: We need at least 0.10.2 for 'channel-send-eof'. Support for build offloading (@pxref{Daemon Offload Setup}) and diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-man= agement.scm index 141d0e52f..c4e917102 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -389,7 +389,7 @@ the Nix package manager.") (propagated-inputs (fold alist-delete (package-propagated-inputs guix) - '("guile-json" "guile-ssh"))))))) + '("guile-ssh"))))))) =20 (define (source-file? file stat) "Return true if FILE is likely a source file, false if it is a typical --=20 2.19.1 --MP_/TVvQ/8d9wk01=Wagiq0OqM4-- --Sig_/YwBbVrV.jNWhPNhusqaVM5T Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwEWyEACgkQ/XPKxxnT JWbq/g/9G6/PDkrd0aStcLBkpJQaKmqMSxaJ+6sbEVFoCx0HiGL+0L/UnzIBMa3n Ni2J8L1NTi1ZoEVk4hOYhP77oOj8JVte0RI3a+KFPfWQOp52ZYCoF76wVHevcIQt YJQK5N37dbCHjQDQyAu4nLR1MK2QEI0oDwFPBT+eB4h8UdzHGqnPxfEuUcQ9cQFF GvjDJs6yK+O8SkQSgcS/AK5L7Dhq+Rvj7HDTXqgwzHPSNvHYa2DUiewFPxU/HY71 uCJwJ6kpzwB78nPLksTCsghMYYTpPnPiIH/sDL4wzzuy6CpY2ZnZMt7BtWqzGjf5 2u3/vqiU85qNqg6HtPsiIjg+JLzy7CdExQY4ZDKBQ9xsJzCA6nf0sTBfpgV00wsO C50cfJA3LJwcNFt0hV35zF7RpIe8CABUUYEPGovlbKGmEk50WkzbB4tPGM+vFApQ pmRfySCPW4wlZzOUJ4Lrq68tgO7lRgKdd17Rc2um7y7unAMRov5x2qoGs48C5wXi 03/wSg/VVrpZJQyctXKOFNV6w3DqLywyyme70Lg4SKP2Dqfu1EjI1kXCkVZ6NC4g UsczYe3sLsL/K7eUPBgYBUomDQvhTMzMGJX8X+daZtauZDvf9IXUhhBNPT8gXtTB B6mmvus3AzEl+CJIGevQm+yYgb4XKJ4IBIhlKfjZzYoywCKD6qs= =WVw0 -----END PGP SIGNATURE----- --Sig_/YwBbVrV.jNWhPNhusqaVM5T-- From unknown Sat Jun 14 19:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] Guile-JSON now seems to be a required dependency Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Dec 2018 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch Cc: guix-devel@gnu.org, Joshua Branson , 33572@debbugs.gnu.org Received: via spool by 33572-submit@debbugs.gnu.org id=B33572.154379035527271 (code B ref 33572); Sun, 02 Dec 2018 22:40:02 +0000 Received: (at 33572) by debbugs.gnu.org; 2 Dec 2018 22:39:15 +0000 Received: from localhost ([127.0.0.1]:58466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTaOJ-00075X-UU for submit@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:15 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:29054 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTaO9-00074u-Hr for 33572@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:06 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543790332; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=ARB14/aSgGIlT3Wq10y/Df2dhmQ=; b=fs+famDjifK53RW01UrVvxBgugnyBn5m31hz9Vf6RNWUs1ehbyB+eXDgiPK5WLHV x+3PA9sQKVHutQltxObFzX+/JhaTAXj9MB8MemgcwDhVDEY4i5UYKMmIDAJjgmg/ FKwR63vTGD57VyVctEScEK8dU1hoQh0szrbWIxMc69hJgwZH9Afbg/ctHacRIA+l XcMz9k84z5tyCzKpDNyVFE/hYaoXO3bB8g93PUXFb5fAx5zyCffxEvVQjrH0MnZv I224l+a/8p9YL52ph0UMkZkeFVylguwD/cdmRLKJHOwFQoSyIVJTMemILJKuVAaD BvJ0poVZsptNNaBsCo5sSA==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=SPAAb6nH c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=9cW_t1CCXrUA:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=I_5RNyk1AAAA:8 a=mDV3o1hIAAAA:8 a=ZLGELXoPAAAA:8 a=xyPz4MZXAAAA:8 a=jkeNA5DuGbtvc2G82hMA:9 a=QEXdDO2ut3YA:10 a=inoG4m36AAAA:8 a=CcLUTRNvAAAA:8 a=FFLdh5n2AAAA:20 a=fXms6y0vAAAA:8 a=69wJf7TsAAAA:8 a=YlWAI3VNwFMpwfLTPFcA:9 a=sA05eG8pRY_Lc50BeKYA:9 a=Eh9yxdLE6B1twWrs3SXz:22 a=_FVE-zBwftR9WsbkzFJk:22 a=CFiPc5v16LZhaT-MVE1c:22 a=MgilOBo1dlhwZn2HC1h_:22 a=_Qgj-RFg6mImvLaOgLPg:22 a=obhdfE27RNN5ZnF-s2K5:22 a=c6Zb8eaUoX5VaqycxFvw:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp01.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:51186] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 5C/94-05378-BFE540C5; Sun, 02 Dec 2018 17:38:51 -0500 Date: Sun, 2 Dec 2018 16:38:50 -0600 From: Eric Bavier Message-ID: <20181202163850.63cb6d9e@centurylink.net> In-Reply-To: <20181202162225.500e1721@centurylink.net> References: <87y399am9b.fsf@ngyro.com> <20181201091658.720e1f20@centurylink.net> <87sgzh9ivq.fsf@ngyro.com> <87woorg3hk.fsf@fastmail.com> <87a7lnlhd8.fsf@gnu.org> <20181202162225.500e1721@centurylink.net> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/xPc2i11ypu5xWWZ7lnDuxeO"; protocol="application/pgp-signature" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, 2 Dec 2018 16:22:25 -0600 Eric Bavier wrote: > On Sun, 02 Dec 2018 22:59:47 +0100 > ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) wrote: > > > Hello, > > > > Joshua Branson skribis: > > > > > Timothy Sample writes: > > > > > >> Hi Eric, > > >> > > >> Eric [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 MISSING_HEADERS Missing To: header -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ericbavier[at]centurylink.net) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --Sig_/xPc2i11ypu5xWWZ7lnDuxeO Content-Type: multipart/mixed; boundary="MP_/.bp2lE_IeEBCtqiYe2FYW+n" --MP_/.bp2lE_IeEBCtqiYe2FYW+n Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sun, 2 Dec 2018 16:22:25 -0600 Eric Bavier wrote: > On Sun, 02 Dec 2018 22:59:47 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >=20 > > Hello, > >=20 > > Joshua Branson skribis: > >=20 > > > Timothy Sample writes: > > > =20 > > >> Hi Eric, > > >> > > >> Eric Bavier writes: =20 > >=20 > > [...] > >=20 > > >>> Yes, we decided to make it a hard requirement. I'm working on a pa= tch > > >>> to follow through. =20 > > > > > > I believe I created such a patch. =20 > >=20 > > Eric, could you consider merging your patch with Joshua=E2=80=99s? Mak= ing > > Guile-JSON a hard dependency takes more than updating guix.texi, though. >=20 > Here's an updated patch. Oops, messed up the texinfo formatting; this patch is better. `~Eric --MP_/.bp2lE_IeEBCtqiYe2FYW+n Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-Make-Guile-JSON-a-required-dependency.patch =46rom 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Sat, 1 Dec 2018 20:46:22 -0600 Subject: [PATCH] Make Guile-JSON a required dependency. * README (Requirements): Remove "optional" verbiage. * doc/guix.texi (Requirements): Move Guile-JSON from optional to required. * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. (have_guile_json): Error if not "yes". * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests unconditionally. * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Lea= ve guile-json input. --- Makefile.am | 72 ++++++++++++----------------- README | 2 +- configure.ac | 6 ++- doc/guix.texi | 8 +--- gnu/packages/package-management.scm | 2 +- 5 files changed, 37 insertions(+), 53 deletions(-) diff --git a/Makefile.am b/Makefile.am index e14ac57f2..32cebd591 100644 --- a/Makefile.am +++ b/Makefile.am @@ -62,7 +62,9 @@ MODULES =3D \ guix/base16.scm \ guix/base32.scm \ guix/base64.scm \ + guix/ci.scm \ guix/cpio.scm \ + guix/docker.scm \ guix/records.scm \ guix/pki.scm \ guix/progress.scm \ @@ -186,15 +188,24 @@ MODULES =3D \ guix/build/make-bootstrap.scm \ guix/search-paths.scm \ guix/packages.scm \ - guix/import/print.scm \ - guix/import/utils.scm \ - guix/import/gnu.scm \ - guix/import/snix.scm \ guix/import/cabal.scm \ + guix/import/cpan.scm \ guix/import/cran.scm \ - guix/import/hackage.scm \ + guix/import/crate.scm \ guix/import/elpa.scm \ + guix/import/gem.scm \ + guix/import/github.scm \ + guix/import/gnome.scm \ + guix/import/gnu.scm \ + guix/import/hackage.scm \ + guix/import/json.scm \ + guix/import/opam.scm \ + guix/import/print.scm \ + guix/import/pypi.scm \ + guix/import/snix.scm \ + guix/import/stackage.scm \ guix/import/texlive.scm \ + guix/import/utils.scm \ guix/scripts.scm \ guix/scripts/download.scm \ guix/scripts/perform-download.scm \ @@ -216,46 +227,29 @@ MODULES =3D \ guix/scripts/system/search.scm \ guix/scripts/lint.scm \ guix/scripts/challenge.scm \ + guix/scripts/import/crate.scm \ guix/scripts/import/cran.scm \ + guix/scripts/import/elpa.scm \ + guix/scripts/import/gem.scm \ guix/scripts/import/gnu.scm \ - guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/elpa.scm \ + guix/scripts/import/json.scm \ + guix/scripts/import/nix.scm \ + guix/scripts/import/opam.scm \ + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm \ guix/scripts/import/texlive.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ guix/scripts/edit.scm \ guix/scripts/size.scm \ guix/scripts/graph.scm \ + guix/scripts/weather.scm \ guix/scripts/container.scm \ guix/scripts/container/exec.scm \ guix.scm \ $(GNU_SYSTEM_MODULES) =20 -if HAVE_GUILE_JSON - -MODULES +=3D \ - guix/ci.scm \ - guix/docker.scm \ - guix/import/cpan.scm \ - guix/import/crate.scm \ - guix/import/gem.scm \ - guix/import/github.scm \ - guix/import/gnome.scm \ - guix/import/json.scm \ - guix/import/opam.scm \ - guix/import/pypi.scm \ - guix/import/stackage.scm \ - guix/scripts/import/crate.scm \ - guix/scripts/import/gem.scm \ - guix/scripts/import/json.scm \ - guix/scripts/import/opam.scm \ - guix/scripts/import/pypi.scm \ - guix/scripts/import/stackage.scm \ - guix/scripts/weather.scm - -endif - if HAVE_GUILE_SSH =20 MODULES +=3D \ @@ -335,7 +329,10 @@ SCM_TESTS =3D \ tests/base16.scm \ tests/base32.scm \ tests/base64.scm \ + tests/cpan.scm \ tests/cpio.scm \ + tests/crate.scm \ + tests/gem.scm \ tests/pki.scm \ tests/print.scm \ tests/sets.scm \ @@ -389,22 +386,13 @@ SCM_TESTS =3D \ tests/services.scm \ tests/scripts-build.scm \ tests/containers.scm \ + tests/opam.scm \ tests/pack.scm \ + tests/pypi.scm \ tests/import-utils.scm \ tests/store-database.scm \ tests/store-deduplication.scm =20 -if HAVE_GUILE_JSON - -SCM_TESTS +=3D \ - tests/pypi.scm \ - tests/opam.scm \ - tests/cpan.scm \ - tests/gem.scm \ - tests/crate.scm - -endif - SH_TESTS =3D \ tests/guix-build.sh \ tests/guix-build-branch.sh \ diff --git a/README b/README index a7a818c5c..e7871917f 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ GNU Guix currently depends on the following packages: - [[https://notabug.org/guile-sqlite3/guile-sqlite3][Guile-SQLite3]], ve= rsion 0.1.0 or later - [[https://gitlab.com/guile-git/guile-git][Guile-Git]] - [[http://www.zlib.net/][zlib]] - - optionally [[https://savannah.nongnu.org/projects/guile-json/][Guile-J= SON]], for the 'guix import pypi' command + - [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]] =20 Unless `--disable-daemon' was passed, the following packages are needed: =20 diff --git a/configure.ac b/configure.ac index 2a1edbc32..2817e6e24 100644 --- a/configure.ac +++ b/configure.ac @@ -122,9 +122,11 @@ if test "x$have_guile_git" !=3D "xyes"; then AC_MSG_ERROR([Guile-Git is missing; please install it.]) fi =20 -dnl Guile-JSON is used in various places. +dnl Check for Guile-JSON. GUILE_MODULE_AVAILABLE([have_guile_json], [(json)]) -AM_CONDITIONAL([HAVE_GUILE_JSON], [test "x$have_guile_json" =3D "xyes"]) +if test "x$have_guile_json" !=3D "xyes"; then + AC_MSG_ERROR([Guile-JSON is missing; please install it.]) +fi =20 dnl Guile-Sqlite3 is used by the (guix store ...) modules. GUIX_CHECK_GUILE_SQLITE3 diff --git a/doc/guix.texi b/doc/guix.texi index fff5dfe0b..6cb63edb9 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -653,6 +653,7 @@ or later; @c FIXME: Specify a version number once a release has been made. @uref{https://gitlab.com/guile-git/guile-git, Guile-Git}, from August 2017 or later; +@item @uref{https://savannah.nongnu.org/projects/guile-json/, Guile-JSON}; @item @url{http://zlib.net, zlib}; @item @url{http://www.gnu.org/software/make/, GNU Make}. @end itemize @@ -660,13 +661,6 @@ or later; The following dependencies are optional: =20 @itemize -@item -Installing -@url{http://savannah.nongnu.org/projects/guile-json/, Guile-JSON} will -allow you to use the @command{guix import pypi} command (@pxref{Invoking -guix import}). It is of -interest primarily for developers and not for casual users. - @item @c Note: We need at least 0.10.2 for 'channel-send-eof'. Support for build offloading (@pxref{Daemon Offload Setup}) and diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-man= agement.scm index 141d0e52f..c4e917102 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -389,7 +389,7 @@ the Nix package manager.") (propagated-inputs (fold alist-delete (package-propagated-inputs guix) - '("guile-json" "guile-ssh"))))))) + '("guile-ssh"))))))) =20 (define (source-file? file stat) "Return true if FILE is likely a source file, false if it is a typical --=20 2.19.1 --MP_/.bp2lE_IeEBCtqiYe2FYW+n-- --Sig_/xPc2i11ypu5xWWZ7lnDuxeO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwEXvoACgkQ/XPKxxnT JWYwSA/9GtZfVXt2YjMxrwQRy60zVOPE7fu9IEAS2jQVSloznqxPyA4pjGQNcDj1 ZEZlfX0t+qXUAqzCWN2tqc4siWQwjJFeHYRZEfrPmi42vaWALlnzHr297rDOWx9X dZCffL0iYOUCCk+5m+isdTAXxD2HpA0m/wYCVGOuJrLqnswpp77QrSH7eFuAFlwh wRuV6sJVk0zo67NK75Hsef/vQxBq6YWSqGW1ir1q9tjECkHkSkmFsJTzAleZClXy xMA+SAOfWntZsf8sJrP0H+HsrOe0w/JeI1vZvP1+bM23ViJqJKGD49bRh/Kotqgx lpw/8105wOe1pRgZtOYESMSyEwtP9bPt94ElKE/QWuCTikMFH8CH1FWXtVSCw3q5 Ji/cwIn/nBzU1J4/CrgD7ZpWH1kuUkUoFzdRo8rRbCT1R6LghgdaOjMkkAJf16UA oPeFqHOSi2thE2XrBnlJWXgdazYRpPmAPjtrW/3Ey4DmgI3zZZF4BS1zCoWr6vIT rxM6bOCtf957yJ6WwMDUU/rxQ309AV0dzuS9AUmixHGrnYIx9HieJEzsge0ziYXE SvF4h0247EXKory9iLIRkfva3G84eRWx+Nx6wJMfRwdJItIvC/fcTQi3tGA76gsE BO8OXb1063mst6hhO4RfJBvTExygtyJXX2/DMkWLo2u6fMuQgeE= =pWSX -----END PGP SIGNATURE----- --Sig_/xPc2i11ypu5xWWZ7lnDuxeO-- From unknown Sat Jun 14 19:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] [PATCH] Make Guile-JSON a required dependency. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Dec 2018 22:40:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ericbavier@centurylink.net Cc: Eric Bavier , 33572@debbugs.gnu.org Received: via spool by 33572-submit@debbugs.gnu.org id=B33572.154379035727282 (code B ref 33572); Sun, 02 Dec 2018 22:40:04 +0000 Received: (at 33572) by debbugs.gnu.org; 2 Dec 2018 22:39:17 +0000 Received: from localhost ([127.0.0.1]:58469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTaOS-00075v-T9 for submit@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTaOR-00075b-Gj for 33572@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTaOL-0007Ru-IN for 33572@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTaOJ-0007PF-3K; Sun, 02 Dec 2018 17:39:07 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56400 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gTaOI-00076X-5u; Sun, 02 Dec 2018 17:39:07 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20181202051822.8344-1-ericbavier@centurylink.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Frimaire an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 02 Dec 2018 23:39:04 +0100 In-Reply-To: <20181202051822.8344-1-ericbavier@centurylink.net> (ericbavier's message of "Sat, 1 Dec 2018 23:18:22 -0600") Message-ID: <875zwbk0zb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello Eric, ericbavier@centurylink.net skribis: > From: Eric Bavier > > * README (Requirements): Remove "optional" verbiage. > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. > (have_guile_json): Error if not "yes". > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests > unconditionally. > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: L= eave > guile-json input. Could you include guix.texi changes along the lines of what Joshua proposed on guix-devel? Otherwise LGTM, thanks! Ludo=E2=80=99. From unknown Sat Jun 14 19:27:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: ericbavier@centurylink.net Subject: bug#33572: closed (Re: [bug#33572] [PATCH] Make Guile-JSON a required dependency.) Message-ID: References: <20181202182218.40049d39@centurylink.net> <20181202051822.8344-1-ericbavier@centurylink.net> X-Gnu-PR-Message: they-closed 33572 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 33572@debbugs.gnu.org Date: Mon, 03 Dec 2018 00:23:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1543796582-13098-1" This is a multi-part message in MIME format... ------------=_1543796582-13098-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33572: [PATCH] Make Guile-JSON a required dependency. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33572@debbugs.gnu.org. --=20 33572: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33572 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1543796582-13098-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33572-done) by debbugs.gnu.org; 3 Dec 2018 00:22:32 +0000 Received: from localhost ([127.0.0.1]:58508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTc0O-0003OW-J3 for submit@debbugs.gnu.org; Sun, 02 Dec 2018 19:22:32 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:21554 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTc0M-0003OF-Ju for 33572-done@debbugs.gnu.org; Sun, 02 Dec 2018 19:22:31 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543796544; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=/obhZVl/6+UL+dw8y5fdtkagWtk=; b=4d1LJeqEUdAlKteZEjW+y0HezCc4k3jztrplkI6HMGbn1hKcXbRKfzhXwt9kWY1c Ti9WEDUi+q88Wxz6fvktuo8gtJhnjtclnpS1JqAQ9oyNZDzQhkdM5TfdHD0wOMYs WsscUG4WJDlmUTCdo6lvygqEPsNxcJdsDtPN5M3OWyb1JnUm6rpJ/Jlo3x77QBS/ k5ekRR+D7HkQIypxFyiwn8POKU1SWjcI3mWn1hsIOHltr+1Th6zRLzTAlXSMZZrJ FGLwMTNwEkWJbG4yeitS8KLVo2UVQfA3p18UTWwv5HSGj0fQMR+BZFauhccDYQBF L0l0ZSeLfE7tOwQy1cvH9g==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=KLAYNxNo c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=9cW_t1CCXrUA:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=I_5RNyk1AAAA:8 a=inoG4m36AAAA:8 a=jRy9nKJgBQng5PeVhnwA:9 a=QEXdDO2ut3YA:10 a=45xGrA4LyI2KgjvAo6wA:9 a=_FVE-zBwftR9WsbkzFJk:22 a=Eh9yxdLE6B1twWrs3SXz:22 a=_Qgj-RFg6mImvLaOgLPg:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp03.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:53470] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 88/4C-30600-047740C5; Sun, 02 Dec 2018 19:22:24 -0500 Date: Sun, 2 Dec 2018 18:22:18 -0600 From: Eric Bavier Subject: Re: [bug#33572] [PATCH] Make Guile-JSON a required dependency. Message-ID: <20181202182218.40049d39@centurylink.net> In-Reply-To: <875zwbk0zb.fsf@gnu.org> References: <20181202051822.8344-1-ericbavier@centurylink.net> <875zwbk0zb.fsf@gnu.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/cV7w=pa5/.t7H+g0a4YPmdW"; protocol="application/pgp-signature" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, 02 Dec 2018 23:39:04 +0100 ludo@gnu.org (Ludovic Courtès) wrote: > Hello Eric, > > > > > From: Eric Bavier > > > > * README (Requirements): Remove "optional" verbiage. > > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. > > (have_guile_json): Err [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 MISSING_HEADERS Missing To: header -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ericbavier[at]centurylink.net) X-Debbugs-Envelope-To: 33572-done Cc: 33572-done@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --Sig_/cV7w=pa5/.t7H+g0a4YPmdW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 02 Dec 2018 23:39:04 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello Eric, >=20 > ericbavier@centurylink.net skribis: >=20 > > From: Eric Bavier > > > > * README (Requirements): Remove "optional" verbiage. > > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. > > (have_guile_json): Error if not "yes". > > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tes= ts > > unconditionally. > > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]:= Leave > > guile-json input. =20 >=20 > Could you include guix.texi changes along the lines of what Joshua > proposed on guix-devel? Done. > Otherwise LGTM, thanks! >=20 > Ludo=E2=80=99. Thanks for the review. Pushed in 6776af04d4b65c5a9a07784307a6abe395b6f480 `~Eric --Sig_/cV7w=pa5/.t7H+g0a4YPmdW Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwEdzoACgkQ/XPKxxnT JWZf5Q//V4jxUudyZ6gDvkDYcAnzRbUQRWM305N4TEjt+dH1B6iG5NbaB0izJRSU LDFyLRN/Pj5RXv6dSNBfccm0rBmC0KyJaabDhwhk2qZ2xsCM2GLVTISQ1FJSVRLM Ol9PcRgfHab6yPpGhtkdWfmehw9LWkFQ6i66J0x7LBLfx0UPb4nskhyuqyOeGtyU a9l1upH1sWBwdx/x/7lFUlhqCAiAa7hnrK5m02z0iv/PhivRMGRjWWMcfOx5usku BAKVesnNcSkGAX96Ey1JV3RC9Zyz/ukU54FvvowJq7Km6NXYeXyDexG9fEv9Uc7g UodYQUUfUGvBoK3QGq2D+fX4poiWugKG1C+GFtsyAA6sSisUB+MDPs2z4c1GjcQl 1ad1oXKNOgv29UUjHf4BET+kmdCsL/goZdI9QNZ2LvKq+lPT2vd5gWK4pbQ5LDQR JzwFct646yC63sGuQM4E2/GckOIrMfdvrMWz3xiKSqpEK5uyg9NYCpsRHwWnKJX7 Rr1MpPyOXHlCsjBsTRItrAdqCXprXoEipL2YXIl+7E4x7uzifLFIU7wqcYxMX7+8 Lf1tyR/QRpSb+zZRld3hHkXhTp/G7/JPIodE7dihsb9prnh0B1wmTA9eieGq4S5U er9jhdcN8ufnXE+8br7/DaF+uxURV03KKLRDzMc1Rqb/IznuNbM= =QGQq -----END PGP SIGNATURE----- --Sig_/cV7w=pa5/.t7H+g0a4YPmdW-- ------------=_1543796582-13098-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Dec 2018 05:19:08 +0000 Received: from localhost ([127.0.0.1]:57449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTK9k-0005Mq-9I for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:19:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTK9e-0005MY-Pm for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:18:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTK9Y-0004TF-57 for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:18:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTK9Y-0004TB-2P for submit@debbugs.gnu.org; Sun, 02 Dec 2018 00:18:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTK9W-0001lk-Qr for guix-patches@gnu.org; Sun, 02 Dec 2018 00:18:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTK9T-0004Qf-LG for guix-patches@gnu.org; Sun, 02 Dec 2018 00:18:46 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:21184 helo=smtp.centurylink.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTK9T-0004Q2-E5 for guix-patches@gnu.org; Sun, 02 Dec 2018 00:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543727922; h=From:Subject:Date:To:MIME-Version; bh=6Dg/j7tk8uAFgDBgB0PLAVAmDFw=; b=31VShiyWMP+TZQqq1+z4I6cOd5/Z7H7HUWyZveRvXFnpMlTE+Zra0mn0su8+tlfi OFhx/xW9hxBbslnWshxWxhOnxL9EIQlsSAB+UZwRaUqtaOAAFb0nmvBDxr5Drf/k qyT8+QK6HJ3bNEM7q5r0cT7Dn6ddFvCd0/hZHg4vdOXi6BPs9EEEOrugX4ezyMCM 14Egx082V5Bn/7N+RiKCn30mbEfx5q5XHMrZuRjm++ORwLyNYr4oR+hVaDjCRxvU /49qqlzVj8odHIOqQQXReRKdu/uC4TuDJSuQkRP6FEDTNWQu94JJkowYg2yp1MB8 zsQT5AXrI5L99V/TZyGcSg==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=Sbi1TbZu c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=inoG4m36AAAA:8 a=CcLUTRNvAAAA:8 a=FFLdh5n2AAAA:20 a=fXms6y0vAAAA:8 a=69wJf7TsAAAA:8 a=p-wP41oKWemYr1zPVNkA:9 a=_Qgj-RFg6mImvLaOgLPg:22 a=obhdfE27RNN5ZnF-s2K5:22 a=c6Zb8eaUoX5VaqycxFvw:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp02.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:49464] helo=localhost.localdomain) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=DHE-RSA-AES128-GCM-SHA256) id 03/10-10541-13B630C5; Sun, 02 Dec 2018 00:18:42 -0500 From: ericbavier@centurylink.net To: guix-patches@gnu.org Subject: [PATCH] Make Guile-JSON a required dependency. Date: Sat, 1 Dec 2018 23:18:22 -0600 Message-Id: <20181202051822.8344-1-ericbavier@centurylink.net> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) From: Eric Bavier * README (Requirements): Remove "optional" verbiage. * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. (have_guile_json): Error if not "yes". * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests unconditionally. * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave guile-json input. --- Makefile.am | 72 ++++++++++++----------------- README | 2 +- configure.ac | 6 ++- gnu/packages/package-management.scm | 2 +- 4 files changed, 36 insertions(+), 46 deletions(-) diff --git a/Makefile.am b/Makefile.am index e14ac57f2..32cebd591 100644 --- a/Makefile.am +++ b/Makefile.am @@ -62,7 +62,9 @@ MODULES = \ guix/base16.scm \ guix/base32.scm \ guix/base64.scm \ + guix/ci.scm \ guix/cpio.scm \ + guix/docker.scm \ guix/records.scm \ guix/pki.scm \ guix/progress.scm \ @@ -186,15 +188,24 @@ MODULES = \ guix/build/make-bootstrap.scm \ guix/search-paths.scm \ guix/packages.scm \ - guix/import/print.scm \ - guix/import/utils.scm \ - guix/import/gnu.scm \ - guix/import/snix.scm \ guix/import/cabal.scm \ + guix/import/cpan.scm \ guix/import/cran.scm \ - guix/import/hackage.scm \ + guix/import/crate.scm \ guix/import/elpa.scm \ + guix/import/gem.scm \ + guix/import/github.scm \ + guix/import/gnome.scm \ + guix/import/gnu.scm \ + guix/import/hackage.scm \ + guix/import/json.scm \ + guix/import/opam.scm \ + guix/import/print.scm \ + guix/import/pypi.scm \ + guix/import/snix.scm \ + guix/import/stackage.scm \ guix/import/texlive.scm \ + guix/import/utils.scm \ guix/scripts.scm \ guix/scripts/download.scm \ guix/scripts/perform-download.scm \ @@ -216,46 +227,29 @@ MODULES = \ guix/scripts/system/search.scm \ guix/scripts/lint.scm \ guix/scripts/challenge.scm \ + guix/scripts/import/crate.scm \ guix/scripts/import/cran.scm \ + guix/scripts/import/elpa.scm \ + guix/scripts/import/gem.scm \ guix/scripts/import/gnu.scm \ - guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/elpa.scm \ + guix/scripts/import/json.scm \ + guix/scripts/import/nix.scm \ + guix/scripts/import/opam.scm \ + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm \ guix/scripts/import/texlive.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ guix/scripts/edit.scm \ guix/scripts/size.scm \ guix/scripts/graph.scm \ + guix/scripts/weather.scm \ guix/scripts/container.scm \ guix/scripts/container/exec.scm \ guix.scm \ $(GNU_SYSTEM_MODULES) -if HAVE_GUILE_JSON - -MODULES += \ - guix/ci.scm \ - guix/docker.scm \ - guix/import/cpan.scm \ - guix/import/crate.scm \ - guix/import/gem.scm \ - guix/import/github.scm \ - guix/import/gnome.scm \ - guix/import/json.scm \ - guix/import/opam.scm \ - guix/import/pypi.scm \ - guix/import/stackage.scm \ - guix/scripts/import/crate.scm \ - guix/scripts/import/gem.scm \ - guix/scripts/import/json.scm \ - guix/scripts/import/opam.scm \ - guix/scripts/import/pypi.scm \ - guix/scripts/import/stackage.scm \ - guix/scripts/weather.scm - -endif - if HAVE_GUILE_SSH MODULES += \ @@ -335,7 +329,10 @@ SCM_TESTS = \ tests/base16.scm \ tests/base32.scm \ tests/base64.scm \ + tests/cpan.scm \ tests/cpio.scm \ + tests/crate.scm \ + tests/gem.scm \ tests/pki.scm \ tests/print.scm \ tests/sets.scm \ @@ -389,22 +386,13 @@ SCM_TESTS = \ tests/services.scm \ tests/scripts-build.scm \ tests/containers.scm \ + tests/opam.scm \ tests/pack.scm \ + tests/pypi.scm \ tests/import-utils.scm \ tests/store-database.scm \ tests/store-deduplication.scm -if HAVE_GUILE_JSON - -SCM_TESTS += \ - tests/pypi.scm \ - tests/opam.scm \ - tests/cpan.scm \ - tests/gem.scm \ - tests/crate.scm - -endif - SH_TESTS = \ tests/guix-build.sh \ tests/guix-build-branch.sh \ diff --git a/README b/README index a7a818c5c..e7871917f 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ GNU Guix currently depends on the following packages: - [[https://notabug.org/guile-sqlite3/guile-sqlite3][Guile-SQLite3]], version 0.1.0 or later - [[https://gitlab.com/guile-git/guile-git][Guile-Git]] - [[http://www.zlib.net/][zlib]] - - optionally [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]], for the 'guix import pypi' command + - [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]] Unless `--disable-daemon' was passed, the following packages are needed: diff --git a/configure.ac b/configure.ac index 2a1edbc32..2817e6e24 100644 --- a/configure.ac +++ b/configure.ac @@ -122,9 +122,11 @@ if test "x$have_guile_git" != "xyes"; then AC_MSG_ERROR([Guile-Git is missing; please install it.]) fi -dnl Guile-JSON is used in various places. +dnl Check for Guile-JSON. GUILE_MODULE_AVAILABLE([have_guile_json], [(json)]) -AM_CONDITIONAL([HAVE_GUILE_JSON], [test "x$have_guile_json" = "xyes"]) +if test "x$have_guile_json" != "xyes"; then + AC_MSG_ERROR([Guile-JSON is missing; please install it.]) +fi dnl Guile-Sqlite3 is used by the (guix store ...) modules. GUIX_CHECK_GUILE_SQLITE3 diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index 141d0e52f..c4e917102 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -389,7 +389,7 @@ the Nix package manager.") (propagated-inputs (fold alist-delete (package-propagated-inputs guix) - '("guile-json" "guile-ssh"))))))) + '("guile-ssh"))))))) (define (source-file? file stat) "Return true if FILE is likely a source file, false if it is a typical -- 2.19.2 ------------=_1543796582-13098-1-- From unknown Sat Jun 14 19:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] Guile-JSON now seems to be a required dependency Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Dec 2018 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Eric Bavier Cc: guix-devel@gnu.org, Joshua Branson , 33572@debbugs.gnu.org Received: via spool by 33572-submit@debbugs.gnu.org id=B33572.15438268114171 (code B ref 33572); Mon, 03 Dec 2018 08:47:02 +0000 Received: (at 33572) by debbugs.gnu.org; 3 Dec 2018 08:46:51 +0000 Received: from localhost ([127.0.0.1]:58686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTjsQ-00015D-Pa for submit@debbugs.gnu.org; Mon, 03 Dec 2018 03:46:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTjsP-00014y-84 for 33572@debbugs.gnu.org; Mon, 03 Dec 2018 03:46:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTjsI-0000Ah-Kn for 33572@debbugs.gnu.org; Mon, 03 Dec 2018 03:46:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTjsI-0000Aa-HP; Mon, 03 Dec 2018 03:46:42 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=49966 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gTjsI-0007ht-8q; Mon, 03 Dec 2018 03:46:42 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87y399am9b.fsf@ngyro.com> <20181201091658.720e1f20@centurylink.net> <87sgzh9ivq.fsf@ngyro.com> <87woorg3hk.fsf@fastmail.com> <87a7lnlhd8.fsf@gnu.org> <20181202162225.500e1721@centurylink.net> <20181202163850.63cb6d9e@centurylink.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Frimaire an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 03 Dec 2018 09:46:40 +0100 In-Reply-To: <20181202163850.63cb6d9e@centurylink.net> (Eric Bavier's message of "Sun, 2 Dec 2018 16:38:50 -0600") Message-ID: <87ftvfatfz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi, Eric Bavier skribis: > From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Sat, 1 Dec 2018 20:46:22 -0600 > Subject: [PATCH] Make Guile-JSON a required dependency. > > * README (Requirements): Remove "optional" verbiage. > * doc/guix.texi (Requirements): Move Guile-JSON from optional to required. > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. > (have_guile_json): Error if not "yes". > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests > unconditionally. > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: L= eave > guile-json input. One last thing: guix.texi contains a few footnotes like: This functionality requires Guile-JSON to be installed. Could you remove them as well? Otherwise LGTM, thank you! Ludo=E2=80=99. From unknown Sat Jun 14 19:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] Guile-JSON now seems to be a required dependency Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Dec 2018 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: guix-devel@gnu.org, Joshua Branson , 33572@debbugs.gnu.org Received: via spool by 33572-submit@debbugs.gnu.org id=B33572.154384913718269 (code B ref 33572); Mon, 03 Dec 2018 14:59:01 +0000 Received: (at 33572) by debbugs.gnu.org; 3 Dec 2018 14:58:57 +0000 Received: from localhost ([127.0.0.1]:59315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTpgX-0004kb-BY for submit@debbugs.gnu.org; Mon, 03 Dec 2018 09:58:57 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:22585 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTpgU-0004kJ-TL for 33572@debbugs.gnu.org; Mon, 03 Dec 2018 09:58:55 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543849128; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=XVkjLWj9rLNy63hZAfh236CU4QM=; b=isTCyhoqANAC6U6lbWSFm6xG1zQmZaZRbtlD7EKpF4IPHuRJHvrm4B+S2rSSAubw hezOHauykiwh9QzgsxbcGqkNos9SRE+WCUGFC+4zzTDaiPXiMCjM1/QAdF/2zIme t48QjIgaQEs7p1eT+BduDkr9bcwKGEK48K4D6GhQ9SIHeeU+aX7xu1QxelN8ybS3 6NQAkovEMFdncbL38fBv6UGypslQjuYRn5pNmoWs7n8yY1ux/xmpjILtJKlAga7g m2ev1lKwt3jXmgaarPJxftyatB+RunPR0pxa8o4XRId29IE3GU6cRSGZZUJ2mWY7 5OMrYHlbMtpgrGNBUVM4HA==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=Xs64AhN9 c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=I_5RNyk1AAAA:8 a=inoG4m36AAAA:8 a=L8y98XJqIHJ9vspS0scA:9 a=QEXdDO2ut3YA:10 a=yQX73rbfqiz5HTDDROAA:9 a=_FVE-zBwftR9WsbkzFJk:22 a=Eh9yxdLE6B1twWrs3SXz:22 a=_Qgj-RFg6mImvLaOgLPg:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp01.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:54576] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 1E/5D-14659-8A4450C5; Mon, 03 Dec 2018 09:58:48 -0500 Date: Mon, 3 Dec 2018 08:58:47 -0600 From: Eric Bavier Message-ID: <20181203085847.5a35f271@centurylink.net> In-Reply-To: <87ftvfatfz.fsf@gnu.org> References: <87y399am9b.fsf@ngyro.com> <20181201091658.720e1f20@centurylink.net> <87sgzh9ivq.fsf@ngyro.com> <87woorg3hk.fsf@fastmail.com> <87a7lnlhd8.fsf@gnu.org> <20181202162225.500e1721@centurylink.net> <20181202163850.63cb6d9e@centurylink.net> <87ftvfatfz.fsf@gnu.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/QXD.W_f4krL5/Z5vqFpK4Tm"; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/QXD.W_f4krL5/Z5vqFpK4Tm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 03 Dec 2018 09:46:40 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hi, >=20 > Eric Bavier skribis: >=20 > > From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001 > > From: Eric Bavier > > Date: Sat, 1 Dec 2018 20:46:22 -0600 > > Subject: [PATCH] Make Guile-JSON a required dependency. > > > > * README (Requirements): Remove "optional" verbiage. > > * doc/guix.texi (Requirements): Move Guile-JSON from optional to requir= ed. > > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. > > (have_guile_json): Error if not "yes". > > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tes= ts > > unconditionally. > > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]:= Leave > > guile-json input. =20 >=20 > One last thing: guix.texi contains a few footnotes like: >=20 > This functionality requires Guile-JSON to be installed. >=20 > Could you remove them as well? Good catch. Thanks. Fixed in a8fdca11d85296b4df1b60a0c8ce4e33c92759af `~Eric --Sig_/QXD.W_f4krL5/Z5vqFpK4Tm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwFRKcACgkQ/XPKxxnT JWZFjg//Z+6y1tMzxKo0g+HqwjsCd7p1ztIu+8SqKy3IB8COWIoGwtWl151jlX6o 5iNQxAAS1i358r+A6u2Ho9cyBHniKYYruq8Uy0JlmH1D++Nxa9IdmqR/f+mxCwgP RaFrmei+1h7zgPwz6WDt8gUpJ6bDWMhhivBZA4jdic8FMx+efIqI7mpJENo/mORe qmZK0eSxCuEeyNJMPY2Qsy8TsqJXEIU59cMUEff9FLu+fjKY20rIuKM4ZJhTwdDR dXlk9vMFw7vy/e3/t12WU1pmff9eqSehJuojXdxvJG0e55f+MFZ/opIVCata8qjM rS6PTEejuOGyYkmwQju69/55Mr75YsqMBbMj4XwoEsmji2A8nVTh8DsD72HjLtm1 9XG6mxFt54UZxYR4f5BMm7NGKmk0NgMEDmxjLJWgEgXas1s2SXGBbO01C3+s0c4w 4jwpd+FlzFR5eOeyHEBNjAj+2grklcwlxkif8Jm4b/7yPUEFCn5/gaaCc1hwExro tVJejPK13g2iwGNpBi2S0ukBjcEN4RHCc1pRqTgwZIvhT2bLbaLydASIwZrSpktX 7wS9oqbN2JOgZMXd42cghgaAa1s53bnlgm6IKrQjVhI6cQtjX2XgGnvUgL77wP7x M/yMpchlIDOFl2ZIMhEkirB/GyP8ZXEw49V0z/JWqNdQum4B+g8= =GzT0 -----END PGP SIGNATURE----- --Sig_/QXD.W_f4krL5/Z5vqFpK4Tm--