From unknown Sun Jun 22 11:47:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33566: 26; `group' :type for defcustom Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Dec 2018 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33566@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154369711419865 (code B ref -1); Sat, 01 Dec 2018 20:46:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Dec 2018 20:45:14 +0000 Received: from localhost ([127.0.0.1]:57312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTC8X-00059w-Gf for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTC8V-00052m-Fu for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTC8P-0006gi-FL for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTC8P-0006gc-Cn for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTC8O-00063u-Du for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2018 15:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTC8L-0006dn-9K for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2018 15:45:04 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:48230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTC8L-0006cF-0F for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2018 15:45:01 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB1KiweL007605 for ; Sat, 1 Dec 2018 20:44:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=cVMAv6p+ytNOzPSoKx1TnSYzT1aBAnmvzfGYxtjKjMI=; b=wF21P3EVIdfbMaS/pb43oDRJMX/2mEAB+1ZNH9lBAcz1r3ZDjpX0emQc9z0QOTdCP+0F AXUEK7DeD5GShOrD3JXHg/B13m5DJmcQLtlUEXwIiqXKmVg3D/tyoSFb9jgi3ym2MRAJ 6DlaGWrlESSYwN/cetHtTiajCkoUUkrmkoy34guRYBVt507ZTOfipSYpYkvnCi41GuY/ G4tZ1EJEM/u7TwMCIMtJzrG0D0ihk74TlITqe5daMO+bE9IdY6d7lqk0wFOHXHEgN/M9 MX2wDT05uAgOPRn4+KGuac97Poei0QCdf43p+plPYDKtVqaV2j1M1q9kIIQgkWgM9H3X 2A== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2p3hqthg0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 01 Dec 2018 20:44:58 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB1Kivo1020750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 1 Dec 2018 20:44:57 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB1KivJd019121 for ; Sat, 1 Dec 2018 20:44:57 GMT MIME-Version: 1.0 Message-ID: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> Date: Sat, 1 Dec 2018 12:44:56 -0800 (PST) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9094 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812010192 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) It seems like defcustom composite :type `group' does not work. See https://emacs.stackexchange.com/q/46357/105. emacs -Q (defcustom foo '(1 2 3) "..." :type '(group integer integer integer) :group 'emacs) M-x customize-option foo Shows this message in *Messages*: custom-variable-value-create: Bad format And buffer *Customize Option: Foo* is not complete. I see only this: ------------8<---------------- Custom settings cannot be saved; maybe you started Emacs with '-q'. For help using this buffer, see Easy Customization in the Emacs manual. Search=20 Operate on all settings in this buffer: Revert... Apply =20 Hide=20 ------------8<---------------- The doc says that :type `group' should be very similar to :type `list', but without tags. See also this bug: https://lists.gnu.org/archive/html/emacs-pretest-bug/2007-06/msg00067.html In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.16299 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Sun Jun 22 11:47:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33566: 26; `group' :type for defcustom Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Dec 2018 23:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams , 33566@debbugs.gnu.org Received: via spool by 33566-submit@debbugs.gnu.org id=B33566.15437058839055 (code B ref 33566); Sat, 01 Dec 2018 23:12:02 +0000 Received: (at 33566) by debbugs.gnu.org; 1 Dec 2018 23:11:23 +0000 Received: from localhost ([127.0.0.1]:57378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTEPz-0002Lz-7C for submit@debbugs.gnu.org; Sat, 01 Dec 2018 18:11:23 -0500 Received: from smtp-2.orcon.net.nz ([60.234.4.43]:47995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTEPw-0002Lq-IN for 33566@debbugs.gnu.org; Sat, 01 Dec 2018 18:11:21 -0500 Received: from [150.107.172.122] (port=7883 helo=[192.168.20.103]) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gTEPu-0005wy-Bx; Sun, 02 Dec 2018 12:11:18 +1300 References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> From: Phil Sainty Message-ID: <1df4e5f4-4410-d907-0fbb-82453e73f74b@orcon.net.nz> Date: Sun, 2 Dec 2018 12:11:18 +1300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This appears to be the same issue as bug #31309 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31309 At present in wid-edit.el we see: (define-widget 'group 'default [...] :format "%v" And that format of "%v" is triggering the error. In #31309 I noted that: > the parent `editable-field' widget says: > "Note: In an ‘editable-field’ widget, the ‘%v’ escape must be preceded > by some other text in the ‘:format’ string (if specified)." And so I copied the :format "%{%t%}: %v" used by the 'string type. If we make that same change here: (define-widget 'group 'default [...] :format "%{%t%}: %v" Then the example code from this new bug works. Possibly there are other such bugs here as well? 8 matches for ":format "%v"" in buffer: wid-edit.el 594: :type '(repeat (cons :format "%v" 597: (string :format "%v"))))) 1870: :format "%v" 2214: :format "%v" 2392: :format "%v" 2749: :format "%v" 2905: :format "%v" 3565: (cons :format "%v" -Phil From unknown Sun Jun 22 11:47:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33566: 26; `group' :type for defcustom Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Dec 2018 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phil Sainty , 33566@debbugs.gnu.org Received: via spool by 33566-submit@debbugs.gnu.org id=B33566.154371071017080 (code B ref 33566); Sun, 02 Dec 2018 00:32:01 +0000 Received: (at 33566) by debbugs.gnu.org; 2 Dec 2018 00:31:50 +0000 Received: from localhost ([127.0.0.1]:57399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTFfq-0004RQ-2k for submit@debbugs.gnu.org; Sat, 01 Dec 2018 19:31:50 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:39542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTFfo-0004R8-4M for 33566@debbugs.gnu.org; Sat, 01 Dec 2018 19:31:48 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB20U69d140772; Sun, 2 Dec 2018 00:31:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=gWfMqLNkbgT4EOd5DxgaXIYYdq/Cn83Ce6mfuzpl99s=; b=GhDvOE+WBATfHih/wMXQS/jHr+WVl3Wj3azkLkhobCxoIrVs5Ma9lQZWLdF+b5KydPnQ dzFUGMTJgozw7dd8LrEs2ozEQNkFjoqx05vvWVt1Gmfs81CrNraWaOHnX2LmwsEQDJqC VlyqUrGObaA08BAzSIa90/Fx2E/FWHKg26oQT+nmxyHRBNvKQ8oLU6rQFaXYX3vaeP4x qLhzfRsOBpl6CGQ0J+ixKou1/WphQPD38Y/Sctw7M9iAZDGl8H3EpDwg6DjgkhdZUEgR jF2BnHKanvvf+QEyugiqdUxS4tx9qawoZFBX5FhbXq1U05DkTsQJBKLz3YKya/JPnelg TQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2p3hqthtd6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 02 Dec 2018 00:31:41 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB20Ve6Q023604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 2 Dec 2018 00:31:40 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wB20VesW010893; Sun, 2 Dec 2018 00:31:40 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 1 Dec 2018 16:31:39 -0800 (PST) From: Drew Adams References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> <1df4e5f4-4410-d907-0fbb-82453e73f74b@orcon.net.nz> In-Reply-To: <1df4e5f4-4410-d907-0fbb-82453e73f74b@orcon.net.nz> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9094 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812020003 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > This appears to be the same issue as bug #31309 >=20 > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__debbugs.gnu.org_cgi_bugreport.cgi-3Fbug- > 3D31309&d=3DDwIDaQ&c=3DRoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=3DkI= 3P6l > jGv6CTHIKju0jqInF6AOwMCYRDQUmqX22rJ98&m=3Dq_aD3h6_uQ5XqacM7h8h0yyr4bJrYed > Kx_CcGGTUXRU&s=3DBlmxwvxgNdZTq6QqgdDRglwd0qa8LpG-SLOp13SLoV4&e=3D >=20 >=20 > At present in wid-edit.el we see: >=20 > (define-widget 'group 'default > [...] > :format "%v" >=20 > And that format of "%v" is triggering the error. >=20 > In #31309 I noted that: >=20 > > the parent `editable-field' widget says: > > "Note: In an =E2=80=98editable-field=E2=80=99 widget, the =E2=80=98%v= =E2=80=99 escape must be > preceded > > by some other text in the =E2=80=98:format=E2=80=99 string (if specifie= d)." >=20 > And so I copied the :format "%{%t%}: %v" used by the 'string type. >=20 > If we make that same change here: >=20 > (define-widget 'group 'default > [...] > :format "%{%t%}: %v" >=20 > Then the example code from this new bug works. >=20 >=20 > Possibly there are other such bugs here as well? >=20 > 8 matches for ":format "%v"" in buffer: wid-edit.el > 594: :type '(repeat (cons :format "%v" > 597:=09=09=09 (string :format "%v"))))) > 1870: :format "%v" > 2214: :format "%v" > 2392: :format "%v" > 2749: :format "%v" > 2905: :format "%v" > 3565:=09=09=09=09(cons :format "%v" Great. Good catch and follow-up. A couple things: This (e.g. the recipe in bug #33566) has apparently been broken since at le= ast Emacs 20. But in Emacs 20 the message in *Messages* is just "Bad forma= t". But :group is supposed to not show any :tag. So I think this is what we sh= ould use: (define-widget 'group 'default "A widget which groups other widgets inside." :convert-widget 'widget-types-convert-widget :copy 'widget-types-copy :format ":\n%v" ; <=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D :value-create 'widget-group-value-create :value-get 'widget-editable-list-value-get :default-get 'widget-group-default-get :validate 'widget-children-validate :match 'widget-group-match :match-inline 'widget-group-match-inline) There doesn't seem to be any way to eliminate the `:' altogether, though. I think the doc needs to be corrected in (widget) Editable Text Fields. Th= is is not correct/sufficient; *Warning:* In an =E2=80=98editable-field=E2=80=99 widget, the =E2=80=98%v= =E2=80=99 escape must be preceded by some other text in the =E2=80=98:format=E2=80=99 string (if specified). It's not sufficient that just any old text precede the `%v'. There must be a colon, AFAICT. It should instead say something like this: *Warning:* In an =E2=80=98editable-field=E2=80=99 widget, the =E2=80=98%v= =E2=80=99 escape must be preceded by a colon (`:') in the =E2=80=98:format=E2=80=99 string (if specified). No tag name need precede the colon, but the colon must be present. (Additional text can follow the colon and precede the =E2=80=98%v=E2=80=99.) (Perhaps more testing or checking of just what can precede the %v needs to be done.) I'd also drop the "*Warning:*", personally, and instead say that this is necessary or you get a bad format message (or some such). From unknown Sun Jun 22 11:47:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> In-Reply-To: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Dec 2018 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phil Sainty , 33566@debbugs.gnu.org Received: via spool by 33566-submit@debbugs.gnu.org id=B33566.154387019129487 (code B ref 33566); Mon, 03 Dec 2018 20:50:02 +0000 Received: (at 33566) by debbugs.gnu.org; 3 Dec 2018 20:49:51 +0000 Received: from localhost ([127.0.0.1]:59508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTvA7-0007fX-BO for submit@debbugs.gnu.org; Mon, 03 Dec 2018 15:49:51 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:57234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTvA4-0007fF-BG for 33566@debbugs.gnu.org; Mon, 03 Dec 2018 15:49:50 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB3KiRue115094; Mon, 3 Dec 2018 20:49:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ANxIzYBdF5HOnxNoG53bdRxgXGksSPA+pY9/rSL4xhc=; b=3cU65BqvybH6MhsFQ/Jxg6aC9kP6mpYCqK7/eD+fadC46L5y3QuTgCoNmwGO/Hkqw6m0 IR/Rr5bCSFMhfN4U01zad+SftBJkOK1ob1AYkg0R2MBx65ciZiCGv4KtRlaOpHcvIA+D +BdQEH0ejWQimlVjQSZElfCY4+C+LB5gtp7Dj+W83dev/jUO4aHMJtUjttpWG50YTYir BCVylSfxxIaOj3pcjRoNBDBK5DpV0UT9fc+huqfyUqJOU2kTmAjEo1CKzTZTGD8xPl8M 4F/k/SlB76H9rnjvqLn+cbHQmrvsOWmm/itwz0uNbQAv2Bbt3W09wH7igvsG5EU7GBX5 kA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2p3jxr8p4r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Dec 2018 20:49:41 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB3KnfEx026557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Dec 2018 20:49:41 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB3KneQC015968; Mon, 3 Dec 2018 20:49:40 GMT MIME-Version: 1.0 Message-ID: <64ef54b7-8773-480c-943f-fcde67233332@default> Date: Mon, 3 Dec 2018 12:49:39 -0800 (PST) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9096 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=822 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030189 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I think the patch below fixes the code bug. Someone else can consider fixing the doc bug: > I think the doc needs to be corrected in (widget) > Editable Text Fields. This is not correct/sufficient; >=20 > *Warning:* In an =E2=80=98editable-field=E2=80=99 widget, the =E2=80=98= %v=E2=80=99 > escape must be preceded by some other text in the > =E2=80=98:format=E2=80=99 string (if specified). >=20 > It's not sufficient that just any old text precede > the `%v'. There must be a colon, AFAICT. >=20 > It should instead say something like this: >=20 > *Warning:* In an =E2=80=98editable-field=E2=80=99 widget, the `%v' > escape must be preceded by a colon (`:') in the > `:format' string (if specified). No tag name need > precede the colon, but the colon must be present. > (Additional text can follow the colon and precede > the `%v'.) ... > I'd also drop the "*Warning:*", personally, and > instead say that this is necessary or you get a > bad format message (or some such). --- diff -u wid-edit.el wid-edit-2018-12-03a-patched.el --- wid-edit.el=092018-12-03 12:37:30.626331700 -0800 +++ wid-edit-2018-12-03a-patched.el=092018-12-03 12:43:05.440329000 -0800 @@ -2746,7 +2746,7 @@ "A widget which groups other widgets inside." :convert-widget 'widget-types-convert-widget :copy 'widget-types-copy - :format "%v" + :format ":\n%v" :value-create 'widget-group-value-create :value-get 'widget-editable-list-value-get :default-get 'widget-group-default-get From unknown Sun Jun 22 11:47:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 23:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phil Sainty , 33566@debbugs.gnu.org Received: via spool by 33566-submit@debbugs.gnu.org id=B33566.154552175028687 (code B ref 33566); Sat, 22 Dec 2018 23:36:01 +0000 Received: (at 33566) by debbugs.gnu.org; 22 Dec 2018 23:35:50 +0000 Received: from localhost ([127.0.0.1]:60314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaqoA-0007Sd-In for submit@debbugs.gnu.org; Sat, 22 Dec 2018 18:35:50 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:54296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaqo8-0007SO-Sy for 33566@debbugs.gnu.org; Sat, 22 Dec 2018 18:35:49 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wBMNYt4k111606; Sat, 22 Dec 2018 23:35:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=GmQIjnlAr7BnvYCO6vGYMRukaSkUghI31gC/rUELAVQ=; b=C/qdS4gXWv38YqpvGbYimxQPXEVcqq5J8Pk3y5erptJRvDAh9pUcNza5hRVXGY/EgFs6 4jYHP+wxROd+7Q9XaWlweuj0bu7DNBpKfrykfYq48jOvFLkRafcKltXtQcutNev0bCpT uGxp4UxeujKuIgKClmslj76pmqFEnS7dGyIEnEO7RRgOJyVza6r43YNBy09+cZctLDMM ljtdZBXvJYDQuMb/Qtel7s+nG4paaasW+zbzRlu7gKprBnUMlLu0a/HzBHoPCpr3YFbM +LARh8pPHhAzHjSpt+jH9wl8axQm15D80Vbs7Gse6T9XyMjnAAM9fjrkaKl/cajOMtAY xQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2phdwqhd5u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Dec 2018 23:35:42 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wBMNZfO6010618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Dec 2018 23:35:41 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wBMNZfrf017351; Sat, 22 Dec 2018 23:35:41 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 22 Dec 2018 15:35:40 -0800 (PST) From: Drew Adams References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> <64ef54b7-8773-480c-943f-fcde67233332@default> In-Reply-To: <64ef54b7-8773-480c-943f-fcde67233332@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4783.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9115 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=849 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812220214 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ping. Could someone please consider committing this patch. Thx. > I think the patch below fixes the code bug. > diff -u wid-edit.el wid-edit-2018-12-03a-patched.el > --- wid-edit.el=092018-12-03 12:37:30.626331700 -0800 > +++ wid-edit-2018-12-03a-patched.el=092018-12-03 12:43:05.440329000 -0800 > @@ -2746,7 +2746,7 @@ > "A widget which groups other widgets inside." > :convert-widget 'widget-types-convert-widget > :copy 'widget-types-copy > - :format "%v" > + :format ":\n%v" > :value-create 'widget-group-value-create > :value-get 'widget-editable-list-value-get > :default-get 'widget-group-default-get From unknown Sun Jun 22 11:47:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Drew Adams Subject: bug#33566: closed (Re: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom) Message-ID: References: <83k1js69oc.fsf@gnu.org> <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> X-Gnu-PR-Message: they-closed 33566 X-Gnu-PR-Package: emacs Reply-To: 33566@debbugs.gnu.org Date: Sat, 29 Dec 2018 08:05:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1546070703-22220-1" This is a multi-part message in MIME format... ------------=_1546070703-22220-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33566: 26; `group' :type for defcustom which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33566@debbugs.gnu.org. --=20 33566: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33566 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1546070703-22220-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33566-done) by debbugs.gnu.org; 29 Dec 2018 08:04:52 +0000 Received: from localhost ([127.0.0.1]:40804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gd9c3-0005lv-OJ for submit@debbugs.gnu.org; Sat, 29 Dec 2018 03:04:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gd9c0-0005lf-IJ for 33566-done@debbugs.gnu.org; Sat, 29 Dec 2018 03:04:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gd9bq-0000W3-ET for 33566-done@debbugs.gnu.org; Sat, 29 Dec 2018 03:04:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gd9bq-0000Vf-BL; Sat, 29 Dec 2018 03:04:38 -0500 Received: from [176.228.60.248] (port=2375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gd9bp-0000Of-VB; Sat, 29 Dec 2018 03:04:38 -0500 Date: Sat, 29 Dec 2018 10:04:19 +0200 Message-Id: <83k1js69oc.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: (message from Drew Adams on Sat, 22 Dec 2018 15:35:40 -0800 (PST)) Subject: Re: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> <64ef54b7-8773-480c-943f-fcde67233332@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33566-done Cc: psainty@orcon.net.nz, 33566-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sat, 22 Dec 2018 15:35:40 -0800 (PST) > From: Drew Adams > > ping. Could someone please consider committing > this patch. Thx. Sorry for the delay. Installed on the emacs-26 branch. ------------=_1546070703-22220-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Dec 2018 20:45:14 +0000 Received: from localhost ([127.0.0.1]:57312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTC8X-00059w-Gf for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTC8V-00052m-Fu for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTC8P-0006gi-FL for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTC8P-0006gc-Cn for submit@debbugs.gnu.org; Sat, 01 Dec 2018 15:45:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTC8O-00063u-Du for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2018 15:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTC8L-0006dn-9K for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2018 15:45:04 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:48230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTC8L-0006cF-0F for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2018 15:45:01 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB1KiweL007605 for ; Sat, 1 Dec 2018 20:44:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=cVMAv6p+ytNOzPSoKx1TnSYzT1aBAnmvzfGYxtjKjMI=; b=wF21P3EVIdfbMaS/pb43oDRJMX/2mEAB+1ZNH9lBAcz1r3ZDjpX0emQc9z0QOTdCP+0F AXUEK7DeD5GShOrD3JXHg/B13m5DJmcQLtlUEXwIiqXKmVg3D/tyoSFb9jgi3ym2MRAJ 6DlaGWrlESSYwN/cetHtTiajCkoUUkrmkoy34guRYBVt507ZTOfipSYpYkvnCi41GuY/ G4tZ1EJEM/u7TwMCIMtJzrG0D0ihk74TlITqe5daMO+bE9IdY6d7lqk0wFOHXHEgN/M9 MX2wDT05uAgOPRn4+KGuac97Poei0QCdf43p+plPYDKtVqaV2j1M1q9kIIQgkWgM9H3X 2A== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2p3hqthg0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 01 Dec 2018 20:44:58 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB1Kivo1020750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 1 Dec 2018 20:44:57 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB1KivJd019121 for ; Sat, 1 Dec 2018 20:44:57 GMT MIME-Version: 1.0 Message-ID: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> Date: Sat, 1 Dec 2018 12:44:56 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26; `group' :type for defcustom X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9094 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812010192 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) It seems like defcustom composite :type `group' does not work. See https://emacs.stackexchange.com/q/46357/105. emacs -Q (defcustom foo '(1 2 3) "..." :type '(group integer integer integer) :group 'emacs) M-x customize-option foo Shows this message in *Messages*: custom-variable-value-create: Bad format And buffer *Customize Option: Foo* is not complete. I see only this: ------------8<---------------- Custom settings cannot be saved; maybe you started Emacs with '-q'. For help using this buffer, see Easy Customization in the Emacs manual. Search=20 Operate on all settings in this buffer: Revert... Apply =20 Hide=20 ------------8<---------------- The doc says that :type `group' should be very similar to :type `list', but without tags. See also this bug: https://lists.gnu.org/archive/html/emacs-pretest-bug/2007-06/msg00067.html In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.16299 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' ------------=_1546070703-22220-1--