Subject: bug#33565: closed (Re: [bug#33565] [PATCH] gnu: Add python-xmltodict.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 05 Dec 2018 00:46:03 +0000

Your bug report

#33565: [PATCH] gnu: Add python-xmltodict.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
33565: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33565
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#33565] [PATCH] gnu: Add python-xmltodict.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked] (Ludovic Courtès)
Cc: [email-masked], [email-masked]
Date: Wed, 05 Dec 2018 03:45:25 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

[email-masked] (Ludovic Courtès) writes:

> Oleg Pykhalov <[email-masked]> skribis:
>
>> [email-masked] (Ludovic Courtès) writes:
>>
>>> Oleg Pykhalov <[email-masked]> skribis:
>>>
>>>> * gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.
>>>
>>> [...]
>>>
>>>> +    (home-page "https://github.com/martinblech/xmltodict")
>>>> +    (synopsis "Work with XML like you are working with JSON")
>>>> +    (description "This package provides a Python library to work with XML like
>>>> +you are working with JSON")
>>>
>>> Could you expound a bit on what this means (I’m curious!) and add a
>>> period?
>>
>> It's a quote from the home page. :-) But in reality this Python library
>> converts input string which contains XML to an OrderedDict object which
>> looks like a JSON.  Queries for data inside OrderedDict feels (I guess)
>> like you're working with JSON.  Maybe we should change a description to
>> “This package provides a Python library to convert XML to OrderedDict.”,
>
> @code{OrderedDict} even.  :-)
>
> LGTM with this change, thank you!

Pushed as 79a0eabd2a8765c294b3e2decf71a27cd1dd219d

Thanks,
Oleg.

Subject: [PATCH] gnu: Add python-xmltodict.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked]
Cc: Oleg Pykhalov <[email-masked]>
Date: Sat, 1 Dec 2018 23:18:32 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.
---
 gnu/packages/xml.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 347ac878a3..1bb6ba48aa 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -39,6 +39,7 @@
 (define-module (gnu packages xml)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages gnupg)
@@ -2133,3 +2134,27 @@ It converts the procedure call into an XML document, sends it to a remote
 server using HTTP, and gets back the response as XML.  This library provides a
 modular implementation of XML-RPC for C and C++.")
     (license (list license:psfl license:expat))))
+
+(define-public python-xmltodict
+  (package
+    (name "python-xmltodict")
+    (version "0.11.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "xmltodict" version))
+        (sha256
+          (base32
+            "1pxh4yjhvmxi1h6f92skv41g4kbsws3ams57150kzn18m907v3cg"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-nose" ,python-nose)))
+    (home-page "https://github.com/martinblech/xmltodict")
+    (synopsis "Work with XML like you are working with JSON")
+    (description "This package provides a Python library to work with XML like
+you are working with JSON")
+    (license license:expat)))
+
+(define-public python2-xmltodict
+  (package-with-python2 python-xmltodict))
-- 
2.19.1