GNU bug report logs - #33544
gzip 1.9 alignment compile failure on cast

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Adler, Mark" <madler <at> alumni.caltech.edu>
Subject: bug#33544: closed (Re: bug#33544: gzip 1.9 alignment compile
 failure on cast)
Date: Sat, 01 Dec 2018 00:28:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#33544: gzip 1.9 alignment compile failure on cast

which was filed against the gzip package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 33544 <at> debbugs.gnu.org.

-- 
33544: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33544
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: "Adler, Mark" <madler <at> alumni.caltech.edu>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>, 33544-done <at> debbugs.gnu.org
Subject: Re: bug#33544: gzip 1.9 alignment compile failure on cast
Date: Fri, 30 Nov 2018 16:27:23 -0800

[Message part 3 (text/plain, inline)]

Thanks, I installed the attached patch into Gnulib.

[0001-memrchr-port-better-to-clang.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: "Adler, Mark" <madler <at> alumni.caltech.edu>
To: "bug-gzip <at> gnu.org" <bug-gzip <at> gnu.org>
Subject: gzip 1.9 alignment compile failure on cast
Date: Wed, 28 Nov 2018 19:22:56 +0000

Compiling gzip 1.9 on macOS 10.13.6 using Xcode 10.1 with clang (Apple LLVM version 10.0.0 (clang-1000.11.45.5)), I get this error after ./configure and make:

memrchr.c:71:18: error: cast from 'const unsigned char *' to 'const longword *'
      (aka 'const unsigned long *') increases required alignment from 1 to 8
      [-Werror,-Wcast-align]
  longword_ptr = (const longword *) char_ptr;

I resolved it with this patch:

@@ -68,7 +68,7 @@ __memrchr (void const *s, int c_in, size_t n)
     if (*--char_ptr == c)
       return (void *) char_ptr;
 
-  longword_ptr = (const longword *) char_ptr;
+  longword_ptr = (const void *) char_ptr;
 
   /* All these elucidatory comments refer to 4-byte longwords,
      but the theory applies equally well to any size longwords.  */

Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.