Subject: Re: [bug#33526] Utilities for emacs-irony-mode

From: [email-masked] (Ludovic Courtès)
Date: Thu, 29 Nov 2018 09:48:20 +0100

Hello,

Tim Gesthuizen <[email-masked]> skribis:

> From be0733336aaf0047f92eaccb6cb360c86f941298 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <[email-masked]>
> Date: Tue, 27 Nov 2018 17:56:33 +0100
> Subject: [PATCH 1/4] gnu: Add emacs-company-irony.
>
> * gnu/packages/emacs.scm (emacs-company-irony): New variable.

I fixed the tiny issues reported by ‘guix lint’, made the description a
full sentence (info "(guix) Synopses and Descriptions"), and committed.

> From bf04fa3e0892bd9461feb5bebb7454f478710282 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <[email-masked]>
> Date: Tue, 27 Nov 2018 17:57:14 +0100
> Subject: [PATCH 2/4] gnu: Add emacs-flycheck-irony.
>
> * gnu/packages/emacs.scm (emacs-flycheck-irony): New variable.

[...]

> +	      (method git-fetch)
> +	      (uri (git-reference
> +		    (url "https://github.com/Sarcasm/flycheck-irony.git")
> +		    (commit version)))

The tag should be “v1.0.0”, not “1.0.0”, but then the hash is different
than the one here.

Also, ‘guix lint’ reports the same kind of issues as above.

Could you double-check and adjust the Git references and address the
issues that ‘guix lint’ reports in the remaining patches?

Thank you!

Ludo’.