From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Nov 2018 16:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33524@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154333664330135 (code B ref -1); Tue, 27 Nov 2018 16:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Nov 2018 16:37:23 +0000 Received: from localhost ([127.0.0.1]:52457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRgMV-0007pz-Ev for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRgMT-0007pi-F9 for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRgMM-0004lT-VJ for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRgMM-0004lK-SM for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRgML-0001qD-FJ for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 11:37:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRgMJ-0004iK-5e for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 11:37:12 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:37091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRgMI-0004g2-Uv for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 11:37:11 -0500 Received: by mail-wm1-x332.google.com with SMTP id g67so9442636wmd.2 for ; Tue, 27 Nov 2018 08:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8vbRp3UAlUtFpG4Z/ATa+EGPDmM+CLTh7FifnTGyU6w=; b=eQqTfxdDBkxAeXj13nX/qCTTIyi/JxBOUihb9ZP9izAvkzHwYPT86Mca9IzkpvRFKu +GPautI4eeQ/crZQffJLbr7zJFmOI6x2K5OfwWRGaGCGWEPpRKkjhqqQjPwb73ljghrf Z55AJOotgRlrwqJPSFM101yyz6v6VQsZ2qHtACDkg0kpPUAPOVt/wjQ3Z9QerVh/CVWP GVQUtSEmgN96yuG0F4jrk+Ig/Da8lhzrsrLH/WnaxoyXRAteU9e5Sa0soR9S4Dzv27Tl IW/nA4mtyVumpDrsMwT3LbUDUZaQZNqCqNyD1t24Iwo+dvOjPm9tkbiumBrN2Uovsmmg +2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8vbRp3UAlUtFpG4Z/ATa+EGPDmM+CLTh7FifnTGyU6w=; b=ersbEKO/IpA0KnDpH939fEFM10YRAQmm6KrUhoCuiDlAf2JsDNfMNfKF2rcfiJaY/g AHkQy5TPRMetLVtILxQv9r/TEQ5pMhxFu4Lja9qarmwAd7gYgawvsofQIyUfyhcPl34d Obazev/euhvluyDC1CFVc74ZNiDmjNFCAAdKay0w1q15k7mfbYh32jyaHLbXdREk8TP6 /4Nbe1laOjQzKiRj3TIep6sKBmyy18WRv2W+Ip+kqAoAcWqDL8NTdO41jmPeX9mqP6bX J7HiMB+HdEsLw1NI+YeyGx0+iTDB4tiuad4pzaeuxzoReH1QIpa2HXmpanX9EiU+2P6+ ajfg== X-Gm-Message-State: AA+aEWayud8r9KLDHxQvfCYOt7aN+cOu0AGT6nD/ec3Xmur4j19GZx72 Y1g+W2ye7ctpF8lUdgeSW4pc8dle X-Google-Smtp-Source: AFSGD/UZsatK4j2ns1JjnYAdZN0+3Di+9Els1rFhQLCYx8+O6PG6mKkC00Bvzl/fDsHaGmNTXZk85Q== X-Received: by 2002:a1c:1b8d:: with SMTP id b135mr17845193wmb.24.1543336629100; Tue, 27 Nov 2018 08:37:09 -0800 (PST) Received: from a.muc.corp.google.com ([2a00:79e0:15:10:cd99:29f5:6da:65fc]) by smtp.gmail.com with ESMTPSA id l15sm4445808wrw.4.2018.11.27.08.37.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 08:37:08 -0800 (PST) From: Philipp Stephani Date: Tue, 27 Nov 2018 17:37:05 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) I've noticed that the temporary directory code in flymake-proc has issues with remote filenames. For example: $ emacs -Q -batch -l flymake-proc --eval=3D'(print (flymake-proc-create-tem= p-with-folder-structure "/:/dir" nil))' "/tmp/:/dir" Clearly that's not what was intended. Rather, this should create the directory structure on the remote machine. If we use that filename: mkdir -p /tmp/:/dir then stuff will generally work, but trying to remove it will cause an endless loop and try to remove /dir and /: $ emacs -Q -batch -l flymake-proc --eval=3D'(flymake-proc--delete-temp-dire= ctory "/tmp/:/dir")' Error [flymake-proc *scratch*]: Failed to delete dir /dir, error ignored Error [flymake-proc *scratch*]: Failed to delete dir /, error ignored Error [flymake-proc *scratch*]: Failed to delete dir /, error ignored [...infinite loop...] ^C lisp.h:1485: Emacs fatal error: assertion failed: 0 <=3D nchars Aborted The assertion failure seems to be a different issue, but this bug focuses on the problematic behavior of flymake-proc. The code for these functions looks really suspicious and seems to make lots of incorrect assumptions (about whether temporary-file-directory ends in a slash, that all files are local, etc.). Especially the infinite loop in flymake-proc--delete-temp-directory causes trouble because the only way out of it is sending a signal to the Emacs process. In GNU Emacs 27.0.50 (build 46, x86_64-pc-linux-gnu, GTK+ Version 3.22.24) of 2018-11-27 Repository revision: e02d375cb6670e2306b9c67d7f6fd2dd1d1b2711 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux buster/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Eager macro-expansion failure: (wrong-number-of-arguments (2 . 2) 4) Configured using: 'configure --without-threads --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES JSON GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst pcase ffap thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 109009 5313) (symbols 48 21762 1) (strings 32 32871 2004) (string-bytes 1 894311) (vectors 16 16454) (vector-slots 8 533506 11914) (floats 8 52 65) (intervals 56 230 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Nov 2018 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Stephani Cc: 33524@debbugs.gnu.org Received: via spool by 33524-submit@debbugs.gnu.org id=B33524.15433955217551 (code B ref 33524); Wed, 28 Nov 2018 08:59:02 +0000 Received: (at 33524) by debbugs.gnu.org; 28 Nov 2018 08:58:41 +0000 Received: from localhost ([127.0.0.1]:52833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRvg8-0001xj-SN for submit@debbugs.gnu.org; Wed, 28 Nov 2018 03:58:41 -0500 Received: from mout.gmx.net ([212.227.15.15]:50639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRvg6-0001xW-Oa for 33524@debbugs.gnu.org; Wed, 28 Nov 2018 03:58:39 -0500 Received: from detlef.gmx.de ([212.86.41.67]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MJBEo-1gPAmo0Odu-002mKe; Wed, 28 Nov 2018 09:58:32 +0100 From: Michael Albinus References: Date: Wed, 28 Nov 2018 09:58:31 +0100 In-Reply-To: (Philipp Stephani's message of "Tue, 27 Nov 2018 17:37:05 +0100") Message-ID: <874lc18too.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:2dt4KtWktPc1l7U7a2uTOAGT+4yZNMTa6+4uOqOm6BzWbIj5Oio WBxi8UbBQy1/cZsWcBAoRcXiD46LfquR7n9LNi7uk0v/hgKpvLHc5JFP0dAt6nvXwuJhyvr GkfJcYNZXhegfSc4dVjTs0jnlAhEk7Fq4f51LJXF38M059ZvILCtwA6u95hmZ2ptashHca4 11dyMIRr/XP7U96YNDQIg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:NOV9EvZ/l5I=:7Hha01jKrt074ezpLfrY6c IoTQyh7HILua40Rx9cEW4YMzrALI5cSEHZVGYREJy3WXKqKGnc68eTQRa4XeO+yLGyiocWhH7 5sXGw5TBGi0CuHnku4UJcgoYk2XzMsUGD+znAiowq8qp7TX6S7TnDDbS5hZCxZo4teNWPa6if Ob4Gk4Qikfcy+Y/ggHmTP/xdN44m/mMIq2VXS1jcYRzNlWViCkuxjjdwjkp9HvpkPQaKxT8HH ybJiZPyWDdt6zDKknf5N/DT0VkDUBS3vB9i8qwSVww/B2YfOve66Yb2E4PgBcAjM3zT/3/4XX 5gONI+0ahO5IYeeR560c459V6sRYzvod3/2AUe+SQEvi98CJ6t1S9Lbf8k/g6gJ7HXiDizC9V jglqWnq3vjJJZnHqRvK04CRrBAoLm96xtzYrPLkPARk7R6lXqVrLuZb70CEW9fxrocp6ok2RX SHpXUmzw0Jq0z0fgKJeaniu/dPNY9fXQMIypipTEv8YD95H6kSCcKAACZqXGk1JyfHa3SXmAy y7I6BfJIdZwtSb/3P1slGNqOfRKbtb0+LIOaQy9xtSA9P2TlILZi3fHpWmU1QqyVch9BERvd3 /Q/6NaBN8+FuK4AAG3X8HBE/sh1IyV+KxSeiZeeTFZw5Q6+pymC7kh0xen4bOsKtzFzGxMOaB kp0ngYq+NbxbbuH+1PlvAR9iFCloMCTPMi/1sG3dQud/J8JwVpa1kYVPiGGbTgtIHpG8bO01e U+W2X2KEyuU7CkAymazPHiHFd7x3aiPfDtjNV6ZBlUi4SlQ3cvDMHpr4aCnmT2IYC8HmMpXpE TzOmWeqfkTdJlXMaFIUKApW1OupGhuqMhAOjHD1I7hJKr/bBABTUd9J3Emycy+YKW/UdHiLuU Z/mKiSPAWFWEBAh/fhQ1lvGT2TfKp1wJyXJPrzQekfYTEnYSqH55CJcijgHYn8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: Hi Phillipp, > I've noticed that the temporary directory code in flymake-proc has > issues with remote filenames. For example: > > $ emacs -Q -batch -l flymake-proc --eval='(print (flymake-proc-create-temp-with-folder-structure "/:/dir" nil))' > > "/tmp/:/dir" > > Clearly that's not what was intended. Rather, this should create the > directory structure on the remote machine. I don't understand. "/:/dir" is not a remote file name, it is a quoted file name. See (info "(emacs) Quoted File Names") for a description. Could you pls explain what you want to achieve? This would help to understand your problem. Best regards, Michael. From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Nov 2018 09:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 33524@debbugs.gnu.org Received: via spool by 33524-submit@debbugs.gnu.org id=B33524.15434849425886 (code B ref 33524); Thu, 29 Nov 2018 09:50:01 +0000 Received: (at 33524) by debbugs.gnu.org; 29 Nov 2018 09:49:02 +0000 Received: from localhost ([127.0.0.1]:54113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSIwP-0001Wf-NW for submit@debbugs.gnu.org; Thu, 29 Nov 2018 04:49:02 -0500 Received: from mail-ot1-f54.google.com ([209.85.210.54]:35489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSIwN-0001WN-P9 for 33524@debbugs.gnu.org; Thu, 29 Nov 2018 04:49:00 -0500 Received: by mail-ot1-f54.google.com with SMTP id 81so1194260otj.2 for <33524@debbugs.gnu.org>; Thu, 29 Nov 2018 01:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lYGnwiS9jAA75tcTU8JrmbBBsW/gIRsbtPKQ8h/bFSY=; b=m4lfFHMiXUHGtiirVzRbTjk9tJhR3xb1M30n+M8HEljl6mdEo3sSdISYRRSz3NenLD ADfEV0Zlxzzepxn6IWRmJ4lEibnOL+JTwW6V0qnyj9W7wBkcOnV+fFDSbaQdcveWfgok uAQsiiA+BvfBXUhUCabZdtmxqZRV85vI9/MdopPphzKF4XPdxWuLt1au1oCHysvgPjux tDZYq4hjhSrYPZbbCiozrB5FVzFLMaKiXshN1sjTLS+EH69oBib0nhMI1903x6Dp9aeb VAw8BOzguiDrt+v3t/TmlrjqkMh9hhO+t9sOTMbh/VzYjcKxWkLvF3Bs8JqQvbNxKob2 Puqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lYGnwiS9jAA75tcTU8JrmbBBsW/gIRsbtPKQ8h/bFSY=; b=HhwaRBMkzSnGXhR+/YdHJE58zZenEEpTXzQYtRHo/ot9pHv62VHY6PMj4WkgXdI9T6 eE/mGBYSrd+cg6eCnNOBV12/qmPK3QRxEas0TUPGISDU+ZqitIaJGtCHKV9nl20Swury Th+4I2EMctzHGs3iPInPfmQZshWMPKAkgJi5Axdai/l9Jdt37btZWtBHamUSXq2g+cQB Zjf4MCnO2TiQkPRCflZU5pKl4Gleu64cOMu9rtM9GQASobTYIvD1Mo9kY8AifySp/jA6 vq2CoLkET+LEYuVCkF/DFEyqZQMWaDjiSMUGyH6X4klQmlv7SbuCei7Mdg4/DgRMg93U aZpg== X-Gm-Message-State: AA+aEWbB4E1iOBuVnT9t7lYWTNzM5XbM7v7OCo1LKcdElsoqFND8gGb1 BwwWoBcYIEY9BO0IoL6sM4+o2F9VBvmA3VK5T5E= X-Google-Smtp-Source: AFSGD/Val8Tpe3pHgfUqVgZ7PBOC3U2rRDsi6YkOYtqONFO50nx+QlkO96QxwVsRo0epd+aeAgSEkONv+PN0fr+JoUE= X-Received: by 2002:a9d:60cf:: with SMTP id b15mr459876otk.144.1543484933352; Thu, 29 Nov 2018 01:48:53 -0800 (PST) MIME-Version: 1.0 References: <874lc18too.fsf@gmx.de> In-Reply-To: <874lc18too.fsf@gmx.de> From: Philipp Stephani Date: Thu, 29 Nov 2018 10:48:42 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000002b2fba057bca9718" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000002b2fba057bca9718 Content-Type: text/plain; charset="UTF-8" Am Mi., 28. Nov. 2018 um 09:58 Uhr schrieb Michael Albinus < michael.albinus@gmx.de>: > Philipp Stephani writes: > > Hi Phillipp, > > > I've noticed that the temporary directory code in flymake-proc has > > issues with remote filenames. For example: > > > > $ emacs -Q -batch -l flymake-proc --eval='(print > (flymake-proc-create-temp-with-folder-structure "/:/dir" nil))' > > > > "/tmp/:/dir" > > > > Clearly that's not what was intended. Rather, this should create the > > directory structure on the remote machine. > > I don't understand. "/:/dir" is not a remote file name, it is a quoted > file name. See (info "(emacs) Quoted File Names") for a description. > > Could you pls explain what you want to achieve? This would help to > understand your problem. > > Sorry for being imprecise. Yes, I mean quoted filenames. (It's possible that the issue also arises for true remote filenames, but I haven't checked.) You can easily reproduce user-facing problems. Assuming you have some binary installed that would check Java files using the legacy backend: $ touch /tmp/{a,b}.java $ emacs -Q -eval '(progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff "/:/tmp/a.java" "/:/tmp/b.java"))' And Emacs immediately hangs because it runs into the endless loop. Stacktrace in this case is Debugger entered--Lisp error: (quit) display-warning((flymake flymake-proc) "Failed to delete dir /, error ignored" :error "*Flymake log*") flymake--log-1(1 flymake-proc "Failed to delete dir %s, error ignored" "/") flymake-proc--safe-delete-directory("/") flymake-proc--delete-temp-directory("/tmp/:/tmp/") flymake-proc-simple-java-cleanup() #f(compiled-function () #)() flymake-proc-legacy-flymake(#f(compiled-function (&rest args) #)) flymake--run-backend(flymake-proc-legacy-flymake) #f(compiled-function (backend) #)(flymake-proc-legacy-flymake) run-hook-wrapped(#f(compiled-function (backend) #) flymake-proc-legacy-flymake) flymake-start((post-command) nil) #f(compiled-function () #)() set-window-buffer(nil #) switch-to-buffer(#) ediff-setup-windows-multiframe-compare(# # nil #) ediff-setup-windows-multiframe(# # nil #) ediff-setup-windows-default(# # nil #) ediff-setup-windows(# # nil #) ediff-setup(# "/:/tmp/a.java" # "/:/tmp/b.java" nil nil nil ((ediff-job-name . ediff-files)) nil) ediff-files-internal("/:/tmp/a.java" "/:/tmp/b.java" nil nil ediff-files) ediff("/:/tmp/a.java" "/:/tmp/b.java") (progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff "/:/tmp/a.java" "/:/tmp/b.java")) eval((progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff "/:/tmp/a.java" "/:/tmp/b.java"))) command-line-1(("-f" "toggle-debug-on-quit" "-eval" "(progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff \"/:/tmp/a.java\" \"/:/tmp/b.java\"))")) command-line() normal-top-level() --0000000000002b2fba057bca9718 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Am Mi., 28. Nov. 2018 um 09:58= =C2=A0Uhr schrieb Michael Albinus <michael.albinus@gmx.de>:
Philipp Stephani <p.stephani2@gmail.com> writes:

Hi Phillipp,

> I've noticed that the temporary directory code in flymake-proc has=
> issues with remote filenames.=C2=A0 For example:
>
> $ emacs -Q -batch -l flymake-proc --eval=3D'(print (flymake-proc-c= reate-temp-with-folder-structure "/:/dir" nil))'
>
> "/tmp/:/dir"
>
> Clearly that's not what was intended.=C2=A0 Rather, this should cr= eate the
> directory structure on the remote machine.

I don't understand. "/:/dir" is not a remote file name, it is= a quoted
file name. See (info "(emacs) Quoted File Names") for a descripti= on.

Could you pls explain what you want to achieve? This would help to
understand your problem.


Sorry for being imprecise. Yes, I mean= quoted filenames. (It's possible that the issue also arises for true r= emote filenames, but I haven't checked.)
You can easily repro= duce user-facing problems. Assuming you have some binary installed that wou= ld check Java files using the legacy backend:

$ to= uch /tmp/{a,b}.java
$=C2=A0emacs -Q -eval '(progn (add-ho= ok (quote prog-mode-hook) (quote flymake-mode)) (ediff "/:/tmp/a.java&= quot; "/:/tmp/b.java"))'

And Emacs i= mmediately hangs because it runs into the endless loop. Stacktrace in this = case is

Debugger entered--Lisp error: (quit)<= /div>
=C2=A0 display-warning((flymake flymake-proc) "Failed to del= ete dir /, error ignored" :error "*Flymake log*")
= =C2=A0 flymake--log-1(1 flymake-proc "Failed to delete dir %s, error i= gnored" "/")
=C2=A0 flymake-proc--safe-delete-dire= ctory("/")
=C2=A0 flymake-proc--delete-temp-directory(&= quot;/tmp/:/tmp/")
=C2=A0 flymake-proc-simple-java-cleanup()=
=C2=A0 #f(compiled-function () #<bytecode 0x11a4ea9>)()
=C2=A0 flymake-proc-legacy-flymake(#f(compiled-function (&rest = args) #<bytecode 0x11a4e51>))
=C2=A0 flymake--run-backend(f= lymake-proc-legacy-flymake)
=C2=A0 #f(compiled-function (backend)= #<bytecode 0x117b195>)(flymake-proc-legacy-flymake)
=C2=A0= run-hook-wrapped(#f(compiled-function (backend) #<bytecode 0x117b195>= ;) flymake-proc-legacy-flymake)
=C2=A0 flymake-start((post-comman= d) nil)
=C2=A0 #f(compiled-function () #<bytecode 0x1180771>= ;)()
=C2=A0 set-window-buffer(nil #<buffer a.java>)
=C2=A0 switch-to-buffer(#<buffer a.java>)
=C2=A0 ediff-s= etup-windows-multiframe-compare(#<buffer a.java> #<buffer b.java&g= t; nil #<buffer *Ediff Control Panel*>)
=C2=A0 ediff-setup-= windows-multiframe(#<buffer a.java> #<buffer b.java> nil #<b= uffer *Ediff Control Panel*>)
=C2=A0 ediff-setup-windows-defau= lt(#<buffer a.java> #<buffer b.java> nil #<buffer *Ediff Con= trol Panel*>)
=C2=A0 ediff-setup-windows(#<buffer a.java>= ; #<buffer b.java> nil #<buffer *Ediff Control Panel*>)
=C2=A0 ediff-setup(#<buffer a.java> "/:/tmp/a.java" #<= ;buffer b.java> "/:/tmp/b.java" nil nil nil ((ediff-job-name .= ediff-files)) nil)
=C2=A0 ediff-files-internal("/:/tmp/a.ja= va" "/:/tmp/b.java" nil nil ediff-files)
=C2=A0 ed= iff("/:/tmp/a.java" "/:/tmp/b.java")
=C2=A0 (= progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff "/= :/tmp/a.java" "/:/tmp/b.java"))
=C2=A0 eval((progn= (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff "/:/tmp= /a.java" "/:/tmp/b.java")))
=C2=A0 command-line-1(= ("-f" "toggle-debug-on-quit" "-eval" "(p= rogn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff \"/= :/tmp/a.java\" \"/:/tmp/b.java\"))"))
=C2=A0 = command-line()
=C2=A0 normal-top-level()

--0000000000002b2fba057bca9718-- From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2018 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Stephani Cc: 33524@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 33524-submit@debbugs.gnu.org id=B33524.15435828089722 (code B ref 33524); Fri, 30 Nov 2018 13:01:02 +0000 Received: (at 33524) by debbugs.gnu.org; 30 Nov 2018 13:00:08 +0000 Received: from localhost ([127.0.0.1]:55626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSiOt-0002Wj-C3 for submit@debbugs.gnu.org; Fri, 30 Nov 2018 08:00:08 -0500 Received: from mout.gmx.net ([212.227.15.19]:56941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSiOr-0002VP-CQ for 33524@debbugs.gnu.org; Fri, 30 Nov 2018 08:00:05 -0500 Received: from detlef.gmx.de ([178.20.94.255]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M92lh-1geVhz1cZZ-00COkp; Fri, 30 Nov 2018 13:59:58 +0100 From: Michael Albinus References: <874lc18too.fsf@gmx.de> Date: Fri, 30 Nov 2018 13:59:57 +0100 In-Reply-To: (Philipp Stephani's message of "Thu, 29 Nov 2018 10:48:42 +0100") Message-ID: <87tvjyg1pu.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:YIfiBUINwcn8UKOMWGUmwPVsRPr5TnreM+aq+vZEMp07i1430rO zoF0gfw68+AdPEIWSi4WWLDhPaxE3Yz5t7lWwPqxsbWNy+3NdLaaoXFN9wcEkVV7NBAVwDL /48HJWQsaZD9s+/EesLFzKzNufPSCCArvXC0Z7LSkKDb9MXm/kPfSteKOps+mHq7HxBKH3w 10hJtY+Sej03X8BmN6K8w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:788cYF7I0qo=:lup14Ex0JkSqnlHuDiFlC8 KSSF+b8IewM+GAju6Fc8Z/z1dtQPEABXA6JY8nKv2GwYkd+8yLaHc1MZOT7vfoMfTGMgAgH1w S3hgpP+rHGp55apYKIj8A3kLeXHgpZU+g6w7QmraRIi6sy2VYiB8yekJke5MQIcvbAsEMiFaN 8oPubkiJhcx2Eyl5wt5vj8qDWfhFKRY3O/u5PGbDSMYeH0d0KqlsPi+D+wjwesh41jgfZzagX 2bgUySW35/5VYV1CIHg1oG0h78+MRvOe9ds9nZWxwFxECX2Bw+qiwd+9qdti4LemTEbV77/b+ SXfMw4QIfFAwr915HraAKMJr3ND3oTEbvuljvEnqFA9FkMPA9yYCksVAWkQRYU82Rc5t9jL8S P1XxJdSDBcYGmiJPd3yRcKuj/7zRzmYtuuIW5z87NNUTM6cPix4getETKCW0lsOjJ5QSomgfA 0WuwvxUzUphhM4E7qW48iuyaC0DqThCKviZYHfxAUg4rMLNuvBo4J35XNz12xn6PAkw8jbN/4 e0Ekmi2MbwSIAWnGjd6QOXGzVSwf5P6ypZRPTIDXBhrMRyheBAcS1WMhLSRL+PB3Xhzb/+t1r qhPBNeYdlhSHmN16nJObnPF7tjrwQgFi4bxeYeJms6Od3JCgWl63QHCb6d7kvttFnWiZSgEPW m262m4QcvrSL/3XqUp7cZoZfyEb2h43yGYFkDuOarotfqnPowwsI5DaklpnTmy9mZ18NmA0mS PSCS6L0ZDlGHM78/NZLp/Oh9b5GIIapslCpjLL/RKpgAptnzwWBLoxzajNdVZ2HGBA2iQl/Cu EEPeg2LYajTSyZfHTIr/N9lS/SCjgyW5UJW4y4djOnRSEIkxkaMYo2KkAuWIMIWdRZwRS/51r iaqsrZJQpoCi/blBH/Zipm8Vy79Qxyjoqg7lwSCuHqxnMh55z/FuLNreUCJi1O X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Philipp Stephani writes: Hi Philipp, > Sorry for being imprecise. Yes, I mean quoted filenames. (It's > possible that the issue also arises for true remote filenames, but I > haven't checked.) "True remote filename" is still a wrong phrase. Quoted file names and remote file names play different games. > You can easily reproduce user-facing problems. Assuming you have some > binary installed that would check Java files using the legacy backend: > > $ touch /tmp/{a,b}.java > $ emacs -Q -eval '(progn (add-hook (quote prog-mode-hook) (quote > flymake-mode)) (ediff "/:/tmp/a.java" "/:/tmp/b.java"))' > > And Emacs immediately hangs because it runs into the endless loop. > Stacktrace in this case is > > Debugger entered--Lisp error: (quit) > display-warning((flymake flymake-proc) "Failed to delete dir /, > error ignored" :error "*Flymake log*") > flymake--log-1(1 flymake-proc "Failed to delete dir %s, error > ignored" "/") > flymake-proc--safe-delete-directory("/") > flymake-proc--delete-temp-directory("/tmp/:/tmp/") > flymake-proc-simple-java-cleanup() > #f(compiled-function () #)() > flymake-proc-legacy-flymake(#f(compiled-function (&rest args) > #)) > flymake--run-backend(flymake-proc-legacy-flymake) > #f(compiled-function (backend) #) > (flymake-proc-legacy-flymake) > run-hook-wrapped(#f(compiled-function (backend) # 0x117b195>) flymake-proc-legacy-flymake) > flymake-start((post-command) nil) > #f(compiled-function () #)() > set-window-buffer(nil #) > switch-to-buffer(#) > ediff-setup-windows-multiframe-compare(# # b.java> nil #) > ediff-setup-windows-multiframe(# # nil > #) > ediff-setup-windows-default(# # nil > #) > ediff-setup-windows(# # nil # *Ediff Control Panel*>) > ediff-setup(# "/:/tmp/a.java" # > "/:/tmp/b.java" nil nil nil ((ediff-job-name . ediff-files)) nil) > ediff-files-internal("/:/tmp/a.java" "/:/tmp/b.java" nil nil > ediff-files) > ediff("/:/tmp/a.java" "/:/tmp/b.java") > (progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff > "/:/tmp/a.java" "/:/tmp/b.java")) > eval((progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) > (ediff "/:/tmp/a.java" "/:/tmp/b.java"))) > command-line-1(("-f" "toggle-debug-on-quit" "-eval" "(progn > (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff > \"/:/tmp/a.java\" \"/:/tmp/b.java\"))")) > command-line() > normal-top-level() The following patch fixes this problem: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.el index 8600be9b97..e969c5d992 100644 --- a/lisp/progmodes/flymake-proc.el +++ b/lisp/progmodes/flymake-proc.el @@ -874,7 +874,7 @@ flymake-proc-create-temp-with-folder-structure (unless (stringp file-name) (error "Invalid file-name")) - (let* ((dir (file-name-directory file-name)) + (let* ((dir (file-name-directory (file-name-unquote file-name))) ;; Not sure what this slash-pos is all about, but I guess it's just ;; trying to remove the leading / of absolute file names. (slash-pos (string-match "/" dir)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable However, I don't know whether this is sufficient, because I don't know why you use quoted file names in your example. Is this something which shall be preserved in the temporary directory, created by flymake? Jo=C3=A3o, do you have further remarks? Best regards, Michael. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 30 08:01:22 2018 Received: (at control) by debbugs.gnu.org; 30 Nov 2018 13:01:22 +0000 Received: from localhost ([127.0.0.1]:55630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSiQ6-0002ZX-Dl for submit@debbugs.gnu.org; Fri, 30 Nov 2018 08:01:22 -0500 Received: from mout.gmx.net ([212.227.17.20]:51415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSiQ4-0002ZJ-Es for control@debbugs.gnu.org; Fri, 30 Nov 2018 08:01:20 -0500 Received: from detlef.gmx.de ([178.20.94.255]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MZxch-1gnxvZ0hAt-00LlLJ for ; Fri, 30 Nov 2018 14:01:14 +0100 Date: Fri, 30 Nov 2018 14:01:12 +0100 Message-Id: <87sgzien3b.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #33524 X-Provags-ID: V03:K1:z8argzvhIlqbutwQyuAPB75+MXe9fJ5jACNsoaA/nEXhJEdgVUG EC92pT7vzrgcmE94hoa4FL3fQD4Oq+to6lMF7QI2pKLYVIcLP7v+WlCJESki+1qF0Fcs+pm zvILcLfy/yzwXQLEuvSAUWvLpLg9KzlTuHhL3NHoNSq9PXK5exzA6MzEi9dYK9h4J9n08kp R6ou2aZ9FUuF+1ilf3t7g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/ZHodo9s4kI=:tEMMHiqGQaCmjZbwW9DoJc 6BR16xvEGhCdr/OZsAC17Xf7TU9WehGoPLvnMsaQEOFEPHVxZ5Zju5fwNTVx7EdTqP/9cgdFt YdLkTRKZ/LEuTUH1fMftycuRLdKvEZiDGbFxUUs9cxSQYeb213lelwnywmuoP23JxC1kq1jam P6KwAvZQtgpwIPS146HFuqRMNxKEa+PuLJIJeNpaWUrDmYZ+SRv660h/bQx0JgnmryUYsqLmh j+ltSSUVuHzPWuC4HY325rCGVbGaFcvbQTZLcT9WwVhS0cTxsWEeeeFWirljBMdZRHEXL4OBm 6lFnKeJsei8rJkFJ6iOZH6+s4fSWDtM7nlrSIs4FocLmFP6g0cU0DOsk0Bkh58une0eA4mkgY ZXXxj9scpz0PrntEdYDSkl9cg29uaTesIZJFJODz6JnJQ/CkIdSFbMS5QbyVhPTRNeG9+3cmB BE9bP2b7xaH2sIaGIZgFQbZ0JQJA0lh6ozBPfVpX3ErGMS+5y/eElwJR5zmOPv6BiHNiQMBiR eW38p0ee9x8CNKrqEI5NLPQRN5Br0lF1t1mUMauCFS0XkWfmg73U7A1eJmd2EcDV6VBBEZD4o /LQ/BOSGHCPlONicYTgJP52H969z4o88Cysv7O+QlcDYRCIRCIWO1Cnrg1mSS6p5vs5XqPY/s pWSQD1HS31/D7P6HEI0DSKqcWaBoJJGKz5fw3h3vfO66dGrgF+cT1NMcEjp3DKO9XZegXlx37 xl4O7BrIV7JaGM9+pTp1MG/o1D8aJa4nwxzbbV4KpK8Wg0HftBGtlxsVY+G/Ca4BxCmNAa9kR 08wzVt+3/fyHPiC92/HVS6Sg+6AJCi/5+nvUoihKyJPVrvZg53y2kiazirzS5dclrn9fomR3w XPbOHUW7QWQH8JJjFVe8FSaE97V82hjHgFtw6PaDeAlkjxMxO1+3M5W83ub2Kl X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 33524 patch From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2018 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Philipp Stephani , 33524@debbugs.gnu.org Received: via spool by 33524-submit@debbugs.gnu.org id=B33524.154358643823234 (code B ref 33524); Fri, 30 Nov 2018 14:01:01 +0000 Received: (at 33524) by debbugs.gnu.org; 30 Nov 2018 14:00:38 +0000 Received: from localhost ([127.0.0.1]:55641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSjLS-00062g-3K for submit@debbugs.gnu.org; Fri, 30 Nov 2018 09:00:38 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:43698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSjLQ-00062U-Qx for 33524@debbugs.gnu.org; Fri, 30 Nov 2018 09:00:37 -0500 Received: by mail-qt1-f172.google.com with SMTP id i7so5935304qtj.10 for <33524@debbugs.gnu.org>; Fri, 30 Nov 2018 06:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cdpI/EfBC9K4fjV+nhgJKK4Fg02cx158hXkCbrGmatI=; b=lLea3PYiYexzD00/eMRJxgasKU+HCCfDjeBfztuFq9bEJ7dP9vEFPrlw+dW9N1qvUL erHwfrtCBwF+A5MOmToDrinajyY3qcuzc32K8tDE+ZwkrjRM1uDzSD99kBkNLzErcmdt efXPyFsJGO1ORfL2DkKJD91cyqsI66DfdMH+PxBmj+nwlcNyWNmjacRiWhh75NrgDFsJ 3mzvPEWKnZlu0rqNpQ72AInVEQKxwQEmL9vE2yzY7ZCNyrL82C6sFyc7npWVLNDt6khy Dw18mKlWKEc6VD2lbYEgx28r8yLiRt2zeda9fsAtPGaZLs1gf/BAAWb0vci0Tb2ZiHsv L6xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cdpI/EfBC9K4fjV+nhgJKK4Fg02cx158hXkCbrGmatI=; b=GkfDukF2dwzSzG1qnShMprv4mLp1p2HaPTHDMS/68NVOGhVNJps9uLbwN6A+5299PQ VPG/N6RQdXaX4exf76KSKf7EyET2w236JvpD2Ho7OeOT7gvekHwZxo5AwZr5s9sPvcRn HmqQuhZA7Dbq8LHFeRCIuEfyYEjHFJIq0JzheZll77cI412LZkvGxvCOTXyMlLJNi/Bz d/+o5CSGuD08hPmxN5jbxmSSjjRbgbIBAuDPwWWs2bMsT49GPNv59fSkfqle0EHwkGj2 VuT5FMmsZAkBjrgBsOIlSNY2tLO82zaTbwWpArdaIvH2SWL6VSxs7uBJK2j+cswOX5Ku +qIw== X-Gm-Message-State: AA+aEWaNWtDKzRbmTGylX3LKAiUDLGvu6r5HALZI7nUaPRxWDnPg8nRz IXCR8TlKNGXG5SgDnTTmuI3K57PiDjHkQrNY0V4= X-Google-Smtp-Source: AFSGD/XqdNeDBv0RkV01/T/llFK8n1HSX9712jy24uEGn5+gUsCHR1gHRYgPUD6F8An1wlt4L8gskSvXtE+XDk6T5ds= X-Received: by 2002:ac8:88:: with SMTP id c8mr5697799qtg.218.1543586431237; Fri, 30 Nov 2018 06:00:31 -0800 (PST) MIME-Version: 1.0 References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> In-Reply-To: <87tvjyg1pu.fsf@gmx.de> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Fri, 30 Nov 2018 14:00:19 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ea01b4057be23862" X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --000000000000ea01b4057be23862 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable No, it looks great, for all I know... Which is very little :-) Flymake-proc is the "legacy" backend that I packed up in a file. It probably has many such bugs. Thanks very much Michael and Philipp, Jo=C3=A3o On Fri, Nov 30, 2018 at 12:59 PM Michael Albinus wrote: > Philipp Stephani writes: > > Hi Philipp, > > > Sorry for being imprecise. Yes, I mean quoted filenames. (It's > > possible that the issue also arises for true remote filenames, but I > > haven't checked.) > > "True remote filename" is still a wrong phrase. Quoted file names and > remote file names play different games. > > > You can easily reproduce user-facing problems. Assuming you have some > > binary installed that would check Java files using the legacy backend: > > > > $ touch /tmp/{a,b}.java > > $ emacs -Q -eval '(progn (add-hook (quote prog-mode-hook) (quote > > flymake-mode)) (ediff "/:/tmp/a.java" "/:/tmp/b.java"))' > > > > And Emacs immediately hangs because it runs into the endless loop. > > Stacktrace in this case is > > > > Debugger entered--Lisp error: (quit) > > display-warning((flymake flymake-proc) "Failed to delete dir /, > > error ignored" :error "*Flymake log*") > > flymake--log-1(1 flymake-proc "Failed to delete dir %s, error > > ignored" "/") > > flymake-proc--safe-delete-directory("/") > > flymake-proc--delete-temp-directory("/tmp/:/tmp/") > > flymake-proc-simple-java-cleanup() > > #f(compiled-function () #)() > > flymake-proc-legacy-flymake(#f(compiled-function (&rest args) > > #)) > > flymake--run-backend(flymake-proc-legacy-flymake) > > #f(compiled-function (backend) #) > > (flymake-proc-legacy-flymake) > > run-hook-wrapped(#f(compiled-function (backend) # > 0x117b195>) flymake-proc-legacy-flymake) > > flymake-start((post-command) nil) > > #f(compiled-function () #)() > > set-window-buffer(nil #) > > switch-to-buffer(#) > > ediff-setup-windows-multiframe-compare(# # > b.java> nil #) > > ediff-setup-windows-multiframe(# # nil > > #) > > ediff-setup-windows-default(# # nil > > #) > > ediff-setup-windows(# # nil # > *Ediff Control Panel*>) > > ediff-setup(# "/:/tmp/a.java" # > > "/:/tmp/b.java" nil nil nil ((ediff-job-name . ediff-files)) nil) > > ediff-files-internal("/:/tmp/a.java" "/:/tmp/b.java" nil nil > > ediff-files) > > ediff("/:/tmp/a.java" "/:/tmp/b.java") > > (progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff > > "/:/tmp/a.java" "/:/tmp/b.java")) > > eval((progn (add-hook (quote prog-mode-hook) (quote flymake-mode)) > > (ediff "/:/tmp/a.java" "/:/tmp/b.java"))) > > command-line-1(("-f" "toggle-debug-on-quit" "-eval" "(progn > > (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff > > \"/:/tmp/a.java\" \"/:/tmp/b.java\"))")) > > command-line() > > normal-top-level() > > The following patch fixes this problem: > > diff --git a/lisp/progmodes/flymake-proc.el > b/lisp/progmodes/flymake-proc.el > index 8600be9b97..e969c5d992 100644 > --- a/lisp/progmodes/flymake-proc.el > +++ b/lisp/progmodes/flymake-proc.el > @@ -874,7 +874,7 @@ flymake-proc-create-temp-with-folder-structure > (unless (stringp file-name) > (error "Invalid file-name")) > > - (let* ((dir (file-name-directory file-name)) > + (let* ((dir (file-name-directory (file-name-unquote file-name))) > ;; Not sure what this slash-pos is all about, but I guess it's > just > ;; trying to remove the leading / of absolute file names. > (slash-pos (string-match "/" dir)) > > However, I don't know whether this is sufficient, because I don't know > why you use quoted file names in your example. Is this something which > shall be preserved in the temporary directory, created by flymake? > > Jo=C3=A3o, do you have further remarks? > > Best regards, Michael. > --=20 Jo=C3=A3o T=C3=A1vora --000000000000ea01b4057be23862 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
No, it looks great, for all I know... Which is very l= ittle :-)

Flymake-proc is the "legacy" b= ackend that I packed up in a file. It probably has many such bugs.

Thanks very much Michael and Philipp,
Jo=C3= =A3o



On Fri, Nov 30, 2018 at 12:59 PM Michael Albinus <= ;michael.albinus@gmx.de> w= rote:
Philipp Stephani <p.stephani2@gmail.com> writes:

Hi Philipp,

> Sorry for being imprecise. Yes, I mean quoted filenames. (It's
> possible that the issue also arises for true remote filenames, but I > haven't checked.)

"True remote filename" is still a wrong phrase. Quoted file names= and
remote file names play different games.

> You can easily reproduce user-facing problems. Assuming you have some<= br> > binary installed that would check Java files using the legacy backend:=
>
> $ touch /tmp/{a,b}.java
> $ emacs -Q -eval '(progn (add-hook (quote prog-mode-hook) (quote > flymake-mode)) (ediff "/:/tmp/a.java" "/:/tmp/b.java&qu= ot;))'
>
> And Emacs immediately hangs because it runs into the endless loop.
> Stacktrace in this case is
>
> Debugger entered--Lisp error: (quit)
>=C2=A0 =C2=A0display-warning((flymake flymake-proc) "Failed to del= ete dir /,
> error ignored" :error "*Flymake log*")
>=C2=A0 =C2=A0flymake--log-1(1 flymake-proc "Failed to delete dir %= s, error
> ignored" "/")
>=C2=A0 =C2=A0flymake-proc--safe-delete-directory("/")
>=C2=A0 =C2=A0flymake-proc--delete-temp-directory("/tmp/:/tmp/"= ;)
>=C2=A0 =C2=A0flymake-proc-simple-java-cleanup()
>=C2=A0 =C2=A0#f(compiled-function () #<bytecode 0x11a4ea9>)()
>=C2=A0 =C2=A0flymake-proc-legacy-flymake(#f(compiled-function (&res= t args)
> #<bytecode 0x11a4e51>))
>=C2=A0 =C2=A0flymake--run-backend(flymake-proc-legacy-flymake)
>=C2=A0 =C2=A0#f(compiled-function (backend) #<bytecode 0x117b195>= )
> (flymake-proc-legacy-flymake)
>=C2=A0 =C2=A0run-hook-wrapped(#f(compiled-function (backend) #<bytec= ode
> 0x117b195>) flymake-proc-legacy-flymake)
>=C2=A0 =C2=A0flymake-start((post-command) nil)
>=C2=A0 =C2=A0#f(compiled-function () #<bytecode 0x1180771>)()
>=C2=A0 =C2=A0set-window-buffer(nil #<buffer a.java>)
>=C2=A0 =C2=A0switch-to-buffer(#<buffer a.java>)
>=C2=A0 =C2=A0ediff-setup-windows-multiframe-compare(#<buffer a.java&= gt; #<buffer
> b.java> nil #<buffer *Ediff Control Panel*>)
>=C2=A0 =C2=A0ediff-setup-windows-multiframe(#<buffer a.java> #<= ;buffer b.java> nil
> #<buffer *Ediff Control Panel*>)
>=C2=A0 =C2=A0ediff-setup-windows-default(#<buffer a.java> #<bu= ffer b.java> nil
> #<buffer *Ediff Control Panel*>)
>=C2=A0 =C2=A0ediff-setup-windows(#<buffer a.java> #<buffer b.j= ava> nil #<buffer
> *Ediff Control Panel*>)
>=C2=A0 =C2=A0ediff-setup(#<buffer a.java> "/:/tmp/a.java&quo= t; #<buffer b.java>
> "/:/tmp/b.java" nil nil nil ((ediff-job-name . ediff-files))= nil)
>=C2=A0 =C2=A0ediff-files-internal("/:/tmp/a.java" "/:/tm= p/b.java" nil nil
> ediff-files)
>=C2=A0 =C2=A0ediff("/:/tmp/a.java" "/:/tmp/b.java")=
>=C2=A0 =C2=A0(progn (add-hook (quote prog-mode-hook) (quote flymake-mod= e)) (ediff
> "/:/tmp/a.java" "/:/tmp/b.java"))
>=C2=A0 =C2=A0eval((progn (add-hook (quote prog-mode-hook) (quote flymak= e-mode))
> (ediff "/:/tmp/a.java" "/:/tmp/b.java")))
>=C2=A0 =C2=A0command-line-1(("-f" "toggle-debug-on-quit&= quot; "-eval" "(progn
> (add-hook (quote prog-mode-hook) (quote flymake-mode)) (ediff
> \"/:/tmp/a.java\" \"/:/tmp/b.java\"))"))
>=C2=A0 =C2=A0command-line()
>=C2=A0 =C2=A0normal-top-level()

The following patch fixes this problem:

diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.e= l
index 8600be9b97..e969c5d992 100644
--- a/lisp/progmodes/flymake-proc.el
+++ b/lisp/progmodes/flymake-proc.el
@@ -874,7 +874,7 @@ flymake-proc-create-temp-with-folder-structure
=C2=A0 =C2=A0(unless (stringp file-name)
=C2=A0 =C2=A0 =C2=A0(error "Invalid file-name"))

-=C2=A0 (let* ((dir=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name-directory file-nam= e))
+=C2=A0 (let* ((dir=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name-directory (file-na= me-unquote file-name)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Not sure what this slash-pos is all a= bout, but I guess it's just
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; trying to remove the leading / of abs= olute file names.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(slash-pos (string-match "/" di= r))

However, I don't know whether this is sufficient, because I don't k= now
why you use quoted file names in your example. Is this something which
shall be preserved in the temporary directory, created by flymake?

Jo=C3=A3o, do you have further remarks?

Best regards, Michael.


--
Jo=C3=A3o T=C3=A1vora --000000000000ea01b4057be23862-- From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2018 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Philipp Stephani , 33524@debbugs.gnu.org Received: via spool by 33524-submit@debbugs.gnu.org id=B33524.154358716524334 (code B ref 33524); Fri, 30 Nov 2018 14:13:02 +0000 Received: (at 33524) by debbugs.gnu.org; 30 Nov 2018 14:12:45 +0000 Received: from localhost ([127.0.0.1]:55655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSjXB-0006KQ-3E for submit@debbugs.gnu.org; Fri, 30 Nov 2018 09:12:45 -0500 Received: from mout.gmx.net ([212.227.15.18]:45611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSjXA-0006KE-0j for 33524@debbugs.gnu.org; Fri, 30 Nov 2018 09:12:44 -0500 Received: from detlef.gmx.de ([178.20.94.255]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lb4vZ-1hCprg1pOL-00kdq2; Fri, 30 Nov 2018 15:12:37 +0100 From: Michael Albinus References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> Date: Fri, 30 Nov 2018 15:12:36 +0100 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 30 Nov 2018 14:00:19 +0000") Message-ID: <87y39aodrf.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:i09jXesDbHfV/sQ7RhffeKNE8XQMypH6RdM3CsN8fPqSSXx76IX mFgDcjeM1OFyqpbIxQUrUzcb/nG3MUh2sFDmMitKr33/O30MgemaWWUpokwTVy7tqoY3puY mXlzCefzltofzkKtWHIldKvPdLRG4u+jRqVxEuXO0brlNG+ljIk1U8RKx8HMG4pK208YbrF X8KwDbp1f5X76pC9Xn4tg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ejzrTK1ic7c=:7Iaaen5slislFnShpyCV92 SekQ0Agr3Z5sdWQqCku61DEUTDbppJUzeEqd8r/tHIQ3PcPFV6XwBKpYflpXN0EFoEFJQuu9R 64pLhr6Tk7L8aSd725GGfjkVIJjQoCSbDNTCR7J8pnC9Yv8OVUSYzyKbRI6o+JoucP2jYSWug wXbQgc+sTAjNgP7818lopB3ILD1ssoca0QUZD5k2rxmRh9SejfG/jCvItjbWN8c2nJEojHgFi /jmI/3JqzciJnAXFNzZuYIp9OBiSyHUrduy348sCgSrcQ29pbrL7FNyQHIQvGzumnTr7+g7Gw rRWUC40GcqhMy64cikd4to8R/kTFo5r8lCk+KriMtAoLKG1GI7v5nAj/IOxTKVq0VNGkL4h+N IZJkaVrQZaa6ZZkafRvUS05ozRVjLmbfms30zvQ4uPhKrtmjAcwxBbIGNaOZG+CdvdG3dy0Dw uPX1t42t25Wg5ic+2kgejLb5Tmc3QOYKe8Sal/bxBbKwSNss1b6IvhmvA9cDyftaEVntVVxBU ObE3vu8yxlpvbm4KullO/PxcKEA89+sBImIz+aqmCNK3wT1YlllPcQqjc8tiw0wS9Csabaozp 1/N9/egb7F9yhA2rWS31MvnhMB61wu6PoUa30OJEcxAGx90dALvwKgKepVPkHwiCSTH7LdwrW DWDG/k0IA+a56DQX9j8dyGSOdfN8xaE3PmA6674I4CfWU4ju87/MFVQXxsOyeFiQTUL/lPzkj EEsqgcAp53xemaErGzPnDAXQRwiZ8bxwBTRJxa28RYWlzM8SCdCC6F673vaqq2YQ6NcGHIXDG vlp6lIASRmy8gg8mz9ut7t1eRJpnoTIEbNPThGBGvvfKQEsjsl61+76QZ1xjcC4xgsSjWPphS 9SOXsFS2TfFSKminUFT5mo9amQWtoZ1YBqSwYpcxVoOqjluDn/d2E0LAi1Rvpm1aYQYQkVtTW qSReGQCYQyQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, > No, it looks great, for all I know... Which is very little :-) > > Flymake-proc is the "legacy" backend that I packed up in a file. It > probably has many such bugs. Thanks for the reply. If Philipp confirms the solution, I'll push it to master. > Thanks very much Michael and Philipp, > Jo=C3=A3o Best regards, Michael. From unknown Sun Jun 22 22:46:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Philipp Stephani Subject: bug#33524: closed (Re: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories) Message-ID: References: <877eg8s9mt.fsf@gmx.de> X-Gnu-PR-Message: they-closed 33524 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 33524@debbugs.gnu.org Date: Mon, 17 Dec 2018 10:59:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1545044343-24613-1" This is a multi-part message in MIME format... ------------=_1545044343-24613-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33524: 27.0.50; Suspicious code in flymake-proc around temporary directori= es which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33524@debbugs.gnu.org. --=20 33524: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33524 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1545044343-24613-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33524-done) by debbugs.gnu.org; 17 Dec 2018 10:58:13 +0000 Received: from localhost ([127.0.0.1]:50896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYqbE-0006NR-NP for submit@debbugs.gnu.org; Mon, 17 Dec 2018 05:58:12 -0500 Received: from mout.gmx.net ([212.227.17.20]:48133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYqbC-0006NC-SJ for 33524-done@debbugs.gnu.org; Mon, 17 Dec 2018 05:58:11 -0500 Received: from detlef.gmx.de ([212.86.54.89]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LjdS8-1hA7Hv1a8G-00bf1f; Mon, 17 Dec 2018 11:58:03 +0100 From: Michael Albinus To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> <87y39aodrf.fsf@gmx.de> Date: Mon, 17 Dec 2018 11:58:02 +0100 In-Reply-To: <87y39aodrf.fsf@gmx.de> (Michael Albinus's message of "Fri, 30 Nov 2018 15:12:36 +0100") Message-ID: <877eg8s9mt.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Ga+K0iQdkhU/qPqpvrjcK7it8Xww6Ld2cJWGXKtCaUOnlWoFQbs XhKVOTjQJS6i2LaYzs4Qivp2GdBT+SuFDstDbb72dsUWavLRQvAOGAbHNKDsbnOu1BRbssr azePu4XyCfStzyMywihUu2vg4uNGmO/vzVmI/Fq0gKvU1uLLNFYtPpUNo5G11WcCnyaOKTe A8Un9RudrpdE0NM0LD1wQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jiu+LrYzjjU=:RZ1mGANw6UAMp0VEzGBSMv D2E7F9FGYNluDFlQOPn0eZTBa+cVg7IpEk3x8Q39NkZFhGsN0wZ7KM2UqtjrhZavmLGVNlwDp 2GOL8yPzA94eLpLEXInXyFkbFEezc1cTa8SOX09Shiq7s73AL3hANhmBGQXZl0BAUE2smimRf nAQlFYkf0qS9alFB3GzPxMaLC3Z3Z5NLl6uuAOTWnt60AahJOAPNNE9T8BLwOhWTTA/tV8d6n byd8qmVM8u2U8mM9136zOH7Ld2+W31pq1VS2N/D1Eo1sUhDk6uxDX7vTsts+OoHHSrKplSe4C RDhI9Zbeokz/ULaBaW2AYRuzjlAgaAdnY0dMP9VV3sOBZorobU7d0qWr8dy2FKeteiUrJF2+H C2WjxRgBikeZLi2bvTDdGM2mKt/KgsQ5u9JMdxNPsaQMACp3yvJPD8WEomPHh943HbhjImrZf bmrezTZlhTp5PKNeKbWYI8QNhnI+aMYTiRb0grD9GEEsh8nDjkuDJXtYYO+H5ckNK1in8n0Ji /ePrQ/4i5IFAqpL0Q54+/80hnj+DBoJC1meyedt5jyiZwGSVKv7kDutMVWTYA6UOVl+sJTFx9 1XzUBB6QUXDC3hA5ZjdwlZ/zjNEtIReqtSxk40+1SZ8p8qFqsgbohFv3Q5m1s0RcrK083Zkkf JGdkKHVefFbrdMyZv6ayR/ocfzNpWkQbARgFQfF+cy95jnvUEkyZ3Jqn5npCeZwxxVoW7k/Hq GjmZ/1ed7BAT4qAdnxeeuIx2RAkaiXpWUaA5R4cbZFk98EvDR7/w5752yDnvQl/ACGWT4PhUh 41Vl4FbAj+dYjZrzkildTYuymCDAhPFd5r+XWlIvr75zu7aVg7VutFD8oRU9YIXz9PGBpnQ14 s8Q/b1FLkj/ngaIdhEDwucqeG8RHM60hPSQLkiA2YP9LAVa8Ea+FM/pmeCrQ9qpUpaJ7D/A9u iaUeRc0je5g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33524-done Cc: Philipp Stephani , 33524-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi, >> No, it looks great, for all I know... Which is very little :-) >> >> Flymake-proc is the "legacy" backend that I packed up in a file. It >> probably has many such bugs. > > Thanks for the reply. If Philipp confirms the solution, I'll push it to > master. I've pushed the patch to the master branch, closing the bug. >> Thanks very much Michael and Philipp, >> Jo=C3=A3o Best regards, Michael. ------------=_1545044343-24613-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Nov 2018 16:37:23 +0000 Received: from localhost ([127.0.0.1]:52457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRgMV-0007pz-Ev for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRgMT-0007pi-F9 for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRgMM-0004lT-VJ for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRgMM-0004lK-SM for submit@debbugs.gnu.org; Tue, 27 Nov 2018 11:37:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRgML-0001qD-FJ for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 11:37:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRgMJ-0004iK-5e for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 11:37:12 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:37091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRgMI-0004g2-Uv for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 11:37:11 -0500 Received: by mail-wm1-x332.google.com with SMTP id g67so9442636wmd.2 for ; Tue, 27 Nov 2018 08:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8vbRp3UAlUtFpG4Z/ATa+EGPDmM+CLTh7FifnTGyU6w=; b=eQqTfxdDBkxAeXj13nX/qCTTIyi/JxBOUihb9ZP9izAvkzHwYPT86Mca9IzkpvRFKu +GPautI4eeQ/crZQffJLbr7zJFmOI6x2K5OfwWRGaGCGWEPpRKkjhqqQjPwb73ljghrf Z55AJOotgRlrwqJPSFM101yyz6v6VQsZ2qHtACDkg0kpPUAPOVt/wjQ3Z9QerVh/CVWP GVQUtSEmgN96yuG0F4jrk+Ig/Da8lhzrsrLH/WnaxoyXRAteU9e5Sa0soR9S4Dzv27Tl IW/nA4mtyVumpDrsMwT3LbUDUZaQZNqCqNyD1t24Iwo+dvOjPm9tkbiumBrN2Uovsmmg +2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8vbRp3UAlUtFpG4Z/ATa+EGPDmM+CLTh7FifnTGyU6w=; b=ersbEKO/IpA0KnDpH939fEFM10YRAQmm6KrUhoCuiDlAf2JsDNfMNfKF2rcfiJaY/g AHkQy5TPRMetLVtILxQv9r/TEQ5pMhxFu4Lja9qarmwAd7gYgawvsofQIyUfyhcPl34d Obazev/euhvluyDC1CFVc74ZNiDmjNFCAAdKay0w1q15k7mfbYh32jyaHLbXdREk8TP6 /4Nbe1laOjQzKiRj3TIep6sKBmyy18WRv2W+Ip+kqAoAcWqDL8NTdO41jmPeX9mqP6bX J7HiMB+HdEsLw1NI+YeyGx0+iTDB4tiuad4pzaeuxzoReH1QIpa2HXmpanX9EiU+2P6+ ajfg== X-Gm-Message-State: AA+aEWayud8r9KLDHxQvfCYOt7aN+cOu0AGT6nD/ec3Xmur4j19GZx72 Y1g+W2ye7ctpF8lUdgeSW4pc8dle X-Google-Smtp-Source: AFSGD/UZsatK4j2ns1JjnYAdZN0+3Di+9Els1rFhQLCYx8+O6PG6mKkC00Bvzl/fDsHaGmNTXZk85Q== X-Received: by 2002:a1c:1b8d:: with SMTP id b135mr17845193wmb.24.1543336629100; Tue, 27 Nov 2018 08:37:09 -0800 (PST) Received: from a.muc.corp.google.com ([2a00:79e0:15:10:cd99:29f5:6da:65fc]) by smtp.gmail.com with ESMTPSA id l15sm4445808wrw.4.2018.11.27.08.37.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 08:37:08 -0800 (PST) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Suspicious code in flymake-proc around temporary directories Date: Tue, 27 Nov 2018 17:37:05 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) I've noticed that the temporary directory code in flymake-proc has issues with remote filenames. For example: $ emacs -Q -batch -l flymake-proc --eval=3D'(print (flymake-proc-create-tem= p-with-folder-structure "/:/dir" nil))' "/tmp/:/dir" Clearly that's not what was intended. Rather, this should create the directory structure on the remote machine. If we use that filename: mkdir -p /tmp/:/dir then stuff will generally work, but trying to remove it will cause an endless loop and try to remove /dir and /: $ emacs -Q -batch -l flymake-proc --eval=3D'(flymake-proc--delete-temp-dire= ctory "/tmp/:/dir")' Error [flymake-proc *scratch*]: Failed to delete dir /dir, error ignored Error [flymake-proc *scratch*]: Failed to delete dir /, error ignored Error [flymake-proc *scratch*]: Failed to delete dir /, error ignored [...infinite loop...] ^C lisp.h:1485: Emacs fatal error: assertion failed: 0 <=3D nchars Aborted The assertion failure seems to be a different issue, but this bug focuses on the problematic behavior of flymake-proc. The code for these functions looks really suspicious and seems to make lots of incorrect assumptions (about whether temporary-file-directory ends in a slash, that all files are local, etc.). Especially the infinite loop in flymake-proc--delete-temp-directory causes trouble because the only way out of it is sending a signal to the Emacs process. In GNU Emacs 27.0.50 (build 46, x86_64-pc-linux-gnu, GTK+ Version 3.22.24) of 2018-11-27 Repository revision: e02d375cb6670e2306b9c67d7f6fd2dd1d1b2711 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux buster/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Eager macro-expansion failure: (wrong-number-of-arguments (2 . 2) 4) Configured using: 'configure --without-threads --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES JSON GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst pcase ffap thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 109009 5313) (symbols 48 21762 1) (strings 32 32871 2004) (string-bytes 1 894311) (vectors 16 16454) (vector-slots 8 533506 11914) (floats 8 52 65) (intervals 56 230 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. ------------=_1545044343-24613-1-- From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2018 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 33524-done@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 33524-done@debbugs.gnu.org id=D33524.15450802778874 (code D ref 33524); Mon, 17 Dec 2018 20:58:02 +0000 Received: (at 33524-done) by debbugs.gnu.org; 17 Dec 2018 20:57:57 +0000 Received: from localhost ([127.0.0.1]:52295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYzxd-0002J4-Bs for submit@debbugs.gnu.org; Mon, 17 Dec 2018 15:57:57 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]:36781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYzxZ-0002Io-MY for 33524-done@debbugs.gnu.org; Mon, 17 Dec 2018 15:57:54 -0500 Received: by mail-ot1-f53.google.com with SMTP id k98so13569849otk.3 for <33524-done@debbugs.gnu.org>; Mon, 17 Dec 2018 12:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gfu8xT/ItVrWwbmnMj8O1HDDFY5Id7NOH8G58wkQLvs=; b=CifI9BcA8SNUjk9J1eP/Rj2CWnLZ1gJBMkcxaVYoAQV1mHkNN0rFZmm0EV9vRaTgSg vrKj6h1zdEQ7PeE5XlOaoavkF1RIn0oBEjqfjyVON3bB3xVwPurSZacW59Y0s5aKC7s9 Gaz2pmNnfQJZbcnCndEpE6WPAyrBjyKOyaRImoetr93RgGyt1KSph1NMToIJmI/NaHD3 89WwSJf68gsO9vD0BvQfFSinKq31ttvz5QSg2UM4TEjPAGcleCyKrLfGdycBdrNfUs6Z +JI9jERJm0/fODpCoM1/rT+cDMno9P1U8ZYxOcIJQ1yOzgLqs4Ds1vUtD/JFas5E5EuB J3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gfu8xT/ItVrWwbmnMj8O1HDDFY5Id7NOH8G58wkQLvs=; b=Y4PUzArcIfqHttk5DJZos44vdd01rnWI/I3+COgUCsEKPl5hI78ZYWnJHY388R2rFr RW8vanYPD3ZcJOEx6r4ja76m0m31/6DH/B31xFdnXrqePhJDLBhdM8sLTw0JgUmHboio 3ZKlPRDwkKi9nf4vmpp3O1UqZXc6aHkXfGM0PbraFu8sXyITxykstW9/ivQvogJtYeB2 2ndnd6RzISzzTG2FlDu3+7A0Y1J3HYbRPnl8RKN1ZLT4xtI65l0GXR2DDvx+EUIjWouP 6jC9mSxtMiQ9Vfu2K4sUPfpt5jJVCLDsrdhdOJiOAhCuIOe23SXzyRYXKH3d6A0Tvu51 20eA== X-Gm-Message-State: AA+aEWbgiiulfqCUPtYEQSu29XhwnpzAnBDCLdZGeO4FiXn5sGHBRxu9 szzyMwuXLwYIFSrmJ+Y3B7ObGwQooWLOQHwZXoI= X-Google-Smtp-Source: AFSGD/X2OJvuBBxj3ipWuvTpXj2Ar27llFI5aV/gHrFwB0wLYODTeE81d+fAlRkW0tQset4u/4iuz1HShZDAZhBNL8c= X-Received: by 2002:a9d:4549:: with SMTP id p9mr10032830oti.51.1545080267832; Mon, 17 Dec 2018 12:57:47 -0800 (PST) MIME-Version: 1.0 References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> <87y39aodrf.fsf@gmx.de> <877eg8s9mt.fsf@gmx.de> In-Reply-To: <877eg8s9mt.fsf@gmx.de> From: Philipp Stephani Date: Mon, 17 Dec 2018 21:57:36 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Mo., 17. Dez. 2018 um 11:58 Uhr schrieb Michael Albinus : > > Michael Albinus writes: > > Hi, > > >> No, it looks great, for all I know... Which is very little :-) > >> > >> Flymake-proc is the "legacy" backend that I packed up in a file. It > >> probably has many such bugs. > > > > Thanks for the reply. If Philipp confirms the solution, I'll push it to > > master. > > I've pushed the patch to the master branch, closing the bug. Confirmed that the issue no longer happens on master, thanks. 1. Would it make sense to backport this patch onto the release branch? The bug is annoying, and the fix seems trivial. 2. There's more suspicious code in the legacy backend that assumes that magic or quoted filenames don't exist, is there a long-term plan to tackle this? ("Deleting the legacy backend" might be a viable long-term plan.) From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2018 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philipp Stephani Cc: 33524-done@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 33524-done@debbugs.gnu.org id=D33524.154508093610012 (code D ref 33524); Mon, 17 Dec 2018 21:09:01 +0000 Received: (at 33524-done) by debbugs.gnu.org; 17 Dec 2018 21:08:56 +0000 Received: from localhost ([127.0.0.1]:52299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZ08G-0002bQ-FZ for submit@debbugs.gnu.org; Mon, 17 Dec 2018 16:08:56 -0500 Received: from mout.gmx.net ([212.227.15.15]:56523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZ08E-0002b4-Ps for 33524-done@debbugs.gnu.org; Mon, 17 Dec 2018 16:08:55 -0500 Received: from detlef.gmx.de ([212.86.54.89]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LwJRe-1hTt0Q0t0Y-0182f4; Mon, 17 Dec 2018 22:08:48 +0100 From: Michael Albinus References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> <87y39aodrf.fsf@gmx.de> <877eg8s9mt.fsf@gmx.de> Date: Mon, 17 Dec 2018 22:08:46 +0100 In-Reply-To: (Philipp Stephani's message of "Mon, 17 Dec 2018 21:57:36 +0100") Message-ID: <8736qv6eu9.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ZfI9GYHNZAMMVsA6fcUux/EpNu78Fdf3L8nFot6dhhjQHSM/KqS LlsjTbGpBwzA8nDXScpPWdW2swjpEf6HcDUolgVPGQ1w9GhXVuEx2AOv1VTTAAMzTYgsiPr 4tug8sWhMKlJe2s62rYQoxng/F5S7qDIxak1+f4vzFORCaxGBmnhULn3e8ec6pqz0OikXTt /sTIpRDAwTiCFoaO52qNg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nmNDG28MwHI=:k2LZ1Qd/pfi5WRxaZ9sFVV p6g4J/1zBSLYpKZ11tZ+Hd01lyIcea6BL7rJwQpW50qdv6PQxva7FKHSKqYvK8kFkCBGuooFc AB4y15l0AuJBq9aP+7/Ot75FoiXhtK8PAkxU5xwgIRh8x76+q0cv5zxQpCgyFUeFHhGUYEsQL Koa7TwWycReCvyl0Q+hB+kQgtO2V5ZeY2FTREsy+WX728tQny4AWgcDmWZdbamVJYhwIn8hFP YCeO92UMfbpKw/Niqf3+EL/ExwCdQOoeH0TlvwGTvaESQPslN9CjQhDuogr51AOdIawb3bw8S YKBb46fiSXmEJWum1tOYWc9TJFS7kWBjaQrePtJXgzS7X/JdBzGh1Tg7OZW3/q+veFL6ZTXmI I/gFkWtez6AOrUT3CJFpDsjoT7z72dVE8C1eIV4rjrnMUhWlB51uMT9gcKo0NRrWT8QOwQijq Mwmq1W7bRYb/U8dkevOPA/ru/rNTBpd0EBxyfp6N5oKSrZvXfMV6hYBx5GrtkUsrl2nQ30Exp DSNuxBOUWf/PHiWA5DSvPN916RguB7jjgung6M/IK5I6+H4cPcby6A+FT92CoayyyNnOHbazm kwcndyZVTE4cSbPHsJza99rjztAyi5JL8MElIbH3jtetrWontiL/4QocTboay10jEMujOtiSu uSoqRE060IdjH8d4HeV4s8qDyJoy0X/Xu6wUjv1WxTtY3cUWO3ShzHaogPBQTHWwiONzjIKbm umyJukyhKa/V2ipHueF6F45AroGuENDBIuZwFTG7QGZaQLIs5y8erNiUETDRp6o/oAUPvMfpB 5iema0PsWblPp0NGIVdyVNlM2uRfzegYa/jANxu4EzSJe0eU7y7pfMOJDvXeMJ5F48ylWSrbQ FVYXpC0JSvwwI3VneeBGUCllhqZZk6/ayv1l1j4bZhvETTAdW6VZR8Qikg/gJxeR+J+lAJJgd ee+bPS2fBIA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: Hi Philipp, > 1. Would it make sense to backport this patch onto the release branch? > The bug is annoying, and the fix seems trivial. That's for Eli to decide. Yes, the patch is trivial, so it seems harmless to backport. > 2. There's more suspicious code in the legacy backend that assumes > that magic or quoted filenames don't exist, is there a long-term plan > to tackle this? ("Deleting the legacy backend" might be a viable > long-term plan.) I'm not in the flymake business. I will help if questions arise, but I'm not in the position to review flymake completely. Best regards, Michael. From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Dec 2018 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: p.stephani2@gmail.com, 33524-done@debbugs.gnu.org, joaotavora@gmail.com Received: via spool by 33524-done@debbugs.gnu.org id=D33524.154514524519715 (code D ref 33524); Tue, 18 Dec 2018 15:01:02 +0000 Received: (at 33524-done) by debbugs.gnu.org; 18 Dec 2018 15:00:45 +0000 Received: from localhost ([127.0.0.1]:53546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZGrU-00057v-N1 for submit@debbugs.gnu.org; Tue, 18 Dec 2018 10:00:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZGrT-00057i-F7 for 33524-done@debbugs.gnu.org; Tue, 18 Dec 2018 10:00:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZGrG-0004tV-AH for 33524-done@debbugs.gnu.org; Tue, 18 Dec 2018 10:00:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGqq-0004gx-Kn; Tue, 18 Dec 2018 10:00:08 -0500 Received: from [176.228.60.248] (port=1934 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gZGqp-00055v-Jm; Tue, 18 Dec 2018 10:00:04 -0500 Date: Tue, 18 Dec 2018 17:00:11 +0200 Message-Id: <83y38mdgn8.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <8736qv6eu9.fsf@gmx.de> (message from Michael Albinus on Mon, 17 Dec 2018 22:08:46 +0100) References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> <87y39aodrf.fsf@gmx.de> <877eg8s9mt.fsf@gmx.de> <8736qv6eu9.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Michael Albinus > Date: Mon, 17 Dec 2018 22:08:46 +0100 > Cc: 33524-done@debbugs.gnu.org, > João Távora > > Philipp Stephani writes: > > Hi Philipp, > > > 1. Would it make sense to backport this patch onto the release branch? > > The bug is annoying, and the fix seems trivial. > > That's for Eli to decide. Yes, the patch is trivial, so it seems > harmless to backport. Fine with me, thanks. From unknown Sun Jun 22 22:46:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33524: 27.0.50; Suspicious code in flymake-proc around temporary directories Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Dec 2018 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: p.stephani2@gmail.com, 33524-done@debbugs.gnu.org, joaotavora@gmail.com Received: via spool by 33524-done@debbugs.gnu.org id=D33524.154515157229789 (code D ref 33524); Tue, 18 Dec 2018 16:47:02 +0000 Received: (at 33524-done) by debbugs.gnu.org; 18 Dec 2018 16:46:12 +0000 Received: from localhost ([127.0.0.1]:53609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZIVW-0007kO-Ts for submit@debbugs.gnu.org; Tue, 18 Dec 2018 11:46:11 -0500 Received: from mout.gmx.net ([212.227.15.19]:43553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZIVS-0007ja-JF for 33524-done@debbugs.gnu.org; Tue, 18 Dec 2018 11:46:07 -0500 Received: from detlef.gmx.de ([79.140.120.234]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MH0SI-1geESq0vkg-00Dl0Z; Tue, 18 Dec 2018 17:45:58 +0100 From: Michael Albinus References: <874lc18too.fsf@gmx.de> <87tvjyg1pu.fsf@gmx.de> <87y39aodrf.fsf@gmx.de> <877eg8s9mt.fsf@gmx.de> <8736qv6eu9.fsf@gmx.de> <83y38mdgn8.fsf@gnu.org> Date: Tue, 18 Dec 2018 17:45:57 +0100 In-Reply-To: <83y38mdgn8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Dec 2018 17:00:11 +0200") Message-ID: <87y38m3hru.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:XVyZyGCmEGzCKxGQ4uWpmucthJooANuTkc+flpetLrGWUmhR4mh utjKLIbzM1KG/iwEGS3lKWp1N8H2dRI5yMj2odDsbpe77wq899RoNjyw4JNWre4Ta2gFwif lZMKE4pQyKDzxC5igH65qs2L6MT+xnzPyXySY4miLbyftW5Mye+kWBguluz6Nn80BnnHlol m4MhVUB+xSHmQ4Jntxncg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:lMCLPQZDG3Q=:YkDgcMVKJkkA7HFkMRfoH3 bg4YPLPEEzGEKPwqvccLiFKFdFmb0T3tyQB3L+9HucjQ9wmP95co1YJ7UMzJkZ6PVo62If7a+ o0r03WyfuRyWut5zdz6cPTYxhEybaYQVUBb2LZHZh85RLaRpUl+DWlf27idQAOEHmZfmjoxGg RiPCimKKJcXRl4Muq0dJHhAQmkgOBfF1mHmqqBoVJnQ7MFrmyYtSHVnzD9sDuG6yj6VujBwLt fzj+yGQZMz5utfjtque7u/dF/mXK7t86D/BSNmjZGlb7jD3xGLtLKqJT/ztpYDfJAvrncteFV lJmYfRbcMC6Lrdmf6w4XY5gyW6a8gVb/dp7m1m/cjWujD1Jsmv1dh0DJIWTnlQkXHfEsLgPRr DqV8dHJDpUu9LYhZyHx/4HpfXUuZYT++fsK6luvORRyM+MhAK8gwjQQ2PaylkfI1/FjJnPiYT 5NX1G+TdtM1q8sYdK0E8VF/ygpifdIJwhYe56SGdXTFDytt8mM9YBSU5aAA9fIBoapNr24eBy edil2UYjQvkilXvCqfZVpZtldLLqG/CXQck971iKaZZ2kC/NBA/VMhESSDy0+Ly45AXqSFhsp YZrIg9UjL/PFX9NZkuWMece3cLJIHPBkv0BLmBmr8tCxi3Ob/hXcZGy7QNetYQvimggiiy5MF DOkjov+AHJbZY+hXKmlnkwthmX6Bu1ZvMNpTcOJeUoi+yzOnF/d83VoozzYriT3WjvWMTAzXg EweutlFqVE51UepEx/5U1vl9TUdC8/gnFar+W7ErJyydY8lEa9wMiq9Lqc4SvY8ocK9Zw4wW/ q6xtaX0YbHnpsxJtZBZIMNSKwXR/G//hujxhONnNha8T1UmP6Ll84JMd/B5Nevl9W1r5Fwoo9 jfPi3hmXA0+fXtkiSfAIIwMYfrK2EfEjZ8aAxV6mZPeqyqG5j5n3Z74/j/X7VfWBtWSMWZEgE b/8zFTC09fA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> > 1. Would it make sense to backport this patch onto the release branch? >> > The bug is annoying, and the fix seems trivial. >> >> That's for Eli to decide. Yes, the patch is trivial, so it seems >> harmless to backport. > > Fine with me, thanks. Cherry-picked from the master branch. Best regards, Michael.