From unknown Tue Aug 19 14:21:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33516: Should the docstring for flymake-diag-region mention behavior with narrowing? Resent-From: Matthew Bregg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Nov 2018 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33516@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154325733225226 (code B ref -1); Mon, 26 Nov 2018 18:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Nov 2018 18:35:32 +0000 Received: from localhost ([127.0.0.1]:50102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRLjI-0006Yn-0Y for submit@debbugs.gnu.org; Mon, 26 Nov 2018 13:35:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRKy7-0005Jg-FY for submit@debbugs.gnu.org; Mon, 26 Nov 2018 12:46:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRKxz-0000XK-SJ for submit@debbugs.gnu.org; Mon, 26 Nov 2018 12:46:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRKxy-0000Wi-PO for submit@debbugs.gnu.org; Mon, 26 Nov 2018 12:46:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRKxx-0001pf-U0 for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 12:46:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRKxv-0000VE-Qe for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 12:46:37 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:39035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRKxt-0000RM-RL for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 12:46:34 -0500 Received: by mail-wr1-x433.google.com with SMTP id t27so11916975wra.6 for ; Mon, 26 Nov 2018 09:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=yQXYaPUHMWBgV/dW0x4G06c05OLz26+poq+mT7CfNl4=; b=vNeA2KD+/tVfVgTSchpM5Q4z6CtsAPKoLofAzlmYKEG6nuoI/rJsaHgCQC7mgKL+Xr 8BJOYGjEUr2yD78mbClGfEbPOlgiLAmSPX0zQgCZIBcuitkJhbra2plXDe+rnqpLeUN6 puwCSV7471vJ3g+ot2u+l7K108SDuHdINluT5Trbv8qzQ3FO3spKleu6msMpANf741Cm 6jLYy9bw83dJRTakW2JF29HtR85iwvZXVNWC5e7aRWREXrHShv8X4SkRc7aURRX1nWOg H8nva7zvHWpXM57mDgCl/t27eUCEhS4fp8CLoSEgGihLw8XT0KjrKlSM4qAkCvy0cGVW R8hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=yQXYaPUHMWBgV/dW0x4G06c05OLz26+poq+mT7CfNl4=; b=VqkjKvbu2jwNh6YWf2K7rXYbSOG5c4fN57aYQ6xxcqQM9Kv2awm4Q2iFxiX7sv6lqr 3t2P6wfg/KJa5WAo91oFKhSJyHXHKYVQ8hwo6xIQo8Fq9S8QxJHMucrXy/W4GIprCQLb wA+Zzn0LVAyNxfa/FeUQ5dgu5Rr3R96eW6f4EsrQDmK4r/HPRV9wpztWDXlcpj3UkwL+ nW/21BHk2q/4KPNPRN20OjSAuVl5dLWilxtBtCtG84v1lk4P8EqDHavutvyMZXWa4NC0 QuszlA41iUQthK1Iya49glMsuSBdj2DXZLssKRM1Uhu+E3TCLR5vBbs1fOEc1vTBkgGK ia3A== X-Gm-Message-State: AA+aEWYaE+CR7D5B2lHTJ3zFjD6os/psCwi964E++OfMlOk0vwieKE6s BOO+DcevtIzqe1fG93I7asFnqRJgNaSaJsIIIvyk8Lpru0A= X-Google-Smtp-Source: AFSGD/UZJ+IfGIXVw4sw0Cm2aueF/EhUXeM6O+x5MLN7jbAMnjPi6X3n8tromrGI4buFqqsDA8VNOOCrkMkaqOHmtAo= X-Received: by 2002:a5d:678b:: with SMTP id v11mr26597380wru.245.1543254389977; Mon, 26 Nov 2018 09:46:29 -0800 (PST) MIME-Version: 1.0 From: Matthew Bregg Date: Mon, 26 Nov 2018 11:46:18 -0600 Message-ID: Content-Type: multipart/mixed; boundary="000000000000b718ef057b94e93b" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Mon, 26 Nov 2018 13:35:31 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --000000000000b718ef057b94e93b Content-Type: multipart/alternative; boundary="000000000000b718ec057b94e939" --000000000000b718ec057b94e939 Content-Type: text/plain; charset="UTF-8" Currently it can be confusing when developing a flymake checker that flymake-diag-region does not handle narrowing. Updating the comment to mention this seems useful to me. Thanks! --000000000000b718ec057b94e939 Content-Type: text/html; charset="UTF-8"
Currently it can be confusing when developing a flymake checker that flymake-diag-region does not handle narrowing.

Updating the comment to mention this seems useful to me.

Thanks!
--000000000000b718ec057b94e939-- --000000000000b718ef057b94e93b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Update-documentation-for-flymake.patch" Content-Disposition: attachment; filename="0001-Update-documentation-for-flymake.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_joylgcj20 RnJvbSAwYjQ3MTJjODU1M2I5MTgyMjdiZDU4YTIwNzFhMGRiZGVjYWEwNGMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGV3IEJyZWdnIDxicmVnZ0Bnb29nbGUuY29tPgpEYXRl OiBGcmksIDE2IE5vdiAyMDE4IDE1OjAxOjE0IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gVXBkYXRl IGRvY3VtZW50YXRpb24gZm9yIGZseW1ha2UuCgpGbHltYWtlIGZseW1ha2UtZGlhZy1yZWdpb24g ZG9lcyBub3QgbWVudGlvbiBiZWhhdmlvciB3aXRoIG5hcnJvd2luZywgd2hpY2ggY2FuIGJlIGNv bmZ1c2luZy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9mbHltYWtlLmVsIHwgNCArKystCiAxIGZpbGUg Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9wcm9nbW9kZXMvZmx5bWFrZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2ZseW1ha2UuZWwKaW5kZXgg ZjBmOTNmMTA4Ny4uNThiYmJkNTAwZSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZmx5bWFr ZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9mbHltYWtlLmVsCkBAIC0zODQsNyArMzg0LDkgQEAg dmVyaWZ5IEZJTFRFUiwgYSBmdW5jdGlvbiwgYW5kIHNvcnQgdGhlbSBieSBDT01QQVJFICh1c2lu ZyBLRVkpLiIKIChkZWZ1biBmbHltYWtlLWRpYWctcmVnaW9uIChidWZmZXIgbGluZSAmb3B0aW9u YWwgY29sKQogICAiQ29tcHV0ZSBCVUZGRVIncyByZWdpb24gKEJFRyAuIEVORCkgY29ycmVzcG9u ZGluZyB0byBMSU5FIGFuZCBDT0wuCiBJZiBDT0wgaXMgbmlsLCByZXR1cm4gYSByZWdpb24ganVz dCBmb3IgTElORS4gIFJldHVybiBuaWwgaWYgdGhlCi1yZWdpb24gaXMgaW52YWxpZC4iCityZWdp b24gaXMgaW52YWxpZC4KK0lmIHRoZSBCVUZGRVIgaGFzIGJlZW4gbmFycm93ZWQsCit0aGUgcmVn aW9uIHJldHVybmVkIHdpbGwgY29ycmVzcG9uZCB0byB0aGUgQlVGRkVSJ3MgbmFycm93ZWQgc3Rh dGUuIgogICAoY29uZGl0aW9uLWNhc2UtdW5sZXNzLWRlYnVnIF9lcnIKICAgICAgICh3aXRoLWN1 cnJlbnQtYnVmZmVyIGJ1ZmZlcgogICAgICAgICAobGV0ICgobGluZSAobWluIChtYXggbGluZSAx KQotLSAKMi4xOS4xLjEyMTUuZzg0MzhjMGIyNDUtZ29vZwoK --000000000000b718ef057b94e93b-- From unknown Tue Aug 19 14:21:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33516: Should the docstring for flymake-diag-region mention behavior with narrowing? Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2019 23:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthew Bregg Cc: 33516@debbugs.gnu.org Received: via spool by 33516-submit@debbugs.gnu.org id=B33516.156271613327946 (code B ref 33516); Tue, 09 Jul 2019 23:49:01 +0000 Received: (at 33516) by debbugs.gnu.org; 9 Jul 2019 23:48:53 +0000 Received: from localhost ([127.0.0.1]:34568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkzqt-0007Ge-OF for submit@debbugs.gnu.org; Tue, 09 Jul 2019 19:48:52 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkzqr-0007GV-DP for 33516@debbugs.gnu.org; Tue, 09 Jul 2019 19:48:49 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkzqo-00027e-54; Wed, 10 Jul 2019 01:48:48 +0200 From: Lars Ingebrigtsen References: Date: Wed, 10 Jul 2019 01:48:45 +0200 In-Reply-To: (Matthew Bregg's message of "Mon, 26 Nov 2018 11:46:18 -0600") Message-ID: <87zhlmojky.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matthew Bregg writes: > Currently it can be confusing when developing a flymake checker that > flymake-diag-region does not handle narrowing. > > Updating the comment to mention this seems useful to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthew Bregg writes: > Currently it can be confusing when developing a flymake checker that > flymake-diag-region does not handle narrowing. > > Updating the comment to mention this seems useful to me. [...] > -region is invalid." > +region is invalid. > +If the BUFFER has been narrowed, > +the region returned will correspond to the BUFFER's narrowed state." Hm... I think we generally assume that all functions (except explicitly documented not to) work on the narrowed section of a buffer? So documenting this in this specific function doesn't seem natural do me, and I'm closing this bug report. If somebody disagrees, please reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 19:48:55 2019 Received: (at control) by debbugs.gnu.org; 9 Jul 2019 23:48:55 +0000 Received: from localhost ([127.0.0.1]:34571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkzqw-0007Gx-W9 for submit@debbugs.gnu.org; Tue, 09 Jul 2019 19:48:55 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkzqw-0007Go-3q for control@debbugs.gnu.org; Tue, 09 Jul 2019 19:48:54 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkzqt-00027l-HC for control@debbugs.gnu.org; Wed, 10 Jul 2019 01:48:53 +0200 Date: Wed, 10 Jul 2019 01:48:51 +0200 Message-Id: <87y316ojks.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #33516 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 33516 wontfix close 33516 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 33516 wontfix close 33516 quit