From unknown Sun Jun 22 00:28:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33490: 27.0.50; auto-save-visited-mode clears the echo area every time the save interval is hit Resent-From: Terje Larsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Nov 2018 18:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33490@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154308238628142 (code B ref -1); Sat, 24 Nov 2018 18:00:03 +0000 Received: (at submit) by debbugs.gnu.org; 24 Nov 2018 17:59:46 +0000 Received: from localhost ([127.0.0.1]:45784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQcDZ-0007Jp-KD for submit@debbugs.gnu.org; Sat, 24 Nov 2018 12:59:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQWYE-0004gk-22 for submit@debbugs.gnu.org; Sat, 24 Nov 2018 06:56:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQWY7-0005hy-Tz for submit@debbugs.gnu.org; Sat, 24 Nov 2018 06:56:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gQWY7-0005hd-RD for submit@debbugs.gnu.org; Sat, 24 Nov 2018 06:56:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQWY6-0002Dn-O2 for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 06:56:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQWY2-0005bf-2j for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 06:56:34 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:39470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQWY1-0005TP-OW for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 06:56:30 -0500 Received: by mail-lf1-x12e.google.com with SMTP id n18so10314492lfh.6 for ; Sat, 24 Nov 2018 03:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klarna.com; s=google; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=xAvH6yHsEKTL8Y6FlCAwVJNHDF1RtyIIF3ggTPsX7oQ=; b=VooUB5FzciTqnckSH1gDET5kHbMBH6FRcp/uAullO4dettsGwIM1ec6WZLjsSz4WF3 AWUpEzpFyzf8FQNeQwGNH6V7hRbmWsiTVwPfvY3WKLq0ZoQSKtd+JF5amjDPGlVsBI4g W9llRLIm/6J6AIyePjBiOayhdyKuZA0Pqg9Tv7mreN46z1/Xya3+S1Vluo3byCZYvb3N NXLyqxMPyqcVu8EbsTKeABlus1fX2BdIA3Ilf4sRqtGs7F4rmtse/ygPgOnhLaFO1T7T au3AKrueBk3cBFn9iVovwwOm/5Od+QC0Pok32ZwHukdkyFgC7a6o/ySWqGsEb+XoIe0E QARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=xAvH6yHsEKTL8Y6FlCAwVJNHDF1RtyIIF3ggTPsX7oQ=; b=TbcizP42jRHHcNY7y2QrX7KpNFWfw2FCTgkQ3bJI72sPg5wsSOBu8wAm7M1V2QuH0/ qBZDId/l7MwfdpU3B2dre5xZOIOhSVTK1JXMaFXUy44YI8I78rqvA3xgXN3ruI4lbsyY d46UBneDHqFzdlzzH0LgXtMpn41WF8oOmxlUwTgAKNtix2p8Ojgck+LgaSLsZrgM8koR rW/eIpXypl2SOVuNzvjbMQ5OH8rLlxmgOYY26emEBLu748QG83j1BWNS7ou/3WIXFtNU w9mkAS49j7ROtT3wpxhKcO3QmhWS9rcCZnqHd6Lp3GOhvhCfN6BVmIsFgff5vxzIRSky Y2Xw== X-Gm-Message-State: AGRZ1gKEwgbOuwpumlgWoPoe/FarjlRFBIepBofHTk21j5BAgsja5jR3 wyIozAgASNlaJovUTCDmnrKb+7HLlQY= X-Google-Smtp-Source: AJdET5c/MLZvJRSY2WHG/WezFqDCMU0OXUbl9OtTPZbie7sItNvSYn3UnkzfKncHYZKOeJNPxR3P+g== X-Received: by 2002:a19:6f0a:: with SMTP id k10mr11150312lfc.119.1543060581425; Sat, 24 Nov 2018 03:56:21 -0800 (PST) Received: from [10.0.1.6] (h-155-4-130-49.NA.cust.bahnhof.se. [155.4.130.49]) by smtp.gmail.com with ESMTPSA id x16sm8139583lff.26.2018.11.24.03.56.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Nov 2018 03:56:20 -0800 (PST) From: Terje Larsen Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\)) Message-Id: Date: Sat, 24 Nov 2018 12:56:19 +0100 X-Mailer: Apple Mail (2.3445.101.1) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Sat, 24 Nov 2018 12:59:44 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) M-x auto-save-visited-mode M-: (message "%s" "hello") ... Wait 5 seconds ... Now the message buffer gets cleared and you lose the message. This is causing usability issues when using eldoc/reading some output message as it continously gets cleared. I would expect the `auto-save-visited' feature to not change the = behaviour of the Echo Area. If you compare this to the `auto-save-mode' which outputs a message indicating a save, but restores the Echo Area after. I have tracked down this to the `save-some-buffers' function or more specifically the `map-y-or-n-p' function that it calls. In this function there is a call to message like `(message "")`. In GNU Emacs 27.0.50 (build 2, x86_64-apple-darwin18.0.0, NS = appkit-1671.00 Version 10.14 (Build 18A391)) of 2018-11-07 built on C02V91MHHV2Q.local Repository revision: 811d9291fcfb12d87bad277d4e8b25152129d73d Windowing system distributor 'Apple', version 10.3.1671 System Description: Mac OS X 10.14.1 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Auto-Save-Visited mode enabled You can run the command =E2=80=98auto-save-visited-mode=E2=80=99 with = M-x au-v RET Auto-Save-Visited mode enabled hello "hello" Making completion list... [2 times] Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=3D/usr/local/share/emacs/site-lisp --infodir=3D/usr/local/Cellar/emacs/HEAD-811d929_1/share/info/emacs --prefix=3D/usr/local/Cellar/emacs/HEAD-811d929_1 --with-gnutls --without-x --with-xml2 --without-dbus --with-imagemagick --with-rsvg --with-ns --disable-ns-self-contained' Configured features: RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS LCMS2 GMP Important settings: value of $LC_ALL: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t auto-save-visited-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cus-start cus-load elec-pair tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 211301 10028) (symbols 48 20869 1) (strings 32 30416 1948) (string-bytes 1 793438) (vectors 16 35289) (vector-slots 8 725548 23404) (floats 8 47 72) (intervals 56 245 0) (buffers 992 12)) From unknown Sun Jun 22 00:28:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33490: 27.0.50; auto-save-visited-mode clears the echo area every time the save interval is hit Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Nov 2018 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Terje Larsen Cc: 33490@debbugs.gnu.org Received: via spool by 33490-submit@debbugs.gnu.org id=B33490.154308482531990 (code B ref 33490); Sat, 24 Nov 2018 18:41:02 +0000 Received: (at 33490) by debbugs.gnu.org; 24 Nov 2018 18:40:25 +0000 Received: from localhost ([127.0.0.1]:45795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQcqv-0008Js-6S for submit@debbugs.gnu.org; Sat, 24 Nov 2018 13:40:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQcqt-0008Jd-BC for 33490@debbugs.gnu.org; Sat, 24 Nov 2018 13:40:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQcqk-00026f-TT for 33490@debbugs.gnu.org; Sat, 24 Nov 2018 13:40:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQcqk-00026R-Pr; Sat, 24 Nov 2018 13:40:14 -0500 Received: from [176.228.60.248] (port=3199 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gQcqh-0000XL-UM; Sat, 24 Nov 2018 13:40:14 -0500 Date: Sat, 24 Nov 2018 20:40:04 +0200 Message-Id: <83pnuujp4r.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Terje Larsen on Sat, 24 Nov 2018 12:56:19 +0100) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Terje Larsen > Date: Sat, 24 Nov 2018 12:56:19 +0100 > > M-x auto-save-visited-mode > M-: (message "%s" "hello") > > ... Wait 5 seconds ... > > Now the message buffer gets cleared and you lose the message. This is > causing usability issues when using eldoc/reading some output message as > it continously gets cleared. > > I would expect the `auto-save-visited' feature to not change the behaviour > of the Echo Area. If you compare this to the `auto-save-mode' which > outputs a message indicating a save, but restores the Echo Area after. > > I have tracked down this to the `save-some-buffers' function or more > specifically the `map-y-or-n-p' function that it calls. In this function > there is a call to message like `(message "")`. Right. Does the patch below fix the problem? diff --git a/lisp/emacs-lisp/map-ynp.el b/lisp/emacs-lisp/map-ynp.el index 8260af5..93235bd 100644 --- a/lisp/emacs-lisp/map-ynp.el +++ b/lisp/emacs-lisp/map-ynp.el @@ -79,6 +79,7 @@ map-y-or-n-p Returns the number of actions taken." (let* ((actions 0) + (msg (current-message)) user-keys mouse-event map prompt char elt def ;; Non-nil means we should use mouse menus to ask. use-menus @@ -250,9 +251,10 @@ map-y-or-n-p (if delayed-switch-frame (setq unread-command-events (cons delayed-switch-frame unread-command-events)))) - ;; Clear the last prompt from the minibuffer. + ;; Clear the last prompt from the minibuffer, and restore the + ;; previous echo-area message, if any. (let ((message-log-max nil)) - (message "")) + (message (or msg ""))) ;; Return the number of actions that were taken. actions)) From unknown Sun Jun 22 00:28:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33490: 27.0.50; auto-save-visited-mode clears the echo area every time the save interval is hit Resent-From: Terje Larsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Nov 2018 20:27:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , 33490@debbugs.gnu.org Received: via spool by 33490-submit@debbugs.gnu.org id=B33490.15430911769090 (code B ref 33490); Sat, 24 Nov 2018 20:27:04 +0000 Received: (at 33490) by debbugs.gnu.org; 24 Nov 2018 20:26:16 +0000 Received: from localhost ([127.0.0.1]:45823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQeVM-0002MX-7F for submit@debbugs.gnu.org; Sat, 24 Nov 2018 15:26:16 -0500 Received: from mail-lj1-f171.google.com ([209.85.208.171]:37147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQeVK-0002MJ-96 for 33490@debbugs.gnu.org; Sat, 24 Nov 2018 15:26:15 -0500 Received: by mail-lj1-f171.google.com with SMTP id e5-v6so13252751lja.4 for <33490@debbugs.gnu.org>; Sat, 24 Nov 2018 12:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klarna.com; s=google; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=PIn8DdtlA0jazY4yPO6PVsXGhPxg+jRQNoFX5GB1acg=; b=UAx6NbR7vKmtQca5vIBnN65Yeq/dWvv8VazoujHKn3o0K7nSoRGMvxG6J+L4lpbi7U KD0+1oUlXOFosrHGglq7uma08KX10lGVrhC1g5znk8MM6Rq68WZyay/Syglxj7BfVtad Fg63WqWxI2rsmTdPyYEuGC7s/8eFye7Z9DJoGqlKnFTkQoSc6aUOPkOkSj9vX71rEqXh ia0wajncXzJRt9CAepjhS8mQALWmTFg+wVauk7mhHwRYB8e/CZKNAfCT3UlweZnY2gXa L4RnyM6GRBtpCFC3cWXKvH8V6vk36+pzLTKs+9/rW+US7ylUM+J0nBYjn43/OR8HoCC+ IYfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=PIn8DdtlA0jazY4yPO6PVsXGhPxg+jRQNoFX5GB1acg=; b=ZYtr32rNlDP5m5L3CIiGrgxDaEnB81e0OBNvxWRrKV4lpvPX8IESn+KAveGTNZGe8+ UBPsXhFCjgsW74Jc4+Sw2qBeYmk1IsGZZdyIG38LlSFvkJEDsogfPc05FYU5nSB6TFwQ C+xVUsFWuhpR5c+YZbYb9vMgtao5Pzld6ltyNXceELE3TZ7efabJb5d5/s9p3LWUZxUf eOcieVajH4m08Fy9CwOvux2AriZuIJLm1IHIkfBQBHA6wkaL75a1I3x0n+F1Lf3Qb7/h hMeMOfywq0CzFfyiF1+M1FPceWETt89katbxhnPpQo4ocqi2URDbrORL3rckZ7zYf4dY aRpw== X-Gm-Message-State: AGRZ1gIfThhASnERN3metQ0Z1mMGUU1JjRHB3Rc7XhdUx9zH+sdXADhH BDu4SkUs3s3v/cN941vj44cKBw== X-Google-Smtp-Source: AFSGD/WGnv2IIsCzgUJWkcBQJJpKJcci6/JQkyxs1ff8PnaWANDB9pUqVymawKgrXJLbwag5csiIIA== X-Received: by 2002:a2e:95c6:: with SMTP id y6-v6mr12720411ljh.59.1543091168250; Sat, 24 Nov 2018 12:26:08 -0800 (PST) Received: from [10.0.1.6] (h-155-4-130-49.NA.cust.bahnhof.se. [155.4.130.49]) by smtp.gmail.com with ESMTPSA id c5-v6sm8537811lja.62.2018.11.24.12.26.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Nov 2018 12:26:07 -0800 (PST) From: Terje Larsen Content-Type: multipart/alternative; boundary="Apple-Mail=_650F5D07-DC65-4670-A598-53F18C474EDB" Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\)) Date: Sat, 24 Nov 2018 21:26:06 +0100 References: <83pnuujp4r.fsf@gnu.org> In-Reply-To: <83pnuujp4r.fsf@gnu.org> Message-Id: X-Mailer: Apple Mail (2.3445.101.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_650F5D07-DC65-4670-A598-53F18C474EDB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Thank you for the quick fix, that seems to solve the issue. Applying this patch and repeating the same kind of testing procedure = produced the expected result. > On 24 Nov 2018, at 19:40, Eli Zaretskii wrote: >=20 >> From: Terje Larsen >> Date: Sat, 24 Nov 2018 12:56:19 +0100 >>=20 >> M-x auto-save-visited-mode >> M-: (message "%s" "hello") >>=20 >> ... Wait 5 seconds ... >>=20 >> Now the message buffer gets cleared and you lose the message. This is >> causing usability issues when using eldoc/reading some output message = as >> it continously gets cleared. >>=20 >> I would expect the `auto-save-visited' feature to not change the = behaviour >> of the Echo Area. If you compare this to the `auto-save-mode' which >> outputs a message indicating a save, but restores the Echo Area = after. >>=20 >> I have tracked down this to the `save-some-buffers' function or more >> specifically the `map-y-or-n-p' function that it calls. In this = function >> there is a call to message like `(message "")`. >=20 > Right. Does the patch below fix the problem? >=20 > diff --git a/lisp/emacs-lisp/map-ynp.el b/lisp/emacs-lisp/map-ynp.el > index 8260af5..93235bd 100644 > --- a/lisp/emacs-lisp/map-ynp.el > +++ b/lisp/emacs-lisp/map-ynp.el > @@ -79,6 +79,7 @@ map-y-or-n-p >=20 > Returns the number of actions taken." > (let* ((actions 0) > + (msg (current-message)) > user-keys mouse-event map prompt char elt def > ;; Non-nil means we should use mouse menus to ask. > use-menus > @@ -250,9 +251,10 @@ map-y-or-n-p > (if delayed-switch-frame > (setq unread-command-events > (cons delayed-switch-frame unread-command-events)))) > - ;; Clear the last prompt from the minibuffer. > + ;; Clear the last prompt from the minibuffer, and restore the > + ;; previous echo-area message, if any. > (let ((message-log-max nil)) > - (message "")) > + (message (or msg ""))) > ;; Return the number of actions that were taken. > actions)) --Apple-Mail=_650F5D07-DC65-4670-A598-53F18C474EDB Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Thank= you for the quick fix, that seems to solve the issue.
Applying this patch and repeating the same kind of testing = procedure produced the expected result.

On 24 = Nov 2018, at 19:40, Eli Zaretskii <eliz@gnu.org> wrote:

From: = Terje Larsen <terje.larsen@klarna.com>
Date: Sat, 24 = Nov 2018 12:56:19 +0100

M-x = auto-save-visited-mode
M-: (message "%s" "hello")

... Wait 5 seconds ...

Now the message buffer gets cleared and you lose the message. = This is
causing usability issues when using eldoc/reading = some output message as
it continously gets cleared.

I would expect the `auto-save-visited' feature = to not change the behaviour
of the Echo Area. If you = compare this to the `auto-save-mode' which
outputs a = message indicating a save, but restores the Echo Area after.

I have tracked down this to the = `save-some-buffers' function or more
specifically the = `map-y-or-n-p' function that it calls. In this function
there is a call to message like `(message "")`.

Right.  Does the patch below fix the problem?

diff --git = a/lisp/emacs-lisp/map-ynp.el b/lisp/emacs-lisp/map-ynp.el
index 8260af5..93235bd = 100644
--- = a/lisp/emacs-lisp/map-ynp.el
+++ b/lisp/emacs-lisp/map-ynp.el
@@ -79,6 +79,7 @@ = map-y-or-n-p

Returns the = number of actions taken."
  (let* ((actions 0)
+         (msg = (current-message))
=  user-keys mouse-event map = prompt char elt def
=  ;; Non-nil means we should = use mouse menus to ask.
=  use-menus
@@ -250,9 +251,10 @@ = map-y-or-n-p
      (if = delayed-switch-frame
=   (setq = unread-command-events
= (cons = delayed-switch-frame unread-command-events))))
-    ;; Clear the = last prompt from the minibuffer.
+    ;; Clear the last prompt from the = minibuffer, and restore the
+    ;; previous echo-area message, if = any.
    (let ((message-log-max = nil))
- =      (message ""))
+ =      (message (or msg "")))
    ;; = Return the number of actions that were taken.
    actions))

= --Apple-Mail=_650F5D07-DC65-4670-A598-53F18C474EDB-- From unknown Sun Jun 22 00:28:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Terje Larsen Subject: bug#33490: closed (Re: bug#33490: 27.0.50; auto-save-visited-mode clears the echo area every time the save interval is hit) Message-ID: References: <8336rniw7m.fsf@gnu.org> X-Gnu-PR-Message: they-closed 33490 X-Gnu-PR-Package: emacs Reply-To: 33490@debbugs.gnu.org Date: Mon, 26 Nov 2018 17:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1543253402-18704-1" This is a multi-part message in MIME format... ------------=_1543253402-18704-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33490: 27.0.50; auto-save-visited-mode clears the echo area every time the= save interval is hit which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33490@debbugs.gnu.org. --=20 33490: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33490 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1543253402-18704-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33490-done) by debbugs.gnu.org; 26 Nov 2018 17:29:23 +0000 Received: from localhost ([127.0.0.1]:50066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRKhH-0004qT-09 for submit@debbugs.gnu.org; Mon, 26 Nov 2018 12:29:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRKhF-0004qH-9F for 33490-done@debbugs.gnu.org; Mon, 26 Nov 2018 12:29:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRKh6-0002vH-3o for 33490-done@debbugs.gnu.org; Mon, 26 Nov 2018 12:29:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRKh6-0002vB-0E; Mon, 26 Nov 2018 12:29:12 -0500 Received: from [176.228.60.248] (port=1879 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRKh5-00035M-Fk; Mon, 26 Nov 2018 12:29:11 -0500 Date: Mon, 26 Nov 2018 19:29:17 +0200 Message-Id: <8336rniw7m.fsf@gnu.org> From: Eli Zaretskii To: Terje Larsen In-reply-to: (message from Terje Larsen on Sat, 24 Nov 2018 21:26:06 +0100) Subject: Re: bug#33490: 27.0.50; auto-save-visited-mode clears the echo area every time the save interval is hit References: <83pnuujp4r.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33490-done Cc: 33490-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Terje Larsen > Date: Sat, 24 Nov 2018 21:26:06 +0100 > > Thank you for the quick fix, that seems to solve the issue. > Applying this patch and repeating the same kind of testing procedure produced the expected result. Thanks, pushed to the emacs-26 branch. ------------=_1543253402-18704-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Nov 2018 17:59:46 +0000 Received: from localhost ([127.0.0.1]:45784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQcDZ-0007Jp-KD for submit@debbugs.gnu.org; Sat, 24 Nov 2018 12:59:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQWYE-0004gk-22 for submit@debbugs.gnu.org; Sat, 24 Nov 2018 06:56:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQWY7-0005hy-Tz for submit@debbugs.gnu.org; Sat, 24 Nov 2018 06:56:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gQWY7-0005hd-RD for submit@debbugs.gnu.org; Sat, 24 Nov 2018 06:56:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQWY6-0002Dn-O2 for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 06:56:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQWY2-0005bf-2j for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 06:56:34 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:39470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQWY1-0005TP-OW for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 06:56:30 -0500 Received: by mail-lf1-x12e.google.com with SMTP id n18so10314492lfh.6 for ; Sat, 24 Nov 2018 03:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klarna.com; s=google; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=xAvH6yHsEKTL8Y6FlCAwVJNHDF1RtyIIF3ggTPsX7oQ=; b=VooUB5FzciTqnckSH1gDET5kHbMBH6FRcp/uAullO4dettsGwIM1ec6WZLjsSz4WF3 AWUpEzpFyzf8FQNeQwGNH6V7hRbmWsiTVwPfvY3WKLq0ZoQSKtd+JF5amjDPGlVsBI4g W9llRLIm/6J6AIyePjBiOayhdyKuZA0Pqg9Tv7mreN46z1/Xya3+S1Vluo3byCZYvb3N NXLyqxMPyqcVu8EbsTKeABlus1fX2BdIA3Ilf4sRqtGs7F4rmtse/ygPgOnhLaFO1T7T au3AKrueBk3cBFn9iVovwwOm/5Od+QC0Pok32ZwHukdkyFgC7a6o/ySWqGsEb+XoIe0E QARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=xAvH6yHsEKTL8Y6FlCAwVJNHDF1RtyIIF3ggTPsX7oQ=; b=TbcizP42jRHHcNY7y2QrX7KpNFWfw2FCTgkQ3bJI72sPg5wsSOBu8wAm7M1V2QuH0/ qBZDId/l7MwfdpU3B2dre5xZOIOhSVTK1JXMaFXUy44YI8I78rqvA3xgXN3ruI4lbsyY d46UBneDHqFzdlzzH0LgXtMpn41WF8oOmxlUwTgAKNtix2p8Ojgck+LgaSLsZrgM8koR rW/eIpXypl2SOVuNzvjbMQ5OH8rLlxmgOYY26emEBLu748QG83j1BWNS7ou/3WIXFtNU w9mkAS49j7ROtT3wpxhKcO3QmhWS9rcCZnqHd6Lp3GOhvhCfN6BVmIsFgff5vxzIRSky Y2Xw== X-Gm-Message-State: AGRZ1gKEwgbOuwpumlgWoPoe/FarjlRFBIepBofHTk21j5BAgsja5jR3 wyIozAgASNlaJovUTCDmnrKb+7HLlQY= X-Google-Smtp-Source: AJdET5c/MLZvJRSY2WHG/WezFqDCMU0OXUbl9OtTPZbie7sItNvSYn3UnkzfKncHYZKOeJNPxR3P+g== X-Received: by 2002:a19:6f0a:: with SMTP id k10mr11150312lfc.119.1543060581425; Sat, 24 Nov 2018 03:56:21 -0800 (PST) Received: from [10.0.1.6] (h-155-4-130-49.NA.cust.bahnhof.se. [155.4.130.49]) by smtp.gmail.com with ESMTPSA id x16sm8139583lff.26.2018.11.24.03.56.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Nov 2018 03:56:20 -0800 (PST) From: Terje Larsen Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\)) Subject: 27.0.50; auto-save-visited-mode clears the echo area every time the save interval is hit Message-Id: Date: Sat, 24 Nov 2018 12:56:19 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.101.1) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 24 Nov 2018 12:59:44 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) M-x auto-save-visited-mode M-: (message "%s" "hello") ... Wait 5 seconds ... Now the message buffer gets cleared and you lose the message. This is causing usability issues when using eldoc/reading some output message as it continously gets cleared. I would expect the `auto-save-visited' feature to not change the = behaviour of the Echo Area. If you compare this to the `auto-save-mode' which outputs a message indicating a save, but restores the Echo Area after. I have tracked down this to the `save-some-buffers' function or more specifically the `map-y-or-n-p' function that it calls. In this function there is a call to message like `(message "")`. In GNU Emacs 27.0.50 (build 2, x86_64-apple-darwin18.0.0, NS = appkit-1671.00 Version 10.14 (Build 18A391)) of 2018-11-07 built on C02V91MHHV2Q.local Repository revision: 811d9291fcfb12d87bad277d4e8b25152129d73d Windowing system distributor 'Apple', version 10.3.1671 System Description: Mac OS X 10.14.1 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Auto-Save-Visited mode enabled You can run the command =E2=80=98auto-save-visited-mode=E2=80=99 with = M-x au-v RET Auto-Save-Visited mode enabled hello "hello" Making completion list... [2 times] Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=3D/usr/local/share/emacs/site-lisp --infodir=3D/usr/local/Cellar/emacs/HEAD-811d929_1/share/info/emacs --prefix=3D/usr/local/Cellar/emacs/HEAD-811d929_1 --with-gnutls --without-x --with-xml2 --without-dbus --with-imagemagick --with-rsvg --with-ns --disable-ns-self-contained' Configured features: RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS LCMS2 GMP Important settings: value of $LC_ALL: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t auto-save-visited-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cus-start cus-load elec-pair tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 211301 10028) (symbols 48 20869 1) (strings 32 30416 1948) (string-bytes 1 793438) (vectors 16 35289) (vector-slots 8 725548 23404) (floats 8 47 72) (intervals 56 245 0) (buffers 992 12)) ------------=_1543253402-18704-1--