From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 21 18:26:46 2018 Received: (at submit) by debbugs.gnu.org; 21 Nov 2018 23:26:46 +0000 Received: from localhost ([127.0.0.1]:40340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbtO-0005yZ-Gg for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:26:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbd8-0005V4-8w for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:09:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbd1-0004zq-LU for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:09:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPbd1-0004yh-A8 for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:09:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbcz-0000Gu-Ux for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:09:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbcw-0004sC-MD for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:09:49 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:45775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPbcs-0004jX-Sh for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:09:45 -0500 Received: by mail-pl1-f196.google.com with SMTP id a14so7530918plm.12 for ; Wed, 21 Nov 2018 15:09:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aovTCD6wwgNbb6IdHWOOcleF5MqOMn4eWCOM6+x5b9c=; b=E+RA6hspOfNczNMpczxsG763mcVxsAktur67L5jz6i/kbGM5ApLBkTAnOZP1Sntpxk r4JhOI0qT92wSLrQHiLFJQLohU4NZvWQHzP4gkPCXDIFeuzPRXUiQwVf7mm39oixXPw3 Q6nNI04uFxOHtgzFyifpt44JStCQMBkEzzF3k9NHhbSC+zViph9h0DY/qjhnJ1s4Jkac YVjYHcasgpaEhNGDDDeIi60aUza94Fr+Fqw8pxA/Dun0cyJ+pIcgwkI5ygdkaSWcE/pO eWGWzHqonjjJCcS/HKaT3PtY3asC1ubabYvHLmB3An+gRS7FbOEOC36sXwy/YmFYql5+ z2TA== X-Gm-Message-State: AA+aEWZKNqS0NVaCm9yTUryfWimMb2S7juDokF6eirPV1Z5rxQm6lKBt hT3pLmx9uNOf2ogFhD528Jk9oe60KtyJeNWQFR5Brg== X-Google-Smtp-Source: AFSGD/UUUZfGO0786GTu9EuqiDSEmoMMr3U/HYbBT0i36PxrjYjWtcEWsik81kECm8hWb/9K7pdiD0yf48jh3h3ytC4= X-Received: by 2002:a17:902:f81:: with SMTP id 1mr2020867plz.174.1542841772190; Wed, 21 Nov 2018 15:09:32 -0800 (PST) MIME-Version: 1.0 From: Philip Hudson Date: Wed, 21 Nov 2018 23:09:16 +0000 Message-ID: Subject: 24.4; Eshell histfile symlinks not followed To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000c6ddae057b34d755" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 21 Nov 2018 18:26:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) --000000000000c6ddae057b34d755 Content-Type: text/plain; charset="UTF-8" If the file named by the value of option `eshell-history-file-name' is a symbolic link, then it will be replaced and overwritten instead. It should be dereferenced (followed) first, and its target file should be replaced and overwritten. The attached patch uses function `file-truename' to fix this. The patch was made using source cloned from git savannah HEAD today, which I think is version 26.1.90, based on ChangeLog.3 in the cloned repo. In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5) of 2017-09-12 on hullmann, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.11604000 System Description: LMDE 2 Betsy -- Phil Hudson http://hudson-it.ddns.net Pretty Good Privacy (PGP) ID: 0x4E482F85 --000000000000c6ddae057b34d755 Content-Type: text/x-patch; charset="US-ASCII"; name="eshellResolveHistFile.patch" Content-Disposition: attachment; filename="eshellResolveHistFile.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jors4rdx0 ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwgYi9saXNwL2VzaGVsbC9lbS1oaXN0 LmVsCmluZGV4IDYyZTJmNTcuLmY4NjZkZmQgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWhp c3QuZWwKKysrIGIvbGlzcC9lc2hlbGwvZW0taGlzdC5lbApAQCAtNDY2LDE1ICs0NjYsMTYgQEAg bG9zdCBpZiBgZXNoZWxsLWhpc3RvcnktcmluZycgaXMgbm90IGVtcHR5LiAgSWYKIFVzZWZ1bCB3 aXRoaW4gcHJvY2VzcyBzZW50aW5lbHMuCiAKIFNlZSBhbHNvIGBlc2hlbGwtcmVhZC1oaXN0b3J5 Jy4iCi0gIChsZXQgKChmaWxlIChvciBmaWxlbmFtZSBlc2hlbGwtaGlzdG9yeS1maWxlLW5hbWUp KSkKKyAgKGxldCogKChmaWxlIChvciBmaWxlbmFtZSBlc2hlbGwtaGlzdG9yeS1maWxlLW5hbWUp KQorCSAocmVzb2x2ZWQtZmlsZSAoZmlsZS10cnVlbmFtZSBmaWxlKSkpCiAgICAgKGNvbmQKICAg ICAgKChvciAobnVsbCBmaWxlKQogCSAgKGVxdWFsIGZpbGUgIiIpCiAJICAobnVsbCBlc2hlbGwt aGlzdG9yeS1yaW5nKQogCSAgKHJpbmctZW1wdHktcCBlc2hlbGwtaGlzdG9yeS1yaW5nKSkKICAg ICAgIG5pbCkKLSAgICAgKChub3QgKGZpbGUtd3JpdGFibGUtcCBmaWxlKSkKLSAgICAgIChtZXNz YWdlICJDYW5ub3Qgd3JpdGUgaGlzdG9yeSBmaWxlICVzIiBmaWxlKSkKKyAgICAgKChub3QgKGZp bGUtd3JpdGFibGUtcCByZXNvbHZlZC1maWxlKSkKKyAgICAgIChtZXNzYWdlICJDYW5ub3Qgd3Jp dGUgaGlzdG9yeSBmaWxlICVzIiByZXNvbHZlZC1maWxlKSkKICAgICAgKHQKICAgICAgIChsZXQq ICgocmluZyBlc2hlbGwtaGlzdG9yeS1yaW5nKQogCSAgICAgKGluZGV4IChyaW5nLWxlbmd0aCBy aW5nKSkpCkBAIC00ODksNyArNDkwLDcgQEAgU2VlIGFsc28gYGVzaGVsbC1yZWFkLWhpc3Rvcnkn LiIKICAgICAgICAgICAgICAgKGluc2VydCAoc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMgKHJpbmct cmVmIHJpbmcgaW5kZXgpKSA/XG4pCiAJICAgICAgKHN1YnN0LWNoYXItaW4tcmVnaW9uIHN0YXJ0 ICgxLSAocG9pbnQpKSA/XG4gP1wxNzcpKSkKIAkgIChlc2hlbGwtd2l0aC1wcml2YXRlLWZpbGUt bW9kZXMKLQkgICAod3JpdGUtcmVnaW9uIChwb2ludC1taW4pIChwb2ludC1tYXgpIGZpbGUgYXBw ZW5kCisJICAgKHdyaXRlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSByZXNvbHZlZC1m aWxlIGFwcGVuZAogCQkJICduby1tZXNzYWdlKSkpKSkpKSkKIAogKGRlZnVuIGVzaGVsbC1saXN0 LWhpc3RvcnkgKCkK --000000000000c6ddae057b34d755-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 04:15:56 2018 Received: (at 33460-done) by debbugs.gnu.org; 8 Dec 2018 09:15:56 +0000 Received: from localhost ([127.0.0.1]:37615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVYiK-0005ik-84 for submit@debbugs.gnu.org; Sat, 08 Dec 2018 04:15:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVYiI-0005iT-PX for 33460-done@debbugs.gnu.org; Sat, 08 Dec 2018 04:15:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVYiA-0003yY-F5 for 33460-done@debbugs.gnu.org; Sat, 08 Dec 2018 04:15:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVYiA-0003yU-BP; Sat, 08 Dec 2018 04:15:46 -0500 Received: from [176.228.60.248] (port=3915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gVYi9-0000D9-UV; Sat, 08 Dec 2018 04:15:46 -0500 Date: Sat, 08 Dec 2018 11:15:27 +0200 Message-Id: <834lbo5qhc.fsf@gnu.org> From: Eli Zaretskii To: Philip Hudson In-reply-to: (message from Philip Hudson on Wed, 21 Nov 2018 23:09:16 +0000) Subject: Re: bug#33460: 24.4; Eshell histfile symlinks not followed References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33460-done Cc: 33460-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Philip Hudson > Date: Wed, 21 Nov 2018 23:09:16 +0000 > > If the file named by the value of option `eshell-history-file-name' is > a symbolic link, then it will be replaced and overwritten instead. It > should be dereferenced (followed) first, and its target file should be > replaced and overwritten. > > The attached patch uses function `file-truename' to fix this. The > patch was made using source cloned from git savannah HEAD today, which > I think is version 26.1.90, based on ChangeLog.3 in the cloned repo. Thanks, pushed to the master branch, to appear in Emacs 27.1. Please in the future provide a ChangeLog-style commit log entry for your changes; see CONTRIBUTE for the details. Also, user-visible behavior changes need to be called out in NEWS, and if necessary also in the relevant Texinfo manual(s). From unknown Sat Sep 06 02:32:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Jan 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator