GNU bug report logs - #33452
Color of tooltip text on macOS with mark mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33452 in the body.
You can then email your comments to 33452 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: Color of tooltip text on macOS with mark mode
Date: Wed, 21 Nov 2018 16:30:56 +0900 (JST)

When Emacs 26.1.90 is launched on macOS with dark mode, color of
tooltip text is set to white. It is hard to read the text.

 Switch to dark-mode on macOS
 $ cd ~/emacs-26.1.90/
 $ ./configure; make install
 $ ~/emacs-26.1.90/nextstep/Emacs.app/Contents/MacOS/Emacs -Q
 M-: (setq mouse-drag-and-drop-region 'meta)

During dragging region, tooltip shows text in the region.  Color of
tooltip background is yellow, and color of tooltip text is white.

I think that color of either tooltip text or tooltip background should
be darker.

Message #8 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
Cc: 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with mark mode
Date: Wed, 21 Nov 2018 11:30:31 +0200

> Date: Wed, 21 Nov 2018 16:30:56 +0900 (JST)
> From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
> 
> When Emacs 26.1.90 is launched on macOS with dark mode, color of
> tooltip text is set to white. It is hard to read the text.

Is this problem new with Emacs 26.1.90?

Thanks.

Message #11 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
To: eliz <at> gnu.org
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Wed, 21 Nov 2018 19:14:35 +0900 (JST)

>> When Emacs 26.1.90 is launched on macOS with dark mode, color of
>> tooltip text is set to white. It is hard to read the text.
> 
> Is this problem new with Emacs 26.1.90?

I do not see the problem in 27.0.50.

Message #14 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
Cc: 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Wed, 21 Nov 2018 12:32:10 +0200

> Date: Wed, 21 Nov 2018 19:14:35 +0900 (JST)
> Cc: 33452 <at> debbugs.gnu.org, tkk <at> misasa.okayama-u.ac.jp
> From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
> 
> >> When Emacs 26.1.90 is launched on macOS with dark mode, color of
> >> tooltip text is set to white. It is hard to read the text.
> > 
> > Is this problem new with Emacs 26.1.90?
> 
> I do not see the problem in 27.0.50.

Can you test with Emacs 26.1?

In any case, it sounds like the problem, whatever it is, was solved on
master.

Message #17 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Wed, 21 Nov 2018 19:44:58 +0000

On Wed, Nov 21, 2018 at 12:32:10PM +0200, Eli Zaretskii wrote:
> > Date: Wed, 21 Nov 2018 19:14:35 +0900 (JST)
> > Cc: 33452 <at> debbugs.gnu.org, tkk <at> misasa.okayama-u.ac.jp
> > From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
> > 
> > >> When Emacs 26.1.90 is launched on macOS with dark mode, color of
> > >> tooltip text is set to white. It is hard to read the text.
> > > 
> > > Is this problem new with Emacs 26.1.90?
> > 
> > I do not see the problem in 27.0.50.
> 
> Can you test with Emacs 26.1?
> 
> In any case, it sounds like the problem, whatever it is, was solved on
> master.

I expect it was commit 15cd18991c1d9a9bafeef7bf9b4dad91ecc0332a.

It’s pretty small and is probably safe to backport to emacs-26.
-- 
Alan Third

Message #20 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
To: alan <at> idiocy.org
Cc: eliz <at> gnu.org, tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Thu, 22 Nov 2018 21:44:04 +0900 (JST)

>>>>> When Emacs 26.1.90 is launched on macOS with dark mode, color of
>>>>> tooltip text is set to white. It is hard to read the text.
>>>> 
>>>> Is this problem new with Emacs 26.1.90?
>>> 
>>> I do not see the problem in 27.0.50.
>> 
>> Can you test with Emacs 26.1?

Emacs 26.1 build on macOS Mojave (10.14) cannot show text even on
scratch buffer.  I cannot test Emacs 26.1 build under macOS Mojave
(10.14).

>> In any case, it sounds like the problem, whatever it is, was solved on
>> master.
> 
> I expect it was commit 15cd18991c1d9a9bafeef7bf9b4dad91ecc0332a.n
> 
> It’s pretty small and is probably safe to backport to emacs-26.

I applied the commit 15cd18991c1d9a9bafeef7bf9b4dad91ecc0332a to
26.1.90 and confirmed that I do not see the problem.

Message #23 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Fri, 23 Nov 2018 12:29:53 +0200

> Date: Wed, 21 Nov 2018 19:44:58 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>, 33452 <at> debbugs.gnu.org
> 
> I expect it was commit 15cd18991c1d9a9bafeef7bf9b4dad91ecc0332a.

Are you saying that tooltips on NS couldn't use colors before that
change?  Or was that color support broken at some point?  If the
latter, when was it broken and by what changeset?

Thanks.

Message #26 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Fri, 23 Nov 2018 18:10:49 +0000

On Fri, Nov 23, 2018 at 12:29:53PM +0200, Eli Zaretskii wrote:
> > Date: Wed, 21 Nov 2018 19:44:58 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>, 33452 <at> debbugs.gnu.org
> > 
> > I expect it was commit 15cd18991c1d9a9bafeef7bf9b4dad91ecc0332a.
> 
> Are you saying that tooltips on NS couldn't use colors before that
> change?  Or was that color support broken at some point?  If the
> latter, when was it broken and by what changeset?

Tooltips on NS couldn’t use colours before that change.

What happened is that tooltips set the background to yellow and left
the foreground (text) to be the system default (black).

MacOS Mojave has introduced ‘dark mode’, which makes the foreground
colour light, and therefore we’re seeing light text on a yellow
background.

If you don’t want to apply the above commit the absolute minimum fix
for emacs-26 would be to explicitly set a foreground colour for
tooltips, or not set the background, therefore reverting to the system
default.

-- 
Alan Third

Message #29 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Fri, 23 Nov 2018 22:13:40 +0200

> Date: Fri, 23 Nov 2018 18:10:49 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
> 
> > Are you saying that tooltips on NS couldn't use colors before that
> > change?  Or was that color support broken at some point?  If the
> > latter, when was it broken and by what changeset?
> 
> Tooltips on NS couldn’t use colours before that change.
> 
> What happened is that tooltips set the background to yellow and left
> the foreground (text) to be the system default (black).
> 
> MacOS Mojave has introduced ‘dark mode’, which makes the foreground
> colour light, and therefore we’re seeing light text on a yellow
> background.
> 
> If you don’t want to apply the above commit the absolute minimum fix
> for emacs-26 would be to explicitly set a foreground colour for
> tooltips, or not set the background, therefore reverting to the system
> default.

Sorry, I'm confused: does "system default" mean the tooltips will be
without colors, or does it mean they will use the system colors?  If
the latter, then why did you say in the beginning that "tooltips on NS
couldn't use colors"?

Message #32 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Fri, 23 Nov 2018 20:38:51 +0000

On Fri, Nov 23, 2018 at 10:13:40PM +0200, Eli Zaretskii wrote:
> > Date: Fri, 23 Nov 2018 18:10:49 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
> > 
> > > Are you saying that tooltips on NS couldn't use colors before that
> > > change?  Or was that color support broken at some point?  If the
> > > latter, when was it broken and by what changeset?
> > 
> > Tooltips on NS couldn’t use colours before that change.
> > 
> > What happened is that tooltips set the background to yellow and left
> > the foreground (text) to be the system default (black).
> > 
> > MacOS Mojave has introduced ‘dark mode’, which makes the foreground
> > colour light, and therefore we’re seeing light text on a yellow
> > background.
> > 
> > If you don’t want to apply the above commit the absolute minimum fix
> > for emacs-26 would be to explicitly set a foreground colour for
> > tooltips, or not set the background, therefore reverting to the system
> > default.
> 
> Sorry, I'm confused: does "system default" mean the tooltips will be
> without colors, or does it mean they will use the system colors?  If
> the latter, then why did you say in the beginning that "tooltips on NS
> couldn't use colors"?

Sorry, I thought you were meaning colours as set by Emacs lisp.

We can set the foreground and background to anything we want in C, but
in emacs-26 currently we can’t modify them by Emacs lisp, and only the
background colour is being set in C, which leaves the foreground to
use whatever the system default is.

The master branch honours the colours set by lisp.

A little more background, which hopefully won’t confuse things more:

NS tooltips are very basic, whoever wrote the tooltips for Emacs under
NS decided to use a full toolkit window instead, and just colour it
like the default Emacs tooltips on X. Except they only did half the
job, which wasn’t a problem until Apple decided to change the default
colours.
-- 
Alan Third

Message #35 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Fri, 23 Nov 2018 23:08:18 +0200

> Date: Fri, 23 Nov 2018 20:38:51 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
> 
> Sorry, I thought you were meaning colours as set by Emacs lisp.
> 
> We can set the foreground and background to anything we want in C, but
> in emacs-26 currently we can’t modify them by Emacs lisp, and only the
> background colour is being set in C, which leaves the foreground to
> use whatever the system default is.
> 
> The master branch honours the colours set by lisp.

Thanks.  So what are out alternatives for emacs-26, besides
backporting from master (which will give control on colors to Lisp)?

Message #38 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Sat, 24 Nov 2018 09:35:25 +0000

[Message part 1 (text/plain, inline)]

On Fri, Nov 23, 2018 at 11:08:18PM +0200, Eli Zaretskii wrote:
> > Date: Fri, 23 Nov 2018 20:38:51 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
> > 
> > Sorry, I thought you were meaning colours as set by Emacs lisp.
> > 
> > We can set the foreground and background to anything we want in C, but
> > in emacs-26 currently we can’t modify them by Emacs lisp, and only the
> > background colour is being set in C, which leaves the foreground to
> > use whatever the system default is.
> > 
> > The master branch honours the colours set by lisp.
> 
> Thanks.  So what are out alternatives for emacs-26, besides
> backporting from master (which will give control on colors to Lisp)?

We can try to use the system tooltip colours, but I think we’re better
off just setting a foreground colour. Patch attached.
-- 
Alan Third

[0001-Set-tooltip-text-color-bug-33452.patch (text/plain, attachment)]

Message #41 received at 33452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Sat, 24 Nov 2018 11:44:35 +0200

> Date: Sat, 24 Nov 2018 09:35:25 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: tkk <at> misasa.okayama-u.ac.jp, 33452 <at> debbugs.gnu.org
> 
> We can try to use the system tooltip colours, but I think we’re better
> off just setting a foreground colour. Patch attached.

OK, thanks.

Message #46 received at 33452-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tkk <at> misasa.okayama-u.ac.jp, 33452-done <at> debbugs.gnu.org
Subject: Re: bug#33452: Color of tooltip text on macOS with dark mode
Date: Sun, 25 Nov 2018 11:36:01 +0000

On Sat, Nov 24, 2018 at 09:35:25AM +0000, Alan Third wrote:
> On Fri, Nov 23, 2018 at 11:08:18PM +0200, Eli Zaretskii wrote:
> > Thanks.  So what are out alternatives for emacs-26, besides
> > backporting from master (which will give control on colors to Lisp)?
> 
> We can try to use the system tooltip colours, but I think we’re better
> off just setting a foreground colour. Patch attached.

Pushed to emacs-26.
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.