From unknown Fri Jun 20 07:09:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33446 <33446@debbugs.gnu.org> To: bug#33446 <33446@debbugs.gnu.org> Subject: Status: 26; `isearch-lazy-highlight-update' in MASTER today Reply-To: bug#33446 <33446@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:09:36 +0000 retitle 33446 26; `isearch-lazy-highlight-update' in MASTER today reassign 33446 emacs submitter 33446 Drew Adams severity 33446 minor tag 33446 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 20 14:47:55 2018 Received: (at submit) by debbugs.gnu.org; 20 Nov 2018 19:47:55 +0000 Received: from localhost ([127.0.0.1]:37412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPC02-0006fN-Lp for submit@debbugs.gnu.org; Tue, 20 Nov 2018 14:47:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPC00-0006ah-RD for submit@debbugs.gnu.org; Tue, 20 Nov 2018 14:47:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPBzt-00006J-Rr for submit@debbugs.gnu.org; Tue, 20 Nov 2018 14:47:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPBzt-00005E-Iy for submit@debbugs.gnu.org; Tue, 20 Nov 2018 14:47:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPBzs-0007ay-Cv for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:47:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPBzo-0008S0-8I for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:47:44 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:43272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPBzm-0008PI-8G for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2018 14:47:40 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAKJipoH016811; Tue, 20 Nov 2018 19:47:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=XctGWbNnxKSoTiE70TXqeNq6lSGzGKYNA0CEO9IcYMQ=; b=QyLDWODLPpKnqM9ZOkud97gQvo/qYwja8Fczs1zSqdg6axTawNlDa3orLBx20bfvLRto aa3nuC9rL22WCAKgi1j6FKFLwrQ01WsV2a3jZIQ5I3o/yOKf3Qqelw7qVTGJhh/CDwK1 avHbmlAEN14a39y9vj7iHs9AB0LukQ+7RmPlRz70RBv2MnPiWqyST248sblgW6cZr1/C MA24nfl7BLj9S6GCZ4gNEIeHG5QmFfgbOHoMc9ZvQufrVJ9qSmkqxd9b8K1mPdyYLnZn EIrP7ZI3iI80aYB+G+SmhtNhBx/e73Dk08AGk5y2Bmfp3Pydo5U5a/B5KEI+W920XYHV uQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2ntbmqnsy2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Nov 2018 19:47:31 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAKJlVxx010394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Nov 2018 19:47:31 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAKJlUSd017127; Tue, 20 Nov 2018 19:47:30 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 20 Nov 2018 11:47:29 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26; `isearch-lazy-highlight-update' in MASTER today X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9083 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811200173 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I ran into this bug today using my setup, which reflects the code for `isearch-lazy-highlight-update' that was added recently to isearch.el. Dunno why or how, but for some reason I got in a situation where `isearch-lazy-highlight-window' is live and is not the selected window. In fact it is in a different frame. And there is no lazy-highlighting showing there and no search in progress there. I'm willing to guess that this is not a normal situation that I got myself into. ;-) But I think there is nevertheless a bug somewhere in the Isearch code. The `isearch-lazy-highlight-update' code does this: (save-selected-window (if (and (window-live-p isearch-lazy-highlight-window) (not (memq (selected-window) isearch-lazy-highlight-window-group))) (select-window isearch-lazy-highlight-window)) That causes the window in the other frame to be selected. It's not there that I wanted to do `isearch-lazy-highlight-update'. If there is no lazy highlighting to be updated in the selected window then I'd expect that `isearch-lazy-highlight-update' would in that case be a no-op. Why do we move to another window to do it, even if for some reason `isearch-lazy-highlight-window' is non-nil? (I don't know why it is non-nil in my case.) The code then does this: (setq window-start (window-group-start)) (setq window-end (window-group-end)) This causes `window-end' to be nil. Should `window-group-*' here be passed window `isearch-lazy-highlight-window'? In any case, then the code does this: (save-excursion (save-match-data (goto-char (if isearch-lazy-highlight-forward isearch-lazy-highlight-end isearch-lazy-highlight-start)) (while looping (let* ((bound (if isearch-lazy-highlight-forward (min (or isearch-lazy-highlight-end-limit (point-max)) (if isearch-lazy-highlight-wrapped isearch-lazy-highlight-start window-end)) (max (or isearch-lazy-highlight-start-limit (point-min)) (if isearch-lazy-highlight-wrapped isearch-lazy-highlight-end window-start)))) and that raises an error because `window-end' is nil. Dunno what the right fix is. Definitely min and max should not be called if one of their args is nil. What should be done in this case? And I wonder, even if that error gets prevented, why we should update lazy highlighting on a window other than the selected one? Is that TRT? In this case, at least, that other window has nothing to do with the action in question (my code that calls `isearch-lazy-highlight-update'), and there is no search in progress in that other window and no lazy-highlighting (e.g. overlay) showing there. In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.16299 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 20 16:11:01 2018 Received: (at 33446) by debbugs.gnu.org; 20 Nov 2018 21:11:01 +0000 Received: from localhost ([127.0.0.1]:37476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPDIS-0000eo-PJ for submit@debbugs.gnu.org; Tue, 20 Nov 2018 16:11:00 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:42062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPDIQ-0000eU-GN for 33446@debbugs.gnu.org; Tue, 20 Nov 2018 16:10:58 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAKL9K05081462; Tue, 20 Nov 2018 21:10:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=N5Cj4FOB9RFq2fa8kWb+F6M8MVk7XQG/RrrOejPJNqE=; b=les316sQc/bjtwg8KeroTaDC6MidwdJH299psAtITe6clwha5JReuKRxHgnfXF4Q016u ljZGJDkA9EUkimeFZ++AdTcUdPLOHK2bU4kYxqVk8Bf9f6ws5R4fsix4Ci/i/RWjYdCZ RZuw611drthPhVmJQRzCsURX/cBsmhWmBD17383YdxGoXX15YZUITt6lZDhXlabr9K8m 0it1AMqCOpwC0xip4dMM7rBsiUwhmluxGjSglWmcQerYFAevKYaRG4MTrJkCytMxbYIF 9D2g0Shjez6E/kBo7GLFJ9j+8WnzSFQkA9Rmu/cSbt2+KnIyuPfd71D74rowjm17hAhh fg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2ntbmqp4d0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Nov 2018 21:10:52 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAKLApmN026523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Nov 2018 21:10:52 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAKLApK2032274; Tue, 20 Nov 2018 21:10:51 GMT MIME-Version: 1.0 Message-ID: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> Date: Tue, 20 Nov 2018 13:10:50 -0800 (PST) From: Drew Adams To: 33446@debbugs.gnu.org Subject: RE: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9083 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=301 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811200185 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33446 Cc: Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The proximate cause of the error was likely due to my calling `isearch-lazy-highlight-update' outside searching (i.e., nil `isearch-mode'). But I think there might still be a bug in the Isearch code. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 20 18:15:36 2018 Received: (at 33446) by debbugs.gnu.org; 20 Nov 2018 23:15:36 +0000 Received: from localhost ([127.0.0.1]:37553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFF2-0003r9-DC for submit@debbugs.gnu.org; Tue, 20 Nov 2018 18:15:36 -0500 Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:27647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFF1-0003r0-56 for 33446@debbugs.gnu.org; Tue, 20 Nov 2018 18:15:35 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1A989680C30; Tue, 20 Nov 2018 23:15:34 +0000 (UTC) Received: from pdx1-sub0-mail-a37.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id DB9C6680C51; Tue, 20 Nov 2018 23:15:33 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 20 Nov 2018 23:15:34 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Broad-Coil: 0b0618776b791ee0_1542755733980_154849828 X-MC-Loop-Signature: 1542755733980:2242352055 X-MC-Ingress-Time: 1542755733979 Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id A2776808BC; Tue, 20 Nov 2018 15:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=fwyHO6dzOlSEjL4rC3dBVtA3FCY=; b= uLCudgd94kdm9Jgt13ARsrClOpa1npY0Nz0xDWONkiUAU86smVpMkbAcTGoDLgTt vVbFWAPB32I5sZZYO50HFk9n3lrh2tR++axRu4ZqAaAy1im9H1rBrB9N8IHZoCey 8TtC+8OrIaQxbSCidlkp1+4RN2lN3rypMCY558Fy9FM= Received: from mail.jurta.org (m91-129-105-252.cust.tele2.ee [91.129.105.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id 3D052808AD; Tue, 20 Nov 2018 15:15:31 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a37 From: Juri Linkov To: Drew Adams Subject: Re: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today Organization: LINKOV.NET References: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> Date: Wed, 21 Nov 2018 01:14:12 +0200 In-Reply-To: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> (Drew Adams's message of "Tue, 20 Nov 2018 13:10:50 -0800 (PST)") Message-ID: <87h8gb5owm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddtiedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrddvhedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrvdehvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33446 Cc: 33446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The proximate cause of the error was likely due to > my calling `isearch-lazy-highlight-update' outside > searching (i.e., nil `isearch-mode'). But I think > there might still be a bug in the Isearch code. isearch-lazy-highlight-update is not intended to be used in a window other than the window where isearch-lazy-highlight-new-loop was called. It has many dependencies on the original window being selected. > The `isearch-lazy-highlight-update' code does this: > > (save-selected-window > (if (and (window-live-p isearch-lazy-highlight-window) > (not (memq (selected-window) > isearch-lazy-highlight-window-group))) > (select-window isearch-lazy-highlight-window)) > > That causes the window in the other frame to be selected. It should select the same window where isearch-lazy-highlight-new-loop was called. > The code then does this: > > (setq window-start (window-group-start)) > (setq window-end (window-group-end)) > > This causes `window-end' to be nil. Should `window-group-*' here > be passed window `isearch-lazy-highlight-window'? isearch-lazy-highlight-window should not be passed here because it's guaranteed to be selected by the code above. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 20 18:48:07 2018 Received: (at 33446) by debbugs.gnu.org; 20 Nov 2018 23:48:07 +0000 Received: from localhost ([127.0.0.1]:37578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFkU-0004d0-TJ for submit@debbugs.gnu.org; Tue, 20 Nov 2018 18:48:07 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:49474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPFkT-0004cX-R3 for 33446@debbugs.gnu.org; Tue, 20 Nov 2018 18:48:06 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAKNhfn6190109; Tue, 20 Nov 2018 23:47:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=y9q5rayAuHpt92e6vRgXiHNpwISp0oBIBFPXVe6rN4E=; b=IhTpphhskUjw4ElBboo0EzYXUfGIGCW4/pwxNehLJU+qyBBLY8jmNakchdM3DVlhlHPr AAxyVV6j8gjh7qWvzbO69ZS5jj7/HIcD7CqfnNi5Ast+S5NA7mRARpJfoNafoJ2d2Imm n+qK8y/5TXwh6kkZl0LqnSF7AKHjtXKlgxH7zvlvWj26kiGAnLY6A9sEcrmY865u+ST9 eqM5S1YWZqzX9hf6Te6FDj51wXrVNkircTf8un8Djpm/K493aN9Y/nBzlC5AOGXqGsNA 5hE2R8tpbOvMHaznYS4/MmfUkXAlQUqEhBOuuIu6US3OHlFlTv0+x/oOCSGYGdmPeJ/z RQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2ntbmqpmdc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Nov 2018 23:47:59 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAKNlsSj026181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Nov 2018 23:47:54 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAKNlse3012903; Tue, 20 Nov 2018 23:47:54 GMT MIME-Version: 1.0 Message-ID: <064c334d-cfd8-4610-a320-2d4ca68b437b@default> Date: Tue, 20 Nov 2018 15:47:53 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today References: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> <87h8gb5owm.fsf@mail.linkov.net> In-Reply-To: <87h8gb5owm.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9083 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=588 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811200209 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33446 Cc: 33446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > The proximate cause of the error was likely due to > > my calling `isearch-lazy-highlight-update' outside > > searching (i.e., nil `isearch-mode'). But I think > > there might still be a bug in the Isearch code. >=20 > isearch-lazy-highlight-update is not intended > to be used in a window other than the window > where isearch-lazy-highlight-new-loop was called. > It has many dependencies on the original window > being selected. Yes, I guessed that finally. Beyond that, I think it's not intended to be invoked outside of search (i.e., when `isearch-mode' is nil). That was my mistake: invoking it in a command that can be used during Isearch or not. I know that wasn't intended as part of the Isearch design. Now I test for it and avoid calling `i-l-h-u'. (But it might not hurt for `i-l-h-u' itself to test and do nothing if `isearch-mode' is nil. I'm not requesting that, however.) > > The `isearch-lazy-highlight-update' code does this: > > > > (save-selected-window > > (if (and (window-live-p isearch-lazy-highlight-window) > > (not (memq (selected-window) > > isearch-lazy-highlight-window-group))) > > (select-window isearch-lazy-highlight-window)) > > > > That causes the window in the other frame to be selected. >=20 > It should select the same window where > isearch-lazy-highlight-new-loop was called. Which assumes it was called ;-) _and_ that we are still within Isearch. > > The code then does this: > > > > (setq window-start (window-group-start)) > > (setq window-end (window-group-end)) > > > > This causes `window-end' to be nil. Should `window-group-*' here > > be passed window `isearch-lazy-highlight-window'? >=20 > isearch-lazy-highlight-window should not be passed here > because it's guaranteed to be selected by the code above. OK (but see above). Feel free to close this bug, if you like. It's not clear to me whether any code change is needed. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 21 13:27:15 2018 Received: (at control) by debbugs.gnu.org; 21 Nov 2018 18:27:15 +0000 Received: from localhost ([127.0.0.1]:40068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPXDX-0004tF-1g for submit@debbugs.gnu.org; Wed, 21 Nov 2018 13:27:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPXDV-0004sz-J1 for control@debbugs.gnu.org; Wed, 21 Nov 2018 13:27:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPXDP-0000df-N7 for control@debbugs.gnu.org; Wed, 21 Nov 2018 13:27:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPXDP-0000dT-In for control@debbugs.gnu.org; Wed, 21 Nov 2018 13:27:07 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gPXDP-0005tL-FY for control@debbugs.gnu.org; Wed, 21 Nov 2018 13:27:07 -0500 Subject: control message for bug 33446 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 21 Nov 2018 13:27:07 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) tag 33446 notabug close 33446 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 21 17:44:19 2018 Received: (at 33446-done) by debbugs.gnu.org; 21 Nov 2018 22:44:19 +0000 Received: from localhost ([127.0.0.1]:40315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbEH-0004rV-J6 for submit@debbugs.gnu.org; Wed, 21 Nov 2018 17:44:18 -0500 Received: from common.maple.relay.mailchannels.net ([23.83.214.38]:6647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbEF-0004rM-Cr for 33446-done@debbugs.gnu.org; Wed, 21 Nov 2018 17:44:16 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E29501247AC; Wed, 21 Nov 2018 22:44:13 +0000 (UTC) Received: from pdx1-sub0-mail-a37.g.dreamhost.com (unknown [100.96.11.179]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9DD57124239; Wed, 21 Nov 2018 22:44:13 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 21 Nov 2018 22:44:13 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Quick-Juvenile: 03f934ab10452125_1542840253724_982166810 X-MC-Loop-Signature: 1542840253724:3301599368 X-MC-Ingress-Time: 1542840253724 Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id 630308092B; Wed, 21 Nov 2018 14:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=qqjHQhj5l3T3d0TxR9Lst+il+Lc=; b= B/uq0J1vQdZv4milRoaVVex4xR5sfAOt6F8NSI6ODqcCp4OpSdFOBK8S/fmHwhsY uy7LAvXHrat8KqHT8BurMPWrYeN0tBgQ2Lur6PoKuU43MMoVrbMSk0R07/hBjj7e CK+LF88xoIiqy0M8WgqDShN517hWb84I7SMLn+SZXyI= Received: from mail.jurta.org (m91-129-105-252.cust.tele2.ee [91.129.105.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id 89D1180920; Wed, 21 Nov 2018 14:44:05 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a37 From: Juri Linkov To: Drew Adams Subject: Re: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today Organization: LINKOV.NET References: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> <87h8gb5owm.fsf@mail.linkov.net> <064c334d-cfd8-4610-a320-2d4ca68b437b@default> Date: Thu, 22 Nov 2018 00:42:34 +0200 In-Reply-To: <064c334d-cfd8-4610-a320-2d4ca68b437b@default> (Drew Adams's message of "Tue, 20 Nov 2018 15:47:53 -0800 (PST)") Message-ID: <87y39mdpd1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddtkedgtddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrddvhedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrvdehvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33446-done Cc: 33446-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Yes, I guessed that finally. Beyond that, I think it's > not intended to be invoked outside of search (i.e., > when `isearch-mode' is nil). That was my mistake: > invoking it in a command that can be used during Isearch > or not. > > I know that wasn't intended as part of the Isearch > design. Now I test for it and avoid calling `i-l-h-u'. > > (But it might not hurt for `i-l-h-u' itself to test and > do nothing if `isearch-mode' is nil. I'm not requesting > that, however.) isearch-lazy-highlight-update can't test for non-nil isearch-mode, because it's also used in non-isearch cases like in query-replace where isearch-mode is nil. > Feel free to close this bug, if you like. It's not > clear to me whether any code change is needed. I thought that your request was for using isearch-lazy-highlight-window as an argument of window functions in isearch-lazy-highlight-update. If you need this, then please create a new request, and I'm closing this one. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 21 17:51:11 2018 Received: (at 33446-done) by debbugs.gnu.org; 21 Nov 2018 22:51:11 +0000 Received: from localhost ([127.0.0.1]:40323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbKx-000528-Hy for submit@debbugs.gnu.org; Wed, 21 Nov 2018 17:51:11 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:45736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbKv-00051s-Ig for 33446-done@debbugs.gnu.org; Wed, 21 Nov 2018 17:51:10 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wALMitaU043479; Wed, 21 Nov 2018 22:51:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=R+2qWSdYzzB1dMV80YsmwzqtUt0YP3ypwxcxYmAEEYU=; b=YB06lGH5WYE6yG4RtKlnVEx30bFGjf8oci9R+S1WbmvyBsPS9cf2iDXqKWLT/cDs9PZB UbC+3uRlxX2lg0/1VP2uPKXnkOU+liaEYyDg7BqhZQz0gq3KgL122yHArMwOafkpmw3m la2l8IGs47zQhXHhvNv29iVBqI3PYAfXOZh2+DJzwKeW7aE7CpRcJidD8hfRTf+8Mc4H Xtqv5p1uMTLoeP5C4Nt13lYIECIXMuXmeXr8AFKvJCCGknY46oFZIlJXih5JAoNN3nFG UFr0RfSkMes9Q8odrw6BtZQe1vRePuB2kRWuB4TDvfkplNcmV+OdqVS0UDs4QEjkAIN1 ew== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2ntbmquwyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 22:51:03 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wALMow33024121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 22:50:58 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wALMovUI024534; Wed, 21 Nov 2018 22:50:57 GMT MIME-Version: 1.0 Message-ID: <0ba62b0e-d257-405d-a358-cee30725f4c6@default> Date: Wed, 21 Nov 2018 14:50:56 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today References: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> <87h8gb5owm.fsf@mail.linkov.net> <064c334d-cfd8-4610-a320-2d4ca68b437b@default> <87y39mdpd1.fsf@mail.linkov.net> In-Reply-To: <87y39mdpd1.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9084 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=921 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811210198 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33446-done Cc: 33446-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > Yes, I guessed that finally. Beyond that, I think it's > > not intended to be invoked outside of search (i.e., > > when `isearch-mode' is nil). That was my mistake: > > invoking it in a command that can be used during Isearch > > or not. > > > > I know that wasn't intended as part of the Isearch > > design. Now I test for it and avoid calling `i-l-h-u'. > > > > (But it might not hurt for `i-l-h-u' itself to test and > > do nothing if `isearch-mode' is nil. I'm not requesting > > that, however.) >=20 > isearch-lazy-highlight-update can't test for non-nil > isearch-mode, because it's also used in non-isearch cases > like in query-replace where isearch-mode is nil. Oh, right. Is there some other state it can test for? As you said, it can only be expected to be used (i.e., to work) when within an appropriate context (e.g. following xyz). > > Feel free to close this bug, if you like. It's not > > clear to me whether any code change is needed. >=20 > I thought that your request was for using > isearch-lazy-highlight-window as an argument > of window functions in isearch-lazy-highlight-update. > If you need this, then please create a new request, > and I'm closing this one. That's fine. Thx. From unknown Fri Jun 20 07:09:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Dec 2018 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator