From unknown Sat Jun 14 18:59:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33428: 27.0.50; edebug-print-{length,level} customization types Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Nov 2018 10:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33428@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154262358830011 (code B ref -1); Mon, 19 Nov 2018 10:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Nov 2018 10:33:08 +0000 Received: from localhost ([127.0.0.1]:59687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgrc-0007nz-Ik for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgra-0007nh-Tx for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgrU-00008T-Sl for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57953) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOgrU-00008L-QC for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgrT-00015S-QR for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:33:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgrO-000056-TS for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:32:59 -0500 Received: from mout.gmx.net ([212.227.17.22]:60375) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOgrO-0008WU-KL for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:32:54 -0500 Received: from rosalinde ([88.74.20.32]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUDXS-1fxqaM37I2-00QyUW for ; Mon, 19 Nov 2018 11:32:52 +0100 From: Stephen Berman Date: Mon, 19 Nov 2018 11:32:51 +0100 Message-ID: <87o9alcq7g.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:BbXqhQm+qz736FTc0OxFNcoES+kCL58QoTEXAIP5vKeLJ2PNj0V HBfJ0CM4vAGHRsDL+9IiZmQ8MM/TRiJAvkucuvgsIKnwCl0ygyv3gzkmm28bbepqAb5jSCn B+OigNBOqBHyxP2osMX8H5fKhs9gTqb0iqHIP3Mv5mYADoWCjUsBdTx6CCf+aUdo4Id6/oR WDdGemQX2Sn2DfIA3K1vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:HXnuyjk/G88=:mrAK9cTVPSKPY1m++nEjNS 243m1xWzMOh0+rl9ThoDa7O7ixk7SsLxcQvlWgoXP3dpCI6+IZ8HaPTVb6vOOHNqo2A44Svuj iu0t6avY3ilpBEdLLWxcApSRv3pE7y3NbuEUhJKK4eDbO5WbMgXH1JiKLpusZY5KgjZiuKkZG 4aP57cV7XD3TaMa4yeMKmAlwtHJAwy2Ib5Dhjsdf0btK8+cl1hixRIRBgoxXUOKhT2aeYfzlP Kex3Irps9FFAGjhVnT2OIUnryoSBvjaiYwsOstsA9FKVeISFqcHBDI+kKZpdFG7UNcmIaTb6u WLj9XKPY5SCnPYgJkbcYvuI15B/hat3HVYRI3fWVl4hshXtcHu15Ea+mgWSgyQL0illaN6ASP aZA8Rb3eSj8mjJBGSK4UtDa7bxH/GUUSlK2MpqAQv+KVrbKxzr4RJDsnnfCIVVptYHU//7sYo 03Mn1l0OLNnWiG/L7jwKrNjlv1ljoULdOXphuF2/R9bbuA+GMnrI3dwdpJJnZgbqloAaeoT7L /wiEsjkmJvJPgHjbrYqHc8wa1HOBCykIizk3fmhaQ4aqrcSvOCwLo9jWBO1rhEXMVgBkEXcov oEQtRtuabL3ETZ63eRtKhdw/tDwg7WjbTcWHZ9nH3zQ2NhH1XdcpOrBL3rrMRKsdDBUK2e6jg J703eVPDu3aMh7WQRGcfD10csgF1dgty7/cYmsdhndGblyIT2bX9ggzidmq+181IWMk3iiG9c G1RGv17/ZhcT2STpLa8uO07/FuvCTjbB+weqg4v53zlRVcnRoOzOLjw8WwjqQ1qzqqXcGImDe MtJlDvTMo9/wA92yIDxhMfHa27u2M18Om27x1La6gjlvtCFsfrHO5FN9Tj1Q2xeRy2dsMtKhf aaCLA7/aWfX5DU/x80baUdeDcJLm6gKOwxQB6FNurEsX6jSeTLBN3t/gJUNPwevGb+buTicmX l8qJL63RIKQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) The doc strings of edebug-print-length and edebug-print-level imply that nil is a valid value and indeed it is. Yet trying to set the value to nil via `M-x customize-option' fails with the error "This field should contain an integer", because nil does not fit the customization type :integer used in the definitions of these user options. It's been like this since they were changed from defvars to defcustoms more than 20 years ago (though "If non-nil" was added to the doc strings only a little less than 10 years ago), so should the fix (below) go into master, or is it on the order of a documentation fix and suitable for the release branch? diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 15f68a62ac..b50b0383da 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -192,11 +192,11 @@ edebug-continue-kbd-macro (defcustom edebug-print-length 50 "If non-nil, default value of `print-length' for printing results in Edebug." - :type 'integer + :type '(choice integer (const nil)) :group 'edebug) (defcustom edebug-print-level 50 "If non-nil, default value of `print-level' for printing results in Edebug." - :type 'integer + :type '(choice integer (const nil)) :group 'edebug) (defcustom edebug-print-circle t "If non-nil, default value of `print-circle' for printing results in Edebug." In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-11-18 built on rosalinde Repository revision: 5d140800398287c20230dda79162a7c40016d88e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12001000 System Description: 8.3 From unknown Sat Jun 14 18:59:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33428: 27.0.50; edebug-print-{length,level} customization types Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Nov 2018 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: 33428@debbugs.gnu.org Received: via spool by 33428-submit@debbugs.gnu.org id=B33428.15426526299854 (code B ref 33428); Mon, 19 Nov 2018 18:38:02 +0000 Received: (at 33428) by debbugs.gnu.org; 19 Nov 2018 18:37:09 +0000 Received: from localhost ([127.0.0.1]:32993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOoQ1-0002Ys-D8 for submit@debbugs.gnu.org; Mon, 19 Nov 2018 13:37:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOoQ0-0002Yc-18 for 33428@debbugs.gnu.org; Mon, 19 Nov 2018 13:37:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOoPs-0004Yk-Sm for 33428@debbugs.gnu.org; Mon, 19 Nov 2018 13:37:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOoPs-0004YU-Pr; Mon, 19 Nov 2018 13:37:00 -0500 Received: from [176.228.60.248] (port=2642 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gOoPs-0003By-4r; Mon, 19 Nov 2018 13:37:00 -0500 Date: Mon, 19 Nov 2018 20:37:05 +0200 Message-Id: <837eh8kj72.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87o9alcq7g.fsf@gmx.net> (message from Stephen Berman on Mon, 19 Nov 2018 11:32:51 +0100) References: <87o9alcq7g.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Stephen Berman > Date: Mon, 19 Nov 2018 11:32:51 +0100 > > The doc strings of edebug-print-length and edebug-print-level imply that > nil is a valid value and indeed it is. Yet trying to set the value to > nil via `M-x customize-option' fails with the error "This field should > contain an integer", because nil does not fit the customization type > :integer used in the definitions of these user options. It's been like > this since they were changed from defvars to defcustoms more than 20 > years ago (though "If non-nil" was added to the doc strings only a > little less than 10 years ago), so should the fix (below) go into > master, or is it on the order of a documentation fix and suitable for > the release branch? It's fine with me to put this on the release branch. Thanks. From unknown Sat Jun 14 18:59:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33428: 27.0.50; edebug-print-{length,level} customization types Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Nov 2018 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 33428@debbugs.gnu.org Received: via spool by 33428-submit@debbugs.gnu.org id=B33428.154266572930616 (code B ref 33428); Mon, 19 Nov 2018 22:16:02 +0000 Received: (at 33428) by debbugs.gnu.org; 19 Nov 2018 22:15:29 +0000 Received: from localhost ([127.0.0.1]:33136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOrpJ-0007xj-JH for submit@debbugs.gnu.org; Mon, 19 Nov 2018 17:15:29 -0500 Received: from mout.gmx.net ([212.227.15.19]:54419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOrpI-0007xX-Lp for 33428@debbugs.gnu.org; Mon, 19 Nov 2018 17:15:29 -0500 Received: from rosalinde ([92.73.79.118]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MFMEG-1gCiCM1H88-00EQTR; Mon, 19 Nov 2018 23:15:22 +0100 From: Stephen Berman References: <87o9alcq7g.fsf@gmx.net> <837eh8kj72.fsf@gnu.org> Date: Mon, 19 Nov 2018 23:15:21 +0100 In-Reply-To: <837eh8kj72.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Nov 2018 20:37:05 +0200") Message-ID: <878t1od892.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:4OL7GfH0OW1DQjj+VSZi2/gBixkuxdShfh/KCsWdF0onAnYXGET qCl1NCMFpeKMzG7z6Tju89o/H3+dA7Mle07wJaPya6Er98lvFkAkj8CX4eRHaV0r+UYNJ13 3ORumZtUrqeLTBLEGbUsDmmNuo4YaMAj+yRZyvLFpql7a8DRInhJV9IW0oFOIxM1q4fA8EV 6vv+J1kR/+lwFGPj3FJgg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:82dkl594/u8=:zZp8ECeASEVHRePphPegWC h402M0zH7odcxS/FVCTgXAsM+gX4+IzqGUrel68SzEadeSNtwtZL6CGZbIMt2XJWYoLcP/Pxl SjffKrlzuQSSdgXR8yib3M+3j3tbKdoAOn5YGtpUOgoOULaLJ0jJhRL3j/YvIl6i8boDN4jfd wTiiu8Tw9q584pPOYYZZhqn2XMwvRvtJLkxH3/evkpuc1n9DVEOhNK81t/XKLm8sSY3HqIaPv BR38oHLIE0xnALczhEwHMYukodODHyiL4qqI39TWBJoVGsukEEW0/XBDjBm+rfCwnUaTejF9+ 9rdKFuy8JHctOm9FIjajGjPkHcnjLuQknSrT3PBvZZM1O7j7rFfiFn+slERo+XM07ZAW+d99T stF5aeZAH8Ctpyz22SiigQufQWp568wnQGyAvrWG7rWpyV85Bx8SCTxb8CpTssC9e0U9BuoRH oy2eHsLuzx+cNKMBCzzIlx/XcktKzO3UG9QjehS7lbjwRnm7lf5niZkmdHavWuCm7+msOGeQI 54ZXsDtEdQWylQM8H29NiHJtx3WoiUSQpUz+iIifEJApxppxYj3evaLIV8EAijjbC3o/YGwxE 1Z4j6m11ifijXN3OzmmlJ6Ytw7CS5QZnb/Gsr8C9hHbMLdDPQAs9sfE2zT68sloulyI5kStbs bvxqGVITj1gyho0GBXB4cUcTDM+A2kUyrk1XNWabwcI2Vdu9kqrah2wY97xDjJLCo45O6nY3T 9joZRdppXKbmXNQw9ips8Hj2d9PRvWcdt9gvPvrMeLDcgoskEQYGySoy8VH6AQmjT3VDSSqQp OuTfgM//2FvBZjhVb/mmOZGvlgrXgRCHj+J54E9kcKg7k1khUmCn+6UnyRUH0641+GAcxxFkY L+jPQN+mxRoJlQbd56QEOf1bwJIAe3gutjY16BmRCh6IV0w7Jnvpp/u1wEpOicRilHEJmorzV hbGM13oOymg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, 19 Nov 2018 20:37:05 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Mon, 19 Nov 2018 11:32:51 +0100 >> >> The doc strings of edebug-print-length and edebug-print-level imply that >> nil is a valid value and indeed it is. Yet trying to set the value to >> nil via `M-x customize-option' fails with the error "This field should >> contain an integer", because nil does not fit the customization type >> :integer used in the definitions of these user options. It's been like >> this since they were changed from defvars to defcustoms more than 20 >> years ago (though "If non-nil" was added to the doc strings only a >> little less than 10 years ago), so should the fix (below) go into >> master, or is it on the order of a documentation fix and suitable for >> the release branch? > > It's fine with me to put this on the release branch. > > Thanks. Done in commit d667318a7f. Steve Berman From unknown Sat Jun 14 18:59:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Berman Subject: bug#33428: closed (Re: bug#33428: 27.0.50; edebug-print-{length,level} customization types) Message-ID: References: <874lccd86c.fsf@rub.de> <87o9alcq7g.fsf@gmx.net> X-Gnu-PR-Message: they-closed 33428 X-Gnu-PR-Package: emacs Reply-To: 33428@debbugs.gnu.org Date: Mon, 19 Nov 2018 22:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1542665882-30856-1" This is a multi-part message in MIME format... ------------=_1542665882-30856-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33428: 27.0.50; edebug-print-{length,level} customization types which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33428@debbugs.gnu.org. --=20 33428: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33428 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1542665882-30856-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33428-done) by debbugs.gnu.org; 19 Nov 2018 22:17:09 +0000 Received: from localhost ([127.0.0.1]:33140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOrqv-00080b-0M for submit@debbugs.gnu.org; Mon, 19 Nov 2018 17:17:09 -0500 Received: from mout.gmx.net ([212.227.15.15]:46511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOrqs-000802-8u for 33428-done@debbugs.gnu.org; Mon, 19 Nov 2018 17:17:07 -0500 Received: from rosalinde ([92.73.79.118]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MCLx3-1gFlBF18jZ-009B9m; Mon, 19 Nov 2018 23:17:00 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#33428: 27.0.50; edebug-print-{length,level} customization types References: <87o9alcq7g.fsf@gmx.net> <837eh8kj72.fsf@gnu.org> <878t1od892.fsf@rub.de> Date: Mon, 19 Nov 2018 23:16:59 +0100 In-Reply-To: <878t1od892.fsf@rub.de> (Stephen Berman's message of "Mon, 19 Nov 2018 23:15:21 +0100") Message-ID: <874lccd86c.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:MT36yEfEra8VZrH3zCQvKrRw0P1XnTdXo34gIgN8MuO38cKn2/N TzUkvksV0g/NYNVWdeQ07MUhIU5XGtgn7/o6ayU9Ac6JoJW+CH7QkWArBH3Ht2J2g6vDYlC j/2YWWezoG/9cTr3S/pQdlOY5zWFfQf1mLTkQ52SOsDQmsWHBw26M0jQ6FaNg9POmxd3G5y 3/KFenPfsYNNjI3GZtxRA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:Jfu3lWWlLEk=:WGQn+N+9oeW/omJJz4tJsS svxyGiDmGJklUfPBoHqicDof1NsNBtj/1HszrHuK6jANPpUNAXyNLtwV+qCm+bc+rUShYDxHl 10/i7vBcvQ5Qwk8YEF9h6p2aD9lOtPdv3Cmsx6VO6g1OI2hrKBOCyf6iRW9lNggBjDO3zUYs6 g7tgbLQuQ2a8MbwmOeT1mvFSsN+9C5QLN/8UQvA+0+4wq4imWHq8xHC7dEcZpJHl2S4+/mzlw Wz9cGCeYtSHFKV7UbDjdW+IfqAg/eLW3KwC63WNiDpR6HpTPXT4mjU8XtuJKbxcIN6OoMp8vy W+WCHfZ8oPrFwQSfcrVBLlS8lyOKOzRV7VkePsZc9lshZ19wQnOasoXhuo+eIvqKKszHqWhBS sKDnnmlH2gRpPVkPnhvQUY7NC7EHCBr68gPcmflkO0z5DlMG3RwiA7Yplf9pVTRvX1np11kqI Uhs1I9TB1QjCyJgqiG2mGF1C6oOmV9WGkIYCTR5jik0SnUFDt8B73Zu2kUGdJstprDlFOftxH 5gUZXDwvHGp2wBo/R1MgZ6PhcPaBJNyfKY22BRgBFtU+9qu+3lKV4uI/LWnZO/cACk0R9Bw98 PxFsBf2X+uMRTofNlis+yUUMm8c9oQyaVwiUlJwkRPhCn5Hhun1lLWDIpfjemKkHNd1GW8IGx Ph4/sL+exzCMm9gCr7hYh1U4echyLVb6BvHUh/+2NTzIOFCwlZe+JDU8Pd7aDJUZEH4gPSw/p h/d3sxSIKeVqbO9DEU8tCWOSwANZINk4AnjyEuVCWKNtL139+IC0XFOFDwh2ivgq/HXojD0Op oP/chNpjVBuTaXGpc/Ypn//G4HJO/XBhBPmxNfdCj5Jx6eYHlJYUKsGQ48X3e4MjWeXgGfRal pPFEWlas1OvgARRkNbGZG7pGjv78wrJX/8VZntrBk4WPvht6vxfZO+F6rrkG3rnIZNy9UZluR m8dHmnGlpuQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33428-done Cc: 33428-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, 19 Nov 2018 23:15:21 +0100 Stephen Berman wrote: > On Mon, 19 Nov 2018 20:37:05 +0200 Eli Zaretskii wrote: > >>> From: Stephen Berman >>> Date: Mon, 19 Nov 2018 11:32:51 +0100 >>> >>> The doc strings of edebug-print-length and edebug-print-level imply that >>> nil is a valid value and indeed it is. Yet trying to set the value to >>> nil via `M-x customize-option' fails with the error "This field should >>> contain an integer", because nil does not fit the customization type >>> :integer used in the definitions of these user options. It's been like >>> this since they were changed from defvars to defcustoms more than 20 >>> years ago (though "If non-nil" was added to the doc strings only a >>> little less than 10 years ago), so should the fix (below) go into >>> master, or is it on the order of a documentation fix and suitable for >>> the release branch? >> >> It's fine with me to put this on the release branch. >> >> Thanks. > > Done in commit d667318a7f. > > Steve Berman Oops, and closing the bug. ------------=_1542665882-30856-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Nov 2018 10:33:08 +0000 Received: from localhost ([127.0.0.1]:59687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgrc-0007nz-Ik for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOgra-0007nh-Tx for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgrU-00008T-Sl for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57953) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOgrU-00008L-QC for submit@debbugs.gnu.org; Mon, 19 Nov 2018 05:33:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgrT-00015S-QR for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:33:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgrO-000056-TS for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:32:59 -0500 Received: from mout.gmx.net ([212.227.17.22]:60375) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOgrO-0008WU-KL for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 05:32:54 -0500 Received: from rosalinde ([88.74.20.32]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUDXS-1fxqaM37I2-00QyUW for ; Mon, 19 Nov 2018 11:32:52 +0100 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 27.0.50; edebug-print-{length,level} customization types Date: Mon, 19 Nov 2018 11:32:51 +0100 Message-ID: <87o9alcq7g.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:BbXqhQm+qz736FTc0OxFNcoES+kCL58QoTEXAIP5vKeLJ2PNj0V HBfJ0CM4vAGHRsDL+9IiZmQ8MM/TRiJAvkucuvgsIKnwCl0ygyv3gzkmm28bbepqAb5jSCn B+OigNBOqBHyxP2osMX8H5fKhs9gTqb0iqHIP3Mv5mYADoWCjUsBdTx6CCf+aUdo4Id6/oR WDdGemQX2Sn2DfIA3K1vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:HXnuyjk/G88=:mrAK9cTVPSKPY1m++nEjNS 243m1xWzMOh0+rl9ThoDa7O7ixk7SsLxcQvlWgoXP3dpCI6+IZ8HaPTVb6vOOHNqo2A44Svuj iu0t6avY3ilpBEdLLWxcApSRv3pE7y3NbuEUhJKK4eDbO5WbMgXH1JiKLpusZY5KgjZiuKkZG 4aP57cV7XD3TaMa4yeMKmAlwtHJAwy2Ib5Dhjsdf0btK8+cl1hixRIRBgoxXUOKhT2aeYfzlP Kex3Irps9FFAGjhVnT2OIUnryoSBvjaiYwsOstsA9FKVeISFqcHBDI+kKZpdFG7UNcmIaTb6u WLj9XKPY5SCnPYgJkbcYvuI15B/hat3HVYRI3fWVl4hshXtcHu15Ea+mgWSgyQL0illaN6ASP aZA8Rb3eSj8mjJBGSK4UtDa7bxH/GUUSlK2MpqAQv+KVrbKxzr4RJDsnnfCIVVptYHU//7sYo 03Mn1l0OLNnWiG/L7jwKrNjlv1ljoULdOXphuF2/R9bbuA+GMnrI3dwdpJJnZgbqloAaeoT7L /wiEsjkmJvJPgHjbrYqHc8wa1HOBCykIizk3fmhaQ4aqrcSvOCwLo9jWBO1rhEXMVgBkEXcov oEQtRtuabL3ETZ63eRtKhdw/tDwg7WjbTcWHZ9nH3zQ2NhH1XdcpOrBL3rrMRKsdDBUK2e6jg J703eVPDu3aMh7WQRGcfD10csgF1dgty7/cYmsdhndGblyIT2bX9ggzidmq+181IWMk3iiG9c G1RGv17/ZhcT2STpLa8uO07/FuvCTjbB+weqg4v53zlRVcnRoOzOLjw8WwjqQ1qzqqXcGImDe MtJlDvTMo9/wA92yIDxhMfHa27u2M18Om27x1La6gjlvtCFsfrHO5FN9Tj1Q2xeRy2dsMtKhf aaCLA7/aWfX5DU/x80baUdeDcJLm6gKOwxQB6FNurEsX6jSeTLBN3t/gJUNPwevGb+buTicmX l8qJL63RIKQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) The doc strings of edebug-print-length and edebug-print-level imply that nil is a valid value and indeed it is. Yet trying to set the value to nil via `M-x customize-option' fails with the error "This field should contain an integer", because nil does not fit the customization type :integer used in the definitions of these user options. It's been like this since they were changed from defvars to defcustoms more than 20 years ago (though "If non-nil" was added to the doc strings only a little less than 10 years ago), so should the fix (below) go into master, or is it on the order of a documentation fix and suitable for the release branch? diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 15f68a62ac..b50b0383da 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -192,11 +192,11 @@ edebug-continue-kbd-macro (defcustom edebug-print-length 50 "If non-nil, default value of `print-length' for printing results in Edebug." - :type 'integer + :type '(choice integer (const nil)) :group 'edebug) (defcustom edebug-print-level 50 "If non-nil, default value of `print-level' for printing results in Edebug." - :type 'integer + :type '(choice integer (const nil)) :group 'edebug) (defcustom edebug-print-circle t "If non-nil, default value of `print-circle' for printing results in Edebug." In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-11-18 built on rosalinde Repository revision: 5d140800398287c20230dda79162a7c40016d88e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12001000 System Description: 8.3 ------------=_1542665882-30856-1--