From unknown Fri Aug 15 15:58:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33407: Cuirass is dropping the SQLite error message when rethrowing Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 16 Nov 2018 17:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33407 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 33407@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.154239026310658 (code B ref -1); Fri, 16 Nov 2018 17:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Nov 2018 17:44:23 +0000 Received: from localhost ([127.0.0.1]:56725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNiAJ-0002lq-2q for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNiAH-0002ld-5h for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNiA6-0005tB-77 for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,FROM_EXCESS_BASE64 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNi9x-0005gG-Ig for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNi9w-0004A5-Ox for bug-guix@gnu.org; Fri, 16 Nov 2018 12:44:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNi9q-0005d2-P5 for bug-guix@gnu.org; Fri, 16 Nov 2018 12:44:00 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:49968 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNi9q-0005cX-IR for bug-guix@gnu.org; Fri, 16 Nov 2018 12:43:54 -0500 Received: from alma-ubu (p508AC390.dip0.t-ipconnect.de [80.138.195.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id E10FC40180 for ; Fri, 16 Nov 2018 18:43:52 +0100 (CET) Date: Fri, 16 Nov 2018 18:43:51 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20181116184351.5ce7bc8b@alma-ubu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/X_gOtcwwiwEE1j3UzqUGYFk"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.9 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.9 (-----) --Sig_/X_gOtcwwiwEE1j3UzqUGYFk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, is this a bug or by intention? In src/cuirass/database.scm, in the db-add-* procedures, we have a catch-clause like this: (with-db-critical-section db (catch 'sqlite-error (lambda () ) (lambda (key who code message . rest) ;; If we get a unique-constraint-failed error, that means we have ;; already inserted the same checkout. That happens for each input ;; that doesn't change between two evaluations. (if (=3D code SQLITE_CONSTRAINT_PRIMARYKEY) #f (apply throw key who code rest)))))) -------------------------------------^ Here the message is not re-thrown. It would have made my life easier if I saw this message: "NOT NULL constraint failed: Builds.system" instead of just: In cuirass/utils.scm: 115:35 0 (_) cuirass/utils.scm:115:35: Throw to key `sqlite-error' with args `(#f 1299)'. Addationally, when adding the message to the apply clause, at least in an isolated test it will be just thrown without problems. Bj=C3=B6rn --Sig_/X_gOtcwwiwEE1j3UzqUGYFk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlvvAdgACgkQvyhstlk+X/3gXwCeIH6wrqVYnDqi6eawGPvSGEEb xPsAoJ0S14nXp1/8L1d3ddSAMwG6gyLT =D1Aa -----END PGP SIGNATURE----- --Sig_/X_gOtcwwiwEE1j3UzqUGYFk-- From unknown Fri Aug 15 15:58:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Subject: bug#33407: closed (Re: bug#33407: Cuirass is dropping the SQLite error message when rethrowing) Message-ID: References: <874lcgu4nu.fsf@gnu.org> <20181116184351.5ce7bc8b@alma-ubu> X-Gnu-PR-Message: they-closed 33407 X-Gnu-PR-Package: guix Reply-To: 33407@debbugs.gnu.org Date: Fri, 16 Nov 2018 20:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1542401582-27545-1" This is a multi-part message in MIME format... ------------=_1542401582-27545-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33407: Cuirass is dropping the SQLite error message when rethrowing which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33407@debbugs.gnu.org. --=20 33407: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33407 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1542401582-27545-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33407-done) by debbugs.gnu.org; 16 Nov 2018 20:52:02 +0000 Received: from localhost ([127.0.0.1]:56823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNl5t-00078l-Mz for submit@debbugs.gnu.org; Fri, 16 Nov 2018 15:52:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNl5r-00078S-Du for 33407-done@debbugs.gnu.org; Fri, 16 Nov 2018 15:52:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNl5l-0002la-D3 for 33407-done@debbugs.gnu.org; Fri, 16 Nov 2018 15:51:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNl5l-0002lQ-9K; Fri, 16 Nov 2018 15:51:53 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45146 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gNl5j-0001BE-FZ; Fri, 16 Nov 2018 15:51:53 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= Subject: Re: bug#33407: Cuirass is dropping the SQLite error message when rethrowing References: <20181116184351.5ce7bc8b@alma-ubu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Brumaire an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 16 Nov 2018 21:51:49 +0100 In-Reply-To: <20181116184351.5ce7bc8b@alma-ubu> (=?utf-8?Q?=22Bj=C3=B6rn?= =?utf-8?Q?_H=C3=B6fling=22's?= message of "Fri, 16 Nov 2018 18:43:51 +0100") Message-ID: <874lcgu4nu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33407-done Cc: 33407-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Bj=C3=B6rn H=C3=B6fling skribis: > is this a bug or by intention? > > In src/cuirass/database.scm, in the db-add-* procedures, we have a > catch-clause like this: > > (with-db-critical-section db > (catch 'sqlite-error > (lambda () > ) > (lambda (key who code message . rest) > ;; If we get a unique-constraint-failed error, that means we have > ;; already inserted the same checkout. That happens for each inp= ut > ;; that doesn't change between two evaluations. > (if (=3D code SQLITE_CONSTRAINT_PRIMARYKEY) > #f > (apply throw key who code rest)))))) > -------------------------------------^ > > Here the message is not re-thrown. > > It would have made my life easier if I saw this message: > > "NOT NULL constraint failed: Builds.system" Oops, good catch! Fixed in commit d0ed3341d7201d0332e9aeb0af80e0ec635aeb1e. I also factorized the exception handler in the previous commit because there were 3 copies of this bug=E2=80=A6 Thanks! Ludo=E2=80=99. ------------=_1542401582-27545-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Nov 2018 17:44:23 +0000 Received: from localhost ([127.0.0.1]:56725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNiAJ-0002lq-2q for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNiAH-0002ld-5h for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNiA6-0005tB-77 for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,FROM_EXCESS_BASE64 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNi9x-0005gG-Ig for submit@debbugs.gnu.org; Fri, 16 Nov 2018 12:44:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNi9w-0004A5-Ox for bug-guix@gnu.org; Fri, 16 Nov 2018 12:44:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNi9q-0005d2-P5 for bug-guix@gnu.org; Fri, 16 Nov 2018 12:44:00 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:49968 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNi9q-0005cX-IR for bug-guix@gnu.org; Fri, 16 Nov 2018 12:43:54 -0500 Received: from alma-ubu (p508AC390.dip0.t-ipconnect.de [80.138.195.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id E10FC40180 for ; Fri, 16 Nov 2018 18:43:52 +0100 (CET) Date: Fri, 16 Nov 2018 18:43:51 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Subject: Cuirass is dropping the SQLite error message when rethrowing Message-ID: <20181116184351.5ce7bc8b@alma-ubu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/X_gOtcwwiwEE1j3UzqUGYFk"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.9 (-----) --Sig_/X_gOtcwwiwEE1j3UzqUGYFk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, is this a bug or by intention? In src/cuirass/database.scm, in the db-add-* procedures, we have a catch-clause like this: (with-db-critical-section db (catch 'sqlite-error (lambda () ) (lambda (key who code message . rest) ;; If we get a unique-constraint-failed error, that means we have ;; already inserted the same checkout. That happens for each input ;; that doesn't change between two evaluations. (if (=3D code SQLITE_CONSTRAINT_PRIMARYKEY) #f (apply throw key who code rest)))))) -------------------------------------^ Here the message is not re-thrown. It would have made my life easier if I saw this message: "NOT NULL constraint failed: Builds.system" instead of just: In cuirass/utils.scm: 115:35 0 (_) cuirass/utils.scm:115:35: Throw to key `sqlite-error' with args `(#f 1299)'. Addationally, when adding the message to the apply clause, at least in an isolated test it will be just thrown without problems. Bj=C3=B6rn --Sig_/X_gOtcwwiwEE1j3UzqUGYFk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlvvAdgACgkQvyhstlk+X/3gXwCeIH6wrqVYnDqi6eawGPvSGEEb xPsAoJ0S14nXp1/8L1d3ddSAMwG6gyLT =D1Aa -----END PGP SIGNATURE----- --Sig_/X_gOtcwwiwEE1j3UzqUGYFk-- ------------=_1542401582-27545-1-- From unknown Fri Aug 15 15:58:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33407: Cuirass is dropping the SQLite error message when rethrowing Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 16 Nov 2018 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33407 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 33407-done@debbugs.gnu.org Received: via spool by 33407-done@debbugs.gnu.org id=D33407.154240284929424 (code D ref 33407); Fri, 16 Nov 2018 21:15:01 +0000 Received: (at 33407-done) by debbugs.gnu.org; 16 Nov 2018 21:14:09 +0000 Received: from localhost ([127.0.0.1]:56833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNlRI-0007eW-ME for submit@debbugs.gnu.org; Fri, 16 Nov 2018 16:14:08 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:35472 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNlRG-0007eN-QJ for 33407-done@debbugs.gnu.org; Fri, 16 Nov 2018 16:14:07 -0500 Received: from alma-ubu (p508AC390.dip0.t-ipconnect.de [80.138.195.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id A0C0540252; Fri, 16 Nov 2018 22:14:05 +0100 (CET) Date: Fri, 16 Nov 2018 22:14:04 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20181116221404.25dd0241@alma-ubu> In-Reply-To: <874lcgu4nu.fsf@gnu.org> References: <20181116184351.5ce7bc8b@alma-ubu> <874lcgu4nu.fsf@gnu.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/0CWM=HcQpBs2J6dgyFJn5y5"; protocol="application/pgp-signature" X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --Sig_/0CWM=HcQpBs2J6dgyFJn5y5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 16 Nov 2018 21:51:49 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello, >=20 > Bj=C3=B6rn H=C3=B6fling skribis: >=20 > > is this a bug or by intention? > > > > In src/cuirass/database.scm, in the db-add-* procedures, we have a > > catch-clause like this: > > > > (with-db-critical-section db > > (catch 'sqlite-error > > (lambda () > > ) > > (lambda (key who code message . rest) > > ;; If we get a unique-constraint-failed error, that means > > we have ;; already inserted the same checkout. That happens for > > each input ;; that doesn't change between two evaluations. > > (if (=3D code SQLITE_CONSTRAINT_PRIMARYKEY) > > #f > > (apply throw key who code rest)))))) > > -------------------------------------^ > > > > Here the message is not re-thrown. > > > > It would have made my life easier if I saw this message: > > > > "NOT NULL constraint failed: Builds.system" =20 >=20 > Oops, good catch! Fixed in commit > d0ed3341d7201d0332e9aeb0af80e0ec635aeb1e. >=20 > I also factorized the exception handler in the previous commit because > there were 3 copies of this bug=E2=80=A6 That's quick. Thank you, Bj=C3=B6rn --Sig_/0CWM=HcQpBs2J6dgyFJn5y5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlvvMxwACgkQvyhstlk+X/1dgQCfZdSh+SIQmB7b3f199O/XjaXH lfoAnA3/6dv4qIC9WVR8lnRTsaCAVY4A =B3Vk -----END PGP SIGNATURE----- --Sig_/0CWM=HcQpBs2J6dgyFJn5y5--