From unknown Sun Jun 22 00:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33402: 27.0.50; Test Gnus group names when reading from the browse mode Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 15 Nov 2018 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33402 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: 33402@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154231969829751 (code B ref -1); Thu, 15 Nov 2018 22:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2018 22:08:18 +0000 Received: from localhost ([127.0.0.1]:54533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNPo9-0007jn-NE for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNPo8-0007jY-4L for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPo1-0004Yd-Ut for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPo1-0004YR-Rj for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPo0-0007XM-Rp for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 17:08:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPnv-0004Tu-TD for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 17:08:08 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:57797) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPnv-0004Me-ML for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 17:08:03 -0500 Received: from localhost (71-212-20-199.tukw.qwest.net [71.212.20.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 7C46B42C78 for ; Thu, 15 Nov 2018 22:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1542319673; bh=lOwpnnsuvPqb2Gwyl3GCADXFmTuvBahCYdQBWUAXZX0=; h=From:To:Subject:Date:From; b=sHgP/J40I4o3UKml0zhEoKNw1VE9R43Rhr/ge/zemS3yjX4ChHNmlAk97G3okS9DA NqWgz4OJ3KPfCYL8vlWuqdPpkn4U+iPjrpyHAl4u65w5/Dsvf+PQsnpwtS2HMFpocH UFA9hbgDNX1DKUR4J7oDPzYlqtzd2dqzstn0DpxQ= From: Eric Abrahamsen Date: Thu, 15 Nov 2018 14:07:51 -0800 Message-ID: <87efbmvvt4.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) --=-=-= Content-Type: text/plain When browsing server groups through the *Gnus Browse Mode* interface, entering a group either reads the solid group, if it's already active, or creates an ephemeral copy of the server and reads it there, if it isn't. That might work for nntp servers, but for servers like nnmaildir that keep their own group accounting, if you create an ephemeral copy of the server it will have no groups, and you can't browse the group from the Browse interface. This patch checks if the group in question belongs to the native server, and shortens the group name if so, so that we can accurately know if the group is subscribed or not. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Check-Gnus-group-names-when-reading-from-a-browse-se.patch >From 8171708c120e1c65550f39e0075fd4054582b82b Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 15 Nov 2018 13:59:27 -0800 Subject: [PATCH] Check Gnus group names when reading from a browse server * lisp/gnus/gnus-srvr.el (gnus-browse-read-group): If the group in question belongs to the native server, the name has to be shortened before we check it wil `gnus-get-info'. It might work otherwise with nntp, but for backends like nnmaildir that have their own accounting system, creating an ephemeral group won't work. --- lisp/gnus/gnus-srvr.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-srvr.el b/lisp/gnus/gnus-srvr.el index dfca5e9d2c..34ebd00ef2 100644 --- a/lisp/gnus/gnus-srvr.el +++ b/lisp/gnus/gnus-srvr.el @@ -925,7 +925,11 @@ gnus-browse-read-group "Enter the group at the current line. If NUMBER, fetch this number of articles." (interactive "P") - (let ((group (gnus-browse-group-name))) + (let* ((full-name (gnus-browse-group-name)) + (group (if (gnus-native-method-p + (gnus-find-method-for-group full-name)) + (gnus-group-short-name full-name) + full-name))) (if (or (not (gnus-get-info group)) (gnus-ephemeral-group-p group)) (unless (gnus-group-read-ephemeral-group -- 2.19.1 --=-=-=-- From unknown Sun Jun 22 00:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33402: 27.0.50; Test Gnus group names when reading from the browse mode References: <87efbmvvt4.fsf@ericabrahamsen.net> In-Reply-To: <87efbmvvt4.fsf@ericabrahamsen.net> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 20 Nov 2018 18:30:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33402 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: 33402@debbugs.gnu.org Received: via spool by 33402-submit@debbugs.gnu.org id=B33402.15427385876611 (code B ref 33402); Tue, 20 Nov 2018 18:30:06 +0000 Received: (at 33402) by debbugs.gnu.org; 20 Nov 2018 18:29:47 +0000 Received: from localhost ([127.0.0.1]:37254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPAmP-0001iH-4q for submit@debbugs.gnu.org; Tue, 20 Nov 2018 13:29:45 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:49333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPAmM-0001hB-9x for 33402@debbugs.gnu.org; Tue, 20 Nov 2018 13:29:43 -0500 Received: from localhost (71-212-20-199.tukw.qwest.net [71.212.20.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 6C1353F39F for <33402@debbugs.gnu.org>; Tue, 20 Nov 2018 18:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1542738581; bh=1CKTuGTolZ5m+lrSpIX70rHhzFsgQI/loF++BBbL5Xw=; h=From:To:Subject:Date:From; b=Adg5eYKH4AwTvNyVG/OsVhg7oVGw7Zmf7dEPbzQ6afNaFbcPyTznwmfctOdw8t28Y PbrMtKxyEUNGf6fmw03zI0rjcltYcpvnlCqJ3sCqk1F9n4X4DIpipRRYOD/T+8yflQ cFQtZKtXAEJ3IdKvXaCcGJZPvLagsMSPKtGfTRNY= From: Eric Abrahamsen Date: Tue, 20 Nov 2018 10:29:40 -0800 Message-ID: <87bm6j1u23.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I think this is fairly uncontroversial, I'll push it in a bit if no one objects. From unknown Sun Jun 22 00:18:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eric Abrahamsen Subject: bug#33402: closed (Re: bug#33402: Acknowledgement (27.0.50; Test Gnus group names when reading from the browse mode)) Message-ID: References: <87o9aiz90g.fsf@ericabrahamsen.net> <87efbmvvt4.fsf@ericabrahamsen.net> X-Gnu-PR-Message: they-closed 33402 X-Gnu-PR-Package: emacs,gnus Reply-To: 33402@debbugs.gnu.org Date: Wed, 21 Nov 2018 16:33:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1542817982-433-1" This is a multi-part message in MIME format... ------------=_1542817982-433-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33402: 27.0.50; Test Gnus group names when reading from the browse mode which was filed against the emacs,gnus package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33402@debbugs.gnu.org. --=20 33402: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33402 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1542817982-433-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33402-done) by debbugs.gnu.org; 21 Nov 2018 16:32:35 +0000 Received: from localhost ([127.0.0.1]:39955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPVQZ-00006H-LD for submit@debbugs.gnu.org; Wed, 21 Nov 2018 11:32:35 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:37777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPVQY-000060-1g for 33402-done@debbugs.gnu.org; Wed, 21 Nov 2018 11:32:34 -0500 Received: from localhost (71-212-20-199.tukw.qwest.net [71.212.20.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4F9D83F8E0 for <33402-done@debbugs.gnu.org>; Wed, 21 Nov 2018 16:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1542817953; bh=VVq+h8jXkV+MBeouq2MXGAiNS01Tjvr0RhG71JqezJ4=; h=From:To:Subject:References:Date:In-Reply-To:From; b=KplNNcH8fayExEp2hs2Vkj88jH9TokgkTGLHJNSsFb+2op+MqVSaisOR3ehbFb320 Bsf0OR1p2Jghktv2QmStuQgEJMm72yYDeMg4x+izo6HZBAsIu7kmSluXOZTA8KA7SM trGezcw+mFr9fantzPSG5S07bpMDfmUomL4XjW+E= From: Eric Abrahamsen To: 33402-done@debbugs.gnu.org Subject: Re: bug#33402: Acknowledgement (27.0.50; Test Gnus group names when reading from the browse mode) References: <87efbmvvt4.fsf@ericabrahamsen.net> Date: Wed, 21 Nov 2018 08:32:31 -0800 In-Reply-To: (GNU bug Tracking System's message of "Thu, 15 Nov 2018 22:09:02 +0000") Message-ID: <87o9aiz90g.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33402-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Pushed. ------------=_1542817982-433-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Nov 2018 22:08:18 +0000 Received: from localhost ([127.0.0.1]:54533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNPo9-0007jn-NE for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNPo8-0007jY-4L for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPo1-0004Yd-Ut for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPo1-0004YR-Rj for submit@debbugs.gnu.org; Thu, 15 Nov 2018 17:08:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPo0-0007XM-Rp for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 17:08:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPnv-0004Tu-TD for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 17:08:08 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:57797) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPnv-0004Me-ML for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 17:08:03 -0500 Received: from localhost (71-212-20-199.tukw.qwest.net [71.212.20.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 7C46B42C78 for ; Thu, 15 Nov 2018 22:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1542319673; bh=lOwpnnsuvPqb2Gwyl3GCADXFmTuvBahCYdQBWUAXZX0=; h=From:To:Subject:Date:From; b=sHgP/J40I4o3UKml0zhEoKNw1VE9R43Rhr/ge/zemS3yjX4ChHNmlAk97G3okS9DA NqWgz4OJ3KPfCYL8vlWuqdPpkn4U+iPjrpyHAl4u65w5/Dsvf+PQsnpwtS2HMFpocH UFA9hbgDNX1DKUR4J7oDPzYlqtzd2dqzstn0DpxQ= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Test Gnus group names when reading from the browse mode X-Debbugs-Package: emacs,gnus Date: Thu, 15 Nov 2018 14:07:51 -0800 Message-ID: <87efbmvvt4.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) --=-=-= Content-Type: text/plain When browsing server groups through the *Gnus Browse Mode* interface, entering a group either reads the solid group, if it's already active, or creates an ephemeral copy of the server and reads it there, if it isn't. That might work for nntp servers, but for servers like nnmaildir that keep their own group accounting, if you create an ephemeral copy of the server it will have no groups, and you can't browse the group from the Browse interface. This patch checks if the group in question belongs to the native server, and shortens the group name if so, so that we can accurately know if the group is subscribed or not. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Check-Gnus-group-names-when-reading-from-a-browse-se.patch >From 8171708c120e1c65550f39e0075fd4054582b82b Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 15 Nov 2018 13:59:27 -0800 Subject: [PATCH] Check Gnus group names when reading from a browse server * lisp/gnus/gnus-srvr.el (gnus-browse-read-group): If the group in question belongs to the native server, the name has to be shortened before we check it wil `gnus-get-info'. It might work otherwise with nntp, but for backends like nnmaildir that have their own accounting system, creating an ephemeral group won't work. --- lisp/gnus/gnus-srvr.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-srvr.el b/lisp/gnus/gnus-srvr.el index dfca5e9d2c..34ebd00ef2 100644 --- a/lisp/gnus/gnus-srvr.el +++ b/lisp/gnus/gnus-srvr.el @@ -925,7 +925,11 @@ gnus-browse-read-group "Enter the group at the current line. If NUMBER, fetch this number of articles." (interactive "P") - (let ((group (gnus-browse-group-name))) + (let* ((full-name (gnus-browse-group-name)) + (group (if (gnus-native-method-p + (gnus-find-method-for-group full-name)) + (gnus-group-short-name full-name) + full-name))) (if (or (not (gnus-get-info group)) (gnus-ephemeral-group-p group)) (unless (gnus-group-read-ephemeral-group -- 2.19.1 --=-=-=-- ------------=_1542817982-433-1--