GNU bug report logs - #33398
26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion

Previous Next

Full log

Message #68 received at 33398 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Van L <van <at> scratch.space>, 33398 <at> debbugs.gnu.org
Subject: Re: bug#33398: 26.1, netbsd-8;
 Hi Lock Faces, Hi Green B, default setting suggestion
Date: Tue, 27 Nov 2018 01:27:40 +0200

> So your problem is with the names of the faces?  Then may I suggest to
> name the new faces hi-red and hi-deepblue?

Maybe something like this, but I'm not sure because the red background would
be too glaring on 88 colors, but more readable orchid1 is not quite red.
Also blue would be too dark for a light background, but more readable
DarkSlateGray1 is not quite blue as its name suggests.

diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index f503c2764b..223b1007a8 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -177,6 +177,24 @@ hi-blue
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
+(defface hi-red
+  '((((min-colors 88) (background dark))
+     (:background "orchid1" :foreground "black"))
+    (((background dark)) (:background "red" :foreground "black"))
+    (((min-colors 88)) (:background "orchid1"))
+    (t (:background "red")))
+  "Face for hi-lock mode."
+  :group 'hi-lock-faces)
+
+(defface hi-deepblue
+  '((((min-colors 88) (background dark))
+     (:background "DarkSlateGray1" :foreground "black"))
+    (((background dark)) (:background "blue" :foreground "black"))
+    (((min-colors 88)) (:background "DarkSlateGray1"))
+    (t (:background "blue")))
+  "Face for hi-lock mode."
+  :group 'hi-lock-faces)
+
 (defface hi-black-b
   '((t (:weight bold)))
   "Face for hi-lock mode."
@@ -189,13 +207,13 @@ hi-blue-b
   :group 'hi-lock-faces)
 
 (defface hi-green-b
-  '((((min-colors 88)) (:weight bold :foreground "green1"))
+  '((((min-colors 88)) (:weight bold :foreground "green3"))
     (t (:weight bold :foreground "green")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
 (defface hi-red-b
-  '((((min-colors 88)) (:weight bold :foreground "red1"))
+  '((((min-colors 88)) (:weight bold :foreground "firebrick2"))
     (t (:weight bold :foreground "red")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
@@ -216,8 +234,8 @@ hi-lock-interactive-patterns
 (define-obsolete-variable-alias 'hi-lock-face-history
                                 'hi-lock-face-defaults "23.1")
 (defvar hi-lock-face-defaults
-  '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b"
-    "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
+  '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-red" "hi-deepblue"
+    "hi-black-b" "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
   "Default faces for hi-lock interactive functions.")
 
 (define-obsolete-variable-alias 'hi-lock-regexp-history

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.