Subject: Re: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion

From: Juri Linkov <[email-masked]>
Date: Wed, 28 Nov 2018 01:49:54 +0200

>> Maybe something like this, but I'm not sure because the red background would
>> be too glaring on 88 colors, but more readable orchid1 is not quite red.
>
> Is OrangeRed better?

OrangeRed is not better than red, but simply Orange looks much better,
so a new face could be named hi-orange.

>> Also blue would be too dark for a light background, but more readable
>> DarkSlateGray1 is not quite blue as its name suggests.
>
> That's okay, I think.

I found a better color: Aquamarine, it's very close to DarkSlateGray1,
but it's name has a stronger association with blue.

>>  (defface hi-green-b
>> -  '((((min-colors 88)) (:weight bold :foreground "green1"))
>> +  '((((min-colors 88)) (:weight bold :foreground "green3"))
>>      (t (:weight bold :foreground "green")))
>>    "Face for hi-lock mode."
>>    :group 'hi-lock-faces)
>>
>>  (defface hi-red-b
>> -  '((((min-colors 88)) (:weight bold :foreground "red1"))
>> +  '((((min-colors 88)) (:weight bold :foreground "firebrick2"))
>>      (t (:weight bold :foreground "red")))
>>    "Face for hi-lock mode."
>>    :group 'hi-lock-faces)
>
> So why are you still changing the existing faces?  Not that I see any
> problem with these changes on low-color TTYs, but still: why change?

The original complain from Van L was that "green1" and "red1" are
too glaring, and I agree.  The new colors are dimmed down versions
that are more easy to read.

diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index f503c2764b..f66a512755 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -177,6 +177,24 @@ hi-blue
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
+(defface hi-orange
+  '((((min-colors 88) (background dark))
+     (:background "orange" :foreground "black"))
+    (((background dark)) (:background "red" :foreground "black"))
+    (((min-colors 88)) (:background "orange"))
+    (t (:background "red")))
+  "Face for hi-lock mode."
+  :group 'hi-lock-faces)
+
+(defface hi-aquamarine
+  '((((min-colors 88) (background dark))
+     (:background "aquamarine" :foreground "black"))
+    (((background dark)) (:background "blue" :foreground "black"))
+    (((min-colors 88)) (:background "aquamarine"))
+    (t (:background "blue")))
+  "Face for hi-lock mode."
+  :group 'hi-lock-faces)
+
 (defface hi-black-b
   '((t (:weight bold)))
   "Face for hi-lock mode."
@@ -189,13 +207,13 @@ hi-blue-b
   :group 'hi-lock-faces)
 
 (defface hi-green-b
-  '((((min-colors 88)) (:weight bold :foreground "green1"))
+  '((((min-colors 88)) (:weight bold :foreground "green3"))
     (t (:weight bold :foreground "green")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
 (defface hi-red-b
-  '((((min-colors 88)) (:weight bold :foreground "red1"))
+  '((((min-colors 88)) (:weight bold :foreground "firebrick2"))
     (t (:weight bold :foreground "red")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
@@ -216,8 +234,8 @@ hi-lock-interactive-patterns
 (define-obsolete-variable-alias 'hi-lock-face-history
                                 'hi-lock-face-defaults "23.1")
 (defvar hi-lock-face-defaults
-  '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b"
-    "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
+  '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-orange" "hi-aquamarine"
+    "hi-black-b" "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
   "Default faces for hi-lock interactive functions.")
 
 (define-obsolete-variable-alias 'hi-lock-regexp-history