Subject: Re: [bug#33395] [PATCH 1/2] gnu: Add liblcf.

From: [email-masked] (宋文武)
Date: Sat, 08 Dec 2018 11:30:18 +0800

[email-masked] (Ludovic Courtès) writes:

> Hello 宋文武!
>
> 宋文武 <[email-masked]> skribis:
>
>> * gnu/packages/easyrpg.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>
> Should it go to game-development.scm?

Not sure, but I'd prefer it go into the same file with 'easyrpg-player',
which IMO dosen't belong into 'games.scm'...

>
>> +    (synopsis "Library to handle RPG Maker 2000 and 2003 game data")
>> +    (description
>> +     "@code{liblcf} is a library to handle RPG Maker 2000 and 2003 game data.
>> +It can read and write LCF and XML files.")
>> +    ;; It bundles Boost Preprocessor Cat and Stringize (boost-1.0) and a copy
>> +    ;; of inih (bsd-3).
>> +    (license license:expat)))
>
> Could these things be unbundled?  If not, could you leave a comment
> possibly with a TODO?

Ok, how about:

    ;; It includes a copy of Boost Preprocessor Cat and Stringize (boost-1.0):
    ;;   src/boost/preprocessor/config.hpp
    ;;   src/boost/preprocessor/cat.hpp
    ;;   src/boost/preprocessor/stringize.hpp
    ;; and a copy of inih (bsd-3):
    ;;   src/ini.h
    ;;   src/ini.cpp
    ;;   src/initreader.cpp
    ;; TODO: Unbundle them.