From unknown Thu Aug 21 12:10:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33386 <33386@debbugs.gnu.org> To: bug#33386 <33386@debbugs.gnu.org> Subject: Status: Gajim plugins Reply-To: bug#33386 <33386@debbugs.gnu.org> Date: Thu, 21 Aug 2025 19:10:04 +0000 retitle 33386 Gajim plugins reassign 33386 guix-patches submitter 33386 Cl=C3=A9ment Lassieur severity 33386 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 14 14:55:00 2018 Received: (at submit) by debbugs.gnu.org; 14 Nov 2018 19:55:00 +0000 Received: from localhost ([127.0.0.1]:52588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1Fb-0002yp-VA for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:55:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1FZ-0002yZ-Gb for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:54:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN1FT-0006wZ-RV for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:54:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gN1FT-0006wU-P5 for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:54:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN1FT-0002lD-3v for guix-patches@gnu.org; Wed, 14 Nov 2018 14:54:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN1FQ-0006lw-FP for guix-patches@gnu.org; Wed, 14 Nov 2018 14:54:51 -0500 Received: from mail.lassieur.org ([83.152.10.219]:35950) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gN1FK-0006eq-A1 for guix-patches@gnu.org; Wed, 14 Nov 2018 14:54:44 -0500 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 8537d11a (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Wed, 14 Nov 2018 19:54:39 +0000 (UTC) User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: guix-patches@gnu.org Subject: Gajim plugins Date: Wed, 14 Nov 2018 20:54:38 +0100 Message-ID: <87d0r7e8ox.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Hi, The first patch allow one to package Gajim plugins. It also removes two inputs that were added for the OMEMO plugin. The second add the OMEMO plugin. Thanks, Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 14 14:56:07 2018 Received: (at 33386) by debbugs.gnu.org; 14 Nov 2018 19:56:07 +0000 Received: from localhost ([127.0.0.1]:52594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1Gh-00031Q-AF for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:56:07 -0500 Received: from mail.lassieur.org ([83.152.10.219]:40108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1Gg-00031H-4q for 33386@debbugs.gnu.org; Wed, 14 Nov 2018 14:56:06 -0500 Received: from localhost.localdomain (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 8d6e57d2 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <33386@debbugs.gnu.org>; Wed, 14 Nov 2018 19:56:04 +0000 (UTC) From: =?UTF-8?q?Cl=C3=A9ment=20Lassieur?= To: 33386@debbugs.gnu.org Subject: [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. Date: Wed, 14 Nov 2018 20:55:52 +0100 Message-Id: <20181114195553.27293-1-clement@lassieur.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33386 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/messaging.scm (gajim)[arguments]: Add an 'add-plugin-dirs' phase. Export PYTHONPATH in the wrapper. [inputs]: Remove python-axolotl and python-qrcode. --- gnu/packages/messaging.scm | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index c22cacfd3..f68b7e4eb 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -588,15 +588,29 @@ was initially a fork of xmpppy, but uses non-blocking sockets.") `(#:test-target "test_nogui" #:phases (modify-phases %standard-phases + (add-after 'unpack 'add-plugin-dirs + (lambda _ + (substitute* "gajim/common/configpaths.py" + (("_paths\\['PLUGINS_USER'\\]") + (string-append + "_paths['PLUGINS_USER'],os.path.expanduser" + "('~/.guix-profile/share/gajim/plugins')"))) + #t)) (add-after 'install 'wrap-program (lambda* (#:key outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out"))) (for-each (lambda (name) (let ((file (string-append out "/bin/" name)) - (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (pythonpath (string-append + "$HOME/.guix-profile/lib/python" + ,(version-major+minor + (package-version python)) + "/site-packages"))) (wrap-program file - `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))) + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) + `("PYTHONPATH" ":" prefix (,pythonpath))))) '("gajim" "gajim-remote" "gajim-history-manager"))) #t)) (add-after 'install 'install-icons @@ -636,7 +650,6 @@ was initially a fork of xmpppy, but uses non-blocking sockets.") ("gtkspell3" ,gtkspell3) ("hicolor-icon-theme" ,hicolor-icon-theme) ("libsecret" ,libsecret) - ("python-axolotl" ,python-axolotl) ("python-cssutils" ,python-cssutils) ("python-dbus" ,python-dbus) ("python-gnupg" ,python-gnupg) @@ -646,8 +659,7 @@ was initially a fork of xmpppy, but uses non-blocking sockets.") ("python-precis-i18n" ,python-precis-i18n) ("python-pycairo" ,python-pycairo) ("python-pygobject" ,python-pygobject) - ("python-pyopenssl" ,python-pyopenssl) - ("python-qrcode" ,python-qrcode))) + ("python-pyopenssl" ,python-pyopenssl))) (home-page "https://gajim.org/") (synopsis "Jabber (XMPP) client") (description "Gajim is a feature-rich and easy to use Jabber/XMPP client. -- 2.19.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 14 14:56:09 2018 Received: (at 33386) by debbugs.gnu.org; 14 Nov 2018 19:56:09 +0000 Received: from localhost ([127.0.0.1]:52596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1Gj-00031d-Jk for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:56:09 -0500 Received: from mail.lassieur.org ([83.152.10.219]:40108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1Gg-00031H-SC for 33386@debbugs.gnu.org; Wed, 14 Nov 2018 14:56:07 -0500 Received: from localhost.localdomain (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 5007ebf3 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <33386@debbugs.gnu.org>; Wed, 14 Nov 2018 19:56:04 +0000 (UTC) From: =?UTF-8?q?Cl=C3=A9ment=20Lassieur?= To: 33386@debbugs.gnu.org Subject: [PATCH 2/2] gnu: Add gajim-omemo. Date: Wed, 14 Nov 2018 20:55:53 +0100 Message-Id: <20181114195553.27293-2-clement@lassieur.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181114195553.27293-1-clement@lassieur.org> References: <20181114195553.27293-1-clement@lassieur.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33386 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/messaging.scm (gajim-omemo): New variable. [propagated-inputs]: Add python-axolotl and python-qrcode. --- gnu/packages/messaging.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index f68b7e4eb..7be0fcc1b 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -93,6 +93,7 @@ #:use-module (guix build-system meson) #:use-module (guix build-system perl) #:use-module (guix build-system python) + #:use-module (guix build-system trivial) #:use-module (guix download) #:use-module (guix git-download) #:use-module ((guix licenses) #:prefix license:) @@ -669,6 +670,42 @@ transformation; audio and video conferences; file transfer; TLS, GPG and end-to-end encryption support; XML console.") (license license:gpl3))) +(define-public gajim-omemo + (package + (name "gajim-omemo") + (version "2.6.23") + (source (origin + (method url-fetch/zipbomb) + (uri (string-append + "https://ftp.gajim.org/plugins_releases/omemo_" + version ".zip")) + (sha256 + (base32 + "134zbscbcnhx4smad0ryvx3ngkqlsspafqf0kk8y2d3vcd9bf3pa")))) + (build-system trivial-build-system) + (arguments + `(#:modules ((guix build utils)) + #:builder + (begin + (use-modules (guix build utils)) + (let* ((out (assoc-ref %outputs "out")) + (share (in-vicinity out "share/gajim/plugins")) + (source (assoc-ref %build-inputs "source"))) + (mkdir-p share) + (copy-recursively source share) + #t)))) + (propagated-inputs + `(("python-axolotl" ,python-axolotl) + ("python-qrcode" ,python-qrcode))) + (home-page + "https://dev.gajim.org/gajim/gajim-plugins/wikis/OmemoGajimPlugin") + (synopsis "Gajim OMEMO plugin") + (description + "This package provides the Gajim OMEMO plugin. OMEMO is an XMPP +Extension Protocol (XEP) for secure multi-client end-to-end encryption based +on Axolotl and PEP.") + (license license:gpl3+))) + (define-public dino ;; The only release tarball is for version 0.0, but it is very old and fails ;; to build. -- 2.19.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 14 14:58:03 2018 Received: (at submit) by debbugs.gnu.org; 14 Nov 2018 19:58:03 +0000 Received: from localhost ([127.0.0.1]:52601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1IZ-00034c-0w for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:58:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN1IX-000343-Na for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:58:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN1IR-0002iI-JE for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:57:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gN1IR-0002i4-GQ for submit@debbugs.gnu.org; Wed, 14 Nov 2018 14:57:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN1IQ-0003Y1-S3 for guix-patches@gnu.org; Wed, 14 Nov 2018 14:57:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN1IO-0002eQ-6a for guix-patches@gnu.org; Wed, 14 Nov 2018 14:57:54 -0500 Received: from mail.lassieur.org ([83.152.10.219]:35954) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gN1IN-0002BD-Hm for guix-patches@gnu.org; Wed, 14 Nov 2018 14:57:52 -0500 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 92bafe62 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Wed, 14 Nov 2018 19:57:39 +0000 (UTC) References: <87d0r7e8ox.fsf@lassieur.org> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: guix-patches@gnu.org Subject: Re: Gajim plugins In-reply-to: <87d0r7e8ox.fsf@lassieur.org> Date: Wed, 14 Nov 2018 20:57:39 +0100 Message-ID: <87bm6re8jw.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Cl=C3=A9ment Lassieur writes: > Hi, > > The first patch allow one to package Gajim plugins. It also removes two allows > inputs that were added for the OMEMO plugin. > > The second add the OMEMO plugin. adds I must be tired ;) > > Thanks, > Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 15 13:19:13 2018 Received: (at 33386) by debbugs.gnu.org; 15 Nov 2018 18:19:13 +0000 Received: from localhost ([127.0.0.1]:54449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNMES-0002IZ-R9 for submit@debbugs.gnu.org; Thu, 15 Nov 2018 13:19:13 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:59050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNMEQ-0002IQ-Sd for 33386@debbugs.gnu.org; Thu, 15 Nov 2018 13:19:11 -0500 Received: from localhost (178.113.161.191.wireless.dyn.drei.com [178.113.161.191]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 270023360D8A; Thu, 15 Nov 2018 19:19:09 +0100 (CET) Date: Thu, 15 Nov 2018 19:19:03 +0100 From: Danny Milosavljevic To: =?ISO-8859-1?Q?Cl=E9ment?= Lassieur Subject: Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. Message-ID: <20181115191903.7f3db09b@scratchpost.org> In-Reply-To: <20181114195553.27293-1-clement@lassieur.org> References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/sF9ST=3xGEk3Z5QJpJGZWLu"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33386 Cc: 33386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/sF9ST=3xGEk3Z5QJpJGZWLu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Cl=C3=A9ment, On Wed, 14 Nov 2018 20:55:52 +0100 Cl=C3=A9ment Lassieur wrote: >+ (add-after 'unpack 'add-plugin-dirs >+ (lambda _ >+ (substitute* "gajim/common/configpaths.py" >+ (("_paths\\['PLUGINS_USER'\\]") >+ (string-append >+ "_paths['PLUGINS_USER'],os.path.expanduser" >+ "('~/.guix-profile/share/gajim/plugins')"))) >+ #t)) [...] > + (pythonpath (string-append > + "$HOME/.guix-profile/lib/python" > + ,(version-major+minor > + (package-version python)) > + "/site-packages"))) Hmm, don't both of these hard-code one profile? I thought one can use any number of profiles - and this patch could definitely pick from the wrong one. Why isn't the PLUGINS_USER setting enough? Can't it be provided via environment variables? (set by the profile) Also, shouldn't PYTHONPATH already have been set by the profile? For me, it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I log in. --Sig_/sF9ST=3xGEk3Z5QJpJGZWLu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlvtuJcACgkQ5xo1VCww uqX7Wwf/VcwanJSqE/4JWpJVnUf1b0BMPcHb1Ez7bBievsVcgZQztrObgVeilGjA NlH76K2RWaWILgXdW1FFlAXjikEgTJrfR5u4pahaz+cXPMkDcSffpNhfB3mbY8RJ +dmCLpJRGUOdMyWIp1xsmCBSsfDYHlJQFoTGnO1JayU8lVNi0qjO2dSycpkxbO4Y 5opD1FKTFC0HXudQWHnZNBELCkyOuZzD17n+LVPBZwySiHhVviY3EjvHLSYI7wxP 0I/e/1vMMEFwsb0x38CeUlBAxjxT2wwxWXvYe5Lx6ISEJXaEaznuyQEFEkXR1UW5 /R8fUaaxvC8sixpQUKc4x+jhtLeikg== =t6d8 -----END PGP SIGNATURE----- --Sig_/sF9ST=3xGEk3Z5QJpJGZWLu-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 16 05:14:03 2018 Received: (at 33386) by debbugs.gnu.org; 16 Nov 2018 10:14:03 +0000 Received: from localhost ([127.0.0.1]:54784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNb8U-0001zj-H9 for submit@debbugs.gnu.org; Fri, 16 Nov 2018 05:14:03 -0500 Received: from mail.lassieur.org ([83.152.10.219]:40164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNb8S-0001zC-J2 for 33386@debbugs.gnu.org; Fri, 16 Nov 2018 05:14:01 -0500 Received: from newt (smtp.parrot.biz [62.23.167.188]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id c9a6172f (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Fri, 16 Nov 2018 10:13:59 +0000 (UTC) References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> <20181115191903.7f3db09b@scratchpost.org> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Danny Milosavljevic Subject: Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. In-reply-to: <20181115191903.7f3db09b@scratchpost.org> Date: Fri, 16 Nov 2018 11:13:58 +0100 Message-ID: <87efblz5w9.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33386 Cc: 33386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Danny, Danny Milosavljevic writes: > Hi Cl=C3=A9ment, > > On Wed, 14 Nov 2018 20:55:52 +0100 > Cl=C3=A9ment Lassieur wrote: > >>+ (add-after 'unpack 'add-plugin-dirs >>+ (lambda _ >>+ (substitute* "gajim/common/configpaths.py" >>+ (("_paths\\['PLUGINS_USER'\\]") >>+ (string-append >>+ "_paths['PLUGINS_USER'],os.path.expanduser" >>+ "('~/.guix-profile/share/gajim/plugins')"))) >>+ #t)) > > [...] > >> + (pythonpath (string-append >> + "$HOME/.guix-profile/lib/python" >> + ,(version-major+minor >> + (package-version python)) >> + "/site-packages"))) > > > Hmm, don't both of these hard-code one profile? I don't understand what this means. > I thought one can use any number of profiles - and this patch could > definitely pick from the wrong one. What do you mean? This patch just adds the Guix packaged plugins to the list of plugin dirs. > Why isn't the PLUGINS_USER setting enough? Because it doens't know about Guix installed plugins. It doesn't look in ~/.guix-profile/whatever. Only at /gnu/store/...-gajim/something and ~/.local/share/gajim/something. > Can't it be provided via environment variables? (set by the profile) Gajim doesn't seem to support customizing plugin dirs through environment variables, which is why I edited its code. > Also, shouldn't PYTHONPATH already have been set by the profile? For > me, it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I > log in. It shouldn't be in the profile if python isn't installed. Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 18 18:16:05 2018 Received: (at 33386) by debbugs.gnu.org; 18 Nov 2018 23:16:05 +0000 Received: from localhost ([127.0.0.1]:59484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOWIP-0008PC-KU for submit@debbugs.gnu.org; Sun, 18 Nov 2018 18:16:05 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:48602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOWIN-0008P3-Q2 for 33386@debbugs.gnu.org; Sun, 18 Nov 2018 18:16:04 -0500 Received: from localhost (178.113.191.65.wireless.dyn.drei.com [178.113.191.65]) by dd26836.kasserver.com (Postfix) with ESMTPSA id F2353336181B; Mon, 19 Nov 2018 00:16:01 +0100 (CET) Date: Mon, 19 Nov 2018 00:15:55 +0100 From: Danny Milosavljevic To: =?ISO-8859-1?Q?Cl=E9ment?= Lassieur Subject: Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. Message-ID: <20181119001555.2a18946d@scratchpost.org> In-Reply-To: <87efblz5w9.fsf@lassieur.org> References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> <20181115191903.7f3db09b@scratchpost.org> <87efblz5w9.fsf@lassieur.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/covDa14bh8+capIwdple8Ri"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33386 Cc: 33386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/covDa14bh8+capIwdple8Ri Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Cl=C3=A9ment, > I don't understand what this means. > > I thought one can use any number of profiles - and this patch could > > definitely pick from the wrong one. =20 >=20 > What do you mean? This patch just adds the Guix packaged plugins to the > list of plugin dirs. guix supports any number of profiles as one user, the ~/.guix-profile one i= s just the default, you can create and select profiles at will. You can specify any profile you want using the option "-p" to "guix package= " - also, "guix environment" will create a custom profile. However, your patch hardcodes ~/.guix-profile which is in general not what = a user using "-p" would want. I agree that it makes sense to search for the plugi= ns in the current profile, but it's not clear to me that ~/.guix-profile is always guaranteed to BE the current profile. Is it? According to https://www.gnu.org/software/guix/manual/en/html_node/Invoking= -guix-environment.html#FOOT16 , fontconfig already hardcodes ~/.guix-profile and "guix environment" has a special flag to fake it, so maybe (probably?) it's OK to use it after all. I hope someone else can chime in - but this is what immediately caught my eye because what's the use of all these environment variables if one hard-codes ~/.guix-profile anyway - could have hard-coded it in all package= s, then... > > Why isn't the PLUGINS_USER setting enough? =20 >=20 > Because it doens't know about Guix installed plugins. It doesn't look > in ~/.guix-profile/whatever. Only at /gnu/store/...-gajim/something and > ~/.local/share/gajim/something. >=20 > > Can't it be provided via environment variables? (set by the profile) = =20 >=20 > Gajim doesn't seem to support customizing plugin dirs through > environment variables, which is why I edited its code. In general that's OK. > > Also, shouldn't PYTHONPATH already have been set by the profile? For > > me, it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I > > log in. =20 >=20 > It shouldn't be in the profile if python isn't installed. Oh, makes sense. --Sig_/covDa14bh8+capIwdple8Ri Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlvx8qsACgkQ5xo1VCww uqXKOgf/aLfMt5CZIX3ikj+nSnf3l0VCLOdF9ps9nFe0tPi5eEoIp5uEHwfLyyof 9uzzyU5+uTt7HslfzTpLOEg/H5rF1KsSruVFh1Z0VOtYRXbpVIFAYyI7tyPTMAaE AgjYhycp1cygdC5jsVk/r9RgzeD/8HjOGDxZxb9iw3qAxYLu4UDxk4+5oru1nHcp C0e7F8x87fiX7hxtyOUsjGxQDlFU5xV5CyPyJnXJcy9Q2SDMHIedcE+NUu3nDG+n R9OVoeeU2tPl7pexddqU2xqmct556A6awQXy109W8RgmuoFaH/IZwWBdukcSbklk iXLfpSh88U8nGRRMKibCSoxgeeg3gg== =QhvN -----END PGP SIGNATURE----- --Sig_/covDa14bh8+capIwdple8Ri-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 19 11:01:57 2018 Received: (at 33386) by debbugs.gnu.org; 19 Nov 2018 16:01:57 +0000 Received: from localhost ([127.0.0.1]:32863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOlzp-0004ea-AE for submit@debbugs.gnu.org; Mon, 19 Nov 2018 11:01:57 -0500 Received: from mail.lassieur.org ([83.152.10.219]:40390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOlzm-0004c1-VU for 33386@debbugs.gnu.org; Mon, 19 Nov 2018 11:01:55 -0500 Received: from newt.Parrot.biz (smtp.parrot.biz [62.23.167.188]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 5d914d72 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <33386@debbugs.gnu.org>; Mon, 19 Nov 2018 16:01:53 +0000 (UTC) From: =?UTF-8?q?Cl=C3=A9ment=20Lassieur?= To: 33386@debbugs.gnu.org Subject: [PATCH] gnu: gajim: Add support for Guix packaged plugins. Date: Mon, 19 Nov 2018 17:01:40 +0100 Message-Id: <20181119160140.26199-1-clement@lassieur.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119001555.2a18946d@scratchpost.org> References: <20181119001555.2a18946d@scratchpost.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33386 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/messaging.scm (gajim)[inputs]: Remove python-axolotl. [arguments]: Add an 'add-plugin-dirs' phase. [native-search-paths]: New field. --- gnu/packages/messaging.scm | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index c22cacfd3..4aea1fd7d 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -588,6 +588,12 @@ was initially a fork of xmpppy, but uses non-blocking sockets.") `(#:test-target "test_nogui" #:phases (modify-phases %standard-phases + (add-after 'unpack 'add-plugin-dirs + (lambda _ + (substitute* "gajim/common/configpaths.py" + (("_paths\\['PLUGINS_USER'\\]") + "_paths['PLUGINS_USER'],os.getenv('GAJIM_PLUGIN_PATH')")) + #t)) (add-after 'install 'wrap-program (lambda* (#:key outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out"))) @@ -625,6 +631,18 @@ was initially a fork of xmpppy, but uses non-blocking sockets.") (,(string-append (assoc-ref inputs "gtk+") "/share/glib-2.0/schemas")))) #t))))) + (native-search-paths + (list (search-path-specification + (variable "GAJIM_PLUGIN_PATH") + (separator #f) ;single entry + (files '("share/gajim/plugins"))) + ;; Gajim needs to use the propagated inputs of its plugins. + (search-path-specification + (variable "PYTHONPATH") + (files (list (string-append + "lib/python" + (version-major+minor (package-version python)) + "/site-packages")))))) (native-inputs `(("intltool" ,intltool) ("python-docutils" ,python-docutils) @@ -636,7 +654,6 @@ was initially a fork of xmpppy, but uses non-blocking sockets.") ("gtkspell3" ,gtkspell3) ("hicolor-icon-theme" ,hicolor-icon-theme) ("libsecret" ,libsecret) - ("python-axolotl" ,python-axolotl) ("python-cssutils" ,python-cssutils) ("python-dbus" ,python-dbus) ("python-gnupg" ,python-gnupg) -- 2.19.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 19 11:02:41 2018 Received: (at 33386) by debbugs.gnu.org; 19 Nov 2018 16:02:41 +0000 Received: from localhost ([127.0.0.1]:32868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOm0W-00058f-OM for submit@debbugs.gnu.org; Mon, 19 Nov 2018 11:02:41 -0500 Received: from mail.lassieur.org ([83.152.10.219]:40394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOm0U-00056k-OI for 33386@debbugs.gnu.org; Mon, 19 Nov 2018 11:02:39 -0500 Received: from newt (smtp.parrot.biz [62.23.167.188]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id a52a5a2d (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Mon, 19 Nov 2018 16:02:37 +0000 (UTC) References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> <20181115191903.7f3db09b@scratchpost.org> <87efblz5w9.fsf@lassieur.org> <20181119001555.2a18946d@scratchpost.org> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Danny Milosavljevic Subject: Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. In-reply-to: <20181119001555.2a18946d@scratchpost.org> Date: Mon, 19 Nov 2018 17:02:36 +0100 Message-ID: <878t1pjbs3.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33386 Cc: 33386@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Danny Milosavljevic writes: > Hi Cl=C3=A9ment, > >> I don't understand what this means. >> > I thought one can use any number of profiles - and this patch could >> > definitely pick from the wrong one.=20=20 >>=20 >> What do you mean? This patch just adds the Guix packaged plugins to the >> list of plugin dirs. > > guix supports any number of profiles as one user, the ~/.guix-profile one= is just > the default, you can create and select profiles at will. > > You can specify any profile you want using the option "-p" to "guix packa= ge" - > also, "guix environment" will create a custom profile. > > However, your patch hardcodes ~/.guix-profile which is in general not wha= t a user > using "-p" would want. I agree that it makes sense to search for the plu= gins in > the current profile, but it's not clear to me that ~/.guix-profile is alw= ays > guaranteed to BE the current profile. Is it? > > According to https://www.gnu.org/software/guix/manual/en/html_node/Invoki= ng-guix-environment.html#FOOT16 , > fontconfig already hardcodes ~/.guix-profile and "guix environment" has a > special flag to fake it, so maybe (probably?) it's OK to use it after all. > > I hope someone else can chime in - but this is what immediately caught my > eye because what's the use of all these environment variables if one > hard-codes ~/.guix-profile anyway - could have hard-coded it in all packa= ges, > then... Understood, thanks for this nice explanation! I attached a new patch. What do you think? Thanks, Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 05:22:19 2018 Received: (at 33386-done) by debbugs.gnu.org; 11 Dec 2018 10:22:19 +0000 Received: from localhost ([127.0.0.1]:42820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWfBD-00049m-El for submit@debbugs.gnu.org; Tue, 11 Dec 2018 05:22:19 -0500 Received: from mail.lassieur.org ([83.152.10.219]:39832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWfBB-00049c-D5 for 33386-done@debbugs.gnu.org; Tue, 11 Dec 2018 05:22:18 -0500 Received: from newt (smtp.parrot.biz [62.23.167.188]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 3833eb57 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Tue, 11 Dec 2018 10:22:15 +0000 (UTC) References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> <20181115191903.7f3db09b@scratchpost.org> <87efblz5w9.fsf@lassieur.org> <20181119001555.2a18946d@scratchpost.org> <878t1pjbs3.fsf@lassieur.org> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Danny Milosavljevic Subject: Re: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. In-reply-to: <878t1pjbs3.fsf@lassieur.org> Date: Tue, 11 Dec 2018 11:22:14 +0100 Message-ID: <87o99s8isp.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33386-done Cc: 33386-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Cl=C3=A9ment Lassieur writes: > Danny Milosavljevic writes: > >> Hi Cl=C3=A9ment, >> >>> I don't understand what this means. >>> > I thought one can use any number of profiles - and this patch could >>> > definitely pick from the wrong one.=20=20 >>>=20 >>> What do you mean? This patch just adds the Guix packaged plugins to the >>> list of plugin dirs. >> >> guix supports any number of profiles as one user, the ~/.guix-profile on= e is just >> the default, you can create and select profiles at will. >> >> You can specify any profile you want using the option "-p" to "guix pack= age" - >> also, "guix environment" will create a custom profile. >> >> However, your patch hardcodes ~/.guix-profile which is in general not wh= at a user >> using "-p" would want. I agree that it makes sense to search for the pl= ugins in >> the current profile, but it's not clear to me that ~/.guix-profile is al= ways >> guaranteed to BE the current profile. Is it? >> >> According to https://www.gnu.org/software/guix/manual/en/html_node/Invok= ing-guix-environment.html#FOOT16 , >> fontconfig already hardcodes ~/.guix-profile and "guix environment" has a >> special flag to fake it, so maybe (probably?) it's OK to use it after al= l. >> >> I hope someone else can chime in - but this is what immediately caught my >> eye because what's the use of all these environment variables if one >> hard-codes ~/.guix-profile anyway - could have hard-coded it in all pack= ages, >> then... > > Understood, thanks for this nice explanation! > > I attached a new patch. What do you think? I pushed it. I'll be happy to improve it if you have other comments. Thanks, Cl=C3=A9ment From unknown Thu Aug 21 12:10:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 Jan 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator