From unknown Wed Jun 18 23:03:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33301 <33301@debbugs.gnu.org> To: bug#33301 <33301@debbugs.gnu.org> Subject: Status: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." Reply-To: bug#33301 <33301@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:03:39 +0000 retitle 33301 27.0.50; broken elisp indentation for non-definition symbols = starting with "def.." reassign 33301 emacs submitter 33301 Jo=C3=A3o T=C3=A1vora severity 33301 minor tag 33301 confirmed moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 07 08:21:59 2018 Received: (at submit) by debbugs.gnu.org; 7 Nov 2018 13:21:59 +0000 Received: from localhost ([127.0.0.1]:38237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKNmR-0003HB-4X for submit@debbugs.gnu.org; Wed, 07 Nov 2018 08:21:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKNmP-0003Gy-Cw for submit@debbugs.gnu.org; Wed, 07 Nov 2018 08:21:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKNmJ-00044e-Mz for submit@debbugs.gnu.org; Wed, 07 Nov 2018 08:21:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKNmJ-00044U-Ii for submit@debbugs.gnu.org; Wed, 07 Nov 2018 08:21:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKNmI-00027D-Qr for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 08:21:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKNmD-00042O-UW for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 08:21:50 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:43300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKNmD-000417-O4 for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 08:21:45 -0500 Received: by mail-wr1-x429.google.com with SMTP id y3-v6so17072485wrh.10 for ; Wed, 07 Nov 2018 05:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=g7wf7Qb1huWy/rCn5qlMzpSstg7RthddRGs0+QYT4k8=; b=KjXCXzPvYIBEe5X/Yg+cw+oQ2ag0qA4cUBLmEvKI6zuVlIbHdiJxHSFmpXJKkdteXg 1DH/+EHalnr6mx/yM+plh5mA6SdywR+BKiwdm/lD8NLQ6fBtburjwqNUhAYqBJnDaUVh fY6IhNaknaepkGog7WnS4wu7VOkHvya+10aME71MShUJNBB9M3z54IWCuZgnU4YtZ/Nw wKnaYHuzU9Ns8MsLuvh4Hd2gppBNVsbip6f2OKU5GJxN7HXEC7MyMIbz9JK7Fwciq7GY mRmKLVCWFjUXKfsP/gx+y/2uolKYZeKg97dCpa7LtsFj57i3uv4UBm1VxU4Y50kTpf4W g8gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=g7wf7Qb1huWy/rCn5qlMzpSstg7RthddRGs0+QYT4k8=; b=mqiYwoSeANvIM3s7UFGmpHRK49HvQmtRqHfJ6WzG3f9+HT02spmT38SMCKiMU8AGgS 23PEwLkOx4sZm30ryMYMdObFlVS3pTAR2gVcdDmTtyaaBlcO7OSpftMBv+ySw4AOsKFs +hQZlzbOpU2KFgtH4CCW8jtWCMU71gZEOy5ssmKOARYmYb9+2sRW8fV/YLuyvLr9hjj/ 9fi8PjAO8gUqloNnBzJPX6RCXzlMJ9eNeH8A4OVBxBKSCvgZLggQJLPrx32p9zh5X2k6 YU3k3glm1wj5wXEMteQCYpCt1k6HmlvSGt4h2dI6xj7NPBV1s1saRAwprd7+OyRz9njx /fcg== X-Gm-Message-State: AGRZ1gL0pdHniL7lkiB+erz8NdoQ01he4qcd1/cmgSFbV9W2nOtxBklD siDg5rhcaDzaE7ZlftuhW1CJxQ/0 X-Google-Smtp-Source: AJdET5cNBZcjwHI5ch3l5hfA5e65JNqzBhCEsQF97z34eJJdhwgMbP5Wy4MyA2hYFZja5Mixpl0Z0A== X-Received: by 2002:adf:8043:: with SMTP id 61-v6mr181109wrk.23.1541596903447; Wed, 07 Nov 2018 05:21:43 -0800 (PST) Received: from GONDOMAR.yourcompany.com (mail1.siscog.pt. [89.115.233.242]) by smtp.gmail.com with ESMTPSA id c24-v6sm854504wre.30.2018.11.07.05.21.42 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Nov 2018 05:21:42 -0800 (PST) From: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= To: bug-gnu-emacs@gnu.org Subject: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." Date: Wed, 07 Nov 2018 13:21:39 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Antivirus: AVG (VPS 181107-0, 07-11-2018), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi maintainers, This doesn't seem the correct indentation for the following elisp forms: (let ((bla (ok)) (defan (strange)))) (cond (bla ok) (defan strange)) ...but that's the way Emacs -Q does it. I'd be suprised if this weren't a duplicate, but I thought I'd report it just in case. Thanks, Jo=E3o From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 07 19:05:46 2018 Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 00:05:46 +0000 Received: from localhost ([127.0.0.1]:40133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKXpS-0002SV-I0 for submit@debbugs.gnu.org; Wed, 07 Nov 2018 19:05:46 -0500 Received: from mail-it1-f176.google.com ([209.85.166.176]:35470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKXpQ-0002S3-KJ; Wed, 07 Nov 2018 19:05:44 -0500 Received: by mail-it1-f176.google.com with SMTP id v11so19431027itj.0; Wed, 07 Nov 2018 16:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=9CnZ05ixbUsZ2hIyBf8zYZcA74k6ub1ePjDfmxC+tDk=; b=TomKQPHA6gBbDDm2yvwuoVXj91AcCj/lhNPZcIBUAyog6qMseXCI5xjod5HOfHC+nb nX2IdSrJqdCpp2PfbC7GF3D6YbBQ6SODe9cZKNn9LZ/Ohd4AS/e8F8MjiwHbGf0cz+yT HSLnxcgQLhxjiZwCq/D+JbNEpqryuqJ505pG8GRnUKT9z6thRzC5NqtedTMnMXx0Xejh fif7+AZY1tnZW/emiZGbVc1REeOgflPZvxIAISMlHcq56ype5I0BqdsmHvQpl5La0H8I 7Dfw2KhSmDgj9DGdMZmWGuBd8oZrnrQ+nweQ4vIfqR+OAfrld5D67MtzF/Iw6j/+N8g7 trpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=9CnZ05ixbUsZ2hIyBf8zYZcA74k6ub1ePjDfmxC+tDk=; b=hKO61y1AsArI2EQd2Ppx97lnQIuotYSexuJ6wOpfcpfXtZDueLstn12og3FpvS93V/ j17wHUlS6ThK82ebeBQeJh+lyNGMJ4QaelMBPjxuWaauoiGmIKb6QxOGXP1RF4moekXN U7CQXy3qnX2ysn69/n1A4itcAgO8jH9rzbT6GN3H5FderM1o7zJ6mQhd1zMLNhbHm/le Q+fpyWzYMUeKPSQ2DRCweXg/PTbF3BDxIRLSFTWi498rZ+t6gfmfOhNEXkp8zQ3oTvP/ kVqVzD6Qcxag4LX0h2FAplBRfB31GrAY35SufsvYo17ss7M3rcE2xfKsUydJgX366W5u 0I4w== X-Gm-Message-State: AGRZ1gK5RoYjnIkyWLm5eMpKdLY8fFMCSAJKwTT/cqs6XaO0lLL0Lk24 gRyNgVq5dIXPaZMYCBhwHnvtLpgo X-Google-Smtp-Source: AJdET5cXSDX8T6UuBrYRuZ8R0u9SQ+eRMguaIFc1UnA31JC1HJl3F/ZPUjt3YxjbOliWSOJodTasPA== X-Received: by 2002:a02:3b12:: with SMTP id c18-v6mr2016935jaa.11.1541635538934; Wed, 07 Nov 2018 16:05:38 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w124-v6sm440507ita.0.2018.11.07.16.05.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Nov 2018 16:05:38 -0800 (PST) From: Noam Postavsky To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: Date: Wed, 07 Nov 2018 19:05:37 -0500 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vo?= =?utf-8?Q?ra=22's?= message of "Wed, 07 Nov 2018 13:21:39 +0000") Message-ID: <87zhukh1ri.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 33301 24.3 tags 33301 + confirmed quit Jo=C3=A3o T=C3=A1vora writes: > This doesn't seem the correct indentation for the following elisp forms: > > (let ((bla > (ok)) > (defan > (strange)))) > > (cond (bla > ok) > (defan > strange)) > > ...but that's the way Emacs -Q does it. I'd be suprised if this weren't > a duplicate, but I thought I'd report it just in case. I can't find any duplicate, though it's certainly not new. Bug#9622 and Bug#23108 are sort of related. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 07 19:35:50 2018 Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 00:35:50 +0000 Received: from localhost ([127.0.0.1]:40142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKYIY-0005HE-2C for submit@debbugs.gnu.org; Wed, 07 Nov 2018 19:35:50 -0500 Received: from mout.web.de ([217.72.192.78]:57637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKYIW-0005H0-TZ for 33301@debbugs.gnu.org; Wed, 07 Nov 2018 19:35:49 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LzKIP-1fP41v07qz-014RFf; Thu, 08 Nov 2018 01:35:42 +0100 From: Michael Heerdegen To: Noam Postavsky Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> Date: Thu, 08 Nov 2018 01:35:41 +0100 In-Reply-To: <87zhukh1ri.fsf@gmail.com> (Noam Postavsky's message of "Wed, 07 Nov 2018 19:05:37 -0500") Message-ID: <87tvksv21u.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Hj/125RYC8aBc2nbOD2nmMlVvitY/VEy1pyERSUe1doRSHc2C/u eJzJE5GroWqfVvcxyrbhtFLn4d9CwkTJ0/jl37k3Gb4nLSf5KnOy/hv2okfmvw9bgZp8cV4 B5cfBcl3WslElwIzLnw+f/7hyxxoV8DaV+X7nVyP847maFTC4Nyq0PsYi4v1JSyG+DPSXQ6 HNcyMdoNpThx3PO3UOJbA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:oxUi+OaiUto=:fXPGxSzkjPTKoPD2MCQ9z0 JBWkn54vkMmFmK/k4FdfRVk9x25lnYJvfYSBM6XZsFIowsuDU6Z/JSsV/jpDQ6u+9uAbBZ2iq 1jJz+ztJ9/LVEo6PxeFcGvO/elZEHKIlXm+IdJQyzUTzR+i5qJ9ByAqLC6B8sB9yoH+e/PXj+ LlAsAQTnAuwjPqxQE0waA9bgDxPzg3CXK6/Jfc5+Dh6QS603ZF5U6ZQqxawwkFRz0kj70XgeL +STS01dE81qiw1fuKTeq9OrZkN7dalHChW9o0XtjeE1SknTg7ONg5/psiseFpfhFFYCRleBTe ik/Cxd50z7UaCn11phWHZpfGjkkJ+IDxQpo3t8s01uFsbxcZDXwZmfZiwu7pGWcClxW6old9l 0HfafhygzGji/yJtipFEXkjXn3TlcvLKETRqmXaG3aEnDkUCqhfXI+LlGGBCf0YWoarCEWDx5 kcZnNl9l3gZEe7px8MCNZbu5yGRpxhOWLcxl/bhJ24kEKUR73iwObrH6MmMZNTWlQ+ztAEeyg tSzMP47KgT2nHGqP/xNBnbTqWrWuRgb82cLRfAQZCxIPCEl8ASvaijtzKj3A7m+60YlyiVlGP stS7l8kkROuK0dpVn4VYEpaXIqtyf4fAY0ZJXppUjmKcRxUXn9d85NnJOQMysr6MLzH/6/YoY qwSkeHSn23RnXV5YxYxPsUYHr4FjtpJyng3wST4fEF+ML6LHMHNycBtK6OMfmfbNo4Xcuz0+Q tWL9oB9JXs36EuEVdh7hsWOZxg+hl2ksZpYc8j7IVYOVSOB/KyVv9h20tbStf3tKdnhE2qIne zC4ESz/BHCBvNjj76lR4UBCcrMvOewKwtD9g0JBwGv9rCzLWKthFtM5rhBsRbOs76i/MOgug4 xsSfmMivXL7kvD5/Ep6NhGzzSubHNQvp2MmrGya9/i/VBEYNrDviSw5ZL5ioeCevZCrOaQm3q k0FpUsFZBQg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Noam Postavsky writes: > > (cond (bla > > ok) > > (defan > > strange)) That's explicitly done in 'lisp-indent-function': (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) (string-match "\\`def" function))) ;; <== (lisp-indent-defform state indent-point)) ((integerp method) (lisp-indent-specform method state indent-point normal-indent)) (method (funcall method indent-point state))) Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 08 04:53:06 2018 Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 09:53:06 +0000 Received: from localhost ([127.0.0.1]:40316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgzn-0003ul-Tg for submit@debbugs.gnu.org; Thu, 08 Nov 2018 04:53:04 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgzm-0003uG-6S for 33301@debbugs.gnu.org; Thu, 08 Nov 2018 04:53:02 -0500 Received: by mail-wm1-f48.google.com with SMTP id b203-v6so549913wme.5 for <33301@debbugs.gnu.org>; Thu, 08 Nov 2018 01:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=qA40eBDyTuiGQrraD+zY4a9WtsFVyUeqYfei+msKoIg=; b=EgNHcQFpJ955i2TRHeETE7niGbIMtakSSqlGlbnaQxjBqCfi5xLPo+ru7CoKngOLjF S4Dm7CkH2EVjdjAo0dawjcCr/2wCRPBjvb/OPrk55jWf+DZ5uyv+tjhOqIJ42qyLTkos E75NPOhRgItKlN+VfBfA5OxjaZJ0EKz1z7NfcfhrCFAayPAB6JjbSLNlPxOwYFLOGKnU LWdaioit4CrNGQyEPGGCBarl8J3SjnAaMbIZ9/MwRbvi05e+WjXSauGGqu9DAXwkCQUT Tsbgu7fk8XAgOhxYI9Ra1EH3SR2Sa+L/QTwTFuhNksprZVik0Bd4ZI2WGZNTqX3X+iiK ccjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=qA40eBDyTuiGQrraD+zY4a9WtsFVyUeqYfei+msKoIg=; b=kd3br5xUIpS3GlrHWSJpnbpIHVkDdlzc7qATYvXt94SRhD96c9r7sS2EoKTy0y5R9V Av2zU1L8yaeNWWIBJwYVjAuTQ9dal0yK9y4veFdz2Swhc3w06x6evzWzGkQHNbyZXKEw CTQMf65RUmyL/YmBnZpt/nvPWAlPW3JHjg9yhTIAyUuOSZiU3fR4ve2C2mskRPyJSgo3 9LPb3XfdOpk4ESSWXAUk3+1y1KBPFEKZZQgOhpd1EpnEy3tUO3AvWpaT1oFwV0gqgKTg m9zn0RhDazbQ+F97NhfnT1uB5xC+MxL9krExsDaup8qO/DVD7pHOCowAdBGDQJj/ZgYF QMoA== X-Gm-Message-State: AGRZ1gJlV1udyt8bVHezbl8K/HtMY2RMCAqLzaJjnnPy0w+lBxzKyw3A 5v5BJEv0ng4c+ZRPpQIYHE96Jc4V X-Google-Smtp-Source: AJdET5cepb3kCJR+OAB+uWMQrAFdHzQ/6JWiBLrEqPYmx6/SKAYcIdI8+U4VZtfOifs0yw4Ka+HMLQ== X-Received: by 2002:a1c:6a09:: with SMTP id f9-v6mr618935wmc.78.1541670775163; Thu, 08 Nov 2018 01:52:55 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id s195-v6sm2635604wmd.39.2018.11.08.01.52.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 01:52:54 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Michael Heerdegen Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." In-Reply-To: <87tvksv21u.fsf@web.de> (Michael Heerdegen's message of "Thu, 08 Nov 2018 01:35:41 +0100") References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Thu, 08 Nov 2018 09:52:51 +0000 Message-ID: <87efbvrj4c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Michael Heerdegen writes: > Noam Postavsky writes: > >> > (cond (bla >> > ok) >> > (defan >> > strange)) > > That's explicitly done in 'lisp-indent-function': > (and (null method) > (> (length function) 3) > (string-match "\\`def" function))) ;; <=3D=3D Ah, that's unfortunate. Still, coundn't we improve the heuristic by asking if the "function" has a macro definition? Isn't that closer to the intended behaviour? diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index afb7cbd1dd..e7373ece85 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1104,7 +1104,8 @@ lisp-indent-function (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) - (string-match "\\`def" function))) + (string-match "\\`def" function) + (macrop (intern function)))) (lisp-indent-defform state indent-point)) ((integerp method) (lisp-indent-specform method state Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 08 19:13:28 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 00:13:28 +0000 Received: from localhost ([127.0.0.1]:42019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKuQS-0006YR-JN for submit@debbugs.gnu.org; Thu, 08 Nov 2018 19:13:28 -0500 Received: from mout.web.de ([212.227.17.11]:44631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKuQR-0006YD-M7 for 33301@debbugs.gnu.org; Thu, 08 Nov 2018 19:13:28 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M7KR8-1fXkJy45n4-00x15t; Fri, 09 Nov 2018 01:13:21 +0100 From: Michael Heerdegen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> Date: Fri, 09 Nov 2018 01:13:20 +0100 In-Reply-To: <87efbvrj4c.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Thu, 08 Nov 2018 09:52:51 +0000") Message-ID: <8736sbumzj.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:eUacmPoL4fjZYZBKiizXEFZNCJg62o/Rqls1CMGgXf+IR9S0JGk xOEPM5TGvhz6eXH9QikRFGZgm53S8yTQe1MuzXayxrYmbXa3vnJk8vDUlhIb4KQbNA1QzCv eR/secZ7maJkEw2aG0sKblNFPYZEquIEJoxyPuST0HCFWvysCujnn1+r+i/tKz4BpVvDaz3 y2NFZKHjT2bH5jOOo+pSw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:hbkYesMovjM=:hojo1F5nD0O/VelwKjzz0f 7QxztlesmaJFldetbhx/XOYqNXwYfblKp99PVY1WpykX6H5HiurTg+HwA5T8hqX4/oWH+/0+W U8a7LDiOlGNtcemeypAwBCx8a/MVKAI3tk0YgAollgk52lnYBh/RK2fpsheLWHK38OvgplHnk zA9Z7OHNqTCeClU8rpax81sPCZ2KIAKe19Bgoyu7yJVLMeEF1JnmmZQVzCgW9CkdUZzxpKydD 9Sh3y0LjNNyQGO70WvulDHrQcLaHysOXh5ZkjB5Jg2JPWbRtoDg5NNlMwNlm2uAIGzQCwLim8 BxeBvc0pJYkiqzd67FgFKOHR5MAlbL/JaUiBkZLjOp/7v09mlTC2BwNQj1UQtQBHydclFmse7 UiVWdAVpl13pTVgxxJJoyruRbWeHzF1Se7YpxtZ+gA9Gb4TubYMqWBRIAAgHtrkjPutdQAnNH GJvhXIlS6kbxUVYE8chmq5fqFKtqAAuoAbRUhzN9l7Ix0//oLFk8v74kuzTkMYm/T7wc24e9E YcHXOkclSH3gE3mspDsqKjFbiODxMCXwMp3vzKkrQXhAmKneSquEVqCEp4H0uy7sOTf5MOo+7 zktnglJaSwLM5s0YTcSyYNzyUBMDRsycu3L9hUSzPn51QRiz5OvgcaGs135BA5MXIqIvNYp9p 7WVkuyUXkXBQGUURH+ufsc5zZ7S4jUoIBdTvsVGk2WZUDYtTyETea5ZNXrnNjKeb0Pk6vQ9JY 0N2xE94CS7c/PFSf5CxfzMqmLdQhgM+QOHUzGUdxdRQWV3K7TsW/CpkDngI03PkZPSNCSnTej KU4U8IaU89oO87pyr8IcYCGsK28pTPusbZu4uGcuyuaeMgqELhjwr7NeoACGhgO7c+Fih+90V mSiJgaAlMdy6XouuPU/8j9MLeaH5SpUG4h+rmxA+WUMcSw6bkwIkrty6CjoHVEWHRVQKMRX7r eOZ0iEx86+w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora writes: > Ah, that's unfortunate. Still, coundn't we improve the heuristic by > asking if the "function" has a macro definition? Isn't that closer to > the intended behaviour? > > diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el > index afb7cbd1dd..e7373ece85 100644 > --- a/lisp/emacs-lisp/lisp-mode.el > +++ b/lisp/emacs-lisp/lisp-mode.el > @@ -1104,7 +1104,8 @@ lisp-indent-function > (cond ((or (eq method 'defun) > (and (null method) > (> (length function) 3) > - (string-match "\\`def" function))) > + (string-match "\\`def" function) > + (macrop (intern function)))) > (lisp-indent-defform state indent-point)) > ((integerp method) > (lisp-indent-specform method state If that macro is defined, shouldn't it already be indented correctly without heuristics? Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 08 19:42:06 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 00:42:06 +0000 Received: from localhost ([127.0.0.1]:42041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKusA-0007Il-GQ for submit@debbugs.gnu.org; Thu, 08 Nov 2018 19:42:06 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:46339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKus8-0007IG-H5 for 33301@debbugs.gnu.org; Thu, 08 Nov 2018 19:42:04 -0500 Received: by mail-wr1-f47.google.com with SMTP id 74-v6so107566wrb.13 for <33301@debbugs.gnu.org>; Thu, 08 Nov 2018 16:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=8lAtZ31TdZi+ZLvCYLc3ufS+98v22j/dDkfQzeKWrb0=; b=FLe9fFs1Yz5FQzydqg2ScMNeJXFQB3dOd2UTCYZ65t1rXiRgmQUmgNtrQAseE/MSSE UVkCQMOV7iso7O5TLTHK7xf9Pyuc/8JLui7Bt/zNBnICl2n3yjrjloQ4asfDmZ3IuSWG Pt04m5YJ5O7lrZSISCS6hvy8ozr8d0wQ1R1P7GX2Y9qMd/YacE5eDsTCV+VVC/woztzr kK3z6h5KzZJs9ymvbe/tqS1eKSw2kO6S5qkna/42tyG+3HXwVR3eq6XV0Q3f/Xe1pFLy ipUp9E7NbJvxtBRKLvGSdoQfLRH3ktIPKZEVQ9172n3g/t94s0FX8qJBpdow8jDe7V3Y duZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=8lAtZ31TdZi+ZLvCYLc3ufS+98v22j/dDkfQzeKWrb0=; b=UGWDiLV45wWM2vItcbNYkE55xoXN4XxXa4rFHVOK5lt5pEC1KIhrV7FCXYil+aIAbN gH9g6OmLHZpvpXaNH6bIAqhOZ/mchD/Ie28VVH0PWEXTTyb+SZqMpiWylb7oUFhY5zXb /l2jpA8zZE5wG3vlDf8z/CvsDFb7EwdM/fFvv1SG2maj/pQtFpOD0Rs0mr+uifxuvXTP PuEkLjGAXewnvYOfNoWNKTJeoFOsddqAvV9VexrdohwUOlCxm6eEOjEQnu2vPLWtFcfc tzLl7NIhmZQ3Zw0aVlorw78YO8puKZijm1zSNbeYSn3mfTF3YgC4B3jfhzGCPIjW/J6/ 6ztg== X-Gm-Message-State: AGRZ1gIwQ4uNAHKn4TXOxsUVgrPeLK9hqzAA8qMDm243Xe+youqvzt56 hG3aKDm8eZgWLYEL+ojSvbqJjIEK X-Google-Smtp-Source: AJdET5dvGXE+8NOOECwY9sWTu1I736OBeEGG7heH/ucsuRDP3peuBNQ5XnEaZvFCkwSijwKoGydNIQ== X-Received: by 2002:adf:f589:: with SMTP id f9-v6mr6142549wro.281.1541724118296; Thu, 08 Nov 2018 16:41:58 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id r198-v6sm403336wmg.0.2018.11.08.16.41.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 16:41:57 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Michael Heerdegen Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> Date: Fri, 09 Nov 2018 00:41:53 +0000 In-Reply-To: <8736sbumzj.fsf@web.de> (Michael Heerdegen's message of "Fri, 09 Nov 2018 01:13:20 +0100") Message-ID: <87a7mjqdym.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Michael Heerdegen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> Ah, that's unfortunate. Still, coundn't we improve the heuristic by >> asking if the "function" has a macro definition? Isn't that closer to >> the intended behaviour? >> >> diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el >> index afb7cbd1dd..e7373ece85 100644 >> --- a/lisp/emacs-lisp/lisp-mode.el >> +++ b/lisp/emacs-lisp/lisp-mode.el >> @@ -1104,7 +1104,8 @@ lisp-indent-function >> (cond ((or (eq method 'defun) >> (and (null method) >> (> (length function) 3) >> - (string-match "\\`def" function))) >> + (string-match "\\`def" function) >> + (macrop (intern function)))) >> (lisp-indent-defform state indent-point)) >> ((integerp method) >> (lisp-indent-specform method state > > If that macro is defined, shouldn't it already be indented correctly > without heuristics? I don't think so, not without an explicit indent declaration spec in the macro definition. This may explain the string-match hack in the first place. I don't know the exact motivation of the hack, but it's been there since the initial 2001 revision of the file. Possibly before declare/indent existed? If you're suggesting removing it entirely, I don't oppose it. There's the downside that indentation relying on it would start to fail, but diffs normally spot that and this would encourage users to add proper indent (and edebug) specs to their macros. Otherwise, I think my macrop tweak does a slightly better job at avoiding false positives. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 08 20:45:12 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 01:45:12 +0000 Received: from localhost ([127.0.0.1]:42078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKvrD-0006Sf-Ns for submit@debbugs.gnu.org; Thu, 08 Nov 2018 20:45:11 -0500 Received: from mout.web.de ([212.227.15.14]:52969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKvrB-0006SH-OO for 33301@debbugs.gnu.org; Thu, 08 Nov 2018 20:45:10 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Ll30X-1fklgp1RTR-00annb; Fri, 09 Nov 2018 02:45:02 +0100 From: Michael Heerdegen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> Date: Fri, 09 Nov 2018 02:45:01 +0100 In-Reply-To: <87a7mjqdym.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 00:41:53 +0000") Message-ID: <877ehnowgy.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:NOkoWN6GVUXWjHZO2FCrM65EuIJU/kLUS9Zc0J95kxunNTmuyhW ARF2JfxVqN0WxrZKBfQN4RDdj6Dth7FG6HIY0RNbshg/6vQ1DjQSrcjTkRGRdTVbVswFi9a Ulox/K1mASHALYUJDH1CDuWeuDx0/3Frm5poUI49iuoQV2rY5FjGVsxnhIOK2RcMmVVypeB R9U4xZvzIwtE6gjPOxyLA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:4APIT+bPORA=:sDkALJbDlA9MhzAp5XDs/Y gjNUTFpalzvrwsaYRZfxlYg/uEIPyEXO2DSx8kSVAn3NEf0xd1C734L8lHKjQ6zLm+nDrYBEU 69dZy04zLuACb6wokVsyM3PwW6LlyIvP3aX8S7iq4dSmC/j1Y4Dl9zOXFj6jk/Q67JTdGaBIG 44h8rzmKYKvbhN63JC69QgZXmvUtrU1MItdBQ1cH3dKg88kjFHkFYITFriCbwV+9PrOk0lIt3 XLGjoJd+PZJNBHKvz1SHKvitYXWZ5H240IQgsp78OSY7snpsB8PDAm+syO8wqL/R4oDz+lqb9 6pLQy5bCK+2ApTN+/+dj3i8wGFCWF7wfVBKrmqccbCJECyD1wCqQaklOrIYZnyr1sbRwt+I5/ f1pQZnLC2KglQ5epJSi4xFssqLH9Fa22XNMPGRBJH/q0vKwIN5bZZ3GriqDSB+1HheucXW0wx bGtDtQ2qThqdMSwPMz0uE29cBQ0acNoWSM4inn3nAGTV7F2C34RywI69r/0B6GAKVMAkmQ9/N xJvczY/qSV/8SfEHWFVu1gG6CkKgbza77HZRWGWXW4+d1Lpi6JeMBa+uyqFWHzMlyRLA4C9tL i3KLhTs19wMHcQv+WxzF3aO2tvEEcWliFQDoD4mozv4JYVtJgvWqiTqTBIVh2QyI0b4uUHA8l OmRzsfNOEHl+0BQralxMqbZs0tkuf51bZtkcALFKitgyZ+/Rf2EglsoyWbSxrmXEh8sjeiwjn QVQYXz+t+zgvKF+xhaN+C9ZJlj5mEkS4nGR0sfVXmV3mWZYx9p84FE1DMuWsmK7Ui5Rxw9u51 U8SVrWx2kZS2Z4r6LyQMLHlHjoptiiCSMRqDNCgp45nWJ/R58VtD/t/FtwSE/2w5cWrwqjFBp uhigF8f5S/HNHJRHOwZtHORdWmH0vLXae4ALQBTsBy1Uu4QD8xiio9nYRHQ0/lhFbjrNGSz5A TdLIvOpNprw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora writes: > This may explain the string-match hack in the first place. I don't know > the exact motivation of the hack, but it's been there since the initial > 2001 revision of the file. Possibly before declare/indent existed? But wait, this is in lisp-mode.el which I remember is used not only for Elisp but also for other Lisps, right? So your patch could make things worse for editing Common Lisp, for example. For Elisp the heuristic doesn't make much sense, though, if the edited file is not loaded, it also prevents false negatives for macro uses of macros defined in that file. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 09 04:04:19 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 09:04:19 +0000 Received: from localhost ([127.0.0.1]:42190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL2iB-0002YL-1k for submit@debbugs.gnu.org; Fri, 09 Nov 2018 04:04:19 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:42639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL2i6-0002Y5-II for 33301@debbugs.gnu.org; Fri, 09 Nov 2018 04:04:17 -0500 Received: by mail-wr1-f41.google.com with SMTP id y15-v6so1032694wru.9 for <33301@debbugs.gnu.org>; Fri, 09 Nov 2018 01:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=iODe6YO8YQCYvEiDS4RztIEqmFqkIqgFim/NPkxsGZc=; b=JlmKqwWbWaYSZjuNU7pDSU1GBeu3RZgRLkzXzIf08YdOiN7o9jSCEIBadHzHhyLCVQ NZcSdiRjWJ/FCHsvHas/y8mDjUakVfEg9qzqo3dKgN+Fwld+qagbcuKTz1txqGATgfPs rLPY67Q1RyDUf9DSY7hlRyNUEhOIvYRgHouvOcW+3qnse1NFUHr2APWqNxav4tpAqMNj jeGyCqDSECqf5EZT063/zt/T2R2PXVaHscubfHgj4vENHxBtNzRzcsVYOjCa4SpceJdl 7/5Qkvib2dsgGbbqzN+uEEV4+KWkBpNUtj2f3qmyA8tjHBckxNxagq+pRSi7U+fLTkKs lWLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=iODe6YO8YQCYvEiDS4RztIEqmFqkIqgFim/NPkxsGZc=; b=TkR9dqc0NigqB9L5F3h5E/RzuRz0x/JGGb9357GpnjiXgxKmqP+hsTQftUTrCJdMap 1O6gwfZsCQKSCljLvP4tMiFferWqfl7YSIkD9/pmHQSQzFk+1eSmPtQnd/qAOIg5rbgm ot0kFwN+1LXyoadesURMuGT3WaZTcCUpU+Y3J07ElqwteOfXCM2V+5zg54au1mc9x7hn dp5vP2eB5CI12TeGlP15HnWFSfaPNPSV+mSu3f1Vdq2yGDASz6fDhI4Vi4Jqybw4vLci l5pYIuXuFjExQKp5AlaubKZX3L2qhuONndaf65OqL8MtIQduYN76r4VdN3bjMI9a1VrI zPnA== X-Gm-Message-State: AGRZ1gKljDlPqLAlcPxPIQCsmxPR9ndnTuCSMTJHCeGr0fGtTvrTDyOs RdXiWjzXohH52kAtz7mZ/q7Naz/J X-Google-Smtp-Source: AJdET5e/eiiH7DBn8hIivPxZUlQQb6KQOoppfK9DnYtR5p7OERNDp114MozTx1ieDaB1yz3fbwBujg== X-Received: by 2002:a5d:6105:: with SMTP id v5-v6mr7166505wrt.69.1541754247778; Fri, 09 Nov 2018 01:04:07 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id j40-v6sm4534928wre.48.2018.11.09.01.04.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 01:04:06 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Michael Heerdegen Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> Date: Fri, 09 Nov 2018 09:04:04 +0000 In-Reply-To: <877ehnowgy.fsf@web.de> (Michael Heerdegen's message of "Fri, 09 Nov 2018 02:45:01 +0100") Message-ID: <875zx6r5a3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Michael Heerdegen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> This may explain the string-match hack in the first place. I don't know >> the exact motivation of the hack, but it's been there since the initial >> 2001 revision of the file. Possibly before declare/indent existed? > > But wait, this is in lisp-mode.el which I remember is used not only for > Elisp but also for other Lisps, right? Well it's lisp/emacs-lisp/... ;-) > So your patch could make things worse for editing Common Lisp, for > example. OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere in that file. Or I would suggest (setq-local lisp-indent-function 'common-lisp-indent-function) in you hypothetical fancy-lisp-mode hook and has much better heuristics that don't cause the bug I've described. (But, as someone who writes CL for a living, if you're indenting CL with these heuristics, you've already lost. You should use SLY/SLIME which looks at the macroexpansion to understand what you're trying to indent.) > For Elisp the heuristic doesn't make much sense, though, if the edited > file is not loaded, it also prevents false negatives for macro uses of > macros defined in that file. I don't fully understand the "it also" part, but here's my take on this: If you're not loading the code, all things being equal, it's better to incorrectly re-indent existing "def"-macros (not defmacro) than to incorrectly indent new arbitrary "def"-forms anywhere in the AST. That's because it's a bad idea to re-indent code anyway, but indent new code happens all the time. Also, it's not a very good idea to indent without some form of evaluation anyway. Because of the indentation declaration, that ship has sailed long ago (and bon voyage). Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 09 04:52:05 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 09:52:05 +0000 Received: from localhost ([127.0.0.1]:42234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL3SP-0003hE-Ac for submit@debbugs.gnu.org; Fri, 09 Nov 2018 04:52:05 -0500 Received: from mout.web.de ([212.227.17.11]:55411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL3SN-0003gl-9f for 33301@debbugs.gnu.org; Fri, 09 Nov 2018 04:52:03 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LeLKb-1fiQtt1CN3-00qB5L; Fri, 09 Nov 2018 10:51:56 +0100 From: Michael Heerdegen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> Date: Fri, 09 Nov 2018 10:51:55 +0100 In-Reply-To: <875zx6r5a3.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 09:04:04 +0000") Message-ID: <87efbumvd0.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bF1nlPksIdGY3G0kYVjVjIw0ghJQlq0xtaPGyg27HcAM12l1mQ1 zUTqQ5GsFUSyvjGwvJut5D4anpbZ5sBuK/kPnSrIZkhIUz8pvzHeOpyNH8BSOXNZugWzUQ8 UYkmUyA+KuSZ16cww6VoAs0j4ZjmC0mHtLGLB8EEXh0HRWmYfLmYRKTmaJ7Lj30saxgPhga zDxStJmCCLHdJA77/7Ygw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:bvKHy4ndAhQ=:dQk64Kl6UmaVHZnBCtamSC Nh7rFFVALYLC70HBqvmMJTenF8mgfhixmQhAgtr7VDt/2duV5FjBUPG3w2hKFKuKPKJY9ETpY 1xGWl8+WwpJdaMohSMwKmYspZiQDvVQ+9r7iCHJvdYwaDcnlKsNZPd/vg5sRINR24tP/CJjti Ys6LaiqWN3R9N+ZJ2bnKj/a99EK0zXHc2ogQMZI9OLqAtv3QM5H7thEgEboMThq2BJHZJcySt 3rp9/JAU7y9+9nHsMIN5cSp5uo2qJz19Ud8X8vLXrSy6VUz4+37bKKyO6qzckx3T3zdhMq0E5 xUzW3HR32Bj9nSnFDww9f8av63Gkc72IXwZte5RO4SkYkkOoA6/KqCLRFIOYFY0+DXklrSMtw DENW1O3PvvOFf1N+6MCKdcDwRZGCW374QvklT+5ifr/ngRY8YVfc9MJ1T2JqwUpY+T+zn5xJF anyBP8vzuII9BKQxDTm0sDcXuXWxoIBPH1f0zkj1MxJX9Vm3MBFlauOUjenI9ptsuPir1cemH iv5Fc2mvjpftQOVWiJykAhSY2CgrhJ4jrT63bNrJ6a9qhQFimopUjo7d6KCrnPpWxW7cBmByr 2y4OlrG2OYn62bjjIH6pwPG51YgHV2VkEX9uF9lSqX35UYeL+dm5TaP1O56PfzcEEFIoar2TP RtxlS+4zIpOUx7i3pCKR1t7iCpMHnf5OV43PyoOnaN35r9j1J9T1LA4vCfQG9MvZaYPjJ9I73 IG6lY4+XAn9blGo7BsmE0MQhhysXeaTDJP0JEa8/U91B4UG6naxE51nsfw+Opm+nzEelNCuHG tuZ8s5jdb/RDFjTIB982Z9ikKw0zekM97KsTAHZsvNzf+3fQi0OnFcyMtYJNB/1dtg5NzBGik 8HH48A1jM2+zCbDfsHrwu4CB2QNPzoNi+YFDnjUaDKhHUpFbjK0h91S61sYjuPMbC6fRANGKS EDW3FEPND1Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora writes: > OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere > in that file. I think we could do that, but I don't feel qualified to decide. Maybe Noam can help. A quick search shows that the "\\`def" trick is also performed elsewhere, btw: `common-lisp-indent-function-1' does it in one place, and also `scheme-indent-function'. As far as the example in your bug report is concerned, I think it would also be an improvement if elisp-mode wouldn't try be clever in such a way when indenting branches in a cond or variable associations in a let. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 09 07:29:04 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 12:29:04 +0000 Received: from localhost ([127.0.0.1]:42293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL5uI-0001EO-QP for submit@debbugs.gnu.org; Fri, 09 Nov 2018 07:29:04 -0500 Received: from mail-it1-f177.google.com ([209.85.166.177]:34627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL5uG-0001Dp-W5 for 33301@debbugs.gnu.org; Fri, 09 Nov 2018 07:29:01 -0500 Received: by mail-it1-f177.google.com with SMTP id t189-v6so4332862itf.1 for <33301@debbugs.gnu.org>; Fri, 09 Nov 2018 04:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=h9QvRkOPRvA4ZRQrb0zyoEWZsv1bz/9Qyosofny8jZY=; b=NIqT7s/1c8/RdOxSdTxkwar3In1azWwYl0S0sfV+RdQK+hycanWRYyAgnBwFe/WW+n 2B7hQ1fkAT41a2Vs3raLswUlJz1G4T2lcxo/ukvXe7r7ZVCPt1Siwm87z6VxxF08Eng/ gh1zG27p9sxfcoZGcmQ/C45c0zHrmEP8ZAAidKfqTu+AZ2aJzg9o/X1XNxbF7klgyqa5 14IjJ1K+Q2CyDZyCJrMmmroH9B+LQWIaGvFnhHJ+M+XHkmnfCqL1A23rwxIvWJT4JmYH vO6gh9nU9lFsE/4od5QRC7KLgNd6VtPmqL+1C7YhPf2+prHXmlxJuu+l+iX15ppGYYwq AXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=h9QvRkOPRvA4ZRQrb0zyoEWZsv1bz/9Qyosofny8jZY=; b=NXqGmjIlsJgfTWDKnngy6boA8DLQi6uAW6VlNo/1SQoHUGhPwTWOnwpEHU73HXPsT4 TgSsAT7+2LIbzk0cVv8ILbxUBzn1SFiziT/nyQaFnD6JJ0MI3bafyqmZgZphwxP34BD3 qjebfMeAkM/3kmljz8enDMxIVayBZH+O2BdTtFjHS/boJW23/UfZw5IDDNTH58Heg2eR Z5qIOFxDs3yZkdyEuv9sUo6dQOqwtQrMDFFO5tFPvKKYS9xV+Iv3BxI26FFyJZql5gVA qTjHJRYHsXj/e5+FW2Z7SApdvtTCs0L+Q7SbhpkWCEASJukRaM2hgZ23tImq27to7SJH YsXg== X-Gm-Message-State: AGRZ1gJWQ4PNqVawzXm9OcO1Qm8UFFkEuTY0AjvX1jpxnj16FOye/OOy JzElsdV7bJho6JaRILNZ0eJhUUpy X-Google-Smtp-Source: AJdET5enXD1PwOlk8BVlAt8YQEgQ04JQhNVcnqa5GhLBBAZrej9MLJDkBNBXR0lqz50U2CKjrN5rOA== X-Received: by 2002:a02:9b46:: with SMTP id g6-v6mr7696275jal.60.1541766535284; Fri, 09 Nov 2018 04:28:55 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o69-v6sm644583itb.4.2018.11.09.04.28.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 04:28:54 -0800 (PST) From: Noam Postavsky To: Michael Heerdegen Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> Date: Fri, 09 Nov 2018 07:28:53 -0500 In-Reply-To: <87efbumvd0.fsf@web.de> (Michael Heerdegen's message of "Fri, 09 Nov 2018 10:51:55 +0100") Message-ID: <87r2fuh1tm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere >> in that file. > > I think we could do that, but I don't feel qualified to decide. Maybe > Noam can help. I think it would be acceptable. > As far as the example in your bug report is concerned, I think it would > also be an improvement if elisp-mode wouldn't try be clever in such a > way when indenting branches in a cond or variable associations in a let. The problem is that we currently don't have any way of specifying indentation for subforms of macro arguments, which is also the core problem of the other bugs I mentioned about indentation of cl-flet and friends. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 09 14:39:27 2018 Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 19:39:28 +0000 Received: from localhost ([127.0.0.1]:43959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLCcp-0007VK-JW for submit@debbugs.gnu.org; Fri, 09 Nov 2018 14:39:27 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:55148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLCco-0007V8-6p for 33301@debbugs.gnu.org; Fri, 09 Nov 2018 14:39:26 -0500 Received: by mail-wm1-f47.google.com with SMTP id r63-v6so3064546wma.4 for <33301@debbugs.gnu.org>; Fri, 09 Nov 2018 11:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=tloH8d1SFsATH8R8G3cHCQPbDoc6IxMKyzEoHp8iI/k=; b=Jt5AFu56l2tsKvzF3MyCCalYZ8Qf1iPfmTeX/M5TbdZDRNwx35pWfSPMqhEjNTwrrO RSKuE3P9igqo9KBJdEbo2MBYAEdFK53gGOp92UubcBFh6jXhcnN+CeSizILyTm3Qg0Ku yfWD7uH4tncvzZR4V0wD3fAqBY5kP36dGDcVoWj8FdujShZMo932asCoqcgRERrQ4c1a AYzLhvQpt+n5yV2U4kGb2VRga+kjiYMMoDqKq7Z3UbGL51tw1UNau5U/pNaGH3IJPEqr Xx2Dc7grdFTpGbgo2zrj1VL74q7/2PW3Q3KSK6d8SQOwZSdAq2jIvh94fgQCbSI/chV0 a9OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=tloH8d1SFsATH8R8G3cHCQPbDoc6IxMKyzEoHp8iI/k=; b=HDQxaDyNCZjR3N/BRv7AhA3uwKAIxJBNCDBL4cLGEUC9QI5xqYWdW8L9qp/9mtqPr7 EfPOxxeu5Bed92C210q+qwWG5OiqzOy4u2sNsLqE7zzaCQswZ8gG186xLWF9CGvhkFwA joP7rsBJEXdKhlpoDemAjlIJamKHF0+PFmwCHYZQuB1qWJTW5LcD2rgUYfFAq92lhCVt EWo18AUWFZN5HSCJksCGg7efwiIBglvrAo6f3QtdR6f1Rau9D45eqG+JeAvaVuyQRW3b cEjpMY3o1pHZXcBx0j/agKM9QkbfXfp8X7AHQx2nltWsn/iwRBVbDdV+jEoYopni18P7 gKyQ== X-Gm-Message-State: AGRZ1gLuL7NpI8NCj3YrbzTY6cWYJu8ILuSabcxjRidxJlZMHL9eRGwq ZUksRrh4sVbBRUcOsnw9ipZRFj1g X-Google-Smtp-Source: AJdET5c2k3MI7kYWcpL0GMwRUeJWD+mWninZ04XySjY7C/+ufBSDPb6o6WT/U0AJTflrMmRWaiEpfQ== X-Received: by 2002:a1c:c46:: with SMTP id 67-v6mr561911wmm.6.1541792359912; Fri, 09 Nov 2018 11:39:19 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id t129-v6sm3322164wmd.14.2018.11.09.11.39.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 11:39:18 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Noam Postavsky Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> Date: Fri, 09 Nov 2018 19:39:16 +0000 In-Reply-To: <87r2fuh1tm.fsf@gmail.com> (Noam Postavsky's message of "Fri, 09 Nov 2018 07:28:53 -0500") Message-ID: <871s7uqbvf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Noam Postavsky writes: > Michael Heerdegen writes: > >> Jo=C3=A3o T=C3=A1vora writes: >> >>> OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere >>> in that file. >> >> I think we could do that, but I don't feel qualified to decide. Maybe >> Noam can help. > > I think it would be acceptable. OK. If noone opposes I will commit the patch after my sig in a couple of days time. > >> As far as the example in your bug report is concerned, I think it would >> also be an improvement if elisp-mode wouldn't try be clever in such a >> way when indenting branches in a cond or variable associations in a let. > > The problem is that we currently don't have any way of specifying > indentation for subforms of macro arguments, which is also the core > problem of the other bugs I mentioned about indentation of cl-flet and > friends. Well, after some testing with (setq lisp-indent-function 'common-lisp-indent-function) things seem to work as they should. Though the name is "common lisp", cl-indent.el's header says it can be used with emacs-lisp-mode, and indeed it seems to be the case. In Emacs -Q: (setq lisp-indent-function 'common-lisp-indent-function) =20=20=20=20 (flet ((blablabla (correct) also-correct)) ...) =20=20=20=20 (defmacro deffoo (name args &rest body) ;; no indent spec needed `(defun ,name ,args ,@body)) =20=20=20=20 (deffoo test (correct) also-correct) =20=20=20=20 (defmacro defbla (name args moreargs &rest body) (declare (indent 3)) (frobnicate moreargs) `(defun ,name ,args ,@body)) =20=20=20=20 (defbla test (correct) (also-correct) also-also-correct) (cond (defoo correct)) =20=20=20=20 (let ((defoo correct))) But I don't know if I'm missing anything very important here. Are there emacs-lisp indentation tests somewhere? Jo=C3=A3o diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index afb7cbd1dd..b1a99351ed 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1063,8 +1063,8 @@ lisp-indent-function it specifies how to indent. The property value can be: =20 * `defun', meaning indent `defun'-style - (this is also the case if there is no property and the function - has a name that begins with \"def\", and three or more arguments); + (this is also the case if there is no property and a macro has + a name that begins with \"def\", and three or more arguments); =20 * an integer N, meaning indent the first N arguments specially (like ordinary function arguments), and then indent any further @@ -1104,7 +1104,9 @@ lisp-indent-function (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) - (string-match "\\`def" function))) + (string-match "\\`def" function) + (or (not (derived-mode-p 'emacs-lisp-mode)) + (macrop (intern function))))) (lisp-indent-defform state indent-point)) ((integerp method) (lisp-indent-specform method state =09=20=20=20=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 09 23:48:42 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 04:48:42 +0000 Received: from localhost ([127.0.0.1]:44084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLLCL-0007OV-Vy for submit@debbugs.gnu.org; Fri, 09 Nov 2018 23:48:42 -0500 Received: from mout.web.de ([212.227.15.4]:46321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLLCK-0007OI-AC for 33301@debbugs.gnu.org; Fri, 09 Nov 2018 23:48:40 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LoYWI-1fsM2c2DUo-00gZUg; Sat, 10 Nov 2018 05:48:32 +0100 From: Michael Heerdegen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> Date: Sat, 10 Nov 2018 05:48:30 +0100 In-Reply-To: <871s7uqbvf.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 19:39:16 +0000") Message-ID: <87muqhv8pt.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:CzWWJg9c5nXweT2FL8joP4NXy/WzYdfdOK64RpuKuoHzNmlx8QN gWazC8XOiSLBREbo5J0+uip+Y8Q2OOJpdP3+aMCQwg1tN9sA9effyeStobCVqv1NPvtY/T0 QW+IPrICxpO1lc5/fGuv+M1pMDLwtPbfTekz4/wIW0N1z1srNUqYsDX3P1Xb5uT8UYNNLXS tWsJZOxi4tzALuxCB+vzg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:dIGCVmdI1Dg=:Q8lXcyp2YVj9GO1rCfZA0q 8rc1k8w61PqXxVdvAkhB2L1TvArbFISNjo484mvYK8VNY+D2FoD58QA6zblGD/0SSg4zaffhX SZsSMkcbjTH7Cb1/RioTlgGxYqKhZv7klkio20IXBj4UEiFNIiXzx+1B2J9fs2iiH5TYmuvVF pWe2VFoSwnu3MNqH4rQw3Jpa6KOoYZv46yNLOhEI4poVobyXO/UsWKQqDeAgpc5HXld/Vfqr7 vFifoapxFs4nXDjLb8kPjApGYPJr3mzY1+BTQ9yBUyXRDiLbQ8vCeOxZupEZKWDwqgc23504g FOjV2TN2CH90lZGOCWRPEQQ9A9Fn07M7A2zN/4gR49TStWrtMUX24lf32CFuFEmErE2Dq7SRj 7O+o8FXMGrByNaMogRxTp67m5URAVR+tyAx6rmu+RIZ07JyxSw1/AGUL0ZA15VU5BE5KzEwEc iu9GgFZUcYHq0rTi24xDBBYPvBJ8/21dHV+wIEqlRZgnksEpVA3jW58YnC6GnkO2HQ9EYT+Lp 11qZoCnhmJcfbSKSMkFyEPI+4qhyTBPLGEecdEMqOsbc42ND8mKzSoYJIZRB1YHXjuu8fS+Ju JyUgfCEwOmHJNgGipEG4wHXjcc44PxHf+TLHlJ9S0YOFGBym/zKIU9hfa4xjWuORAJhHaSkCC z8BifeFkJmYnIueYU/HvS8JJgwzZVVR15UQi9c9oNf4iL/PdhyChB+Lo14moxnt6feDtYK3TU vEblDQ0I868CJHxXjrsDLRN0VANdLVUzI/72C9AwqAQs5ZFTfoZzNLx1hlkZZIA8ZnLHs87RO 8CgJlxNzi8PHq+v6cmIsr7178qYsfE8zw8W/YTD1e4nsmZkJYlZNvFFpzgTfsufMDQ6j7ftwd /J368TjN8lDUQ8c7nqQCrsHOxc6oEU1WuDxw/u/9x8WGMO1YN9PoMbutS1UQwznVrp6rx5yiN QtYQ6Sm7+CA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora writes: > + (or (not (derived-mode-p 'emacs-lisp-mode)) > + (macrop (intern function))))) That should better be `intern-soft' I think, right? Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 05:28:42 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 10:28:42 +0000 Received: from localhost ([127.0.0.1]:44205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLQVO-0007AU-I1 for submit@debbugs.gnu.org; Sat, 10 Nov 2018 05:28:42 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:40483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLQVM-0007AF-HB for 33301@debbugs.gnu.org; Sat, 10 Nov 2018 05:28:40 -0500 Received: by mail-qk1-f173.google.com with SMTP id y16so5995620qki.7 for <33301@debbugs.gnu.org>; Sat, 10 Nov 2018 02:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VejMYPBDYZKke2Oy0kPXkNCfjN3lh6Zlov8SjVFb5XI=; b=d+WoJQIoVFuZ9VhMFMy1Yn/2YXfxOYm8o95qgqCqTkL6C4nNoI9RhsU9ZoM8eyhKHU ETtLcMU8uNFwazlmzjncVQIYCSZWPfGFM1rzwnoLALx0W7prTO+p9XtwoorfPvma2WpI NH1QAwTFJy8LoquqgyKo+jaowBr72hAqne6L4sljtdHMzlRgxbs1He7Y1w8K3ovz4gyj Mxs73dwQRGa7/BoA6Mv0UM8scY8hnoucQAO7SU7zvTuh2DIfTMFQX8fHjENuTEa3w4Ip ZJxXbnBNklyKaZvrwd2a+o5SX/h2fQusLQ1Cz5fRizscQi2JsVN/ULPRV8HObsLwtLcq EuDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VejMYPBDYZKke2Oy0kPXkNCfjN3lh6Zlov8SjVFb5XI=; b=rBaOKUf+bCI/JzyjknPY9S4CeHfAJSkRalEcMubEvxIqmUOyK92u8J6+JSZcBOiJ+O sX1spj+do1bB3z8UxwVv9HwyfIKby/pMzC9x2uSyYb2jxCjeBMCmirky/BTp1XaV+rqj weCaUQHPfbKE0SOU7SjkibSD1SOs5j0I/PNaEG5n1ALGzx2wob2rVZtTx69LAmpwSok0 71h50Q9v2iloLiC5O35tCFlmToCYEwMQA5OY4KRGDeD027wv5bsxAgeHJKvRn5A21w9D Fv7zt2VkOug6Ss8qlsJt+eUP6bvcSzXmpsB6hLRwvDAnJ3menBlWL4fX7ge32G7yXkPq zHeg== X-Gm-Message-State: AGRZ1gJBDuPqHlEpuHV53opjtQEP76NiO2Yi55/0PAdtUokx+VzULgYJ NssYFBNmbQ+fJJjvNj/6hRaR7DiBCW5FLiXhD/c= X-Google-Smtp-Source: AJdET5f7Vvj9IvqL47VTg9CR6BtcppOrpzh7UhG15SeLmWsjsUeqQ1eoyK5tyxC2JtRU4Xs3KdRlhILofgjQo6l0cRE= X-Received: by 2002:a37:f706:: with SMTP id q6mr11130225qkj.96.1541845715020; Sat, 10 Nov 2018 02:28:35 -0800 (PST) MIME-Version: 1.0 References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <87muqhv8pt.fsf@web.de> In-Reply-To: <87muqhv8pt.fsf@web.de> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 10 Nov 2018 10:28:24 +0000 Message-ID: Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." To: Michael Heerdegen Content-Type: multipart/alternative; boundary="000000000000247086057a4cee91" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --000000000000247086057a4cee91 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Nov 10, 2018, 04:48 Michael Heerdegen Jo=C3=A3o T=C3=A1vora writes: > > > + (or (not (derived-mode-p 'emacs-lisp-mode)) > > + (macrop (intern function))))) > > That should better be `intern-soft' I think, right? > Probably, otherwise you intern some def-symbols even before reading then. Hope nil doesn't break macrop. And it has to ask for special-form-p, too otherwise your defvars are messed up... Jo=C3=A3o > > Michael. > --000000000000247086057a4cee91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, = Nov 10, 2018, 04:48 Michael Heerdegen <michael_heerdegen@web.de wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writ= es:

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 (or (not (derived-mode-p 'emacs-lisp-mode))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 (macrop (intern function)))))

That should better be `intern-soft' I think, right?

Probably, otherwise = you intern some def-symbols even before reading then. Hope nil doesn't = break macrop.

And it has= to ask for special-form-p, too otherwise your defvars are messed up...

Jo=C3=A3o

Michael.
--000000000000247086057a4cee91-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 05:54:53 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 10:54:53 +0000 Received: from localhost ([127.0.0.1]:44211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLQuj-0007oR-MS for submit@debbugs.gnu.org; Sat, 10 Nov 2018 05:54:53 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:46423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLQuh-0007oH-RM for 33301@debbugs.gnu.org; Sat, 10 Nov 2018 05:54:52 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 42sYnQ4LV5z1r3b5; Sat, 10 Nov 2018 11:54:50 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 42sYnQ1zMtz1qql6; Sat, 10 Nov 2018 11:54:50 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id XrztJAs2fg9z; Sat, 10 Nov 2018 11:54:49 +0100 (CET) X-Auth-Info: iL1WUsWYzS6wouo9E9OOuxd6w+JpGBWKX+d/ElOLh3GTV2jSLX8NTIgYcHV1kswg Received: from linux.local (ppp-188-174-147-181.dynamic.mnet-online.de [188.174.147.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 10 Nov 2018 11:54:49 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id C78D81E586D; Sat, 10 Nov 2018 11:54:48 +0100 (CET) From: Andreas Schwab To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> X-Yow: NANCY!! Why is everything RED?! Date: Sat, 10 Nov 2018 11:54:46 +0100 In-Reply-To: <871s7uqbvf.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 19:39:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Nov 09 2018, João Távora wrote: > @@ -1104,7 +1104,9 @@ lisp-indent-function > (cond ((or (eq method 'defun) > (and (null method) > (> (length function) 3) > - (string-match "\\`def" function))) > + (string-match "\\`def" function) > + (or (not (derived-mode-p 'emacs-lisp-mode)) > + (macrop (intern function))))) Why is a defining function required to be a macro? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 07:46:30 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 12:46:30 +0000 Received: from localhost ([127.0.0.1]:44241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLSek-00046B-9M for submit@debbugs.gnu.org; Sat, 10 Nov 2018 07:46:30 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:34937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLSeh-00045v-J6 for 33301@debbugs.gnu.org; Sat, 10 Nov 2018 07:46:28 -0500 Received: by mail-wm1-f41.google.com with SMTP id t15-v6so4208504wmt.0 for <33301@debbugs.gnu.org>; Sat, 10 Nov 2018 04:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fsK5tQThjhotsVSk3y2qbj+BW/beVC753uc9cmmQdfQ=; b=eAEYkJ2qw2BkQi51GqfTakVaH2od+3YaQDNeWZDTqbRMlztpEUcWdVfYtEpwr4Mm1v qGRgXyjSlC5ud53M3qrgvfw0I0xQufJ4CWaZQO8ZffU0VHo9Ff4ZsaCa6uTYLWylM8kj BcCZuLnPcatTiQ/atOtba+4cBgFGrpwyI5Ro6zenW40mWDBlK5WPjhctBXO74mnkV6Lq 0kgGBNljKcrv2oAn3TGJvvRvzEeC2NH+bwIMTS7nLeNUrzyoF2AHQVoCRHrw9pKEGD1G mBob+JQsSd+rF6Nve8N4Oo5jvisXfrf42BcD2/FNX2GfgWH+D+FgoRyiT20H+3h1evrn ZxEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fsK5tQThjhotsVSk3y2qbj+BW/beVC753uc9cmmQdfQ=; b=GI7FtwKotXGUJiMhlvhp37ajdnswg3B33Zp1u1TgyvBeJYIFMV6L+hUvco2tLB20Ye AARa/li0ZtSboTg2V7EEY4y+R/w15mldMeH6V96NVrtrfx1/fO6juM6Mm4am+dOaFsjF D2QCUVJSFnAD5Ka7he1vgm1jlxl6YPTnYwa8cqTsB4Qdp6lm7Zdk+nsGkbjtnuoNbaCs dh4n6ZNzGE0Yia/O3dglNbagZZHMTAzgOvLK/SmpNy0WAoCsvSZbwnFGwPpWGm9N6Nj5 ZZ0ttbotW039XiFlA426nAWbo6/tMM1dQ5smcypAw+jMdX1pB5alHARi/pGLkpH1hl6G sRPg== X-Gm-Message-State: AGRZ1gIW5NrxyLQrIGdyWyyZ9i/tJpEbgwBz18usL7xVSh55WuYbTIFp p43uJpjravBWCQ6r1AtmPPk= X-Google-Smtp-Source: AJdET5e605kkDBZ2wLuK6Lfxd37mwtEkS+aai2BJ6nejwh7p26kshUJ34b3wuuxhNErvFvaWAIemyQ== X-Received: by 2002:a1c:c40e:: with SMTP id u14-v6mr2386967wmf.150.1541853981735; Sat, 10 Nov 2018 04:46:21 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id k3-v6sm14167098wro.9.2018.11.10.04.46.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Nov 2018 04:46:20 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Andreas Schwab Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> Date: Sat, 10 Nov 2018 12:46:18 +0000 In-Reply-To: (Andreas Schwab's message of "Sat, 10 Nov 2018 11:54:46 +0100") Message-ID: <87tvkpp0bp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Andreas Schwab writes: > On Nov 09 2018, Jo=C3=A3o T=C3=A1vora wrote: > >> @@ -1104,7 +1104,9 @@ lisp-indent-function >> (cond ((or (eq method 'defun) >> (and (null method) >> (> (length function) 3) >> - (string-match "\\`def" function))) >> + (string-match "\\`def" function) >> + (or (not (derived-mode-p 'emacs-lisp-mode)) >> + (macrop (intern function))))) > > Why is a defining function required to be a macro? Do you know any that aren't? Of course you can name a function however you want, and give it your own "definition" semantics, but if you want to do it in the lisp sense, generally the properties of macros are good: 1. They are evaluated at compilation time, so the byte compiler can understand the uses of your new definition down the line; 2. The arguments of a macro don't get evaluated unless you want them to, which is crucial for defining formal arguments. Jo=C3=A3o PS: a defining function can also be a special form, which also has the above properties From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 07:54:03 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 12:54:03 +0000 Received: from localhost ([127.0.0.1]:44245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLSm3-0004HA-3W for submit@debbugs.gnu.org; Sat, 10 Nov 2018 07:54:03 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:43316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLSm1-0004Gj-5U for 33301@debbugs.gnu.org; Sat, 10 Nov 2018 07:54:01 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 42scQw01Skz1r1hp; Sat, 10 Nov 2018 13:53:59 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 42scQv6RRrz1rJpx; Sat, 10 Nov 2018 13:53:59 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 9WgV6fdI0sbV; Sat, 10 Nov 2018 13:53:59 +0100 (CET) X-Auth-Info: dhdE/hQwlJ/4J0RtpXBUqBn1mpYXhWzTUG4sozN3Q0QacTjbDP9mdvlm06nCWly1 Received: from igel.home (ppp-188-174-147-181.dynamic.mnet-online.de [188.174.147.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 10 Nov 2018 13:53:59 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id B4FEF2C1F23; Sat, 10 Nov 2018 13:53:58 +0100 (CET) From: Andreas Schwab To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <87tvkpp0bp.fsf@gmail.com> X-Yow: .. ich bin in einem dusenjet ins jahr 53 vor chr... ich lande im antiken Rom... einige gladiatoren spielen scrabble... ich rieche PIZZA... Date: Sat, 10 Nov 2018 13:53:58 +0100 In-Reply-To: <87tvkpp0bp.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sat, 10 Nov 2018 12:46:18 +0000") Message-ID: <87r2ft14bd.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Nov 10 2018, João Távora wrote: > Do you know any that aren't? define-widget Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 11:05:55 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 16:05:55 +0000 Received: from localhost ([127.0.0.1]:44892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLVlj-0002mn-AH for submit@debbugs.gnu.org; Sat, 10 Nov 2018 11:05:55 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:55606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLVli-0002mZ-99 for 33301@debbugs.gnu.org; Sat, 10 Nov 2018 11:05:54 -0500 Received: by mail-wm1-f48.google.com with SMTP id s10-v6so4608144wmc.5 for <33301@debbugs.gnu.org>; Sat, 10 Nov 2018 08:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=IlOBLnqVGkpwHK8XokuEL3yfMGWUpKRkSDHj+f3guKo=; b=STDWrPL9w6opKWgU0zz0PrK/bkGHKbNjUumTtUNjFt9Q164A88+4hudA546FVd+ZY4 qCWpIGCPj4c8NWxpbPpHfjlZZLB7nPjZ4FCTek+jy9PnNP1jJTGUnOsZjsEY6kPs7iFn P8jXeg6kDInsjbq7fPGFlFmmGHHPSp/0o3vy1muG4eU7vSLLuAL6MGW5nJNvL/PZ+bSA 5fk0oXxAkVW2UiAWwnfWnhflyVc/2TOMXBGd1/BN4p65VKV4eaIYUAJZY4Y2FPuSJEmL FY8avCjD7ofcgJ/METQAQynKm3OYrZCRj8iZQ6rnDVLFozuOTFoalsB/d+G9jEkIKWdH VABA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=IlOBLnqVGkpwHK8XokuEL3yfMGWUpKRkSDHj+f3guKo=; b=X30q9/plrLV88Ez+MNIQgXeB9h7yger03cwKWXPoBopyBKeIplKrOZNVVFYPFrwznN GuoBitsVQ3y5fghmi5Pq/9LOQhWTiS29Ugj1JGyFjo0JVvae5THPPyw2KghwgP6J3u3D 6twPlB6XpQgD5evShqy/sMkCxSMM7Zo4OWiL78b4RELTOA30skm/D3T7T6/ZRmBLmyFM RFAp+lHZXc0VhzN5BAvBVig+I9zZwiqyhxAo7l930A7SZiwuphl1XIklkcLmy0HuAdxR w7trV7bpVABCp4mUYOuw1pjCxD9F0NClUgsbVr0dy7p+TrZdlSG1AgY9P+2lOeYy8UZk yYCA== X-Gm-Message-State: AGRZ1gI1+oCQectt9K9t7f65IES/XIZaA8uUKnDxE7puHFyh8HzDTp8p m2XvHCJot+RxFjrrov7Lsk0= X-Google-Smtp-Source: AJdET5eiMw9LXSHxKKEsiMIdDRaF5bBOHI+eJw8J8nxmaaFacvaaTKr5/Dx9XjTQ6LOUGcr/Fwbnew== X-Received: by 2002:a1c:32ca:: with SMTP id y193-v6mr2812566wmy.29.1541865948363; Sat, 10 Nov 2018 08:05:48 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id e10-v6sm15030104wrp.56.2018.11.10.08.05.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Nov 2018 08:05:47 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Andreas Schwab Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." In-Reply-To: <87r2ft14bd.fsf@igel.home> (Andreas Schwab's message of "Sat, 10 Nov 2018 13:53:58 +0100") References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <87tvkpp0bp.fsf@gmail.com> <87r2ft14bd.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sat, 10 Nov 2018 16:05:44 +0000 Message-ID: <87zhug3okn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Andreas Schwab writes: > On Nov 10 2018, Jo=C3=A3o T=C3=A1vora wrote: > >> Do you know any that aren't? > > define-widget A poorly chosen name for what should have been named `make-widget-type' (and define-widget should have been a macro relieving the user of all that useless quoting). Anyhoo, it's a question of (function-put 'define-widget 'lisp-indent-function 'defun) Any objections to that? Do you know any more? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 11:18:45 2018 Received: (at 33301) by debbugs.gnu.org; 10 Nov 2018 16:18:45 +0000 Received: from localhost ([127.0.0.1]:44898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLVy9-00036w-Gp for submit@debbugs.gnu.org; Sat, 10 Nov 2018 11:18:45 -0500 Received: from mail-qk1-f177.google.com ([209.85.222.177]:33321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLVy8-00036g-2r for 33301@debbugs.gnu.org; Sat, 10 Nov 2018 11:18:44 -0500 Received: by mail-qk1-f177.google.com with SMTP id o89so6871659qko.0 for <33301@debbugs.gnu.org>; Sat, 10 Nov 2018 08:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L03ogbItSnprQqXTxs8PquOTQztJ3t4VgmGIi7dOH4g=; b=knNtdf3RzeCe88oJxhhZqyMjEo70uduhqetm/2KWKDolHXaToG6fhrJ4u0CbSaOtjt bWQTzOXuYriXFdfU9/XCB3R6NKkioQaeOE9AZB7MEzglb+Ax9uAQ3tRW65MaEh247Rex WoLmwy/c/HsyngCN8gWI6hHJ6o1pKqzVZMG3wkbyO7UJOKMoYRHC0Y8qAOODwTg2b9Nz arxufRmjWku2dJa3/PXK3WSgBQsaG1aXP4wsFJudnMAyt36r/5KDm9tUP6x3XWwnOsKr Nqy8Dng61mkNjUTTsdtFjm13a54TzWI8l4ZlJXnXGKd5F7gXiuEy/ER7xuzgeY4g2wNJ /oJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L03ogbItSnprQqXTxs8PquOTQztJ3t4VgmGIi7dOH4g=; b=J3oyJ7z3N+svjIcgZ1xxfHm6NGDhKznHGXaaghpxZqVbVAQiB0JS/Lr8TCl+tIiJBX gxI/ybo2QEQilUP6l8RE/8czv0Ior45LgrrXs9z/Dh9m6xEG28KQbrhCMb0yFhPQuSfj CXw9xfrcp36BVADylTrRA4cUKSh52qoPXtNTOoSOqihJ3U+Cz2EkGSAqn66GEg+CnjxE /1zER4tK4xTuVoXrmWXuzX8S4m4IvEqe0mnFPVG2GdtPTZX8LM32oBcxG154A9JW3m0c YhQjqcHE9Ho583a6eUlMhgpKW4UEAVbIAt7o4fQd6dJFVfew5uhEzYlCAldl/3HQY8yJ dR7A== X-Gm-Message-State: AGRZ1gIpGXwROJXSVO96z8TqP+ajY2UJ58NQblIWV18LSqKNtSrdw8eF ny8WUjjmHD94gM6fYVTtkIotAajXiCwE3/En+dI= X-Google-Smtp-Source: AJdET5c6jyIHb8/fnu019iXAUirnpoQUN51dcdAc2qxdPGx6pdpQ/yqc2yxIP4Rn9JkppIEmY4+JFIr2eAL1IupbjaI= X-Received: by 2002:a0c:f9c3:: with SMTP id j3mr13390723qvo.107.1541866718523; Sat, 10 Nov 2018 08:18:38 -0800 (PST) MIME-Version: 1.0 References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <87tvkpp0bp.fsf@gmail.com> <87r2ft14bd.fsf@igel.home> <87zhug3okn.fsf@gmail.com> In-Reply-To: <87zhug3okn.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 10 Nov 2018 16:18:25 +0000 Message-ID: Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." To: Andreas Schwab Content-Type: multipart/alternative; boundary="0000000000000c80d1057a51d2b4" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --0000000000000c80d1057a51d2b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Never mind that, I just grepped for `(defun def` and there are a lot more, though not quite as much as `defmacro def` Indeed I don't know how to proceed. There seem to be around 34. Add indent specs for these 34 symbols? I suspect that some have exclusively one-line uses that don't need them. Perhaps someone else can weigh in. Jo=C3=A3o On Sat, Nov 10, 2018 at 4:05 PM Jo=C3=A3o T=C3=A1vora wrote: > Andreas Schwab writes: > > > On Nov 10 2018, Jo=C3=A3o T=C3=A1vora wrote: > > > >> Do you know any that aren't? > > > > define-widget > > A poorly chosen name for what should have been named `make-widget-type' > (and define-widget should have been a macro relieving the user of all > that useless quoting). > > Anyhoo, it's a question of > > (function-put 'define-widget 'lisp-indent-function 'defun) > > Any objections to that? Do you know any more? > > Jo=C3=A3o > > > > > > --=20 Jo=C3=A3o T=C3=A1vora --0000000000000c80d1057a51d2b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Never mind=C2=A0 that, I just grepped for `(defun def= ` and there are a lot more,
though not quite as much as `defmacro= def`

Indeed I don't know how to proceed.= =C2=A0 There seem to be around 34.
Add indent specs for thes= e 34 symbols? I suspect that some have exclusively
one-line uses = that don't need them.

Perhaps someone else can= weigh in.

Jo=C3=A3o

On Sat, Nov 10, 2018 at 4:05 PM Jo=C3=A3o= T=C3=A1vora <joaotavora@gmail.c= om> wrote:
Andreas Schwab &l= t;schwab@linux-m= 68k.org> writes:

> On Nov 10 2018, Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
>
>> Do you know any that aren't?
>
> define-widget

A poorly chosen name for what should have been named `make-widget-type'=
(and define-widget should have been a macro relieving the user of all
that useless quoting).

Anyhoo, it's a question of

=C2=A0 (function-put 'define-widget 'lisp-indent-function 'defu= n)

Any objections to that? Do you know any more?

Jo=C3=A3o







--
Jo=C3=A3o T=C3=A1vora --0000000000000c80d1057a51d2b4-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 22 10:58:31 2020 Received: (at 33301) by debbugs.gnu.org; 22 Aug 2020 14:58:31 +0000 Received: from localhost ([127.0.0.1]:50980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9UyV-0004ce-Dd for submit@debbugs.gnu.org; Sat, 22 Aug 2020 10:58:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9UyU-0004cQ-Aw for 33301@debbugs.gnu.org; Sat, 22 Aug 2020 10:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Lz7Vd7fI6hmK66mVetpX+Vr1KBeub53BiSDOfK4WzXU=; b=e8LstubKZsoL3RuSgq/QvLuYjt ghBU6xMSXGWJ26jU1jTitLS4nTtw1T70Azp6DxzJ0naQ13bQOY6f83vkmavRfic3rhlMnqibT57sf 8IagvQZMGKGcTJko61n45rifRcl0wSCPv0StqzYZBFZdyyz/2iWQtDSRZ9VKf1AOZvBE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9UyL-0000Hu-5N; Sat, 22 Aug 2020 16:58:23 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> X-Now-Playing: Nettle's _El Resplandor: The Shining in Dubai_: "El Resplandor: In The Marsh" Date: Sat, 22 Aug 2020 16:58:19 +0200 In-Reply-To: <871s7uqbvf.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 19:39:16 +0000") Message-ID: <871rjyloc4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > - (string-match "\\`def" function))) > + (string-match "\\`def" function) > + (or (not (derived-mode-p 'emacs-lisp-mode)) > + (macrop (intern function))))) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > - (string-match "\\`def" function))) > + (string-match "\\`def" function) > + (or (not (derived-mode-p 'emacs-lisp-mode)) > + (macrop (intern function))))) As others noted, this means that indentation changes when you've loaded/not loaded the file that defines the macro, which may be awkward. But also, as your grep showed, there's oodles of functions in Emacs the define stuff, and you'd have to add indentation specs to all of them. And that doesn't take out-of-tree definitions into account. So I don't really see how this can be fixed in any sensible way -- changing this heuristic will just annoy more than it fixes things, I think. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 22 12:19:45 2020 Received: (at 33301) by debbugs.gnu.org; 22 Aug 2020 16:19:45 +0000 Received: from localhost ([127.0.0.1]:51184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9WF6-0000sv-UW for submit@debbugs.gnu.org; Sat, 22 Aug 2020 12:19:45 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9WF4-0000sc-Ik for 33301@debbugs.gnu.org; Sat, 22 Aug 2020 12:19:43 -0400 Received: by mail-wm1-f65.google.com with SMTP id k20so4492983wmi.5 for <33301@debbugs.gnu.org>; Sat, 22 Aug 2020 09:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jJXdOztR3upSFMGCuY4iT8fl/K5BRuRPAJIdZtdukZ4=; b=KXWnK5zprMhIV/bGlMYU+Wiu0oLGDTTtTeotwbvB3PvGg7dWdCQTXlSoKq9jKSzLeg dN4tczfcPDG3TzbGoyxHliPRt0zWumBIyDTlfI9mFBdtb75u54RSmVkdH2cNU+C0ctII Hvjk5nfPQ/2COhd/PYZMsTQuFuRNSAAYyaYeOvI7AXykyNU0U5uyQZ6lGNQiboRJvJwR rHx8HgHqVHrxm3Vlzzi0qB3p8xw4VhCByG2+jI73BX03pUVGbTHd2cQQXYRuKFy/Rt6J bfxeEBla9huTLlrM4dxr2S58CCnqh0yipMdayPpSbw2aVRPJyh0qZK7IkYEGh3Ayjj02 6LYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jJXdOztR3upSFMGCuY4iT8fl/K5BRuRPAJIdZtdukZ4=; b=T2sNkitnXwd18wZDf1TKG4PvlvtSlVjIqTLhj57/1mzpLWXlcfgXBtyzx8q4/7F1Lq hT01RveVZHYPq1G7EzJxRV7ALq+1FuDT7n316CwcpZD4VRaYVBbTmh4BXPZWIUtPFdlP lv+N9wYXRjwkpBH3574dDZvx7UiSEWtwWYV82loZdMrDRR/VftsecoewePmY2JSwjmvY M/kyw8gKsv8JBRuT0QCSv0oW9wbrmjDIWi5plpYBx4twFeiDiQEwyohID8xPYcvbmbYQ OJR125qgRchE0h3j6zYDu6whvdaxcbvMBDGqpN1dCizP73yQQOXMsu/PZ2dn68wrMbDj mPzg== X-Gm-Message-State: AOAM531HpQV7Z9OoYqfHNR//qL9YZ1v9cS5ombE5YAZL35VMVGrauHgp Hd/uudgNfVaVyibNf3IS6KM8N3oO6s0X93LzdDM= X-Google-Smtp-Source: ABdhPJw4vDgcbIgB57yNTIbPIYbcD8sh74m8jOY/HRgwjx4fzuLJqYABDdpv/5e5gYGhVt8Py3Z1bANNqZeaN2QRa00= X-Received: by 2002:a05:600c:c7:: with SMTP id u7mr8541890wmm.135.1598113176693; Sat, 22 Aug 2020 09:19:36 -0700 (PDT) MIME-Version: 1.0 References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <871rjyloc4.fsf@gnus.org> In-Reply-To: <871rjyloc4.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 22 Aug 2020 17:19:25 +0100 Message-ID: Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="00000000000035312705ad79b849" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000035312705ad79b849 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Lars, thanks for your review of old bugs. I wouldn't count 34 as "oodles" and don't think a new line for each occurrence of what is essentially a breach of convention is a high price to pay. Even converting some of those to macros or "make-foo" could be worth it if it would enable non-surprising indentation. As for the problem of needing to load macros before indenting forms where they appears, that's already very much a thing. We wouldn't be creating new problems there, it's just the way it is. As for out-of-tree definitions, we could be lenient and have this saner indentation be controlled by a variable which we would default to 'insane, but to 'sane inside Emacs's source, via directory local variables. So I don't think we should throw in the towel on this one. Jo=C3=A3o On Sat, Aug 22, 2020, 15:58 Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > - (string-match "\\`def" function))) > > + (string-match "\\`def" function) > > + (or (not (derived-mode-p 'emacs-lisp-mode)) > > + (macrop (intern function))))) > > As others noted, this means that indentation changes when you've > loaded/not loaded the file that defines the macro, which may be > awkward. But also, as your grep showed, there's oodles of functions in > Emacs the define stuff, and you'd have to add indentation specs to all > of them. And that doesn't take out-of-tree definitions into account. > > So I don't really see how this can be fixed in any sensible way -- > changing this heuristic will just annoy more than it fixes things, I > think. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --00000000000035312705ad79b849 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Lars, thanks for your review of old bugs.

I wouldn't count 34 as &quo= t;oodles" and don't think a new line for each occurrence of what i= s essentially a breach of convention is a high price to pay. Even convertin= g some of those to macros or "make-foo" could be worth it if it w= ould enable non-surprising indentation.

As for the problem of needing to load macros before indenti= ng forms where they appears, that's already very much a thing. We would= n't be creating new problems there, it's just the way it is.
<= div dir=3D"auto">
As for out-of-tree definitions= , we could be lenient and have this saner indentation be controlled by a va= riable which we would default to 'insane, but to=C2=A0 'sane inside= Emacs's source, via directory local variables.
=
So I don't think we should throw in the tow= el on this one.

Jo=C3=A3= o

On Sat, Aug 22, 2020, 15:58 Lars Ingebrigtsen <larsi@gnus.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wr= ites:

> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(string-match "\\`def" function)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(string-match "\\`def" function)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 (or (not (derived-mode-p 'emacs-lisp-mode))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 (macrop (intern function)))))

As others noted, this means that indentation changes when you've
loaded/not loaded the file that defines the macro, which may be
awkward.=C2=A0 But also, as your grep showed, there's oodles of functio= ns in
Emacs the define stuff, and you'd have to add indentation specs to all<= br> of them.=C2=A0 And that doesn't take out-of-tree definitions into accou= nt.

So I don't really see how this can be fixed in any sensible way --
changing this heuristic will just annoy more than it fixes things, I
think.

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--00000000000035312705ad79b849-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 23 08:26:59 2020 Received: (at 33301) by debbugs.gnu.org; 23 Aug 2020 12:26:59 +0000 Received: from localhost ([127.0.0.1]:52240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9p5O-0006CF-Oa for submit@debbugs.gnu.org; Sun, 23 Aug 2020 08:26:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9p5M-0006Bz-Qn for 33301@debbugs.gnu.org; Sun, 23 Aug 2020 08:26:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ek8vB1Mf2MWLJzBKiiYuzNVMKFNJzUiAHp77SNIwlXw=; b=KO2znXtmcTu+m3z6x75uSUZ6sI UVRnaYssxLf7SQ/OsQxeT5G4P9huu3SO/YY03zmKDAo/qA1BZbqkibsV2D7KlyZClj4F58T2zB8MZ q6qIoVDL3xXBmwvmaoI0PpIMLUt8aIUiwbbTe+z51VlAZYBCVUgRMUuKB6Ab0Vekva74=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9p5E-0006OX-2t; Sun, 23 Aug 2020 14:26:50 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <871rjyloc4.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUeFBRcMCGqWTDZ lGD////llHMYAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QIFwwVKcCiUM8AAAG9SURBVDjLbVSLscQg CBQrAGwgYAMv0n9vb1GT3I/J3CSufHaBK6UUSeOSRkIi5YfhhvovgIjryT+R0sZvQJp8ATOrd/vM 3iI9PManQwQn0M/1We/oEccEbOVwETwqSuuk953Cuw+HGTVKoJ2vXN2FKTQBeimWplI1uuHjm121 dizuHzzq8LxtGe3NrfoE8jrTm0puD/DmEkeWIDhUsec+r5xgytTd7mPZlYJW0b7quIvnSak4BFbb bXvhCqIRG0jiKwc06JAoVnZywRCQYBSQwlBAXYC6WGrJmaGGx7GKQTY1zZ4wYjakGDbLoWFueZp+ ANImUF0XkH6I6yOCVmuaWvZEJzs008cWS3XOcs42Wh19/E0Aoi3aQPE+XOOQBWzHCXT0v69qmejY AgCoYTrK5MfaeVeR4veRBCeAaa3rDQcg28saeIkTI3IBdYq/Qocz5OJL5rsJFH6qzzHMn2c5CUXU VGN2PpW/PY78tCSCp54PMITUJyCD6AGgGtqZ4cGCwff2sCJrPgs143uoyUzQ9r0uh5V2DagfJNeE UbtkgGFhKJm3XGQd90izWsqaa5ux3O6t2jdq5F7S/vf5B1KKMiP0fugcAAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIwLTA4LTIzVDEyOjIxOjQxKzAwOjAwkAnczgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy MC0wOC0yM1QxMjoyMTo0MSswMDowMOFUZHIAAAAASUVORK5CYII= X-Now-Playing: The Stooges's _The Stooges_: "I Wanna Be Your Dog" Date: Sun, 23 Aug 2020 14:26:46 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sat, 22 Aug 2020 17:19:25 +0100") Message-ID: <87o8n1fszd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > I wouldn't count 34 as "oodles" and don't think a new line for each > occurrence of what is essentially a breach of convention is a high > price to pay. Even converting some of those to macros or "m [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I wouldn't count 34 as "oodles" and don't think a new line for each > occurrence of what is essentially a breach of convention is a high > price to pay. Even converting some of those to macros or "make-foo" > could be worth it if it would enable non-surprising indentation. Changing functions to macros, or renaming functions from def* to make*, just because we have a slightly odd heuristic in Emacs Lisp mode doesn't sound quite right to me. > As for the problem of needing to load macros before indenting forms > where they appears, that's already very much a thing. We wouldn't be > creating new problems there, it's just the way it is. That's true, but it would exacerbate the problem. But the main problem is that it would indent the code differently than it does now, and that leads to whitespace churn in the vc, which we should avoid unless we have a very, very good reason not to. And this just doesn't seem like a good enough reason... > As for out-of-tree definitions, we could be lenient and have this > saner indentation be controlled by a variable which we would default > to 'insane, but to 'sane inside Emacs's source, via directory local > variables. I'd be against that -- again, because it leads to whitespace VC churn. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 23 09:40:00 2020 Received: (at 33301) by debbugs.gnu.org; 23 Aug 2020 13:40:00 +0000 Received: from localhost ([127.0.0.1]:52352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9qE4-0008PM-H0 for submit@debbugs.gnu.org; Sun, 23 Aug 2020 09:40:00 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9qE3-0008PA-BW for 33301@debbugs.gnu.org; Sun, 23 Aug 2020 09:39:59 -0400 Received: by mail-wr1-f66.google.com with SMTP id z18so6099697wrm.12 for <33301@debbugs.gnu.org>; Sun, 23 Aug 2020 06:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=nYTg+Aw4kE7cd8FPpRJ10FoZEDCIWVc9A9C4wlJWkls=; b=uoaUuLWCRTLhoAXdvZurXppXNDxoaiUPBq6feuRbBOktH9XCFZvRI9EYQ7UkP6mUgX nAPz/SRbGOJW6quzEvks2R7WQLsyoLrRgPTUB0868jhq2mNypmznXSzmbeUVqns8NtIa XOUHYhdfltQ0CdgaM13OgpnZaifZpzFnTEEgJFEKX32m3oYE7g9vSCybe/LbQynPsPS0 LQP1hlxYdUmdzLVDkn6rB+wIOqjGv+kN+OhG5LHfRwA8s7zCjzZHyci4ZIhw9rsn+C4N fv+ias6amfN6BS5ol3w/rA6A0LMtnHKWNtg7f0AJQQ+DeoxwcbgaopF4agJO9yzuJXiN /aNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=nYTg+Aw4kE7cd8FPpRJ10FoZEDCIWVc9A9C4wlJWkls=; b=ISEDkLj9Wxcrq/tsDwwYG48eemvS3uoKaDR3PO4ojHarsAkHlCcVxjrlWKDtE5OF82 ZJnAWxVOll5wb3APt0YEaweA95Ze0RVBKMf+sAzTC62C+NkXJS82YQ4FU9GsLgQP/i+7 KmUyn0AAOp1dXouODdNGoNchS3SPUvNuVRWn0+s3qLFhHtOdtPrDUwB9yiRGuWQMtBFc 3lUHdsOHTaXdjCB8TZ6/p46FKy0oWd3fFdL4H4aGPAXohn00vvmmy+qOOso4HwJ8HCdZ qFwEeir1EjBX7FPYbfLLGMAaada8QlWABUWaq0yqW8475FhDdZi7C7EBjHqjXMh1bKd7 UQ6A== X-Gm-Message-State: AOAM532ME1wMUADPCTKWfccF8lx5PPe+MHbr3WTQdgxT7m/9PCvG+Ouj VTV6bUgKqAzmwLdVKlCSFgzc9+hiQ/A= X-Google-Smtp-Source: ABdhPJzoCiKtibjwQb+nVaDx8TZJcIGWYm9uHG/pguOUnfAQbwYR4Kk1iEko+yCJZjOF/4Mu9YsczA== X-Received: by 2002:adf:f58c:: with SMTP id f12mr1600322wro.45.1598189993175; Sun, 23 Aug 2020 06:39:53 -0700 (PDT) Received: from krug ([89.180.151.68]) by smtp.gmail.com with ESMTPSA id j11sm16756020wrq.69.2020.08.23.06.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2020 06:39:52 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <871rjyloc4.fsf@gnus.org> <87o8n1fszd.fsf@gnus.org> Date: Sun, 23 Aug 2020 14:39:50 +0100 In-Reply-To: <87o8n1fszd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 23 Aug 2020 14:26:46 +0200") Message-ID: <871rjxbhw9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I wouldn't count 34 as "oodles" and don't think a new line for each >> occurrence of what is essentially a breach of convention is a high >> price to pay. Even converting some of those to macros or "make-foo" >> could be worth it if it would enable non-surprising indentation. > > Changing functions to macros, or renaming functions from def* to make*, > just because we have a slightly odd heuristic in Emacs Lisp mode doesn't > sound quite right to me. This wouldn't be the only reason to do that. As I explained https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33301#51 this convention is good in itself. >> As for the problem of needing to load macros before indenting forms >> where they appears, that's already very much a thing. We wouldn't be >> creating new problems there, it's just the way it is. > > That's true, but it would exacerbate the problem. Really doubt that. I think regular use of macros (like, say with-foo) is prevalent enough that people already know not to mass-reindent existing code anyway. > But the main problem is that it would indent the code differently than > it does now, and that leads to whitespace churn in the vc, which we > should avoid unless we have a very, very good reason not to. What exactly do you mean "whitespace churn"? Can you illustrate this hypothetical scenario? I don't expect whitespace/indentation beyond fixing the akward cases, at least that's the entire point of this report. > good enough reason... It is a somewhat infrequent but annoying bug when one decides to use a variable name that happens to start with "def". I use "default" and "deferred" a lot, for instance. In Common Lisp mode, I don't have this problem. >> As for out-of-tree definitions, we could be lenient and have this >> saner indentation be controlled by a variable which we would default >> to 'insane, but to 'sane inside Emacs's source, via directory local >> variables. > > I'd be against that -- again, because it leads to whitespace VC churn. Again, I'm missing something: this option wouldn't lead to that, I think Jo=C3=A3o PS: another entirely different approach would just limit the current hacky heuristic to calls/expansions that happen at top-level, i.e. at "column 0". I believe this to be the vast majority (though not the entirety) of cases. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 09:12:52 2020 Received: (at 33301) by debbugs.gnu.org; 24 Aug 2020 13:12:52 +0000 Received: from localhost ([127.0.0.1]:56516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kACHL-00079Y-Qz for submit@debbugs.gnu.org; Mon, 24 Aug 2020 09:12:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kACHK-00079K-2J for 33301@debbugs.gnu.org; Mon, 24 Aug 2020 09:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VJKlaJuXs191QSgB8iogg5q5N9DWVv/A8jy5AUBqxXE=; b=evcqWxcBalpGJ+JwD+MrP4rWxO frgAxs+oWhzRzyXK5M+TmXd3YPwPkSPKj0Kg9BcOruQWFpz9eqiUlwgREqgZRa+Mc+ZzfUS6U915n 3BXeBcRIWtfhRGiyw36cq66M7MXoxQLAmHJ2p2fvfdGpUdgpmKyVypl5gcHhxhcKIpKs=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kACH5-0006UD-WE; Mon, 24 Aug 2020 15:12:44 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <871rjyloc4.fsf@gnus.org> <87o8n1fszd.fsf@gnus.org> <871rjxbhw9.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXo2Md/f3DnS2L/ //9XflpNAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIGA0KLVM04CkAAAFfSURBVCjPZdKxbsIwEAbg P1ZA1JOpoGo3q4Iq8lOECpZOGZoBpqgTzVMYxFAx8wAGUcm5p+xdEtqhpwz55Pt9jhUgqakA1wQJ yrKmRpAygJrIC9RZEFwQaMEWsAK3A/xWYSSwiQC+BXGb3bZdGDhBjUxw5xLoUHsnGIUOmueoeDwz 3oKSOSQZvAYIXJZA3ZDZHZTP+ZWfjDOMCMWb6zYjGCn/whmE/AtK63287HjrnIc4TQ1nHgQImog/ 4b3ooTljTIfo+GzqKhl6Ds7zikDTJTq+nftZi/2F0Gc0hSjQ1x6aMRS46FtMl4zMWT+QzLhyFB35 OUNNKqJIBAGufPHUw7SI5L9l6LkDVwN1atvcfwwPW+qrwXTR7cZrDSbFx9Ha3SE1/gk4VcNHrFam yBmzKjVmuUqKxRqY58vU5AmKnGEF4yQ1gzVf4qrsixE/byihbF1u2kGbsvt3/vDbVf4ADoOdtQUT 9loAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjRUMTM6MTA6NDUrMDA6MDAyCdQSAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI0VDEzOjEwOjQ1KzAwOjAwQ1RsrgAAAABJRU5ErkJggg== X-Now-Playing: Various's _Alefa Madagascar_: "Jean Kely et Basth - Andosy Mora" Date: Mon, 24 Aug 2020 15:12:34 +0200 In-Reply-To: <871rjxbhw9.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 23 Aug 2020 14:39:50 +0100") Message-ID: <87imd8chml.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: >> But the main problem is that it would indent the code differently than >> it does now, and that leads to whitespace churn in the vc, which we >> should avoid unless we have a very, very good reason [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: >> But the main problem is that it would indent the code differently than >> it does now, and that leads to whitespace churn in the vc, which we >> should avoid unless we have a very, very good reason not to. > > What exactly do you mean "whitespace churn"? Can you illustrate this > hypothetical scenario? I don't expect whitespace/indentation beyond > fixing the akward cases, at least that's the entire point of this > report. It means indenting some things in a different way than today? That leads to whitespace changes. >>> As for out-of-tree definitions, we could be lenient and have this >>> saner indentation be controlled by a variable which we would default >>> to 'insane, but to 'sane inside Emacs's source, via directory local >>> variables. >> >> I'd be against that -- again, because it leads to whitespace VC churn. > > Again, I'm missing something: this option wouldn't lead to that, I think If some people have the variable set to 'insane, they would indent the code they're writing differently than the rest, which would lead to whitespace churn. > PS: another entirely different approach would just limit the current > hacky heuristic to calls/expansions that happen at top-level, i.e. at > "column 0". I believe this to be the vast majority (though not the > entirety) of cases. That's probably true... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 15:59:19 2020 Received: (at 33301) by debbugs.gnu.org; 25 Aug 2020 19:59:19 +0000 Received: from localhost ([127.0.0.1]:36185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAf6F-0002Cf-15 for submit@debbugs.gnu.org; Tue, 25 Aug 2020 15:59:19 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:51496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAf6D-0002CT-6a for 33301@debbugs.gnu.org; Tue, 25 Aug 2020 15:59:17 -0400 Received: by mail-wm1-f44.google.com with SMTP id s20so199216wmj.1 for <33301@debbugs.gnu.org>; Tue, 25 Aug 2020 12:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=6wQnb7qH6a0mO3PUy7C7kUg23iZHSFzfX7CBFtNYfx8=; b=ldAEJi+hANnRuHYmmp1LEZ3klkvOaoZdLvrB7SECDnHwMTrAjQtuoia1RMakrDyQx/ TwnAC8FtcKEgZoZgxPaK+y4Oa7ilBQs0LOJsu9Nj3tSaR92G585GWfOSyo5G0xOyA9A0 14YyGBMEIdGrMZ6SouHuvY21tClNwDHQ/RbBqWfFiq+fPHybQYlILW740tPmXpkJRMNv 58QHCKTBeTQSLDoGELGRrv5/yqnv4kGjdY4U4/lsJBQU/p0lRgbmhjbRzXV/a8oOZ53/ pcBlaaANChCF/47ed8ezRaaC2wE/Uu1qgq3zS7qudqkSuBuj2BSnrII0k8ikrZsKiaR2 sn1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=6wQnb7qH6a0mO3PUy7C7kUg23iZHSFzfX7CBFtNYfx8=; b=jRvwb2k8G/eu+luFkn1cClEEAluzHhwMMYfb9qV0RFFA9Kw8g5F8McfaqMI7NLrwlF CtHLbgfisDskrq3BP9CjtFivoZ0mhO3ucUf5dEVyx2nACCmjaBWwe5J7RWrNgZNkZb8s gjjKilcVKkKtJpDCyBNzz7467KbURktaAXZHJBQFgZwI4K3tg8eZVWemQbNPauZROSbs 0g5hhYifvOkR+fKTJe41dXLuh846+lbSXjVyiXDpMqWLDPN+fraIDOJR2ztpUhErXpBV DxgJ40K2+WNObQOfVMpT4f3XIss9fbBQb0MnaZkuI8GfPtK3mMRT/BHIt9VtHtxFBJYx bNqg== X-Gm-Message-State: AOAM532PYSXvqj9ae4edXBPDk0oOkqwhG4JRzxun6BiMbR9jCLGgW8M+ jTCFrnq5sP91OS3GntdeSJIwpymr7Ik= X-Google-Smtp-Source: ABdhPJx7ApWrUlIUHvIODp17i8xBqy7hwREzrBgp2tqpcNSpEE3RaxJLCfAQF5v52wp8TT4wj8mOFg== X-Received: by 2002:a1c:48c2:: with SMTP id v185mr3494037wma.5.1598385550723; Tue, 25 Aug 2020 12:59:10 -0700 (PDT) Received: from krug (a83-132-192-71.cpe.netcabo.pt. [83.132.192.71]) by smtp.gmail.com with ESMTPSA id f2sm13127795wrj.54.2020.08.25.12.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 12:59:09 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <871rjyloc4.fsf@gnus.org> <87o8n1fszd.fsf@gnus.org> <871rjxbhw9.fsf@gmail.com> <87imd8chml.fsf@gnus.org> Date: Tue, 25 Aug 2020 20:59:07 +0100 In-Reply-To: <87imd8chml.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 24 Aug 2020 15:12:34 +0200") Message-ID: <87wo1ma450.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Jo=C3=A3o T=C3=A1vora writes: > It means indenting some things in a different way than today? That > leads to whitespace changes. Hmmm, an indentation bug such as this is, by definition, about an incorrect amount of ... whitespace. Right? >>> I'd be against that -- again, because it leads to whitespace VC churn. >> Again, I'm missing something: this option wouldn't lead to that, I think > If some people have the variable set to 'insane, they would indent the > code they're writing differently than the rest, which would lead to > whitespace churn. Well, they did set it to 'insane :-). I don't see the problem here, this variable would be similar to indent-tabs-mode. If some people set that differently it'll be equally disastrous. But anyway, we probably don't need the variable since I don't expect out of tree code to be particularly affected: that's because, according to code conventions, definitions should start with a package-specific prefix anyway. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 12:35:57 2020 Received: (at control) by debbugs.gnu.org; 11 Sep 2020 16:35:57 +0000 Received: from localhost ([127.0.0.1]:45248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGm1k-0000oQ-SG for submit@debbugs.gnu.org; Fri, 11 Sep 2020 12:35:57 -0400 Received: from mail-il1-f182.google.com ([209.85.166.182]:45042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGm1g-0000o6-QN; Fri, 11 Sep 2020 12:35:55 -0400 Received: by mail-il1-f182.google.com with SMTP id h11so9513196ilj.11; Fri, 11 Sep 2020 09:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ge28Bn3yIT+Z+XflriPiZH5cead3VuKgeYXNU89B+8c=; b=ANEMLX4ZbhpQoGkhx0ruqh5+2zFTzlGnrmHmR7OYFVsR51GHidHZtxS4BrxxrBP0JS KXZF+i/cOY75dIgtlIirTGGvwyy5zcVuuJ/kNA+lIcr2yqu5TCXc3ocqz80aktAPKT9m Cld9rTxnpvXcsC8DFj6+P5HWJQEIZYQcZFSgiH7NAP7godEuBqhhykTBIzv19UH8iK9y lzV+foqtbxGEBcCYjfeu0iSslXzKbxw8DHZR20suWRRxtTC8R0TZ3KlnIkVsa3eowRod FFYrlM1RyTSFW+tMfF6KaBAdR6RgFD6PBha0diI75vVoiBh3kG7JzGZMOTsvYw9VJVNP cyyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ge28Bn3yIT+Z+XflriPiZH5cead3VuKgeYXNU89B+8c=; b=uW/kDNBfDfFA3mv7aWpxVFoW70uQ49wbegm9mI915QWQevq3OTVO4WYFQPCmfPFgG2 I4119EBHUVehAzv40vQdBfBy+dDzmj7Z/FQMnWm3EtddEPv08MKvBkRPGsXwVkGjcGNg l8FzKm2X4pxBqteYJf6WdFZAo7wQu37RkX+PvR8nd4BM0OLud8/MoA+5SY6qvbUXEs7N db//IygQWnlaPLMrKkPNmlNKVFpdKI+6sjxaooIFjp9Qkaq8tg9aab8wrTo+vumcAYiS qCdmK3/xVPazoaLbjt+GVvpoHzCC/3JCgWosPUNiVdY807Rs9sHy8et7k0o5nzyi3o24 Qk0g== X-Gm-Message-State: AOAM532iufjTgt0fm4DBrBmJtOg+FzZz8num+tr0qmx7ACfWwLSsU8sM qF7iBbJXaclUdG2tDem1nFXUQfBSGvc= X-Google-Smtp-Source: ABdhPJw7OEf52nOJJ29lujwSKSE5IlgbclBNeBSGH02/NXX2IaXvgoALWrPfh4ey+PU2QN9l74LKOw== X-Received: by 2002:a92:dad1:: with SMTP id o17mr2462972ilq.22.1599842146986; Fri, 11 Sep 2020 09:35:46 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id z4sm1332657iol.52.2020.09.11.09.35.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Sep 2020 09:35:46 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: <87y2lg1uek.fsf@gnus.org> Date: Fri, 11 Sep 2020 12:35:46 -0400 In-Reply-To: <87y2lg1uek.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 11 Sep 2020 12:26:27 +0200") Message-ID: <85o8mcl199.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Philipp Stephani , 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 33301 43329 quit Lars Ingebrigtsen writes: > Yes, the Emacs Lisp indentation machinery assumes that everything that > starts with "def" is a macro that defines something. [...] > Anybody remember which function this happens in? lisp-indent-function (see https://debbugs.gnu.org/33301#15) From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 16:05:42 2021 Received: (at control) by debbugs.gnu.org; 13 Oct 2021 20:05:42 +0000 Received: from localhost ([127.0.0.1]:33647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1makVS-0003q6-IE for submit@debbugs.gnu.org; Wed, 13 Oct 2021 16:05:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1makVQ-0003po-PH for control@debbugs.gnu.org; Wed, 13 Oct 2021 16:05:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YMd7fCldowV09vjaFyik7IyyFeZgMlRBGcfYouLy6tU=; b=N6SCwQt3RMiFHK8yX893TMPZfT 8mwzHJ/3TtFZLSOpNQVQEAntJimv0I0e6tDzUTZMgxZOSp9xMrkLOLlZJfx5u/4/bcKBULo0qNK1K Bb5pN+ZXVVCmXcBY+q7aQaKOgcLWRoyK82q3VspVtZRaqyfr7lGSXSKHfqIZxvFtFrcs=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1makVI-00039U-Vz for control@debbugs.gnu.org; Wed, 13 Oct 2021 22:05:34 +0200 Date: Wed, 13 Oct 2021 22:05:32 +0200 Message-Id: <871r4o3d2r.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43329 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43329 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 43329 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 04:01:12 2021 Received: (at 33301) by debbugs.gnu.org; 18 Oct 2021 08:01:13 +0000 Received: from localhost ([127.0.0.1]:45832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNZs-00035H-1p for submit@debbugs.gnu.org; Mon, 18 Oct 2021 04:01:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNZm-0002uM-Kp; Mon, 18 Oct 2021 04:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OL7Rtan+rW/pHA5z3kT5rlnDqgb+8rxXNB7MjJi+tro=; b=J+yHEKJHf6Bk+iY7j4fwIng+1g CAdbSbt6vTUSqqhthfYgZJVwnt75fA+PdBsizOJd2Y2hIE60pgZLf8TTU0jRNZo+QfpjWLbqOuwC8 lLfHsy+9e2vFGVjROiWPEsMPOaFMjRARCEABBYkRRHfRSQNaqGikgsx2cb/lKTn5ygFE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcNZc-0000hS-Dw; Mon, 18 Oct 2021 10:00:46 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> <87a6xtzw02.fsf@gnus.org> <87een5h9u8.fsf@gnus.org> <877deg3f0q.fsf@gnus.org> X-Now-Playing: Brokeback's _Looks At The Bird_: "Pearl's Dream" Date: Mon, 18 Oct 2021 10:00:43 +0200 In-Reply-To: <877deg3f0q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 13 Oct 2021 21:23:33 +0200") Message-ID: <87lf2qlq38.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > This will change how out-of-tree code indents, though. This can be > fixed by out-of-tree packages doing markup, but is there some way we can > make the transition kinder? (I don't think so, though. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33301 Cc: Philipp Stephani , 33301@debbugs.gnu.org, Noam Postavsky , 43329@debbugs.gnu.org, =?utf-8?B?Sm8=?= =?utf-8?B?w6NvIFTDoXZvcmE=?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > This will change how out-of-tree code indents, though. This can be > fixed by out-of-tree packages doing markup, but is there some way we can > make the transition kinder? (I don't think so, though.) I've now pushed this change to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 04:01:14 2021 Received: (at control) by debbugs.gnu.org; 18 Oct 2021 08:01:14 +0000 Received: from localhost ([127.0.0.1]:45835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNa4-0003H0-UV for submit@debbugs.gnu.org; Mon, 18 Oct 2021 04:01:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNZp-0002xu-Pi for control@debbugs.gnu.org; Mon, 18 Oct 2021 04:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iqLL75A6uQbdwafsWfgcot1qGS+V3sJAtlwXUt/JKcM=; b=uUyZTwt7QkHX3uHTDTXKcvKz+6 QUOH3jld9MHxw3i6OvI7asAaU/0bzM5nVrIpPi5W/RDZi4LLY7ScKYh6luQW9BE6dWoZwElErKrCR MmqSXqPbVyJa5eXdX8DT6oUH23+1wyVKQ1HQpcnATsFyS0YD3yzwKjni6pgbNHtZhtD4=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcNZi-0000hd-8S for control@debbugs.gnu.org; Mon, 18 Oct 2021 10:00:52 +0200 Date: Mon, 18 Oct 2021 10:00:49 +0200 Message-Id: <87k0ialq32.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #33301 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 33301 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 33301 29.1 quit From unknown Wed Jun 18 23:03:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 15 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator