From unknown Sun Jun 22 11:41:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33295: Unhandled error in log-view-find-revision Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 21:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33295@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15415408196443 (code B ref -1); Tue, 06 Nov 2018 21:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2018 21:46:59 +0000 Received: from localhost ([127.0.0.1]:37892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK9Ba-0001fr-Tb for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK9BZ-0001ff-5v for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK9BI-0002fj-P2 for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK9B9-0002D0-3E for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK9B3-0002uN-Qn for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 16:46:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK96x-0006TZ-6z for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 16:42:15 -0500 Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:57278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK96i-0003gk-QJ for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 16:41:58 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 050CA123EF0 for ; Tue, 6 Nov 2018 21:41:21 +0000 (UTC) Received: from pdx1-sub0-mail-a56.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BD0AD123E03 for ; Tue, 6 Nov 2018 21:41:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a56.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 06 Nov 2018 21:41:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Share-Stop: 4a611bb54f7ee832_1541540480855_3584804201 X-MC-Loop-Signature: 1541540480855:2485711195 X-MC-Ingress-Time: 1541540480854 Received: from pdx1-sub0-mail-a56.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a56.g.dreamhost.com (Postfix) with ESMTP id 7D91180609 for ; Tue, 6 Nov 2018 13:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=linkov.net; bh=kruZKuwyTwdKNha4RZr OIBvxTRo=; b=Z3XwDd63g/fyegPS1doAyuRTnyaYm3mqOamsLAQZhQK/JZ/f+zt LA600ISXIWjzn5xnKPjHiET7Ln+oV3fnSINrYLsUZ/Hy1triO7ETi4wxDM+2vSH2 YAJXBJklH2tXznsqp0msSYgDpFQgSDt9IQTj5VMXs/3IJdZb51Ngi9eI= Received: from mail.jurta.org (m91-129-107-244.cust.tele2.ee [91.129.107.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a56.g.dreamhost.com (Postfix) with ESMTPSA id 9F7A0805F9 for ; Tue, 6 Nov 2018 13:41:18 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a56 From: Juri Linkov Organization: LINKOV.NET Date: Tue, 06 Nov 2018 23:27:22 +0200 Message-ID: <87d0rhyk05.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrjeejgdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdeggedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) 0. emacs -Q 1. in the root of a vc-controlled directory: C-x v L ;; vc-print-root-log 2. on any revision f ;; log-view-find-revision fails with an error: vc-find-backend-function: Cannot open load file: No such file or director= y, vc-nil and with non-nil =E2=80=98debug-on-error=E2=80=99 shows a backtrace that = refers to =E2=80=98require(vc-nil)=E2=80=99. This is because the value of =E2=80=98log-view-vc-fileset=E2=80=99 in tha= t *vc-change-log* buffer is a directory. This patch changes it to display a nicer error: diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index 6ff50dcde5..bfb31ccdab 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -517,8 +517,10 @@ log-view-find-revision If called interactively, visit the version at point." (interactive "d") (unless log-view-per-file-logs - (when (> (length log-view-vc-fileset) 1) - (error "Multiple files shown in this buffer, cannot use this comma= nd here"))) + (when (or (> (length log-view-vc-fileset) 1) + (null (car log-view-vc-fileset)) + (file-directory-p (car log-view-vc-fileset))) + (user-error "Multiple files shown in this buffer, cannot use this = command here"))) (save-excursion (goto-char pos) (switch-to-buffer (vc-find-revision (if log-view-per-file-logs @@ -561,8 +563,10 @@ log-view-annotate-version If called interactively, annotate the version at point." (interactive "d") (unless log-view-per-file-logs - (when (> (length log-view-vc-fileset) 1) - (error "Multiple files shown in this buffer, cannot use this comma= nd here"))) + (when (or (> (length log-view-vc-fileset) 1) + (null (car log-view-vc-fileset)) + (file-directory-p (car log-view-vc-fileset))) + (user-error "Multiple files shown in this buffer, cannot use this = command here"))) (save-excursion (goto-char pos) (vc-annotate (if log-view-per-file-logs From unknown Sun Jun 22 11:41:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#33295: closed (Re: bug#33295: Unhandled error in log-view-find-revision) Message-ID: References: <87va58tspp.fsf@mail.linkov.net> <87d0rhyk05.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 33295 X-Gnu-PR-Package: emacs Reply-To: 33295@debbugs.gnu.org Date: Wed, 07 Nov 2018 22:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1541631242-1991-1" This is a multi-part message in MIME format... ------------=_1541631242-1991-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33295: Unhandled error in log-view-find-revision which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33295@debbugs.gnu.org. --=20 33295: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33295 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1541631242-1991-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33295-done) by debbugs.gnu.org; 7 Nov 2018 22:53:53 +0000 Received: from localhost ([127.0.0.1]:40044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKWht-0000Vn-Lj for submit@debbugs.gnu.org; Wed, 07 Nov 2018 17:53:53 -0500 Received: from firebrick.maple.relay.mailchannels.net ([23.83.214.59]:43983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKWhr-0000Vc-Uw for 33295-done@debbugs.gnu.org; Wed, 07 Nov 2018 17:53:52 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EF2455021AA for <33295-done@debbugs.gnu.org>; Wed, 7 Nov 2018 22:53:49 +0000 (UTC) Received: from pdx1-sub0-mail-a61.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B0F57501396 for <33295-done@debbugs.gnu.org>; Wed, 7 Nov 2018 22:53:49 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a61.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 07 Nov 2018 22:53:49 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Language-Tart: 3af0feea09b0c225_1541631229788_1187124149 X-MC-Loop-Signature: 1541631229788:1318777963 X-MC-Ingress-Time: 1541631229788 Received: from pdx1-sub0-mail-a61.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a61.g.dreamhost.com (Postfix) with ESMTP id 7D473806CE for <33295-done@debbugs.gnu.org>; Wed, 7 Nov 2018 14:53:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=rIsCwg NAg0+2RSob8j3CKopLeT8=; b=p9qyVzMgNZiliGW+Of26ifcYW0ulczHqJqppPq H6NSDu8AjCVNIXly99v9N4Hk9T8Fvm9Py+zOf22V3v+KRpAgSOwOzHgtmMCZVcOS fK341nX0eCYJcJiJYFNQ2kIH3T63METDFwlwKbYKUzi+3YA3S0UCiscMnwXqAdvs kNmL8= Received: from mail.jurta.org (m91-129-107-244.cust.tele2.ee [91.129.107.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a61.g.dreamhost.com (Postfix) with ESMTPSA id 72A10806CB for <33295-done@debbugs.gnu.org>; Wed, 7 Nov 2018 14:53:47 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a61 From: Juri Linkov To: 33295-done@debbugs.gnu.org Subject: Re: bug#33295: Unhandled error in log-view-find-revision Organization: LINKOV.NET References: <87d0rhyk05.fsf@mail.linkov.net> Date: Thu, 08 Nov 2018 00:42:42 +0200 In-Reply-To: <87d0rhyk05.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 06 Nov 2018 23:27:22 +0200") Message-ID: <87va58tspp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrkedtgddtfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtjedrvdeggeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdejrddvgeegpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepfeefvdelhedqughonhgvseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33295-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 27.1 > vc-find-backend-function: Cannot open load file: No such file or direct= ory, vc-nil > > and with non-nil =E2=80=98debug-on-error=E2=80=99 shows a backtrace tha= t refers to =E2=80=98require(vc-nil)=E2=80=99. > > This is because the value of =E2=80=98log-view-vc-fileset=E2=80=99 in t= hat *vc-change-log* buffer > is a directory. > > This patch changes it to display a nicer error: Fixed. ------------=_1541631242-1991-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Nov 2018 21:46:59 +0000 Received: from localhost ([127.0.0.1]:37892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK9Ba-0001fr-Tb for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK9BZ-0001ff-5v for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK9BI-0002fj-P2 for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK9B9-0002D0-3E for submit@debbugs.gnu.org; Tue, 06 Nov 2018 16:46:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK9B3-0002uN-Qn for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 16:46:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK96x-0006TZ-6z for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 16:42:15 -0500 Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:57278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK96i-0003gk-QJ for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 16:41:58 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 050CA123EF0 for ; Tue, 6 Nov 2018 21:41:21 +0000 (UTC) Received: from pdx1-sub0-mail-a56.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BD0AD123E03 for ; Tue, 6 Nov 2018 21:41:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a56.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 06 Nov 2018 21:41:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Share-Stop: 4a611bb54f7ee832_1541540480855_3584804201 X-MC-Loop-Signature: 1541540480855:2485711195 X-MC-Ingress-Time: 1541540480854 Received: from pdx1-sub0-mail-a56.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a56.g.dreamhost.com (Postfix) with ESMTP id 7D91180609 for ; Tue, 6 Nov 2018 13:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=linkov.net; bh=kruZKuwyTwdKNha4RZr OIBvxTRo=; b=Z3XwDd63g/fyegPS1doAyuRTnyaYm3mqOamsLAQZhQK/JZ/f+zt LA600ISXIWjzn5xnKPjHiET7Ln+oV3fnSINrYLsUZ/Hy1triO7ETi4wxDM+2vSH2 YAJXBJklH2tXznsqp0msSYgDpFQgSDt9IQTj5VMXs/3IJdZb51Ngi9eI= Received: from mail.jurta.org (m91-129-107-244.cust.tele2.ee [91.129.107.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a56.g.dreamhost.com (Postfix) with ESMTPSA id 9F7A0805F9 for ; Tue, 6 Nov 2018 13:41:18 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a56 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Unhandled error in log-view-find-revision Organization: LINKOV.NET Date: Tue, 06 Nov 2018 23:27:22 +0200 Message-ID: <87d0rhyk05.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrjeejgdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdeggedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) 0. emacs -Q 1. in the root of a vc-controlled directory: C-x v L ;; vc-print-root-log 2. on any revision f ;; log-view-find-revision fails with an error: vc-find-backend-function: Cannot open load file: No such file or director= y, vc-nil and with non-nil =E2=80=98debug-on-error=E2=80=99 shows a backtrace that = refers to =E2=80=98require(vc-nil)=E2=80=99. This is because the value of =E2=80=98log-view-vc-fileset=E2=80=99 in tha= t *vc-change-log* buffer is a directory. This patch changes it to display a nicer error: diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index 6ff50dcde5..bfb31ccdab 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -517,8 +517,10 @@ log-view-find-revision If called interactively, visit the version at point." (interactive "d") (unless log-view-per-file-logs - (when (> (length log-view-vc-fileset) 1) - (error "Multiple files shown in this buffer, cannot use this comma= nd here"))) + (when (or (> (length log-view-vc-fileset) 1) + (null (car log-view-vc-fileset)) + (file-directory-p (car log-view-vc-fileset))) + (user-error "Multiple files shown in this buffer, cannot use this = command here"))) (save-excursion (goto-char pos) (switch-to-buffer (vc-find-revision (if log-view-per-file-logs @@ -561,8 +563,10 @@ log-view-annotate-version If called interactively, annotate the version at point." (interactive "d") (unless log-view-per-file-logs - (when (> (length log-view-vc-fileset) 1) - (error "Multiple files shown in this buffer, cannot use this comma= nd here"))) + (when (or (> (length log-view-vc-fileset) 1) + (null (car log-view-vc-fileset)) + (file-directory-p (car log-view-vc-fileset))) + (user-error "Multiple files shown in this buffer, cannot use this = command here"))) (save-excursion (goto-char pos) (vc-annotate (if log-view-per-file-logs ------------=_1541631242-1991-1--