GNU bug report logs - #33290
[PATCH 1/8] gnu: go-github-com-prometheus-common-expfmt: Disable tests for go-1.11.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <mail <at> ambrevar.xyz>

Date: Tue, 6 Nov 2018 17:19:01 UTC

Severity: normal

Tags: fixed, patch

Done: Pierre Neidhardt <mail <at> ambrevar.xyz>

Bug is archived. No further changes may be made.

Full log


Message #26 received at 33290 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 33290 <at> debbugs.gnu.org
Subject: [PATCH 6/8] gnu: go-github-com-stevedonovan-luar: Add workaround for
 go-1.11.
Date: Tue,  6 Nov 2018 18:37:07 +0100
* gnu/packages/golang.scm (go-github-com-stevedonovan-luar): Add workaround for go-1.11.
---
 gnu/packages/golang.scm | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index b6b726019..643ecda9f 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2303,10 +2303,24 @@ similar word.")
            "1acjgw9cz1l0l9mzkyk7irz6cfk31wnxgbwa805fvm1rqcjzin2c"))))
       (build-system go-build-system)
       (native-inputs
-       `(("go-github-com-aarzilli-golua" ,go-github-com-aarzilli-golua)))
+       `(("go-github-com-aarzilli-golua" ,go-github-com-aarzilli-golua)
+         ("lua" ,lua)))
       (arguments
        `(#:tests? #f                    ; Upstream tests are broken.
-         #:import-path "github.com/stevedonovan/luar"))
+         #:import-path "github.com/stevedonovan/luar"
+         ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+         ;; rebuilt (https://bugs.gnu.org/32919).  Thus we need to re-specify
+         ;; the special flags of golua and the "lua" native-input.
+         #:phases
+         (modify-phases %standard-phases
+           (replace 'build
+             (lambda* (#:key import-path #:allow-other-keys)
+               (invoke "go" "install"
+                       "-v"  ; print the name of packages as they are compiled
+                       "-x"  ; print each command as it is invoked
+                       "-ldflags=-s -w" ; strip the symbol table and debug
+                       "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+                       import-path))))))
       (home-page "https://github.com/stevedonovan/luar")
       (synopsis "Lua reflection bindings for Go")
       (description "Luar is designed to make using Lua from Go more
-- 
2.19.1





This bug report was last modified 6 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.