GNU bug report logs - #33290
[PATCH 1/8] gnu: go-github-com-prometheus-common-expfmt: Disable tests for go-1.11.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <mail <at> ambrevar.xyz>

Date: Tue, 6 Nov 2018 17:19:01 UTC

Severity: normal

Tags: fixed, patch

Done: Pierre Neidhardt <mail <at> ambrevar.xyz>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 33290 <at> debbugs.gnu.org
Subject: [bug#33290] [PATCH 5/8] gnu: go-gitlab-com-ambrevar-golua-unicode: Add workaround for go-1.11.
Date: Tue,  6 Nov 2018 18:37:06 +0100
* gnu/packages/golang.scm (go-gitlab-com-ambrevar-golua-unicode): Add workaround for go-1.11.
---
 gnu/packages/golang.scm | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index a4978af2a..b6b726019 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2204,10 +2204,23 @@ run a Lua virtual machine.")
          #:import-path "gitlab.com/ambrevar/golua/unicode"
          #:phases
          (modify-phases %standard-phases
+           ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+           ;; rebuilt (https://bugs.gnu.org/32919).  Thus we need to re-specify
+           ;; the special flags of golua here and in the 'check phase below.
+           (replace 'build
+             (lambda* (#:key import-path #:allow-other-keys)
+               (invoke "go" "install"
+                       "-v"  ; print the name of packages as they are compiled
+                       "-x"  ; print each command as it is invoked
+                       "-ldflags=-s -w" ; strip the symbol table and debug
+                       "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+                       import-path)))
            (replace 'check
              (lambda* (#:key import-path #:allow-other-keys)
                (setenv "USER" "homeless-dude")
-               (invoke "go" "test" import-path))))))
+               (invoke "go" "test"
+                       "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+                       import-path))))))
       (home-page "https://gitlab.com/ambrevar/golua")
       (synopsis "Add Unicode support to Golua")
       (description "This extension to Arzilli's Golua adds Unicode support to
-- 
2.19.1





This bug report was last modified 6 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.