From unknown Thu Sep 11 17:28:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33287: [PATCH] sync: add missing brackets in sync_arg() Resent-From: Kamil Dudka Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 06 Nov 2018 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33287 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 33287@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15415057827811 (code B ref -1); Tue, 06 Nov 2018 12:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2018 12:03:02 +0000 Received: from localhost ([127.0.0.1]:36102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK04T-00021l-De for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:03:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK04Q-00021P-0j for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:02:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK04I-0004iE-Vw for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:02:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK04H-0004gq-Um for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:02:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK04C-000843-BR for bug-coreutils@gnu.org; Tue, 06 Nov 2018 07:02:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK03z-00042X-Sm for bug-coreutils@gnu.org; Tue, 06 Nov 2018 07:02:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53662) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK03x-0003lw-L4 for bug-coreutils@gnu.org; Tue, 06 Nov 2018 07:02:29 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A58E183F51 for ; Tue, 6 Nov 2018 12:02:25 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF42460C61; Tue, 6 Nov 2018 12:02:24 +0000 (UTC) From: Kamil Dudka Date: Tue, 6 Nov 2018 13:02:24 +0100 Message-Id: <20181106120224.21566-1-kdudka@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 06 Nov 2018 12:02:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Detected by Coverity Analysis: Error: RESOURCE_LEAK (CWE-772): coreutils-8.30/src/sync.c:112: open_fn: Returning handle opened by "open". coreutils-8.30/src/sync.c:112: var_assign: Assigning: "fd" = handle returned from "open(file, 2049)". coreutils-8.30/src/sync.c:115: leaked_handle: Handle variable "fd" going out of scope leaks the handle. 113| if (fd < 0) 114| error (0, rd_errno, _("error opening %s"), quoteaf (file)); 115|-> return false; 116| } 117| --- src/sync.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sync.c b/src/sync.c index bd3671a19..607fa8f7f 100644 --- a/src/sync.c +++ b/src/sync.c @@ -111,8 +111,10 @@ sync_arg (enum sync_mode mode, char const *file) if (open_flags != (O_WRONLY | O_NONBLOCK)) fd = open (file, O_WRONLY | O_NONBLOCK); if (fd < 0) - error (0, rd_errno, _("error opening %s"), quoteaf (file)); - return false; + { + error (0, rd_errno, _("error opening %s"), quoteaf (file)); + return false; + } } /* We used O_NONBLOCK above to not hang with fifos, -- 2.17.2 From unknown Thu Sep 11 17:28:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kamil Dudka Subject: bug#33287: closed (Re: bug#33287: [PATCH] sync: add missing brackets in sync_arg()) Message-ID: References: <89968cd2-0a3e-b70f-11ca-f2382fb55b89@cs.ucla.edu> <20181106120224.21566-1-kdudka@redhat.com> X-Gnu-PR-Message: they-closed 33287 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 33287@debbugs.gnu.org Date: Tue, 06 Nov 2018 18:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1541529422-5543-1" This is a multi-part message in MIME format... ------------=_1541529422-5543-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33287: [PATCH] sync: add missing brackets in sync_arg() which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33287@debbugs.gnu.org. --=20 33287: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33287 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1541529422-5543-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33287-done) by debbugs.gnu.org; 6 Nov 2018 18:36:07 +0000 Received: from localhost ([127.0.0.1]:37774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK6Cs-0001QK-Ux for submit@debbugs.gnu.org; Tue, 06 Nov 2018 13:36:07 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK6Cq-0001Pr-UC for 33287-done@debbugs.gnu.org; Tue, 06 Nov 2018 13:36:05 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 66A96160183; Tue, 6 Nov 2018 10:35:59 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id OEMVRPBlH0Kl; Tue, 6 Nov 2018 10:35:58 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C0EA8160187; Tue, 6 Nov 2018 10:35:58 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IJ0vixuD3RDX; Tue, 6 Nov 2018 10:35:58 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A9691160183; Tue, 6 Nov 2018 10:35:58 -0800 (PST) Subject: Re: bug#33287: [PATCH] sync: add missing brackets in sync_arg() To: Kamil Dudka , 33287-done@debbugs.gnu.org References: <20181106120224.21566-1-kdudka@redhat.com> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <89968cd2-0a3e-b70f-11ca-f2382fb55b89@cs.ucla.edu> Date: Tue, 6 Nov 2018 10:35:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181106120224.21566-1-kdudka@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33287-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks, I installed that and am closing the bug report. ------------=_1541529422-5543-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Nov 2018 12:03:02 +0000 Received: from localhost ([127.0.0.1]:36102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK04T-00021l-De for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:03:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK04Q-00021P-0j for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:02:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK04I-0004iE-Vw for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:02:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK04H-0004gq-Um for submit@debbugs.gnu.org; Tue, 06 Nov 2018 07:02:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK04C-000843-BR for bug-coreutils@gnu.org; Tue, 06 Nov 2018 07:02:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK03z-00042X-Sm for bug-coreutils@gnu.org; Tue, 06 Nov 2018 07:02:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53662) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK03x-0003lw-L4 for bug-coreutils@gnu.org; Tue, 06 Nov 2018 07:02:29 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A58E183F51 for ; Tue, 6 Nov 2018 12:02:25 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF42460C61; Tue, 6 Nov 2018 12:02:24 +0000 (UTC) From: Kamil Dudka To: bug-coreutils@gnu.org Subject: [PATCH] sync: add missing brackets in sync_arg() Date: Tue, 6 Nov 2018 13:02:24 +0100 Message-Id: <20181106120224.21566-1-kdudka@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 06 Nov 2018 12:02:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Detected by Coverity Analysis: Error: RESOURCE_LEAK (CWE-772): coreutils-8.30/src/sync.c:112: open_fn: Returning handle opened by "open". coreutils-8.30/src/sync.c:112: var_assign: Assigning: "fd" = handle returned from "open(file, 2049)". coreutils-8.30/src/sync.c:115: leaked_handle: Handle variable "fd" going out of scope leaks the handle. 113| if (fd < 0) 114| error (0, rd_errno, _("error opening %s"), quoteaf (file)); 115|-> return false; 116| } 117| --- src/sync.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sync.c b/src/sync.c index bd3671a19..607fa8f7f 100644 --- a/src/sync.c +++ b/src/sync.c @@ -111,8 +111,10 @@ sync_arg (enum sync_mode mode, char const *file) if (open_flags != (O_WRONLY | O_NONBLOCK)) fd = open (file, O_WRONLY | O_NONBLOCK); if (fd < 0) - error (0, rd_errno, _("error opening %s"), quoteaf (file)); - return false; + { + error (0, rd_errno, _("error opening %s"), quoteaf (file)); + return false; + } } /* We used O_NONBLOCK above to not hang with fifos, -- 2.17.2 ------------=_1541529422-5543-1-- From unknown Thu Sep 11 17:28:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33287: [PATCH] sync: add missing brackets in sync_arg() Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 06 Nov 2018 23:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33287 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 33287@debbugs.gnu.org, eggert@cs.ucla.edu, kdudka@redhat.com Received: via spool by 33287-submit@debbugs.gnu.org id=B33287.154154724923927 (code B ref 33287); Tue, 06 Nov 2018 23:35:01 +0000 Received: (at 33287) by debbugs.gnu.org; 6 Nov 2018 23:34:09 +0000 Received: from localhost ([127.0.0.1]:37954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKArJ-0006Dr-E9 for submit@debbugs.gnu.org; Tue, 06 Nov 2018 18:34:09 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:50439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKArH-0006Dd-Oo for 33287@debbugs.gnu.org; Tue, 06 Nov 2018 18:34:08 -0500 Received: from [192.168.101.10] ([91.12.166.119]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N49Ul-1fL1cw1pGz-0107Q3; Wed, 07 Nov 2018 00:33:47 +0100 Received: from [192.168.101.10] ([91.12.166.119]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N49Ul-1fL1cw1pGz-0107Q3; Wed, 07 Nov 2018 00:33:47 +0100 References: <20181106120224.21566-1-kdudka@redhat.com> <89968cd2-0a3e-b70f-11ca-f2382fb55b89@cs.ucla.edu> From: Bernhard Voelker Openpgp: preference=signencrypt Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= xsBNBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAHNK0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT7CwHkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BzsBNBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAHCwF8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: <62a1aaf8-da38-9e31-5636-ac6a87a49962@bernhard-voelker.de> Date: Wed, 7 Nov 2018 00:33:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <89968cd2-0a3e-b70f-11ca-f2382fb55b89@cs.ucla.edu> Content-Type: multipart/mixed; boundary="------------E738BF67C2A122EF27F2F6C4" Content-Language: en-US X-Provags-ID: V03:K1:nGBAEqWqMLH8nfvJehLjh0BrL2HyDDFEBC/3iYGgmTZn+xwVilt YIMK2IZA1Dmc1MM4mEIrt7M+fNltjOIfWCir3tVrSAvBefvTur2/uXbHmxidwHnSNSRjpKX +vgC7wSZgO/NVSSFZiKaAL/2mQUb0+B6Rrt9HwarLLaobg12tR+NWQh0qqeaDDiPGf7G6eZ BakkFWqFJUJb2FPU2wGZw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:zjHSBkc30vM=:goC8xqeLO9WGzoPDg1vmuW Scbxb6lnMweBdprT+VYRq//NAG3ILQ/AkYdf9jpvQEltjz5WPRfuez70hiqdnrvMKpjVBzThV RAWrViYJV/1RWW9k79xN0fc9HwWUYhkwlh7fZd11j9FlrRxBks6jEFwu9ZFPkXBWCih+ei4FG jYov28xEltYerLMxnZzRwUuLz1nz8UpIOVazl5uBtMlLAnVPFDx1HvCAFOfv0CHtfkIKwBsty 7FUuRRBkDv73AAazRfDPXIvpytpLeV7ZmLD3CE9WAWctihnfwGFo4kHKW4vHf4vqmCuJIlx9X McPAp2Nv8BiPsbraL3leN8wOep4YNHFvGG32ag8xSRbriRNDYQorImp7CcpLcr6DWRST1idLT U+Cx2l9Zo6lmt4X6oLf/kP6Ro0e01NK2Vm/WwjAPj+13JUQU2uR1tdrBL8xquWwrO86xVX+xQ EVIOa0d8SvdxcJIXHxxJtLTcIPsre5ZgnOggxlZc8WoXjVLh6Kne6rvritb/XThe0OOpyVRuB B5S/j3PaTFZ2BuMKDSDd9cfVG8k5TdWmh7vRY8YkRWNyPcrAwy3NhKHo1nNMjZ3U5Eho+etOP +fVMXZHjp4lbxWjVaEWwNTxpw27CVvYvT/l6Hp+pItob7M/rpjPUvlPJY0wDzD15T8MM23hVz kTRLFfWpcpzCUnaksJwod/dO3E8HuCdd3Xfqsw4YnWzFNmeyoy8yOWsSWuXCLWB9P2HLdwE0e nhw3/kQtsDwSgjSQknvBDuSJqp5yRkxVL8iBqm3o3DQePaWyvbkEMxZthLOdHGcGLoPwgKabP JySw6wZHB1ij+82CsHsaNZEXrUsnQ== X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------E738BF67C2A122EF27F2F6C4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 11/6/18 7:35 PM, Paul Eggert wrote: > Thanks, I installed that and am closing the bug report. That was a real bug, i.e., not only a resource leak, wasn't it? If the calling user has -r+w permissions on the file, then sync previously exited with 1 without actually syncing: $ install -m 0200 /dev/null /tmp/file $ ls -log /tmp/file --w------- 1 0 Nov 7 00:06 /tmp/file $ strace -v /usr/bin/sync /tmp/file 2>&1 | tail -n6 openat(AT_FDCWD, "/tmp/file", O_RDONLY|O_NONBLOCK) = -1 EACCES (Permission denied) openat(AT_FDCWD, "/tmp/file", O_WRONLY|O_NONBLOCK) = 3 close(1) = 0 close(2) = 0 exit_group(1) = ? +++ exited with 1 +++ With the patch, fsync is called, and sync terminated with success: $ strace -v src/sync /tmp/file 2>&1 | tail openat(AT_FDCWD, "/tmp/file", O_RDONLY|O_NONBLOCK) = -1 EACCES (Permission denied) openat(AT_FDCWD, "/tmp/file", O_WRONLY|O_NONBLOCK) = 3 fcntl(3, F_GETFL) = 0x8801 (flags O_WRONLY|O_NONBLOCK|O_LARGEFILE) fcntl(3, F_SETFL, O_WRONLY|O_LARGEFILE) = 0 fsync(3) = 0 close(3) = 0 close(1) = 0 close(2) = 0 exit_group(0) = ? +++ exited with 0 +++ Should we add a NEWS entry and a test - see attached? Thanks & have a nice day, Berny --------------E738BF67C2A122EF27F2F6C4 Content-Type: text/x-patch; name="0001-sync-add-NEWS-and-test-for-the-fix-in-the-previous-c.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-sync-add-NEWS-and-test-for-the-fix-in-the-previous-c.pa"; filename*1="tch" =46rom 90679f499b71f2432a7faa439bc7a9155e7bee9c Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 7 Nov 2018 00:26:01 +0100 Subject: [PATCH] sync: add NEWS and test for the fix in the previous comm= it * NEWS (Bug fixes): Mention the fix in commit 94d364f157f0. While at it, remove duplicate "Changes in behavior" heading. * tests/misc/sync.sh: Add a test with a write-only file for the fix. --- NEWS | 5 +++-- tests/misc/sync.sh | 7 ++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 088810fe8..8c1283549 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,9 @@ GNU coreutils NEWS -= *- outline -*- df no longer corrupts displayed multibyte characters on macOS. [bug introduced with coreutils-8.18] =20 + sync no longer fails for write-only file arguments. + [bug introduced with argument support to sync in coreutils-8.24] + ** Changes in behavior =20 echo now always processes backslash escapes when the POSIXLY_CORRECT @@ -22,8 +25,6 @@ GNU coreutils NEWS -= *- outline -*- approach is still used in situations where hard links to directories are allowed (e.g., NetBSD when superuser). =20 -** Changes in behavior - 'test -a FILE' is not supported anymore. Long ago, there were concern= s about the high probability of humans confusing the -a primary with the -a bi= nary operator, so POSIX changed this to 'test -e FILE'. Scripts using it w= ere diff --git a/tests/misc/sync.sh b/tests/misc/sync.sh index f60d28c5a..3bb6e179e 100755 --- a/tests/misc/sync.sh +++ b/tests/misc/sync.sh @@ -19,7 +19,7 @@ . "${srcdir=3D.}/tests/init.sh"; path_prepend_ ./src print_ver_ sync =20 -touch file +touch file || framework_failure_ =20 # fdatasync+syncfs is nonsensical returns_ 1 sync --data --file-system || fail=3D1 @@ -30,6 +30,11 @@ returns_ 1 sync -d || fail=3D1 # Test syncing of file (fsync) (little side effects) sync file || fail=3D1 =20 +# Test syncing of write-only file - which failed since adding argument +# support to sync in coreutils-8.24. +chmod 0200 file || framework_failure_ +sync file || fail=3D1 + # Ensure multiple args are processed and diagnosed returns_ 1 sync file nofile || fail=3D1 =20 --=20 2.19.1 --------------E738BF67C2A122EF27F2F6C4-- From unknown Thu Sep 11 17:28:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33287: [PATCH] sync: add missing brackets in sync_arg() Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 07 Nov 2018 01:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33287 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Bernhard Voelker , 33287@debbugs.gnu.org, kdudka@redhat.com Received: via spool by 33287-submit@debbugs.gnu.org id=B33287.154155257632028 (code B ref 33287); Wed, 07 Nov 2018 01:03:02 +0000 Received: (at 33287) by debbugs.gnu.org; 7 Nov 2018 01:02:56 +0000 Received: from localhost ([127.0.0.1]:37972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKCFE-0008KW-DU for submit@debbugs.gnu.org; Tue, 06 Nov 2018 20:02:56 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKCFC-0008KG-ED for 33287@debbugs.gnu.org; Tue, 06 Nov 2018 20:02:55 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8576416012E; Tue, 6 Nov 2018 17:02:48 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SOpi_Q2J9j0h; Tue, 6 Nov 2018 17:02:47 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D2A8D160184; Tue, 6 Nov 2018 17:02:47 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mLSwgMzzWIB3; Tue, 6 Nov 2018 17:02:47 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B9DA916012E; Tue, 6 Nov 2018 17:02:47 -0800 (PST) References: <20181106120224.21566-1-kdudka@redhat.com> <89968cd2-0a3e-b70f-11ca-f2382fb55b89@cs.ucla.edu> <62a1aaf8-da38-9e31-5636-ac6a87a49962@bernhard-voelker.de> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <41c229fe-68ca-6397-a8cb-5d6522e8ccff@cs.ucla.edu> Date: Tue, 6 Nov 2018 17:02:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <62a1aaf8-da38-9e31-5636-ac6a87a49962@bernhard-voelker.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 11/6/18 3:33 PM, Bernhard Voelker wrote: > Should we add a NEWS entry and a test - see attached? Thanks, good point, and I installed that. From unknown Thu Sep 11 17:28:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33287: [PATCH] sync: add missing brackets in sync_arg() Resent-From: Kamil Dudka Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 07 Nov 2018 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33287 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Bernhard Voelker Cc: eggert@cs.ucla.edu, 33287@debbugs.gnu.org Received: via spool by 33287-submit@debbugs.gnu.org id=B33287.15415790538909 (code B ref 33287); Wed, 07 Nov 2018 08:25:01 +0000 Received: (at 33287) by debbugs.gnu.org; 7 Nov 2018 08:24:13 +0000 Received: from localhost ([127.0.0.1]:38074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKJ8G-0002Jd-QI for submit@debbugs.gnu.org; Wed, 07 Nov 2018 03:24:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKJ8D-0002JM-0P for 33287@debbugs.gnu.org; Wed, 07 Nov 2018 03:24:11 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF743308FF0D; Wed, 7 Nov 2018 08:24:02 +0000 (UTC) Received: from kdudka-nb.localnet (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FC425C886; Wed, 7 Nov 2018 08:24:00 +0000 (UTC) From: Kamil Dudka Date: Wed, 07 Nov 2018 09:24:38 +0100 Message-ID: <2098449.nmVPbzlmZO@kdudka-nb> In-Reply-To: <62a1aaf8-da38-9e31-5636-ac6a87a49962@bernhard-voelker.de> References: <20181106120224.21566-1-kdudka@redhat.com> <89968cd2-0a3e-b70f-11ca-f2382fb55b89@cs.ucla.edu> <62a1aaf8-da38-9e31-5636-ac6a87a49962@bernhard-voelker.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 07 Nov 2018 08:24:03 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) On Wednesday, November 7, 2018 12:33:45 AM CET Bernhard Voelker wrote: > On 11/6/18 7:35 PM, Paul Eggert wrote: > > Thanks, I installed that and am closing the bug report. > > That was a real bug, i.e., not only a resource leak, wasn't it? > > If the calling user has -r+w permissions on the file, then sync previously > exited with 1 without actually syncing: > > $ install -m 0200 /dev/null /tmp/file > > $ ls -log /tmp/file > --w------- 1 0 Nov 7 00:06 /tmp/file > > $ strace -v /usr/bin/sync /tmp/file 2>&1 | tail -n6 > openat(AT_FDCWD, "/tmp/file", O_RDONLY|O_NONBLOCK) = -1 EACCES (Permission > denied) openat(AT_FDCWD, "/tmp/file", O_WRONLY|O_NONBLOCK) = 3 > close(1) = 0 > close(2) = 0 > exit_group(1) = ? > +++ exited with 1 +++ > > With the patch, fsync is called, and sync terminated with success: > > $ strace -v src/sync /tmp/file 2>&1 | tail > openat(AT_FDCWD, "/tmp/file", O_RDONLY|O_NONBLOCK) = -1 EACCES (Permission > denied) openat(AT_FDCWD, "/tmp/file", O_WRONLY|O_NONBLOCK) = 3 > fcntl(3, F_GETFL) = 0x8801 (flags > O_WRONLY|O_NONBLOCK|O_LARGEFILE) fcntl(3, F_SETFL, O_WRONLY|O_LARGEFILE) = > 0 > fsync(3) = 0 > close(3) = 0 > close(1) = 0 > close(2) = 0 > exit_group(0) = ? > +++ exited with 0 +++ > > Should we add a NEWS entry and a test - see attached? Looks good. Thanks for the follow-up patch! Kamil > Thanks & have a nice day, > Berny