Subject: bug#33267: closed (Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 06 Nov 2018 02:32:02 +0000

Your bug report

#33267: [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
33267: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33267
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.
From: Maxim Cournoyer <[email-masked]>
To: [email-masked]
Date: Mon, 05 Nov 2018 21:30:57 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Closing.

Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.
From: Maxim Cournoyer <[email-masked]>
To: guix-patches <[email-masked]>
Date: Mon, 05 Nov 2018 00:16:39 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi!

The following small issue caught my eye while I was reading the code.

Maxim

>From dd6d3ee8bec3a99fd178a8efddfa417fbed72a66 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <[email-masked]>
Date: Mon, 5 Nov 2018 00:01:47 -0500
Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of
 connect-to-remote-daemon.

* guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variable to
the `open-connection' call so that it is honored.
---
 guix/ssh.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/ssh.scm b/guix/ssh.scm
index da20d4d8d..25ec8295e 100644
--- a/guix/ssh.scm
+++ b/guix/ssh.scm
@@ -161,7 +161,7 @@ Throw an error on failure."
                                     "/var/guix/daemon-socket/socket"))
   "Connect to the remote build daemon listening on SOCKET-NAME over SESSION,
 an SSH session.  Return a <nix-server> object."
-  (open-connection #:port (remote-daemon-channel session)))
+  (open-connection #:port (remote-daemon-channel session socket-name)))

 (define (store-import-channel session)
-- 
2.19.0