From unknown Mon Aug 18 09:08:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Nov 2018 05:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33267 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33267@debbugs.gnu.org X-Debbugs-Original-To: guix-patches Received: via spool by submit@debbugs.gnu.org id=B.154139501713258 (code B ref -1); Mon, 05 Nov 2018 05:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Nov 2018 05:16:57 +0000 Received: from localhost ([127.0.0.1]:34506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJXFx-0003Rm-G4 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJXFv-0003RY-M6 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJXFp-0004Hs-Rz for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37826) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gJXFp-0004Hf-OC for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJXFo-0002l9-Ti for guix-patches@gnu.org; Mon, 05 Nov 2018 00:16:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJXFl-0004Gj-OI for guix-patches@gnu.org; Mon, 05 Nov 2018 00:16:48 -0500 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]:38986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJXFl-0004Ez-H6 for guix-patches@gnu.org; Mon, 05 Nov 2018 00:16:45 -0500 Received: by mail-io1-xd43.google.com with SMTP id n11-v6so5595020iob.6 for ; Sun, 04 Nov 2018 21:16:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=bb7mec6tTXhiaM2s475G8J2b0NI2VYSCH3hy/yNOUfo=; b=UtgrntF7sExz1tV2q7aeYlhAc0VV/3cySwi4W7mKlyX2BsFMjSFIYk+TGY8AfIne/R jqw8O7RW7OLKpijZ6Jn5APwICNgPs/39Y3eBG0ZaMQdhqjN54hr01wZuCVEC2GKmeOjo Ll4LeoH7W8vlHKiH/5uPF4x1XQNiH/4SAjckwLsuFJYErJqfLX9I3N9BWXLyzgHlaonr NUdaAZ/4f+1CpkG450SMA3BEBozfnxH1CwjKNUixghr8TkUr5CTM2lKoEAu8VXYjARnk FCzjmBXo9PhYk3yZbs6HPNrjo17jzggGI1pflqhzF/HWs90+oPHpMZ8vKkCFcI6OhMWg KIJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=bb7mec6tTXhiaM2s475G8J2b0NI2VYSCH3hy/yNOUfo=; b=gewA7XCNeiUQUYDoHFU4xrjO+q/rcpn4ZZR4Jt0knBFQIef8s4jQkwzwFrv1a8jIu0 xoQ7KSeGV6+rmlIxoFtAaNkYc5GWttFeMmHhXlUNooCY53cWGpz51wF57ZsoxK3iTgDQ LAiJREftEZr4CcpZFQkNoCp2k15wheBxfB76wKrZyktBxr0+olHjigBSRwYlTrhuO3TO h0D2AfqvtUmHb0KMmHkEjxXlQgSfhjGyo15P8bLbZhl4MDffq4gccGkglYZ6oDx3eBar j0iKuHgjYviNsaXQRE9PIti1NJawZO6fQwAklOaiNuEr5sYiVZ4j1CQXxVbMALfB3Dl+ d9CA== X-Gm-Message-State: AGRZ1gJuIviRTXLJ+aTthEtkYFlKGev+A3yXljmiG2sTJGAr+oO30TMm sc215QyLu+bgrMGRZSAy4JCfIyHe X-Google-Smtp-Source: AJdET5d0wdwjHWNBl2SEikIBRxfA+Zopq8oZ9QrkrtH4ICreEthceulpWoeBGBw4iHRx6njpySEdpw== X-Received: by 2002:a6b:4014:: with SMTP id k20-v6mr7262190ioa.277.1541395002067; Sun, 04 Nov 2018 21:16:42 -0800 (PST) Received: from apteryx (76-10-140-126.dsl.teksavvy.com. [76.10.140.126]) by smtp.gmail.com with ESMTPSA id m9-v6sm13830449ioc.29.2018.11.04.21.16.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Nov 2018 21:16:41 -0800 (PST) From: Maxim Cournoyer Date: Mon, 05 Nov 2018 00:16:39 -0500 Message-ID: <875zxc5cjs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hi! The following small issue caught my eye while I was reading the code. Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-ssh-Honor-the-SOCKET-NAME-argument-of-connect-to-rem.patch >From dd6d3ee8bec3a99fd178a8efddfa417fbed72a66 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Mon, 5 Nov 2018 00:01:47 -0500 Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. * guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variable to the `open-connection' call so that it is honored. --- guix/ssh.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/ssh.scm b/guix/ssh.scm index da20d4d8d..25ec8295e 100644 --- a/guix/ssh.scm +++ b/guix/ssh.scm @@ -161,7 +161,7 @@ Throw an error on failure." "/var/guix/daemon-socket/socket")) "Connect to the remote build daemon listening on SOCKET-NAME over SESSION, an SSH session. Return a object." - (open-connection #:port (remote-daemon-channel session))) + (open-connection #:port (remote-daemon-channel session socket-name))) (define (store-import-channel session) -- 2.19.0 --=-=-=-- From unknown Mon Aug 18 09:08:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Nov 2018 20:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33267 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 33267@debbugs.gnu.org Received: via spool by 33267-submit@debbugs.gnu.org id=B33267.154145081210787 (code B ref 33267); Mon, 05 Nov 2018 20:47:01 +0000 Received: (at 33267) by debbugs.gnu.org; 5 Nov 2018 20:46:52 +0000 Received: from localhost ([127.0.0.1]:35704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJllr-0002nu-RK for submit@debbugs.gnu.org; Mon, 05 Nov 2018 15:46:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJllo-0002ng-Mo for 33267@debbugs.gnu.org; Mon, 05 Nov 2018 15:46:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJlli-0000Y9-GZ for 33267@debbugs.gnu.org; Mon, 05 Nov 2018 15:46:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJllg-0000WT-Gz; Mon, 05 Nov 2018 15:46:42 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55240 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gJllg-000237-1j; Mon, 05 Nov 2018 15:46:40 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <875zxc5cjs.fsf@gmail.com> Date: Mon, 05 Nov 2018 21:46:38 +0100 In-Reply-To: <875zxc5cjs.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 05 Nov 2018 00:16:39 -0500") Message-ID: <87o9b3xnf5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Maxim, Maxim Cournoyer skribis: >>>From dd6d3ee8bec3a99fd178a8efddfa417fbed72a66 Mon Sep 17 00:00:00 2001 > From: Maxim Cournoyer > Date: Mon, 5 Nov 2018 00:01:47 -0500 > Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of > connect-to-remote-daemon. > > * guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variabl= e to > the `open-connection' call so that it is honored. Good catch! LGTM. Thanks, Ludo=E2=80=99. From unknown Mon Aug 18 09:08:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Nov 2018 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33267 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 33267@debbugs.gnu.org Received: via spool by 33267-submit@debbugs.gnu.org id=B33267.154147143118572 (code B ref 33267); Tue, 06 Nov 2018 02:31:02 +0000 Received: (at 33267) by debbugs.gnu.org; 6 Nov 2018 02:30:31 +0000 Received: from localhost ([127.0.0.1]:35882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJr8R-0004pT-21 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 21:30:31 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:35741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJr8P-0004pH-Qe for 33267@debbugs.gnu.org; Mon, 05 Nov 2018 21:30:30 -0500 Received: by mail-it1-f196.google.com with SMTP id v11so9564346itj.0 for <33267@debbugs.gnu.org>; Mon, 05 Nov 2018 18:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=qDxojGOmBYFxhtTQKKesQdwjp3DVTQbvlNSK5jTkuEA=; b=sh1RnV37VKaRsnes2bJvKiUmyWbTY41e2GzfK+QI0wVDgy4+2u5Hy7CShoC8xisXHb /3cQpPhouc9yU64l46oQPc/FPXrqudADLIq7EVs4LVmn8t3q0qNVLlf3HXceUehpaBz7 OJy7vtFFQQI/5x/34+LsdnBJ15bqUF0K6YQciJ6w2sYtthZHz7s1VZqSH+nzBEl2RYW2 B7gRn0ojihIB7WvLezXRAU1j5iR0dExop+1H45Jy5Zy32EVnFDRlp1R93aDA94dJFDe5 3f8tKcsg0azqq+ixUjqLLHrDIKBumLuyEdlvbaQqsNDpMlnA2LFO/f5KK9bYJDGoaC/V rNOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qDxojGOmBYFxhtTQKKesQdwjp3DVTQbvlNSK5jTkuEA=; b=MgPvnQZWnsAIw/mGYMkRR74oYhtygB0lMt7mPxfflQkIbaJ+evOXzJ3840SrrdsMGD POkvRwxPoEI8b/WMILzcPY892QRo6LpsbCbO9B6LuHt7wCiYhzQwaxRwAszaiGwrQJBn 9Y1cAIM104mmuCbRm8womsjSb5Flr3idQDXy+lRBKfvHk+FYvaIx8G1wSK3LN/CgWE0v e4iMmc/h+idyqpTpFc4xLTEzwp442GDm7W7RQpl3g8Mfsml0vDW5S+Jtpq6U5Rff0n81 vCN9MLRiByK99sX6pnztDXX0NM0wsI5li3gGEtk4poemKxqhzu6B6TG8Zj/tDVVYEULN sKcg== X-Gm-Message-State: AGRZ1gIinmUH9rG6M6zYhJ54Ha/bFBYwqH0KNAlYgL1WxbsfZtAtN6Vw x71+BV+NqZRp/Zx3ukiqXttdeG3n X-Google-Smtp-Source: AJdET5d3IiYdkdpGSj35PXs4wNumSq+aYdvhi/jml+lA1N4ZTLg4XUhsn2widfy+mr/rsi/QeWoLcw== X-Received: by 2002:a24:bc47:: with SMTP id n68-v6mr591278ite.102.1541471423571; Mon, 05 Nov 2018 18:30:23 -0800 (PST) Received: from apteryx (76-10-140-126.dsl.teksavvy.com. [76.10.140.126]) by smtp.gmail.com with ESMTPSA id w26-v6sm9614048ioc.0.2018.11.05.18.30.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Nov 2018 18:30:22 -0800 (PST) From: Maxim Cournoyer References: <875zxc5cjs.fsf@gmail.com> <87o9b3xnf5.fsf@gnu.org> Date: Mon, 05 Nov 2018 21:30:21 -0500 In-Reply-To: <87o9b3xnf5.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 05 Nov 2018 21:46:38 +0100") Message-ID: <87bm733pky.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >> * guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variab= le to >> the `open-connection' call so that it is honored. > > Good catch! LGTM. Pushed as 2e4d83398. Thanks! Maxim From unknown Mon Aug 18 09:08:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Maxim Cournoyer Subject: bug#33267: closed (Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.) Message-ID: References: <877ehr3pjy.fsf@gmail.com> <875zxc5cjs.fsf@gmail.com> X-Gnu-PR-Message: they-closed 33267 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 33267@debbugs.gnu.org Date: Tue, 06 Nov 2018 02:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1541471522-18721-1" This is a multi-part message in MIME format... ------------=_1541471522-18721-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33267: [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-da= emon. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33267@debbugs.gnu.org. --=20 33267: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33267 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1541471522-18721-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33267-done) by debbugs.gnu.org; 6 Nov 2018 02:31:06 +0000 Received: from localhost ([127.0.0.1]:35886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJr90-0004qp-B3 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 21:31:06 -0500 Received: from mail-it1-f177.google.com ([209.85.166.177]:39449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJr8z-0004qD-1z for 33267-done@debbugs.gnu.org; Mon, 05 Nov 2018 21:31:05 -0500 Received: by mail-it1-f177.google.com with SMTP id m15so15695088itl.4 for <33267-done@debbugs.gnu.org>; Mon, 05 Nov 2018 18:31:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=lHZ9a+XiV5epK7xMYM6DNSvfPlei7cSv9nKUpTAkcrw=; b=rk8bLTOR/8mbUjXp13hdTu4kHkDRYXw0wUu+VvYJ6UIbU6RHWbHN5NCtBOTzurPMS0 C6OLpdukx7ekTpjRjd6eNYVqBoVHwkpEfRJIBouvoAvRbTzYWFh5MBevHMz+EYPDaLum poyi2s1IM10TpdG70xmlcK+UVKzHkfAJu8KYyjVEJpcHsspjshy4i9erhW4xO3yesyeu eWCZPuHwsCDobeSgtkhoDcZrl2cs75o4pjhAOe5xvDkLMVJ6MQukoJLLXZXtkzIQSeES keY3jp+3DjeFlx5N9/SbZztMf1dhUcFrpjfwets1T1fR9wgEfk1WPeaoeHCF8KwulrO2 0/vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lHZ9a+XiV5epK7xMYM6DNSvfPlei7cSv9nKUpTAkcrw=; b=PWn9UVUp8H8dd5XE0z34Ihp/EdzMeC7qnvjd8wx5XkUYTp+ToDyojpN/FC8LGuCPN7 f3oqEjG31ZRCPxSHuIywXXHYrJ+AY4JDV4kankQXiZTNmE0YA/ypniCkGt4b2DTUi2Po uLLCH+ykBJBaCnfu1gm9y9domky+AZ+V/tgCltZdN61BfIFUKrOq1qq09RjZOzwbdZIM XHktzK3Z6E42rVxFlGFqcoMFg/z57XCvtprv5jZAcm9GxzwQIBDZm0dkcPr0E8Gu8tr/ IxMjdX1jpwZJZqp2XMnHs+xW915YrkDsoBmpANg3NXvB/wfXjJ3dgPT3WarGgzAcDd9X IcmQ== X-Gm-Message-State: AGRZ1gJqf7pNfzmgVmwEF8zIeHlR8XuncevM4LAxwGAl9MGUd3vHrHP3 5TL/BEF172WW2CFJ92DfFMlym229 X-Google-Smtp-Source: AJdET5daHucxY03qI+ODDQIpzd58cTb48MP5xNClCMzKR36NFcmKxnM1U9ALlMJqjufyIJB5rb9yKw== X-Received: by 2002:a24:1d97:: with SMTP id 145-v6mr584229itj.14.1541471459306; Mon, 05 Nov 2018 18:30:59 -0800 (PST) Received: from apteryx (76-10-140-126.dsl.teksavvy.com. [76.10.140.126]) by smtp.gmail.com with ESMTPSA id x6-v6sm270042itg.15.2018.11.05.18.30.58 for <33267-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Nov 2018 18:30:58 -0800 (PST) From: Maxim Cournoyer To: 33267-done@debbugs.gnu.org Subject: Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. References: <875zxc5cjs.fsf@gmail.com> <87o9b3xnf5.fsf@gnu.org> Date: Mon, 05 Nov 2018 21:30:57 -0500 In-Reply-To: <87o9b3xnf5.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 05 Nov 2018 21:46:38 +0100") Message-ID: <877ehr3pjy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 33267-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Closing. ------------=_1541471522-18721-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Nov 2018 05:16:57 +0000 Received: from localhost ([127.0.0.1]:34506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJXFx-0003Rm-G4 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJXFv-0003RY-M6 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJXFp-0004Hs-Rz for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37826) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gJXFp-0004Hf-OC for submit@debbugs.gnu.org; Mon, 05 Nov 2018 00:16:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJXFo-0002l9-Ti for guix-patches@gnu.org; Mon, 05 Nov 2018 00:16:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJXFl-0004Gj-OI for guix-patches@gnu.org; Mon, 05 Nov 2018 00:16:48 -0500 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]:38986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJXFl-0004Ez-H6 for guix-patches@gnu.org; Mon, 05 Nov 2018 00:16:45 -0500 Received: by mail-io1-xd43.google.com with SMTP id n11-v6so5595020iob.6 for ; Sun, 04 Nov 2018 21:16:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=bb7mec6tTXhiaM2s475G8J2b0NI2VYSCH3hy/yNOUfo=; b=UtgrntF7sExz1tV2q7aeYlhAc0VV/3cySwi4W7mKlyX2BsFMjSFIYk+TGY8AfIne/R jqw8O7RW7OLKpijZ6Jn5APwICNgPs/39Y3eBG0ZaMQdhqjN54hr01wZuCVEC2GKmeOjo Ll4LeoH7W8vlHKiH/5uPF4x1XQNiH/4SAjckwLsuFJYErJqfLX9I3N9BWXLyzgHlaonr NUdaAZ/4f+1CpkG450SMA3BEBozfnxH1CwjKNUixghr8TkUr5CTM2lKoEAu8VXYjARnk FCzjmBXo9PhYk3yZbs6HPNrjo17jzggGI1pflqhzF/HWs90+oPHpMZ8vKkCFcI6OhMWg KIJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=bb7mec6tTXhiaM2s475G8J2b0NI2VYSCH3hy/yNOUfo=; b=gewA7XCNeiUQUYDoHFU4xrjO+q/rcpn4ZZR4Jt0knBFQIef8s4jQkwzwFrv1a8jIu0 xoQ7KSeGV6+rmlIxoFtAaNkYc5GWttFeMmHhXlUNooCY53cWGpz51wF57ZsoxK3iTgDQ LAiJREftEZr4CcpZFQkNoCp2k15wheBxfB76wKrZyktBxr0+olHjigBSRwYlTrhuO3TO h0D2AfqvtUmHb0KMmHkEjxXlQgSfhjGyo15P8bLbZhl4MDffq4gccGkglYZ6oDx3eBar j0iKuHgjYviNsaXQRE9PIti1NJawZO6fQwAklOaiNuEr5sYiVZ4j1CQXxVbMALfB3Dl+ d9CA== X-Gm-Message-State: AGRZ1gJuIviRTXLJ+aTthEtkYFlKGev+A3yXljmiG2sTJGAr+oO30TMm sc215QyLu+bgrMGRZSAy4JCfIyHe X-Google-Smtp-Source: AJdET5d0wdwjHWNBl2SEikIBRxfA+Zopq8oZ9QrkrtH4ICreEthceulpWoeBGBw4iHRx6njpySEdpw== X-Received: by 2002:a6b:4014:: with SMTP id k20-v6mr7262190ioa.277.1541395002067; Sun, 04 Nov 2018 21:16:42 -0800 (PST) Received: from apteryx (76-10-140-126.dsl.teksavvy.com. [76.10.140.126]) by smtp.gmail.com with ESMTPSA id m9-v6sm13830449ioc.29.2018.11.04.21.16.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Nov 2018 21:16:41 -0800 (PST) From: Maxim Cournoyer To: guix-patches Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. Date: Mon, 05 Nov 2018 00:16:39 -0500 Message-ID: <875zxc5cjs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hi! The following small issue caught my eye while I was reading the code. Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-ssh-Honor-the-SOCKET-NAME-argument-of-connect-to-rem.patch >From dd6d3ee8bec3a99fd178a8efddfa417fbed72a66 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Mon, 5 Nov 2018 00:01:47 -0500 Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon. * guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variable to the `open-connection' call so that it is honored. --- guix/ssh.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/ssh.scm b/guix/ssh.scm index da20d4d8d..25ec8295e 100644 --- a/guix/ssh.scm +++ b/guix/ssh.scm @@ -161,7 +161,7 @@ Throw an error on failure." "/var/guix/daemon-socket/socket")) "Connect to the remote build daemon listening on SOCKET-NAME over SESSION, an SSH session. Return a object." - (open-connection #:port (remote-daemon-channel session))) + (open-connection #:port (remote-daemon-channel session socket-name))) (define (store-import-channel session) -- 2.19.0 --=-=-=-- ------------=_1541471522-18721-1--