GNU bug report logs - #33267
[PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33267 in the body.
You can then email your comments to 33267 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of
 connect-to-remote-daemon.
Date: Mon, 05 Nov 2018 00:16:39 -0500

[Message part 1 (text/plain, inline)]

Hi!

The following small issue caught my eye while I was reading the code.

Maxim

[0001-ssh-Honor-the-SOCKET-NAME-argument-of-connect-to-rem.patch (text/x-patch, attachment)]

Message #8 received at 33267 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 33267 <at> debbugs.gnu.org
Subject: Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of
 connect-to-remote-daemon.
Date: Mon, 05 Nov 2018 21:46:38 +0100

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

>>From dd6d3ee8bec3a99fd178a8efddfa417fbed72a66 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Mon, 5 Nov 2018 00:01:47 -0500
> Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of
>  connect-to-remote-daemon.
>
> * guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variable to
> the `open-connection' call so that it is honored.

Good catch!  LGTM.

Thanks,
Ludo’.

Message #11 received at 33267 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 33267 <at> debbugs.gnu.org
Subject: Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of
 connect-to-remote-daemon.
Date: Mon, 05 Nov 2018 21:30:21 -0500

ludo <at> gnu.org (Ludovic Courtès) writes:

[...]

>> * guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variable to
>> the `open-connection' call so that it is honored.
>
> Good catch!  LGTM.

Pushed as 2e4d83398. Thanks!

Maxim

Message #16 received at 33267-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 33267-done <at> debbugs.gnu.org
Subject: Re: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of
 connect-to-remote-daemon.
Date: Mon, 05 Nov 2018 21:30:57 -0500

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.