GNU bug report logs - #33263
27.0.50; Tidying up Gnus modes

Previous Next

Package: emacs;

Reported by: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Date: Mon, 5 Nov 2018 02:55:02 UTC

Severity: wishlist

Found in version 27.0.50

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 33263 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 33263 <at> debbugs.gnu.org
Subject: Re: bug#33263: 27.0.50; Tidying up Gnus modes
Date: Mon, 05 Nov 2018 09:14:25 -0500

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> +(defvar gnus-browse-mode-map (make-keymap))
>  
>  (unless gnus-browse-mode-map
> -  (setq gnus-browse-mode-map (make-keymap))
> +  (defvar gnus-browse-mode-map (make-keymap))

This doesn't look right.

> -(defun gnus-summary-mode (&optional group)
> +(define-derived-mode gnus-summary-mode gnus-mode "Summary"
>    "Major mode for reading articles.

> -      (gnus-summary-mode group)
> +      (setq gnus-newsgroup-name group)
> +      (gnus-summary-mode)
>        (when (gnus-group-quit-config group)

Where does GROUP come from now?
This bug report was last modified 6 years and 264 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.