GNU bug report logs - #33263
27.0.50; Tidying up Gnus modes

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Subject: bug#33263: closed (Re: bug#33263: 27.0.50; Tidying up Gnus modes)
Date: Fri, 23 Nov 2018 17:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#33263: 27.0.50; Tidying up Gnus modes

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 33263 <at> debbugs.gnu.org.

-- 
33263: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33263
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: 33263-done <at> debbugs.gnu.org
Subject: Re: bug#33263: 27.0.50; Tidying up Gnus modes
Date: Fri, 23 Nov 2018 09:45:24 -0800

Okay, I've been running this for more than a week and it seems fine so
far. I'll push it, and watch for repercussions.

[Message part 3 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Tidying up Gnus modes
Date: Sun, 04 Nov 2018 18:53:41 -0800

[Message part 4 (text/plain, inline)]

The attached patch does a couple of things to clean up Gnus's various
major modes:

- Creates a do-nothing `gnus-mode', derived from `special-mode', to
  serve as parent mode for all the other major modes. This isn't so
  important, but sometimes it would be nice to do (derived-mode-p
  'gnus-mode).
- Derives everything from `gnus-mode', and turns a couple of modes from
  functions that manually set up modes into proper calls to
  `define-derived-mode'.
- Removes code like "(setq buffer-read-only t)", as that's automatically
  done by `special-mode'.
- Where appropriate, deletes custom definitions for gnus-*-mode-hook, as
  these hooks are already automatically created by the define-mode
  calls. (Maybe this removal isn't worth doing?)

This patch probably needs more testing, but I'm floating it first for
any comments.

Eric

In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.1)
 of 2018-10-31 built on slip

[0001-Provide-new-gnus-mode-derive-all-gnus-major-modes-fr.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.