GNU bug report logs - #33263
27.0.50; Tidying up Gnus modes

Previous Next

Full log

Message #26 received at 33263 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: 33263 <at> debbugs.gnu.org
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#33263: 27.0.50;
 Tidying up Gnus modes, [PATCH] Provide new gnus-mode, derive all gnus
 major modes from this
Date: Fri, 09 Nov 2018 23:01:46 -0500

[Message part 1 (text/plain, inline)]

[forwarding to list]

[Message part 2 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#33263: 27.0.50; Tidying up Gnus modes
Date: Fri, 09 Nov 2018 12:54:53 -0800

[Message part 3 (text/plain, inline)]

Here's a new version of the patch. I fixed the keymap thing, and looked
carefully at the code called from `gnus-summary-mode'.

`turn-on-mailing-list-mode' clearly belongs in
`gnus-summary-setup-buffer', so I moved it up there. The format spec and
mark position stuff doesn't vary depending on the group, but I have
dreams of a day when it will, so I moved that up, too.

I added more docs and comments making the separation of concerns clear:
`gnus-summary-setup-buffer' handles group-dependent setup,
`gnus-summary-mode' handles group-independent stuff. That's also the
motivation for moving the three `make-local-variables', which would
otherwise be a pointless change.

I hope this is acceptable (I'm cc'ing Lars in case he has an opinion).
I'll run it locally for a week or so, then push to master.

Eric

[0001-Provide-new-gnus-mode-derive-all-gnus-major-modes-fr.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.