GNU bug report logs - #33263
27.0.50; Tidying up Gnus modes

Previous Next

Full log

Message #20 received at 33263 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 33263 <at> debbugs.gnu.org
Subject: Re: bug#33263: 27.0.50; Tidying up Gnus modes
Date: Tue, 6 Nov 2018 11:28:17 -0500

On Tue, 6 Nov 2018 at 11:22, Eric Abrahamsen <eric <at> ericabrahamsen.net> wrote:

> >>>> +(defvar gnus-browse-mode-map (make-keymap))
> >>>>
> >>>>  (unless gnus-browse-mode-map
> >>>> -  (setq gnus-browse-mode-map (make-keymap))
> >>>> +  (defvar gnus-browse-mode-map (make-keymap))

> Right, I got that much, I was mostly wondering why the `unless' -- it's
> unlikely these files would be loaded multiple times, and even if they
> were, that wouldn't break anything, would it?

Without the `unless', if the user had made changes to
gnus-browse-mode-map they would be lost upon reload (as you say, it's
not especially likely to happen, but I guess the original author
wanted to preserve the semantics of the single defvar form).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.