GNU bug report logs - #33259
[PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more tests

Previous Next

Full log

Message #67 received at 33259-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 33259-done <at> debbugs.gnu.org
Subject: Re: [bug#33259] [PATCH 4/8] pack: Docker backend now honors
 '--localstatedir'.
Date: Tue, 06 Nov 2018 23:23:51 +0100

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>
>>> diff --git a/tests/pack.scm b/tests/pack.scm
>>> index 6bd18bdee2..e8d4f9f18d 100644
>>> --- a/tests/pack.scm
>>> +++ b/tests/pack.scm
>>> @@ -22,6 +22,7 @@
>>>    #:use-module (guix store)
>>>    #:use-module (guix derivations)
>>>    #:use-module (guix profiles)
>>
>>> +  #:use-module (guix packages)                    ;XXX: debugging
>>
>> Is this still needed?
>
> Oops, I don’t think so.  I’ll fix it before pushing.

Well it was actually needed so I just removed the comment.

Pushed, thanks for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.