GNU bug report logs - #33259
[PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more tests

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Sun, 4 Nov 2018 22:03:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more
 tests
Date: Sun,  4 Nov 2018 23:01:30 +0100
Hello Guix!

These patches ensure ‘--localstatedir’ is properly handled by the
Docker and Squashfs backends of ‘guix pack’ (until now they ignored
this option.)

They also add ‘guix pack’ tests, which were severely lacking until now,
including a ‘guix pack -R’ test using the user’s store.  While doing
that, I also fixed a bug whereby ‘guix pack’ tarballs would contain
writable directories (whereas normally every file in the store is
read-only.)

Feedback welcome!

Ludo’.

Ludovic Courtès (8):
  pack: Move store database creation to a separate derivation.
  pack: Import (guix store database) only when '--localstatedir' is
    passed.
  install: Add 'install-database-and-gc-roots'.
  pack: Docker backend now honors '--localstatedir'.
  pack: Squashfs backend now honors '--localstatedir'.
  pack: Add test for 'self-contained-tarball' with localstatedir.
  store-copy: Canonicalize the mtime and permissions of the store copy.
  pack: Add test for '--relocatable'.

 Makefile.am                    |   1 +
 gnu/build/install.scm          |  77 ++++---
 gnu/build/vm.scm               |  19 +-
 guix/build/store-copy.scm      |  28 +++
 guix/docker.scm                |  16 +-
 guix/scripts/pack.scm          | 379 +++++++++++++++++++--------------
 tests/guix-pack-relocatable.sh |  61 ++++++
 tests/guix-pack.sh             |  28 +--
 tests/pack.scm                 | 156 ++++++++++++--
 9 files changed, 525 insertions(+), 240 deletions(-)
 create mode 100644 tests/guix-pack-relocatable.sh

-- 
2.19.1





This bug report was last modified 6 years and 282 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.