GNU bug report logs - #33259
[PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more tests

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33259 <at> debbugs.gnu.org
Subject: [bug#33259] [PATCH 1/8] pack: Move store database creation to a separate derivation.
Date: Tue, 6 Nov 2018 11:48:08 +0100

[Message part 1 (text/plain, inline)]

Hi Ludo,

On Sun,  4 Nov 2018 23:10:29 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> +  (when database
> +    (install-file database (scope "/var/guix/db/"))
> +    (chmod (scope "/var/guix/db/db.sqlite") #o644)

Hmm, is it guaranteed that the basename of DATABASE is "db.sqlite" ?
Sounds a little magical.

> +  (define database
>      (and localstatedir?
> -         (local-file (search-path %load-path
> -                                  "guix/store/schema.sql"))))
> +         (file-append (store-database (list profile))
> +                      "/db/db.sqlite")))

Ah okay.

Otherwise LGTM!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.